D8276: [SideBar] enable LayoutMirroring for RTL

[Elkana Bardugo]

ttv20 added a comment.


  I think I've because I'm translator

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8276

To: ttv20, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 383614] KCM opened from tray icon has wrong icon under Wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=383614

--- Comment #1 from Dr. Chapatin  ---
Same on Arch, plasma 5.11.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8232: Add option to center shadow

[rodrigo pelorosso]

rpelorosso added a comment.


  In https://phabricator.kde.org/D8232#155503, @ngraham wrote:
  
  > Check out the large centered shadows in ElementaryOS. They're goregeous:
  >
  > F5430019: photos.jpg 
  
  
  They look amazing!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8232: Add option to center shadow

[rodrigo pelorosso]

rpelorosso added a comment.


  In https://phabricator.kde.org/D8232#155519, @alake wrote:
  
  > Ok, I agree now that there shouldn't be an option. I think it is fair to 
say that the contrast on the left side of overlapping windows could be 
improved. The proposed compromise solution actually looks decent too and it 
keeps the lighting reasonably consistent. The VDG and Hugo are discussing. Oh 
and in case it is sometimes forgotten, thanks for submitting the patch. :-)
  
  
  Thank you! :)  In case centered shadows aren't going to be an option, as it 
seems it's going to be the case, I'll go back to my idea of creating a patch 
for oxygen to allow changing the alpha of the shadow. I think, with that in 
place, I'll be able to configure shadows to look the way I want.  I won't have 
the energy to patch breeze myself every time a new version is out.
  
  Thank you! :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8232: Add option to center shadow

[rodrigo pelorosso]

rpelorosso added a comment.


  I didn't want to stop mentioning that, unless I'm missing something, it looks 
like breeze *window* shadows are not taking into consideration the Screen 
Scaling settings, so basically they don't scale if that value is incremented, 
making the shadows look small in 4k screens with screen scaling.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Andrew Lake]

alake added a comment.


  Ok, I agree now that there shouldn't be an option. I think it is fair to say 
that the contrast on the left side of overlapping windows could be improved. 
The proposed compromise solution actually looks decent too and it keeps the 
lighting reasonably consistent. The VDG and Hugo are discussing. Oh and in case 
it is sometimes forgotten, thanks for submitting the patch. :-)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D8232#155503, @ngraham wrote:
  
  > Check out the large centered shadows in ElementaryOS. They're goregeous..
  
  
  The thing is that they arent totally centered. They are centered at x but 
they have a small y offset, it gives the feeling that the shadow is going down.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8302: Add FreeBSD port from the development-repo

[Tobias C . Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, mvourlakos.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - FreeBSD now has a port for this in k...@freebsd.org's development repo.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8302

AFFECTED FILES
  README.md

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8232: Add option to center shadow

[Nathaniel Graham]

ngraham added a comment.


  Check out the large centered shadows in ElementaryOS. They're goregeous:
  
  F5430019: photos.jpg 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8285: Unload poller's connection thread earlier in teardown

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R130:e27d843cc320: Unload pollers connection thread 
earlier in teardown (authored by davidedmundson).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8285?vs=20710=20764

REVISION DETAIL
  https://phabricator.kde.org/D8285

AFFECTED FILES
  src/idletime/poller.cpp
  src/idletime/poller.h

To: davidedmundson, graesslin
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8232: Add option to center shadow

[Alessandro Longo]

alex-l added a comment.


  Absolutely +1, I was waiting for this option since Plasma 5 was launched. I 
suggest to make it default, I can't really get why the shadow should be on the 
right.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D8232#155473, @alake wrote:
  
  > +1 for the centered shadow proposal as an option.
  >
  > I'd hesitate for this to be the default since to do it well, in my opinion, 
it'd take a complete lighting (re)design effort on Breeze to help ensure 
visually consistency.
  
  
  If it has to be an option, and if it can bring inconsistency in the theme, 
then honestly I would rather see it as an "aurorae" theme than a breeze hack.
  If it goes to breeze (whether as an option, which I would disfavor, or as the 
default), it has to go as a complete relightning , with consistency across 
menus, combobox drop down, and buttons. 
  We do not want to ship a default theme that is inherently inconsistent, 
whether in its default configuration mode or when tweeking any random options.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Andrew Lake]

alake added a comment.


  +1 for the centered shadow proposal as an option.
  
  I'd hesitate for this to be the default since to do it well, in my opinion, 
it'd take a complete lighting (re)design effort on Breeze to help ensure 
visually consistency.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D8232: Add option to center shadow

[rodrigo pelorosso]

rpelorosso added a comment.


  In https://phabricator.kde.org/D8232#155436, @ngraham wrote:
  
  > I completely agree, @rkflx. For just this reason, 10 years ago Apple 
changed the window shadows to be super super gigantic: 
https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/
  >
  > It was a bit controversial at first, but eventually people really liked it 
for exactly the reason you indicate: it provided a great sense of depth. I 
always make Breeze shadows as huge as possible to try to emulate this. 
Programmer-types like us often underestimate just how hard it is for many 
people so know which window is in the active one. Anything we can do ti make it 
more obvious, without becoming garish, IMHO is worth it.
  
  
  Indeed, in fact, what I was meaning to achieve was exactly that effect. I 
like centered, big shadows, that allow me to differenciate widndows with small 
(or non-existant) borders easily while still being smooth. The proposed 
compromise may seem like a good idea, but the fact that the shadow is not 
horizontally balanced is, although subtle, still noticed, and gives me that 
"something is not right" feeling that's hard to shake off.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D8232#155450, @abetts wrote:
  
  > That's a cool idea. I would just try to make it smoother. The proposals 
still look pretty rough. I don't know programming, but can you tell me the 
current parameters to create the shadow with this patch? Blur, spread, color?
  
  
  sorry, to whom are you referring? which shadow from all presented?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Andres Betts]

abetts added a comment.


  That's a cool idea. I would just try to make it smoother. The proposals still 
look pretty rough. I don't know programming, but can you tell me the current 
parameters to create the shadow with this patch? Blur, spread, color?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D8232#155436, @ngraham wrote:
  
  > I completely agree, @rkflx. For just this reason, 10 years ago Apple 
changed the window shadows to be super super gigantic: 
https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/
  
  
  A huge shadow would look like this with my proposal:
  
  F5429843: screen_shadow_proposed_gigantic.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Nathaniel Graham]

ngraham added a comment.


  I completely agree, @rkflx. For just this reason, 10 years ago Apple changed 
the window shadows to be super super gigantic: 
https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/
  
  F5429828: leopard-window.png 
  
  It was a bit controversial at first, but eventually people really liked it 
for exactly the reason you indicate: it provided a great sense of depth. I 
always make Breeze shadows as huge as possible to try to emulate this. 
Programmer-types like us often underestimate just how hard it is for many 
people so know which window is in the active one. Anything we can do ti make it 
more obvious, without becoming garish, IMHO is worth it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D8232#155435, @hpereiradacosta wrote:
  
  > Can you explain in which situation/workflow these two screenshots are the 
only part of the screen that you see ?
  
  
  This is mainly on external displays with a lot of windows open, some 
maximized vertically. If you focus on parts of the screen (e.g. to read 
something in a particular column or use a toolbox), you do not look at the 
whole window. Imagine someone sitting close to the screen so he has to move his 
head to see the full screen. In this situation you do not see the complete 
shadow, but only some parts.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D8232#155433, @rkflx wrote:
  
  > Let me illustrate the problem I have with the current shadows. Imagine this 
situation:
  >
  > - Not a single window on a background to just look pretty, but a multitude 
of windows scattered all around to do actual work.
  > - Window switching by focus-follows-mouse, i.e. a workflow with a lot of 
overlapping and cascaded windows. Here it is very important from a usability 
standpoint to tell the windows apart and to get a sense of depth.
  >
  >   Do you know which window is in the front in the following screenshot? I 
cannot tell:
  >
  >   F5429808: left.png 
  >
  >   Here it is much easier:
  >
  >   F5429810: right.png 
  
  
  Can you explain in which situation/workflow these two screenshots are the 
only part of the screen that you see ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Henrik Fehlauer]

rkflx added a comment.


  Let me illustrate the problem I have with the current shadows. Imagine this 
situation:
  
  - Not a single window on a background to just look pretty, but a multitude of 
windows scattered all around to do actual work.
  - Window switching by focus-follows-mouse, i.e. a workflow with a lot of 
overlapping and cascaded windows.
  
  Here it is very important from a usability standpoint to tell the windows 
apart and to get a sense of depth.
  
  Do you know which window is in the front in the following screenshot? I 
cannot tell:
  
  F5429808: left.png 
  
  Here it is much easier:
  
  F5429810: right.png 
  
  And here is the full screenshot:
  
  F5429813: full.png 
  
  I think Plasma should support a diverse set of workflows, currently I do not 
feel it is optimal in every case.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Nathaniel Graham]

ngraham added a comment.


  FWIW, I gave some substantive, non-aesthetic reasons to at least center the 
shadow up-thread at https://phabricator.kde.org/D8232#155293

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Julian Wolff]

progwolff added a comment.


  I am on Michail's side.
  
  Having the shadow falling at the bottom right feels more natural to me. I 
also like the sharper edge at the left. Makes the overall look of the desktop a 
little cleaner.
  Actually, the clean look of breeze was the main reason why I finally switched 
to Linux. I tried Gnome and KDE4 before and was not satisfied by the overall 
look and feel, so I stayed with MS Windows. Breeze changed this.
  
  In my opinion, a decent shadow at the bottom right is enough to seperate 
application windows from each other.
  
  I however can understand that this is depending on personal preference. And 
by this I am against centering the shadow without an option.
  Either do this optionally (we already have several options here, another one 
won't hurt that much), or slightly reduce the offset like Michail proposed.
  
  In https://phabricator.kde.org/D8232#155278, @hpereiradacosta wrote:
  
  > 1/ this is a decision VDG should make
  
  
  Totally aggree. If the falling shadow was a concious choice, then the reasons 
for this decision should be discussed here. Are they documented somewhere?
  
  > 3/ I don't think this should be an option. The change is too small (and 
implies too much code complexity, once 2/ is fullifille) for being controled by 
an option
  
  I think you might underestimate the impact of this change. The overall feel 
of the system will change with this.
  Also, I am not sure if it is really that complex to have an option for 
centering the shadows.
  
  > On the other hand we must then be prepared to people complaining when the 
change is introduced, and have a good story for justifying the change (rather 
than just : because I think it looks better).
  
  Definitely. And thus it would be great if we could find some reasons why

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D8232#155402, @mvourlakos wrote:
  
  > Proposed:
  >  F5429752: screen_shadow_proposed.png 
  
  
  This compromise would work really well for me.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Michail Vourlakos]

mvourlakos added a comment.


  my previous screenshot was to show you the problem with the current 
implementation not to suggest new defaults...
  
  in order to demonstrate you the best in my liking I will give you two 
screenshots using the current breeze defaults.
  The first one is the default current breeze shadow, the second is my liking 
which has been produced by reducing the offset
  to half and changing line #643 of breezedecoration.cpp to:
  
const int shadowOffset = qMax( 3*g_shadowSize/16, 
2*Metrics::Shadow_Overlap/2 );
  
  Current:
  F5429749: screen_shadow_current.png 
  
  Proposed:
  F5429752: screen_shadow_proposed.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Nathaniel Graham]

ngraham added a comment.


  > ! In https://phabricator.kde.org/D8232#155370, @rpelorosso wrote:
  >  For me, the screenshot you present just feels unbalanced, and trying to 
focus on the window content makes me feel dizzy.
  
  +1, me too.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8284: Don't duplicate connect to wl_display_flush

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f48b796c74d5: Dont duplicate connect to 
wl_display_flush (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8284?vs=20708=20744

REVISION DETAIL
  https://phabricator.kde.org/D8284

AFFECTED FILES
  src/client/connection_thread.cpp
  src/client/connection_thread.h

To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8232: Add option to center shadow

[rodrigo pelorosso]

rpelorosso added a comment.


  In https://phabricator.kde.org/D8232#155278, @hpereiradacosta wrote:
  
  > 4/ note that oxygen has centered shadows everywhere (decoration, menus and 
buttons).
  
  
  That's true, but Oxygen shadows suffer from a different issue, as they seem 
to blend in an odd way. For example, say you want a light shadow. In order to 
achieve this effect you need to change the inner color to a light gray. This 
works fine over lighter backgrounds, but over a darker background the shadow 
becomes a gray glow, as seen here:
  
  F5429686: image.png 
  
  This could be fixed by adding an option to change the shadow's alpha, so that 
a light shadow can be created with a small alpha and setting black as inner 
color. At first I thought about creating a patch to allow this in Oxygen, but I 
really like Breeze so I decided to try with this patch we're discussing now.
  
  In https://phabricator.kde.org/D8232#155305, @mvourlakos wrote:
  
  > I tried my best at the following screenshot to show a good top and left 
shadow, that was the best I could do.
  >  The settings for size and strength are: 57px.  -  37%  take into account 
that I am in a hidpi screen.
  
  
  I tried at first playing with the parameters, but I couldn't come up with a 
good result. For me, the screenshot you present just feels unbalanced, and 
trying to focus on the window content makes me feel dizzy.
  
  As for shadows in menues and windows, I'm fine with the way they look now, 
but I wouldn't mind having centered shadows in menues as well.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Michail Vourlakos]

mvourlakos added a comment.


  Personally I like the feeling of the shadow falling at the bottom right.
  I just found it a bit too much.
  I think it must go a little more to the left and top but preserve the feeling 
that the shadow falls at bottom-right like the original designer thought it.
  
  I tried my best at the following screenshot to show a good top and left 
shadow, that was the best I could do.
  The settings for size and strength are: 57px.  -  37%  take into account that 
I am in a hidpi screen.
  The shadow size isnt that important because the offsets are calculated in 
proportion of the shadow size but
  the bigger the shadows the better can be observed the location of the shadow 
for the window.
  
  F5429611: windows_shadows.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Nathaniel Graham]

ngraham added a comment.


  I agree that this should be a change, not a new option. Personally, in 
addition to aesthetics, I like the change because it fixes the following visual 
glitches:
  
  - Having a small shadow on the left side looks like a visual bug when you 
tile windows to sides of the screen and make the right-most one active. There's 
almost no shadow, and it looks wrong.
  - When you take a screenshot of a window, shadows are included, so the 
resulting file looks (and is) unbalanced.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D8232#155232, @rkflx wrote:
  
  > FWIW, I would love this too. IMHO this should even be the default (but is 
obviously something for the https://phabricator.kde.org/tag/vdg/ to decide). 
Reasons:
  >
  > - The shadow not only adds a spatial dimension to the visuals, it also is 
important in separating the contents of cascaded windows. Currently, this 
second function is not achieved for the left and top borders.
  
  
  This is not true
  There is a shadow at the top and at the left. It is simply not as pronounced 
as the one at the bottom and the right. Also, the shadow strength (not its 
centering) is already configurable.
  
  > - It would be consistent with GNOME, Windows (all borders) and MacOS (all 
borders except the top).
  
  This is not a strong enough reason, imho
  
  > Patch LGTM.
  > 
  > However, I noticed a small inconsistency (probably just food for thought 
and not something for this patch): Shadows of menus do not respect this, they 
are still offset. While that's the behaviour on Windows too, on MacOS menus 
have shadows on all three borders.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi,
  Thanks for the patch.
  Few comments (on the functionality, not yet on the code)
  
  1/ this is a decision VDG should make (Thomas Pfeiffer ?): when I first wrote 
the code for breeze we discussed this possibility to have the shadow centered 
(as well as left oriented) but it was rejected. The right oriented shadow being 
a concious choice of the main breeze designer at the time, Andrew Lake
  
  2/ if the option is added it must be applied consistently everywhere. This 
includes (as already noticed): menu and combobox shadows, but also buttons 
shadows. This requires changes to breeze::style as well as breeze::decoration.
  The shadow code for menu and comboboxes is 'similar' to that of the 
decorations. The button shadow is somewhat different, but ...
  
  3/ I don't think this should be an option. The change is too small (and 
implies too much code complexity, once 2/ is fullifille) for being controled by 
an option, and doesn't bring/remove anything functionality wise, instead of eye 
candy. This would be like adding an option on how many pixels are used to round 
corners at the top of the window decoration. Bottom line one should choose one 
design or the other, it is not worth it to keep both. On the other hand we must 
then be prepared to people complaining when the change is introduced, and have 
a good story for justifying the change (rather than just : because I think it 
looks better).
  
  4/ note that oxygen has centered shadows everywhere (decoration, menus and 
buttons).
  
  Comments welcome
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8284: Don't duplicate connect to wl_display_flush

[Martin Flöser]

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  Ahhh. That's of course tricky to spot in this change ;-)

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8284

To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8285: Unload poller's connection thread earlier in teardown

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8285

To: davidedmundson, graesslin
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8284: Don't duplicate connect to wl_display_flush

[David Edmundson]

davidedmundson added a comment.


  The other ctor has a connect in the body.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8284

To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8287: Default X font DPI to 96 on wayland

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8287

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8284: Don't duplicate connect to wl_display_flush

[Martin Flöser]

graesslin added a comment.


  I don't see in the change what you describe. This seems to be just a 
refactoring.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8284

To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8232: Add option to center shadow

[Henrik Fehlauer]

rkflx added a reviewer: hpereiradacosta.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: qqc2-desktop-style as framework

[Volker Krause]

On Thursday, 31 August 2017 17:06:46 CEST Marco Martin wrote:
> Hi all,
> we have a qtquickcontrols style that is right now in workspace (unrelased,
> to be released with Plasma 5.11)
> it makes controls paint with qstyle to give it a reasonable desktop
> appearance, plus some fixes/workarounds to make qml a bit more desktop
> friendly (for instance fixes scrollwheel issues with Flickable)
> sice it's pretty much untenable to make a desktop application with
> QtQuickControls2 without it and make it look anything near "native", so
> releasing it together plasma is probably not enough.
> Applications using kirigami should be able to explicitly depend from it if
> they want, to require a native-looking look and feel on linux desktops (even
> on gnome would look already marginally better than with the stock
> "universal" or "material" styles)
> 
> it's a thing with no api, no libraries (not even an import, qqc2 styles work
> a bit differently), so as with kirigami only source compatibility on the
> qml- side will matter
> 
> any objection into pulling it into a framework? anything particular for the
> procedure?

Observations while trying to add this to the KF5 Yocto recipes:
- it shows up as Tier 1 on https://api.kde.org/frameworks/index.html but seems 
to have a hard dependency on Kirigami
- it seems to be licensed LGPLv3 + GPLv2, which doesn't match what https://
community.kde.org/Policies/Licensing_Policy says about KF5 code (see item 4).

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

D8232: Add option to center shadow

[Henrik Fehlauer]

rkflx set the repository for this revision to R31 Breeze.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg
Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

[Henrik Fehlauer]

rkflx added a comment.


  FWIW, I would love this too. IMHO this should even be the default (but is 
obviously something for the https://phabricator.kde.org/tag/vdg/ to decide). 
Reasons:
  
  - The shadow not only adds a spatial dimension to the visuals, it also is 
important in separating the contents of cascaded windows. Currently, this 
second function is not achieved for the left and top borders.
  - It would be consistent with GNOME, Windows (all borders) and MacOS (all 
borders except the top).
  
  Patch LGTM.
  
  However, I noticed a small inconsistency (probably just food for thought and 
not something for this patch): Shadows of menus do not respect this, they are 
still offset. While that's the behaviour on Windows too, on MacOS menus have 
shadows on all three borders.

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg
Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8291: correct Settings.isMobile usage

[Jan Mulder]

janmulder created this revision.
janmulder added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Settings.isMobile is in the Kirigami import.
  
  Signed-off-by: Jan Mulder 

TEST PLAN
  Check that the error in the console "Settings.isMobile" is not defined is 
gone.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8291

AFFECTED FILES
  src/controls/Page.qml

To: janmulder, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8286: Port away from PlasmaCore.Units in system settings modules

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> main.qml:28
>  Item {
>  implicitWidth: units.gridUnit * 20
>  implicitHeight: units.gridUnit * 20

Should be using `Units.gridUnit`, no?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8286

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D8260: [LauncherTasksModel] Try resolving absolute path to applications: URL before adding launcher

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Same as the other patch:
  menuId is autogenerated from the filename, so why go via KService to find 
something we already know?
  
  But it's the same as that other patch. Submit this so things work, and we can 
let eike optimise afterwards.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8260

To: broulik, #plasma, hein, ngraham, mvourlakos, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8287: Default X font DPI to 96 on wayland

[David Edmundson]

davidedmundson added a comment.


  Weirdly I didn't need this before, it defaulted to this if unset.
  I updated today and now do. Something must have either changed in QtXCB or 
Xwayland.
  
  Can't immediately see what though...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8287

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8287: Default X font DPI to 96 on wayland

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As otherwise we duplicate wayland scaling.
  
  Possibly not needed when we support xdg-output, as then xwayland will
  get the corrected post-scaling resolution.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8287

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8260: [LauncherTasksModel] Try resolving absolute path to applications: URL before adding launcher

[Michail Vourlakos]

mvourlakos added a comment.


  I can confirm that this fixes the drag n dropped launchers behavior

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8260

To: broulik, #plasma, hein, ngraham, mvourlakos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8286: Port away from PlasmaCore.Units in system settings modules

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As Kirigrami has it's own version.
  
  We want to be moving towards not having any Plasma imports in KCM code.
  (except for theme previews)

TEST PLAN
  Opened all 3 KCMs listed
  They looked pretty much identical

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8286

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8266: Fix QFile::copy warning when the colors file doesn't exist

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df6658eee5c6: Fix QFile::copy warning when the colors 
file doesnt exist (authored by dfaure).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8266?vs=20647=20711

REVISION DETAIL
  https://phabricator.kde.org/D8266

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: dfaure, mart, davidedmundson
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart