Re: Missing mouse pointer in KWin on Wayland with Etnaviv

2017-10-30 Thread Bhushan Shah 
Hey Matthias,

On Tue, Oct 31, 2017 at 02:56:20AM +0100, Matthias Klumpp wrote:
> Also, did you know that you get screen artifacts and "stripes" as soon
> as you run kwin_wayland as root and not as regular user? ;-)

No, as it is unsupported workflow.. don't expect fixes for that :-P

> Anyway, the only real issue is panels vanishing in the mobile shell
> (apparently a known issue and soon resolved) and KWin not showing any
> mouse pointer (as well as - to be expected - performance currently).

About panel issue, the issue is at first start-up the plasmashell
crashed and configuration was corrupted, can you try deleting
~/.config/plasma* files? and restart shell?

About mouse though I've no ideas, mgraesslin or d_ed might have ideas

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

2017-10-30 Thread Nathaniel Graham 
ngraham added a comment.


  What's next for this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8562: Use standard Ok/Cancel buttons for the connection removal dialog

2017-10-30 Thread Nathaniel Graham 
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
ngraham added reviewers: Plasma, jgrulich.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D8562

To: ngraham, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Missing mouse pointer in KWin on Wayland with Etnaviv

2017-10-30 Thread Matthias Klumpp 
Hello!

The past weekend I made Plasma Mobile work on our preliminary
"devboard" for the Purism Librem 5 phone (which at the moment is not
much more than a i.mx6 CPU with peripherals/a screen - it will be much
more exciting soon).

The system is running Debian Testing (Buster) with KDE libraries found
there (Plasma 5.10.5 (KWin 5.10.5), KF 5.37.0, ...) and Plasma Mobile
Git master. With some fiddling and Bhushan's help I got it to work.
The only real obstacle was Debian's really outdated version of
libepoxy, which made KWin not detect the OpenGL ES features (to be
fixed soonish in Debian).
Also, did you know that you get screen artifacts and "stripes" as soon
as you run kwin_wayland as root and not as regular user? ;-)

Anyway, the only real issue is panels vanishing in the mobile shell
(apparently a known issue and soon resolved) and KWin not showing any
mouse pointer (as well as - to be expected - performance currently).

For a phone we obviously don't need a mouse pointer, but at the moment
I can only interact with the UI by clicking blindly, which is not
ideal for testing. So, do you have an idea on what might be wrong
here?
(The logs I know of don't show anything related to this issue). If
this is a real bug and not a configuration mistake, I'll file a bug.

Anyway, there will be a blogpost about this soon, with pretty pictures
I hope ;-)

I also think we should get Plasma Mobile into Debian as soon as
possible. For that we'd (ideally) need a release tarball. I talked to
Bhushan about this, and he is preparing something.

Cheers,
Matthias

D5381: Add brightness control using ddcutil lib

2017-10-30 Thread Dorian Vogel 
dvogel updated this revision to Diff 21592.
dvogel added a comment.


  Reworked for simplification.

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5381?vs=14856=21592

REVISION DETAIL
  https://phabricator.kde.org/D5381

AFFECTED FILES
  CMakeLists.txt
  daemon/backends/upower/ddcutilbrightness.cpp
  daemon/backends/upower/ddcutilbrightness.h

To: dvogel, broulik, davidedmundson
Cc: strobach, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8561: [d_ptr] Do not harsh destroy QThread

2017-10-30 Thread David Edmundson 
davidedmundson added a comment.


  Wouldn't it be cleaner to put the quit in:
  
  Resources::Private::~Private 
  and/or ResourceScoreMaintainer::Private::~Private
  
  (also I have no idea what the Resource thread is for, literally the only 
thing it does actually in the thread is sleep)

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D8561

To: anthonyfieroni, #plasma, davidedmundson, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8561: [d_ptr] Do not harsh destroy QThread

2017-10-30 Thread David Edmundson 
davidedmundson added a reviewer: ivan.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D8561

To: anthonyfieroni, #plasma, davidedmundson, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8561: [d_ptr] Do not harsh destroy QThread

2017-10-30 Thread Anthony Fieroni 
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  systemd makes coredumps in /var/lib/systemd/coredumps when 
kactivitymanagerd_plugin_sqlite.so quits
  
coredumpctl list
coredumpctl gdb PID
(gdb) bt
#0  0x6d63f0d0513f in raise () from /lib/libc.so.6
#1  0x6d63f0d0656a in abort () from /lib/libc.so.6
#2  0x6d63f148792e in QMessageLogger::fatal(char const*, ...) const ()
   from /usr/lib/libQt5Core.so.5
#3  0x6d63f14991bc in QThread::~QThread() () from 
/usr/lib/libQt5Core.so.5
#4  0x6d63d17c6c8a in ?? ()
   from 
/usr/lib/qt5/plugins/kactivitymanagerd/1/kactivitymanagerd_plugin_sqlite.so
#5  0x6d63f0d07a80 in __run_exit_handlers () from /lib/libc.so.6
#6  0x6d63f0d07ada in exit () from /lib/libc.so.6
#7  0x6d63f2dd5e75 in QXcbConnection::processXcbEvents() ()
---Type  to continue, or q  to quit---
   from /usr/lib/qt5/plugins/platforms/../../../libQt5XcbQpa.so.5
#8  0x6d63f1699141 in QObject::event(QEvent*) () from 
/usr/lib/libQt5Core.so.5

TEST PLAN
  Try to nice quit a thread

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D8561

AFFECTED FILES
  src/utils/d_ptr_implementation.h

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme

2017-10-30 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=367696

Nate Graham  changed:

   What|Removed |Added

 CC||kain...@gmail.com,
   ||pointedst...@zoho.com
 Status|UNCONFIRMED |CONFIRMED
  Component|general |Icons
 Ever confirmed|0   |1

--- Comment #3 from Nate Graham  ---
Hmm, dark icons are just always going to have visibility issues with dark
themes. Breeze icon folks, would you be open to tweaking Konsole's icon to give
it a subtle light-colored outline?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8534: DictEngine: set a scheme for the URLs, otherwise webengine won't handle them

2017-10-30 Thread David Faure 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:208ad519efa8: DictEngine: set a scheme for the URLs, 
otherwise webengine wont handle them (authored by dfaure).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8534?vs=21496=21579

REVISION DETAIL
  https://phabricator.kde.org/D8534

AFFECTED FILES
  dataengines/dict/dictengine.cpp

To: dfaure, #plasma, davidedmundson, broulik, mart
Cc: ngraham, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8390: Don't re-align outputs when QMLOutput in clone mode moves

2017-10-30 Thread Daniel Vrátil 
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:baf36bc421b8: Dont re-align outputs when QMLOutput 
in clone mode moves (authored by dvratil).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8390?vs=21033=21576

REVISION DETAIL
  https://phabricator.kde.org/D8390

AFFECTED FILES
  kcm/src/declarative/qmlscreen.cpp

To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8391: Keep the unified QMLOutput always in center

2017-10-30 Thread Daniel Vrátil 
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:1a9164cdc7d1: Keep the unified QMLOutput always in center 
(authored by dvratil).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8391?vs=21034=21575

REVISION DETAIL
  https://phabricator.kde.org/D8391

AFFECTED FILES
  kcm/src/declarative/qmloutput.cpp

To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8526: add a background in ScrollView

2017-10-30 Thread Marco Martin 
mart added a comment.


  so, may be worth to have in kirigami a component called like ItemScrollView 
intended for this?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8526

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

2017-10-30 Thread Xuetian Weng 
xuetianweng added a comment.


  @mart I understand what you want to say, but for this specific case:
  
  
https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037
  
  rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done.
  
  And thus there's no signal that can be used for this function.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-30 Thread Marco Martin 
mart added a comment.


  as long qt and gtk will scale the same factor on dpi change, it should be good

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D8481

To: dos, #breeze, #plasma
Cc: mart, elvisangelaccio, ngraham, apol, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-30 Thread Marco Martin 
mart added a comment.


  scrollbars are smaller by purpose now, so no, not a bug

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D8481

To: dos, #breeze, #plasma
Cc: mart, elvisangelaccio, ngraham, apol, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D8529: Plasma change icons should exit after its work finished.

2017-10-30 Thread Marco Martin 
mart added a comment.


  hmm, i feel it would be more correct to connect to the procedure finished and 
then quit the app?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8529

To: xuetianweng, apol, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8534: DictEngine: set a scheme for the URLs, otherwise webengine won't handle them

2017-10-30 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8534

To: dfaure, #plasma, davidedmundson, broulik, mart
Cc: ngraham, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8504: Scaled decorations in QPainter mode

2017-10-30 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7e6721ece08a: Scaled decorations in QPainter mode 
(authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8504?vs=21398=21567

REVISION DETAIL
  https://phabricator.kde.org/D8504

AFFECTED FILES
  decorations/decorationrenderer.cpp
  plugins/scenes/qpainter/scene_qpainter.cpp

To: davidedmundson, #plasma, hetzenecker, graesslin
Cc: ngraham, graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8432: Use nullptr. Initialize pointer

2017-10-30 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:7c602a831f5d: Use nullptr. Initialize pointer (authored 
by mlaurent).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8432?vs=21172=21566

REVISION DETAIL
  https://phabricator.kde.org/D8432

AFFECTED FILES
  backends/xcbwrapper.cpp
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandroutput.cpp
  src/backendlauncher/backenddbuswrapper.h
  src/backendlauncher/backendloader.cpp
  src/backendlauncher/backendloader.h
  src/backendmanager.cpp
  src/config.cpp
  src/configmonitor.cpp
  src/doctor/doctor.h
  src/doctor/dpmsclient.h
  src/edid.h
  src/getconfigoperation.h
  src/mode.cpp
  src/setconfigoperation.h

To: mlaurent, davidedmundson, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8553: It's autotests not tests

2017-10-30 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:357bb3ab75c9: Its autotests not tests (authored by 
mlaurent).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8553?vs=21558=21565#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8553?vs=21558=21565

REVISION DETAIL
  https://phabricator.kde.org/D8553

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/foldermodeltest.h
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/autotests/positionertest.h
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h

To: mlaurent, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8390: Don't re-align outputs when QMLOutput in clone mode moves

2017-10-30 Thread Sebastian Kügler 
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.


  Please also merge into master.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8390

To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8391: Keep the unified QMLOutput always in center

2017-10-30 Thread Sebastian Kügler 
sebas added a comment.


  Please also merge into master.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8391

To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8391: Keep the unified QMLOutput always in center

2017-10-30 Thread Sebastian Kügler 
sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8391

To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8432: Use nullptr. Initialize pointer

2017-10-30 Thread Sebastian Kügler 
sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R110 KScreen Library

BRANCH
  use_nullptr

REVISION DETAIL
  https://phabricator.kde.org/D8432

To: mlaurent, davidedmundson, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Minutes Monday Plasma Hangout

2017-10-30 Thread Sebastian Kügler 
Meeting notes, fun as always. Enjoy the read!
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 4-9-2017

Present: fvogt, d_ed, romangg, Sho_, einar77_work, bshah, notmart, kbroulik, 
sebas

fvogt:
- I'm not quite sure what to do with ivan's request on the simplefavoritesmodel
- Neither with https://phabricator.kde.org/D8455
Diff 8455 "Fix DBus startup notification" [Closed] 
https://phabricator.kde.org/D8455 (Is the X-DBus-ServiceName even implemented 
by other DEs?)
- Any news on Qt 5.10 integration on the CI?
- https://bugs.kde.org/show_bug.cgi?id=382291#c22 seems to be broken still

d_ed:
Fixed wayland multiple screens where a screen has a y offset
Fixed glScissors calls on scaling (minimise animation now works nicely)
and added the wayland highDPI support for window decs (not merged that last one)

romangg:
reviewed patch from Xuetian Weng for refactoring of input (mouse) kcm. D8168 
was the original one.
Diff 8168 "kcm_input: Refactor the code and add support for libinput under X11" 
[Needs Review] https://phabricator.kde.org/D8168
-> now split up into several ones:
The first one D8456 has already landed. the next one is D8460
Diff 8456 "Port kcm input to UI File." [Closed] 
https://phabricator.kde.org/D8456
Diff 8460 "Refactor kcm_input to enable having multiple backends." [Needs 
Review] https://phabricator.kde.org/D8460
The goal is to have the mouse kcm work like the touchpad kcm, such that we can 
have fully functional libinput backends for X and Wayland.
Dived into reviewing the screen recording patches from Oleg.
some dev (Plagman) asked for a solution for his kvm issues this weekend. it's a 
very specific setup. but we need something like virtual screens in Wayland 
since xrandr not available anymore. created a task for now: T7331
Task 7331 "[kwin] Virtual screens" [Open,Low] {Plasma on Wayland} 
https://phabricator.kde.org/T7331
still need a review for my lib for night color: D5931 Martin reviewed the patch 
to KWin
Diff 5931 "ColorCorrect Library - for configuring KWin's native color 
correction (in particular Night Color)" [Needs Review] 
https://phabricator.kde.org/D5931


Sho:
* Fixed Simple Menu crashing when opening context menu for runner result items
** Planning 1.0.4 release this week
* Fixed Activity Pager not updating labels when activities are renamed, still 
in review
* Working on libtm URL chaos fix
* Set up official KDE community on Matrix and the sysadmin stuff around that
* Contributed QtWS postmortem on Phab (https://phabricator.kde.org/T7315
Task 7315 "Qt World Summit: Postmortem" [Open,Normal] { KDE Promo} 
https://phabricator.kde.org/T7315
* Off tomorrow, national holiday (but will actually spend it drafting the 2018 
KDE e.V. budget)

einar77_work:
testing Qt 5.10 with Plasma
so far a couple of regressions, but need to be investigated further (file 
dialog is the major offender)

bhsah:
- Audio fixes
- Figured out how audio works without droid module if device is using ALSA
- One need to use haskell based tool xml2ucm to convert android's 
mixter_paths.xml to ALSA ucm configuration or write it manually
- However sound quality by such ALSA driver is ... bad
- Investigated why pulseaudio crashes when loading droid-module
- Two different issues, droid-module is not compatible with new way of 
declaring audio_policy
- And it needed a two liner patch to fix the incompatibility with newer 
pulseaudio API
- Investigating the build system of pulseaudio-modules-droid to build it 
out-of-tree
- Overall have sound working locally, trying to fix the remaining packaging 
issues to actually ship it on phone
- dealt with massive spam in #halium channel last weekend
- I fixed brightness-gets-low-at-start bug on phone

notmart:
 * Fix Dialog component in qqc2-desktop-style, now actually loads and works
 * plasma mobile: fixed a bug in opening plasmoids from the top panel
This week, mostly KCMS redesign things:
 * KCM redesigns: back and forward with Andy Betts using the cursor theme one 
as prototype https://imgur.com/a/bL7w8
 * made a couple of basic components that can be reused across kcms
 * port of plasma mobile settings to kirigami
 * use a single shared qml engine for all kcms in the same process, solves a 
crash in plasma mobile settings: https://phabricator.kde.org/D8436
Diff 8436 "use a single QML engine" [Needs Review] 
https://phabricator.kde.org/D8436
 * loader for qml kcms in systemsettings/kcmshell: a big hack for keyboard 
navigation (QQuickWidget has tab key navigation not working at all) 
https://phabricator.kde.org/D8522
Diff 8522 "keyboard navigation in and out QML kcms" [Needs Review] 
https://phabricator.kde.org/D8522

kbroulik:
* Not much from me, did a bit of code reviewing
* Will add a menu button to notification thumbnails to make it more obvious 
that there's a menu

sebas:
- plasma mobile roadmap blog to finish and publish
- trying to get some time in to look into why kscreen config isn't properly 
restored on Wayland
- interview with

D8553: It's autotests not tests

2017-10-30 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rename_as_autotest

REVISION DETAIL
  https://phabricator.kde.org/D8553

To: mlaurent, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D5931: ColorCorrect Library - for configuring KWin's native color correction (in particular Night Color)

2017-10-30 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> geolocator.cpp:25
> +{
> +m_engine = dataEngine("geolocation");
> +

meh, I'd rather we didn't have to link the rather heavy Plasma from KDED.

I'm not going to make you change it, but in future hopefully we can just use 
the geo code directly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5931

To: subdiff, #plasma, davidedmundson
Cc: davidedmundson, HuShifang, leezu, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8553: It's autotests not tests

2017-10-30 Thread Laurent Montel 
mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8553

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8553: It's autotests not tests

2017-10-30 Thread Laurent Montel 
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  compile

REPOSITORY
  R119 Plasma Desktop

BRANCH
  rename_as_autotest

REVISION DETAIL
  https://phabricator.kde.org/D8553

AFFECTED FILES
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/foldermodeltest.h
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/autotests/positionertest.h
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.h
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/foldermodeltest.h
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-30 Thread Jay Turner 
jayturner added a comment.


  In https://phabricator.kde.org/D7747#161721, @broulik wrote:
  
  > What is "Elevensens" (I mean, how would a translator translate this)? 
Dict.cc says "Homo floresiensis" latin name for Hobbit, so perhaps we can 
deduce something for that, just trying to be careful here.
  
  
  Elevenses is a very unoriginal term for 'food at eleven' - actually used 
commonly in England.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D7747

To: jayturner, ngraham
Cc: broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-30 Thread Kai Uwe Broulik 
broulik added a comment.


  What is "Elevensens" (I mean, how would a translator translate this)? Dict.cc 
says "Homo floresiensis" latin name for Hobbit, so perhaps we can deduce 
something for that, just trying to be careful here.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D7747

To: jayturner, ngraham
Cc: broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8549: We use Q_DECL_OVERRIDE or override.

2017-10-30 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0adccf18e3d0: We use Q_DECL_OVERRIDE or override. 
(authored by mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8549?vs=21551=21553

REVISION DETAIL
  https://phabricator.kde.org/D8549

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.h
  containments/desktop/plugins/folder/itemviewadapter.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/wheelinterceptor.h

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8515: Don't loop twice here

2017-10-30 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a5e9be03fe6: Dont loop twice here (authored by 
mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8515?vs=21422=21552

REVISION DETAIL
  https://phabricator.kde.org/D8515

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/positioner.cpp

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8549: We use Q_DECL_OVERRIDE or override.

2017-10-30 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use_override

REVISION DETAIL
  https://phabricator.kde.org/D8549

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8549: We use Q_DECL_OVERRIDE or override.

2017-10-30 Thread Laurent Montel 
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  > use unique keyword override
  =

TEST PLAN
  compile

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use_override

REVISION DETAIL
  https://phabricator.kde.org/D8549

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.h
  containments/desktop/plugins/folder/itemviewadapter.h
  containments/desktop/plugins/folder/positioner.h
  containments/desktop/plugins/folder/wheelinterceptor.h

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8515: Don't loop twice here

2017-10-30 Thread Laurent Montel 
mlaurent added a comment.


  This one too ?:)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8515

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8516: Emit signal when we change PerStripe

2017-10-30 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bf0a2b81426e: Emit signal when we change PerStripe 
(authored by mlaurent).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8516?vs=21421=21550#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8516?vs=21421=21550

REVISION DETAIL
  https://phabricator.kde.org/D8516

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8517: Test enable status change and perStripe change

2017-10-30 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:27fb7629ce1d: Test enable status change and perStripe 
change (authored by mlaurent).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8517?vs=21426=21549

REVISION DETAIL
  https://phabricator.kde.org/D8517

AFFECTED FILES
  containments/desktop/plugins/folder/tests/CMakeLists.txt
  containments/desktop/plugins/folder/tests/foldermodeltest.cpp
  containments/desktop/plugins/folder/tests/positionertest.cpp
  containments/desktop/plugins/folder/tests/positionertest.h
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp
  containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h
  containments/desktop/plugins/folder/viewpropertiesmenu.h

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8516: Emit signal when we change PerStripe

2017-10-30 Thread Eike Hein 
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  One more newline after the emit line please, otherwise GTG.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_missing_emit_signal

REVISION DETAIL
  https://phabricator.kde.org/D8516

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8517: Test enable status change and perStripe change

2017-10-30 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add_more_autotest

REVISION DETAIL
  https://phabricator.kde.org/D8517

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7957: Turn on frames around dock widgets by default

2017-10-30 Thread Jens Reuterberg 
jensreuterberg added a comment.


  I would avoid the shadows personally - it would be better to focus on better 
spacing between the two areas and a clearer font usage to define them. Like 
Broulik mentions it was removed more or less by active choice

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7957

To: ngraham, #breeze, #vdg
Cc: jensreuterberg, abetts, broulik, emmanuelp, elvisangelaccio, nicolasfella, 
markg, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, sebas, 
apol, mart

D8516: Emit signal when we change PerStripe

2017-10-30 Thread Laurent Montel 
mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8516

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8517: Test enable status change and perStripe change

2017-10-30 Thread Laurent Montel 
mlaurent added a reviewer: hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8517

To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8524: Add a signal notifying a change in the names of running activities.

2017-10-30 Thread Eike Hein 
hein added a comment.


  In https://phabricator.kde.org/D8524#161438, @ivan wrote:
  
  > Also, not sure adding a signal that has one user only to a shared library 
is the best approach, especially since .h says this:
  >
  >   37  * @NOTE: This is a placeholder, to be moved into KActivities (which 
it 
  >   38  * wraps) or the Task Manager applet backend.
  >   
  >
  > But this is your call.
  
  
  I agree, but I already petitioned the upstream KActivities lib author for a 
less awkward API for this and failed, so I had to bite the bullet.

INLINE COMMENTS

> ivan wrote in activityinfo.cpp:52
> This screams `shared_ptr`, for example to a structure holding a consumer and 
> the model.

I'm not going to refactor this code considerably and risk more breakage for a 
minor fix, especially as this pattern is used elsewhere in the lib and was 
reviewed as such already.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8524

To: hein, #plasma
Cc: ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart