D10131: Expose more URLs relevant to the app
apol added inline comments.
INLINE COMMENTS
> ApplicationPage.qml:39
> +readonly property string donationURL: application.donationURL
> +readonly property string version: appInfo.application.isInstalled ?
> appInfo.application.installedVersion : appInfo.application.availableVersion
> +
Here actually we probably want to be a bit smarter. If it's updateable we
probably want to reflect it as well.
> ApplicationPage.qml:354
> +// "Make a Donation" row
> +QQC2.Label {
> +visible: donationURL.length > 0
How about:
QQC2.Label {
visible: donationButton.visible
Layout.alignment: Qt.AlignRight
text: i18n("Make a Donation:")
}
LinkButton {
id: donationButton
visible: text.length > 0
text: application.donationURL
onClicked: Qt.openUrlExternally(donationURL)
elide: Text.ElideRight
Layout.fillWidth: true
horizontalAlignment: Text.AlignLeft
}
This way we don't need to have random top-level properties for every single
thing.
Also note that referring to properties by name is considered expensive. So it
should have been `appInfo.donationURL)`.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10131
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
ngraham marked 3 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
ngraham updated this revision to Diff 26024. ngraham added a comment. - Don't create unnecessary stub functions - Don't unnecessarily re-define variables ApplicationPage.qml - Show all the new URLs by default (when available) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26023&id=26024 BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10131 AFFECTED FILES discover/qml/ApplicationPage.qml libdiscover/backends/DummyBackend/DummyResource.cpp libdiscover/backends/DummyBackend/DummyResource.h libdiscover/backends/FlatpakBackend/FlatpakResource.cpp libdiscover/backends/FlatpakBackend/FlatpakResource.h libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp libdiscover/backends/PackageKitBackend/AppPackageKitResource.h libdiscover/backends/SnapBackend/SnapResource.cpp libdiscover/backends/SnapBackend/SnapResource.h libdiscover/resources/AbstractResource.cpp libdiscover/resources/AbstractResource.h To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"
aacid added a comment. autotest possible? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: aacid, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
apol added inline comments. INLINE COMMENTS > ApplicationPage.qml:337 > +readonly property string helpURL: application.helpURL > +visible: helpURL.length > 0 > +text: helpURL No need to put it in a separte property. And specially don't add the exact same 2 properties! > ApplicationPage.qml:345 > } > } > it's missing the rest, no? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
apol added inline comments. INLINE COMMENTS > AbstractResource.h:134 > +///@returns a URL that points to the app's online documentation > +virtual QUrl helpURL() = 0; > +///@returns a URL that points to the place where you can file a bug Maybe they could return an empty url by default? This way they don't have to be implemented right away. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
ngraham added a comment. (for master, since it includes a string change) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10131: Expose more URLs relevant to the app
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Make the help, bug tracker, and donation URLs available to the backends. Also, expose the help URL on the Application page, so users can easily find the app's documentation. The other URLs will probably require a bit more UI design work to avoid overloading the metadata section, so I didn't expose them in the UI yet in this patch. TEST PLAN Tested in KDE Neon with apps available from multiple backends. Here's an example of how it looks with Krita: REPOSITORY R134 Discover Software Store BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10131 AFFECTED FILES discover/qml/ApplicationPage.qml libdiscover/backends/DummyBackend/DummyResource.cpp libdiscover/backends/DummyBackend/DummyResource.h libdiscover/backends/FlatpakBackend/FlatpakResource.cpp libdiscover/backends/FlatpakBackend/FlatpakResource.h libdiscover/backends/KNSBackend/KNSResource.cpp libdiscover/backends/KNSBackend/KNSResource.h libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp libdiscover/backends/PackageKitBackend/AppPackageKitResource.h libdiscover/backends/PackageKitBackend/PackageKitResource.cpp libdiscover/backends/PackageKitBackend/PackageKitResource.h libdiscover/backends/SnapBackend/SnapResource.cpp libdiscover/backends/SnapBackend/SnapResource.h libdiscover/resources/AbstractResource.h To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
bshah added subscribers: broulik, hein. bshah added a comment. In https://phabricator.kde.org/D10118#196581, @graesslin wrote: > I never had noticed any problems when compiling the code. Could it be that the CI system changed (e.g. newer compiler?) I would find it sad to lose this very useful feature (which might in fact not be exposed enough) This has been issue from forever.. see BUG: 362946 And for @hein and @broulik e.g this problem is so severe that it causes them to not able to compile plasma-desktop at all. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9070: KDE platform plugin: don't force default stylename on user-specified fonts
abetts added a comment. Is this change purely a conversation of what developers use in code to call up fonts in their applications? Or does this also include a discussion where regular users have interfaces that allow changes to font naming? Let's say, something like System Settings that would allow users to change the naming for system fonts? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D9070: KDE platform plugin: don't force default stylename on user-specified fonts
ngraham edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9070: KDE platform plugin: don't force default stylename on user-specified fonts
ngraham added a comment. Does anyone have strong objections to landing this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure Cc: anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
graesslin added a comment. I never had noticed any problems when compiling the code. Could it be that the CI system changed (e.g. newer compiler?) I would find it sad to lose this very useful feature (which might in fact not be exposed enough) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9638: [effects] replace old slide effect with a new one
zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'll try to build Plasma on my host. I hope `startplasmacompositor` will launch full Plasma session. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol
D9638: [effects] replace old slide effect with a new one
graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#196539, @zzag wrote: > If you know how to start wayland session, please let me know. Till then, I can't do too much (I'm familiar with effects part only). I cannot help you with the docker setup, but I can describe how I do my testing: export $(dbus-launch) cd build/kde/workspace/kwin/bin gdb --args ./kwin_wayland --socket wayland-1 Then from other konsole tab WAYLAND_DISPLAY=wayland-1 kwrite or any other application I want to try. For testing something like the effect I would probably launch qdbusviewer together with kwin_wayland and use it to switch desktops. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
D9325: Use QUrl in the ScreenMapper API
amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10111: [Klipper] Force plain text on the edit dialog
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:bac2ae0cd272: [Klipper] Force plain text on the edit dialog (authored by safaalfulaij). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10111?vs=25978&id=25984 REVISION DETAIL https://phabricator.kde.org/D10111 AFFECTED FILES klipper/klipper.cpp To: safaalfulaij, #plasma, mlaurent, broulik Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10079: Port baloo krunner plugin to KDBusRunner
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH portBalooRunnerToKDBusRunner REVISION DETAIL https://phabricator.kde.org/D10079 To: kossebau, davidedmundson, broulik, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10055: [Look and feel KCM] Keep cursor size when applying theme
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10055 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10067: [Look and feel KCM] Destroy and recreate GHNS button when palette changes
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ok for now (note that we will be able to use qqc2 buttons with icons only when we can depend at least for plasma-desktop on Qt 5.10) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10067 To: broulik, #plasma, mart Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D10057: Require libinput and udev
mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. +1 from me REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10057 To: graesslin, #kwin, #plasma Cc: mart, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
D10077: [Default Tooltip] Fix sizing
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10077 To: broulik, #plasma, #vdg, mart Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10101: Fix autohide panels on wayland
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10101 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10084: Make the messages translatable
This revision was automatically updated to reflect the committed changes. Closed by commit R129:64d9f92f6a87: Make the messages translatable (authored by yurchor). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10084?vs=25908&id=25983#toc REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10084?vs=25908&id=25983 REVISION DETAIL https://phabricator.kde.org/D10084 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/Messages.sh To: yurchor, #plasma, graesslin, #localization, lueck Cc: lueck, aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10111: [Klipper] Force plain text on the edit dialog
broulik accepted this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10111 To: safaalfulaij, #plasma, mlaurent, broulik Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9225: Fix building autotest on platforms where syscalls are not available
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R133:f1a1c9b22e4f: Fix building autotest on platforms where syscalls are not available (authored by bshah). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9225?vs=23555&id=25987 REVISION DETAIL https://phabricator.kde.org/D9225 AFFECTED FILES greeter/autotests/seccomp_test.cpp To: bshah, #plasma, fvogt, graesslin, davidedmundson Cc: davidk, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10116: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH dumpcontactsrunner REVISION DETAIL https://phabricator.kde.org/D10116 To: kossebau, broulik, jriddell, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10102: base scrolling on the smallest item
ngraham added a comment. Also FWIW we had trouble with hyper-sensitive touchpad scrolling in Gwenview a few months ago and fixed it with https://cgit.kde.org/gwenview.git/commit/?id=c4a84dad6292b9c7918bec8d7ed33114d3758730 REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10102: base scrolling on the smallest item
ngraham added a comment. Same results as Kai, but I also do not have that Qt patch. Still, this is a definite improvement for the wheel mouse use case. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10067: [Look and feel KCM] Destroy and recreate GHNS button when palette changes
This revision was automatically updated to reflect the committed changes. Closed by commit R119:900a334e72a7: [Look and feel KCM] Destroy and recreate GHNS button when palette changes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10067?vs=25862&id=25995 REVISION DETAIL https://phabricator.kde.org/D10067 AFFECTED FILES kcms/lookandfeel/package/contents/ui/main.qml To: broulik, #plasma, mart Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D10055: [Look and feel KCM] Keep cursor size when applying theme
This revision was automatically updated to reflect the committed changes. Closed by commit R119:aae0d59de766: [Look and feel KCM] Keep cursor size when applying theme (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10055?vs=25832&id=25994 REVISION DETAIL https://phabricator.kde.org/D10055 AFFECTED FILES kcms/lookandfeel/kcm.cpp To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9638: [effects] replace old slide effect with a new one
zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. I would like to test this effect in "full KDE Plasma wayland session", but I can't start plasma. After splash screen there is only black screen. Sometimes, there are messages like this kscreen.kwayland: Connection to Wayland server at socket: "wayland-0" timed out. Does anyone know how to fix this? --- My workflow xhost + sudo docker run --rm \ -v /tmp/.X11-unix:/tmp/.X11-unix \ -e DISPLAY=:0 \ --device /dev/dri \ --device /dev/snd \ --device /dev/video0 \ --cap-add ALL \ -v /home/vlad/KDE/build:/home/neon/build \ -v /home/vlad/KDE/log:/home/neon/log \ -v /home/vlad/KDE/src:/home/neon/src \ -v /home/vlad/KDE/usr:/home/neon/usr \ -v /home/vlad/KDE/.kdesrc-buildrc:/home/neon/.kdesrc-buildrc \ -v /home/vlad/KDE/.kdesrc-build:/home/neon/.kdesrc-build \ -ti kdebuilder:v2 bash # inside container $ kdesrc-build --include-dependencies plasma-desktop $ source kde-env-master.sh $ startplasmacompositor (`kdebuilder:v2` is an image based on `kdeneon/plasma:dev-unstable` with some -dev packages preinstalled) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
D10112: watch the tabletMode from KWin
mart created this revision. mart added reviewers: Plasma, Kirigami. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Add api in the C++ library that watches the tablet mode property exposed from KWin. use dbus, but only on linux,bsd etc, not on Android, Windows etc. connect it to Settings.isMobile which was already used for it (even tough it introduces a naming inconsistence, but needed for retrocompatibility) TEST PLAN tested to switch on the fly on Wayland with the kwin tablet mode sensor working REPOSITORY R169 Kirigami BRANCH mart/tabletMode REVISION DETAIL https://phabricator.kde.org/D10112 AFFECTED FILES CMakeLists.txt examples/gallerydata/contents/ui/gallery/MiscGallery.qml src/CMakeLists.txt src/controls/templates/SwipeListItem.qml src/libkirigami/CMakeLists.txt src/libkirigami/org.kde.KWin.TabletModeManager.xml src/libkirigami/tabletmodewatcher.cpp src/libkirigami/tabletmodewatcher.h src/settings.cpp src/settings.h To: mart, #plasma, #kirigami Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10077: [Default Tooltip] Fix sizing
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f31e7860d98f: [Default Tooltip] Fix sizing (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10077?vs=25885&id=25993 REVISION DETAIL https://phabricator.kde.org/D10077 AFFECTED FILES src/declarativeimports/core/private/DefaultToolTip.qml To: broulik, #plasma, #vdg, mart Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10092: [Examples] Fix build
This revision was automatically updated to reflect the committed changes. Closed by commit R242:595fd8805430: [Examples] Fix build (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10092?vs=25923&id=25992 REVISION DETAIL https://phabricator.kde.org/D10092 AFFECTED FILES examples/dataengines/customDataContainers/customDataContainersEngine.cpp examples/dataengines/customDataContainers/customDataContainersEngine.h examples/dataengines/customDataContainers/httpContainer.cpp examples/dataengines/customDataContainers/httpContainer.h examples/dataengines/simpleEngine/simpleEngine.cpp examples/dataengines/sourcesOnRequest/sourcesOnRequest.cpp examples/dataengines/sourcesOnRequest/sourcesOnRequest.h examples/shell/customcorona.cpp examples/shell/customcorona.h examples/shell/main.cpp examples/testcontainmentactionsplugin/test.cpp examples/testcontainmentactionsplugin/test.h To: broulik, #plasma, rjvbb Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9993: Improve quality of images in notifications (Bug 385097)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bfe2539aa055: Improve quality of images in notifications (Bug 385097) (authored by rkron, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9993?vs=25688&id=26010 REVISION DETAIL https://phabricator.kde.org/D9993 AFFECTED FILES applets/notifications/plugin/thumbnailer.cpp To: rkron, #plasma_workspaces, #plasma, broulik Cc: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma, ZrenBot, gassaf, progwolff, franciscofernandes, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10110: Port konsolesessions runner to Plasma5/Qt5
This revision was automatically updated to reflect the committed changes. Closed by commit R114:2f3bcfa8c61d: Port konsolesessions runner to Plasma5/Qt5 (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10110?vs=25972&id=26016#toc REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10110?vs=25972&id=26016 REVISION DETAIL https://phabricator.kde.org/D10110 AFFECTED FILES runners/CMakeLists.txt runners/konsolesessions/CMakeLists.txt runners/konsolesessions/konsolesessions.cpp runners/konsolesessions/konsolesessions.h To: kossebau, broulik, jriddell, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"
broulik added a comment. Yes, please! I agree that shared-mime-info must be fixed to remove the `.bin` extension but this will take forever and this is a serious regression preventing any novice user from downloading files properly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
davidedmundson added a comment. > I can't find anything related to preview on my Arch Linux default Arch kcm -> layouts -> add layout -> preview REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10116: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner
This revision was automatically updated to reflect the committed changes. Closed by commit R114:a19c9118000c: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10116?vs=26000&id=26006 REVISION DETAIL https://phabricator.kde.org/D10116 AFFECTED FILES runners/CMakeLists.txt runners/contacts/CMakeLists.txt runners/contacts/Messages.sh runners/contacts/contactsrunner.cpp runners/contacts/contactsrunner.h runners/contacts/imageiconengine.cpp runners/contacts/imageiconengine.h runners/contacts/plasma-runner-contacts.desktop To: kossebau, broulik, jriddell, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D1230: GBM remote access support for KWin
Kanedias updated this revision to Diff 25979. Kanedias added a comment. - Merge branch 'master' into gbm-vnc - Fix compilation on Clang REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=21211&id=25979 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES decorations/decoratedclient.h kcmkwin/kwindecoration/declarative-plugin/previewclient.h main_wayland.cpp plugins/platforms/drm/CMakeLists.txt plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_buffer_gbm.h plugins/platforms/drm/drm_output.h plugins/platforms/drm/egl_gbm_backend.cpp plugins/platforms/drm/egl_gbm_backend.h plugins/platforms/drm/remoteaccess_manager.cpp plugins/platforms/drm/remoteaccess_manager.h To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, schernikov, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D9638: [effects] replace old slide effect with a new one
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#196184, @zzag wrote: > @graesslin: do elevated windows have order? (e.g. docks are above fullscreen windows, etc) They are above all other windows. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol
D10111: [Klipper] Force plain text on the edit dialog
safaalfulaij updated this revision to Diff 25978. safaalfulaij added a comment. setAcceptRichText REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10111?vs=25973&id=25978 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10111 AFFECTED FILES klipper/klipper.cpp To: safaalfulaij, #plasma, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9638: [effects] replace old slide effect with a new one
zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. If you know how to start wayland session, please let me know. Till then, I can't do too much (I'm familiar with effects part only). REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol
D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"
ijanssen added reviewers: Plasma, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10116: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner
davidedmundson accepted this revision. REPOSITORY R114 Plasma Addons BRANCH dumpcontactsrunner REVISION DETAIL https://phabricator.kde.org/D10116 To: kossebau, broulik, jriddell, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9638: [effects] replace old slide effect with a new one
zzag updated this revision to Diff 26015. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. - clip with the PaintClipper - elevate docks when `Slide docks` is unchecked - rewritten logic which forces blur and background contrast (tested only on X11) PS. I wish I could test Wayland part. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9638?vs=25915&id=26015 BRANCH effects/slide REVISION DETAIL https://phabricator.kde.org/D9638 AFFECTED FILES effects/effect_builtins.cpp effects/slide/slide.cpp effects/slide/slide.h effects/slide/slide.kcfg effects/slide/slide_config.cpp effects/slide/slide_config.h effects/slide/slide_config.ui To: zzag, #vdg, #kwin, #plasma Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
D10118: Disable keyboard geometry preview code
bshah updated this revision to Diff 26004. bshah added a comment. add bug in message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10118?vs=26002&id=26004 BRANCH bshah/disable-geometry REVISION DETAIL https://phabricator.kde.org/D10118 AFFECTED FILES kcms/keyboard/CMakeLists.txt To: bshah, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10111: [Klipper] Force plain text on the edit dialog
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Indeed it's better. but we need to use setAcceptRichText(false) in edit otherwise we can set html text by dnd or copy. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10111 To: safaalfulaij, #plasma, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY it is not clear if this code is functional at this moment or not, given I can't find anything related to preview on my Arch Linux default Arch Linux, but nevertheless, this code is disabled due to another reason This code makes C++ compiler OOM even with 16GB of RAM, In my opinion this is simply not acceptable, there are multiple build jobs failed on both KDE CI and KDE Neon CI. If someone wants to re-enable this code, it needs to be optimized so that it doesn't bring down full-fledged CI server nodes.. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH bshah/disable-geometry REVISION DETAIL https://phabricator.kde.org/D10118 AFFECTED FILES kcms/keyboard/CMakeLists.txt To: bshah, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
anthonyfieroni added a comment. I believe that port away from boost will fix the problem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D1231: Add Remote Access interface to KWayland
Kanedias updated this revision to Diff 25976. Kanedias edited the test plan for this revision. Kanedias added a comment. - Add RemoteAccess interface to KWayland - Merge branch - Fix compilation warnings uint -> int REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=21212&id=25976 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_remote_access.cpp src/client/CMakeLists.txt src/client/protocols/remote-access.xml src/client/registry.cpp src/client/registry.h src/client/remote_access.cpp src/client/remote_access.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/remote_access_interface.cpp src/server/remote_access_interface.h src/server/remote_access_interface_p.h src/tools/mapping.txt To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, schernikov, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D10116: Dump unported code of contactsrunner, akonadi-search has pimcontactsrunner
kossebau created this revision. kossebau added reviewers: broulik, jriddell, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH dumpcontactsrunner REVISION DETAIL https://phabricator.kde.org/D10116 AFFECTED FILES runners/CMakeLists.txt runners/contacts/CMakeLists.txt runners/contacts/Messages.sh runners/contacts/contactsrunner.cpp runners/contacts/contactsrunner.h runners/contacts/imageiconengine.cpp runners/contacts/imageiconengine.h runners/contacts/plasma-runner-contacts.desktop To: kossebau, broulik, jriddell, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10110: Port konsolesessions runner to Plasma5/Qt5
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. good stuff REPOSITORY R114 Plasma Addons BRANCH portkonsolesessions REVISION DETAIL https://phabricator.kde.org/D10110 To: kossebau, broulik, jriddell, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10102: base scrolling on the smallest item
mart added a comment. do you have in your qt copy this patch? https://codereview.qt-project.org/#/c/212398/ REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D10102 To: mart, #dolphin, broulik Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10079: [Draft] Port baloo krunner plugin to KDBusRunner
kossebau retitled this revision from "Port baloo krunner plugin to KDBusRunner" to " [Draft] Port baloo krunner plugin to KDBusRunner". kossebau edited the summary of this revision. REPOSITORY R120 Plasma Workspace BRANCH portBalooRunnerToKDBusRunner REVISION DETAIL https://phabricator.kde.org/D10079 To: kossebau, davidedmundson, broulik, mart Cc: michaelh, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
