D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate added a comment.


  In D10670#209823 , @mwolff wrote:
  
  > ok, looking at the reasoning in the other commit:
  >
  > - you need to extend the commit message here
  
  
  Will be done.
  
  > - you need to provide a comment in the code the clarifies what's going on 
here
  
  Will be done.
  
  > in general, I don't see how such a comparison can be so costly - the real 
problem would be too many native events, no? did you maybe profile a debug 
build or something?
  
  A qstrcmp is more expensive than a single cpu instruction in i586 builds 
(debug or release), unless it uses SSE4 instruction in the x64 world.
  
  Unfortunately I haven't found what causes so many native events.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=369676

--- Comment #10 from Rog131  ---
(In reply to Michael D from comment #9)
> Why not have configurable font color, or have the background detected and
> automatically select text color based on that (which I imagine is way harder
> to implement)?

The Breeze plasma lockscreen is using plasma complementary color group. The
Breeze text color can be set from the KDE system settings > Colors >
Complementary > Normal text.

Image - Imgur: https://imgur.com/jrC4bR8

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10337: First approach to a plasmoid that can display the state of caps lock

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:1ab3d012b2d5: First approach to a plasmoid that can 
display the state of caps lock (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10337?vs=26665=27585#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10337?vs=26665=27585

REVISION DETAIL
  https://phabricator.kde.org/D10337

AFFECTED FILES
  applets/CMakeLists.txt
  applets/keyboardindicator/contents/ui/main.qml
  applets/keyboardindicator/metadata.desktop

To: apol, #plasma, jriddell
Cc: graesslin, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=369676

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #9 from Michael D  ---
Why not have configurable font color, or have the background detected and
automatically select text color based on that (which I imagine is way harder to
implement)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10668: Fix PowerDevil shortcuts migration

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> aacid wrote in powerdevilapp.cpp:177
> Won't this return QList() since you've set it on the line just 
> before?

You'd think so, but no.

setShortcut(QAction, sequence, KGlobalAccel::NoAutoloading)   
would do exactly that

setShortcut(QAction, sequence, KGlobalAccel::Autoloading)   
(which this defaults to)
will make KGlobalAccel load whatever it has stored already in its config file.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma
Cc: aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10668: Fix PowerDevil shortcuts migration

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> powerdevilapp.cpp:177
> +KGlobalAccel::self()->setShortcut(, 
> QList());
> +auto shortcuts = KGlobalAccel::self()->shortcut();
> +KGlobalAccel::self()->removeAllShortcuts();

Won't this return QList() since you've set it on the line just 
before?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma
Cc: aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10668: Fix PowerDevil shortcuts migration

[Christoph Feck]

cfeck added a comment.


  Regarding the comments, I prefer a space after '//' for better readability.

INLINE COMMENTS

> powerdevilapp.cpp:169
> +});
> +for(const QString : actionIds)
> +{

Missing space after 'for'.

> powerdevilapp.cpp:170
> +for(const QString : actionIds)
> +{
> +QAction oldAction;

Please move brace to previous line.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma
Cc: cfeck, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Milian Wolff]

mwolff added a comment.


  ok, looking at the reasoning in the other commit:
  
  - you need to extend the commit message here
  - you need to provide a comment in the code the clarifies what's going on here
  
  in general, I don't see how such a comparison can be so costly - the real 
problem would be too many native events, no? did you maybe profile a debug 
build or something?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  what? this is totally unsafe - the reinterpret_cast below shouldn't be done 
on anything that has event names other than the previously used one...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10627: Reduce plasmashell frozen time to almost nothing

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e1fe26f1fc78: Reduce plasmashell frozen time to almost 
nothing (authored by jtamate).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10627?vs=27453=27577

REVISION DETAIL
  https://phabricator.kde.org/D10627

AFFECTED FILES
  shell/screenpool.cpp

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Third part of https://phabricator.kde.org/D10627

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10670

AFFECTED FILES
  src/plasma/private/effectwatcher.cpp

To: jtamate, #frameworks, #plasma
Cc: plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10669: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Second part of https://phabricator.kde.org/D10627

REPOSITORY
  R278 KWindowSystem

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10669

AFFECTED FILES
  src/platforms/xcb/kxmessages.cpp

To: jtamate, #plasma, #frameworks
Cc: plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10668: Fix PowerDevil shortcuts migration

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  5.11 -> 5.12 migrated shortcuts from kded5 to the correct component name
  org_kde_powerdevil for good reasons
  However, despite a kconfupdate script working correctly and moving the
  old keys, kglobalaccel is running whilst we update and it syncs the old
  values later. On future loads it detects the duplication and removes the
  powerdevil entries.
  
  This patch removes the old powermanagent entries in the kded5 component
  at powerdevil startup which is at runtime where we can talk to
  kglobalaccel, but before powerdevil has registered the new actions.
  
  This should handle both users that haven't upgraded to 5.12 yet, as well
  as users who hit the previous config script.
  
  Ideally kconf_update needs to be patched to do migration at appropriate
  times.
  
  BUG: 389991
  FIXED-IN: 5.12.2

TEST PLAN
  "broke" my config by putting in values in the old place with a custom 
shortcut for poweroff
  Restarted kglobalaccel
  Ran powerdevil
  Shortucts worked
  Cleanly quit kglobalaccel
  Config stayed synced

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10668

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  kconf_update/CMakeLists.txt
  kconf_update/powerdevil_move_shortcuts.upd

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10659: [AppletConfiguration] Let applet override Return closing the dialog

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Eek. Undocumented secret properties make my toe nails roll up.
  
  Can this property become something more official, with real documentation 
(and test case), so that other applet config pages can make use of it as well?
  No real insight into design of applet confiuration myself, so otherwise shy 
to comment on this at all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10659

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Not tested, but seems good to me by pure reading.

INLINE COMMENTS

> ConfigWeatherStation.qml:33
> +
> +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || 
> searchStringEdit.length === 0
>  

Slightly undecided: given above we use the `length` property as implicit bool, 
dping a value comparison here instead seems inconsistent.

Just saying, no own preference and not enough years of JS/QML done to have 
strong opinions about it :) Do we have some accepted JS tricks with Plasma code 
style?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by 
jtamate).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10629?vs=27523=27571

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp
  klipper/clipboardjob.cpp

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Plasma 5.13 dependencies

[Ben Cooksley]

On 20/02/2018 12:23 AM, "Jonathan Riddell"  wrote:

Hi Jonathan,

Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks
5.46.  The newer Qt will help us port KControl modules to QtQuick
Controls 2 a target of this release.
https://phabricator.kde.org/project/view/254/


When will this dependency start coming into effect?

While we fortunately already have a Qt 5.10 image for Linux on the CI
system, I'm not sure what the status is of Qt 5.10 for FreeBSD so a
timeline for this would be nice.



Jonathan


Cheers,
Ben

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored 
by mvourlakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10592?vs=27382=27568

REVISION DETAIL
  https://phabricator.kde.org/D10592

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:57-68
> +if (s_preloadPolicy == Uninitialized) {
> +if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) {
> +const QString policy = 
> QString::fromUtf8(qgetenv("PLASMA_PRELOAD_POLICY")).toLower();
> +if (policy == QStringLiteral("aggressive")) {
> +s_preloadPolicy = Aggressive;
> +} else if (policy == QStringLiteral("none")) {
> +s_preloadPolicy = None;

So Adaptive can a default even environment variable is not setted?
Furthermore you can make a static function to access value

  AppletQuickItemPrivate::PreloadPolicy AppletQuickItemPrivate::appletPolicy()
  {
  static const PreloadPolicy preloadPolicy = []() -> PreloadPolicy {
  if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) {
  const QString policy = 
QString::fromUtf8(qgetenv("PLASMA_PRELOAD_POLICY")).toLower();
  if (policy == QStringLiteral("aggressive")) {
  return Aggressive;
  } else if (policy == QStringLiteral("none")) {
  return None;
  }
  }
  return Adaptive;
  }();
  return preloadPolicy;
  }

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, broulik, apol, ngraham, plasma-devel, 
#frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D10592: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij accepted this revision.
safaalfulaij added a comment.
This revision is now accepted and ready to land.


  Now since I'm a reviewer, sure :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  rtl

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6cbea20bf9f7: try to preload certain applets in a smart 
way (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27559=27561

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  > Sure. Go ahead and commit.
  
  is it possible to give first the green light by accepting the review?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a reviewer: safaalfulaij.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart, safaalfulaij
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10592: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In D10592#209670 , @mvourlakos 
wrote:
  
  > @safaalfulaij is there a green light for this?
  
  
  Sure. Go ahead and commit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27559.
mart added a comment.


  - just PLASMA_PRELOAD_POLICY

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27558=27559

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27558.
mart added a comment.


  - always delay preloading

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27557=27558

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart added a comment.


  In D10512#209679 , @ngraham wrote:
  
  > If by default this slows down plasmashell's loading in favor of making 
widgets load faster, I'm against it. People will notice the drawbacks of the 
former more than the benefits of the latter.
  
  
  with the trick of the QTimer,  it shows an usable desktop actually before 
things are preloaded, then starting doing its things in the background.
  thesting on the local systems, plasma seems to stay fluid even while it's 
actually performing the preload in the background, so shouldn't be noticeable 
there.
  of course, needs to be tried by many people with systems more or less 
performant

INLINE COMMENTS

> broulik wrote in appletquickitem.cpp:55
> Cache the result in a static to read it only once?

in a static?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Nathaniel Graham]

ngraham added a comment.


  If by default this slows down plasmashell's loading in favor of making 
widgets load faster, I'm against it. People will notice the drawbacks of the 
former more than the benefits of the latter.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added a comment.


  lgtm

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27557.
mart added a comment.


  - cache env var reading

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27554=27557

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:55
>  {
> +if (qEnvironmentVariableIsSet("KDE_PLASMA_PRELOAD_POLICY")) {
> +const QByteArray policy = qgetenv("KDE_PLASMA_PRELOAD_POLICY");

Cache the result in a static to read it only once?

> appletquickitem.cpp:57
> +const QByteArray policy = qgetenv("KDE_PLASMA_PRELOAD_POLICY");
> +if (policy == "Aggressive") {
> +preloadPolicy = Aggressive;

case insensitive?

> appletquickitem.cpp:653
> +const int delay = qrand() % ((max + 1) - min) + min;
> +QTimer::singleShot(delay, [this, delay]() {
> +qCInfo(LOG_PLASMAQUICK) << "Delayed preload of " << 
> d->applet->title() << "after" << (qreal)delay/1000 << "seconds";

Still missing `this` context:

  QTimer::singleShot(delay, this, [this, delay]() {

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10592: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij is there a green light for this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10592

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

[Piotr Kąkol]

piotrkakol added a comment.


  Thank you for reviewing.
  
  No, I don't have commit access.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10642: [kcmkwin/rules] Disable detect button on Wayland

[Martin Flöser]

graesslin updated this revision to Diff 27555.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Hide buttons intead of disabling them

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10642?vs=27484=27555

BRANCH
  detect-button-disabled-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10642

AFFECTED FILES
  kcmkwin/kwinrules/ruleswidget.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: mart, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27554.
mart added a comment.


  control with an env variable
  
  can be either always off, always on or adaptive

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27263=27554

BRANCH
  arcpatch-D10512

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: QtWayland decoration improvement

[Martin Flöser]

Am 2018-02-19 16:37, schrieb Martin Bříza:

Hello everyone,

I thought this would be a good place to discuss this small problem:

I'm trying to make Qt work better under Wayland and especially in
GNOME.  The current infrastructure in QtWayland doesn't allow for very
complicated  window decorations. First, QWaylandAbstractDecoration is
a private API  now, which is mostly fine, however I'd like to make it
a bit better.  Especially, there's a problem with the limited
possibilities we now have.  The decorations cannot have shadows and
the ability to handle mouse events  is pretty limited.

I'd like to solve this systematically, for everyone, likely by
patching  QtWayland to add new features to QWaylandAbstractDecoration
and I'd like  to ask for your advice.

I know there is the KDecoration2 API which is feature-complete (and in
my  opinion, it exposes a lot more stuff than what we would eventually
 actually need in Qt). Could (partially or completely) upstreaming
this  class help with this problem? There could be a base class in
QtWayland  implementing the core functionality and KDecoration2 could
just extend the  class with what's required for KWin. KWin decorations
could then be used  in other environments with a different compositor
and a different QPA  plugin. I'm CCing Martin as I'm pretty sure he'll
have something to say,  especially considering the stance on SSDs vs
CSDs.


One of the design goals of KDecoration2 was to make it possible to 
implement CSD with it.


I'm totally fine with upstreaming the implementation and agree to any 
license change required for it. But I'm not the only copyright holder, 
though probably > 90 % should be by me.


Personally I'm not interested in anything of it. I don't care whether Qt 
applications have good looking decorations. On Plasma we will continue 
to use server side decorations even if Qt uses our KDecoration2 (it 
provides a significant better performance in the compositor).


Cheers
Martin

D10512: try to preload certain applets in a smart way

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:51
> +DefaultLauncherPreloadWeight = 100,
> +DelayedPreloadWeight = 25,
> +PreloadWeightIncrement = 5,

So by default we preload /everything/ then over time your session gets faster 
as you don't use stuff?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10407: Disable positioning in popup folderviews

[Andras Mantia]

amantia closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10407

To: amantia, hein
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

QtWayland decoration improvement

[Martin Bříza]

Hello everyone,

I thought this would be a good place to discuss this small problem:

I'm trying to make Qt work better under Wayland and especially in GNOME.  
The current infrastructure in QtWayland doesn't allow for very complicated  
window decorations. First, QWaylandAbstractDecoration is a private API  
now, which is mostly fine, however I'd like to make it a bit better.  
Especially, there's a problem with the limited possibilities we now have.  
The decorations cannot have shadows and the ability to handle mouse events  
is pretty limited.


I'd like to solve this systematically, for everyone, likely by patching  
QtWayland to add new features to QWaylandAbstractDecoration and I'd like  
to ask for your advice.


I know there is the KDecoration2 API which is feature-complete (and in my  
opinion, it exposes a lot more stuff than what we would eventually  
actually need in Qt). Could (partially or completely) upstreaming this  
class help with this problem? There could be a base class in QtWayland  
implementing the core functionality and KDecoration2 could just extend the  
class with what's required for KWin. KWin decorations could then be used  
in other environments with a different compositor and a different QPA  
plugin. I'm CCing Martin as I'm pretty sure he'll have something to say,  
especially considering the stance on SSDs vs CSDs.


The other, less complicated (and less integrated) way would be to just add  
a few more properties to QWaylandAbstractDecoration, patch QtWaylandClient  
to handle shadows and improve damage/repaint support and patch Bradient to  
support all this new stuff.


And even less complicated way would be to just do my own thing in  
QGnomePlatform and support only the decorations I wrote myself.


Which one is the best one, according to you, please? I'm open to every  
suggestion.


Cheers
Martin

D10408: Add option to enable shared folderview content per desktop

[Andras Mantia]

amantia closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10408

To: amantia, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10620: Improve sidebar header visibility

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10659: [AppletConfiguration] Let applet override Return closing the dialog

[Kai Uwe Broulik]

broulik added a dependent revision: D10660: [Weather applet] Let Return invoke 
search.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10659

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, kossebau.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Depends on D10659 

TEST PLAN
  Hit Return after opening dialog, closed
  Hit Return with search focused but nothing in it, closed
  Hit Return with search query, started search (no search providers seem to be 
enabled by default, though, and no hint is provided why I cannot search..)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

AFFECTED FILES
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10620: Improve sidebar header visibility

[Nathaniel Graham]

ngraham updated this revision to Diff 27550.
ngraham added a comment.


  re-base on Plasma 5.12 branch

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10620?vs=27540=27550

BRANCH
  more-visible-headers (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D10620

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10659: [AppletConfiguration] Let applet override Return closing the dialog

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, kossebau.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In weather applet, pressing Return should invoke the search rather than 
closing the dialog.
  When this property is set, pressing Return will not close the dialog.

TEST PLAN
  Normal applet dialog closes as usual, saving changes. When property is set, 
hitting Return keeps dialog open. Escape is unaffected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10659

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10613: Make it possible for actions to show submenus

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27547.
apol added a comment.


  Drop Qt 5.10 dependency

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10613?vs=27454=27547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10613

AFFECTED FILES
  src/controls/private/ActionsMenu.qml
  src/controls/private/PrivateActionToolButton.qml
  tests/actionsMenu.qml

To: apol, #kirigami
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10613: Make it possible for actions to show submenus

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ActionsMenu.qml:35
> +text: model.text
> +icon.name: model.iconName
> +visible: model.visible

does it work? icon.* in controls is supposed to work only in qt 5.10 (and qqc2 
2.3) which we can't use in kirigami yet as we are on the 2 qt releases ago rule

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10613

To: apol, #kirigami
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10642: [kcmkwin/rules] Disable detect button on Wayland

[Marco Martin]

mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  i also wonder if wouldn't be better to hide it as that button could never 
ever be enabled at all in wayland (at least.. i guess?)

REPOSITORY
  R108 KWin

BRANCH
  detect-button-disabled-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10642

To: graesslin, #kwin, #plasma, davidedmundson
Cc: mart, ngraham, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, iodelay, bwowk, hardening

D10620: Improve sidebar header visibility

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R124 System Settings

BRANCH
  more-visible-headers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10653: Set IconItem default to smooth=true

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10653

To: davidedmundson, #plasma, apol
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  another way, may be adding a default kwin rule or script which lets every 
plasma window go trough

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8227e4e2b7f0: [Run Command] Add history drop down button 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10652?vs=27525=27541

REVISION DETAIL
  https://phabricator.kde.org/D10652

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  VDG-wise, big thumbs up. This is a clear usability improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Nathaniel Graham]

ngraham added a comment.


  I imagine refactoring that not to use magic numbers is a bigger effort. 
Still, we should keep that in mind, I think.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Kai Uwe Broulik]

broulik added a comment.


  Those magic values are copied straight from Plasma `TextFieldStyle`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Nathaniel Graham]

ngraham added a comment.


  Indeed; I never discovered it! This is great.

INLINE COMMENTS

> RunCommand.qml:125
> +right: parent.right
> +rightMargin: 6 // from PlasmaStyle TextFieldStyle
> +verticalCenter: parent.verticalCenter

Do we have a programmatic value we can use here instead of a magic number?

> RunCommand.qml:129
> +// match clear button
> +width: Math.max(parent.height * 0.8, units.iconSizes.small)
> +height: width

Ditto; maybe we should make `units.iconSizes.small` reflect the actual size 
that we want and just use that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10620: Improve sidebar header visibility

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10620: Improve sidebar header visibility

[Nathaniel Graham]

ngraham updated this revision to Diff 27540.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Also improve subcategory headers

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10620?vs=27539=27540

BRANCH
  more-visible-headers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10620

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10620: Improve sidebar header visibility

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10620: Improve sidebar header visibility

[Nathaniel Graham]

ngraham updated this revision to Diff 27539.
ngraham added a comment.


  Use supportsMouseEvents: false instead

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10620?vs=27438=27539

BRANCH
  more-visible-headers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10620

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  In D10591#207905 , @davidedmundson 
wrote:
  
  > What would this code do if the device notifier is expanded but on the 
desktop?
  
  
  giving desktop window focus, which means we should also either check window 
flags or the applet formfactor... (tough i would still like a smarter solution)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:745cffc9ffd3: Fix location of Firefox dbCacheFile 
(authored by z3ntu, committed by mlaurent).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10605?vs=27414=27534

REVISION DETAIL
  https://phabricator.kde.org/D10605

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

[Laurent Montel]

mlaurent added a comment.


  Ok I will commit for you.
  Regards

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10605

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

[Luca Weiss]

z3ntu added a comment.


  No (this is one of my first patches )

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10605

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

[Laurent Montel]

mlaurent added a comment.


  Do you have commit access ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10605

REVISION DETAIL
  https://phabricator.kde.org/D10605

To: z3ntu, mlaurent
Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Minutes Monday Plasma Hangout

[Eike Hein]

Plasma Team meeting, 2018-02-19

Present: kbroulik, romangg, d_ed, bshah, notmart, Riddell, Sho_

kbroulik:
* Did some cleanup and performance fixes to Klipper plasmoid:
** Opens almost instant on first startup now, used to cause quite a hickup
** Added support for "Aztec" barcodes (credit goes to Volker Krause who
added that to Prison), I just put a button in the UI ;)
** https://phabricator.kde.org/D10557 please
* Did some cleanup and performance fixes to Kickoff (e.g. removing
unused items, making sure imported JS files are marked "pragma library"
if possible, moving items to where they're actually used, etc)
* Did some minor cleanup to BlueDevil and plasma-pa plasmoids
* I want to place the toolbox in the top right corner to avoid conflicts
with Folder View and apparently downstreams patched that for ages,
https://phabricator.kde.org/D10563
* I killed the QmlObjectIncubationController in KDeclarative. This gives
a *massive* performance boost to Plasma; all it did was slow things down
artificially, it didn't do anything smart (like preload or load only
when idle)
** Startup speed of plasmashell reduced by 1 second(!) here, taking 2.8
seconds total now
** Also speeds up initial creation of plasmoid popups, e.g. Kickoff
takes half the time now, the calendar popup is noticeably faster, you
still get an occasional hickup when opening plasmoids for the first time
but it should be a lot less
* Continued working on gmenu-dbusmenu-proxy, setup a Debian VM to get a
more vanilla GTK experience (i.e. no Unity stuff that neon inherits from
its Ubuntu 16.04 base)
** I'm also in touch with Konstantin who maintains the
appmenu-gtk-module,
http://wstaw.org/m/2018/02/19/Screenshot_20180215_130102.png Inkscape!
(don't mind the blurriness, that's just VirtualBox not handling Qt scaling)
** There's still quite a few corner cases and bugs to be ironed out but
should be doable
* Various other minor fixes:
** IconItem "smooth" is also applied during the image transition (e.g.
on hover)
** Task Manager audio indicator is no longer delayed when a window shows
up that is  already playing audio
* Finally merged a couple of older patches:
** KUrlNavigatorPlacesSelector (the dropdown list left of url bar if you
have your Places panel hidden) now puts places categories into sub menus
just as Plasma's Task Manager does
** KIconLoader paints overlays correctly on high-dpi screens now (I
finally have my overlays back \o/)
** Web browser plasmoid uses QtWebEngine now, also added a slew of
features and bug fixes to it in the process
** KNewFileMenu emits KDirNotify now, fixes the delay when creating a
new file on the desktop
** Will merge my KFileWidget visual patch later this week if nobody
objects: https://phabricator.kde.org/D10325

romangg:
* Held Plasma Wayland 5.13 meeting last Wednesday. We set some goals,
that we aim for in 5.13. Report:
https://mail.kde.org/pipermail/plasma-devel/2018-February/081015.html
  There are still tasks on Phabricator missing representing these goals.
The assignees pls don't forget to create them so we can track them
properly. We have setup a 5.13 milestone to tag your tasks with.
* Kick-started HIG revision project:
  bshah did sysadmin tasks described here: https://phabricator.kde.org/T7950
  * Git repo: https://cgit.kde.org/websites/hig-kde-org.git
  * Domain; hig.kde.org
  * Phab project: https://phabricator.kde.org/project/profile/264/
  On the workboard we already defined some tasks regarding format and
content revision of the HIG. Most of them still need input on how to
proceed, so you're invited to participate.
  Spread the info about the project to some more people who are Ui/Ux
designers and could help with the HIG revision.
* Looked into T7242, at first this seems to be a simple task but for the
heck of it I couldn't decide on where these two checkboxes should go.
Any suggestion? I thought about putting it at the top of the Desktop
Effects KCM, but this is a KCM provided by KWin.

d_ed:
I've ported the minimizeAll applet to share libtaskmanager
which fixes it on wayland, and removes a tonne of code in one
Also I have a branch davidedmundson/wallpaperrewrite   that redoes the
image wallpaper in slightly under 1/3  of the original size

bshah:
- Neon, qt 5.10 packaging work
- sysadmin tasks for hig.kde.org

notmart:
* Kirigami: Make overlay sheet not possible to be closed with the mouse
wheel (one complained thing of discover)
** small visual makeover and header/footer features for OverlayDrawer
* continue the activity switching gesture prototype on plasma-mobile
* some logic for preloading of applet popups and getting some numbers to
compare D10512 (final decision when/if/how merge asap)
* (pushed) small patch in kwin to be able to use gbm implementations
which are not mesa
* an attempt to mitigate devicenotifier not being dismissable when
clicking anywhere D10591 horrible solution, i don't know about a proper
one, it should be dismissed by clicking anywhere when doesn't have
focus, which 

Plasma 5.13 dependencies

[Jonathan Riddell]

Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks
5.46.  The newer Qt will help us port KControl modules to QtQuick
Controls 2 a target of this release.
https://phabricator.kde.org/project/view/254/

Jonathan

D10653: Set IconItem default to smooth=true

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This changes between linear and nearest neighbour filtering.
  
  Docs for QtQuick say:
  In Qt Quick 2, this property has minimal impact on performance.
  
  Generally we round to icon size anyway and resize the underlying images
  anyway, so this will have no impact.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10653

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10618: Fix ComboBox & mode description for image fill mode

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:5bf2d077895b: Fix ComboBox  mode description for 
image fill mode (authored by sharvey, committed by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10618?vs=27508=27527

REVISION DETAIL
  https://phabricator.kde.org/D10618

AFFECTED FILES
  applets/mediaframe/package/contents/config/main.xml
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml
  applets/mediaframe/package/metadata.desktop

To: sharvey, #plasma, mart, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Do you have commit access?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10597: Fix media frame config layout

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  someone else made some mods.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10597

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:c8c734fabe47: Port minimize all applet from its own 
plugin to org.kde.TaskManager (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10019?vs=27364=27526

REVISION DETAIL
  https://phabricator.kde.org/D10019

AFFECTED FILES
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/plugin/minimizeall.cpp
  applets/minimizeall/plugin/minimizeall.h
  applets/minimizeall/plugin/minimizeallplugin.cpp
  applets/minimizeall/plugin/minimizeallplugin.h
  applets/minimizeall/plugin/qmldir

To: davidedmundson, #plasma, anthonyfieroni
Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik added a comment.


  In D10563#209361 , @rikmills wrote:
  
  > In D10563#209359 , 
@davidedmundson wrote:
  >
  > > What xml file? If it's not used, delete it.
  >
  >
  > containments/desktop/package/contents/config/main.xml
  >
  > It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in 
a default setup at least.
  
  
  I mean the toolboxes/desktoptoolbox/contents/config/main.xml - I thought 
that's where the toolbox stores its config but it turns out it just writes them 
to the desktop containment config (which has all the keys of this one). This 
looks wrong to me, though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Indicates that there's a "drop down" history similar to a ComboBox. The fact 
that you can press the down arrow to bring it up is hardly discoverable.
  
  BUG: 375207
  FIXED-IN: 5.13.0

TEST PLAN
  When the text field is empty, a drop down arrow is shown in the text field. 
As soon as you type it is replaced by the regular "clear" button
  F5718506: Screenshot_20180219_113317.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10629: Avoid a double emitResult()

[Kai Uwe Broulik]

broulik added a comment.


  Okay, nevermind. Go for it then!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I just received a +2 for my Qt patch and will merge it. This is obsolete 
then. Thanks, Hugo!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9227

To: broulik, #plasma, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

jtamate added a comment.


  In D10629#209358 , @broulik wrote:
  
  >
  
  
  I did a objdump -d to be sure:
  
  > dataengines/places/setupdevicejob.cpp
  
  setError is from KJob and it only sets a member value (d->error = errorCode;)
  
  > dataengines/mpris2/playeractionjob.cpp
  
  setErrorText is from KJob also and it only sets a member value (d->errorText 
= errorText;)
  
  > dataengines/applicationjobs/jobaction.cpp
  
  The same as the other two.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Rik Mills]

rikmills added a comment.


  In D10563#209359 , @davidedmundson 
wrote:
  
  > > what "the toolbox' own xml file is ignored
  >
  > What xml file? If it's not used, delete it.
  
  
  containments/desktop/package/contents/config/main.xml
  
  It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in a 
default setup at least.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[David Edmundson]

davidedmundson added a comment.


  > what "the toolbox' own xml file is ignored
  
  What xml file? If it's not used, delete it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Kai Uwe Broulik]

broulik added a comment.


  dataengines/places/setupdevicejob.cpp
  dataengines/mpris2/playeractionjob.cpp
  dataengines/applicationjobs/jobaction.cpp

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10325: [KFileWidget] Hide places frame and header

[Kai Uwe Broulik]

broulik added a comment.


  If no Frameworks dev objects within next few days this will be pushed

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D10620: Improve sidebar header visibility

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> mart wrote in CategoriesPage.qml:134
> hoverEnabled: false should be enough (iirc there are also properties to make 
> it not do mousepressed effects)

should be supportsMouseEvents: false

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10627: Reduce plasmashell frozen time to almost nothing

[David Edmundson]

davidedmundson added a comment.


  I'd do reviews on the other two, because there's a mistake in your commit 
message:
  
  > The other eventType are "windows_generic_MSG" and "mac_generic_NSEvent".
  
  QAbstractEventDispatcher::filterNativeEvent is public. Client code could be 
using that for anything, clients are weird. 
  We know what Plasma is doing, but that's not true for the Frameworks case.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10627

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10620: Improve sidebar header visibility

[Marco Martin]

mart added a comment.


  I'm ok with making the text darker in the headers.
  I'm not exactly sure why as viewbackgroundcolor should be correct(tough 
deprecated), but in the breeze light screenshots the headers have a background 
slightly ligher than the other elements, which makes it look a bit weird

INLINE COMMENTS

> CategoriesPage.qml:134
> +// Ideally, we would use real header items
> +background: Rectangle {
> +color: Kirigami.Theme.viewBackgroundColor

hoverEnabled: false should be enough (iirc there are also properties to make it 
not do mousepressed effects)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D10620

To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

jtamate updated this revision to Diff 27523.
jtamate added a comment.


  I haven't found more instances of setResult followed by emitResult.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10629?vs=27456=27523

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp
  klipper/clipboardjob.cpp

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10642: [kcmkwin/rules] Disable detect button on Wayland

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

BRANCH
  detect-button-disabled-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10642

To: graesslin, #kwin, #plasma, davidedmundson
Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart