D10938: Enable showing top level items in kicker and kickoff menu

2018-03-04 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e93dbd0e5914: Enable showing top level items in kicker 
and kickoff menu (authored by lopatin, committed by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10938?vs=28318&id=28664

REVISION DETAIL
  https://phabricator.kde.org/D10938

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: lopatin, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D10837: bad textarea width for rename file if filename too short

2018-03-04 Thread Eike Hein
hein added a comment.


  Could you let me know which real name to use on the commit?

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


Re: Fwd: Re: kwin display issue on librem5

2018-03-04 Thread Bhushan Shah
Hello,

On Fri, Mar 02, 2018 at 10:43:28AM -0700, Heather Ellsworth wrote:
> > So my questions for you are:
> > * Do you have any idea what could be missing or causing the
> > display_issue.jpg that could be fixed by exporting KWIN_COMPOSE?

This issue is due to kwin_wayland not using the zwp_linux_dmabuf
interface yet.

See the following task: https://phabricator.kde.org/T8067 and the diffs
attached with it.

In my opinion you should have a local kwin and kwayland packaging fork
with patches attached to this tasks or wait for Plasma 5.13 release

> > * Do you know how to make the mouse cursor show up?

There is two bugs, and workaround:

- https://bugs.kde.org/show_bug.cgi?id=391412 : due to this, if hardware
  doesn't provide the cursor plane it never fallbacks to software
  cursor.
- However, this is more interesting
- KWin calls : output->initCursor(m_cursorSize)
- initCursor calls DrmBuffer::map
- But somehow map function is failing internally, but returns true
  anyway.
- Through gdb session if we break on DrmOutput::initCursor() and
  make it return false early, it initalizes the software cursor
  correctly.
- Which makes me believe either there is something wrong in
  DrmBuffer::map and/or the DRM driver.

The solution is to ofcourse fix a bug.. but other then that, as a
workaround you can enable track mouse effect and press Ctrl+Meta to make
it show a "circle" around mouse cursor position.

https://files.kde.org/plasma/kwin/effect-videos/track_mouse.mp4

You can add following line under [Plugins] section in ~/.config/kwinrc

trackmouseEnabled=true

Thanks!

> > Also if there's a better place to ask this (like a kwin irc or mailing
> > list), I'm happy to redirect my questions. Once again, thanks for your
> > time on this project.
> > 
> > Cheers,
> > Heather
> > 

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature


D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Eike Hein
hein added a comment.


  Looks good to me, Kai?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10762: Fix the build on armhf/aarch64

2018-03-04 Thread Bhushan Shah
bshah updated this revision to Diff 28659.
bshah added a comment.


  updated to use single header

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10762?vs=28375&id=28659

BRANCH
  arcpatch-D10762

REVISION DETAIL
  https://phabricator.kde.org/D10762

AFFECTED FILES
  fixqopengl.h
  libkwineffects/kwinglplatform.cpp
  platform.h
  plugins/qpa/abstractplatformcontext.h
  plugins/qpa/integration.h
  plugins/qpa/window.h

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D10938: Enable showing top level items in kicker and kickoff menu

2018-03-04 Thread Eike Hein
hein added a comment.


  Will do, thank you for your patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10938

To: lopatin, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D10938: Enable showing top level items in kicker and kickoff menu

2018-03-04 Thread Eike Hein
hein added a comment.


  Will do, thanks again!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10938

To: lopatin, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11003: Fix the Add Source dialog

2018-03-04 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-add-source-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11009: Make passiveNotifications last longer, so users can actually read them

2018-03-04 Thread Aleix Pol Gonzalez
apol added a comment.


  Makes sense to me. Maybe we want to have some kind of formula to turn length 
into time like we do in plasma notifications (AFAIR).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11009

To: ngraham, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein


D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Алексей Шилин
aleksejshilin updated this revision to Diff 28639.
aleksejshilin added a comment.


  - Make sure to forget all documents, too

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10890?vs=28626&id=28639

BRANCH
  prepare_for_krecentdocument_fix

REVISION DETAIL
  https://phabricator.kde.org/D10890

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11021: [Media controller] Add simple volume control

2018-03-04 Thread Radek Hušek
Pitel retitled this revision from "[Media contoller] Add simple volume control" 
to "[Media controller] Add simple volume control".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

2018-03-04 Thread Milian Wolff
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  minor style stuff, otherwise lgtm, esp. if it works now

INLINE COMMENTS

> README:5
>  
> -[Drkonqi]
> +[DrKonqi]
>  ShowDebugButton=true

could be a separate commit

> debuggerlaunchers.cpp:42
>  {
> -if ( qobject_cast(parent())->debuggerIsRunning() ) {
> +if ( static_cast(parent())->debuggerIsRunning() ) {
>  qWarning() << "Another debugger is already running";

could be a separate commit

> debuggerlaunchers.h:81
>  public:
> -explicit DBusOldInterfaceLauncher(DebuggerManager *parent = nullptr);
> +explicit DBusInterfaceLauncher(const QString& name, 
> DBusInterfaceAdaptor* parent = nullptr);
>  QString name() const override;

here and below: style issues, afaik & and * should be next to the var name in 
frameworks code, like done in Qt

REPOSITORY
  R871 DrKonqi

BRANCH
  kdevelopdbus

REVISION DETAIL
  https://phabricator.kde.org/D10195

To: croick, #kdevelop, #plasma_workspaces, mwolff
Cc: mwolff, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Anthony Fieroni
anthonyfieroni added a comment.


  It looks good to me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10890: Don't skip certain recent documents in kicker and taskmanager

2018-03-04 Thread Алексей Шилин
aleksejshilin retitled this revision from "Prepare for KIO KRecentDocument fix 
(D10863)" to "Don't skip certain recent documents in kicker and taskmanager".
aleksejshilin edited the summary of this revision.
aleksejshilin edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10890: Prepare for KIO KRecentDocument fix (D10863)

2018-03-04 Thread Алексей Шилин
aleksejshilin updated this revision to Diff 28626.
aleksejshilin added a comment.


  - Clean up and better comment the code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10890?vs=28398&id=28626

BRANCH
  prepare_for_krecentdocument_fix

REVISION DETAIL
  https://phabricator.kde.org/D10890

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11003: Fix the Add Source dialog

2018-03-04 Thread Andrew Crouthamel
acrouthamel added a comment.


  Nice and clean! I like the change.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11003

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11028: [media controller applet] Fix JS error on no xesam:url data set

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixtoStringfromnull

REVISION DETAIL
  https://phabricator.kde.org/D11028

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D10973: [media controller applet] Support MPRIS services where CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28619.
kossebau added a comment.


  set PassiveStatus also for state=="stopped"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10973?vs=28415&id=28619

BRANCH
  mpriscontrollersupportnocanpause

REVISION DETAIL
  https://phabricator.kde.org/D10973

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11026: [taskmanager applet] Mark some caching QML Item properties readonly

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  markshortcutpropertiesreadonly

REVISION DETAIL
  https://phabricator.kde.org/D11026

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS 
controllers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11025

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28616.
kossebau added a comment.


  - also disable play/pause icon, not just mousearea
  - add needed method in main.qml (addition shared with D11007 
)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11025?vs=28614&id=28616

BRANCH
  fixtaskmanagertooltipformpris

REVISION DETAIL
  https://phabricator.kde.org/D11025

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Currently the media controller in the tooltup only works with MPRIS services
  which support the PlayPause command. By the MPRIS spec this is an optional
  feature though.
  While most players out there support this, the MPRIS support in Gwenview
  currently worked on does not (would need some more rewrite of internals).
  Which makes the media controller in the tooltip and/or Gwenview look broken :)
  
  To keep the current design with a central Play/Not Play button, this patch
  changes its behaviour depending on the CanPause flag:
  CanPause=true ->  show either Play or Pause
  CanPause=false -> show either Pkay or Stop
  That should stay close to what people need.

TEST PLAN
  Works with Gwenview patched with MPRIS support, button toggles between
  play/stop, depending on state.
  Works with VLC, button toggles between play/pause (but might need more
  testingg to add some work-arounds perhaps needed with vlc as hinted by
  broulik)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixtaskmanagertooltipformpris

REVISION DETAIL
  https://phabricator.kde.org/D11025

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 28610.
kossebau added a comment.


  cache isPlayingCheck in bool, fix icon update of play/pause menu entry

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11007?vs=28529&id=28610

BRANCH
  fixtaskmanagercontextmenuformpris

REVISION DETAIL
  https://phabricator.kde.org/D11007

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Radek Hušek
Pitel added a comment.


  The idea crossed my mind but I rarely use expanded version of the applet and 
there are two problems to deal with:
  
  - Where exactly to place the slider (I am bad at designing UI).
  - What should upper bound of slider be -- usually 1 is good option but mpris 
does not prevent apps from using larger volumes and there is not "getMaxVolume" 
method / property. It might be possible to just hardcode 1 as max but care 
would be needed not to mess the volume up if it was set to (say) 1.5 by other 
means. (And the user experience would be somewhat inconsistent, but I am not 
sure how many apps really uses volume > 1.)
  
  So I decided to keep it simple at first try.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Nicolas Fella
nicolasfella added a comment.


  What about a volume slider in the applet?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11021: [Media contoller] Add simple volume control

2018-03-04 Thread Radek Hušek
Pitel created this revision.
Pitel added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  Add simple volume control to Media Controller applet. Volume can by changed 
by:
  
  - mouse wheel on applet icon (3 % step), and
  - new global shortcuts (5 % step, unbound by default).
  
  There is no mute support currently (mpris interface does not have a mute 
method so we would have to keep
  track of old volume).
  
  Currently the patch does only prevent volume from being negative but it will 
try to set volume larger than 1 (mpris spec
  does not prevent players from using larger volumes).

TEST PLAN
  Tested in daily use with Cantata and SMPlayer. There is no UI change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/multiplexedservice.cpp

To: Pitel, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D10235: [server] Add support for the frame semantics of Pointer version 5

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b6bd28ab0492: [server] Add support for the frame 
semantics of Pointer version 5 (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10235?vs=26336&id=28563#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10235?vs=26336&id=28563

REVISION DETAIL
  https://phabricator.kde.org/D10235

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/client/registry.cpp
  src/server/pointer_interface.cpp
  src/server/pointer_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, schernikov, michaelh, ZrenBot, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


D10549: Don't crash if the cursor theme fails to create

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:2ea5153e1c97: Don't crash if the cursor theme fails 
to create (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10549?vs=27278&id=28560

REVISION DETAIL
  https://phabricator.kde.org/D10549

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/dont_crash_cursor_physical_size_empty.cpp
  wayland_cursor_theme.cpp

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D10642: [kcmkwin/rules] Disable detect button on Wayland

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:6d6576f81932: [kcmkwin/rules] Disable detect button on 
Wayland (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10642?vs=27555&id=28561

REVISION DETAIL
  https://phabricator.kde.org/D10642

AFFECTED FILES
  kcmkwin/kwinrules/ruleswidget.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: mart, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol


D10440: Support modifier mouse/scroll action on internal decorated windows

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b554e54e87b5: Support modifier mouse/scroll action on 
internal decorated windows (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10440?vs=26910&id=28559#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10440?vs=26910&id=28559

REVISION DETAIL
  https://phabricator.kde.org/D10440

AFFECTED FILES
  autotests/integration/internal_window.cpp
  input.cpp

To: graesslin, #kwin, #plasma, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-04 Thread Martin Flöser
graesslin updated this revision to Diff 28556.
graesslin added a comment.


  - Reword documentation to make it more clear when it has to be called
  - rename to detectPlatform

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10816?vs=27985&id=28556

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D10816

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/main.cpp
  ksmserver/logout-greeter/main.cpp
  ksmserver/switchuser-greeter/main.cpp
  ksplash/ksplashqml/CMakeLists.txt
  ksplash/ksplashqml/main.cpp
  kuiserver/CMakeLists.txt
  kuiserver/main.cpp
  libkworkspace/CMakeLists.txt
  libkworkspace/autotests/CMakeLists.txt
  libkworkspace/autotests/testPlatformDetection.cpp
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace.h
  shell/CMakeLists.txt
  shell/main.cpp
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/main.cpp
  systemmonitor/CMakeLists.txt
  systemmonitor/main.cpp

To: graesslin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-04 Thread Martin Flöser
graesslin marked 2 inline comments as done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart