D11166: Simplify display when there's only a single input device and a single output device

[Nathaniel Graham]

ngraham updated this revision to Diff 29133.
ngraham added a comment.


  Fix typo causing behavior issue

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11166?vs=29055=29133

BRANCH
  simplify-single-device-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11166

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

[Nathaniel Graham]

ngraham added a comment.


  Ping! Is this landable?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9878

To: broulik, #plasma, hein, graesslin, #vdg, fabianr
Cc: ngraham, fabianr, abetts, mart, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D11197: Allow OverlaySheet clients to omit the built-in close button

[Nathaniel Graham]

ngraham added a comment.


  "Close button + cancel" is inherently redundant; a historical relic of the 
fact that dialog boxes have traditionally been separate windows, and windows 
have titlebars with fixed button arrangements (that said, in macOS, dialog 
boxes now have no window decorations). Having two visible methods of doing the 
exact same thing is pointless and confusing, and IMHO there's no reason to go 
out of our way to replicate this error now that we're using  a convergent UI 
toolkit that has inline sheets.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11197

To: ngraham, mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11197: Allow OverlaySheet clients to omit the built-in close button

[Aleix Pol Gonzalez]

apol added a comment.


  I'd say it's okay to have the close button and a cancel, every dialog does.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11197

To: ngraham, mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11194: Load correct wallpaper plugin configuration in the dialog

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I think there's a bug report about this somewhere if you want to find it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_wallpaper_configuration_dialog

REVISION DETAIL
  https://phabricator.kde.org/D11194

To: aleksejshilin, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11195: Use separate config group for each wallpaper plugin

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  One could argue keeping the colour persist across wallpapers is a feature, 
what problems does it cause?

INLINE COMMENTS

> containmentconfigview.cpp:180
>  KConfigGroup cfg = m_containment->config();
>  cfg = KConfigGroup(, "Wallpaper");
> +cfg = KConfigGroup(, wallpaper);

why do this line still?

> containmentconfigview.cpp:181
>  cfg = KConfigGroup(, "Wallpaper");
> +cfg = KConfigGroup(, wallpaper);
>  m_currentWallpaperConfig = m_ownWallpaperConfig = new 
> KDeclarative::ConfigPropertyMap(new KConfigLoader(cfg, ), this);

when a user with a current config upgrades, what's going to happen?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11195

To: aleksejshilin, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11197: Allow OverlaySheet clients to omit the built-in close button

[Nathaniel Graham]

ngraham updated this revision to Diff 29130.
ngraham added a comment.


  Fix whitespace

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11197?vs=29125=29130

BRANCH
  overlay-sheet-without-close-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11197

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

To: ngraham, mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11199: Don't show the built-in close button on ProceedDialogs

[Nathaniel Graham]

ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Don't show the Kirigami OverlaySheet's built-in close button, since we draw 
our own
  
  Depends on D11197 

TEST PLAN
  F5747561: after 2.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  no-close-button-on-proceed-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11199

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: ngraham
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29128.
zzag added a comment.


  - move libbreezecommon to another patch

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=29122=29128

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29127.
zzag added a comment.


  - move libbreezecommon to another patch

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29121=29127

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11198: [WIP][libbreezecommon] add box shadow helper

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Breeze, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  TODO: write motivation behind this helper.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11197: Allow OverlaySheets to omit built-in close buttons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: mart, Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Most of the time we want an OverlayDialog to draw a close button so clients 
don't have to. But sometimes clients want to draw their own close buttons, for 
example to use the OverlaySheet as a dialog bux with a Cancel button. In these 
circumstances, we don't need OverlaySheet to draw its own close button. This 
patch makes that possible.

TEST PLAN
  Tested in Discover after applying the patch and adding `showCloseButton: 
false` to DiscoverWindow.qml's proceedDialog:

REPOSITORY
  R169 Kirigami

BRANCH
  overlay-sheet-without-close-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11197

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

To: ngraham, mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10807: fileindexerconfig: Exclude Vaults by default

[Michael Heidelbach]

michaelh added a comment.


  In D10807#222173 , @rkflx wrote:
  
  > Did you already look at which approach Tracker uses regarding filesystems? 
Are they just indexing everything?
  
  
  Nope, good you reminded me. Made a note for myself T8066 
 so I won't forget again.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, 
michaelh, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

T8066: Fix BUG:390830

[Michael Heidelbach]

michaelh added a comment.


  How does tracker handle file systems?

TASK DETAIL
  https://phabricator.kde.org/T8066

To: michaelh
Cc: nicolasfella, ivan, plasma-devel, alexeymin, michaelh, ashaposhnikov, 
spoorun

D11069: [WIP][kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  - split this patch(deco shadow patch and libbreezecommon patch)
  - fix params issues

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag planned changes to this revision.
zzag added a comment.


  - fix params issues

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29122.
zzag added a comment.


  - fix KDE4 build
  - move cmake changes to this patch

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=29073=29122

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29121.
zzag added a comment.


  - fix KDE4 build

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29072=29121

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  > But then, this code is compiled in a separate library ? 
  >  How is it linked against the kstyle code ? Doesn't that require changes to 
CMakeLists ? I'm confused.
  
  Yes, it is compiled as a separate shared library. Yes, it requires changes to 
CMakeLists.txt. (e.g. add `include_directories` and `target_link_libraries`)
  
  > (sorry if I missed something: I have not had the time to actually try apply 
the patches and compile them).
  
  That's good because they don't build with KDE4. (I will post updated patches 
soon)
  
  > So that means that the code is not actually shared, but copied ? I am fine 
with this also, I just don't see how it works here .
  
  For the most part, yes..
  
  It works as follows:
  
  - create a "render" target (`QPixmap` or `QImage`)
  - paint each separate shadow onto that render target with 
`BoxShadowHelper::boxShadow()`. Please note, each shadow is centered around 
some box so all shadows are aligned.
  - clip inner rect
  - pass the result somewhere along
  
  > Not sure I understand what you mean by DRY obsession ?
  
  Some people try to get rid of repetitions even when it's not really needed.
  
  ---
  
  Also, could you please point me out how to create shadows on plugin load? 
Maybe, I could implement it..

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11189: Force a content size into the background style item

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in PrivateActionToolButton.qml:70
> Magic number? Should that be `Kirigami.units.LargeSize` (18) or 
> `Kirigami.units.MediumSize * 2` (16)?

It's just copying the logic that is used above.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11189

To: apol
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11195: Use separate config group for each wallpaper plugin

[Алексей Шилин]

aleksejshilin created this revision.
aleksejshilin added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  Wallpaper plugins were storing their configurations in the same config
  group, overwriting each other's values.

TEST PLAN
0. Apply revision D11194 (plasma-desktop).
1. Right-click the desktop and click Configure Desktop.
2. Select Wallpaper Type -> Plain Color. Click the chooser button
   and select green. Hit Apply.
3. Select Wallpaper Type -> Picture of the Day. Click Background
   Color button and select red. Hit Apply.
4. Select Plain Color type again. The color should still be green.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use_correct_configgroup

REVISION DETAIL
  https://phabricator.kde.org/D11195

AFFECTED FILES
  shell/containmentconfigview.cpp

To: aleksejshilin, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11194: Load correct wallpaper plugin configuration in the dialog

[Алексей Шилин]

aleksejshilin created this revision.
aleksejshilin added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  Wallpaper plugin was previously set for configDialog after StackView.
  The latter, however, is using the former in its onSourceFileChanged
  signal handler. As the result, it was using the previous wallpaper
  plugin configuration instead of the current one.

TEST PLAN
  1. Right-click the desktop and click Configure Desktop.
  2. Select Wallpaper Type -> Plain Color. Click the chooser button and select 
green. Hit Apply.
  3. Select Wallpaper Type -> Haenau and click Apply.
  4. Select Plain Color type again. The color should still be green.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_wallpaper_configuration_dialog

REVISION DETAIL
  https://phabricator.kde.org/D11194

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: aleksejshilin, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D11175#222124 , @zzag wrote:
  
  > In D11175#222001 , 
@hpereiradacosta wrote:
  >
  > > I am confused. Where is the shadow rending code ?
  >
  >
  > `BoxShadowHelper::boxShadow()` does pretty much all rendering.
  >
  > > How is it shared between style and deco ?
  >
  > Only box shadow rendering is shared. It's not obvious to me what I can 
share beside that. Params? Then shadow paint function should receive qpainter 
and the params. What about QMargins? They will be calculated twice and it also 
would require copying logic between kstyle, kdecoration, and libbreezecommon. 
The same applies to the top-left corner of the shadow inner rect and size of 
it. Also, kdecoration renders outline while kstyle not.
  
  
  But then, this code is compiled in a separate library ? 
  How is it linked against the kstyle code ? Doesn't that require changes to 
CMakeLists ? I'm confused. 
  (sorry if I missed something: I have not had the time to actually try apply 
the patches and compile them).
  
  > I believe I could solve this by creating a bunch of classes, but it would 
complicate things a lot more.
  > 
  > //Update//
  >  IMHO, DRY obsession is good, but in this case it would make things worse.
  
  So that means that the code is not actually shared, but copied ? I am fine 
with this also, I just don't see how it works here . 
  Not sure I understand what you mean by DRY obsession ?
  
  >> In general, the sharing should be a separate patch, that could be applied 
even with the current shadows, before modifying how shadows are drawn ... 
  >>  That would make a two steps patch: first share shadow code (with existing 
shadow) between kstyle and decoration, then modify shadow code.
  >> 
  >> Some more comments will follow

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> zzag wrote in breezeshadowhelper.cpp:145
> No, I just prefer this method of initialization of structs. IMHO, it's more 
> readable.
> 
> I'll see what I can do.
> 
> PS. I'd say it looks like js.

yeah well, but unless you sign up as the maintainer of this code, what you 
prefer is not the most relevant, sorry.

What I don't like with this construction is that if I change the name of a 
member of the class, I also have to change all the initializations. 
This is against c++ encapsulation.
Ideally you would even have getters rather than direct access to members.

Please change.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10807: fileindexerconfig: Exclude Vaults by default

[Henrik Fehlauer]

rkflx added a comment.


  Did you already look at which approach Tracker uses regarding filesystems? 
Are they just indexing everything?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, 
michaelh, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11189: Force a content size into the background style item

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> PrivateActionToolButton.qml:70
>  id: layout
> +onImplicitWidthChanged: control.background.contentWidth = 
> implicitWidth + 16
>  anchors.centerIn: parent

Magic number? Should that be `Kirigami.units.LargeSize` (18) or 
`Kirigami.units.MediumSize * 2` (16)?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11189

To: apol
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11190: Make sure we are taking into account hte size of the element when styling

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  See https://phabricator.kde.org/D11189

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11190

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: apol, #frameworks, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11189: Force a content size into the background style item

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise the background will still be rendered without taking into
  account the sizes we offer

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11189

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11175#222001 , 
@hpereiradacosta wrote:
  
  > I am confused. Where is the shadow rending code ?
  
  
  `BoxShadowHelper::boxShadow()` does pretty much all rendering.
  
  > How is it shared between style and deco ?
  
  Only box shadow rendering is shared. It's not obvious to me what I can share 
beside that. Params? Then shadow paint function should receive qpainter and the 
params. What about QMargins? They will be calculated twice and it also would 
require copying logic between kstyle, kdecoration, and libbreezecommon. The 
same applies to the top-left corner of the shadow inner rect and size of it. 
Also, kdecoration renders outline while kstyle not.
  
  I believe I could solve this by creating a bunch of classes, but it would 
complicate things a lot more.
  
  > In general, the sharing should be a separate patch, that could be applied 
even with the current shadows, before modifying how shadows are drawn ... 
  >  That would make a two steps patch: first share shadow code (with existing 
shadow) between kstyle and decoration, then modify shadow code.
  > 
  > Some more comments will follow

INLINE COMMENTS

> hpereiradacosta wrote in breezeshadowhelper.cpp:145
> ok. I know this whole chunc of code is to make it look like css, but this is 
> ugly sorry.
> The fact that you need to repeat all the member names for each new set of 
> parameters is not maintainable in the long run. Please add a proper 
> constructor to the structure (with three params), and use this to initialize 
> the various sets of parameters. 
> Idem in the kdecoration.

No, I just prefer this method of initialization of structs. IMHO, it's more 
readable.

I'll see what I can do.

PS. I'd say it looks like js.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10807: fileindexerconfig: Exclude Vaults by default

[Michael Heidelbach]

michaelh abandoned this revision.
michaelh added a comment.


  Too naive approach

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, 
michaelh, spoorun, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezeshadowhelper.cpp:145
>  }
> +};
>  

ok. I know this whole chunc of code is to make it look like css, but this is 
ugly sorry.
The fact that you need to repeat all the member names for each new set of 
parameters is not maintainable in the long run. Please add a proper constructor 
to the structure (with three params), and use this to initialize the various 
sets of parameters. 
Idem in the kdecoration.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  I am confused. Where is the shadow rending code ? How is it shared between 
style and deco ? 
  In general, the sharing should be a separate patch, that could be applied 
even with the current shadows, before modifying how shadows are drawn ... 
  That would make a two steps patch: first share shadow code (with existing 
shadow) between kstyle and decoration, then modify shadow code.
  
  Some more comments will follow

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, oliverhenshaw.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For preventing screen standby or screen locking the 
`org.freedesktop.ScreenSaver.Inhibit` must be used.
  Both calls erroneously did the same.

TEST PLAN
  Started a video in Chrome, got an inhibition for screen and suspend
  Started audio player in Chrome, got an inhibition for suspend only
  Started a download in Chrome, got an inhibition for suspend only
  Started a video in VLC, got an inhibition for screen and suspend

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D11182

AFFECTED FILES
  daemon/powerdevilfdoconnector.cpp

To: broulik, #plasma, oliverhenshaw
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 165 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/165/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 09 Mar 2018 14:38:48 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.testdesktop

D11180: Reverse tooltip colors for Breeze colorscheme

[Richard Wurth]

rwurth created this revision.
rwurth added a reviewer: Breeze.
rwurth added a project: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
rwurth requested review of this revision.

REVISION SUMMARY
  Hello this patch reverses the background and foreground tooltip colors of the 
breeze colorscheme. The current default black background hides black monochrome 
icons which are used by default, for example, the "fonts" icon in system 
settings.
  
  Before:
  F5747101: Screenshot_20180309_095643.png 

  
  After:
  F5747102: Screenshot_20180309_095749.png 

  
  BUG: 386748
  BUG: 391581
  FIXED-IN: 5.12.4

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

AFFECTED FILES
  colors/Breeze.colors

To: rwurth, #breeze
Cc: rwurth, plasma-devel, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  Yet, I would like to have single shadow size for kstyle shadows.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11175#221928 , @ngraham wrote:
  
  > What shadow size is being used in the screenshot?
  
  
  Large. Well, currently, shadow params are shared among all sizes.
  
  You can help by providing CSS shadows. :)
  
  IMHO, Large and Very Large shadow sizes should not be too "large" and "very 
large". In addition to that, maybe, they have to be lighter than decoration 
shadows.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 164 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/164/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 09 Mar 2018 14:29:23 +
 Build duration:
5 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 1.15 MB...][ 81%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/menuproxy.cpp.o[ 81%] Building CXX object kuiserver/CMakeFiles/kdeinit_kuiserver5.dir/progresslistdelegate.cpp.o[ 81%] Building CXX object soliduiserver/CMakeFiles/soliduiserver.dir/deviceactionsdialog.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/soliduiserver/soliduiserver.cpp:39:/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/soliduiserver/deviceactionsdialog.h:30:36: warning: 'KDialog' is deprecated [-Wdeprecated-declarations]class DeviceActionsDialog : public KDialog   ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdialog.h:128:41: note: 'KDialog' has been explicitly marked deprecated hereclass KDELIBS4SUPPORT_DEPRECATED_EXPORT KDialog : public QDialog //krazy:exclude=qclasses^[ 81%] Building CXX object xembed-sni-proxy/CMakeFiles/xembedsniproxy.dir/debug.cpp.o1 warning generated.Scanning dependencies of target holidaysevents[ 81%] Building CXX object plasmacalendarintegration/CMakeFiles/holidaysevents.dir/holidaysevents.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/soliduiserver/deviceactionsdialog.cpp:20:/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/soliduiserver/deviceactionsdialog.h:30:36: warning: 'KDialog' is deprecated [-Wdeprecated-declarations]class DeviceActionsDialog : public KDialog   ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdialog.h:128:41: note: 'KDialog' has been explicitly marked deprecated hereclass KDELIBS4SUPPORT_DEPRECATED_EXPORT KDialog : public QDialog //krazy:exclude=qclasses^/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/soliduiserver/deviceactionsdialog.cpp:30:7: warning: 'KDialog' is deprecated [-Wdeprecated-declarations]: KDialog(parent)  ^/usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdialog.h:170:41: note: 'KDialog' has been explicitly marked deprecated hereKDELIBS4SUPPORT_DEPRECATED explicit KDialog(QWidget *parent = nullptr, Qt::WindowFlags flags = nullptr);^[ 81%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/window.cpp.o[ 81%] Building CXX object xembed-sni-proxy/CMakeFiles/xembedsniproxy.dir/xembedsniproxy_autogen/mocs_compilation.cpp.o[ 81%] Building CXX object gmenu-dbusmenu-proxy/CMakeFiles/gmenudbusmenuproxy.dir/menu.cpp.o2 warnings generated.[ 82%] Building CXX object soliduiserver/CMakeFiles/soliduiserver.dir/deviceaction.cpp.o[ 82%] Building CXX object kuiserver/CMakeFiles/kdeinit_kuiserver5.dir/requestviewcallwatcher.cpp.o[ 82%] Building CXX object plasmacalendarintegration/CMakeFiles/holidaysevents.dir/holidaysevents_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/gmenu-dbusmenu-proxy/menu.cpp:172:29: warning: comparison of integers of different signs: 'const uint' (aka 'const unsigned int') and 'const int' [-Wsign-compare]return item.section == section;    ^  ~~~/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/gmenu-dbusmenu-proxy/menu.cpp:229:43: warning: comparison of integers of different signs: 'const uint' (aka 'const unsigned int') and 'int' [-Wsign-compare]if (change.itemsToRemoveCount == change.itemsToInsert.count()) {~ ^  /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/gmenu-dbusmenu-proxy/menu.cpp:239:35: warning: comparison of integers of different signs: 'int' and 'const uint' (aka 'const unsigned int') [-Wsign-compare]for (int i = 0; i < change.itemsToRemoveCount; ++i) {~ ^ ~/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/gmenu-dbusmenu-proxy/window.cpp:247:13: error: non-constant-_expression_ cannot be narrowed from type 'uint' (aka 'unsigned int') to 'int' in initializer list [-Wc++11-narrowing]id,^~/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/gmenu-dbusmenu-proxy/window.cpp:247:13: note: insert an explicit cast to silence this issueid,^~static_cast( )[ 82%] Building CXX object soliduiserver/CMakeFiles/soliduiserver.dir/devicenothingaction.cpp.o[ 82%] Linking CXX executable 

D11174: fix detecting changes in sub-pixel and hinting settings

[Julian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ac5c39292836: fix detecting changes in sub-pixel and 
hinting settings (authored by progwolff).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11174?vs=29068=29087

REVISION DETAIL
  https://phabricator.kde.org/D11174

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: progwolff, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Nathaniel Graham]

ngraham added a comment.


  What shadow size is being used in the screenshot?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[Powerdevil] [Bug 365100] Power button ignored

[Peter Kreussel]

https://bugs.kde.org/show_bug.cgi?id=365100

Peter Kreussel  changed:

   What|Removed |Added

 CC||pri...@peter-kreussel.de

--- Comment #2 from Peter Kreussel  ---
Just confirming that this still is the case for me in Plasma 5.12.3., KDE
Frameworks 5.43.0, Qt 5.10.1 

Exactly as orig. reporter describes (button working, systemd-inhibit listing
PowerDevil)

Sorry, no idea how to help, but would have time, if told how to provide
additional info.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  It will soon be this patch 2nd birthday. Can we speed up things a bit? I've 
seen this is scheduled for Plasma 5.13, would be good if we have time to test 
it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, 
plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  Please re-review this and D1231  as I'm 
starting to work on KRfb support for this and it will be the 3rd patch 
depending on this.
  Or suggest reviewers with more spare time so they can look this through.

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11168: [AppMenu Applet] Support actions without menu

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:640042ce0771: [AppMenu Applet] Support actions without 
menu (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11168?vs=29059=29081

REVISION DETAIL
  https://phabricator.kde.org/D11168

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  TODOs(kdecoration and kstyle):
  
  - revise params
  - document how to fill params
  
  @hpereiradacosta: could you please give it first round review code?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11175: [WIP][kstyle] refine shadows

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Breeze, VDG, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  TODO
  
  Depends on D11069 

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29072.
zzag added a comment.


  fix previous update

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=29071=29072

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  CMakeLists.txt
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 29071.
zzag added a comment.


  move box shadow helper out to a separate library

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28893=29071

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11174: fix detecting changes in sub-pixel and hinting settings

[Julian Wolff]

progwolff created this revision.
progwolff added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
progwolff requested review of this revision.

REVISION SUMMARY
  Since #R119, on changes to the sub-pixel and hinting comboboxes, the "apply" 
button stays disabled.
  This patch fixes this, so that one can actually apply changes to the font 
rendering settings.

TEST PLAN
  Open the fonts kcm and change the sub-pixel or hinting settings. The apply 
button should be enabled.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11174

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: progwolff, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Fabian Riethmayer]

fabianr added a comment.


  In D11069#221381 , @zzag wrote:
  
  > So, I'd spent last two hours trying to find good menu shadow params.. HIG 
guidelines don't say too much about shadows(also, navigating them is hard) so I 
don't know whether these shadows are good.
  
  
  As you noticed HIG has very few information on shadows, it would be great if 
the results of this review could also be added to the hig. 
  https://hig.kde.org/resources/contribute.html

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11168: [AppMenu Applet] Support actions without menu

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Applications could place actions in the main menu bar that do not have a menu.
  Also restore the `checked` binding when clicked to avoid it highlighting even 
though there is no menu. Also might fix some spurious highlighting that I've 
seen when switching between windows.

TEST PLAN
  Had an application with actions without menu and could trigger them just fine.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11168

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart