D1231: Add Remote Access interface to KWayland

[Jaime Torres Amate]

jtamate added a comment.


  As I don't see anything related to security in this patch, I have two 
questions.
  
  Could anyone with access to server:port manage the server wayland sessions or 
just create a new session? 
  The access control should be done in the firewall?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  In D1231#224441 , @jtamate wrote:
  
  > As I don't see anything related to security in this patch, I have two 
questions.
  >
  > Could anyone with access to server:port manage the server wayland sessions 
or just create a new session? 
  >  The access control should be done in the firewall?
  
  
  What port? This patch doesn't expose any port.
  No, nobody can manage server sessions with this protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11262: KDE logout screen background color fix

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> Logout.qml:87
> +function isLightColor(color) {
> +return Math.max(color.r, color.g, color.b) > 0.5
>  }

the method lattes is using 0.2126*r + 0.7152*g + 0.0722*b is more correct
(a simple one would be convertin to gray scale with  qGray, but unfortunately 
is C++ only)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11257: Improve By Desktop sorting for task groups

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a9df1e20f527: Improve By Desktop sorting for task groups 
(authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11257?vs=29309&id=29393

REVISION DETAIL
  https://phabricator.kde.org/D11257

AFFECTED FILES
  libtaskmanager/taskgroupingproxymodel.cpp

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Marco Martin]

mart added a comment.


  In D11253#223766 , @broulik wrote:
  
  > +1
  >
  > I just hope it won't make the menu too wide „Arbeitsfläche und 
Hintergrundbild einrichten“ is what I guess it would be for my locale (but then 
we already have „Inhalt der Zwischenablage einfügen“ for Paste) so that is not 
a big deal ;)
  
  
  maybe an i18nc in which in the context one says "plz keep this as short as 
pssible bcause is a context menu"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11254: Fix scrollbar on empty search results

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7ddd20cfd35d: Fix scrollbar on empty search results 
(authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11254?vs=29305&id=29394

REVISION DETAIL
  https://phabricator.kde.org/D11254

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/RunnerResultsList.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Marco Martin]

mart added a comment.


  I'm really against manual reordering and saving.. as the only thing i would 
like for the systray is to make it simpler, not more complicated :p
  that said yes, icons need to be in a more predictable, or at least consistent 
position
  
  I think it would be fairly predictable if we restore orderng per type.. and 
then maybe alphabetically, which would still look kinda random but at least 
always stable.
  all of this could be done with just a simple sortfilterproxymodel

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: mart, broulik, ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11233: Ordered system tray

[Marco Martin]

mart added a comment.


  In D11233#223694 , @ngraham wrote:
  
  > In D11233#223661 , @broulik 
wrote:
  >
  > > Drag and drop might be an acceptable way to rearrange them but then I 
think we should just have a smarter more predictable sorting logic (currently 
it's on a first come first serve basis) and the need for this should go away.
  >
  >
  > ...As long as we can ensure that things come and are served in the same 
order every time, because muscle memory is important.
  
  
  for purely the muscle memory standpoint perhaps is even better the current 
way theoretically,  even tough in practiche has been found to be confusing.. as 
when a new icon appear is always at the beginning, therefore it doesn't move 
any other icon, while if it was ordered more icons would change their place

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: mart, broulik, ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11220: option to force FolderView icon-only presentation

[Marco Martin]

mart added a comment.


  Shouldn't the quick launch applet cover this use case?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11180: Reverse tooltip colors for Breeze colorscheme

[Marco Martin]

mart added a comment.


  I also personally prefer dark tooltips.
  
  anyways this change has to be agreed upon widely in the VDG

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

To: rwurth, #breeze, #vdg
Cc: mart, broulik, progwolff, ngraham, rwurth, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11166: Simplify display when there's only a single input device and a single output device

[Marco Martin]

mart added a comment.


  i like it in principle. could it be less obviout tough which is the output 
and which is the input?
  i know there are the speaker and microphone icons, but they are small and 
secondary.. maybe in this case the soundcard icon should be dropped and the 
speaker/microphone take its place? or maybe swapped in general, and have a 
bigger speaker and the soundcard just a tiny think at its corner... if needed 
at all, i find it not too important information

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  In D11220#224622 , @mart wrote:
  
  > Shouldn't the quick launch applet cover this use case?
  
  
  The quick launch applet can show folder contents or activities-pinned 
documents?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11180: Reverse tooltip colors for Breeze colorscheme

[Richard Wurth]

rwurth added a comment.


  Okay! I never made a patch before or anything so I don't necessarily know the 
procedure, just wanted to throw in my two cents. Thanks for taking a look!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11180

To: rwurth, #breeze, #vdg
Cc: mart, broulik, progwolff, ngraham, rwurth, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11262: KDE logout screen background color fix

[Fredrik Höglund]

fredrik added inline comments.

INLINE COMMENTS

> mart wrote in Logout.qml:87
> the method lattes is using 0.2126*r + 0.7152*g + 0.0722*b is more correct
> (a simple one would be convertin to gray scale with  qGray, but unfortunately 
> is C++ only)

qGray() uses an integer approximation that is only correct for CRT monitors.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Kai Uwe Broulik]

broulik added a comment.


  >   "plz keep this as short as pssible bcause is a context menu"
  
  Widget apps use `i18nc("@action:inmenu", "...")`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11274: Fix font rendering for non-HiDPI and integer scale factors

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9a5f7d834f86: Fix font rendering for non-HiDPI and 
integer scale factors (authored by ngraham).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11274?vs=29365&id=29401

REVISION DETAIL
  https://phabricator.kde.org/D11274

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml

To: ngraham, mart, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 187 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/187/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Mar 2018 14:22:00 +
 Build duration:
1 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 133.10 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Built target PaginateModelTest_autogenScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 10%] Linking CXX shared library libDiscoverNotifiers.so[ 10%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogen[ 11%] Automatic MOC for target DummyNotifier[ 11%] Built target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[ 12%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[ 12%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target DummyNotifier[ 13%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 14%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.oScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 15%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 17%] Linking CXX shared module DummyNotifier.so[ 17%] Built target DummyNotifier[ 18%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 20%] Linking CXX executable PaginateModelTest[ 20%] Built target PaginateModelTest[ 21%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 21%] Built target DiscoverCommon_autogen[ 21%] Built target DiscoverNotifierDeclarativePluginScanning dependencies of target DiscoverCommon[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 359 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/359/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 14:22:00 +
 Build duration:
5 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 192.00 KB...]Scanning dependencies of target knsbackendtest_autogenScanning dependencies of target CategoriesTest_autogenScanning dependencies of target dummytest_autogen[ 54%] Automatic MOC for target dummy-backend[ 55%] Automatic MOC for target dummytest[ 56%] Automatic MOC for target updatedummytest[ 57%] Automatic MOC for target kns-backend[ 58%] Automatic MOC for target CategoriesTest[ 59%] Automatic MOC for target knsbackendtest[ 59%] Built target knsbackendtest_autogenScanning dependencies of target plasma-discover_autogen[ 59%] Built target dummytest_autogen[ 59%] Built target CategoriesTest_autogen[ 60%] Automatic MOC for target plasma-discoverScanning dependencies of target plasma-discover-exporter_autogen[ 60%] Built target updatedummytest_autogen[ 61%] Automatic MOC for target plasma-discover-exporterScanning dependencies of target knsbackendtest[ 62%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 62%] Built target dummy-backend_autogenScanning dependencies of target dummytest[ 62%] Built target plasma-discover-exporter_autogen[ 63%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 64%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.oScanning dependencies of target CategoriesTest[ 64%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.o[ 64%] Built target kns-backend_autogenScanning dependencies of target dummy-backend[ 65%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 65%] Built target plasma-discover_autogen[ 66%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 67%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:22:0:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyResource.h:27:7: note:   because the following virtual functions are pure within ‘DummyResource’: class DummyResource : public AbstractResource   ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResourcesBackend.h:28:0, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.h:24, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:21:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResource.h:206:23: note: 	virtual QDate AbstractResource::releaseDate() const virtual QDate releaseDate() const = 0;   ^~~/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:74:64: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, true, this);^/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘virtual AbstractResource* DummyBackend::resourceForFile(const QUrl&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:154:71: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(path.fileName(), true, this);   ^make[2]: *** [libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/build.make:87: libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o] Error 1make[2]: *** Waiting for unfinished jobs[ 68%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.c

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 188 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/188/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Mar 2018 14:27:40 +
 Build duration:
1 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 132.46 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Built target PaginateModelTest_autogenScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 10%] Linking CXX shared library libDiscoverNotifiers.so[ 10%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogen[ 11%] Automatic MOC for target DummyNotifier[ 11%] Built target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[ 12%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[ 12%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target DummyNotifier[ 13%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.oScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 14%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 15%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 17%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 18%] Linking CXX shared module DummyNotifier.so[ 18%] Built target DummyNotifier[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 20%] Linking CXX executable PaginateModelTest[ 20%] Built target PaginateModelTest[ 21%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 21%] Built target DiscoverNotifierDeclarativePlugin[ 21%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverCommon[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.d

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 360 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/360/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 14:27:40 +
 Build duration:
4 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 206.21 KB...] from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 69%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[ 71%] Linking CXX executable CategoriesTestScanning dependencies of target kns-backend[ 72%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 73%] Linking CXX executable knsbackendtest[ 73%] Built target CategoriesTest[ 74%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 75%] Linking CXX executable plasma-discover-exporter[ 75%] Built target knsbackendtest[ 76%] Linking CXX executable dummytest[ 76%] Built target plasma-discover-exporter[ 77%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSReviews.cpp.oScanning dependencies of target dummy-backendScanning dependencies of target updatedummytest[ 78%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 79%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.o[ 79%] Built target dummytest[ 80%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.o[ 81%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/updatedummytest_autogen/mocs_compilation.cpp.o[ 82%] Generating qrc_assets.cpp[ 83%] Generating qrc_resources.cppScanning dependencies of target plasma-discover[ 84%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_resources.cpp.o[ 85%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 86%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o[ 87%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_assets.cpp.o[ 87%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/kns-backend_autogen/mocs_compilation.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:22:0:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyResource.h:27:7: note:   because the following virtual functions are pure within ‘DummyResource’: class DummyResource : public AbstractResource   ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResourcesBackend.h:28:0, from /home/jenkins/workspace/Plasma discove

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 189 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/189/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 13 Mar 2018 14:55:55 +
 Build duration:
2 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 133.24 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Built target PaginateModelTest_autogen[  6%] Linking CXX shared library libDiscoverNotifiers.so[  6%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[  7%] Automatic MOC for target DummyNotifier[  8%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[  8%] Built target DummyNotifier_autogenScanning dependencies of target DummyNotifierScanning dependencies of target PaginateModelTest[  9%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 10%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[ 11%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 12%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[ 12%] Built target DiscoverNotifierDeclarativePlugin_autogen[ 13%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[ 14%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 15%] Linking CXX shared module DummyNotifier.so[ 15%] Built target DummyNotifierScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 17%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 18%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 19%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverCommon[ 20%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 21%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 22%] Linking CXX executable PaginateModelTest[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 25%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 25%] Built target DiscoverNotifierDeclarativePlugin[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 26%] Built target PaginateModelTest[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 361 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/361/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 13 Mar 2018 14:55:55 +
 Build duration:
4 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 206.75 KB...] from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 69%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[ 70%] Linking CXX executable plasma-discover-exporter[ 71%] Linking CXX executable CategoriesTest[ 71%] Built target plasma-discover-exporter[ 72%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 73%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/dummytest_autogen/mocs_compilation.cpp.o[ 73%] Built target CategoriesTestScanning dependencies of target dummy-backend[ 74%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 75%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 76%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSReviews.cpp.o[ 77%] Linking CXX executable knsbackendtest[ 77%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/kns-backend_autogen/mocs_compilation.cpp.o[ 77%] Built target knsbackendtestScanning dependencies of target updatedummytest[ 78%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.o[ 79%] Linking CXX executable dummytest[ 80%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 81%] Generating qrc_assets.cpp[ 82%] Generating qrc_resources.cppScanning dependencies of target plasma-discover[ 83%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_resources.cpp.o[ 83%] Built target dummytest[ 84%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o[ 85%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_assets.cpp.o[ 86%] Building CXX object discover/CMakeFiles/plasma-discover.dir/main.cpp.o[ 87%] Linking CXX shared module kns-backend.so/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:22:0:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyResource.h:27:7: note:   because the following virtual functions are pure within ‘DummyResource’: class DummyResource : public AbstractResource   ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResourcesBackend.h:28:0, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.h:24, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:21:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResource.h:206:23: note: 	virtual QDate AbstractResource::releaseDate() const virtual QDate releaseDate() const = 0;   ^~~/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:74:64: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, true, this);^/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘virtual AbstractResource* DummyBackend::resourceForFi

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

[Nathaniel Graham]

ngraham added a comment.


  So what's our path forward here? We have some positive votes and some 
negative votes. Do we need to first have a wider conversation on wallpaper 
discoverability and then later circle back to something we can all agree on?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11289: checkable FormLayout items

[Julian Wolff]

progwolff created this revision.
progwolff added reviewers: VDG, Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
progwolff requested review of this revision.

REVISION SUMMARY
  In some cases, form items go together with a checkbox which can be used to 
disable the item.
  An example for such an item is the line edit in the first row of the 
screenlocker kcm.
  Here, a checkbox is prepended to the line edit's label.
  
  In Kirigami, there is (afaik) no way to add a widget to a FormLayout item's 
buddyComponent.
  This patch adds an optional combobox to the buddyComponent.
  
  A place where I would like to use this is the fonts kcm: 
https://phabricator.kde.org/T7927#132277

TEST PLAN
  I added a checkable item to the FormLayout gallery page.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11289

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/FormLayoutGallery.qml
  src/controls/templates/FormLayout.qml
  src/formlayoutattached.cpp
  src/formlayoutattached.h

To: progwolff, #vdg, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11166: Simplify display when there's only a single input device and a single output device

[Nathaniel Graham]

ngraham added a comment.


  In D11166#224628 , @mart wrote:
  
  > i like it in principle. could it be less obviout tough which is the output 
and which is the input?
  >  i know there are the speaker and microphone icons, but they are small and 
secondary.. maybe in this case the soundcard icon should be dropped and the 
speaker/microphone take its place? or maybe swapped in general, and have a 
bigger speaker and the soundcard just a tiny think at its corner... if needed 
at all, i find it not too important information
  
  
  Yeah, I agree with you, and I'm not too happy with the icons either. I was 
planning to address that in a follow-up patch, since they're still odd in many 
contexts when the full layout is used.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11103: Move "Standard Shortcut" KCM down in the list

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:51dd27e72640: Move "Standard Shortcut" KCM down 
in the list (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11103?vs=28870&id=29414

REVISION DETAIL
  https://phabricator.kde.org/D11103

AFFECTED FILES
  kcms/standard_actions/standard_actions.desktop

To: broulik, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D1230: GBM remote access support for KWin

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> romangg wrote in drm_output.h:139
> Is it only a friend class to access `m_waylandOutput.data()`? In this case 
> better create a getter for it in DrmOutput.
> 
> Or better do the `passBuffer` call in `DrmBackend::present` and give instead 
> of the DrmOutput the `KWayland::Server::OutputInterface` from there to 
> `passBuffer`.

Regarding the "better" part: you would need the `m_remoteaccessManager` in 
`DrmBackend`.  Only with EGL/GBM this would then be set. I.e. in QPainter 
`DrmBackend` would ignore it.

But that's maybe a bit too much (also you would need to change the buffer cast 
in passBuffer). So better just add a getter in DrmOutput.

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11109: [Notifications] Remove NoAccessNetworkAccessManagerFactory

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:71f168818439: [Notifications] Remove 
NoAccessNetworkAccessManagerFactory (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11109?vs=28890&id=29415#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11109?vs=28890&id=29415

REVISION DETAIL
  https://phabricator.kde.org/D11109

AFFECTED FILES
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/notificationshelperplugin.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11166: Simplify display when there's only a single input device and a single output device

[David Rosca]

drosca added a comment.


  There is still one case where this may not be wanted: when you have two cards 
and first have only sink and second source.
  
  Also this doesn't apply to Applications tab, why?

INLINE COMMENTS

> DeviceListItem.qml:39
> +}
> +labelOpacity: onlyOne ? 1 : 0.6
>  icon: {

Why do you change opacity? It makes it inconsistent with applications tab.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca, #vdg
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D6313: WIP: Support device pixel ratio in icon loader and engine

[Andrew Crouthamel]

acrouthamel added a comment.


  Hey there, any movement on this? I've been submitting some patches to fix 
icon scaling in apps and have noticed how they switch from monochrome to 
colored (hires) versions when fixed. Getting the underlying issue fixed would 
be great as more people buy HiDPI/Retina displays and run with scaling.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11166: Simplify display when there's only a single input device and a single output device

[Nathaniel Graham]

ngraham added a comment.


  In D11166#224808 , @drosca wrote:
  
  > There is still one case where this may not be wanted: when you have two 
cards and first have only sink and second source.
  
  
  Can you help me understand why this might be unwanted in that circumstance? 
You'd still have only one input and one output, no?
  
  > Also this doesn't apply to Applications tab, why?
  
  If you want, I can do the same there too. But I opted not to since the 
Applications tab is a more advanced UI and will only more rarely have a single 
playback stream and a single capture stream.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca, #vdg
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11166: Simplify display when there's only a single input device and a single output device

[David Rosca]

drosca added a comment.


  In D11166#224814 , @ngraham wrote:
  
  > Can you help me understand why this might be unwanted in that circumstance? 
You'd still have only one input and one output, no?
  
  
  In case where both cards support both input/output, but it was disabled by 
selecting according profile, I think it is still useful to know from which card 
it comes.
  
  > If you want, I can do the same there too. But I opted not to since the 
Applications tab is a more advanced UI and will only more rarely have a single 
playback stream and a single capture stream.
  
  Here I would like to hide the header when there are only apps playing audio, 
not recording. This should be the most common case.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca, #vdg
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11166: Simplify display when there's only a single input device and a single output device

[Nathaniel Graham]

ngraham added a comment.


  In D11166#224822 , @drosca wrote:
  
  > In D11166#224814 , @ngraham 
wrote:
  >
  > > Can you help me understand why this might be unwanted in that 
circumstance? You'd still have only one input and one output, no?
  >
  >
  > In case where both cards support both input/output, but it was disabled by 
selecting according profile, I think it is still useful to know from which card 
it comes.
  
  
  If that's a hard requirement for this patch, I might need some help with it.
  
  >> If you want, I can do the same there too. But I opted not to since the 
Applications tab is a more advanced UI and will only more rarely have a single 
playback stream and a single capture stream.
  > 
  > Here I would like to hide the header when there are only apps playing 
audio, not recording. This should be the most common case.
  
  OK, I can do that.

INLINE COMMENTS

> drosca wrote in DeviceListItem.qml:39
> Why do you change opacity? It makes it inconsistent with applications tab.

Check out the screenshot. If I hadn't conditionally changed the opacity here, 
then in the Simple Mode, the header text would look very light, instead of 
being fully opaque.= the way it should be.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca, #vdg
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D11262: KDE logout screen background color fix

[Radek Hušek]

Pitel added a comment.


  I see that relative luminance formula is more correct but I would like to 
point out that we do not need here to calculate precise luminance. The point of 
the `?:` statement is to collapse colors close to back to real black because 
gray overlay with 50 % opacity does not look good. So the current formula looks 
good enough for me and I would even think about moving the threshold down a bit 
to 0.4 or 0.3. (Generally not collapsing to black is the save way, it may not 
look so good but the text will be still easy to read.)
  
  For reference a screenshot with gray background (similar to default breeze) 
without collapsing it to black: F5752690: Screenshot_20180313_175108.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg added a comment.


  Do typedefs for `KWayland::Server::LinuxDmabuf` in files where you use it 
more than once.

INLINE COMMENTS

> abstract_egl_backend.cpp:346
>  
> +void AbstractEglBackend::aboutToDestroy(EglDmabufBuffer *buffer)
> +{

Name should be more descriptive in relation to functionality, also it's not a 
signal, so "aboutTo" imo not recommended.

Suggestion: `removeDmabufBuffer`

> abstract_egl_backend.h:100
>  QList m_clientExtensions;
> +QLinkedList m_dmabufBuffers;
> +bool m_haveDmabufImport = false;

Why QLinkedList? It should be no better than QList for the removeOne call. For 
this better use QSet.

> abstract_egl_backend.h:135
>  
> +class KWIN_EXPORT EglDmabufBuffer : public 
> KWayland::Server::LinuxDmabuf::Buffer
> +{

Why is it necessary to export?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin
Cc: romangg, anthonyfieroni, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg added a comment.


  In D10750#216337 , @fredrik wrote:
  
  > An issue that this patch does not fully address is switching compositing 
backends at runtime.
  
  
  Do we support that at all? The backend is set at startup. Don't think you can 
change this later on.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin
Cc: romangg, anthonyfieroni, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  My try at ordered system try heavily inspired by D11233 
.
  
  Features (and problems):
  
  - the main intention was to keep code as simple as possible
  - items can be reordered by drag & drop and removed from config by dragging 
into trash bin
  - item list is by design loaded only at opening settings dialog (doing 
on-the-fly updates seems complicated for very little gain)
  - new items are added at right end of systray and remeber their position (so 
the first start the order will be random but on subsequent starts the order 
will remain the same)
  - all this is backed by only one new config option `itemOrder` of type 
`StringList`
  - items currently not existent are displayed in italics (and without icon 
because there is nowhere to get it)
  - now also all status notifier items are always in italics because I removed 
using `statusNotifierModel` from setting which solves crash after closing 
setting (and ugly > crash)
  - contains an ugly hack to workaround `ComboBox`'es going crazy when 
`TableView` model is changed (I have no clue what causes this, only than 
`currentItem` binding is not to blame)
  - the drag & drop support was adapted from R884 
 (most 
notably `OrderItem.qml` comes from there and was only lightly modified
  
  Any c

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray

REVISION DETAIL
  https://phabricator.kde.org/D11292

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/OrderableItem.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11233: Ordered system tray

[Radek Hušek]

Pitel added a comment.


  I really like the idea of being able to reorder the systray as I wish. I 
could not resist and took my stab on the issue (with drag&drop) D11292 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11233

To: wsdfhjxc, #plasma_workspaces, #plasma, #vdg
Cc: mart, broulik, ngraham, anthonyfieroni, Pitel, alexeymin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi added a comment.


  Any more thoughts on this patch before it is ready to land?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[Nathaniel Graham]

ngraham added a comment.


  Sometimes silence equals consent, especially when there have been many 
requests for comment. If nobody else has an opinion before then, I propose 
landing this on March 20th.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Wojciech Stachurski]

wsdfhjxc added a comment.


  As for the getFixedItemId function (which was connected to an id trimming 
method in my example), it was because of Dropbox client's StatusNotifier item 
having some random number suffix. Without this, at every boot it was duplicated 
in the new config list-type property with a new id and the previous one was 
stalled because of its id mismatch. So, I just wanted to let you know that 
there might be a problem for items identified with some randomly generated 
names. Although, it seems to be extremely rare, as I've only noticed Dropbox 
client doing this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel
Cc: wsdfhjxc, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[Aleix Pol Gonzalez]

apol added a comment.


  Here's some thoughts:
  
  - Why is there only one with the keyboard shortcut? many of these have (e.g. 
run a command)
  - maybe sort the menu alphabetically first? or there's any meaning?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel added a comment.


  I am aware of `getFixedItemId`, only forgot to mention it in summary. Right 
now it is not included mostly because it is another hack (but fixing stupid 
behavior of someone else so unavoidable) and I do not use DropBox, but if this 
gets any closer to landing, we should reintroduce it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel
Cc: wsdfhjxc, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi added a comment.


  In D10297#224935 , @apol wrote:
  
  > Here's some thoughts:
  >
  > - Why is there only one with the keyboard shortcut? many of these have 
(e.g. run a command)
  
  
  The initial idea of the tools menu was to make the Kill Window more 
discoverable. Yes, Run Command has also a global shortcut (but it is the only 
additional one). I didn't think of adding the shortcut because there are 
several ways to start a program.
  
  > - maybe sort the menu alphabetically first? or there's any meaning?
  
  I put Konsole first, because, in my experience, this is what most likely 
works in case of some unexpected Plasma behaviour.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: Compile kwin using yocto for embedded systems (opengles)

[Jörn M]

Thanks for your reply Martin.

I see the following possibilities to address this error:
>  * forward declare Display (struct Display should be sufficent)
>  * disable building of the EglOnXBackend
> Given that epoxy seems to not have X11 support I would say the second
> option is the proper one. But it would mean no compositing support on X11
> in this build. This makes only sense if you want to use Wayland. If you
> want to use KWin on X11 you need to get epoxy to support X11.


I followed your second suggestion and disabled EglOnXBackend backend since
I don't want to use X11.
Following patch works and I could compile kwin.

https://paste.kde.org/p2rvhzgmc

Nevertheless, in this state I was not able to start kwin at all. Kwin told
me that no backend is available.
Below the full story how I got kwin working, maybe it's useful for someone
else out there.


For fast comparison I enabled weston in my yocto configuration.
Weston only found fbdev as  backend. No egl accelerated backend was
available.

It seems that there are currently two ways to get hardware accelerated
rendering with a wayland compositor on raspberry pi:

1. raspberrypi specific userand driver (proprietary)
  - qtbase with raspberrypi specific eglfs backend
 - qtwayland with raspberrypi specific eglfs backend
2. raspberrypi specific drm driver (open source vc4)
  - qtbase with drm, kms and eglfsdevice
 - weston using drm with egl
 - kwin using drm with egl

At this point I was on the first track. But there is no backend available
for kwin and also not for weston.
Raspberry pi specific backend was dropped from weston because of
maintenance:
https://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/commit/?h=rocko&id=a1cfeb3324c458a73507e34ffcf28c25591b8052

I changed my yocto configuration to the second approach:

remove:
#IMAGE_INSTALL_append = " userland"
add:
MACHINE_FEATURES_append = " vc4graphics"

qtbase configuration also needs adjustment (enable kms and gbm)
https://paste.kde.org/povjpohkv

Weston runs nicely at this point with following commands:

export XDG_RUNTIME_DIR=/tmp/${UID}-runtime-dir
mkdir "${XDG_RUNTIME_DIR}"
chmod 0700 "${XDG_RUNTIME_DIR}"
weston --backend=drm-backend.so --tty=4

Nevertheless weston is complaining about logind issue:

[15:38:26.505] logind: failed to get session seat
[15:38:26.505] logind: cannot setup systemd-logind helper (-61), using
legacy fallback

Trying kwin:

export $(dbus-launch)
kwin_wayland --drm

Kwin runs without any output message. It seems to hang. After a bit of
debugging with GDB it turns out that kwin waits for a logind session.
This could also be made visible by:

export QT_LOGGING_RULES="kwin_core.debug=true;kwin_wayland_drm.debug=true"

To shorten this up here, it was not enough to enable logind and pam support
in systemd.
It is needed to enable pam support in yocto distro features. Otherwise
login does not create a logind session with pam.

DISTRO_FEATURES_append = " systemd wayland x11 wifi pam"

Now running kwin_wayland --drm results in following output executed from
ssh:

kwin_core: Platform does not support input, enforcing libinput support
kwin_core: KGlobalAcceld inited
kwin_core: Session path: "/org/freedesktop/login1/session/c1"
kwin_core: "logind"  seat: "" / "/"
kwin_core: "logind"  seat: "" / "/"
kwin_core: Gained session control
kwin_core: Could not take device /dev/input/event0 , cause:  "Operation not
permitted"
kwin_core: Could not take device /dev/dri/card0 , cause:  "Operation not
permitted"

Running the same on the terminal from raspberry pi (hdmi terminal) results
in a working kwin :-D

Any ideas how to start kwin properly from ssh?

Regards,
Jörn


2018-03-01 21:29 GMT+01:00 Martin Flöser :

> Am 2018-03-01 20:56, schrieb Jörn M:
>
>> I simply did the same as above for kdeclarative and applied the few
>> lines from kwin's kwinglutils_funcs.h
>> on all places where the error occurs:
>>
>> https://paste.kde.org/pgtkzf5yu
>>
>
> see also https://phabricator.kde.org/D10762
>
>
>> This leads me to the final error I'm not able to solve:
>>
>> eglonxbackend.h:36:27: error: expected ')' before '*' token
>> |  EglOnXBackend(Display *display);
>> |^
>> |
>> /home/joern/yocto/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-
>> gnueabi/kwin/5.12.1-r0/git/plugins/platforms/x11/common/
>> eglonxbackend.h:37:58:
>> error: 'Display' has not been declared
>>
>> https://paste.kde.org/pimqgxedi
>>
>> Which component normally declares "Display"?
>>
>
> Display is the XLib Display. It comes in with anything pulling in XLib. So
> most likely the reason for the compile error is that this gets pulled in
> through epoxy normally, but on yocto epoxy is probably built without X11
> support (which might be questionably, but so what).
>
> I see the following possibilities to address this error:
>  * forward declare Display (struct Display should be sufficent)
>  * disable building of the EglOnXBackend
>
> Given that epoxy 

D11292: [RFC] Ordered system tray v2

[Wojciech Stachurski]

wsdfhjxc added a comment.


  In D11292#224949 , @Pitel wrote:
  
  > I am aware of `getFixedItemId`, only forgot to mention it in summary. Right 
now it is not included mostly because it is another hack (but fixing stupid 
behavior of someone else so unavoidable) and I do not use DropBox, but if this 
gets any closer to landing, we should reintroduce it.
  
  
  As you said, that was a hack, and honestly I don't think it should be 
included because it's not the system tray applet's job to fix item 
identificators. Maybe some other component, e.g. related to StatusNotifier item 
registration, would be the place to look into. If not, the Dropbox client would 
be exceptionally placed always at the last position, but still there is a 
problem with previous entries stalled in the config property.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel
Cc: wsdfhjxc, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> ConfigEntries.qml:110-119
> +  /*  for (var i = 0; i < statusNotifierModel_cfg.count; ++i) {
> +var item = statusNotifierModel.get(i);
> +itemInfo[item.Id] = {
>  "taskId": item.Id,
>  "name": item.Title,
>  "iconName": item.IconName,
> +"icon": item.Icon,

Commented code is not allowed to get in, you should decide it's needed or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel
Cc: anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 29433.
Kanedias marked 6 inline comments as done.
Kanedias added a comment.


  Review fixes

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1230?vs=28973&id=29433

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

AFFECTED FILES
  plugins/platforms/drm/CMakeLists.txt
  plugins/platforms/drm/drm_buffer_gbm.h
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added inline comments.

INLINE COMMENTS

> romangg wrote in egl_gbm_backend.cpp:160
> Should be the default not directly activated remote funcitonality? And if one 
> wants to deactivate remote set `KWIN_NO_REMOTE` or something.

There's no authentication protocol, so any malicious application can get whole 
screencast for free.
But that's another story as we're getting full input control already in 
fakeinput-protocol.
Changed.

> romangg wrote in remoteaccess_manager.cpp:85
> This will spam the debug because it is called on every present.

Removed both this and the one at line 77

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11292: [RFC] Ordered system tray v2

[David Edmundson]

davidedmundson added a comment.


  FWIW, the crash you're referring to is also fixed with an up-to-date (not 
released yet) Qt.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 29434.
Kanedias added a comment.


  Typo

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1230?vs=29433&id=29434

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

AFFECTED FILES
  plugins/platforms/drm/CMakeLists.txt
  plugins/platforms/drm/drm_buffer_gbm.h
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel added a comment.


  In D11292#225006 , @davidedmundson 
wrote:
  
  > FWIW, the crash you're referring to is also fixed with an up-to-date (not 
released yet) Qt.
  
  
  If you are referring to https://codereview.qt-project.org/#/c/50/ I tried 
patching my Qt with it and it prevents the crash but after closing settings the 
systray starts to misbehave instead. Qml reports a lot of `TypeError`'s in 
`AbstractItem.qml` in assignment:
  
onContainsMouseChanged: {
if (hidden && containsMouse) {
root.hiddenLayout.hoveredItem = abstractItem
}
}
  
  And plasmoids in systray stop responding to mouse clicks or expand inside of 
systray (like if some objects got reparented wrong?).
  
  But that might be result of me cherry-picking one patch on top of 5.9.4 qt...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Ping. The current version adds a configuration option `fillWidth` (enabled by 
default) which allows the applet to grow beyond its preferred size. I tested it 
in usual setup and with `fillWidth` enabled the behavior is unchanged.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D8302: Add FreeBSD port from the development-repo

[Michail Vourlakos]

mvourlakos accepted this revision.
mvourlakos added a comment.
This revision is now accepted and ready to land.


  sorry, I missed that...

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8302

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos updated this revision to Diff 29439.
mvourlakos added a comment.


  - update semantics based on feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11220?vs=29195&id=29439

BRANCH
  alwaysShowAsIcon

REVISION DETAIL
  https://phabricator.kde.org/D11220

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/main.qml

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11220: option to force FolderView icon-only presentation

[Michail Vourlakos]

mvourlakos added a comment.


  settings window looks like:
  
  F5752898: εικόνα.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D11166: Simplify display when there's only a single input device and a single output device

[Nathaniel Graham]

ngraham updated this revision to Diff 29440.
ngraham added a comment.


  Also implement Simple Mode for the App tab, when there are only apps playing 
or recording, but not both

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11166?vs=29133&id=29440

BRANCH
  simplify-single-device-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11166

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: ngraham, #plasma, drosca, #vdg
Cc: mart, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Ricardo J . Barberis]

https://bugs.kde.org/show_bug.cgi?id=350365

Ricardo J. Barberis  changed:

   What|Removed |Added

 CC||ricardo.barbe...@gmail.com

--- Comment #19 from Ricardo J. Barberis  ---
I have the same problem, sometimes when I reboot my laptop the battery monitor
shows no battery present and if I relogin it shows it correctly.

I noticed that if I reboot my laptop with my wireless mouse's dongle unplugged
the battery monitor usually works fine.

With the mouse's wireless dongle plugged in, it usually fails to detect any
battery.

Maybe it's something related to trying to detect the mouse's battery?

I remember reading on Planet KDE that the battery monitor should show you
mouse/keyboard battery status but it never worked for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11292: [RFC] Ordered system tray v2

[Wojciech Stachurski]

wsdfhjxc added a comment.


  I think it would be better to place new items on the left side of the system 
tray, as this is closer to default behavior. Also, sometimes the visibility 
state is updated incorrectly after moving items back and forth (showing hidden 
state for visible items). Other than that, works very nicely. It's indeed much 
easier to drag the items around instead of clicking their arrows multiple 
times. Thanks for tackling this!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, broulik, Fuchs.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Notifications Plasmoids recently gained a Clear History button! This 
patch gives it some text so it's a bit clearer, since otherwise it's just a 
little clear button potentially in a sea of other clear buttons

TEST PLAN
  [Image does here]

REPOSITORY
  R120 Plasma Workspace

BRANCH
  clear-all-button-has-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11306

AFFECTED FILES
  applets/notifications/package/contents/ui/Notifications.qml

To: ngraham, #plasma, broulik, Fuchs
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11306: Give the "Clear History" button some text

[Vlad Zagorodniy]

zzag added a comment.


  Could another icon be used in the clear history button? The current one 
indicates that something is denied/prohibited.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham added a comment.


  Agreed!  In the VDG room we discussed a broom, but unfortunately we don't 
have any such icon. If we got one, I'd be happy to use it. Until then, the only 
other option is a trash can (`edit-delete-symbolic`).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Vlad Zagorodniy]

zzag added a comment.


  Then get rid of it. It would cause only confusion :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham added a comment.


  Get rid of what now?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Vlad Zagorodniy]

zzag added a comment.


  In D11306#225222 , @ngraham wrote:
  
  > Get rid of what now?
  
  
  The icon.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  As discussed and agreed to by VDG, change the lock screen background from the 
blue color to the current Plasma wallpaper.

TEST PLAN
  - `rm ~/.config/kscreenlockerrc`
  - Build and install kscreenlocker with this patch
  - Lock the screen
  
  [kscreenlocker image goes here]

REPOSITORY
  R133 KScreenLocker

BRANCH
  plasma-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11308

AFFECTED FILES
  kcfg/kscreenlockersettings.kcfg
  kcm/kcm.cpp

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11309: Use the default Plasma wallpaper on the login screen

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  As discussed and agreed to by VDG, change the SDDM theme background from the 
blue color to the current Plasma wallpaper.

TEST PLAN
  - Build and deploy plasma-workspace with this patch
  - Log out
  
  [SDDM image goes here]

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sddm-image-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11309

AFFECTED FILES
  sddm-theme/theme.conf

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11306: Give the "Clear History" button some text

[Nathaniel Graham]

ngraham added a comment.


  In general, buttons need icons, especially buttons that don't look like 
buttons until you hover over them, like this one. While I agree that a better 
icon would be preferable, since we don't have one, let's maybe keep the 
discussion on the subject of this patch (the text) and investigate adding a 
more appropriate icon elsewhere.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I think we first need to bring back some background for the UI elements. 
Otherwise it's too difficult to read.
  
  Personally I'm very confused as it was the vdg's wish to have it blue. I hope 
our users don't take this negative. I would take it negative to see such a 
forward and backward.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin
Cc: graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11306: Give the "Clear History" button some text

[Christian]

Fuchs added a comment.


  Sorry, but clear -1 from me for the reasons outlined in the Telegram channel.
  
  It looks cluttered, and with the very limited space in plasmoids it becomes 
unpredictable with translations. 
  It removes the very alignment that broulik and I worked hard to achieve. 
  It is inconsistent with the klipper plasmoid, which had that exact 
functionality for years, so I think we can live with it until we fixed the 
actual problem, which is "we need a better, more clear icon".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11306

To: ngraham, #plasma, broulik, Fuchs
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8302: Add FreeBSD port from the development-repo

[Tobias C . Berner]

tcberner updated this revision to Diff 29455.
tcberner added a comment.


  Update text&link.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8302?vs=20765&id=29455

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8302

AFFECTED FILES
  README.md

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D8302: Add FreeBSD port from the development-repo

[Tobias C . Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:36033bac748f: Add FreeBSD port from the development-repo 
(authored by tcberner).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8302?vs=29455&id=29456

REVISION DETAIL
  https://phabricator.kde.org/D8302

AFFECTED FILES
  README.md

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel updated this revision to Diff 29457.
Pitel added a comment.


  - modified `onConfigurationChanged` so it triggers updates of properties 
depending on `cfg_shownItems` and `cfg_hiddenItems`
  - make trash bin not draggable
  - removed `ComboBox` hack (which was not working anyway) and added an overlay 
label to combobox showing `S` for items in `cfg_shownItems` and `H` for items 
in `cfg_hiddenItems` (this is meant as debugging tool only) -- when dragging 
the visibility values in comboboxes go wrong but those letter remain correct 
which leads me to conclusion that the problem is `ComboBox` component 
(@wsdfhjxc can you verify this behavior?)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11292?vs=29421&id=29457

BRANCH
  stableSystray

REVISION DETAIL
  https://phabricator.kde.org/D11292

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/OrderableItem.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #plasma, #vdg
Cc: zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart