D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-25 Thread Martin Flöser
graesslin added a comment.


  In D10816#233128 , @fvogt wrote:
  
  > In D10816#233088 , @graesslin 
wrote:
  >
  > > In D10816#233074 , @fvogt 
wrote:
  > >
  > > > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a 
tty - so should this also check for `WAYLAND_DISPLAY` or 
`startplasmacompositor` set `XDG_SESSION_TYPE=wayland`?
  > >
  > >
  > > [...] from developers we can expect to set this variable.
  >
  >
  > Any reason not to set it in `startplasmacompositor` then?
  
  
  It's not the task of startplasmacompositor to set it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: fvogt, davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11670: [cursors] Add arrow cursor symlinks

2018-03-25 Thread David Rosca
drosca created this revision.
drosca added reviewers: Breeze, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
drosca requested review of this revision.

REVISION SUMMARY
  Add arrow -> left_ptr symlinks.
  Same symlink can be found eg. in Adwaita cursor theme.

TEST PLAN
  Arrow cursor is now correct in Rust winit apps

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11670

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/arrow
  cursors/Breeze_Snow/Breeze_Snow/cursors/arrow

To: drosca, #breeze, hpereiradacosta
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11651: FolderView applet respect panel maxIcon size

2018-03-25 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2683d4c6e60a: FolderView applet respect panel maxIcon 
size (authored by mvourlakos).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11651?vs=30420&id=30470

REVISION DETAIL
  https://phabricator.kde.org/D11651

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: mvourlakos, #plasma, hein, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11220: option to force FolderView icon-only presentation

2018-03-25 Thread Michail Vourlakos
mvourlakos abandoned this revision.
mvourlakos added a comment.


  can be closed because https://phabricator.kde.org/D11651 was accepted...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11220

To: mvourlakos, #plasma, mart, hein
Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart


D11670: [cursors] Add arrow cursor symlinks

2018-03-25 Thread David Rosca
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:3e4620e09ded: [cursors] Add arrow cursor symlinks 
(authored by drosca).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11670?vs=30469&id=30482

REVISION DETAIL
  https://phabricator.kde.org/D11670

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/arrow
  cursors/Breeze_Snow/Breeze_Snow/cursors/arrow

To: drosca, #breeze, hpereiradacosta, andreask
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

2018-03-25 Thread Albert Astals Cid
aacid added a comment.


  Your email said "master branch renamed kcmlaunch.pot to 
kcmlaunchfeedback.pot" you did never mention docs.
  
  Anyhow, are you asking Burkhard to change the patch to rename the folder? I 
guess that's also a fine solution.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: aacid, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

2018-03-25 Thread Burkhard Lück
lueck added a comment.


  In D11661#233341 , @hein wrote:
  
  > I disagree with this patch - I renamed things for consistency for a reason 
and emailed i18n-doc, so I expect the docs to get renamed.
  
  
  Right you emailed i18n-doc, changed the X-DocPath to 
control/kcmlaunchfeedback/index.html, but not the install target in 
doc/kcontrol/kcmlaunch/CMakeLists.txt,
  therefore the englisch documentation is not found.
  
  The name of the docmessages catalog, the name of the translated docs and the 
install target for the translated docs are autogenerated by scripty.
  Rename the translated docs is therefore no real option, the dir 
doc/kcontrol/kcmlaunch/ has to be renamed, another level of consistency ;-)
  
  I will upload a new patch so fix this bug for the english and the language 
docs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: aacid, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11606: [WebBrowser Plasmoid] Support opening external links

2018-03-25 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:65-67
> You can find a better solution. Especially as there's only 3 items (two 
> spaces) in this Layout.

The layout is

  [<] [>] [address bar] [popup blocked] [ reload ]

I want a space between everything except around the popup info

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

2018-03-25 Thread Burkhard Lück
lueck updated this revision to Diff 30498.
lueck retitled this revision from "Fix wrong X-DocPath in 
kcm_launchfeedback.desktop" to "Fix docbook installation for 
doc/kcontrol/kcmlaunchfeedback".
lueck added a comment.
Restricted Application added a subscriber: kde-doc-english.


  rename dir doc/kcontrol/kcmlaunch to doc/kcontrol/kcmlaunchfeedback
  scripty automatically generates the correct name for the docmessages catalog, 
the language docs and the install target
  
  change install target to kcontrol/kcmlaunchfeedback in 
doc/kcontrol/kcmlaunchfeedback/CMakeLists.txt
  now the english docbook is found by khelpcenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11661?vs=30439&id=30498

REVISION DETAIL
  https://phabricator.kde.org/D11661

AFFECTED FILES
  doc/kcontrol/CMakeLists.txt
  doc/kcontrol/kcmlaunch/CMakeLists.txt
  doc/kcontrol/kcmlaunch/index.docbook
  doc/kcontrol/kcmlaunchfeedback/CMakeLists.txt
  doc/kcontrol/kcmlaunchfeedback/index.docbook

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: kde-doc-english, aacid, hein, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11551: use the new install_package form

2018-03-25 Thread Martin Kostolný
martinkostolny added a comment.


  Sorry to be late on this. I cannot compile plasma-pa anymore after this 
change with error:
  
Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc
make[2]: *** No rule to make target 
'applet/org.kde.plasma.volume-contents.rcc', needed by 
'applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:191: 
applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
  
  Same goes for plasma-nm after similar change. I'm using kdesrc-build 
environment. Is there something I may be doing wrong?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11551

To: mart, #plasma
Cc: martinkostolny, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11686: Update desktop theme docbook to 5,12

2018-03-25 Thread Burkhard Lück
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releaseinfo
  add info about edit button with plasma-sdk package installed

TEST PLAN
  checkXML5 doc/kcontrol/desktopthemedetails/index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11686

AFFECTED FILES
  doc/kcontrol/desktopthemedetails/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11551: use the new install_package form

2018-03-25 Thread Martin Kostolný
martinkostolny added a comment.


  > Is there something I may be doing wrong?
  
  I can see now that this change was applied and then reverted all over the 
plasma repositories so these are probably 2 leftovers. Sorry for the fuzz.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11551

To: mart, #plasma
Cc: martinkostolny, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11687: Update autostart docbook to 5,12

2018-03-25 Thread Burkhard Lück
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releseinfo
  fix wording Pre-KDE startup -> Before session startup + KDE -> Plasma

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11687

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11688: Update mouse docbook to 5,12

2018-03-25 Thread Burkhard Lück
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releseinfo
  fix changed gui string Mouse Navigation -> Keyboard Navigation

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11688

AFFECTED FILES
  doc/kcontrol/mouse/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11690: Update mouse docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releseinfo
  add a para about adding components from https://phabricator.kde.org/D2111

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11690

AFFECTED FILES
  doc/kcontrol/keys/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D1230: GBM remote access support for KWin

2018-03-25 Thread Roman Gilg
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Looks fine to me. Tested runtime together with your KWayland patch.
  
  Probably you know this, but please push as one commit only to master.

INLINE COMMENTS

> egl_gbm_backend.cpp:160
> +{
> +if (qEnvironmentVariableIsSet("KWIN_NO_REMOTE"))
> +return;

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R108 KWin

BRANCH
  fix-clang

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, 
davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein


D1231: Add Remote Access interface to KWayland

2018-03-25 Thread Roman Gilg
romangg accepted this revision.
romangg added a comment.


  Looks fine to me. Tested compilation as well as runtime with KWin's DRM+EGL 
backend.
  
  - Please change in comments the frameworks version number these changes are 
landing in.
  - I would like to have @davidedmundson look over this patch a last time. If 
he doesn't have time until mid-week to do this, you can push.
  - Probably you know this, but please push as one commit only.

INLINE COMMENTS

> remote_access.cpp:139
> +RemoteBuffer *q;
> +
> +qint32 fd = 0;

rm whitespace

> remote_access_interface.cpp:118
> +};
> +
> +class RemoteAccessManagerInterface::Private : public Global::Private

rm whitespace

> remote_access_interface.h:38
> + * (stored in manager's sent list)
> + *  2. Clients confirm that they wants this buffer, the RemoteBuffer 
> + * interfaces are then created and wrapped around BufferHandle.

rm whitespace (at the end)

> remote_access_interface.h:42
> + * RemoteBuffer notifies manager and release signal is emitted.
> + * 
> + * It's the responsibility of your process to delete this BufferHandle

rm whitespace

> remote_access_interface.h:55
> +void setFormat(quint32 format);
> +  
> +qint32 fd() const;

rm whitespace

> remote_access_interface_p.h:29
> +{
> +
> +/**

rm whitespace

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, ragreen, schernikov, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


D1230: GBM remote access support for KWin

2018-03-25 Thread Oleg Chernovskiy
Kanedias closed this revision.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, 
davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein


D1231: Add Remote Access interface to KWayland

2018-03-25 Thread Oleg Chernovskiy
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:5116fe0c6345: Add Remote Access interface to KWayland 
(authored by Kanedias).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1231?vs=30273&id=30534#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=30273&id=30534

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, ragreen, schernikov, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


D1231: Add Remote Access interface to KWayland

2018-03-25 Thread Oleg Chernovskiy
Kanedias added a comment.


  - squashed before pushing
  - fixed all versions to 5.45
  
  Thanks gentlemen, it's was 1 day more for the second birthday of this patch :)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, ragreen, schernikov, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


D1230: GBM remote access support for KWin

2018-03-25 Thread Oleg Chernovskiy
Kanedias added a comment.


  Done! Thanks for looking this through.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, 
davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein


D11693: Update kcmnotify docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releaseinfo
  add how to disable all sound notifications
  replace kde with plasma
  remove commented option Speech

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11693

AFFECTED FILES
  doc/kcontrol/kcmnotify/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 120 - Failure!

2018-03-25 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/120/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Mar 2018 17:19:06 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 932.01 KB...][ 69%] Built target kwin_wayland_autogenScanning dependencies of target KWinSceneQPainter_autogen[ 69%] Automatic MOC for target KWinSceneQPainter[ 69%] Built target KWinQpaPlugin_autogenScanning dependencies of target KWinSceneXRender_autogen[ 69%] Built target KWinSceneQPainter_autogen[ 69%] Built target KWinSceneOpenGL_autogen[ 69%] Automatic MOC for target KWinSceneXRenderScanning dependencies of target testX11TimestampUpdate_autogenScanning dependencies of target KWinIntegrationTestFramework_autogen[ 69%] Automatic MOC for target testX11TimestampUpdate[ 69%] Automatic MOC for target KWinIntegrationTestFramework[ 69%] Built target KWinWaylandVirtualBackend_autogenScanning dependencies of target kwin_wayland[ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o[ 69%] Built target testX11TimestampUpdate_autogen[ 69%] Built target KWinSceneXRender_autogen[ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/main_wayland.cpp.o[ 69%] Built target KWinWaylandWaylandBackend_autogenScanning dependencies of target kdeinit_kwin_x11[ 69%] Built target KWinIntegrationTestFramework_autogenScanning dependencies of target KF5GlobalAccelPrivateKWin[ 69%] Building CXX object CMakeFiles/kdeinit_kwin_x11.dir/main_x11.cpp.o[ 69%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/kglobalaccel_plugin.cpp.o[ 69%] Built target KWinWaylandDrmBackend_autogen[ 70%] Building CXX object CMakeFiles/kdeinit_kwin_x11.dir/kdeinit_kwin_x11_autogen/mocs_compilation.cpp.oScanning dependencies of target KWinQpaPlugin[ 70%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/abstractplatformcontext.cpp.o[ 70%] Building CXX object CMakeFiles/kwin_wayland.dir/kwin_wayland_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/KF5GlobalAccelPrivateKWin_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/backingstore.cpp.o/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/main_wayland.cpp:95:33: warning: unused parameter 'flags' [-Wunused-parameter]void gainRealTime(RealTimeFlags flags = RealTimeFlags::DontReset)^[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/integration.cpp.o[ 71%] Linking CXX shared module ../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/main.cpp.o[ 71%] Linking CXX shared library bin/libkdeinit5_kwin_x11.so[ 71%] Built target KF5GlobalAccelPrivateKWin1 warning generated.[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/nativeinterface.cpp.oScanning dependencies of target KF5IdleTimeKWinWaylandPrivatePlugin[ 71%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/poller.cpp.o[ 71%] Linking CXX executable bin/kwin_wayland[ 71%] Built target kdeinit_kwin_x11Scanning dependencies of target KWinWaylandDrmBackend[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object.cpp.o[ 71%] Built target kwin_wayland[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_connector.cpp.o[ 71%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/KF5IdleTimeKWinWaylandPrivatePlugin_autogen/mocs_compilation.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcontextwayland.cpp.oScanning dependencies of target KWinWaylandVirtualBackend[ 71%] Building CXX object plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/egl_gbm_backend.cpp.o[ 71%] Building CXX object plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_backend.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/plugins/platforms/drm/drm_backend.cpp:36:In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/plugins/platforms/drm/egl_gbm_backend.h:23:/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/plugins/platforms/drm/remoteaccess_manager.h:25:10: fatal error: 'KWayland/Server/remote_access_interface.h' file not found#include  ^~~[ 71%] Building CXX object plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_output.cpp.o[ 71%] Linking CXX shared module ../../bin/KF5IdleTimeKWinWaylandPrivatePlugin.so1 error generated.gmake[2]: *** [plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 444 - Failure!

2018-03-25 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/444/
 Project:
Plasma kwin kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 25 Mar 2018 17:19:06 +
 Build duration:
18 min and counting
   CONSOLE OUTPUT
  [...truncated 946.75 KB...][ 65%] Automatic MOC for target kwin_wayland[ 65%] Automatic MOC for target KWinQpaPlugin[ 65%] Automatic MOC for target KWinWaylandDrmBackend[ 65%] Automatic MOC for target kdeinit_kwin_x11[ 65%] Built target kdeinit_kwin_x11_autogenScanning dependencies of target KWinWaylandFbdevBackend_autogen[ 65%] Built target KF5GlobalAccelPrivateKWin_autogen[ 65%] Automatic MOC for target KWinWaylandFbdevBackendScanning dependencies of target KWinWaylandVirtualBackend_autogen[ 65%] Built target KF5IdleTimeKWinWaylandPrivatePlugin_autogen[ 65%] Automatic MOC for target KWinWaylandVirtualBackendScanning dependencies of target KWinWaylandWaylandBackend_autogen[ 65%] Built target kwin_wayland_autogen[ 65%] Automatic MOC for target KWinWaylandWaylandBackendScanning dependencies of target eglx11common_autogen[ 65%] Automatic MOC for target eglx11common[ 65%] Built target eglx11common_autogen[ 65%] Built target KWinQpaPlugin_autogen[ 65%] Built target KWinWaylandFbdevBackend_autogenScanning dependencies of target KWinSceneOpenGL_autogenScanning dependencies of target KWinSceneXRender_autogenScanning dependencies of target KWinSceneQPainter_autogen[ 65%] Automatic MOC for target KWinSceneOpenGL[ 65%] Automatic MOC for target KWinSceneXRender[ 65%] Automatic MOC for target KWinSceneQPainter[ 65%] Built target KWinWaylandVirtualBackend_autogen[ 65%] Built target KWinSceneXRender_autogen[ 65%] Built target KWinWaylandDrmBackend_autogenScanning dependencies of target testX11TimestampUpdate_autogen[ 65%] Built target KWinSceneQPainter_autogenScanning dependencies of target KWinIntegrationTestFramework_autogen[ 65%] Built target KWinSceneOpenGL_autogen[ 65%] Built target KWinWaylandWaylandBackend_autogen[ 65%] Automatic MOC for target testX11TimestampUpdate[ 65%] Automatic MOC for target KWinIntegrationTestFrameworkScanning dependencies of target kdeinit_kwin_x11Scanning dependencies of target KF5GlobalAccelPrivateKWinScanning dependencies of target kwin_wayland[ 65%] Building CXX object CMakeFiles/kdeinit_kwin_x11.dir/main_x11.cpp.o[ 65%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/kglobalaccel_plugin.cpp.o[ 65%] Building CXX object CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o[ 65%] Built target testX11TimestampUpdate_autogen[ 65%] Building CXX object CMakeFiles/kwin_wayland.dir/main_wayland.cpp.o[ 65%] Built target KWinIntegrationTestFramework_autogenScanning dependencies of target KF5IdleTimeKWinWaylandPrivatePlugin[ 65%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/poller.cpp.oScanning dependencies of target KWinQpaPlugin[ 65%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/abstractplatformcontext.cpp.o[ 65%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/KF5IdleTimeKWinWaylandPrivatePlugin_autogen/mocs_compilation.cpp.o[ 66%] Building CXX object CMakeFiles/kwin_wayland.dir/kwin_wayland_autogen/mocs_compilation.cpp.o/home/jenkins/workspace/Plasma kwin kf5-qt5 SUSEQt5.9/main_wayland.cpp: In function 'void KWin::{anonymous}::gainRealTime(KWin::RealTimeFlags)':/home/jenkins/workspace/Plasma kwin kf5-qt5 SUSEQt5.9/main_wayland.cpp:95:56: warning: unused parameter 'flags' [-Wunused-parameter] void gainRealTime(RealTimeFlags flags = RealTimeFlags::DontReset)^[ 66%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/backingstore.cpp.o[ 66%] Building CXX object CMakeFiles/kdeinit_kwin_x11.dir/kdeinit_kwin_x11_autogen/mocs_compilation.cpp.o[ 66%] Linking CXX shared module ../../bin/KF5IdleTimeKWinWaylandPrivatePlugin.so[ 67%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/integration.cpp.o[ 67%] Built target KF5IdleTimeKWinWaylandPrivatePluginScanning dependencies of target KWinWaylandDrmBackend[ 67%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o[ 67%] Linking CXX executable bin/kwin_waylandIn file included from /home/jenkins/workspace/Plasma kwin kf5-qt5 SUSEQt5.9/plugins/platforms/drm/egl_gbm_backend.h:23:0, from /home/jenkins/workspace/Plasma kwin kf5-qt5 SUSEQt5.9/plugins/platforms/drm/drm_backend.cpp:36:/home/jenkins/workspace/Plasma kwin kf5-qt5 SUSEQt5.9/plugins/platforms/drm/remoteaccess_manager.h:25:10: fatal error: KWayland/Server/remote_access_interface.h: No such file or directory #include   ^~~compilation terminated.make[2]: *** [plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/build.make:63: plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o] Error

D11695: Update clock docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releaseinfo
  add systemd
  remove commented and outdated info

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11695

AFFECTED FILES
  doc/kcontrol/clock/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11695: Update clock docbook to 5.12

2018-03-25 Thread Yuri Chornoivan
yurchor accepted this revision as: yurchor.
yurchor added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> index.docbook:55
> +When you log in to the &plasma; session while being online or when you 
> later
> +connect to the Internet the access to on or more NTP 
> servers happens.
> +This is not sufficient, however, for maintaining an accurate clock in 
> the long run.

Typo: on or more -> one or more

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11695

To: lueck, #plasma, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11695: Update clock docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck updated this revision to Diff 30548.
lueck added a comment.


  fix typo spotted by Yuri, thanks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11695?vs=30547&id=30548

REVISION DETAIL
  https://phabricator.kde.org/D11695

AFFECTED FILES
  doc/kcontrol/clock/index.docbook

To: lueck, #plasma, #documentation, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11352: [RFC] Auto ordered systray

2018-03-25 Thread Radek Hušek
Pitel added a comment.


  > i would prefer the final version to be quiet
  
  Sure.

INLINE COMMENTS

> mart wrote in AbstractItem.qml:80
> This is probably not necessary: both plasmoids and statusnotifieritems have 
> ids that you can access (numeric for plasmoids, alphanumeric for 
> statusnotifiers, which would then make them ordered after plasmoids but 
> that's fine)

Probably not, I have not observed any problems even without this rule, I just 
wanted to be safe. I see that I can use `applet.id` or even `applet.pluginName` 
as there should be at most one instace of given plasmoid in systray but I am 
not so sure about statusnotifiers, spec says that `Id` should be unique for 
given app, but what if user launches two instances of the app? Or am I 
overthinking this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11410: [RFC] Add option to make applet fixed width

2018-03-25 Thread Radek Hušek
Pitel updated this revision to Diff 30555.
Pitel added a comment.


  - Replace checkbox with a checkable button
  - Add support for panel spacer -- currently we just check whether the applet 
is panel spacer and if it is we use `applet.configuration.expanding` instead of 
our `fixedSizeOverride`. I think we should remove context action to set 
`expanding` from panel spacer after this is landed and then convert it to use 
`fixedSizeOverride` array.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11410?vs=29940&id=30555

BRANCH
  fixedSizeOverride

REVISION DETAIL
  https://phabricator.kde.org/D11410

AFFECTED FILES
  containments/panel/contents/config/main.xml
  containments/panel/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/main.qml

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol


D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-25 Thread Nathaniel Graham
ngraham added a comment.


  @romangg so is this more of a request just for code review review, then?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: hein, mart, abetts, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol


KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 121 - Still Failing!

2018-03-25 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/121/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 03:11:24 +
 Build duration:
31 min and counting
   CONSOLE OUTPUT
  [...truncated 934.66 KB...][ 69%] Built target KWinSceneQPainter_autogenScanning dependencies of target testX11TimestampUpdate_autogen[ 69%] Automatic MOC for target testX11TimestampUpdate[ 69%] Built target KWinSceneXRender_autogenScanning dependencies of target KWinIntegrationTestFramework_autogen[ 69%] Automatic MOC for target KWinIntegrationTestFramework[ 69%] Built target testX11TimestampUpdate_autogenScanning dependencies of target kwin_wayland[ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/tabletmodemanager.cpp.o[ 69%] Built target KWinIntegrationTestFramework_autogen[ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/main_wayland.cpp.oScanning dependencies of target kdeinit_kwin_x11[ 69%] Building CXX object CMakeFiles/kdeinit_kwin_x11.dir/main_x11.cpp.o/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/main_wayland.cpp:95:33: warning: unused parameter 'flags' [-Wunused-parameter]void gainRealTime(RealTimeFlags flags = RealTimeFlags::DontReset)^1 warning generated.[ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/kwin_wayland_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object CMakeFiles/kdeinit_kwin_x11.dir/kdeinit_kwin_x11_autogen/mocs_compilation.cpp.o[ 70%] Linking CXX executable bin/kwin_wayland[ 70%] Linking CXX shared library bin/libkdeinit5_kwin_x11.so[ 70%] Built target kdeinit_kwin_x11Scanning dependencies of target KF5GlobalAccelPrivateKWin[ 70%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/kglobalaccel_plugin.cpp.o[ 70%] Built target kwin_wayland[ 70%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/KF5GlobalAccelPrivateKWin_autogen/mocs_compilation.cpp.o[ 70%] Linking CXX shared module ../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.soScanning dependencies of target KWinQpaPlugin[ 70%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/abstractplatformcontext.cpp.o[ 70%] Built target KF5GlobalAccelPrivateKWin[ 70%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/backingstore.cpp.oScanning dependencies of target KF5IdleTimeKWinWaylandPrivatePlugin[ 70%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/poller.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/integration.cpp.o[ 71%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/KF5IdleTimeKWinWaylandPrivatePlugin_autogen/mocs_compilation.cpp.o[ 71%] Linking CXX shared module ../../bin/KF5IdleTimeKWinWaylandPrivatePlugin.so[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/main.cpp.o[ 71%] Built target KF5IdleTimeKWinWaylandPrivatePlugin[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/nativeinterface.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcontextwayland.cpp.oScanning dependencies of target KWinWaylandDrmBackend[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcursor.cpp.o[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/screen.cpp.o[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_connector.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/sharingplatformcontext.cpp.o[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_crtc.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/window.cpp.o[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_plane.cpp.o[ 71%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_output.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/logging.cpp.o[ 71%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/KWinQpaPlugin_autogen/mocs_compilation.cpp.o[ 72%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_buffer.cpp.o[ 72%] Linking CXX shared module ../../bin/KWinQpaPlugin.so[ 72%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_inputeventfilter.cpp.o[ 72%] Built target KWinQpaPlugin[ 72%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/logging.cpp.o[ 72%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/scene_qpainter_drm_backend.cpp.oScanning dependencies of target KWinWayl

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 445 - Still unstable!

2018-03-25 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/445/
 Project:
Plasma kwin kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Mar 2018 03:11:25 +
 Build duration:
58 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 122 test(s), Skipped: 0 test(s), Total: 124 test(s)Failed: TestSuite.kwin-testDontCrashCursorPhysicalSizeEmptyFailed: TestSuite.kwin-testDontCrashCursorPhysicalSizeEmpty-waylandonly
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report72%
(59/82)57%
(327/577)57%
(327/577)41%
(28194/69344)30%
(13820/46275)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals86%
(132/154)86%
(132/154)63%
(18024/28671)47%
(9816/21094)colorcorrection100%
(6/6)100%
(6/6)81%
(436/535)59%
(203/342)data0%
(0/1)0%
(0/1)0%
(0/29)0%
(0/12)decorations100%
(11/11)100%
(11/11)77%
(392/510)62%
(142/230)effects100%
(3/3)100%
(3/3)98%
(164/168)82%
(23/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(15/352)5%
(14/258)effects.blur20%
(1/5)20%
(1/5)2%
(15/682)3%
(14/407)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch25%
(1/4)25%
(1/4)0%
(2/655)1%
(4/530)effects.cube22%
(2/9)22%
(2/9)1%
(25/1876)0%
(5/1551)effects.desktopgrid50%
(2/4)50%
(2/4)7%
(73/998)3%
(27/970)effects.diminactive50%
(2/4)50%
(2/4)18%
(20/109)0%
(0/94)effects.dimscreen100%
(1/1)100%
(1/1)18%
(10/57)0%
(0/66)effects.fallapart100%
(2/2)100%
(2/2)31%
(29/94)14%
(8/56)effects.flipswitch25%
(1/4)25%
(1/4)7%
(45/656)1%
(5/560)effects.glide67%
(2/3)67%
(2/3)42%
(71/170)30%
(36/122)effects.highlightwindow100%
(2/2)100%
(2/2)38%
(55/143)15%
(21/136)effects.invert50%
(1/2)50%
  

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

2018-03-25 Thread Vlad Zagorodniy
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Why does this patch have non-related changes? E.g. 
`GLRenderTarget::attachTexture`, `GLRenderTarget::detachTexture`, empty 
GLRenderTarget constructor, `GLRenderTarget::setTextureDirty`, etc? They aren't 
used anywhere.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ragreen, iodelay, 
bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol


D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

2018-03-25 Thread Eike Hein
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Thanks! :)

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: kde-doc-english, aacid, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D1230: GBM remote access support for KWin

2018-03-25 Thread Ben Cooksley
bcooksley added a comment.


  The introduction of this has broken the FreeBSD Build.
  Please see 
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/120/consoleText

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, 
#kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein