D11065: [Active Window Control] Slightly fix vertical alignment of window name
This revision was automatically updated to reflect the committed changes. Closed by commit R884:1119c47f1756: [Active Window Control] Slightly fix vertical alignment of window name (authored by Pitel). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11065?vs=28886&id=30832 REVISION DETAIL https://phabricator.kde.org/D11065 AFFECTED FILES package/contents/ui/AppMenu.qml To: Pitel, #plasma, martinkostolny Cc: abetts, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D11072: [Active Window Control] Show window title when app name is missing
This revision was automatically updated to reflect the committed changes. Closed by commit R884:f48d5afac734: Show window title when app name is missing (authored by Pitel). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11072?vs=28763&id=30833 REVISION DETAIL https://phabricator.kde.org/D11072 AFFECTED FILES package/contents/ui/main.qml To: Pitel, #plasma, martinkostolny Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7481: Batch window changes events on XCB
broulik added inline comments.
INLINE COMMENTS
> xwindowsystemeventbatcher.cpp:69
> +{
> +Q_UNUSED(event);
> +for (auto it = m_cache.constBegin(); it!= m_cache.constEnd(); it++) {
Please check `event->timerId()` against `m_timerId`, plasmashell keeps hogging
100% CPU when I have certain windows focused (e.g. ksysguard) as this method is
entered a ton of times with timer ids other than our own.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7481
To: davidedmundson, #plasma, hein, broulik
Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11663: Add InlineMessage type and Gallery app example page
hein updated this revision to Diff 30835. hein added a comment. - Make icon a grouped property. - Support icon color tinting. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30781&id=30835 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED FILES examples/galleryapp/CMakeLists.txt examples/galleryapp/resources.qrc examples/gallerydata/contents/ui/MainPage.qml examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml kirigami.qrc src/controls/InlineMessage.qml src/controls/plugins.qmltypes src/controls/templates/InlineMessage.qml src/enums.h src/kirigamiplugin.cpp src/qmldir To: hein, #kirigami, mart Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein
D11663: Add InlineMessage type and Gallery app example page
This revision was automatically updated to reflect the committed changes. Closed by commit R169:e6231547df6d: Add InlineMessage type and Gallery app example page (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30835&id=30836 REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED FILES examples/galleryapp/CMakeLists.txt examples/galleryapp/resources.qrc examples/gallerydata/contents/ui/MainPage.qml examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml kirigami.qrc src/controls/InlineMessage.qml src/controls/plugins.qmltypes src/controls/templates/InlineMessage.qml src/enums.h src/kirigamiplugin.cpp src/qmldir To: hein, #kirigami, mart Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein
D7481: Batch window changes events on XCB
broulik added inline comments. INLINE COMMENTS > broulik wrote in xwindowsystemeventbatcher.cpp:69 > Please check `event->timerId()` against `m_timerId`, plasmashell keeps > hogging 100% CPU when I have certain windows focused (e.g. ksysguard) as this > method is entered a ton of times with timer ids other than our own. Even with that plasmashell constantly consumes a ton of CPU and becomes sluggish depending on what window is currently focused and what you're doing :/ Perhaps `QBasicTimer` is a better choice? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma, hein, broulik Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11774: Notification dataengine debug category
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fdeb02ce37a1: Notification dataengine debug category (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11774?vs=30821&id=30838 REVISION DETAIL https://phabricator.kde.org/D11774 AFFECTED FILES dataengines/notifications/CMakeLists.txt dataengines/notifications/notificationaction.cpp dataengines/notifications/notificationsanitizer.cpp dataengines/notifications/notificationsengine.cpp To: davidedmundson, broulik Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11775: Remove dead dataengine code
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3a0a7aa780e: Remove dead dataengine code (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11775?vs=30823&id=30837 REVISION DETAIL https://phabricator.kde.org/D11775 AFFECTED FILES dataengines/CMakeLists.txt dataengines/akonadi/CMakeLists.txt dataengines/akonadi/akonadiengine.cpp dataengines/akonadi/akonadiengine.h dataengines/akonadi/plasma-engine-akonadi.desktop dataengines/calendar/CMakeLists.txt dataengines/calendar/Messages.sh dataengines/calendar/calendar.operations dataengines/calendar/calendarengine.cpp dataengines/calendar/calendarengine.h dataengines/calendar/eventdatacontainer.cpp dataengines/calendar/eventdatacontainer.h dataengines/calendar/plasma-dataengine-calendar.desktop dataengines/network/CMakeLists.txt dataengines/network/Messages.sh dataengines/network/networkengine.cpp dataengines/network/networkengine.h dataengines/network/plasma-dataengine-network.desktop dataengines/rss/CMakeLists.txt dataengines/rss/Messages.sh dataengines/rss/plasma-dataengine-rss.desktop dataengines/rss/rss.cpp dataengines/rss/rss.h To: davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 506 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/506/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 10:55:30 + Build duration: 7 min 1 sec and counting CONSOLE OUTPUT [...truncated 1.28 MB...][ 85%] Generating ion-bbcukmet.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"Found property definition "X-KDE-ParentApp" with type "QString"Generated "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/build/dataengines/weather/ions/bbcukmet/ion-bbcukmet.json" [ 85%] Automatic MOC for target ion_bbcukmet[ 85%] Built target ion_bbcukmet_autogenScanning dependencies of target ion_envcan_autogen[ 86%] Generating ion-envcan.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"Found property definition "X-KDE-ParentApp" with type "QString"Generated "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/build/dataengines/weather/ions/envcan/ion-envcan.json" [ 86%] Automatic MOC for target ion_envcanScanning dependencies of target ion_noaa_autogenScanning dependencies of target ion_wettercom_autogen[ 86%] Generating ion-noaa.json[ 86%] Generating ion-wettercom.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"Found property definition "X-KDE-ParentApp" with type "QString"Generated "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/build/dataengines/weather/ions/noaa/ion-noaa.json" About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"Found property definition "X-KDE-ParentApp" with type "QString"Generated "/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/build/dataengines/weather/ions/wetter.com/ion-wettercom.json" [ 86%] Automatic MOC for target ion_noaa[ 86%] Automatic MOC for target ion_wettercom[ 86%] Built target ion_envcan_autogen[ 87%] Generating statusnotifieritem_interface.cpp, statusnotifieritem_interface.h[ 87%] Generating statusnotifierwatcher_interface.cpp, statusnotifierwatcher_interface.h[ 87%] Generating dbusproperties.cpp, dbusproperties.h[ 87%] Built target ion_noaa_autogen[ 87%] Built target ion_wettercom_autogen[ 87%] Generating statusnotifierwatcher_interface.moc[ 87%] Generating statusnotifieritem_interface.moc[ 87%] Generating kuiserversettings.h, kuiserversettings.cpp[ 87%] Generating dbusproperties.mocScanning dependencies of target testPlatformDetection[ 87%] Building CXX object libkworkspace/autotests/CMakeFiles/testPlatformDetection.dir/testPlatformDetection.cpp.o[ 87%] Linking CXX shared library ../../../bin/libappmenuplugin.soScanning dependencies of target plasma_engine_statusnotifieritemmake[1]: *** [CMakeFiles/Makefile2:10784: dataengines/powermanagement/CMakeFiles/plasma_engine_powermanagement.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 87%] Linking CXX shared module ../../bin/krunner_sessions.so[ 87%] Building CXX object libkworkspace/autotests/CMakeFiles/testPlatformDetection.dir/testPlatformDetection_autogen/mocs_compilation.cpp.o[ 87%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o[ 87%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemsource.cpp.o[ 87%] Built target krunner_sessions[ 87%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemservice.cpp.o[ 87%] Built target appmenuplugin[ 87%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritemjob.cpp.o[ 87%] Linking CXX executable ../../bin/testPlatformDetection[ 87%] Built target testPlatformDetection[ 87%] Generating ui_configdialog.h[ 87%] Generating jobviewadaptor.cpp, jobviewadaptor.h[ 87%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/systemtraytypes.cpp.o[ 87%] Generating jobview_interface.cpp, jobview_interface.h[ 87%] Generating jobviewserveradaptor.cpp, jobviewserveradaptor.h[ 87%] Generating jobviewserver_interface.cpp, jobviewserver_interface.h[ 87%] Generating kuiserveradaptor.cpp, kuiserveradaptor.h[ 87%] Generating jobviewadaptor.moc[ 87%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifierwatcher_interface.cpp.o[ 88%] Generating jobview_interface.moc[ 88%] Generating jobviewserveradaptor.moc[ 88%] Generating jobviewserver_interface.moc[ 88%] Generating kuiserveradaptor.moc[ 88%] Building CXX object dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/dbusproperties.cpp.oScanning dependencies of target kdeinit_kuiserver5[ 88%] Building CXX object
D7481: Batch window changes events on XCB
davidedmundson updated this revision to Diff 30839. davidedmundson added a comment. proper timer usage REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7481?vs=30822&id=30839 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7481 AFFECTED FILES libtaskmanager/CMakeLists.txt libtaskmanager/TODO.txt libtaskmanager/xwindowsystemeventbatcher.cpp libtaskmanager/xwindowsystemeventbatcher.h libtaskmanager/xwindowtasksmodel.cpp To: davidedmundson, #plasma, hein, broulik Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11726: Vastly simplify image wallpaper code
davidedmundson updated this revision to Diff 30842. davidedmundson added a comment. Code comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11726?vs=30649&id=30842 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11726 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/main.qml To: davidedmundson, #plasma, broulik Cc: broulik, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D7481: Batch window changes events on XCB
davidedmundson updated this revision to Diff 30843. davidedmundson added a comment. fixup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7481?vs=30839&id=30843 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7481 AFFECTED FILES libtaskmanager/CMakeLists.txt libtaskmanager/TODO.txt libtaskmanager/xwindowsystemeventbatcher.cpp libtaskmanager/xwindowsystemeventbatcher.h libtaskmanager/xwindowtasksmodel.cpp To: davidedmundson, #plasma, hein, broulik Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11726: Vastly simplify image wallpaper code
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f713a77e670a: Vastly simplify image wallpaper code (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11726?vs=30842&id=30844 REVISION DETAIL https://phabricator.kde.org/D11726 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/main.qml To: davidedmundson, #plasma, broulik Cc: broulik, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 507 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/507/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Thu, 29 Mar 2018 12:41:46 +
Build duration:
12 min and counting
CONSOLE OUTPUT
[...truncated 1.28 MB...] KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingSleep(int cookie);^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:86:116: warning: 'bool Solid::PowerManagement::stopSuppressingSleep(int)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::stopSuppressingSleep(parameters().value(QStringLiteral("cookie")).toInt()));^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:103:40: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingSleep(int cookie);^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:89:43: warning: 'int Solid::PowerManagement::beginSuppressingScreenPowerManagement(const QString&)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::beginSuppressingScreenPowerManagement(parameters().value(QStringLiteral("reason")).toString())); ^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:117:39: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT int beginSuppressingScreenPowerManagement(const QString &reason = QString()); ^/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:89:136: warning: 'int Solid::PowerManagement::beginSuppressingScreenPowerManagement(const QString&)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::beginSuppressingScreenPowerManagement(parameters().value(QStringLiteral("reason")).toString()));^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:117:39: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT int beginSuppressingScreenPowerManagement(const QString &reason = QString()); ^/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:92:43: warning: 'bool Solid::PowerManagement::stopSuppressingScreenPowerManagement(int)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::stopSuppressingScreenPowerManagement(parameters().value(QStringLiteral("cookie")).toInt())); ^~~~In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:129:40: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingScreenPowerManagement(int cookie);^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:92:132: warning: 'bool Solid::PowerManagement::stopSuppressingScreenPowerManagement(int)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::stopSuppressingScreenPowerManagement(parameters().value(QStringLiteral("cookie")).toInt()));
D7481: Batch window changes events on XCB
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ec1931f7b298: Batch window changes events on XCB (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7481?vs=30843&id=30849 REVISION DETAIL https://phabricator.kde.org/D7481 AFFECTED FILES libtaskmanager/CMakeLists.txt libtaskmanager/TODO.txt libtaskmanager/xwindowsystemeventbatcher.cpp libtaskmanager/xwindowsystemeventbatcher.h libtaskmanager/xwindowtasksmodel.cpp To: davidedmundson, #plasma, hein, broulik Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 508 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/508/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Thu, 29 Mar 2018 14:38:56 +
Build duration:
9 min 23 sec and counting
CONSOLE OUTPUT
[...truncated 1.31 MB...] KDELIBS4SUPPORT_DEPRECATED_EXPORT int beginSuppressingSleep(const QString &reason = QString()); ^/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:86:43: warning: 'bool Solid::PowerManagement::stopSuppressingSleep(int)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::stopSuppressingSleep(parameters().value(QStringLiteral("cookie")).toInt())); ^~~~In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:103:40: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingSleep(int cookie);^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:86:116: warning: 'bool Solid::PowerManagement::stopSuppressingSleep(int)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::stopSuppressingSleep(parameters().value(QStringLiteral("cookie")).toInt()));^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:103:40: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT bool stopSuppressingSleep(int cookie);^~~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:89:43: warning: 'int Solid::PowerManagement::beginSuppressingScreenPowerManagement(const QString&)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::beginSuppressingScreenPowerManagement(parameters().value(QStringLiteral("reason")).toString())); ^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:117:39: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT int beginSuppressingScreenPowerManagement(const QString &reason = QString()); ^/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:89:136: warning: 'int Solid::PowerManagement::beginSuppressingScreenPowerManagement(const QString&)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::beginSuppressingScreenPowerManagement(parameters().value(QStringLiteral("reason")).toString()));^In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1:0, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:33:/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:117:39: note: declared here KDELIBS4SUPPORT_DEPRECATED_EXPORT int beginSuppressingScreenPowerManagement(const QString &reason = QString()); ^/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/powermanagement/powermanagementjob.cpp:92:43: warning: 'bool Solid::PowerManagement::stopSuppressingScreenPowerManagement(int)' is deprecated [-Wdeprecated-declarations] setResult(Solid::PowerManagement::stopSuppressingScreenPowerManagement(parameters().value(QStringLiteral("cookie")).toInt())); ^~~~In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/
D11189: Force a content size into the background style item
This revision was automatically updated to reflect the committed changes. Closed by commit R169:4b438abc8b15: Force a content size into the background style item (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11189?vs=29505&id=30853 REVISION DETAIL https://phabricator.kde.org/D11189 AFFECTED FILES src/controls/private/PrivateActionToolButton.qml To: apol, mart Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein
D11468: [Mouse KCM] Add KWin Wayland backend
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Haven't reviewed it very well, it's quite a complex diff to follow, but it seems fine. REPOSITORY R119 Plasma Desktop BRANCH mouseKCM REVISION DETAIL https://phabricator.kde.org/D11468 To: romangg, #plasma, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10836: Ensure _NET_CURRENT_DESKTOP is set on startup
This revision was automatically updated to reflect the committed changes. Closed by commit R108:420549603372: Ensure _NET_CURRENT_DESKTOP is set on startup (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10836?vs=28039&id=30856 REVISION DETAIL https://phabricator.kde.org/D10836 AFFECTED FILES autotests/integration/virtual_desktop_test.cpp workspace.cpp To: graesslin, #kwin, #plasma, romangg Cc: broulik, plasma-devel, kwin, ragreen, iodelay, zzag, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D11352: [RFC] Auto ordered systray
Pitel added inline comments. INLINE COMMENTS > Pitel wrote in AbstractItem.qml:80 > Probably not, I have not observed any problems even without this rule, I just > wanted to be safe. I see that I can use `applet.id` or even > `applet.pluginName` as there should be at most one instace of given plasmoid > in systray but I am not so sure about statusnotifiers, spec says that `Id` > should be unique for given app, but what if user launches two instances of > the app? Or am I overthinking this? I tested multiple instances of vlc and all their properties exported by `statusnotifier` engine have the same values so `creationId` is required after all. REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel, #vdg, #plasma, mart Cc: ngraham, wsdfhjxc, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D11352: [RFC] Auto ordered systray
Pitel updated this revision to Diff 30859. Pitel added a comment. - Remove debug print REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352?vs=30111&id=30859 BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 AFFECTED FILES applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/main.qml To: Pitel, #vdg, #plasma, mart Cc: ngraham, wsdfhjxc, mart, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D11695: Update clock docbook to 5.12
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b9d2f63fe1c2: Update clock docbook to 5.12 (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11695?vs=30548&id=30861#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11695?vs=30548&id=30861 REVISION DETAIL https://phabricator.kde.org/D11695 AFFECTED FILES doc/kcontrol/clock/index.docbook To: lueck, #plasma, #documentation, yurchor Cc: yurchor, plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11234: [DrKonqi] Show debug button when KDevelop session is running
croick added a comment. bump REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick, #plasma_workspaces, apol, mwolff Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11794: Drop unused dependency
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D11794 AFFECTED FILES CMakeLists.txt To: asturmlechner Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Changes to networkmanager-qt - breakage in plasma-workspace
Hi Jan, It seems that as part of your recent changes to networkmanager-qt to increase the dependency to 1.0.0 you've made some other changes which mean the appropriate include paths are no longer being provided to projects that depend on networkmanager-qt. This has the unfortunate effect that plasma-workspace is no longer able to build on the CI system. The error is: In file included from /usr/include/libnm/nm-object.h:29:0, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/ipconfig.h:31, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/device.h:33, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:31, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1, from /home/jenkins/workspace/Dependency Build Plasma kf5-qt5 SUSEQt5.9/plasma-workspace/dataengines/geolocation/geolocation.cpp:25: /usr/include/libnm/nm-types.h:24:10: fatal error: gio/gio.h: No such file or directory Could you please take a look? Thanks, Ben
KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 509 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/509/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 22:14:54 + Build duration: 8 min 12 sec and counting CONSOLE OUTPUT [...truncated 1.34 MB...][ 94%] Linking CXX executable ../../../bin/servicerunnertest[ 94%] Building CXX object shell/CMakeFiles/plasmashell.dir/shellcorona.cpp.o[ 94%] Built target servicerunnertest[ 95%] Building CXX object runners/kill/CMakeFiles/krunner_kill.dir/krunner_kill_autogen/mocs_compilation.cpp.o[ 95%] Linking CXX shared module ../../bin/krunner_kill.so[ 95%] Built target krunner_kill[ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/shellmanager.cpp.oScanning dependencies of target plasma_engine_weather[ 95%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherengine.cpp.o[ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelshadows.cpp.oScanning dependencies of target plasma-geolocation-ip[ 95%] Building CXX object dataengines/geolocation/CMakeFiles/plasma-geolocation-ip.dir/location_ip.cpp.oIn file included from /usr/include/libnm/nm-object.h:29:0, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/ipconfig.h:31, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/device.h:33, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:31, from /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1, from /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/dataengines/geolocation/location_ip.cpp:31:/usr/include/libnm/nm-types.h:24:10: fatal error: gio/gio.h: No such file or directory #include ^~~compilation terminated.make[2]: *** [dataengines/geolocation/CMakeFiles/plasma-geolocation-ip.dir/build.make:63: dataengines/geolocation/CMakeFiles/plasma-geolocation-ip.dir/location_ip.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:10031: dataengines/geolocation/CMakeFiles/plasma-geolocation-ip.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 95%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/weatherenginedebug.cpp.o[ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/standaloneappcorona.cpp.o[ 95%] Building CXX object dataengines/weather/CMakeFiles/plasma_engine_weather.dir/plasma_engine_weather_autogen/mocs_compilation.cpp.o[ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/osd.cpp.o[ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/coronatesthelper.cpp.o[ 95%] Linking CXX shared module ../../bin/plasma_engine_weather.so[ 95%] Building CXX object shell/CMakeFiles/plasmashell.dir/debug.cpp.o[ 95%] Built target plasma_engine_weather[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/screenpool.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/appinterface.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/applet.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/containment.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/configgroup.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/i18n.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/rect.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/panel.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/scriptengine.cpp.o[ 96%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/scriptengine_v1.cpp.o[ 97%] Building CXX object shell/CMakeFiles/plasmashell.dir/scripting/widget.cpp.o[ 97%] Building CXX object shell/CMakeFiles/plasmashell.dir/plasmashelladaptor.cpp.o[ 97%] Building CXX object shell/CMakeFiles/plasmashell.dir/krunner_interface.cpp.o/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/shell/scripting/scriptengine_v1.cpp: In static member function 'static QScriptValue WorkspaceScripting::ScriptEngine::V1::immutability(QScriptContext*, QScriptEngine*)':/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/shell/scripting/scriptengine_v1.cpp:945:61: warning: unused parameter 'context' [-Wunused-parameter] QScriptValue ScriptEngine::V1::immutability(QScriptContext *context, ^~~/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 SUSEQt5.9/shell/scripting/scriptengine_v1.cpp: In instantiation of 'struct WorkspaceScripting::loadSerializedConfigs(Object*, const QScriptValue&):: [with Object = WorkspaceScripting::Containment]::':/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5
D6313: Support Icon Scale from Icon naming specification 0.13
cfeck added a comment.
Otherwise looks good. Maybe needs more feedback from testers.
INLINE COMMENTS
> kiconloader.cpp:1264
> {
> +return loadIcon(_name, group, 1.0 /*scale*/, size, state, overlays,
> path_store, canReturnNull);
> +}
indent
> kicontheme.cpp:169
> +} else if (scale > 2.1) {
> +integerScale = 3;
> +}
Unless the XDG spec forbids this, please add scale 4, too. Those 8K screens are
everywhere ;)
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D6313
To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,
davidedmundson, plasma-devel, #frameworks, ragreen, michaelh, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 510 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/510/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 03:25:52 + Build duration: 1 hr 10 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report17% (20/121)12% (56/452)12% (56/452)7% (2544/34502)6% (1538/26303)Coverage Breakdown by Package Name FilesClassesLinesConditionalsapplets.appmenu.lib0% (0/2)0% (0/2)0% (0/128)0% (0/86)applets.appmenu.plugin0% (0/4)0% (0/4)0% (0/162)0% (0/144)applets.calendar0% (0/1)0% (0/1)0% (0/6)100% (0/0)applets.digital-clock.plugin0% (0/7)0% (0/7)0% (0/862)0% (0/86)applets.icon0% (0/1)0% (0/1)0% (0/263)0% (0/230)applets.notifications.lib0% (0/1)0% (0/1)0% (0/52)0% (0/28)applets.notifications.plugin0% (0/6)0% (0/6)0% (0/303)0% (0/138)applets.systemtray0% (0/1)0% (0/1)0% (0/272)0% (0/289)applets.systemtray.container0% (0/1)0% (0/1)0% (0/60)0% (0/52)applets.systemtray.tests.statusnotifier0% (0/3)0% (0/3)0% (0/187)0% (0/40)appmenu0% (0/7)0% (0/7)0% (0/172)0% (0/74)components.keyboardlayout0% (0/3)0% (0/3)0% (0/77)0% (0/38)components.sessionsprivate0% (0/4)0% (0/4)0% (0/156)0% (0/114)components.shellprivate0% (0/2)0% (0/2)0% (0/6)0% (0/2)components.shellprivate.interactiveconsole0% (0/2)0% (0/2)0% (0/351)0% (0/132)components.shellprivate.widgetexplorer0% (0/8)0% (0/8)0% (0/571)0% (0/411)containmentactions.applauncher0% (0/1)0% (0/1)0% (0/52)0% (0/36)containmentactions.contextmenu0% (0/1)0% (0/1)0%
