D11876: Display star ratings

[Andrew Crouthamel]

acrouthamel added a comment.


  Awesome patch!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11876

To: ngraham, apol, #discover_software_store
Cc: acrouthamel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

[Nathaniel Graham]

ngraham added a comment.


  In D11848#238363 , @davidedmundson 
wrote:
  
  > That second diagram literally has that arrow crossing through the History 
tab...
  
  
  Yes, I drew the arrow that way deliberately to illustrate that it still works 
okay for the absolute worst case scenario:
  
  - Right-most tab is active
  - User decides to move the mouse diagonally to position it over the text of 
an item low down in the list, in the process crossing over the History tab
  
  Virtually all other use cases will not have the above constraints and the 
user can be expected to move the cursor straight up.
  
  I just increased the timer to 50ms, and here's a video showing that there 
isn't a problem:
  
  F5781330: Works fine-2018-04-01_17.07.40.webm 

  
  That said, I agree that a very lenient triangle filter might work better 
here, so I'm willing to give it a shot.
  
  In D11848#238363 , @davidedmundson 
wrote:
  
  > I did once write a generic QML implementation of a triangle menu filter, 
implementing something like 
http://bjk5.com/post/44698559168/breaking-down-amazons-mega-dropdown 
  >  https://phabricator.kde.org/P183
  >
  > The reason I didn't push forward with it was because I found afterwards it 
didn't solve the bug I was trying to solve, moving the mouse to task manager 
tooltips, where my mouse is moving outside an area we control. Would cover the 
kicker/kickoff cases fine. I can revisit that if wanted.
  
  
  That sounds like a sane, humane, and re-usable solution!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11848

To: ngraham, #plasma, davidedmundson, abetts
Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

[Nathaniel Graham]

ngraham updated this revision to Diff 31134.
ngraham added a comment.


  Increase threshold to 50ms until I/we can implement a triangle filter thingy

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11848?vs=31068&id=31134

BRANCH
  faster-kickoff-tab-switch-on-hover (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11848

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: ngraham, #plasma, davidedmundson, abetts
Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11801: remove m_desktopContainments

[David Edmundson]

davidedmundson added a comment.


  Now that previous containmentForScreen patch is looking a thousand times 
better. Good stuff.
  
  +1

INLINE COMMENTS

> shellcorona.cpp:1256
>  if (containment) {
>  containment->setActivity(activity);
>  insertContainment(activity, screenNum, containment);

This shouldn't be needed if we pass it as an arg to containmentForScreen

> shellcorona.cpp:1596
> +Plasma::Containment *oldContainment = containmentForScreen(screen, 
> m_activityController->currentActivity(), QString());
> +qWarning()<<"OLD CONT"<  //no valid containment in given screen, giving up

fix

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11801

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  That second diagram literally has that arrow crossing through the History 
tab...
  
  I'm not approving something that replaces one bug with a different known bug. 
Even if it will affect fewer people.
  
  Especially if kicker has some code we can copy paste.
  
  I did once write a generic QML implementation of a triangle menu filter, 
implementing something like 
http://bjk5.com/post/44698559168/breaking-down-amazons-mega-dropdown 
  https://phabricator.kde.org/P183
  
  The reason I didn't push forward with it was because I found afterwards it 
didn't solve the bug I was trying to solve, moving the mouse to task manager 
tooltips, where my mouse is moving outside an area we control. Would cover the 
kicker/kickoff cases fine. I can revisit that if wanted.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11848

To: ngraham, #plasma, davidedmundson, abetts
Cc: rikmills, hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11722: If GL context creation fails fall back to the software renderer

[David Edmundson]

davidedmundson added a comment.


  Kwin's crash detection is this pernament

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11722

To: davidedmundson, #plasma
Cc: mart, broulik, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11848: [Kickoff] Reduce hover delay before switching tabs

[Nathaniel Graham]

ngraham added a comment.


  I agree with @hein that the reason is probably " a poor man's implementation 
of lazy menus".
  
  The thing is, it's an inappropriate application of the feature and isn't 
necessary here. Allow me to put on my Usability Consultant hat and me 
illustrate why:
  
  Lazy menus are critically important for traditional horizontal menus that 
have cascading sub-menus. With this pattern, when you move your cursor 
diagonally to quickly to reach a sub-menu item, it unavoidably has to pass over 
several other top-level menu items to reach the desired sub-menu item, as 
illustrated with Kicker and an arrow showing the corsor's path to reach a 
sub-menu item:
  
  F5780979: Kicker.png 
  
  As you can see, without some logic to handle this case, another top-level 
item would become activated the moment the cursor leaves the current menu area.
  
  But with Kickoff, the user interface is different. Let's look at the same 
basic task and with an arrow describing the worst-case-scenario cursor movement:
  
  F5780980: Kickoff.png 
  
  Kickoff does not implement the pattern of horizontal menus with cascading 
sub-menus. Instead, it has a tabbed UI that renders the "lazy menus" feature 
inapplicable for the following reasons:
  
  - The top-level items (the tabs) are large square buttons, not small 
horizontal rectangles; even with a diagonal movement, there is a good chance 
the cursor never leaved the area of the current tab
  - You can always move your mouse vertically to reach the desired item within 
a tab, because the hover area for entries within tabs take up the whole 
horizontal space
  - Even in the worst-case scenario where a user is on a far right tab, doesn't 
realize that the whole horizontal area is a click target, and moves their 
cursor slowly and diagonally to reach a left-aligned item that's near the 
bottom of the list , even then the cursor only just barely clips the area for 
another tab and the cursor will only be there for a millisecond or two
  
  In conclusion, the "lazy menus" pattern only applies to traditional 
horizontal menus with cascading sub-menus and is inapplicable to Kickoff. 
Therefore, the long delay that attempts to provide this unneeded feature is 
itself unneeded.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11848

To: ngraham, #plasma, davidedmundson, abetts
Cc: hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11849: [kdecoration] properly compare opacity values

[Vlad Zagorodniy]

zzag added a comment.


  In D11849#238233 , @broulik wrote:
  
  > Why not use `qFuzzyCompare`?
  
  
  Opacity can be 0. But yeah, I could also use the +1 trick.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11849

To: zzag, #breeze
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11849: [kdecoration] properly compare opacity values

[Kai Uwe Broulik]

broulik added a comment.


  Why not use `qFuzzyCompare`?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11849

To: zzag, #breeze
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11842: Remove categories from app delegates

[Nathaniel Graham]

ngraham updated this revision to Diff 31109.
ngraham added a comment.


  Rebase on master

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11842?vs=31054&id=31109

BRANCH
  remove-categories-on-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11842

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11855: By default, sort app lists by rating again

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:1735ac9d97f0: By default, sort app lists by rating again 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11855?vs=31080&id=31108

REVISION DETAIL
  https://phabricator.kde.org/D11855

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11866: Fix install target for kgamma

[Burkhard Lück]

lueck updated this revision to Diff 31105.
lueck added a reviewer: Localization.
lueck added a comment.


  change install target to kgamma5, that is the target generated by scripty 
using autogen.sh

REPOSITORY
  R100 KGamma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11866?vs=31104&id=31105

REVISION DETAIL
  https://phabricator.kde.org/D11866

AFFECTED FILES
  doc/CMakeLists.txt
  kcmkgamma/kgamma.desktop

To: lueck, #plasma, #documentation, #localization
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11866: Fix install target for kgamma

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
lueck requested review of this revision.

TEST PLAN
  builds

REPOSITORY
  R100 KGamma

REVISION DETAIL
  https://phabricator.kde.org/D11866

AFFECTED FILES
  doc/CMakeLists.txt

To: lueck, #plasma, #documentation
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11864: Update kinfocenter docbook to 5.12

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread
  bump date + realeaseinfo
  kde -> plasma
  add energy + fileindexer+wayland
  group subitems to Device / Network / Graphical items

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D11864

AFFECTED FILES
  doc/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Look N' Feel and Latte Dock

[Michail Vourlakos]

Hello everyone,

Latte is a few months before its next major release (v0.8 that is).
Very exciting features this is going to bring and I would like to
investigate if I can use this month for one important feature (Look N' Feel
support).

Can anyone give me some hints how this can be achieved?
Is something needed to be added in plasma side or what should Latte do on
its side?

regards,
michail

D11860: [kstyle] use Q_FALLTHROUGH in breezesplitterproxy

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Qt has its own macro to tell the compiler that the lack of the break
  statement is intentional. One of the advantages of using Q_FALLTHROUGH
  is that it explicitly says other developers that the break statement is
  missing on purpose. Another advantage is that we can use directives,
  see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817

TEST PLAN
  Compiled Breeze with GCC 7 and Clang, no "this statement may fall 
  through" warnings whatsoever.

REPOSITORY
  R31 Breeze

BRANCH
  q-fallthrough

REVISION DETAIL
  https://phabricator.kde.org/D11860

AFFECTED FILES
  kstyle/breezesplitterproxy.cpp

To: zzag, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

[Eike Hein]

hein added a comment.


  And FWIW, the main reason there's a delay right now is probably as a poor 
man's implementation of lazy menus. If you're hitting the menu button in the 
lower-left of the screen and then move the pointer to, say, the third or forth 
tab, you're likely to graze adjacent tabs in the process. The delay is there to 
avoid Kickoff switching in that event, to make it feel calmer and more elegant.
  
  The Kicker menu e.g. contains (albeit smarter) code to handle a similar 
problem. It interprets purely vertical and diagonal mouse pointer moves 
differently, so that if you move vertically in the menu it will switch 
categories and open subdialogs immediately, but if you move diagonally into a 
subdialog there's some delay to avoid grazing adjacent categories switching the 
subdialog to that category.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11848

To: ngraham, #plasma, davidedmundson, abetts
Cc: hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

[Eike Hein]

hein added a comment.


  It's also worth noting that the way the delay and the animation are currently 
implemented makes it pretty ugly even in the case of an accidental overshoot. 
If you do A->B->A in quick succession, the move from B back to A doesn't 
commence until the animation moving from A to B has finished playing. This can 
make it feel like Kickoff is running behind and struggling to keep up.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11848

To: ngraham, #plasma, davidedmundson, abetts
Cc: hein, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart