D8626: DDCUtil: Improved DDCUtil support for brightness control

2018-04-15 Thread Dorian Vogel 
dvogel updated this revision to Diff 32187.
dvogel marked 5 inline comments as done.
dvogel added a comment.


  Applied changes suggested by broulik.
  CMake fixed, using the checkbox for WITH_DDCUTIL in Kdevelop now works.
  I must appologise for the long time this is taking. The diff is based on 
5.12.4, since 5.12.80 is not available on my system (Arch). I will try to 
rebase.

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8626?vs=21788&id=32187

REVISION DETAIL
  https://phabricator.kde.org/D8626

AFFECTED FILES
  CMakeLists.txt
  backends/upower/ddcutilbrightness.cpp
  backends/upower/ddcutilbrightness.h

To: dvogel, broulik, davidedmundson
Cc: asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: String freeze exception for Plasma/5.12 (documentation)

2018-04-15 Thread Burkhard Lück 
Am Dienstag, 10. April 2018, 23:13:43 CEST schrieb Luigi Toscano:
> Hi,
> 
> I'd like to request an exception for the documentation of kcmsmserver in
> Plasma/5.12, and namely the backport of this review:
> https://phabricator.kde.org/D11817
> 
> which fixes various references to Plasma instead of KDE.
> 
> Given the LTS nature of Plasma 5.12 I think it's worth doing it.
> 
> Comments/ideas/disagreements?
> 
There are some more updates for Plasma 5.12, KFontView, System Settings, 
autostart, clock, colors, cursortheme, desktopthemedetails, fontinst, fonts, 
kcmlaunchfeedback, kcmnotify, kcmstyle, keys, kwindecoration, mouse, 
translations, see https://techbase.kde.org/Projects/Documentation/
KDE_(health_table)#kde-workspace and https://techbase.kde.org/Projects/
Documentation/KDE_(health_table)/kcontrol5#kde-workspace

All of them could be backported to 5.12 LTS before the release of Plasma 
5.12.5 LTS Tue 2018-05-01

-- 
Burkhard Lück

D12055: Delete border around menubars

2018-04-15 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11909: properly use kpackage_install_package

2018-04-15 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11909

To: zzag, #breeze
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham 
ngraham added a comment.


  In fact, we've got an open request to //add// this line to the Breeze theme 
for Qt apps...
  
  https://bugs.kde.org/show_bug.cgi?id=386306

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

2018-04-15 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Save the view settings when the user closes the dialog using the excape key 
or the titlebar close button. Completes the feature requested in 209559.
  
  CCBUG: 209559
  
  Depends on D12239 

TEST PLAN
  Compile and deploy change, open Kate, open a file open or save dialog, change 
some settings, hit the escape key or the titlebar cancel button, then open a 
dialog again

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  save-view-config-on-close-and-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12240

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h

To: ngraham, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Vlad Zagorodniy 
zzag abandoned this revision.
zzag added a comment.


  In D12055#246990 , @ngraham wrote:
  
  > In fact, we've got an open request to //add// this line to the Breeze theme 
for Qt apps...
  >
  > https://bugs.kde.org/show_bug.cgi?id=386306
  
  
  OK, I won't insist on this change. That's not really hard to patch breeze gtk 
theme. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham 
ngraham added a comment.


  I didn't want to kill this revision, sorry! Just wanted to throw that out 
there for discussion purposes.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham 
ngraham added a comment.


  In fact, please re-open this. Let's have an actual discussion about this, and 
sorry for the silence so far...

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-15 Thread Chris Holland 
Zren updated this revision to Diff 32246.
Zren retitled this revision from "[WIP] Add "Get Wallpaper Plugins..." button 
to Config Desktop dialog" to "Add "Get Wallpaper Plugins..." button to Config 
Desktop dialog".
Zren edited the summary of this revision.
Zren added a comment.


  Change from Wallpaper.Image to the ShellPrivate.WallpaperPlugin

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12041?vs=31700&id=32246

REVISION DETAIL
  https://phabricator.kde.org/D12041

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: Zren, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-04-15 Thread Chris Holland 
Zren updated this revision to Diff 32247.
Zren edited the summary of this revision.
Zren added a comment.


  Move open GHNS window function from Wallpaper.Image to 
ShellPrivate.WallpaperPlugin

REPOSITORY
  R131 Plasma Wallpapers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=31651&id=32247

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-15 Thread Chris Holland 
Zren added a comment.


  I'm still unsure how to update the dropdown after you download a new plugin.
  
  I've moved the "open GHNS window" function in plasma-workspace to 
`components/shellprivate/wallpaperplugin`, but I've just noticed the dropdown 
is populated by `configDialog.wallpaperConfigModel`
  
  - 
https://github.com/KDE/plasma-desktop/blob/master/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml#L141
  
  which is populated here:
  
  - 
https://github.com/KDE/plasma-workspace/blob/master/shell/containmentconfigview.cpp#L114

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12173: [Workspace Scripting] Turn "gridUnit" into a property getter function

2018-04-15 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2082cfcbfa33: [Workspace Scripting] Turn 
"gridUnit" into a property getter function (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12173?vs=32063&id=32249

REVISION DETAIL
  https://phabricator.kde.org/D12173

AFFECTED FILES
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart