D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Scott Harvey]

sharvey updated this revision to Diff 32938.
sharvey added a comment.


  - Turned off "glow" effect on vendor URL; was rendering strange transparency

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12479?vs=32917=32938

BRANCH
  polish-detail-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12479

AFFECTED FILES
  AuthDialog.cpp
  authdetails.ui

To: sharvey, davidedmundson, ngraham, #plasma
Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Stefan Brüns]

bruns added a comment.


  In D12311#252212 , @stikonas wrote:
  
  > In D12311#252165 , @bruns wrote:
  >
  > > Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize
  >
  >
  > Does not work well yet, just a few errors where KPM succeeds:
  >
  > - Cannot resize btrfs filesystem on /dev/sdb1: (null) filesystem 'btrfs' is 
not supported.
  
  
  Wrong, tested, works. You have to use 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Filesystem.BTRFS.html

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Nathaniel Graham]

ngraham added a comment.


  I do like this as a vastly superior replacement for "minimize to tray", yeah.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12481: Add dptr to models

[Nicolas Fella]

nicolasfella updated this revision to Diff 32924.
nicolasfella added a comment.


  - Remove unneeded modifier

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32921=32924

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in models.h:81
> Why `void*`?

So we can replace it with a "real" private class when we need it without 
creating a empty one now

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> models.h:47
>  
> -~AbstractModel() override;
> +virtual ~AbstractModel() override;
>  QHash roleNames() const Q_DECL_FINAL;

The `override` is sufficient

> models.h:81
> +private:
> +void *d;
>  };

Why `void*`?

> models_p.h:26
> +
> +class AbstractModelPrivate
> +{

Do we need an explicit `Q_DECL_HIDDEN` or something?

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

[Nicolas Fella]

nicolasfella updated this revision to Diff 32921.
nicolasfella added a comment.


  - Add license header

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32920=32921

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham
Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Scott Harvey]

sharvey added a comment.


  A little UI polishing, just for the details panel. The redesign of the main 
dialog is still under discussion (T8569 , 
D12311 ) so I touched up the details.
  
  Does anyone know of an application that fills in the `Application` field? I 
haven't been able to find one. I also went down the rabbit hole on how 
PolicyKit is triggered and couldn't find a solution. It's always blank.
  
  If there's a way to get hold of the application name that's asking for 
authorization, it would be nice to have access to. If nothing else, it belongs 
in the window titlebar.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12481: Add dptr to models

[Nicolas Fella]

nicolasfella updated this revision to Diff 32920.
nicolasfella added a comment.


  - Coding style

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32919=32920

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: drosca, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Last exported classes without dptr

TEST PLAN
  Builds

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Scott Harvey]

sharvey added a comment.


  **Before**
  F5819725: polkit-details-before.png 
  
  
  
  **After**
  F5819727: polkit-details-after.png 

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Scott Harvey]

sharvey created this revision.
sharvey added reviewers: davidedmundson, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Aligned detail item labels; added "Not Applicable" when PolicyKit info is 
missing

TEST PLAN
  - Apply patch
- Kill and relaunch `polkit-kde-authentication-agent-1`
- Launch an application or change a KCM that prompts for authorization
- Check that details are no longer left blank

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  polish-detail-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12479

AFFECTED FILES
  AuthDialog.cpp
  authdetails.ui

To: sharvey, davidedmundson, ngraham
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

[Christian]

Fuchs added a comment.


  On the existing bug: it's related to the TODO, changing that to
  
for (int i = 0; i < d->concatProxyModel->rowCount(); ++i) {
const QModelIndex  = d->concatProxyModel->index(i, 0);

// Launchers can't be pinned / unpinned
if (itIndex.data(AbstractTasksModel::IsLauncher).toBool()) {
continue;
}

dataChanged(itIndex, itIndex, 
QVector{AbstractTasksModel::IsPinned});

}
  
  fixes the bug, but of course that goes through all items and not only the 
needed ones, so it's bad performance-wise.
  

  
  Oddly enough, changing the second part to
  
// Check all windows if they match, then update the isPinned for them too. 
// This is needed so if you pin / unpin an app that has multiple instances 
open, all are updated.
if (appsMatch(index, itIndex)) {
dataChanged(itIndex, itIndex, 
QVector{AbstractTasksModel::IsPinned});
}
  
  matched only parts of the same window, so if I e.g. had 3 konsole instances 
open, it affected 2/3 sometimes.
  
  No idea what I am doing wrong here, hopefully @hein  will know what list I 
best iterate over and how to best compare them, so it's not only fixed, but 
fixed without performance impact.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12462

To: Fuchs, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Lindsay Roberts]

roberts created this revision.
roberts added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
roberts requested review of this revision.

REVISION SUMMARY
  Currently DRI information retrieval is attempted via /proc/dri, which
  was removed from the linux kernel in v3.12 (2013). This information
  includes the kernel driver in use as well as card identification sourced
  from pci.ids database.
  
  This adds support for retrieving this information in the same vein via
  /dev and /sys for modern kernels.

TEST PLAN
  kcmshell5 opengl should correctly display kernel driver.

REPOSITORY
  R102 KInfoCenter

BRANCH
  kcm_opengl_fix_dri_info

REVISION DETAIL
  https://phabricator.kde.org/D12476

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: roberts, #plasma
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12455: kcm_opengl: Fix EGL info retrieval.

[Fabian Vogt]

fvogt added a comment.


  What about Plasma/5.12?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12455

To: roberts, #plasma, davidedmundson, graesslin
Cc: fvogt, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12455: kcm_opengl: Fix EGL info retrieval.

[Lindsay Roberts]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:f4af6581d03e: kcm_opengl: Fix EGL info retrieval. 
(authored by roberts).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12455?vs=32837=32903

REVISION DETAIL
  https://phabricator.kde.org/D12455

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: roberts, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

[Kirill Tatunov]

ktatunov updated this revision to Diff 32902.
ktatunov added a comment.


  Replace `mipmap` with `sourceSize`.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12469?vs=32891=32902

REVISION DETAIL
  https://phabricator.kde.org/D12469

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: ktatunov, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

[Kirill Tatunov]

ktatunov added a comment.


  Thanks for the pointer. Upon further investigation it looks like setting
  
sourceSize.width: width
sourceSize.height: height
  
  instead of mipmap works well for more or less square images. However, for 
images that are significantly wider than they are taller (or vice versa) 
quality is degrading.
  
  F5819557: kickoff-sourcesize-after-horizontal.png 

  
  F5819559: kickoff-sourcesize-after-vertical.png 

  
  AFAICT, `Image` in qml loads the image in a mode equivalent to 
`Image.PreserveAspectCrop` (at least in this case) after which `Image`'s 
scaling kicks in. So images that are really wide or really tall end up being 
loaded at a resolution that is way off and then scaled.
  I guess it's not that big of a price to pay so I'll replace `mipmap` with 
`sourceSize`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12469

To: ktatunov, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5961: PoC: Generic adoption of KUserFeedback for Discover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32897.
apol added a comment.


  adapt

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=32887=32897

BRANCH
  arcpatch-D5961

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/discover.schema
  discover/qml/DiscoverWindow.qml
  discover/qml/SourcesPage.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  Beautiful! Could we move the pushbuttons over like 2 pixels to the left so 
they're vertically aligned with the labels above them?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12278: WIP: [Colors KCM] Port to new design

[Kai Uwe Broulik]

broulik added a comment.


  This is what it will most likely look like once the tinting of controls has 
been figured out
  F5819517: Screenshot_20180423_185432.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Christian]

Fuchs added a comment.


  In D12463#252419 , @ngraham wrote:
  
  > This is a neat feature, but I worry that it would muddy the difference 
between the regular task manager and the icons-only task manager. It's not 
inconceivable that a user wanting to get an IOTM-style panel would resort to 
using this feature to force every single window to be icon-only.
  
  
  Well, personally I am not going to use it as I use icon tasks, but the people 
who wished for it seem to not want icon tasks,
  
  Initial discussion  in the VDG group was (anonymized, for now):
  
  anon1, [08.03.18 16:06]
  [In reply to KDE IRC Relay Service]
  if you "pin" an app you get an starter icon, if the app is not running, but a 
full task bar entry, if the app is running.
  
  But there is no way to "pin" like in a browser, icon only even when running.
  
  KDE IRC Relay Service, [08.03.18 16:06]
   ah that
   yeah I wish we had that
   (and no, I dont want to change to icon tasks)
  
  anon1, [08.03.18 16:07]
  then there would be far less need to minimize to systray
  
  KDE IRC Relay Service, [08.03.18 16:08]
   KMail shows unread mail count in task bar, has "check for mail" 
option in the menu, so I dont see a reason for kmail tray icon for instance
  
  anon1, [08.03.18 16:09]
  I only show windows from the current screen in the task bar
  
  anon1, [08.03.18 16:09]
  current virtual desktop *
  
  and https://forum.kde.org/viewtopic.php?f=285=136113  was thrown at me, 
which has some discussion as well.
  
  I can see definitely some valid points, e.g. having it for applications you 
only have one instance (which makes the window title irrelevant in most cases) 
and basically only care about the notification, kmail/kontact was named as an 
example, but I could see the same apply to chat / instant messaging systems.
  
  As said, personally I am not going to use it, but I definitely see good use 
cases which separates this from icon only(icon only is a massive pain if 
you often have multiple windows of the same application you need to be able to 
quickly distinguish)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Nathaniel Graham]

ngraham added a comment.


  This is a neat feature, but I worry that it would muddy the difference 
between the regular task manager and the icons-only task manager. It's not 
inconceivable that a user wanting to get an IOTM-style panel would resort to 
using this feature to force every single window to be icon-only.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

[David Edmundson]

davidedmundson added a comment.


  setting sourceWidth/height so that it resizes before the texture upload

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12469

To: ktatunov, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

[Kirill Tatunov]

ktatunov added a comment.


  In D12469#252388 , @davidedmundson 
wrote:
  
  > why mipmap?
  
  
  Because smooth property is enabled by default and it's apparently not enough 
for a good looking image.
  Unless I'm missing something, nothing else is available that controls 
smoothing of an Image element.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12469

To: ktatunov, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

[David Edmundson]

davidedmundson added a comment.


  why mipmap?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12469

To: ktatunov, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

[Kirill Tatunov]

ktatunov created this revision.
ktatunov added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ktatunov requested review of this revision.

REVISION SUMMARY
  QML Image element has some smoothing when scaling an image by default but 
it's not enough and the picture still looks a bit pixelated. This patch fixes 
that.
  Also while I was at it, I added keeping the aspect ratio, because no one 
likes their avatars stretched.
  
  BUG: 369327

TEST PLAN
  Before: F5819424: kickoff-before.2.png  
F5819425: kickoff-before-aspect-ratio.2.png 

  After: F5819429: kickoff-after.2.png  
F5819430: kickoff-after-aspect-ratio.2.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12469

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: ktatunov, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

[Kirill Tatunov]

ktatunov updated this revision to Diff 32890.
ktatunov added a comment.


  Qt::IgnoreAspectRatio -> Qt::KeepAspectRatio

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12468?vs=32880=32890

REVISION DETAIL
  https://phabricator.kde.org/D12468

AFFECTED FILES
  src/lib/accountmodel.cpp

To: ktatunov, #plasma, davidedmundson
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Andres Betts]

abetts added a comment.


  In D12278#252314 , @ngraham wrote:
  
  > Hmm, I'm not sure those white strips communicate "This is what text looks 
like." I think some sort of placeholder text would work better. To be honest I 
kinda liked the first one better, but I think it's mostly moot until we can 
show a real window or view preview.
  
  
  I am all for creating a concept that can do that. We make a sample window 
with the colors of each. Would it be too hard? @broulik

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12468: Enable anti-aliasing for user avatars

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma, davidedmundson
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I think so.
  
  Then ship it!

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

[Kirill Tatunov]

ktatunov added a comment.


  In D12468#252342 , @davidedmundson 
wrote:
  
  > why ignore aspect ratio?
  
  
  I kept the default behaviour for this argument since it wasn't what I was 
after. But now that you mention it it would probably be better to use 
Qt::KeepAspectRatio. I don't think anyone likes their avatars 
stretched/squashed.
  Shall I change it to that?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5961: PoC: Generic adoption of KUserFeedback for Discover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32887.
apol added a comment.


  Rebase to master

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5961?vs=15686=32887

BRANCH
  arcpatch-D5961

REVISION DETAIL
  https://phabricator.kde.org/D5961

AFFECTED FILES
  CMakeLists.txt
  discover/discover.schema
  discover/qml/DiscoverWindow.qml
  discover/qml/SourcesPage.qml
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h

To: apol, #plasma, vkrause
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12468: Enable anti-aliasing for user avatars

[David Edmundson]

davidedmundson added a comment.


  why ignore aspect ratio?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

[Nathaniel Graham]

ngraham added a comment.


  +1!

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

[Kirill Tatunov]

ktatunov created this revision.
ktatunov added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ktatunov requested review of this revision.

REVISION SUMMARY
  By default, QT uses fast transformations when scaling pixmaps but it results 
in a very pixelated image. This patch fixes it for avatars in the user manager 
module.

TEST PLAN
  Resolution of the original avatar image is 256x256.
  Before: F5819211: user-manager-before.png 

  After: F5819213: user-manager-after.png 

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

AFFECTED FILES
  src/lib/accountmodel.cpp

To: ktatunov, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I'm not sure those white strips communicate "This is what text looks 
like." I think some sort of placeholder text would work better. To be honest I 
kinda liked the first one better, but I think it's mostly moot until we can 
show a real window or view preview.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12375: [Power Management Engine] Fix kiosk restriction for lockscreen

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4932c6e2cbc9: [Power Management Engine] Fix kiosk 
restriction for lockscreen (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12375?vs=32634=32882

REVISION DETAIL
  https://phabricator.kde.org/D12375

AFFECTED FILES
  dataengines/powermanagement/powermanagementengine.cpp

To: broulik, #plasma, sitter, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cfd77db90cf6: [ContextMenu Containment Action] Fix 
checking for KIOSK (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12376?vs=32793=32883

REVISION DETAIL
  https://phabricator.kde.org/D12376

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Kai Uwe Broulik]

broulik updated this revision to Diff 32881.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Implement applying color schemes and notifying applications about that
  - Implement "Install from file" including drag and drop
  - Implement removing color schemes including undo feature
  - Remove "apply to non qt applications" checkbox
  - Somewhat improve thumbnail but it's still not ideal

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12278?vs=32376=32881

REVISION DETAIL
  https://phabricator.kde.org/D12278

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/Messages.sh
  kcms/colors/colors.cpp
  kcms/colors/colors.desktop
  kcms/colors/colors.h
  kcms/colors/colorscm.cpp
  kcms/colors/kcm_colors.desktop
  kcms/colors/package/contents/ui/main.qml
  kcms/colors/package/metadata.desktop

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12459: [Icon KCM] Port to new design

[Vlad Zagorodniy]

zzag added a comment.


  In D12459#252290 , @broulik wrote
  
  > Looks just like compression artefact in the screenshot. The theme cannot be 
uninstalled as it's system-wide and the thin lines seemed to throw it off.
  
  
  Yeah, it makes sense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12459

To: broulik, #plasma, #vdg
Cc: zzag, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:101b5f749aa9: Add KCM for adjusting QtQuick Rendering in 
Plasma (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7934?vs=32811=32879

REVISION DETAIL
  https://phabricator.kde.org/D7934

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/qtquicksettings/CMakeLists.txt
  kcms/qtquicksettings/Messages.sh
  kcms/qtquicksettings/kcmqtquicksettings.cpp
  kcms/qtquicksettings/kcmqtquicksettings.h
  kcms/qtquicksettings/kcmqtquicksettingswidget.ui
  kcms/qtquicksettings/qtquicksettings.desktop
  kcms/qtquicksettings/renderer.kcfg
  kcms/qtquicksettings/renderersettings.kcfgc

To: davidedmundson, #plasma, mart
Cc: abetts, mart, graesslin, alexeymin, sebas, broulik, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol

D12449: Add hidden system setting group

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:2b158ac36aa6: Add hidden system setting group (authored 
by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12449?vs=32813=32878#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12449?vs=32813=32878

REVISION DETAIL
  https://phabricator.kde.org/D12449

AFFECTED FILES
  categories/hidden.desktop

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12459: [Icon KCM] Port to new design

[Kai Uwe Broulik]

broulik added a comment.


  In D12459#252269 , @zzag wrote:
  
  > Delete button is not visible in the attached video at 0:14 (when you hover 
Breeze).
  
  
  Looks just like compression artefact in the screenshot. The theme cannot be 
uninstalled as it's system-wide and the thin lines seemed to throw it off.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12459

To: broulik, #plasma, #vdg
Cc: zzag, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12449: Add hidden system setting group

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> hidden.desktop:5
> +X-KDE-Weight=100
> +Icon=preferences-desktop-default-applications
> +Enabled=false

can you remove the icon?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12449

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

[Vlad Zagorodniy]

zzag added a comment.


  @broulik Ping.

REPOSITORY
  R31 Breeze

BRANCH
  drop-QStyleOptionProgressBarV2

REVISION DETAIL
  https://phabricator.kde.org/D12256

To: zzag, #breeze, hpereiradacosta
Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12459: [Icon KCM] Port to new design

[Vlad Zagorodniy]

zzag added a comment.


  Delete button is not visible in the attached video at 0:14 (when you hover 
Breeze).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12459

To: broulik, #plasma, #vdg
Cc: zzag, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12459: [Icon KCM] Port to new design

[Kai Uwe Broulik]

broulik updated this revision to Diff 32871.
broulik retitled this revision from "WIP: [Icon KCM] Port to new design" to 
"[Icon KCM] Port to new design".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Kill old KCM code
  - "Defaults" will switch back to `KIconTheme::defaultThemeName` or if that 
isn't there (is `hicolor` here which doesn't make sense) will use `breeze`
  - "Defaults" will also revert custom icon effects so the user can get rid of 
them now that they're no longer configurable
  - Apply icon settings to KDE4 apps
  - Add animated preview

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12459?vs=32843=32871

REVISION DETAIL
  https://phabricator.kde.org/D12459

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/Messages.sh
  kcms/icons/icons.cpp
  kcms/icons/icons.desktop
  kcms/icons/icons.h
  kcms/icons/iconthemes.cpp
  kcms/icons/iconthemes.h
  kcms/icons/kcm_icons.desktop
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/icons/package/metadata.desktop
  kcms/icons/tests/CMakeLists.txt
  kcms/icons/tests/testicons.cpp

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#252165 , @bruns wrote:
  
  > Resizing: 
http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize
  
  
  Does not work well yet, just a few errors where KPM succeeds:
  
  - Cannot resize btrfs filesystem on /dev/sdb1: (null) filesystem 'btrfs' is 
not supported.
  - LUKS encrypted ext4: looks like I can resize internal file system but no 
way to resize outer LUKS container (i.e. what cryptsetup resize does)
  - Does not recognize LVM PVs, no way to resize them.
  
  On the other hand, it might be useful in certain cases. E.g. to resize FAT 
and maybe HPFS (not all distros ship fatresize).
  
  In any case, resizing is not the only thing. No way to copy/move file systems.
  
  I'm not opposed to UDisks in principle, I am just saying it's not there yet.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12376

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Fabian Riethmayer]

fabianr updated this revision to Diff 32867.
fabianr added a comment.


  - Merge branch 'master' into swipe
  - added a screenshot for a desktop swipelistitem, small formating change
  - Added png file

REPOSITORY
  R985 KDE Human Interface Guidelines

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12091?vs=31867=32867

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

AFFECTED FILES
  source/components/index.rst
  source/components/swipelistitem.rst
  source/img/Dolphin_hover.png
  source/img/swipe.png
  source/patterns/command/index.rst
  source/patterns/command/ondemand.rst
  source/patterns/command/slide.rst

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b8762edefd04: Kicker: Make menus grow (to a limit) if the 
text doesnt fit on the default… (authored by aacid).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12171?vs=32047=32866

REVISION DETAIL
  https://phabricator.kde.org/D12171

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

To: aacid, #plasma, hein
Cc: fabianr, ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

[Pascal d'Hermilly]

https://bugs.kde.org/show_bug.cgi?id=369676

--- Comment #27 from Pascal d'Hermilly  ---
Looks good. You can read the text with a white background, right?
I'm having trouble imagining the whole thing from the explanation. 

Den 22. april 2018 16.41.19 CEST, Marco Martin 
skrev:
>https://bugs.kde.org/show_bug.cgi?id=369676
>
>Marco Martin  changed:
>
>   What|Removed |Added
>
> Status|CONFIRMED   |RESOLVED
> Resolution|--- |FIXED
> Latest Commit||https://commits.kde.org/pla
>  ||sma-workspace/448455c3c937c
>  ||ebc1358dc417b280b0008a4c196
>   Version Fixed In||5.13
>
>--- Comment #26 from Marco Martin  ---
>Git commit 448455c3c937cebc1358dc417b280b0008a4c196 by Marco Martin.
>Committed on 22/04/2018 at 14:41.
>Pushed by mart into branch 'master'.
>
>fade to blur when the login box appears
>
>Summary:
>for both lockscreen and login screen:
>
>* display the wallpaper and the clock with a shadow by default
>* at the first mouse or keyboard input, make the input fields appear
>* the actual controls appear pretty fast
>* the wallpaper starts to blur, desaturate and fade to darker
>* after 10 seconds make the controls disappear again
>
>* as soon as anything is written in the password field never fade out
>the
>controls
>* if the virtual keyboard is open, never fade out the controls
>* if anything is pushed on the stack, like "switch user", never fade
>the
>controls
>* Esc clears the field and makes controls disappear (closing keyboard
>if
>needed)
>
>the fade won't happen if the background is a simple color
>Related: bug 388622
>FIXED-IN: 5.13
>
>Depends on D12314
>
>Recommended D11309 and D11308 to change the default wallpaper to plasma
>wallpaper
>
>Test Plan: tested the behavior of all the above points
>
>Reviewers: #plasma, #vdg, ngraham
>
>Reviewed By: #vdg, ngraham
>
>Subscribers: zzag, abetts, davidedmundson, ngraham, plasma-devel
>
>Tags: #plasma
>
>Differential Revision: https://phabricator.kde.org/D11928
>
>M  +4-2lookandfeel/contents/components/Clock.qml
>M  +0-1   
>lookandfeel/contents/components/SessionManagementScreen.qml
>A  +182  -0lookandfeel/contents/components/WallpaperFader.qml
>[License:
>GPL (v2)]
>M  +81   -13   lookandfeel/contents/lockscreen/LockScreenUi.qml
>M  +2-0sddm-theme/Login.qml
>M  +308  -236  sddm-theme/Main.qml
>
>https://commits.kde.org/plasma-workspace/448455c3c937cebc1358dc417b280b0008a4c196
>
>-- 
>You are receiving this mail because:
>You are on the CC list for the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.