D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-31 Thread Aleix Pol Gonzalez 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f5cd75acadf4: Allow Kirigami build without KWin tablet 
mode dependency (authored by murillobernardes, committed by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13148?vs=35133=35297

REVISION DETAIL
  https://phabricator.kde.org/D13148

AFFECTED FILES
  CMakeLists.txt
  src/libkirigami/CMakeLists.txt
  src/libkirigami/tabletmodewatcher.cpp

To: murillobernardes, mart, davidedmundson
Cc: apol, davidedmundson, plasma-devel, mart, hein

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-31 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D13148#271691 , 
@murillobernardes wrote:
  
  > Sorry, first time contributing to kde-related project.
  >
  > I’m not sure what I need to do next? Send a pull request somewhere?
  
  
  No, you just would land the patch. I'm guessing you don't have contributor 
powers as it's your first time, I'll land it for you.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13148

To: murillobernardes, mart, davidedmundson
Cc: apol, davidedmundson, plasma-devel, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 35296.
apol added a comment.


  Remove property, only assign the palette if there's a palette property

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13237?vs=35255=35296

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13237

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

2018-05-31 Thread Roman Gilg 
romangg added a comment.


  In D7038#265444 , @graesslin wrote:
  
  > any update on this?
  
  
  Currently I'm working on other stuff and don't want to increase the mental 
load. I really only need this when looking again into sub-surfaces to handle 
Xwayland Present on child windows. But if there are some real-life problems 
associated with this patch missing I will look at it again.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, schernikov, 
michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D13255: Make dependency on KF5NetworkManagerQt optional

2018-05-31 Thread Andreas Sturmlechner 
asturmlechner added a comment.


  (this is me forwarding a Gentoo user contribution)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D13255

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13255: Make dependency on KF5NetworkManagerQt optional

2018-05-31 Thread Andreas Sturmlechner 
asturmlechner created this revision.
asturmlechner added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R845 Plasma Vault

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13255

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/config-plasma-vault.cmake
  kded/service.cpp

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-31 Thread Murillo Bernardes 
murillobernardes added a comment.


  Sorry, first time contributing to kde-related project.
  
  I’m not sure what I need to do next? Send a pull request somewhere?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13148

To: murillobernardes, mart, davidedmundson
Cc: davidedmundson, plasma-devel, apol, mart, hein

D13240: Fix wrong full form of acronym SMB in kinfocenter docbook

2018-05-31 Thread Burkhard Lück 
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:f40ba4b48f34: Fix wrong full form of acronym SMB in 
kinfocenter docbook (authored by lueck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13240?vs=35258=35274

REVISION DETAIL
  https://phabricator.kde.org/D13240

AFFECTED FILES
  doc/index.docbook

To: lueck, #plasma, #documentation, ngraham
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13243: Add checkbox that can show virtual streams in the applet.

2018-05-31 Thread Sefa Eyeoglu 
sefaeyeoglu created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sefaeyeoglu requested review of this revision.

REVISION SUMMARY
  Adds a checkbox and changes the filter of the ListView models.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13243

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

To: sefaeyeoglu
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Marco Martin 
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PrivateActionToolButton.qml:62
>  
> -flat: true
> +palette.button: control.kirigamiAction ? 
> control.kirigamiAction.icon.color : undefined
> +property bool mainButton: false

note that this can't be used directly, as it depends from Qt 5.10
while if the button is colored by the method in D13232 
 this shouldn't happen
so this shouldn't be pushed until can be done without breaking deps

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13148: Allow Kirigami build without KWin tablet mode dependency

2018-05-31 Thread Marco Martin 
mart added a comment.


  ping?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13148

To: murillobernardes, mart, davidedmundson
Cc: davidedmundson, plasma-devel, apol, mart, hein

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

2018-05-31 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.


  Would be good if we can make this a more generic component in future, but we 
should land this as-is first.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff_triangle_filter

REVISION DETAIL
  https://phabricator.kde.org/D13192

To: hein, ngraham, davidedmundson, rkflx, cfeck
Cc: broulik, mart, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D13194: Use the new drag handle in the Language KCM

2018-05-31 Thread Eike Hein 
hein updated this revision to Diff 35260.
hein added a comment.


  Drop height and anchors as per Marco's advise.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35249=35260

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13240: Fix wrong full form of acronym SMB in kinfocenter docbook

2018-05-31 Thread Burkhard Lück 
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added projects: Plasma, Documentation.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365233(v=vs.85).aspx 
reads:
  
  "The Server Message Block (SMB) Protocol is ..."

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D13240

AFFECTED FILES
  doc/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> ToolBarApplicationHeader.qml:105
>  showText: !parent.toobig
> +mainButton: true
>  }

can just assign flat: false instead of adding a new property in 
actiontoolbutton?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 35255.
apol added a comment.


  Address some typos and added nate's margin

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13237?vs=35254=35255

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13237

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D13237#271434 , @ngraham wrote:
  
  > Love it! Two issues that I can see:
  >
  > - In this example, the text really needs to be white; it doesn't show up 
well against the dark green background. If the color is programmatically 
determined, we may need some fancy logic to choose the button's text color to 
ensure that it's visible enough. For that matter, the icon doesn't show up very 
well either...
  
  
  Yeah... thought so too. If people are not against the idea it's something to 
spend time on. I'm afraid it could look weird though...
  
  > - The button has no right padding, and touches the window edge ( A Discover 
issue?)
  
  No, still in kirigami, it's just that with a non-flat button we don't take 
into account the padding within the button as a margin. We can add a margin.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Love it! Two issues that I can see:
  
  - In this example, the text really needs to be white; it doesn't show up well 
against the dark green background. If the color is programmatically determined, 
we may need some fancy logic to choose the button's text color to ensure that 
it's visible enough. For that matter, the icon doesn't show up very well 
either...
  - The button has no right padding, and touches the window edge ( A Discover 
issue?)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Aleix Pol Gonzalez 
apol added a comment.


  F5880995: greenbutton.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

2018-05-31 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Show it as a full button instead of a tool button.
  Use the icon color as the button color.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13237

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D13194: Use the new drag handle in the Language KCM

2018-05-31 Thread Eike Hein 
hein updated this revision to Diff 35249.
hein added a comment.


  Reference correct variable.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35247=35249

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13194: Use the new drag handle in the Language KCM

2018-05-31 Thread Eike Hein 
hein updated this revision to Diff 35247.
hein added a comment.


  Uncheck sheet list items when the sheet is closed.
  
  This now has to be done explicitly as the delegates no longer get
  destroyed with the use of a DelegateRecycler.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13194?vs=35209=35247

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13194

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/translations.cpp
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13233: Support for the Custom color set

2018-05-31 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> plasmadesktoptheme.cpp:177
> +
> +QPalette pal;
> +for (auto state : { QPalette::Active, QPalette::Inactive, 
> QPalette::Disabled }) {

I don't understand this part of the patch in relation to custom color set 
support.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13233

To: mart, #kirigami, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13233: Support for the Custom color set

2018-05-31 Thread Marco Martin 
mart added a comment.


  F5880598: image.png 

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13233

To: mart, #kirigami, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13233: Support for the Custom color set

2018-05-31 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Kirigami.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  In some scenarios, some applications need certain areas with completely custom
  palettes, for instance if a piece of ui is on top of an image it may make
  sense that hierarchy uses whatever the dominant colors of such image are.
  in the scenario of a Custom color set, the qml code would look like this:
  needs D13232 
  Item {
  
Kirigami.Theme.inherit: false
Kirigami.Theme.colorSet: Kirigami.Theme.Custom
Kirigami.Theme.textColor: "#af2352"
Kirigami.Theme.backgroundColor: "#124523"
  
  ...
  
  }

TEST PLAN
  piece with a custom set in the gallery

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  mart/customColors

REVISION DETAIL
  https://phabricator.kde.org/D13233

AFFECTED FILES
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp

To: mart, #kirigami
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13232: introduce Custom color set

2018-05-31 Thread Marco Martin 
mart added a comment.


  F5880591: image.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13232

To: mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D13232: introduce Custom color set

2018-05-31 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  In some scenarios, some applications need certain areas with completely custom
  palettes, for instance if a piece of ui is on top of an image it may make
  sense that hierarchy uses whatever the dominant colors of such image are.
  in the scenario of a Custom color set, the qml code would look like this:
  Item {
  
Kirigami.Theme.inherit: false
Kirigami.Theme.colorSet: Kirigami.Theme.Custom
Kirigami.Theme.textColor: "#af2352"
Kirigami.Theme.backgroundColor: "#124523"
...
  
  }

TEST PLAN
  piece with a custom set in the gallery

REPOSITORY
  R169 Kirigami

BRANCH
  mart/customColors

REVISION DETAIL
  https://phabricator.kde.org/D13232

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ColorSetGallery.qml
  src/kirigamiplugin.cpp
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h
  src/styles/Material/Theme.qml

To: mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein