D13372: Mouse KCM Redesign Using Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Maybe we should use the same wording for the middle-click emulation feature 
that we did with the touchpad KCM ("Press left and right buttons for 
middle-click")? The reasoning being that "Emulate middle button" is a pretty 
technical phrase that doesn't really indicate what it does if you don't already 
know.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13372

To: furkantokac, ngraham, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[ksysguard] [Bug 395095] New: Add a process details dialog showing more information from /proc/[pid]/stat

[Chris Xiong]

https://bugs.kde.org/show_bug.cgi?id=395095

Bug ID: 395095
   Summary: Add a process details dialog showing more information
from /proc/[pid]/stat
   Product: ksysguard
   Version: 5.12.5
  Platform: unspecified
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: libksysguard
  Assignee: plasma-devel@kde.org
  Reporter: chirs241...@gmail.com
  Target Milestone: ---

Created attachment 113127
  --> https://bugs.kde.org/attachment.cgi?id=113127=edit
A screenshot of the dialog.

Possible duplicate: Bug 127728
This functionality could be useful for profiling and debugging.
The info shown in this dialog should be updated periodically.

I've submitted a diff for this:
https://phabricator.kde.org/D12827

A screenshot of the dialog is attached. Currently it only shows some
information from /proc/[pid]/stat and /proc/[pid]/status in the "Statistics"
tab (more can be added). The "Open Files" tab makes use of the unused lsofui
library in libksysguard.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D13390: Fonts KCM: Fix text readability regression

[Chris Holland]

Zren added a comment.


  Would the `TextField.readOnly` property be useful here?
  
  http://doc.qt.io/qt-5/qml-qtquick-controls-textfield.html#readOnly-prop
  
  F5894577: 2018-06-06___19-47-34.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13390

To: rkflx
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13390: Fonts KCM: Fix text readability regression

[Henrik Fehlauer]

rkflx created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
rkflx requested review of this revision.

REVISION SUMMARY
  Porting the Fonts KCM to QML in 24b960f92284 
 set 
the state of the font
  preview labels to `disabled`, resulting in a light gray text with too
  little contrast to enable a usable preview of the chosen font.
  
  In the `QWidgets` based KCM the following code was used:
  
QLabel::setFrameStyle(QFrame::StyledPanel | QFrame::Sunken)
  
  As that property is not available from QML, we reset the text colour to
  solve the problem. It's still not using the proper frame colour, though,
  but that does not seem like too much of an issue.
  
  Alternatively we could use a `Frame` and a `Label`, but this approach
  has even more problems, e.g. the frame does not respect the rounded
  border mandated by Breeze, and the horizontal alignment of each row
  would need to be adapted.

TEST PLAN
  Font previews for each category in `kcmshell5 kcm_fonts` should be
  readable again.
  
  Before: F5894425: fonts-kcm-before.png 
  After: F5894424: fonts-kcm-after.png 
  Ideal look (Plasma 5.12): F5894423: fonts-kcm-5.12.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts-kcm-readability (branched from Plasma/5.13)

REVISION DETAIL
  https://phabricator.kde.org/D13390

AFFECTED FILES
  kcms/fonts/package/contents/ui/FontWidget.qml

To: rkflx
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12851: Change preview text background color to match with default combobox background color

[Henrik Fehlauer]

rkflx added a comment.


  Anything left to be done here? I guess this should land on the `Plasma/5.13` 
branch, since it's still broken there (I almost wrote a patch…).
  
  Patch LGTM, but there's still an issue (but not sure if intentional or not): 
The hover effect does not apply to the preview image, it stays white instead of 
getting a blue background.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_comboboxes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12851

To: progwolff, mart, abetts, ngraham
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm added a comment.


  In D12857#274212 , @ngraham wrote:
  
  > Do you need someone to land this for you, Miklós?
  
  
  Yes, please.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12857

To: miklosm, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13367: Improve the clarity and presentation of the update details text field

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PackageKitResource.cpp:222
>  foreach(const QString& pkgid, pkgids) {
> -ret += i18nc("package-name (version)", "%1 (%2)", 
> PackageKit::Daemon::packageName(pkgid), 
> PackageKit::Daemon::packageVersion(pkgid));
> +ret += i18nc("package-name version", "%1", 
> PackageKit::Daemon::packageVersion(pkgid));
>  }

You don't need the `i18nc` at all anymore as you just forward the string 
verbatim

REPOSITORY
  R134 Discover Software Store

BRANCH
  clearer-update-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13367

To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13378: Handle when the added node itself is audio/video

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a5c049a1a6c6: Handle when the added node itself is 
audio/video (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13378?vs=35675=35678

REVISION DETAIL
  https://phabricator.kde.org/D13378

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13378: Handle when the added node itself is audio/video

[Fabian Vogt]

fvogt accepted this revision.
fvogt added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> content-script.js:367
>  var players = node.querySelectorAll("video,audio");
>  players.forEach(function (player) {
>  registerPlayer(player);

I only notice now how stupid this function call actually is...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13378

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13232: introduce Custom color set

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e3b72a04411f: introduce Custom color set (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13232?vs=35612=35676#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13232?vs=35612=35676

REVISION DETAIL
  https://phabricator.kde.org/D13232

AFFECTED FILES
  examples/gallerydata/contents/ui/gallery/ColorSetGallery.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/basictheme_p.h
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h
  src/styles/Material/Theme.qml

To: mart, #kirigami, broulik
Cc: plasma-devel, apol, davidedmundson, mart, hein

D13378: Handle when the added node itself is audio/video

[Kai Uwe Broulik]

broulik updated this revision to Diff 35675.
broulik added a comment.


  - Use same selector order as the existing code below

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13378?vs=35674=35675

REVISION DETAIL
  https://phabricator.kde.org/D13378

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13378: Handle when the added node itself is audio/video

[Kai Uwe Broulik]

broulik updated this revision to Diff 35674.
broulik added a comment.


  - Simplify

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13378?vs=35672=35674

REVISION DETAIL
  https://phabricator.kde.org/D13378

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13378: Handle when the added node itself is audio/video

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> content-script.js:356
> +// first check whether the node itself is audio/video
> +var tagName = node.tagName;
> +if (typeof tagName === "string") {

Use `node.matches("video,audio")` instead?

> content-script.js:365
> +// then check whether any of its children are
>  if (typeof node.querySelectorAll !== "function") {
>  return;

Skip the children check if it's a video/audio element.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13378

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13378: Handle when the added node itself is audio/video

[Fabian Vogt]

fvogt added a comment.


  I expected that querySelectorAll also looks at the element itself, apparently 
that's not the case...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13378

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13378: Handle when the added node itself is audio/video

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We were only looking at its children but we may also get an audio/video 
element added directly

TEST PLAN
  5.13 branch
  Fixes media controls on SoundCloud for me

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13378

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:20f7137145f6: Support Icon Scale from Icon naming 
specification 0.13 (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6313?vs=35318=35667#toc

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=35318=35667

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol