D13625: Add 'Documentation' category to the Application menus

[Yuri Chornoivan]

yurchor created this revision.
yurchor added a reviewer: Plasma: Workspaces.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  In the distributions with installable documentation (like Mageia), it is not 
possible to reach it from the Application Menu.
  
  All installed desktop files with "Categories=Documentation;" are not 
displayed in the menu unlike the other DEs (Xfce). It can be because of the 
lack of "kf5-documentation.directory" file in the /menu/desktop of 
plasma-workspace repo.
  
  BUG: https://bugs.kde.org/show_bug.cgi?id=395580

TEST PLAN
  In Mageia (6 or the current Cauldron) with installed Installer or MCC docs, 
copy kf5-documentation.directory into /usr/share/desktop-directories/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13625

AFFECTED FILES
  menu/desktop/CMakeLists.txt
  menu/desktop/kf5-documentation.directory

To: yurchor, #plasma_workspaces
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6f491642e9b9: [kded kcm] Fix estimating dbusModuleName of 
kded plugins (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13623?vs=36357=36362#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13623?vs=36357=36362

REVISION DETAIL
  https://phabricator.kde.org/D13623

AFFECTED FILES
  kcms/kded/kcmkded.cpp

To: kossebau, dfaure, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.13.1

[David Edmundson]

​Distros,

We're getting numerous reports of two major problems with 5.13.1
Please hold off on any roll outs. Will update when I have more info/fixes.

Sorry

David

D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: dfaure, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The entry X-KDE-DBus-ModuleName has never been used by kded code,
  at least is using it these days, so the check for that metadata entry
  and using its value is broken.
  
  Instead Kded::loadModule() used KPluginMetaData::pluginId() to set the
  module name, which then is used by KDEDModule for its D-Bus object path.
  
  The branch for handling an empty name is removed as that fallback is
  covered by KPluginMetaData already.

TEST PLAN
  KCM now lists all kded plugins, no longer complains about modules it could not
  relate.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixkdedkcmdbusmodulenames

REVISION DETAIL
  https://phabricator.kde.org/D13623

AFFECTED FILES
  kcms/kded/kcmkded.cpp

To: kossebau, dfaure, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Target: 5.12 LTS

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13623

To: kossebau, dfaure, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13596: Fix there being more security updates than total updates in notifier

[Chris Holland]

Zren added a comment.


  Thanks @apol for merging it. Thanks @ngraham for testing it and the link and 
@davidedmundson for explaining how bugfixes are merged.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13596

To: Zren, #discover_software_store, apol
Cc: davidedmundson, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13596: Fix there being more security updates than total updates in notifier

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:9577e7d1d333: Fix there being more security updates than 
total updates in notifier (authored by Zren).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13596?vs=36297=36355

REVISION DETAIL
  https://phabricator.kde.org/D13596

AFFECTED FILES
  notifier/DiscoverNotifier.cpp

To: Zren, #discover_software_store, apol
Cc: davidedmundson, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13619: Inject script on relevant video nodes not top of DOM

[David Edmundson]

davidedmundson added a comment.


  > Also, executeScript is used not only for this, is it?
  
  Seems to be.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13619

To: davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13618: Only add Media Sessions Shim if we find a valid video object

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in content-script.js:419
> Does `element.dataset.mediaSessionTransfer` work?

even if it did, you still have DOM manipulation on the executeScript function

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13618

To: davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D13360#280205 , @marten wrote:
  
  > Apologies for the unforeseen trouble.
  
  
  Happens also to the best now and then, and only to get better the next time :)
  
  > I'll revert the committed change for now, and then investigate the fix that 
@kossebau suggests in the previous comment.
  
  Given the commits seems that worked out? Good, so I did not misread the kded 
code.
  
  In the meantime I had tried to investigate where the X-KDE-DBus-ModuleName 
had been introduced in kdelibs/kde frameworks history and where/why it faded 
again, but so far have not found it being used at kded core at any time, only 
found traces in outer code spheres.
  
  So am going to create some patches to wipe out the last traces of that key 
from other  KDE code, everything I saw should work good enough using the plugin 
id, either derived from binary name or set by metadata (X-KDE-PluginInfo-Name 
with desktop file and KPlugin/Id with JSON). So in the future no-one can be 
confused by that non-working key anymore.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: cfeck, kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13619: Inject script on relevant video nodes not top of DOM

[Kai Uwe Broulik]

broulik added a comment.


  Media sessions doesn't necessarily need a player item, it's basically meant 
for when you don't have one. The website might remove the player item when it 
pauses when it's using media sessions API to do custom handling. Can't think of 
a better solution, though.
  
  Also, `executeScript` is used not only for this, is it?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13619

To: davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13618: Only add Media Sessions Shim if we find a valid video object

[Kai Uwe Broulik]

broulik added a comment.


  An idea how to avoid adding a DOM node altogether

INLINE COMMENTS

> content-script.js:419
> +var transferItem = 
> document.getElementById('${mediaSessionsTransferDivId}');
> +transferItem.innerText = JSON.stringify({action: action, 
> payload: payload});
> +

Does `element.dataset.mediaSessionTransfer` work?

> content-script.js:423
> +event.initEvent('payloadChanged', true, true);
> +transferItem.dispatchEvent(event);
> +};

Would it work to `dispatchEvent` on `document.documentElement` or 
`document.head`?

> content-script.js:484
> +// cannot access extensions from innocent page JS for security
> +var transferItem = document.createElement("div");
> +transferItem.setAttribute("id", mediaSessionsTransferDivId);

Can we use `document.documentElement` or `document.head` here

> content-script.js:491
> +transferItem.addEventListener('payloadChanged', function() {
> +var json = JSON.parse(this.innerText);
>  

And use the `dataset` from above here

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13618

To: davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13619: Inject script on relevant video nodes not top of DOM

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Turns out we're not the only script that messes with the top of the DOM,
  and because we're in a separate context, we're potentially doing it in
  parallel.
  
  This moves injection into the found video node

TEST PLAN
  Ran media sessions example

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13619

AFFECTED FILES
  extension/content-script.js

To: davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13618: Only add Media Sessions Shim if we find a valid video object

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  PBI has two modes for interacting with media + MPRIS, watching the DOM
  tree from it's own JS context for normal controls and a massive
  workaround for crossing contexts to shim the Media Sessions API for
  getting metadata. We currently inject this on every page.
  
  This patch moves that to only be when we find a valid audio/video
  element, reducing work and risk of breakages on most sites.

TEST PLAN
  Page that used to fail now works
  Still get thumbnails on media sessions test page

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13618

AFFECTED FILES
  extension/content-script.js

To: davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

[Christoph Feck]

cfeck added a comment.


  Regression has been reported as bug 395622. Please close when fixed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: cfeck, kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13617: Support kwin fractional scaling in wayland backend

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Note KScreen UI is deliberately not updated as full functionality is not
  complete. However, I think it's fine to merge this and have it exposed via
  only kscreen-doctor for devs.

TEST PLAN
  Used kscreen-doctor with modified kwin
  Kwin got float values

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13617

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: davidedmundson, #kwin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

[Jonathan Marten]

marten added a comment.


  Apologies for the unforeseen trouble.  I'll revert the committed change for 
now, and then investigate the fix that @kossebau suggests in the previous 
comment.  If this doesn't work then I'll look into splitting the kded and kcm 
modules into separate ones with a common library.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Given the D-Bus object path for the module is generated from the moduleid, 
which is set by kded using the KPluginMetaData::pluginId (in `KDEDModule 
*Kded::loadModule(const KPluginMetaData , bool onDemand)`, a fix might 
have been instead to set in the kded_touchpad.desktop file this entry: ` 
X-KDE-PluginInfo-Name=touchpad`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: plasma-devel to auto-discard non-subscribers?

[Aleix Pol]

On Tue, Jun 19, 2018 at 4:06 PM Harald Sitter  wrote:
>
> Heya
>
> I've been moderating the plasma-devel list for 6 months now, and in
> that time I've seen **one** legitimate pending email. Everything else
> was spam. At least one spam mail per day pretty much.
>
> I really do not think this list doesn't benefit from a moderation queue.
>
> There is just about no non-subscriber traffic, and even when there is
> I would expect a person sending a mail to a developer mailing list to
> be able to read the auto-discard notification email they'd get back
> and subscribe. So what's left is the useless chore of manually
> discarding spam email at the off chance that something useful pops up.
> We moderate daily at most (usually weekly really) because it's almost
> exclusively spam, the useful mail would unnecessarily get stuck in
> moderation for quite a while. Had the sender gotten an auto-discard
> notification they'd have been able to fix it on their own much faster.
>
> So, I propose that we change the list setting to auto-discard. It's
> better for everyone really.
>
> Thoughts?
>
> HS

I've been also moderating the list and I have the feeling that there's
been some legitimate traffic albeit not a lot.

In general, I think it's good that we can tell people to send an
e-mail to plasma-devel@kde.org and discuss things, if auto-discard was
the norm we're then unable to do that.

Aleix

D13612: Fix drop between shared views

[Robert Hoffmann]

hoffmannrobert created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Remove trailing slash from folderUrl, too, when comparing to
  the file's url (minus file name minus trailing slash). FolderUrls
  like file:///home/user/Desktop/ may appear and fail comparing.
  
  Fixes regression introduced in 07001277a8a0893aeb54240d7f5cdd9825fb57ed 

  (see https://phabricator.kde.org/D10729) which fixes urls like
  file:///home/user/foo (if using a different folder than Desktop)
  but breaks moving files from one screen to another using normal
  Desktop folder.

TEST PLAN
  1. Use folder view, Desktop folder, more than one screen.
  
  Create files and folders in Desktop folder and move them from one
  screen to another. The Copy/Move/Link menu must not appear
  and files/folders must be dropped onto the other screen.
  
  2. Use a different folder than Desktop (the same on both screens).
  
  Moving files/folders to another screen must work like in 1.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13612

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: hoffmannrobert
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13360: Touchpad KDED module: Convert to JSON metadata

[Friedrich W. H. Kossebau]

kossebau added a comment.


  This patch seems to have broken things ("kcm does not load") by what people 
reported in irc for 5.13.1.
  
  By a quick investigation the main reason is, that the old plugin binary with 
the name "kded_touchpad" is used both to provide the plugin for kcm as well as 
the plugin for the kded.
  See how both plugins had been registered for the TouchpadPluginFactory in the 
removed file plugins.cpp, with two plugin metadata desktop files referencing 
the very plugin "kded_touchpad" to find their repective plugin (the second via 
the "kcm" id): kcm_touchpad.desktop and kded_touchpad.desktop
  
  By turning the actual plugin into the new-style "embedded json in custom 
path" type plugin, the plugin metadata for the kcm plugin is now pointing into 
the void, as both the name is now wrong as well is the plugin no longer in the 
common plugin dir, but in a subdir (not sure if kcm plugins are searched also 
in subdirs).
  
  No idea where the actual bug this patch was supposed to fix is coming from, 
but it has broken things in a different way :)
  
  One solution might be to properly split the current single plugin binary into 
2 separate plugin binaries, one per kcm and one per kded plugin, and add a 
shared private lib for the stuff they might share.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13596: Fix there being more security updates than total updates in notifier

[Aleix Pol Gonzalez]

apol added a comment.


  You just commit it to Plasma/5.12 branch and it will get propagated when I 
merge 5.12 to 5.13 and master

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13596

To: Zren, #discover_software_store, apol
Cc: davidedmundson, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13596: Fix there being more security updates than total updates in notifier

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!
  Please land in 5.12.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13596

To: Zren, #discover_software_store, apol
Cc: davidedmundson, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13611: [Fonts KCM] disable "to" label when its companion controls are also disabled

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:27acf95acf61: [Fonts KCM] disable to label 
when its companion controls are also disabled (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13611?vs=36336=36338

REVISION DETAIL
  https://phabricator.kde.org/D13611

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: ngraham, #vdg, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:135
> What's the rationale of these two changes?

1. Reducing unnecessary string length: I didn't think "type" and "style" added 
anything.
2. Making the text work with all options. e.g. `Hinting style: none` seems kind 
of awkward ("none" isn't really a style)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: davidedmundson, Fuchs, abetts, nicolasfella, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

plasma-devel to auto-discard non-subscribers?

[Harald Sitter]

Heya

I've been moderating the plasma-devel list for 6 months now, and in
that time I've seen **one** legitimate pending email. Everything else
was spam. At least one spam mail per day pretty much.

I really do not think this list doesn't benefit from a moderation queue.

There is just about no non-subscriber traffic, and even when there is
I would expect a person sending a mail to a developer mailing list to
be able to read the auto-discard notification email they'd get back
and subscribe. So what's left is the useless chore of manually
discarding spam email at the off chance that something useful pops up.
We moderate daily at most (usually weekly really) because it's almost
exclusively spam, the useful mail would unnecessarily get stuck in
moderation for quite a while. Had the sender gotten an auto-discard
notification they'd have been able to fix it on their own much faster.

So, I propose that we change the list setting to auto-discard. It's
better for everyone really.

Thoughts?

HS

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:135
>  Layout.preferredWidth: formLayout.maxImplicitWidth
> -Kirigami.FormData.label: i18n("Sub-pixel rendering type:")
> +Kirigami.FormData.label: i18n("Sub-pixel rendering:")
>  currentIndex: kcm.fontAASettings.subPixelCurrentIndex

What's the rationale of these two changes?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: davidedmundson, Fuchs, abetts, nicolasfella, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13611: [Fonts KCM] disable "to" label when its companion controls are also disabled

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Title and screenshots say it all.

TEST PLAN
  Before:
  
  After:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13611

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: ngraham, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

[Christian]

Fuchs added a comment.


  In D13593#280112 , @ngraham wrote:
  
  > How about in a tooltip?
  
  
  whatever is search- and findable, I guess.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: Fuchs, abetts, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

[Nathaniel Graham]

ngraham added a comment.


  How about in a tooltip?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: Fuchs, abetts, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

[Christian]

Fuchs added a comment.


  Maybe add the technical term in brackets though, for those people who search 
for the technical term and don't find it otherwise?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: Fuchs, abetts, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13573: Touchpad KCM QtQuickControls2 Conversion

[Furkan Tokac]

furkantokac added a comment.


  In D13573#280026 , @ngraham wrote:
  
  > Looks good to me too.
  >
  > In D13573#279852 , @furkantokac 
wrote:
  >
  > > - Please review it. After your review, I'll also enable the Acceleration 
Profile with this patch by some editing.
  >
  >
  > That would be unrelated to this code cleanup. Please do that in another 
patch.
  
  
  So its okay no problem. Thanks for the feedback.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13573: Touchpad KCM QtQuickControls2 Conversion

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Looks good to me too.
  
  In D13573#279852 , @furkantokac 
wrote:
  
  > - Please review it. After your review, I'll also enable the Acceleration 
Profile with this patch by some editing.
  
  
  That would be unrelated to this code cleanup. Please do that in another patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Plasma 5.13.1

[Jonathan Riddell]

Plasma 5.13.1 sources are out now with a week's worth of bugfixes

https://www.kde.org/announcements/plasma-5.13.1.php

Plasma 5.14 Kickoff Schedule

[Jonathan Riddell]

Please say when you can do Plasma 5.14 kickoff meeting
https://doodle.com/poll/wqfei22vxm2aqb8a

Jonathan

D13602: Fix tooltip woes

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:24803dc9dc40: Fix tooltip woes (authored by hein).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13602?vs=36319=36321#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13602?vs=36319=36321

REVISION DETAIL
  https://phabricator.kde.org/D13602

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: hein, broulik, davidedmundson, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13602: Fix tooltip woes

[Eike Hein]

hein added a comment.


  In D13602#279963 , @davidedmundson 
wrote:
  
  > > race condition
  >
  > a race between what?
  
  
  To be honest, I didn't fully figure it out. But when the assignment in 
Tasks.qml was an integer to the delegate, it meant that the DelegateModel in 
the delegate sometimes started out with an undefined rootIndex and therefore 
bad data - almost as if the binding never got evaluated. Always assigning a 
freshly-made model index directly in the mouse event handler fixed it, and I 
prefer it style-wise anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13602

To: hein, broulik, davidedmundson, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13602: Fix tooltip woes

[David Edmundson]

davidedmundson added a comment.


  > race condition
  
  a race between what?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13602

To: hein, broulik, davidedmundson, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13602: Fix tooltip woes

[Eike Hein]

hein created this revision.
hein added reviewers: broulik, davidedmundson, romangg.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Users have reported a number of bugs against TM tooltips, e.g. initially
  coming up with crazy sizes, or showing window duplicates. This all comes
  down to a race conditions causing stale data and ugly code that's using
  visible props to swap between two alternate UI implementations instead
  of doing clean conditional loading.
  
  With this cleanup patch the problems should be gone, as well as various
  ReferenceErrors spewed onto the tty.
  
  BUG:382571
  BUG:385947
  BUG:389469
  BUG:388749

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13602

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: hein, broulik, davidedmundson, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Looking for KDE/Qt developers to participate in ELC EU Conference

[Paul Brown]

On martes, 19 de junio de 2018 12:28:47 (CEST) Paul Brown wrote:
> Hello,
> 
> This may not be relevant to a lot of you, but we have managed to become
> Community Partners of the Linux Foundation's ELC EU
> conference:
> 
> https://events.linuxfoundation.org/events/elce-2018/

Sorry, incorrect link. This is the correct one:

https://events.linuxfoundation.org/events/elc-openiot-europe-2018/

> 
> We are pushing to have a booth to show off mobile and embedded KDE
> technologies to a receptive crowd. Agustín is going and will be talking
> about KDE/Qt in Automotive and embedded. If you know Agustín, you will also
> know he can more than hold his own in this area
> 
> However, I think the mobile side of things would be under-represented. Aleix
> has submitted a talk, and, although he can also help out at the booth, it
> may be a good idea to try and boost KDE's mobile tech with this crowd and
> have some more developers deliver talks and show demos about other Kirigami
> (maybe Marco would be interested?), Halium, Plasma Mobile (Bhushan?), etc.
> 
> https://events.linuxfoundation.org/events/elc-openiot-europe-2018/program/
> cfp/?utm_source=lf_medium=blog_campaign=elceu18
> 
> This could help bring in new contributors from beyond our community and
> maybe attract sponsors from companies that usually attend these events.
> 
> Full disclosure: speakers get in free to the event, but procuring travel and
> accommodation is not mentioned, so I assume it will be on us.
> 
> We have a task up at https://phabricator.kde.org/T8170 if you would like to
> discuss things there. You are welcome to participate.
> 
> Cheers
> 
> Paul


-- 
Promotion & Communication

www: http://kde.org
Mastodon: https://mastodon.technology/@kde
Facebook: https://www.facebook.com/kde/
Twitter: https://twitter.com/kdecommunity



signature.asc
Description: This is a digitally signed message part.

D4667: [applet] Let specify a version for applets private plugins

[Anthony Fieroni]

anthonyfieroni abandoned this revision.
anthonyfieroni added a comment.


  Let's abandon it, i'll return to it, if still needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

To: anthonyfieroni, #plasma, davidedmundson, sitter, dfaure
Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 18 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/18/
 Project:
Plasma systemsettings stable-kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 10:14:10 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 94.35 KB...]JOB_NAME  = 'Plasma systemsettings stable-kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/18/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#18'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma systemsettings stable-kf5-qt5 SUSEQt5.10-18'NODE_LABELS   = 'Docker Swarm-bdd8f4c191db SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma systemsettings stable-kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.48.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.48.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.48.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.48.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.48.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.48.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.48.0") -- Found KF5WidgetsAddons: /home/jenkins/install-prefix/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.48.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.48.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.48.0") -- Found KF5DBusAddons: 

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/12/
 Project:
Plasma powerdevil stable-kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 10:14:06 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 92.34 KB...]HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-bda7c6b76b8b'HOST  = 'bda7c6b76b8b'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma powerdevil stable-kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/12/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#12'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma powerdevil stable-kf5-qt5 SUSEQt5.10-12'NODE_LABELS   = 'Docker Swarm-bda7c6b76b8b SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma powerdevil stable-kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.48.0") -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.48.0") -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.48.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.48.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.48.0") -- Found KF5Solid: /home/jenkins/install-prefix/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.48.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.48.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.48.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.48.0") -- Found KF5NotifyConfig: 

Looking for KDE/Qt developers to participate in ELC EU Conference

[Paul Brown]

Hello,

This may not be relevant to a lot of you, but we have managed to become 
Community Partners of the Linux Foundation's ELC EU 
conference:

https://events.linuxfoundation.org/events/elce-2018/

We are pushing to have a booth to show off mobile and embedded KDE 
technologies to a receptive crowd. Agustín is going and will be talking about 
KDE/Qt in Automotive and embedded. If you know Agustín, you will also know he 
can more than hold his own in this area

However, I think the mobile side of things would be under-represented. Aleix 
has submitted a talk, and, although he can also help out at the booth, it may 
be a good idea to try and boost KDE's mobile tech with this crowd and have 
some more developers deliver talks and show demos about other Kirigami (maybe 
Marco would be interested?), Halium, Plasma Mobile (Bhushan?), etc.

https://events.linuxfoundation.org/events/elc-openiot-europe-2018/program/
cfp/?utm_source=lf_medium=blog_campaign=elceu18

This could help bring in new contributors from beyond our community and maybe 
attract sponsors from companies that usually attend these events.

Full disclosure: speakers get in free to the event, but procuring travel and 
accommodation is not mentioned, so I assume it will be on us.

We have a task up at https://phabricator.kde.org/T8170 if you would like to 
discuss things there. You are welcome to participate.

Cheers

Paul
-- 
Promotion & Communication

www: http://kde.org
Mastodon: https://mastodon.technology/@kde
Facebook: https://www.facebook.com/kde/
Twitter: https://twitter.com/kdecommunity

signature.asc
Description: This is a digitally signed message part.

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/7/
 Project:
Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 10:12:22 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 91.41 KB...]BUILD_NUMBER  = '7'MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-98b9a772f9d7'HOST  = '98b9a772f9d7'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/7/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#7'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10-7'NODE_LABELS   = 'Docker Swarm-98b9a772f9d7 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.48.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.48.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.48.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.48.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.48.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.48.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.48.0") -- 

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/5/
 Project:
Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 10:12:22 +
 Build duration:
3 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 67.57 KB...]RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/5/display/redirect?page=changes'OLDPWD= '/usr/home/jenkins'EXECUTOR_NUMBER   = '0'HUDSON_HOME   = '/home/production/data'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect'STAGE_NAME= 'Configuring Build'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'JENKINS_URL   = 'https://build.kde.org/'WORKSPACE = '/usr/home/jenkins/workspace/Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/5/display/redirect'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'TERM  = 'su'NODE_NAME = 'FreeBSD Builder 2'SHELL = '/usr/local/bin/bash'LOGNAME   = 'jenkins'PWD   = '/usr/home/jenkins/workspace/Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'BUILD_TAG = 'jenkins-Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10-5'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'HUDSON_URL= 'https://build.kde.org/'LANG  = 'en_US.UTF-8'QT_SELECT = 'qt5'MAIL  = '/var/mail/jenkins'BLOCKSIZE = 'K'JOB_URL   = 'https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/'_ = '/usr/local/bin/java'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'BUILD_ID  = '5'JAVA_HOME = '/usr/local/openjdk8-jre'XDG_CURRENT_DESKTOP   = 'KDE'SHLVL = '1'USER  = 'jenkins'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.10'BUILD_DISPLAY_NAME= '#5'JOB_BASE_NAME = 'Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10'HOME  = '/home/jenkins'JOB_NAME  = 'Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.48.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.48.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.48.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.48.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.48.0") -- Found KF5KCMUtils: 

D4667: [applet] Let specify a version for applets private plugins

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  -1 from me until someone finds out what exactly is wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4667

To: anthonyfieroni, #plasma, davidedmundson, sitter, dfaure
Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13573: Touchpad KCM QtQuickControls2 Conversion

[Marco Martin]

mart accepted this revision as: mart.
mart added a comment.


  QML-wise looks ok for me now, still wait for Roman's accept as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13586: Ref KConfig whilst we're using it

[Wolfgang Bauer]

wbauer added a comment.


  In D13586#279538 , @fvogt wrote:
  
  > In D13586#279514 , @ngraham 
wrote:
  >
  > > Could this have any relationship to 
https://bugs.kde.org/show_bug.cgi?id=395401?
  >
  >
  > In theory yes, this is undefined behaviour and could cause everything 
between making a pixel slightly darker or crashing the harddrive.
  >
  > In practice I doubt it - this doesn't touch any of the code related to 
saving.
  
  
  But that bug is about the settings not being applied on login.
  Comment#0 says that the settings are in fact saved correctly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13586

To: davidedmundson, #plasma
Cc: wbauer, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13596: Fix there being more security updates than total updates in notifier

[David Edmundson]

davidedmundson added a comment.


  > Do I make a separate commit for 5.12, 5.13, and master?
  
  If possible, we commit to the oldest relevant branch then merge upwards.
  
  i.e 
  commit to 5.12
  merge 5.12 into 5.13
  merge 5.13 into master
  
  Otherwise git will treat them as different commits which makes some admin 
tasks, like seeing which branches contain a fix, harder.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13596

To: Zren, #discover_software_store, apol
Cc: davidedmundson, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D13573: Touchpad KCM QtQuickControls2 Conversion

[Furkan Tokac]

furkantokac updated this revision to Diff 36308.
furkantokac added a comment.


  V0.2
  Converted everything to qqc2. SizeHint is corrected. Tested.
  Please review it. After your review, I'll also enable the Acceleration 
Profile with this patch.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13573?vs=36236=36308

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13573

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml
  kcms/touchpad/src/kcm/libinput/components/ToolTip.qml
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/resources.qrc

To: furkantokac, romangg, ngraham, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13598: Do not restore windows on minimise change

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:70ecec7298e4: Do not restore windows on minimise change 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13598?vs=36303=36306#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13598?vs=36303=36306

REVISION DETAIL
  https://phabricator.kde.org/D13598

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

To: davidedmundson, #plasma, anthonyfieroni
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13529: [minimizeAll] Do not try to restore window state on model change

[David Edmundson]

davidedmundson added a comment.


  Sorry about taking over like that, just wanted to make sure your change got 
into 5.13.1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13529

To: anthonyfieroni, davidedmundson, #plasma
Cc: hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13599: Ref KConfig whilst we're using it

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ead2c3e859dc: Ref KConfig whilst were using it 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13599?vs=36304=36305

REVISION DETAIL
  https://phabricator.kde.org/D13599

AFFECTED FILES
  kcms/mouse/backends/x11/x11_backend.cpp

To: davidedmundson, #plasma, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13586: Ref KConfig whilst we're using it

[Fabian Vogt]

fvogt added a comment.


  > Your shared pointer still goes out of scope, the group's handle to the 
kconfig object is still the same.
  
  If I read the code correctly, the group keeps the shared pointer, which means 
it owns a reference.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13586

To: davidedmundson, #plasma
Cc: ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13586: Ref KConfig whilst we're using it

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  I failed to use arc. 
  See https://phabricator.kde.org/D13599

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13586

To: davidedmundson, #plasma
Cc: ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13599: Ref KConfig whilst we're using it

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In current code we would have a KConfigGroup with a dangling KConfig
  deleted after the RHS for the group fetch has finished.
  
  BUG: 394534

TEST PLAN
  Wrote minimal test case of code
  It produced a valgrind warning (weirdly didn't crash though)
  Modified to correct version
  No longer any warnings

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13599

AFFECTED FILES
  kcms/mouse/backends/x11/x11_backend.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13586: Ref KConfig whilst we're using it

[David Edmundson]

davidedmundson added a comment.


  > I guess KSharedConfig would work as well, that way the KConfig keeps a 
reference alive.
  
  I'm not convinced that
  
  auto group = KSharedConfig::openConfig().group() 
  would be any different.
  
  Your shared pointer still goes out of scope, the group's handle to the 
kconfig object is still the same.
  
  but I can change anyway

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13586

To: davidedmundson, #plasma
Cc: ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13598: Do not restore windows on minimise change

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  On window changing the old code would deactivate the minimise all
  plugin, but not restore the rest of the minised windows. This restores
  that behaviour.
  
  Also simplify tracking which active window changes, in a way that still
  works when a user clicks minimise all then interacts with the desktop.
  
  BUG: 395519
  
  Finishes D13529 

TEST PLAN
  Clicked minimise all
  Clicked desktop
  Clicked minimise all, windows restored
  
  Clicked minimise all
  Opened a window
  Only that window restored
  Clicking minimise all again minimised only that window

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13598

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart