D13686: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)

2018-06-22 Thread Michael Eden
michaeleden created this revision.
michaeleden added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
michaeleden requested review of this revision.

REVISION SUMMARY
  This change allows users to scroll through krunner output using their homerow.
  
  - Ctrl+j: Scroll Down
  - Ctrl+k: Scroll Up
  
  This makes scrolling easier for those familiar with this convention but 
doesn't
  inhibit users who aren't.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  feature/krunner-scroll-jk

REVISION DETAIL
  https://phabricator.kde.org/D13686

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: michaeleden, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13602: Fix tooltip woes

2018-06-22 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1e218b405bee: Fix tooltip woes (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13602?vs=36405=36537

REVISION DETAIL
  https://phabricator.kde.org/D13602

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: hein, broulik, davidedmundson, romangg
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13602: Fix tooltip woes

2018-06-22 Thread Rik Mills
rikmills added a comment.


  I have tested the modified patch on the same environment with Qt 5.10.1 where 
I found the crash with the previous version in 5.13.0 tars.
  
  plasmashell now seems to start without issue on login

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13602

To: hein, broulik, davidedmundson, romangg
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.10 - Build # 55 - Still unstable!

2018-06-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.10/55/
 Project:
Plasma discover stable-kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 22 Jun 2018 15:11:04 +
 Build duration:
1 hr 36 min and counting
   JUnit Tests
  Name: (root) Failed: 12 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.dummytestFailed: TestSuite.installFailed: TestSuite.knsbackendtestFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.updatedummytestFailed: TestSuite.wrongInput
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report47%
(8/17)26%
(25/95)26%
(25/95)20%
(896/4562)13%
(402/3064)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover73%
(8/11)73%
(8/11)50%
(321/646)31%
(119/386)discover.autotests100%
(1/1)100%
(1/1)100%
(92/92)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/67)0%
(0/40)libdiscover29%
(2/7)29%
(2/7)18%
(41/234)17%
(28/161)libdiscover.Category80%
(4/5)80%
(4/5)49%
(109/222)38%
(80/208)libdiscover.ReviewsBackend0%
(0/7)0%
(0/7)0%
(0/215)0%
(0/72)libdiscover.Transaction13%
(1/8)13%
(1/8)6%
(17/281)6%
(8/138)libdiscover.UpdateModel0%
(0/4)0%
(0/4)0%
(0/197)0%
(0/96)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/212)0%
(0/98)libdiscover.backends.DummyBackend0%
(0/10)0%
(0/10)0%
(0/288)0%
(0/154)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)9%
(24/255)4%
(10/260)libdiscover.backends.KNSBackend0%
(0/5)0%
(0/5)0%
(0/373)0%
(0/213)libdiscover.backends.KNSBackend.tests0%
(0/1)0%
(0/1)0%
(0/86)0%
(0/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/4)0%
(0/2)libdiscover.resources28%
(5/18)28%
(5/18)7%
(69/1015)2%
(16/744)libdiscover.tests100%
(2/2)100%
(2/2)83%
(223/269)46%
(106/232)notifier0%
  

D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> DesktopExampleApp.qml:29
>  
> -header: Kirigami.ToolBarApplicationHeader {}
> +   // header: Kirigami.ToolBarApplicationHeader {}
>  

Why is this commented?

> ExampleApp.qml:29
>  
> -header: Kirigami.ApplicationHeader {}
> +//header: Kirigami.ApplicationHeader {}
>  

why the comment?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami
Cc: apol, IlyaBizyaev, ngraham, davidedmundson, plasma-devel, mart, hein


D13678: Overhaul presentation of link buttons in the Reviews section

2018-06-22 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:5ee0a9c8c4cb: Overhaul presentation of link buttons in 
the Reviews section (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13678?vs=36517=36521

REVISION DETAIL
  https://phabricator.kde.org/D13678

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, #vdg, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13679: Fix recent toolbar layout regression

2018-06-22 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  D13663  fixed the issue, so let's use it 
and then bump the required Kirigami frameworks version
  
  BUG: 395455
  Depends on D13663 

TEST PLAN
  Fixes that regression, but seems to introduce a new one:
  F5932887: Unnecessary whitespace.png 
  
  Unclear whether this is a Discover issue or related to D13663 


REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-toolbar-layout-regression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13679

AFFECTED FILES
  CMakeLists.txt
  discover/qml/DiscoverWindow.qml

To: ngraham, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-06-22 Thread Nathaniel Graham
ngraham added a comment.


  In D13593#281594 , @mart wrote:
  
  > I'm ok with shortening the strings, i don't think anti alias is much more 
complicated than smoothing?
  
  
  "Anti-aliasing" is esoteric technical jargon; "Smoothing" is plain language. 
The point is to replace the former with the latter.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: mart, davidedmundson, Fuchs, abetts, nicolasfella, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol


D13672: Mouse KCM Pointer Speed Slider Improvement

2018-06-22 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  `BUG: 395681` can't be a link, I don't think. It's gotta just be plain old 
dumb text. :) Also, it seems that this is dependent on D13573 
. So please also add `Depends on D13573` to 
the Summary section somewhere. Then do `arc amend` locally. Thanks!
  
  And don't push until the dependent revision is landed, obviously.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

To: furkantokac, ngraham, romangg, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Nathaniel Graham
ngraham added a comment.


  Thanks, that seems to fix the bug!
  
  However, it also introduces another issue: there's now a bunch of whitespace 
on the left of the toolbar:
  
  F5932887: Unnecessary whitespace.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Marco Martin
mart added a comment.


  In D13663#281744 , @ngraham wrote:
  
  > Better now, thanks!
  >
  > What exactly do we have to do in Discover to make this patch fix 
https://bugs.kde.org/show_bug.cgi?id=395455?
  
  
  remove the line header: ToolBarApplicationHeader{} from the main file, that's 
it

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13678: Overhaul presentation of link buttons in the Reviews section

2018-06-22 Thread Nathaniel Graham
ngraham updated this revision to Diff 36517.
ngraham added a comment.


  Fix logic error

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13678?vs=36516=36517

BRANCH
  overhaul-review-section-prsentation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13678

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13678: Overhaul presentation of link buttons in the Reviews section

2018-06-22 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Discover Software Store, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Move the link buttons in the Reviews section around to improve their 
presentation. In the process, allow people to write reviews of installed apps 
without having to first open the review pop-up.

REPOSITORY
  R134 Discover Software Store

BRANCH
  overhaul-review-section-prsentation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13678

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Nathaniel Graham
ngraham resigned from this revision.
ngraham added a comment.


  Better now, thanks!
  
  What exactly do we have to do in Discover to make this patch fix 
https://bugs.kde.org/show_bug.cgi?id=395455?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13591: Set complete vectors instead of creting them at runtime

2018-06-22 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 36515.
tcanabrava edited the summary of this revision.
tcanabrava added a comment.


  - Don't realloc _pixmap vector
  - Don't use a Temporary to Copy data over
  - Fix compile
  - Don't use temporaries, compilers can optimize better this way

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13591?vs=36282=36515

BRANCH
  removeTemporaryReallocs

REVISION DETAIL
  https://phabricator.kde.org/D13591

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezesizegrip.cpp
  kstyle/breezehelper.cpp
  kstyle/breezeshadowhelper.cpp

To: tcanabrava, #breeze
Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13625: Add 'Documentation' category to the Application menus

2018-06-22 Thread Yuri Chornoivan
yurchor added a comment.


  In D13625#281596 , @mart wrote:
  
  > probably in this case the distro should put an entry in the menu offering 
to uninstall that package.. tough for that we have to rely on the distro
  
  
  Actually, the corresponding .desktop file is a part of the documentation 
package. It is enough to uninstall all those packages to get rid of the menu 
item as well.
  
  On the other hand, if someone wants to add their docs (links, desktop files, 
pdf documents) to this menu it is up to they to remove the manually added items 
from the menu.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13625

To: yurchor, #plasma_workspaces
Cc: hein, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Marco Martin
mart added a comment.


  F5932192: Spectacle.B20207.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami, ngraham
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13481: Recommend window border size "None"

2018-06-22 Thread Marco Martin
mart added a comment.


  the dead zone is actually a point.. tough that's a thing that a big company 
would have an actual usability testing lab for . To me is very probably 
something that doesn't get even noticed (i always had side borders disabled but 
now that i read here of the issue is the first time i notice it at all, even if 
knowing the implementation i must have known this had to happen, didn't help me 
to notice that it happened at all)
  As a big test, i don't see much way besides doing a (non lts) release with it 
and see how is received.. i would love to be able to have proper usability 
testing sessions.. but we don't have such a thing (maybe a tiny version of it 
could be set up at kde booths of non kde-only events we have a presence in

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13481

To: romangg, #plasma, #vdg
Cc: januz, ngraham, davidedmundson, graesslin, abetts, mart, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Marco Martin
mart updated this revision to Diff 36502.
mart marked 2 inline comments as done.
mart added a comment.


  - adress comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13663?vs=36472=36502

BRANCH
  arcpatch-D13663

REVISION DETAIL
  https://phabricator.kde.org/D13663

AFFECTED FILES
  examples/gallerydata/contents/ui/DesktopExampleApp.qml
  examples/gallerydata/contents/ui/ExampleApp.qml
  examples/gallerydata/contents/ui/gallery/LayersGallery.qml
  examples/simpleexamples/simpleChatApp.qml
  kirigami.qrc
  src/controls/AbstractApplicationHeader.qml
  src/controls/ApplicationWindow.qml
  src/controls/OverlayDrawer.qml
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/AbstractPageHeader.qml
  src/controls/private/PageRowGlobalToolBarStyleGroup.qml
  src/controls/private/PageRowGlobalToolBarUI.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/TitlesPageHeader.qml
  src/controls/private/ToolBarPageHeader.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ForwardButton.qml
  src/enums.h
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml
  src/styles/org.kde.desktop/OverlayDrawer.qml

To: mart, #kirigami, ngraham
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Marco Martin
mart added a comment.


  reproduced, adding here a comparison for recording prurposes
  before the patch: F5931512: Spectacle.W15291.png 

  after the patch: F5931526: Spectacle.M15738.png 

  
  so indeed size hints of actiontoolbuttons changed a bit (before were indeed a 
bit too much tough) will tweak

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami, ngraham
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


KDE CI: Plasma discover kf5-qt5 SUSEQt5.10 - Build # 39 - Still unstable!

2018-06-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.10/39/
 Project:
Plasma discover kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 22 Jun 2018 07:37:04 +
 Build duration:
1 hr 39 min and counting
   JUnit Tests
  Name: (root) Failed: 12 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.dummytestFailed: TestSuite.installFailed: TestSuite.knsbackendtestFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.updatedummytestFailed: TestSuite.wrongInput
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report47%
(8/17)26%
(25/95)26%
(25/95)20%
(896/4552)13%
(402/3060)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover73%
(8/11)73%
(8/11)50%
(321/646)31%
(119/386)discover.autotests100%
(1/1)100%
(1/1)100%
(92/92)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover29%
(2/7)29%
(2/7)18%
(41/234)17%
(28/161)libdiscover.Category80%
(4/5)80%
(4/5)49%
(109/222)38%
(80/208)libdiscover.ReviewsBackend0%
(0/7)0%
(0/7)0%
(0/215)0%
(0/72)libdiscover.Transaction13%
(1/8)13%
(1/8)6%
(17/281)6%
(8/138)libdiscover.UpdateModel0%
(0/4)0%
(0/4)0%
(0/197)0%
(0/96)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/212)0%
(0/98)libdiscover.backends.DummyBackend0%
(0/10)0%
(0/10)0%
(0/288)0%
(0/154)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)9%
(24/255)4%
(10/260)libdiscover.backends.KNSBackend0%
(0/5)0%
(0/5)0%
(0/365)0%
(0/209)libdiscover.backends.KNSBackend.tests0%
(0/1)0%
(0/1)0%
(0/86)0%
(0/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/4)0%
(0/2)libdiscover.resources28%
(5/18)28%
(5/18)7%
(69/1015)2%
(16/744)libdiscover.tests100%
(2/2)100%
(2/2)83%
(223/269)46%
(106/232)notifier0%

D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Marco Martin
mart added a comment.


  In D13663#281390 , @ngraham wrote:
  
  > I don't know if it was supposed to, but FWIW this does not fix 
https://bugs.kde.org/show_bug.cgi?id=395455.
  
  
  yes, it should fix that issue

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami, ngraham
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13663: Refactor the Global ToolBar concept

2018-06-22 Thread Marco Martin
mart added a comment.


  In D13663#281391 , @ngraham wrote:
  
  > Also, this regresses the Install button width in Discover, and other main 
action buttons, which you can see in your screen recording. They're now very 
narrow and don't have enough side padding.
  
  
  can you provide a screenshot?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13663

To: mart, #kirigami, ngraham
Cc: IlyaBizyaev, ngraham, davidedmundson, plasma-devel, apol, mart, hein


D13664: Fix leak of pipe FDs in MD RAID code

2018-06-22 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:d0287c1dea39: Fix leak of pipe FDs in MD RAID code 
(authored by fvogt).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13664?vs=36480=36497

REVISION DETAIL
  https://phabricator.kde.org/D13664

AFFECTED FILES
  ksysguardd/Linux/softraid.c

To: fvogt, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13625: Add 'Documentation' category to the Application menus

2018-06-22 Thread Marco Martin
mart added a comment.


  probably in this case the distro should put an entry in the menu offering to 
uninstall that package.. tough for that we have to rely on the distro

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13625

To: yurchor, #plasma_workspaces
Cc: hein, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-06-22 Thread Marco Martin
mart added a comment.


  I'm ok with shortening the strings, i don't think anti alias is much more 
complicated than smoothing?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: mart, davidedmundson, Fuchs, abetts, nicolasfella, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol


D13672: Mouse KCM Pointer Speed Slider Improvement

2018-06-22 Thread Furkan Tokac
furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13672

AFFECTED FILES
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart