D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them
broulik updated this revision to Diff 37173. broulik edited the test plan for this revision. broulik added a reviewer: davidedmundson. broulik added a comment. - Use `QPixmapCache` to cache on a per-icon basis and avoid duplicating the first 6 icons when all are loaded REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13793?vs=36882&id=37173 REVISION DETAIL https://phabricator.kde.org/D13793 AFFECTED FILES kcms/icons/main.cpp kcms/icons/main.h kcms/icons/package/contents/ui/main.qml To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D13853: Fix setting primary connector if primary output changed
hoffmannrobert updated this revision to Diff 37174. hoffmannrobert added a comment. - Remove wrong Q_ASSERT REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13853?vs=37072&id=37174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13853 AFFECTED FILES shell/screenpool.cpp To: hoffmannrobert, #plasma, mart, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Raising windows on Wayland
On Tue, Jul 3, 2018 at 7:45 PM, Martin Flöser wrote: > Am 2018-07-03 18:58, schrieb David Edmundson: > >> >>> >> Ideally this needs to be standardized so that it does not only work >>> with our applications but with any. >>> >> >> Even within just KDE apps, we have code like QDesktopServices spawning >> links in code we can't manipulate. Anything non standard, simply isn't >> worth merging. >> >> But I don't think standardising anything would be too hard. >> >> Effectively we want something like xdg-foreign which exists. The >> difference is that it lasts temporarily and it's not manipulating >> parents. >> > > xdg-foreign is pretty much the "token" idea :-) > > Cool, I think we're on the same page. I'll take it up. > >> There are two interesting questions: >> >> Do we want/need to support wayland window sending activating an >> xwayland window? >> > > short term: yes, long term: no. Ideally would be a mapping to the startup > notifications used on X11. > > >> Would we need a serial of the user event (xdg_popup style)? It would >> which kinda matches the X event timestamps? >> It's trickier as you'd need a protocol to generate a UUID for both >> that and the surface to sidechannel, but it's not impossible. >> > > I don't think that the serial is needed as the compositor would only pass > on focus if the app which generated the token has currently the focus. > Given that the serial does not provide any additional advantage. And I > don't like just using the serial as that could be guessed. > > Just to clarify a point. I didn't mean just using the serial as a token. If it was needed I meant clients would need to pass seat + serial as args along with the surface to our get_token_from_server request. but I also didn't think it was useful. > if the app which generated the token has currently the focus We might need to tweak that. kickoff will close and lose focus when you click on an app before that app is launched. This will probably be something up to the compositor, rather than something we need to worry about in the spec. --- X11 startup system is also used for notifying the UI, via taskbar or whatever else about the application starting up before it maps a surface. Is that something we want to bring in? (IMHO no) David
D13752: Build solidautoeject only on FreeBSD
broulik added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: anthonyfieroni, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D13879: Monitor document title
broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-browser-integration.git/commit/?id=49bd13222b1adfc2ca76699d153f5226269d963e REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D13879 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13883: Don't keep transfer div in DOM
This revision was automatically updated to reflect the committed changes. Closed by commit R856:114a1aa927b2: Don't keep transfer div in DOM (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13883?vs=37142&id=37189 REVISION DETAIL https://phabricator.kde.org/D13883 AFFECTED FILES extension/content-script.js To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13878: Also intercept creation of video elements
This revision was automatically updated to reflect the committed changes. Closed by commit R856:e77c0489cbcc: Also intercept creation of video elements (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13878?vs=37139&id=37191 REVISION DETAIL https://phabricator.kde.org/D13878 AFFECTED FILES extension/content-script.js To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Raising windows on Wayland
On 07/05/2018 07:19 PM, David Edmundson wrote: > X11 startup system is also used for notifying the UI, via taskbar or > whatever else about the application starting up before it maps a surface. It's definitely something we want to still have in the UI (we've broken it on X11 in the past and it's made users sad and file bugs). So even if it's out of scope for this particular protocol, eventually we want to have one. I think Gnome has a proprietary one. > David Cheers, Eike
D13903: doc: Fix actions description: the buttons are on the bottom
aspotashev created this revision. Restricted Application added projects: Plasma, Documentation. Restricted Application added subscribers: kde-doc-english, plasma-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R119 Plasma Desktop BRANCH doc-actions-on-bottom REVISION DETAIL https://phabricator.kde.org/D13903 AFFECTED FILES doc/kcontrol/autostart/index.docbook To: aspotashev Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Raising windows on Wayland
I started a thread on wayland-devel, lets do follow ups there. David
D13745: Implement support for virtual desktops on Wayland
hein updated this revision to Diff 37201. hein added a comment. - Adjust to Marco's API changes - builds again. - Add initial population loop to VirtualDesktopInfo on Marco's request. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=36903&id=37201 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13745 AFFECTED FILES libtaskmanager/abstracttasksmodel.cpp libtaskmanager/abstracttasksmodel.h libtaskmanager/abstracttasksmodeliface.h libtaskmanager/abstracttasksproxymodeliface.cpp libtaskmanager/abstracttasksproxymodeliface.h libtaskmanager/launchertasksmodel.cpp libtaskmanager/startuptasksmodel.cpp libtaskmanager/taskfilterproxymodel.cpp libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h libtaskmanager/virtualdesktopinfo.cpp libtaskmanager/virtualdesktopinfo.h libtaskmanager/waylandtasksmodel.cpp libtaskmanager/waylandtasksmodel.h libtaskmanager/windowtasksmodel.cpp libtaskmanager/windowtasksmodel.h libtaskmanager/xwindowtasksmodel.cpp libtaskmanager/xwindowtasksmodel.h To: hein, mart, mvourlakos Cc: zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13745: Implement support for virtual desktops on Wayland
hein updated this revision to Diff 37202. hein added a comment. - Revert a bit flip that wasn't intended to be in there just yet. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=37201&id=37202 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13745 AFFECTED FILES libtaskmanager/abstracttasksmodel.cpp libtaskmanager/abstracttasksmodel.h libtaskmanager/abstracttasksmodeliface.h libtaskmanager/abstracttasksproxymodeliface.cpp libtaskmanager/abstracttasksproxymodeliface.h libtaskmanager/launchertasksmodel.cpp libtaskmanager/startuptasksmodel.cpp libtaskmanager/taskfilterproxymodel.cpp libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h libtaskmanager/virtualdesktopinfo.cpp libtaskmanager/virtualdesktopinfo.h libtaskmanager/waylandtasksmodel.cpp libtaskmanager/waylandtasksmodel.h libtaskmanager/windowtasksmodel.cpp libtaskmanager/windowtasksmodel.h libtaskmanager/xwindowtasksmodel.cpp libtaskmanager/xwindowtasksmodel.h To: hein, mart, mvourlakos Cc: zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13745: Implement support for virtual desktops on Wayland
hein updated this revision to Diff 37203. hein added a comment. Add API for creating/removing desktops. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=37202&id=37203 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13745 AFFECTED FILES libtaskmanager/CMakeLists.txt libtaskmanager/abstracttasksmodel.cpp libtaskmanager/abstracttasksmodel.h libtaskmanager/abstracttasksmodeliface.h libtaskmanager/abstracttasksproxymodeliface.cpp libtaskmanager/abstracttasksproxymodeliface.h libtaskmanager/launchertasksmodel.cpp libtaskmanager/startuptasksmodel.cpp libtaskmanager/taskfilterproxymodel.cpp libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h libtaskmanager/virtualdesktopinfo.cpp libtaskmanager/virtualdesktopinfo.h libtaskmanager/waylandtasksmodel.cpp libtaskmanager/waylandtasksmodel.h libtaskmanager/windowtasksmodel.cpp libtaskmanager/windowtasksmodel.h libtaskmanager/xwindowtasksmodel.cpp libtaskmanager/xwindowtasksmodel.h To: hein, mart, mvourlakos Cc: zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support
hein updated this revision to Diff 37204. hein added a comment. - Enable Add/Remove Desktop actions on Wayland using new libtm API. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13748?vs=36727&id=37204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13748 AFFECTED FILES applets/pager/package/contents/ui/main.qml applets/pager/plugin/pagermodel.cpp applets/pager/plugin/pagermodel.h applets/pager/plugin/windowmodel.cpp To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13745: Implement support for virtual desktops on Wayland
hein updated this revision to Diff 37206. hein added a comment. - Add AbstractTasksModel::requestNewVirtualDesktop and implement for Wayland and X11. - Remove VirtualDesktopInfo::canManageDesktops again as there's parity now. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13745?vs=37203&id=37206 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13745 AFFECTED FILES libtaskmanager/CMakeLists.txt libtaskmanager/abstracttasksmodel.cpp libtaskmanager/abstracttasksmodel.h libtaskmanager/abstracttasksmodeliface.h libtaskmanager/abstracttasksproxymodeliface.cpp libtaskmanager/abstracttasksproxymodeliface.h libtaskmanager/launchertasksmodel.cpp libtaskmanager/startuptasksmodel.cpp libtaskmanager/taskfilterproxymodel.cpp libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h libtaskmanager/virtualdesktopinfo.cpp libtaskmanager/virtualdesktopinfo.h libtaskmanager/waylandtasksmodel.cpp libtaskmanager/waylandtasksmodel.h libtaskmanager/windowtasksmodel.cpp libtaskmanager/windowtasksmodel.h libtaskmanager/xwindowtasksmodel.cpp libtaskmanager/xwindowtasksmodel.h To: hein, mart, mvourlakos Cc: zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support
hein updated this revision to Diff 37207. hein edited the summary of this revision. hein added a comment. - Update message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13748?vs=37204&id=37207 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13748 AFFECTED FILES applets/pager/package/contents/ui/main.qml applets/pager/plugin/pagermodel.cpp applets/pager/plugin/pagermodel.h applets/pager/plugin/windowmodel.cpp To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support
hein updated this revision to Diff 37208. hein edited the summary of this revision. hein added a comment. Make "New Desktop" task context menu action work on Wayland. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13746?vs=36726&id=37208 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13746 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/code/tools.js To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13907: [SDDM Theme] Set sourceSize on background image
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I noticed that loading the background was a significant portion of sddm's startup time and found that we didn't set a `sourceSize` and just load a `3200x2000` image TEST PLAN Verified that the image isn't loaded multiple times due to changing sizes or property re-evaluation Had to change anchors to manual width as anchors seem to set geometry separately in a later step where the image already started loading, with explicit width/height Image waits until they're set, so we load the image only once Didn't really notice any impact on my machine but with 4K screen I would have loaded the full image anyway but might be noticeable on FHD or small laptops REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13907 AFFECTED FILES sddm-theme/Background.qml To: broulik, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
