Re: Hardware adaption of Plasma Mobile

2018-08-01 Thread Aleix Pol
On Wed, Aug 1, 2018 at 3:07 PM "Dr. Jörg Wurzer"  wrote:
>
> Dear developers,
>
> My company has selected Plasma Mobile as a candidate OS for a future smart 
> phone. For hardware sourcing we need to calculate the development effort in 
> hardware adaption and we need to ask potential vendors for the implementation 
> of hardware adaption. Is there a specification for Plasma Mobile?
>
> I’ve posted a message at the forum: 
> https://forum.kde.org/viewtopic.php?f=297=153327
>
> Kind regards
>
> Jörg Wurzer

Hey Jörg, happy to see this happen!

Plasma Mobile builds for most devices so far are using libhybris and
Halium (https://halium.org/) to integrate the hardware. There's other
approaches (like PostmarketOS or PureOS), but they're more involved.

I am not aware of Snapdragon support state, you can ask in the Plasma
Mobile telegram group, which is more active than the forums:
https://t.me/plasmamobile

Aleix


D14493: fontinst quits after KJob is done

2018-08-01 Thread Albert Astals Cid
aacid added a comment.


  you still need to merge 5.13 to master because eventually someone will, it's 
the trouble with cherry-picking.
  
  I'd suggest you use -x so it adds a line about it being a cherry-pick

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10362: Swap reveal password button logic

2018-08-01 Thread Chris Rizzitello
rizzitello added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  In D10362#202592 , 
@elvisangelaccio wrote:
  
  > Would it be possible to implement this feature like in the Windows 10 lock 
screen? (i.e. don't toggle the state; reveal the password only as long as the 
button is pressed). I feel like it would remove the security issue in the first 
place (as there isn't anymore a persistent state where the password can be 
visible).
  
  
  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, #frameworks


D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-01 Thread Eike Hein
hein added a comment.


  I just noticed my logic for the `DesktopRow` role is pretty borked, but out 
of time for today.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart
Cc: plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart


D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-01 Thread Eike Hein
hein added a comment.


  Screenshot:
  
  F6170928: Screenshot_20180802_035857.png 


REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart
Cc: plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart


D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-08-01 Thread Eike Hein
hein created this revision.
hein added a reviewer: mart.
Restricted Application added a project: KWin.
hein requested review of this revision.

REVISION SUMMARY
  This is a basic proof of concept KCM using Marco's DBus API from
  D13887 , as he requested as a form of 
review.
  
  The KCM currently installs alongside the old one with no
  file conflicts.
  
  The UI is based on ScrollViewKCM. I'll attach a screenshot
  seperately. It's OK-ish, I guess, although only the "Rows"
  spinbox correctly manages the "Apply" button; adding, removing
  and renaming desktops results in direct calls to the compositor.
  Renaming is done with an inline text field on the row delegate.
  
  More importantly, here's the problems I found:
  
  - The `desktopCreated` signal doesn't have an index parameter, which means I 
had to resort to appending new desktops I'm told about through the protocol, 
even though `createDesktop` takes a `position` parameter. The struct has an 
x11DesktopNumber, but I don't want to use that.
  - The `position` parameter in `createDesktop` seems to be handled incorrectly 
on the KWin side. I expected it to be zero-indexed, but I have to add one to 
append a new desktop.
  - To do the custom type demarshalling for the structs and vector of structs I 
copied the type definitions and the functions for now, but it would be good to 
put this stuff into a shared header considering it's the same repo.
  - The KCM for some reason catches Return presses and closes when anything in 
the Qt Quick view has focus. To do the inline editing using a TextField in the 
delegate, I had to implement `Keys.on(Return|Enter)Pressed` instead of using 
`onAccepted`.
  - A small spacing conundrum with the RowLayout in the footer I was too lazy 
to work out for now since this is a WIP UI anyway.

REPOSITORY
  R108 KWin

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/CMakeLists.txt
  kcmkwin/kwindesktopng/CMakeLists.txt
  kcmkwin/kwindesktopng/Messages.sh
  kcmkwin/kwindesktopng/desktopsmodel.cpp
  kcmkwin/kwindesktopng/desktopsmodel.h
  kcmkwin/kwindesktopng/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktopng/org.kde.kwin.virtualdesktopmanager.xml
  kcmkwin/kwindesktopng/package/contents/ui/main.qml
  kcmkwin/kwindesktopng/package/metadata.desktop
  kcmkwin/kwindesktopng/virtualdesktops.cpp
  kcmkwin/kwindesktopng/virtualdesktops.h

To: hein, mart
Cc: plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart


Fwd: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121 - Still Failing!

2018-08-01 Thread Ben Cooksley
Hi folks,

Looks like there has been a regression in libkscreen, as can be seen below.

Can someone please take a look?

Thanks,
Ben

-- Forwarded message --
From: CI System 
Date: Thu, Aug 2, 2018 at 1:00 AM
Subject: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121
- Still Failing!
To: bcooks...@kde.org


*BUILD FAILURE*
Build URL https://build.kde.org/job/Dependency%20Build%
20Extragear%20kf5-qt5%20SUSEQt5.9/121/
Project: Dependency Build Extragear kf5-qt5 SUSEQt5.9
Date of build: Wed, 01 Aug 2018 10:01:53 +
Build duration: 2 hr 58 min and counting
* CONSOLE OUTPUT *
[...truncated 62.14 MB...]
[ 37%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_QScreen.so
[ 37%] Built target KSC_QScreen
Scanning dependencies of target KSC_KWayland
[ 37%] Building CXX object backends/kwayland/CMakeFiles/KSC_KWayland.dir/
waylandbackend.cpp.o
[ 38%] Building CXX object backends/kwayland/CMakeFiles/KSC_KWayland.dir/
waylandconfig.cpp.o
[ 38%] Building CXX object backends/kwayland/CMakeFiles/KSC_KWayland.dir/
waylandoutput.cpp.o
[ 39%] Building CXX object backends/kwayland/CMakeFiles/KSC_KWayland.dir/
waylandscreen.cpp.o
[ 40%] Building CXX object backends/kwayland/CMakeFiles/
KSC_KWayland.dir/__/utils.cpp.o
[ 40%] Building CXX object backends/kwayland/CMakeFiles/
KSC_KWayland.dir/KSC_KWayland_autogen/mocs_compilation.cpp.o
[ 41%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_KWayland.so
[ 41%] Built target KSC_KWayland
Scanning dependencies of target KSC_XRandR
[ 42%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/xrandr.cpp.o
[ 42%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/xrandrconfig.cpp.o
[ 43%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/xrandrcrtc.cpp.o
[ 43%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/xrandroutput.cpp.o
[ 44%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/xrandrmode.cpp.o
[ 44%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/xrandrscreen.cpp.o
[ 45%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/__/xcbwrapper.cpp.o
[ 45%] Building CXX object backends/xrandr/CMakeFiles/KSC_XRandR.dir/__/
xcbeventlistener.cpp.o
[ 46%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/__/utils.cpp.o
[ 46%] Building CXX object backends/xrandr/CMakeFiles/
KSC_XRandR.dir/KSC_XRandR_autogen/mocs_compilation.cpp.o
[ 47%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_XRandR.so
[ 47%] Built target KSC_XRandR
Scanning dependencies of target KSC_XRandR11
[ 48%] Building CXX object backends/xrandr1.1/CMakeFiles/
KSC_XRandR11.dir/xrandr11.cpp.o
[ 48%] Building CXX object backends/xrandr1.1/CMakeFiles/
KSC_XRandR11.dir/__/xcbeventlistener.cpp.o
[ 49%] Building CXX object backends/xrandr1.1/CMakeFiles/
KSC_XRandR11.dir/__/xcbwrapper.cpp.o
[ 49%] Building CXX object backends/xrandr1.1/CMakeFiles/
KSC_XRandR11.dir/KSC_XRandR11_autogen/mocs_compilation.cpp.o
[ 50%] Linking CXX shared module ../../bin/kf5/kscreen/KSC_XRandR11.so
[ 50%] Built target KSC_XRandR11
[ 50%] Generating fakebackendinterface.cpp, fakebackendinterface.h
[ 51%] Generating fakebackendinterface.moc
Scanning dependencies of target testbackendloader
[ 52%] Building CXX object autotests/CMakeFiles/testbackendloader.dir/
testbackendloader.cpp.o
[ 52%] Building CXX object autotests/CMakeFiles/testbackendloader.dir/
fakebackendinterface.cpp.o
[ 53%] Building CXX object autotests/CMakeFiles/testbackendloader.dir/
testbackendloader_autogen/mocs_compilation.cpp.o
[ 53%] Linking CXX executable ../bin/testbackendloader
[ 53%] Built target testbackendloader
Scanning dependencies of target testscreenconfig
[ 54%] Building CXX object autotests/CMakeFiles/testscreenconfig.dir/
testscreenconfig.cpp.o
[ 55%] Building CXX object autotests/CMakeFiles/testscreenconfig.dir/
fakebackendinterface.cpp.o
[ 55%] Building CXX object autotests/CMakeFiles/testscreenconfig.dir/
testscreenconfig_autogen/mocs_compilation.cpp.o
[ 56%] Linking CXX executable ../bin/testscreenconfig
[ 57%] Built target testscreenconfig
Scanning dependencies of target testconfigserializer
[ 57%] Building CXX object autotests/CMakeFiles/testconfigserializer.dir/
testconfigserializer.cpp.o
[ 58%] Building CXX object autotests/CMakeFiles/testconfigserializer.dir/
fakebackendinterface.cpp.o
[ 58%] Building CXX object autotests/CMakeFiles/testconfigserializer.dir/
testconfigserializer_autogen/mocs_compilation.cpp.o
[ 59%] Linking CXX executable ../bin/testconfigserializer
[ 60%] Built target testconfigserializer
Scanning dependencies of target testconfigmonitor
[ 61%] Building CXX object autotests/CMakeFiles/testconfigmonitor.dir/
testconfigmonitor.cpp.o
[ 61%] Building CXX object autotests/CMakeFiles/testconfigmonitor.dir/
fakebackendinterface.cpp.o
[ 62%] Building CXX object autotests/CMakeFiles/testconfigmonitor.dir/
testconfigmonitor_autogen/mocs_compilation.cpp.o
[ 62%] Linking CXX executable ../bin/testconfigmonitor
[ 63%] 

Re: Akademy BOF Topics

2018-08-01 Thread Martin Flöser

Am 2018-08-01 17:01, schrieb David Edmundson:

We currently have a bunch of slots booked as general "Plasma".

We should split them up into relevant topics people actually want to
discuss so people know when to turn up to what.


In case there is something you want me to remote participate: I can 
remote join starting at 16:00 CEST, but I need to know before.


Cheers
Martin


Re: KDE Connect clipboard integration doesn't work on Wayland

2018-08-01 Thread Martin Flöser

Am 2018-08-01 17:43, schrieb Aleix Pol:

Hey,
One of the most useful features in KDE Connect is the clipboard
integration, this is not working currently. I'm guessing it's a
privileges issue, I was wondering if it would maybe be possible to fix
it by doing something like we're doing for fake input:


the reason why it's not working is the same for why klipper is not 
working: clipboard is not a shared medium anymore, but the compositor 
grants applications to write to the clipboard and to read from the 
clipboard. Both is strictly tied to having (keyboard) focus.


For kdeconnect this means it's not possible to write to the clipboard 
nor to read from the clipboard as it doesn't have a gui which could gain 
focus (obviously having a gui would not really be a solution here).


The ideas I had was to have a kind of clipboard manager which is always 
informed when clipboard content changes and is also allowed to write 
clipboard. I had a draft protocol, but I never got it to work properly 
for the klipper case as it tried to sync into both directions. But for 
the kdeconnect case the approach could work. Basically what we need is a 
protocol which allows to always set the data source and to get data 
offers. This would probably make sense to have in wayland-protocols as 
it's a rather generic problem (e.g. also virtual machines need this 
feature).


Cheers
Martin


KDE Connect clipboard integration doesn't work on Wayland

2018-08-01 Thread Aleix Pol
Hey,
One of the most useful features in KDE Connect is the clipboard
integration, this is not working currently. I'm guessing it's a
privileges issue, I was wondering if it would maybe be possible to fix
it by doing something like we're doing for fake input:

https://phabricator.kde.org/source/kdeconnect-kde/browse/master/plugins/mousepad/waylandremoteinput.cpp$36

Any ideas?
Aleix


Akademy BOF Topics

2018-08-01 Thread David Edmundson
We currently have a bunch of slots booked as general "Plasma".
We should split them up into relevant topics people actually want to
discuss so people know when to turn up to what.

Either post here or update the wiki directly.

David


D14535: [Desktop Toolbox] Emit contextualActionsAboutToShow before opening

2018-08-01 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3485b7d30efa: [Desktop Toolbox] Emit 
contextualActionsAboutToShow before opening (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14535?vs=38898=38904

REVISION DETAIL
  https://phabricator.kde.org/D14535

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


Hardware adaption of Plasma Mobile

2018-08-01 Thread Dr. Jörg Wurzer
Dear developers,

My company has selected Plasma Mobile as a candidate OS for a future smart 
phone. For hardware sourcing we need to calculate the development effort in 
hardware adaption and we need to ask potential vendors for the implementation 
of hardware adaption. Is there a specification for Plasma Mobile? 

I’ve posted a message at the forum: 
https://forum.kde.org/viewtopic.php?f=297=153327 


Kind regards

Jörg Wurzer

D14493: fontinst quits after KJob is done

2018-08-01 Thread Mathias Tillman
mathiastillman added a comment.


  Okay, so should I wait for someone else to reply before committing it to the 
5.12 and 5.13 branches?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D14207: Also monitor DOM node being removed for player gone

2018-08-01 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:09c729554ea1: Also monitor DOM node being removed for 
player gone (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14207?vs=38016=38899

REVISION DETAIL
  https://phabricator.kde.org/D14207

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14535: [Desktop Toolbox] Emit contextualActionsAboutToShow before opening

2018-08-01 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The toolbox shows containment-specific actions, just like the desktop 
contextmenu does.
  The containment may update or creates its actions on-demand leading to 
outdated actions showing up in the toolbox.
  
  BUG: 384862
  FIXED-IN: 5.12.7

TEST PLAN
  - Started plasma, opened toolbox, "Undo" was correctly disabled. Before it 
was enabled and clicking it would crash

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14535

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14534: Fix build on FreeBSD by including .

2018-08-01 Thread Tobias C. Berner
tcberner created this revision.
tcberner added reviewers: FreeBSD, mvourlakos.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  latte-dock-0.8.0/app/dock/dockview.h:367:44:
  
error: implicit instantiation of undefined template 
'std::__1::array'
std::array connectionsManagedLayout;
   ^

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14534

AFFECTED FILES
  app/dock/dockview.h

To: tcberner, #freebsd, mvourlakos
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14243: Fix bad model hygiene in Positioner::move()

2018-08-01 Thread Eike Hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1cb71a2cca8a: Fix bad model hygiene in Positioner::move() 
(authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14243?vs=38124=38895

REVISION DETAIL
  https://phabricator.kde.org/D14243

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14243: Fix bad model hygiene in Positioner::move()

2018-08-01 Thread Eike Hein
hein added a comment.


  I probably should at some point. Unfortunately it also got a lot more 
complicated with the addition of multi-screen support.
  
  But basically, it's a proxy in use when Folder View is used on the desktop 
and allows moving icons around. The view is a Grid View. The source model is a 
list. It maps from positions the user drops things to to rows in the source 
model. The proxy maps only concern themselves with positions that map to real 
entries in the source model. The sparse gaps inbetween icons are not part of 
the maps, they just return empty data and `true` for the special "IsBlank" data 
role. The delegate implementation in the view is behind a Loader that does 
nothing when IsBlank is true.
  
  Multiscreen works by further associating source rows with a screen and 
filtering in a screen-dependent way.
  
  There's some other things it needs to do, such as when a new file appears it 
needs to figure out the first free space and map it there, etc.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14243

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14243: Fix bad model hygiene in Positioner::move()

2018-08-01 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  In terms of the part that's changed, it does seem to do the same as before in 
a more correct way.
  
  In terms of the bigger picture, I am really struggling to follow what this 
class is doing. Can you please add some comments on the overall proxy structure.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14243

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14532: [Solid Device Engine] Don't update free space info for inaccessible storage devices

2018-08-01 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This might trigger automounting of devices.
  
  CCBUG: 355258

TEST PLAN
  5.13? 5.12?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14532

AFFECTED FILES
  dataengines/soliddevice/soliddeviceengine.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart