D14389: Invert shade button by same logic as keep-above button
andykluger added a comment. Is it worth considering to stop vertically flipping the shade icon? I don't care either way, as the visual cue that provides is too subtle for me to notice anyway. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14389 To: andykluger, #breeze, ngraham, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14389: Invert shade button by same logic as keep-above button
andykluger updated this revision to Diff 39228. andykluger added a comment. - Revert "flip keep-above icon when checked" REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14389?vs=38618&id=39228 BRANCH feature/shade-louder REVISION DETAIL https://phabricator.kde.org/D14389 AFFECTED FILES kdecoration/breezebutton.cpp To: andykluger, #breeze, ngraham, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
This revision was automatically updated to reflect the committed changes. Closed by commit R134:f804580adf56: Fwupd-Backend (Fixes) (authored by abhijeet2096). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14649?vs=39203&id=39209 REVISION DETAIL https://phabricator.kde.org/D14649 AFFECTED FILES libdiscover/backends/FwupdBackend/FwupdBackend.cpp libdiscover/backends/FwupdBackend/FwupdResource.h To: abhijeet2096, apol, davidedmundson Cc: ngraham, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14652: Port to KRun::runApplication
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0d50ff1d88d: Port to KRun::runApplication (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14652?vs=39199&id=39206 REVISION DETAIL https://phabricator.kde.org/D14652 AFFECTED FILES applets/kicker/plugin/appentry.cpp To: shubham, jgrulich, hein, abetts Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D12819: Fix the global drawer handle "click"
This revision was automatically updated to reflect the committed changes. Closed by commit R169:62ccb0ed7001: drawer: Display the content widget when dragging. (authored by lepagevalleeemmanuel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12819?vs=33974&id=39205#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12819?vs=33974&id=39205 REVISION DETAIL https://phabricator.kde.org/D12819 AFFECTED FILES src/controls/templates/OverlayDrawer.qml To: lepagevalleeemmanuel, davidedmundson, mart Cc: plasma-devel, apol, davidedmundson, mart, hein
D13054: SwipeItem: Fix using QRC resources and custom image providers.
This revision was automatically updated to reflect the committed changes. Closed by commit R169:db6ef33cfa9b: Allow qrc assets to be used in Actions icons (authored by lepagevalleeemmanuel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13054?vs=34689&id=39204#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13054?vs=34689&id=39204 REVISION DETAIL https://phabricator.kde.org/D13054 AFFECTED FILES src/controls/templates/SwipeListItem.qml src/desktopicon.cpp To: lepagevalleeemmanuel, mart Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein
D14649: Fwupd-Backend (Fixes)
abhijeet2096 added a comment. This diff only contains the changes and fixes related to the size of releases show. All the changes related to space and name are committed directly! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: ngraham, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
abhijeet2096 updated this revision to Diff 39203. abhijeet2096 edited the summary of this revision. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14649?vs=39202&id=39203 REVISION DETAIL https://phabricator.kde.org/D14649 AFFECTED FILES libdiscover/backends/FwupdBackend/FwupdBackend.cpp libdiscover/backends/FwupdBackend/FwupdResource.h To: abhijeet2096, apol, davidedmundson Cc: ngraham, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
abhijeet2096 updated this revision to Diff 39202. abhijeet2096 edited the summary of this revision. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14649?vs=39188&id=39202 REVISION DETAIL https://phabricator.kde.org/D14649 AFFECTED FILES cmake/FindLIBFWUPD.cmake libdiscover/backends/FwupdBackend/FwupdBackend.cpp libdiscover/backends/FwupdBackend/FwupdBackend.h libdiscover/backends/FwupdBackend/FwupdResource.cpp libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp libdiscover/backends/FwupdBackend/FwupdTransaction.cpp To: abhijeet2096, apol, davidedmundson Cc: ngraham, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14652: Port to KRun::runApplication
shubham created this revision. shubham added reviewers: jgrulich, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14652 AFFECTED FILES applets/kicker/plugin/appentry.cpp To: shubham, jgrulich, dfaure Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14651: [Notifications Engine] Guard "this"
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I can no longer reproduce the crash from bug 397105. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14651 To: broulik, #plasma, davidedmundson, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14651: [Notifications Engine] Guard "this"
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, jgrulich. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted. BUG: 397105 FIXED-IN: 5.12.7 TEST PLAN - `plasmawindowed org.kde.plasma.networkmanagement` no longer crashes on quit - Verified that `NotificationInhibiton` is still properly cleaned up when closing the popup in normal use (only after the GC kicks in, though) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14651 AFFECTED FILES dataengines/notifications/notificationsengine.cpp To: broulik, #plasma, davidedmundson, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
abhijeet2096 added inline comments. INLINE COMMENTS > apol wrote in FwupdBackend.h:84 > Not a big fan, please revert. If anything change `rel` to `release`. okay sure! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: ngraham, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
ngraham added inline comments. INLINE COMMENTS > abhijeet2096 wrote in FwupdBackend.h:84 > I was using "rel" for releases, so for uniformity, I changed the devices to > "dev". How about instead using "releases" for "releases?" :) Short variable names are a false economy. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: ngraham, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
apol added inline comments. INLINE COMMENTS > abhijeet2096 wrote in FwupdBackend.h:84 > I was using "rel" for releases, so for uniformity, I changed the devices to > "dev". Not a big fan, please revert. If anything change `rel` to `release`. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14562: Introduce Theme.smallestFont
volkov added inline comments. INLINE COMMENTS > mart wrote in kirigamiplugin.cpp:173 > this will break completely every import < 2.6 So, should it be registered for both versions 2.2 and 2.6? I tried to use revisions, but it looks like they don't work for properties of attached property objects: https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions One can import kirigami 2.2 and use smallestFont. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein
D14649: Fwupd-Backend (Fixes)
abhijeet2096 added a comment. sure INLINE COMMENTS > apol wrote in FwupdBackend.h:84 > Why did you change all `device` to `dev`? I was using "rel" for releases, so for uniformity, I changed the devices to "dev". REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
apol added a comment. Reviewing the patch with such menial styling changes becomes to hard, please clean up first. The spaces change is indeed correct, maybe just commit that part first, for easier review. INLINE COMMENTS > FwupdBackend.h:84 > const QUrl cacheFile(const QString &kind, const QFileInfo &resource); > -FwupdResource * createDevice(FwupdDevice *device); > -FwupdResource * createRelease(FwupdDevice *device); > -FwupdResource * createApp(FwupdDevice *device); > +FwupdResource * createDevice(FwupdDevice *dev); > +FwupdResource * createRelease(FwupdDevice *dev); Why did you change all `device` to `dev`? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 To: abhijeet2096, apol, davidedmundson Cc: plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14649: Fwupd-Backend (Fixes)
abhijeet2096 created this revision. abhijeet2096 added reviewers: apol, davidedmundson. abhijeet2096 added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. abhijeet2096 requested review of this revision. REVISION SUMMARY This Patch brings the following fixes: - Now It shows proper release data. - Now showing proper size. - Brings uniform variable name and spaces between function. - Changed License in findLIBFWUPD.cmake as per discussion here (https://phabricator.kde.org/T9305) - added a default icon for updates (device-notifier) - fixes some end-case REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14649 AFFECTED FILES cmake/FindLIBFWUPD.cmake libdiscover/backends/FwupdBackend/FwupdBackend.cpp libdiscover/backends/FwupdBackend/FwupdBackend.h libdiscover/backends/FwupdBackend/FwupdResource.h libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp libdiscover/backends/FwupdBackend/FwupdTransaction.cpp To: abhijeet2096, apol, davidedmundson Cc: plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14546: [Service Runner] Look up relative entryPaths
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf7381d7fbff: [Service Runner] Look up relative entryPaths (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14546?vs=38930&id=39185#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14546?vs=38930&id=39185 REVISION DETAIL https://phabricator.kde.org/D14546 AFFECTED FILES runners/services/servicerunner.cpp To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14647: Resolve relative service entry paths
broulik created this revision. broulik added reviewers: Plasma, dfaure, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For KCMs we get a relative `entryPath()` for our `KService` resulting in an invalid URL being created. BUG: 397070 TEST PLAN 5.12? The `QUrl` returned from that could be invalid now (empty), not sure if that could cause any problems elsewhere? - Searched for "Colors", got Color KCM, successfully added it to favorites, to TM and panel (icon widget). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14647 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/kicker/plugin/actionlist.h applets/kicker/plugin/appentry.cpp applets/kicker/plugin/runnermatchesmodel.cpp To: broulik, #plasma, dfaure, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Monday meeting notes for 6/8/2018
David: * Kwin scripting is all up for review * have a patch for scripted effects not being able to claim activeFullScreenEffect which will fix some bugs * at some point we have the other kwin scripting API to port: the one executed from the scripting console is still to be ported * Then I spent some time trying to see if I could fix some of the quirks I had to workaround in Qt Kai Uwe: Work done: - Various plasma-browser-integration fixes - Crashfix in Folder View caused by calling "undo" unconditionally - Fix for GTK global menu with newer GTK and GTK 4 - Crashfix in Desktop scripting engine - Tried to fix blurry/scaled pixmaps in ksysguard (process monitor) - Investigated why KService::entryPath() is relative for some services -- is "by design", needs adjustment in various places where it's used (Task Manager, Kickoff/Kicker) Work todo: - Postponed libnotificationmanager work to Akademy, so I can figure out the model situation in-person with Sho_ - Will merge libcanberra support for KNotifications once Frameworks 5.49 final was tagged Please review: - D14545 Not sure about the ABI implications there - D14532 Supposedly fixes causing unwanted auto-mounting - D14488 - D14487 Roman: * continued work on Xwayland dnd. can now copy/paste Xwayland <-> Wayland native and dnd from Wayland native to Xwayland. * What's left to do is dnd from Xwayland to Wayland native. * current code is there: https://cgit.kde.org/clones/kwin/romangilg/kwin.git/log/?h=xwlSelsDndAddDnd aim to have both ends working before akademy Eike(not at the meeting): * Wrote the new VD KCM PoC and iterated * looked into the LO6 problem with TM Marco: * short week, only thursday and friday --- Kirigami * fixed behavior of buttons in InlineMessage, properly hiding now * fixed automatic padding update when the scrollbar appears/disappears * fixed dinamic enabling/disabling of the top banner * added actionsvisible property in SwipeListItem: hides all the action icons when needed (for instance in edit mode) --- Systemsettings * continued on multi level KCMS: D14579 D14580 D14581
D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:79ac08108966: [Desktop Scripting ConfigGroup] Add more nullptr checks (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14576?vs=39004&id=39171 REVISION DETAIL https://phabricator.kde.org/D14576 AFFECTED FILES shell/scripting/configgroup.cpp To: broulik, #plasma Cc: davidedmundson, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14562: Introduce Theme.smallestFont
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. good idea, 2 comments: - the import version of platformtheme cannot change or will break existing code - needs a smallestfont declared also in all version of qml-base theme implementations, one in controls, one is in the kirigami repo, under controls, one is in the plasma-framework repo, under src/declarativeimports/kirigamiplasmastyle/ INLINE COMMENTS > kirigamiplugin.cpp:173 > > +//2.6 > +qmlRegisterUncreatableType(uri, 2, 6, "Theme", > "Cannot create objects of type Theme, use it as an attached poperty"); this will break completely every import < 2.6 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein
