D15011: [Kickoff] Make the search field always look like a search field

[Andres Betts]

abetts added a comment.


  I like this idea

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15011: [Kickoff] Make the search field always look like a search field

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Heh, flip-flopped back to 
https://userbase.kde.org/images.userbase/thumb/f/fe/Kickoff_Menu_Style.png/300px-Kickoff_Menu_Style.png
 till we get the next bug report about how it should be hidden.

INLINE COMMENTS

> Header.qml:66
> +opacity: 0
> +y: -1
> +}

What's this about? Negative offsets are weird, and we also have a 300ms 
animation to move 1px?

> Header.qml:144
>  left: faceIcon.right
> -top: faceIcon.top
> -right: parent.right
> +bottom: queryField.top
>  leftMargin: units.gridUnit

and here

> Header.qml:153
> +level: 5
> +font.letterSpacing: -0.4
> +opacity: 0

We can't do this. You're assuming lots of things about the user's font that you 
can't do.

> Header.qml:164
>  anchors {
> -left: nameLabel.left
> -top: nameLabel.bottom
> -right: nameLabel.right
> +left: faceIcon.right
> +bottom: queryField.top

This will no longer elide as the right is not constrained.

If you have a long username this will just overflow out the box.

When dealing with text items, it's easier to think in terms of bounding box 
rather than where the text itself.

Include the rightMargin back too.

> Header.qml:211
> +// Implement our own clear button because the PC3 version doesn't 
> have one
> +// (https://bugs.kde.org/show_bug.cgi?id=396828)
> +// FIXME: Replace this Row and everything in it with 
> "clearButtonShown: true"

No working round Plasma code in Plasma.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

[Michael Pyne]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b23e642e5ac4: Explicitly request Qt 5.7s QtQuick to 
make use of Connections.enabled (authored by mpyne).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14984?vs=40179=40265

REVISION DETAIL
  https://phabricator.kde.org/D14984

AFFECTED FILES
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/private/ScrollView.qml

To: mpyne, #frameworks, #plasma, mart, davidedmundson
Cc: plasma-devel, apol, davidedmundson, mart, hein

D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch makes Kickoff's search field always look like a search field, 
instead of on;y after you start typing.
  
  BUG: 397581
  FIXED-IN: 5.14.0

TEST PLAN
  [stuff goes here]

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-search-field-looks-like-a-search-field (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15011

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15008: Don't depend on the exact version of Breeze

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:893175d8c38b: Dont depend on the exact version of 
Breeze (authored by fvogt).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15008?vs=40259=40260

REVISION DETAIL
  https://phabricator.kde.org/D15008

AFFECTED FILES
  CMakeLists.txt

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15008: Don't depend on the exact version of Breeze

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  This makes it easier to build on dev systems and for backports.

TEST PLAN
  Built master with Breeze 5.13.4 installed - works fine.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15008

AFFECTED FILES
  CMakeLists.txt

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14830: Add "Configure Displays" context menu entry on the desktop

[Nathaniel Graham]

ngraham added a comment.


  In D14830#313645 , @davidedmundson 
wrote:
  
  > I am still waiting for a single justification.
  
  
  I think some were provided in the description:
  
  > One of LiMux client's requirements is for display configuration to be 
easily accessible. Adding a "Configure Displays..." context menu entry which is 
widely known by being present on another operating system aids in users finding 
those settings.
  
  
  
  > It also gets asked for occasionally by users on the internet.
  
  IMHO, "a major institutional user wants it" is a pretty fair justification 
all by itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson
Cc: mart, davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14830: Add "Configure Displays" context menu entry on the desktop

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I am still waiting for a single justification.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson
Cc: mart, davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14830: Add "Configure Displays" context menu entry on the desktop

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: mart, davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14855: Add applet with screen layouts and presentation mode

[Andres Betts]

abetts added a comment.


  Love! Love! <3
  
  Thanks for working on it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14855: Add applet with screen layouts and presentation mode

[Nathaniel Graham]

ngraham added a comment.


  +1 on the UI now.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14855: Add applet with screen layouts and presentation mode

[Kai Uwe Broulik]

broulik updated this revision to Diff 40245.
broulik edited the test plan for this revision.
broulik added a comment.


  - Fixup wording
  - Improve layout of Presentation Mode checkbox

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14855?vs=40088=40245

REVISION DETAIL
  https://phabricator.kde.org/D14855

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml
  kded/osdaction.cpp
  kded/osdaction.h
  kded/osdmanager.cpp
  kded/osdmanager.h
  kded/qml/OsdSelector.qml
  plasmoid/CMakeLists.txt
  plasmoid/Messages.sh
  plasmoid/kscreenapplet.cpp
  plasmoid/kscreenapplet.h
  plasmoid/package/contents/ui/PresentationModeItem.qml
  plasmoid/package/contents/ui/ScreenLayoutSelection.qml
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/metadata.desktop
  tests/osd/CMakeLists.txt

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

KDE CI: Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10 - Build # 14 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20stable-kf5-qt5%20FreeBSDQt5.10/14/
 Project:
Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 22 Aug 2018 14:38:13 +
 Build duration:
26 sec and counting
   CONSOLE OUTPUT
  [...truncated 15.33 KB...] > git checkout -f b3bc63f76f7243189022b6298b1a141ddd00bf4aCommit message: "Move KDevelop over as well now"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 17d016c4ae73ba87817b282b4257944f8ce38630 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 17d016c4ae73ba87817b282b4257944f8ce38630Commit message: "mark the plasma-angelfish as the active repository"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 08c8604fc862b40ade3a9f45522bc2ba9e468397 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 08c8604fc862b40ade3a9f45522bc2ba9e468397Commit message: "Set stable branch of KDevelop + plugins to 5.3"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-integration --branchGroup stable-kf5-qt5 --environment production --platform FreeBSDQt5.10 --installTo /home/jenkins/install-prefix/Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5Retrieving: Plasma-karchive-stable-kf5-qt5Retrieving: Plasma-ki18n-stable-kf5-qt5Retrieving: Plasma-kcoreaddons-stable-kf5-qt5Retrieving: Plasma-kwindowsystem-stable-kf5-qt5Retrieving: Plasma-kconfig-stable-kf5-qt5Retrieving: Plasma-kcrash-stable-kf5-qt5Retrieving: Plasma-kdbusaddons-stable-kf5-qt5Retrieving: Plasma-kdoctools-stable-kf5-qt5Retrieving: Plasma-kservice-stable-kf5-qt5Retrieving: Plasma-kcodecs-stable-kf5-qt5Retrieving: Plasma-phonon-stable-kf5-qt5Retrieving: Plasma-kauth-stable-kf5-qt5Retrieving: Plasma-kguiaddons-stable-kf5-qt5Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5Retrieving: Plasma-kitemviews-stable-kf5-qt5Retrieving: Plasma-kcompletion-stable-kf5-qt5Retrieving: Plasma-kiconthemes-stable-kf5-qt5Retrieving: Plasma-sonnet-stable-kf5-qt5Retrieving: Plasma-attica-stable-kf5-qt5Retrieving: Plasma-kglobalaccel-stable-kf5-qt5Retrieving: Plasma-ktextwidgets-stable-kf5-qt5Retrieving: Plasma-breeze-icons-stable-kf5-qt5Retrieving: Plasma-knotifications-stable-kf5-qt5Retrieving: Plasma-kxmlgui-stable-kf5-qt5Retrieving: Plasma-solid-stable-kf5-qt5Retrieving: Plasma-kjobwidgets-stable-kf5-qt5Retrieving: Plasma-kbookmarks-stable-kf5-qt5Retrieving: Plasma-kwallet-stable-kf5-qt5Retrieving: Plasma-kio-stable-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 82, in filename, metadata = packageArchive.retrievePackage( package )  File "/usr/home/jenkins/workspace/Plasma plasma-integration stable-kf5-qt5 FreeBSDQt5.10/ci-tooling/helpers/helperslib/Packages.py", line 115, in retrievePackagelatestContent.write( 

D14950: Add screen to the keyword of kscreen KCM

[Vlad Zagorodniy]

zzag added a comment.


  Why only "refresh"?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14950

To: davidedmundson, #plasma, ngraham, gladhorn
Cc: gladhorn, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14950: Add screen to the keyword of kscreen KCM

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:24f041478771: Add screen to the keyword of kscreen KCM 
(authored by davidedmundson).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14950?vs=40066=40229

REVISION DETAIL
  https://phabricator.kde.org/D14950

AFFECTED FILES
  kcm/kcm_kscreen.desktop.cmake

To: davidedmundson, #plasma, ngraham, gladhorn
Cc: gladhorn, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14806: [AppStream Runner] Reduce verbosity of log output

[Stefan Brüns]

bruns requested review of this revision.
bruns added a comment.


  Why should I squash the commits? Each one:
  
  - compiles **and** works on its own
  - addresses a slightly different issue
  
  Citing from 
https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets
  
  > OTOH, commits should be preferably "atomic" - not splittable. That means 
that every bugfix, feature, refactoring or reformatting should go into an own 
commit. This, too, improves the readability of the history.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14822: Use QJSValue as method parameter type for the scripting interface

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6e5c9e9b1666: Use QJSValue as method parameter type for 
the scripting interface (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14822?vs=39676=40220

REVISION DETAIL
  https://phabricator.kde.org/D14822

AFFECTED FILES
  shell/scripting/applet.cpp
  shell/scripting/applet.h
  shell/scripting/configgroup.cpp
  shell/scripting/configgroup.h
  shell/scripting/scriptengine_v1.cpp

To: fvogt, #plasma, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D14822: Use QJSValue as method parameter type for the scripting interface

[Fabian Vogt]

fvogt added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: mart, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D14999: [PanelShadows] Use 0 offset for disabled borders on Wayland

[Vlad Zagorodniy]

zzag created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  On Wayland, if some border is disabled, we don't attach corresponding
  empty tile. Yet, we set offset of 1 for that border.
  
  KWin relies on offset values to calculate bounding box for shadows.
  
  For example, if a panel has only top border enabled, then the bounding
  box will be 2 pixel wider(and 1px taller) than it should be. This can
  result in having 1px artefacts on neighboring screens.
  
  In general, we don't have to attach empty tiles for disabled borders.
  Thus, we can set corresponding offsets to 0.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wayland-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14999

AFFECTED FILES
  shell/panelshadows.cpp

To: zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14976: Less aggessive monochroming of icons

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e8a611b3eaf5: Less aggessive monochroming of icons 
(authored by mart).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14976?vs=40159=40209

REVISION DETAIL
  https://phabricator.kde.org/D14976

AFFECTED FILES
  src/controls/BasicListItem.qml
  src/desktopicon.cpp
  src/libkirigami/platformtheme.h

To: mart, #kirigami, vkrause
Cc: plasma-devel, apol, davidedmundson, mart, hein

D14976: Less aggessive monochroming of icons

[Volker Krause]

vkrause added a comment.


  Thanks! This looks like it should fix my problem with the breeze weather 
icons on Android :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14976

To: mart, #kirigami, vkrause
Cc: plasma-devel, apol, davidedmundson, mart, hein

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  You would need to read `kwinrc` manually, I suppose. 
  I don't use virtual desktops, so I cannot comment, but I don't think three 
separate options is worthwhile.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14988

To: phuongn, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  Shouldn't this just follow KWin's "screens wrap around" policy?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14988

To: phuongn, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

[Phuong Nguyen]

phuongn created this revision.
phuongn added a reviewer: Plasma.
phuongn added a project: Plasma.
Herald added a subscriber: plasma-devel.
phuongn requested review of this revision.

REVISION SUMMARY
  BUG: 361672
  
  This patch implement an option to disable navigation wraps around for the 
switch desktop mouse action, which potentially cause inconveniences for user 
who switch desktop using mouse wheel or touchpad scroll on the desktop.
  
  The patch is implemented since "Desktop navigation wraps around" option in 
"System Settings -> Desktop Behavior -> Virtual Desktops -> Switching" only 
affects keyboard shortcut mapping.
  
  F6209090: Screenshot_20180822_111020.png 

  
  F6209091: Screenshot_20180822_111204.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14989

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/config.ui
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h
  
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop

To: phuongn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

[Phuong Nguyen]

phuongn created this revision.
phuongn added a project: Plasma.
Herald added a subscriber: plasma-devel.
phuongn requested review of this revision.

REVISION SUMMARY
  BUG: 361672
  
  This patch implement an option to disable navigation wraps around for the 
pager plasmoid, which potentially cause inconveniences for user who switch 
desktop using mouse wheel or touchpad scroll.
  
  The patch is implemented since "Desktop navigation wraps around" option in 
"System Settings -> Desktop Behavior -> Virtual Desktops -> Switching" only 
affects keyboard shortcut mapping.
  
  F6209076: Screenshot_20180822_105425.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14988

AFFECTED FILES
  applets/pager/package/contents/config/main.xml
  applets/pager/package/contents/ui/configGeneral.qml
  applets/pager/package/contents/ui/main.qml

To: phuongn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart