D15331: [Folder View] Hide /home/foo/Desktop place in configuration

2018-09-07 Thread Kai Uwe Broulik 
broulik added a comment.


  It's just a `QSortFilterProxyModel` so not sure we can "delay" the filtering?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15331

To: broulik, #plasma, hein, fvogt
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

2018-09-07 Thread James Smith 
smithjd created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
smithjd requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master-krunnerkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15341

AFFECTED FILES
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

2018-09-07 Thread James Smith 
smithjd updated this revision to Diff 41182.
smithjd added a comment.


  - [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14739?vs=39467=41182

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/view.cpp
  krunner/view.h
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15306: BookmarksRunner: Avoid multiple connections of identical signal

2018-09-07 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cb6805374d12: BookmarksRunner: Avoid multiple connections 
of identical signal (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15306?vs=41125=41180

REVISION DETAIL
  https://phabricator.kde.org/D15306

AFFECTED FILES
  runners/bookmarks/bookmarksrunner.cpp

To: bruns, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

2018-09-07 Thread Eike Hein 
hein added a comment.


  Is it worth adding QQmlParserStatus to PlacesModel at this point?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15331

To: broulik, #plasma, hein, fvogt
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15333: Group Widget + Color Picker = Widget Out Of Bounds

2018-09-07 Thread Oleg Solovyov 
McPain created this revision.
McPain added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 398356

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15333

AFFECTED FILES
  applets/colorpicker/package/contents/ui/main.qml

To: McPain, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

2018-09-07 Thread Nathaniel Graham 
ngraham added a comment.


  > There is no "Desktop" entry in places by default but I have seen many users 
add it
  
  Actually I added that in D11768 . :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15331

To: broulik, #plasma, hein, fvogt
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15287: [Logout Dialog] Add "Hibernate" option

2018-09-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:33746fa4e7e2: [Logout Dialog] Add Hibernate 
option (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15287?vs=41037=41155

REVISION DETAIL
  https://phabricator.kde.org/D15287

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg, mart
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15315: Set gtk-modules to auto-load appmenu-gtk-module

2018-09-07 Thread Kai Uwe Broulik 
broulik added a comment.


  For some reason `GTK2_RC_FILES` (set by krdb) isn't set here for krunner or 
plasmashell so launching apps from there doesn't pick up the 
`~/.config/gtkrc-2.0` but only `~/.gtkrc-2.0`.
  Krdb sets the launch environment but it's probably not sourced, or too late, 
for plasmashell and others :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15315

To: broulik, #plasma, davidedmundson, fvogt
Cc: cgiboudeaux, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15331: [Folder View] Hide /home/foo/Desktop place in configuration

2018-09-07 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, hein, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Folder View is meant to use `desktop:/` and having two entries that behave 
differently can generate confusion.
  
  CCBUG: 398141

TEST PLAN
  There is no "Desktop" entry in places by default but I have seen many users 
add it
  
  Existing configuration will instead show the path as custom url in the 
configuration

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15331

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigLocation.qml
  containments/desktop/plugins/folder/placesmodel.cpp
  containments/desktop/plugins/folder/placesmodel.h

To: broulik, #plasma, hein, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.11 - Build # 13 - Fixed!

2018-09-07 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.11/13/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 07 Sep 2018 10:54:56 +
 Build duration:
1 min 42 sec and counting

D15261: Remove XRandrBrightness

2018-09-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:7e2986932918: Remove XRandrBrightness (authored by 
broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15261?vs=40965=41146

REVISION DETAIL
  https://phabricator.kde.org/D15261

AFFECTED FILES
  CMakeLists.txt
  daemon/backends/CMakeLists.txt
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h
  daemon/backends/upower/xrandrbrightness.cpp
  daemon/backends/upower/xrandrbrightness.h
  daemon/backends/upower/xrandrxcbhelper.cpp
  daemon/backends/upower/xrandrxcbhelper.h

To: broulik, #plasma, bshah, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15327: Add appmenu-gtk-module as runtime dependency

2018-09-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0a56e67cd5cd: Add appmenu-gtk-module as runtime 
dependency (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15327?vs=41141=41142#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15327?vs=41141=41142

REVISION DETAIL
  https://phabricator.kde.org/D15327

AFFECTED FILES
  cmake/FindAppMenuGtkModule.cmake
  gmenu-dbusmenu-proxy/CMakeLists.txt

To: broulik, #plasma, sitter, cgiboudeaux
Cc: cgiboudeaux, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15327: Add appmenu-gtk-module as runtime dependency

2018-09-07 Thread Christophe Giboudeaux 
cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> FindAppMenuGtkModule.cmake:1-6
> +# - Try to find appmenu-gtk2-module and appmenu-gtk3-module
> +# Once done this will define
> +#
> +#  AppMenuGtkModule_FOUND - System has both appmenu-gtk2-module
> +#   and appmenu-gtk3-module
> +

#.rst:

1. FindAppmenuGtkModule
2. --- #
3. Try to find appmenu-gtk2-module and appmenu-gtk3-module.
4. Once done this will define: #
5. ``AppMenuGtkModule_FOUND``
6. System has both appmenu-gtk2-module and appmenu-gtk3-module

#=

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15327

To: broulik, #plasma, sitter, cgiboudeaux
Cc: cgiboudeaux, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15327: Add appmenu-gtk-module as runtime dependency

2018-09-07 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Makes packagers aware that this module is needed for full GTK global menu 
integration

TEST PLAN
  cmake outuput:
  
-- The following RUNTIME packages have been found:

 * IsoCodes, ISO language, territory, currency, script codes and their 
translations, 
   Translation of country names in digital clock applet
 * AppMenuGtkModule, Application Menu GTK+ Module, 

  
  Tested that uninstalling one of them or both marks it as not found

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15327

AFFECTED FILES
  cmake/FindAppMenuGtkModule.cmake
  gmenu-dbusmenu-proxy/CMakeLists.txt

To: broulik, #plasma, sitter
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15261: Remove XRandrBrightness

2018-09-07 Thread Bhushan Shah 
bshah added a comment.


  FWIW, as mentioned on IRC, +1, kill it with 

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D15261

To: broulik, #plasma, bshah
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart