date:20180909

D14221: Keep track of multiple players

2018-09-09 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a3cf696d5777: Keep track of multiple players (authored by 
broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14221?vs=38057&id=41314

REVISION DETAIL
  https://phabricator.kde.org/D14221

AFFECTED FILES
  extension/content-script.js
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15263: Don't use older buggier versions of AppStream Qt

2018-09-09 Thread Arfrever Frehtes Taifersar Arahesis

arfrever added a comment.


  This change was committed in 5.12 and 5.13, but not yet in master branch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15263

To: apol, #plasma, hein
Cc: arfrever, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15391: [Bookmarks Runner] Fix cleanup of favicon directory

2018-09-09 Thread Stefan Brüns

bruns created this revision.
bruns added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QDir.entryInfoList(NoDotAndDotDot) always returns an empty list, as it
  requires one of QDir::Files, QDir::Dirs or QDir::Drives or any
  combination thereof.
  
  Instead of implementing it manually, use QDir::removeRecursively().

TEST PLAN
  Watch ~/.cache/krunner/
  When krunner is closed, KRunner-Favicons-firefox-default should
  be emptied and deleted.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  favicon_dir_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15391

AFFECTED FILES
  runners/bookmarks/faviconfromblob.cpp

To: bruns, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-09 Thread Nathaniel Graham

ngraham added a comment.


  No new instances of `Q_FOREACH`, please. See 
https://www.kdab.com/goodbye-q_foreach/

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-09 Thread Pino Toscano

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  Thanks Bruce for all the updates, and patience! In return, I have more notes 
:)
  
  - I'd send the changes to the existing SimpleIpV4AddressValidator in an own 
review request, since it affects other code than just this new wireguard plugin 
(maybe with unit tests)
  - I'd send the addition of SimpleIpListValidator in an own review request 
too, since it is an independent code (possibly with unit tests)
  - something I forgot (sorry) in the past: `QRegExp` is the "old" class for 
regexps, while in new code `QRegularExpression` should be preferred/used; 
should be mostly a transparent change for your uses
  - I notes various nits for the UI strings: this is to follow the HIG, see 
https://hig.kde.org/style/writing/index.html in particular
  - if possible, please avoid HTML markup in strings in UI files -- they make 
translations slightly more complicated (e.g. more prone to break the string 
with a typo in the markup)

INLINE COMMENTS

> wireguard.cpp:119
> +valueList = interfaceGroup.readEntry(NMV_WG_TAG_ADDRESS, QStringList());
> +if (valueList.size() == 0)
> +return result;

isEmpty()

> wireguard.cpp:121
> +return result;
> +for (int i = 0; i < valueList.size(); i++) {
> +QPair addressIn = 
> QHostAddress::parseSubnet(valueList[i].trimmed());

better use qt's foreach here:

  Q_FOREACH (const QString &address, valueList)

and then using `address` instead of `valueList[i]`

> wireguard.cpp:122
> +for (int i = 0; i < valueList.size(); i++) {
> +QPair addressIn = 
> QHostAddress::parseSubnet(valueList[i].trimmed());
> +if (addressIn.first.protocol() == 
> QAbstractSocket::NetworkLayerProtocol::IPv4Protocol)

addressIn can be const

> wireguard.cpp:134-135
> +if (!value.isEmpty()) {
> +QRegExp validatorRegex("[0-9a-zA-Z\\+/]{43,43}=");
> +if (validatorRegex.exactMatch(value))
> +dataMap.insert(QLatin1String(NM_WG_KEY_PRIVATE_KEY), value);

the validation of a key is done multiple times, repeating the same regexp every 
time -- I'd be worth to create an own validator for it

> wireguard.cpp:159
> +int pos = 0;
> +SimpleIpListValidator *validator = new SimpleIpListValidator(this,
> + 
> SimpleIpListValidator::WithCidr,

"validator" is leaked here -- just use it on the stack (`SimpleIpListValidator 
validator;`)

> wireguard.cpp:174
> +// Listen Port
> +intValue = interfaceGroup.readEntry(NMV_WG_TAG_LISTEN_PORT, 0);
> +if (intValue > 0) {

`0` is `int` by default, so intValue must be int too (not quint32)

> wireguard.cpp:185
> +if (!value.isEmpty()) {
> +QHostAddress testAddress(value);
> +if (testAddress.protocol() == 
> QAbstractSocket::NetworkLayerProtocol::IPv4Protocol)

const

> wireguard.cpp:195
> +if (intValue > 0) {
> +if (intValue < 65536)
> +dataMap.insert(QLatin1String(NM_WG_KEY_LISTEN_PORT), 
> QString::number(intValue));

an MTU is not a port...

> wireguard.cpp:239
> +{
> +NMStringMap dataMap;
> +NetworkManager::VpnSetting::Ptr vpnSetting = 
> connection->setting(NetworkManager::Setting::Vpn).dynamicCast();

if you move the dataMap declaration after vpnSettings, you can glue declaration 
and initialization together

> wireguard.cpp:245
> +if (!(dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP4))
> +  || dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP4)))
> +|| !dataMap.contains(QLatin1String(NM_WG_KEY_PRIVATE_KEY))

most probably this should be `NM_WG_KEY_ADDR_IP6` (not again IP4)

> wireguard.cpp:258-265
> +if (dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP4))) {
> +value = dataMap[NM_WG_KEY_ADDR_IP4];
> +if (dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP6)))
> +value += "," + dataMap[NM_WG_KEY_ADDR_IP6];
> +} else if (dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP4))) {
> +value = dataMap[NM_WG_KEY_ADDR_IP4];
> +}

just like readEntry, writeEntry can output lists -- just create a QStringList, 
and pass it to writeEntry

> wireguard.cpp:262-263
> +value += "," + dataMap[NM_WG_KEY_ADDR_IP6];
> +} else if (dataMap.contains(QLatin1String(NM_WG_KEY_ADDR_IP4))) {
> +value = dataMap[NM_WG_KEY_ADDR_IP4];
> +}

typos for IP6?

> wireguard.ui:54
> +
> + Private Key:
> +

"Private key:"

> wireguard.ui:91
> +
> + Public Key:
> +

"Public key:"

> wireguardadvanced.ui:26
> +
> + Listen Port:
> +

"Listen port:"

> wireguardadvanced.ui:72-76
> +   
> +
> + A 32-bit 
> fwmark for outgoing packets. If set to 0 or "off", this 
> option is disabled. May be specified in hexadecimal by prepending 
> "0x". Optional.
>

D15386: Use consistent "Suspend" terminology

2018-09-09 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4500ff9de102: Use consistent "Suspend" 
terminology (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15386?vs=41286&id=41289

REVISION DETAIL
  https://phabricator.kde.org/D15386

AFFECTED FILES
  runners/powerdevil/PowerDevilRunner.cpp

To: ngraham, #plasma, #vdg, davidedmundson, broulik
Cc: sudhirkhanger, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: CI System Reorganisation

2018-09-09 Thread Ben Cooksley

On Mon, 10 Sep 2018, 01:17 Christoph Feck,  wrote:

> On 09.09.2018 10:59, Ben Cooksley wrote:
> > As a followup to my earlier mail sent about 3 weeks ago, i've now
> > transitioned all builds on the CI system over to the folder layout
> > previously described.
> >
> > Builds can now be found in folders following the following structure
> > on Jenkins:
> >  / 
>
> How I can view all of "stable" Applications on a single page? I remember
> I asked if it would still be possible after the change, but I cannot see
> a filter or link to get an overview of all builds.
>

These views will come available when the DSL Job is run. It hasn't been run
yet as I want a full backup of the current state of Jenkins before I do so,
in the event something goes wrong.

Cheers,
Ben


> Christoph Feck
>

D15386: Use consistent "Suspend" terminology

2018-09-09 Thread Nathaniel Graham

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We use "Suspend" and "Hibernate" in most places except for KRunner, where we 
currently use more technical terms that expose the implementation details 
(spend to ram vs suspend to disk). Let's be consistent.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  consistent-suspend-terminology (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15386

AFFECTED FILES
  runners/powerdevil/PowerDevilRunner.cpp

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15384: [Bookmarks Runner] Remove unused define

2018-09-09 Thread Stefan Brüns

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9be8c3c7e59b: [Bookmarks Runner] Remove unused define 
(authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15384?vs=41281&id=41284

REVISION DETAIL
  https://phabricator.kde.org/D15384

AFFECTED FILES
  runners/bookmarks/faviconfromblob.cpp

To: bruns, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15384: [Bookmarks Runner] Remove unused define

2018-09-09 Thread Stefan Brüns

bruns created this revision.
bruns added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

TEST PLAN
  make

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15384

AFFECTED FILES
  runners/bookmarks/faviconfromblob.cpp

To: bruns, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15254: Fix Firefox profile location lookup after location has changed

2018-09-09 Thread Stefan Brüns

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dda9aaba2d5c: Fix Firefox profile location lookup after 
location has changed (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15254?vs=41271&id=41280

REVISION DETAIL
  https://phabricator.kde.org/D15254

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15254: Fix Firefox profile location lookup after location has changed

2018-09-09 Thread Stefan Brüns

bruns updated this revision to Diff 41271.
bruns added a comment.


  Squash D15257 , otherwise the favicon DB 
path will not be set

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15254?vs=40943&id=41271

BRANCH
  profile_path

REVISION DETAIL
  https://phabricator.kde.org/D15254

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #plasma, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15257: Set favicon DB path when when places DB path is retrieved from config

2018-09-09 Thread Stefan Brüns

bruns abandoned this revision.
bruns added a comment.


  Squashed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15257

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Stefan Brüns

bruns added a comment.


  In D15357#322812 , @davidedmundson 
wrote:
  
  > RunnerContext::addMatches has its own duplicate check based on match.id
  >
  > We're not explicitly setting that currently.
  >  I think we can just do  match.setId(url+title); and have everything 
handled auto-magically.
  >
  > If that does work it will be less code with the same results, faster and 
even handle dupes in both firefox and chrome bookmarks. Win win.
  
  
  hm, no:
  
  - It will not filter out the entries with empty titles
  - The BookmarkMatch constructor fetches the favicon for each match

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread David Edmundson

davidedmundson added a comment.


  RunnerContext::addMatches has it's own duplicate check based on match.id
  
  We're not explicitly setting that currently.
  I think we can just do  match.setId("bookmarks"+url+title); and have 
everything handled auto-magically.
  
  If that does work it will be less code with the same results, faster and even 
handle dupes in both firefox and chrome bookmarks. Win win.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Stefan Brüns

bruns added inline comments.

INLINE COMMENTS

> zzag wrote in firefox.cpp:136
> Please use prefix increment.

If there are more required changes, yes, else - no.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Vlad Zagorodniy

zzag added inline comments.

INLINE COMMENTS

> bruns wrote in firefox.cpp:136
> It neither guarantees prefix is more efficient than postfix.

Please use prefix increment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Stefan Brüns

bruns added inline comments.

INLINE COMMENTS

> zzag wrote in firefox.cpp:136
> Does the C++ standard guarantee that?

It neither guarantees prefix is more efficient than postfix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Vlad Zagorodniy

zzag added inline comments.

INLINE COMMENTS

> bruns wrote in firefox.cpp:136
> Because modern compilers are clever enough do avoid any temporaries

Does the C++ standard guarantee that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: CI System Reorganisation

2018-09-09 Thread Christoph Feck


On 09.09.2018 10:59, Ben Cooksley wrote:

As a followup to my earlier mail sent about 3 weeks ago, i've now
transitioned all builds on the CI system over to the folder layout
previously described.

Builds can now be found in folders following the following structure
on Jenkins:
 / 


How I can view all of "stable" Applications on a single page? I remember 
I asked if it would still be possible after the change, but I cannot see 
a filter or link to get an overview of all builds.


Christoph Feck

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Stefan Brüns

bruns added inline comments.

INLINE COMMENTS

> zzag wrote in firefox.cpp:136
> Why postfix increment?

Because modern compilers are clever enough do avoid any temporaries

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

2018-09-09 Thread Vlad Zagorodniy

zzag added inline comments.

INLINE COMMENTS

> firefox.cpp:136
> +
> +for (auto result = uniqueResults.constKeyValueBegin(); result != 
> uniqueResults.constKeyValueEnd(); result++) {
> +BookmarkMatch bookmarkMatch(m_favicon, term, (*result).second, 
> (*result).first);

Why postfix increment?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15357

To: bruns, #plasma
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

CI System Reorganisation

2018-09-09 Thread Ben Cooksley

Hi all,

As a followup to my earlier mail sent about 3 weeks ago, i've now
transitioned all builds on the CI system over to the folder layout
previously described.

Builds can now be found in folders following the following structure
on Jenkins:
 / 

For those with access to run DSL Scripts: Please do not run them.
While I have completed the necessary adaptions to them, I have yet to
test them and would like to have a full backup of the current state of
Jenkins before I proceed with doing so (due to the colossal number of
files and data involved, this takes quite a bit of time)

When the DSL Job is run the views I mentioned previously, which will
provide recursive overviews for those who prefer those, will become
available.

If anyone encounters any issues please let us know.

Thanks,
Ben Cooksley
KDE Sysadmin

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

2018-09-09 Thread David Edmundson

davidedmundson added a comment.


  Urgh. Just read the code.
  
  We don't reset when we type a new letter. To do so would have a jumpy ui. 
Instead we reset when we get results back.
  
  That leaves a problem when you search for "firefo" ( with 1 result) to 
"firefodfhhxtffrdh" with zero results. Which is what this timer "solves"
  
  Clearly its not a good solution to the problem. Changing it to 5 seconds 
isn't helping.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

To: McPain, broulik, davidedmundson
Cc: davidedmundson, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

2018-09-09 Thread David Edmundson

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  No point pinging if we haven't replied to Kai's comments/question.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

To: McPain, broulik, davidedmundson
Cc: davidedmundson, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-09 Thread Bruce Anderson

andersonbruce marked 37 inline comments as done.
andersonbruce added a comment.


  I think I've gotten most of the fixes in. I made changes to 
simpleipv4addressvalidator and simpleipv6addressvalidator to add checking of 
addresses with CIDR and Port suffixes. Please check these carefully, I think I 
did the changes such that all existing uses will not be affected but I want to 
make sure. Oh, except I made one fix in ipv6 where it was disallowing "::" at 
the beginning of the address followed by anything. This is a totally valid and 
not uncommon usage so I included that in the change.
  I also added a new file simpleiplistvalidator which allows the checking of 
comma separated lists of IPv4, IPv6, or mixed addresses.
  
  I have not yet deleted the wireguardauthwidget because I haven't figured out 
what the 'askUser' function should return if it is not there.  There are also a 
couple of things I either didn't see before or forgot about that I will 
continue working on.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-09 Thread Bruce Anderson

andersonbruce updated this revision to Diff 41241.
andersonbruce added a comment.


  - Fixed comment
  - Expand capabilities of SimpleIP validators.
  - Changes per review comments
  - Update for updated ip validators

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15093?vs=40885&id=41241

BRANCH
  Feature/AddWireGuardVPN

REVISION DETAIL
  https://phabricator.kde.org/D15093

AFFECTED FILES
  libs/editor/CMakeLists.txt
  libs/editor/simpleiplistvalidator.cpp
  libs/editor/simpleiplistvalidator.h
  libs/editor/simpleipv4addressvalidator.cpp
  libs/editor/simpleipv4addressvalidator.h
  libs/editor/simpleipv6addressvalidator.cpp
  libs/editor/simpleipv6addressvalidator.h
  libs/models/kcmidentitymodel.cpp
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14221: Keep track of multiple players

D15263: Don't use older buggier versions of AppStream Qt

D15391: [Bookmarks Runner] Fix cleanup of favicon directory

D15093: Add WireGuard capability.

D15093: Add WireGuard capability.

D15386: Use consistent "Suspend" terminology

Re: CI System Reorganisation

D15386: Use consistent "Suspend" terminology

D15384: [Bookmarks Runner] Remove unused define

D15384: [Bookmarks Runner] Remove unused define

D15254: Fix Firefox profile location lookup after location has changed

D15254: Fix Firefox profile location lookup after location has changed

D15257: Set favicon DB path when when places DB path is retrieved from config

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

Re: CI System Reorganisation

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

CI System Reorganisation

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

D15093: Add WireGuard capability.

D15093: Add WireGuard capability.

27 matches

Site Navigation

Mail list logo

Footer information