D13625: Add 'Documentation' category to the Application menus

2018-09-11 Thread Yuri Chornoivan 
yurchor abandoned this revision.
yurchor added a comment.


  The problem can be solved on the distribution level:
  
  https://bugs.mageia.org/show_bug.cgi?id=19532#c5

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13625

To: yurchor, #plasma_workspaces
Cc: hein, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D15440: Translated into Russian

2018-09-11 Thread Pino Toscano 
pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  NACK, this is not the correct approach.
  The right approach is translate the messages via the .po file that contains 
them: 
https://websvn.kde.org/trunk/l10n-kf5/ru/messages/kde-workspace/plasma-browser-extension.po?view=markup
 (and the same in `branches/stable/l10n-kf5`). There is an automatic system 
that extracts the messages into plasma-browser-extension.pot, and injects all 
the translations back to the repository in form of `messages.json` files.
  
  For more information, please contact the Russian translation team: 
https://l10n.kde.org/team-infos.php?teamcode=ru

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15440

To: sheykhnurlatipov, pino
Cc: pino, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15410: Handle clients which change window metadata during early startup

2018-09-11 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems to work with LO 5.1.6 for me!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15410

To: hein, davidedmundson, broulik, ngraham
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15442: Improve DDCUtil handling in CMakeLists

2018-09-11 Thread Hannes Schweizer 
nilathak created this revision.
nilathak added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nilathak requested review of this revision.

REVISION SUMMARY
  This has already been started in https://phabricator.kde.org/D8626?id=33105
  but never got merged.
  Whenever ddcutil is present during build, it should be OK to enable the 
support by default.
  It can still be turned off via CMAKE_DISABLE_FIND_PACKAGE_DDCUtil=ON.
  
  This will also provide a better fix for https://bugs.gentoo.org/636098

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D15442

AFFECTED FILES
  CMakeLists.txt

To: nilathak, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15441: Initial migration to >=ddcutil-0.8.6 API (tested with ddcutil-0.9.1)

2018-09-11 Thread Hannes Schweizer 
nilathak created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nilathak requested review of this revision.

REVISION SUMMARY
  The current ddcutilbrightness.cpp implementation has been broken since the 
following ddcutil commit:
  
https://github.com/rockowitz/ddcutil/commit/3276de053ec2b3771213f14f7dddba569b82e16f
  
  BUG: 398473

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D15441

AFFECTED FILES
  daemon/backends/upower/ddcutilbrightness.cpp

To: nilathak
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15440: Translated into Russian

2018-09-11 Thread Sheykhnur Latipov 
sheykhnurlatipov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sheykhnurlatipov requested review of this revision.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15440

AFFECTED FILES
  extension/_locales/ru/messages.json

To: sheykhnurlatipov
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15435: Add translucent background attribute to popup menu

2018-09-11 Thread Alex Nemeth 
anemeth updated this revision to Diff 41432.
anemeth added a comment.


  Add translucent background attribute to popup menu

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15435?vs=41431=41432

BRANCH
  fix_desktop_menu_tp

REVISION DETAIL
  https://phabricator.kde.org/D15435

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: anemeth
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15435: Add translucent background attribute to popup menu

2018-09-11 Thread Alex Nemeth 
anemeth created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anemeth requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_desktop_menu_tp

REVISION DETAIL
  https://phabricator.kde.org/D15435

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: anemeth
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Andrew Crouthamel 
acrouthamel added a comment.


  I like it. I agree though to maybe make them a bit lighter.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Nathaniel Graham 
ngraham accepted this revision as: VDG.
ngraham added a comment.


  Looks good to me, and doesn't regress anything in any of the other locales I 
tried. I'll let @hein do a final review.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Nathaniel Graham 
ngraham added a reviewer: VDG.
ngraham added a comment.


  Thanks, that helps!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm. Here's another idea: we could badge the app icon with 
`player-volume-muted`, maybe.
  
  I just worry a bit that lightening the app icon may be too subtle, and people 
might see it as a bug or wonder why it looks different.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15430: Open Web Shorcuts KCM from Web Shortcut Runner config

2018-09-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, leszeklesner, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The runner doesn't have any config on its own but uses the Web Shortcuts 
configuration.
  Add a "configure" button that opens that KCM straight away.
  
  BUG: 398242
  FIXED-IN: 5.14.0

TEST PLAN
  I don't think this was really designed to open non-krunner configuration but 
it's just a KCModule in a KCModuleProxy, so works just fine
  
  - Changed separator setting, krunner pick up that setting at runtime just fine
  
  F6252320: Screenshot_20180911_154830.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15430

AFFECTED FILES
  runners/webshortcuts/CMakeLists.txt
  runners/webshortcuts/plasma-runner-webshortcuts_config.desktop

To: broulik, #plasma, leszeklesner, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

2018-09-11 Thread Kevin Funk 
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  I think that makes sense. +1.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D15429

To: dfaure, kfunk, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

2018-09-11 Thread David Faure 
dfaure created this revision.
dfaure added reviewers: kfunk, kossebau.
Herald added a project: Plasma.
Herald edited subscribers, added: plasma-devel; removed: Plasma.
dfaure requested review of this revision.

REVISION SUMMARY
  This target was added in Qt 5.9, which we can now rely upon.
  Also use target_include_directories rather than the big
  include_directories hammer.

TEST PLAN
  Compiles

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D15429

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt

To: dfaure, kfunk, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15427: [Spellchecker Runner] Add button to open Spell Check KCM

2018-09-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, leszeklesner, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In the runner's configuration you can only configure the trigger word, 
whereas language and other settings are in the KCM.
  Just add a button to open said KCM
  
  BUG: 398244
  FIXED-IN: 5.14.0

TEST PLAN
  F6252261: Screenshot_20180911_152701.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15427

AFFECTED FILES
  runners/spellchecker/spellcheck_config.cpp
  runners/spellchecker/spellcheck_config.h
  runners/spellchecker/spellcheck_config.ui

To: broulik, #plasma, leszeklesner, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Oleg Solovyov 
McPain added a comment.


  Before: F6252186: изображение.png 
  After: F6252262: изображение.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Nathaniel Graham 
ngraham added a comment.


  Before-and-after screenshots can make a big difference in the reviewability 
of a patch like this. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

To: McPain, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Kai Uwe Broulik 
broulik added a comment.


  F6252135: Screenshot_20180911_144651.png 

  Fading the mute button doesn't make that big of a diference

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

2018-09-11 Thread Oleg Solovyov 
McPain added a comment.


  In D14064#322643 , @davidedmundson 
wrote:
  
  > Urgh. Just read the code.
  >
  > We don't reset when we type a new letter. To do so would have a jumpy ui. 
Instead we reset when we get results back.
  >
  > That leaves a problem when you search for "firefo" ( with 1 result) to 
"firefodfhhxtffrdh" with zero results. Which is what this timer "solves"
  >
  > Clearly its not a good solution to the problem. Changing it to 5 seconds 
isn't helping.
  
  
  which solution would be good?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D14064

To: McPain, broulik, davidedmundson
Cc: davidedmundson, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15423: System settings: make date/time format preview consistent

2018-09-11 Thread Oleg Solovyov 
McPain created this revision.
McPain added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  BUG: 398493

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15423

AFFECTED FILES
  kcms/formats/kcmformats.cpp

To: McPain, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Kai Uwe Broulik 
broulik added a comment.


  We need to take care to not make it confusing with the "muted" state where it 
fades the slider

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Nathaniel Graham 
ngraham added a comment.


  That dimming effect might be too subtle on a brightly colored app icon. How 
about dimming the black volume icon instead of or in addition to the app icon?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

2018-09-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a stream is present but not playing anything ("corked"), show icon 
slightly translucent
  
  BUG: 398476
  FIXED-IN: 5.14.0

TEST PLAN
  VLC is playing, Chrome has a paused video open
  F6251873: Screenshot_20180911_131535.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

2018-09-11 Thread James Smith 
smithjd added a comment.


  In D15341#323730 , @ngraham wrote:
  
  > In D15341#323715 , @smithjd 
wrote:
  >
  > > KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.
  >
  >
  > Can you explain why the fact that KRunner does more than the search fields 
in Kicker/Kickoff and Dolphin is a justification for allowing you to customize 
a small subset of the navigation shortcuts there, but not elsewhere? Help me 
understand where you're coming from. If you'd want to use [ctrl] + [e] and 
[ctrl] + [s]  (etc.) to navigate in KRunner, why wouldn't you want to use them 
elsewhere too? What's the difference?
  
  
  Global in-application shortcuts can already be customized. The problem is 
that often the desired shortcut is already assigned to some other action, such 
as Ctrl+S for saving across all applications. Reassigning Ctrl+S **globally** 
just for one application is terrible from a HIG perspective, so an 
application-specific override must be considered. A welcome side-effect from 
this is the large number of shortcuts now available to KRunner that don't 
impact global actions.
  
  In KRunner a larger percentage of the functionality is derived of text input, 
Dolphin / Kicker / Kickoff aren't similar to bash / KRunner in this regard and 
so wouldn't benefit as much from configurable input navigation shortcuts. The 
global shortcuts will still have the same actions as other applications unless 
the global shortcut is used for a KRunner action.
  
  IMO, this feature should already be a part of KRunner, though it hasn't had 
an outstanding absence. The notion that global shortcuts should be shuffled for 
a single application is wrong. Changing the global shortcut for the same 
//type// of input navigation may suit the user, though this shouldn't be 
encouraged for only a single application. Promoting global shortcuts over an 
application-specific configureability is always wrong, and less right when 
there's already a patch. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart