D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

[Bruce Anderson]

andersonbruce created this revision.
andersonbruce added reviewers: jgrulich, pino.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
andersonbruce requested review of this revision.

REVISION SUMMARY
  CCBUG: 397572
  FIXED-IN: 5.14.0

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  IPAddressListValidator

REVISION DETAIL
  https://phabricator.kde.org/D15521

AFFECTED FILES
  libs/editor/CMakeLists.txt
  libs/editor/simpleiplistvalidator.cpp
  libs/editor/simpleiplistvalidator.h
  tests/CMakeLists.txt
  tests/simpleiplisttest.cpp

To: andersonbruce, jgrulich, pino
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

[Nathaniel Graham]

ngraham added a comment.


  Thanks! And since I don't believe this patch on its own is sufficient to 
resolve 397572, please change `FEATURE: 397572` to `CCBUG: 397572`. The former 
will close the bug once this lands; the latter just adds the commit info as a 
comment, but keeps the bug open--which is what we want here.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15520

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidatorto optionally handle a CIDR or port suffix. Added capabilitiesimplemented via defaulted parameter to maintain compatibilitywith

[Nathaniel Graham]

ngraham added a comment.


  That huge summary needs reformatting, please. :) See 
https://chris.beams.io/posts/git-commit/#seven-rules

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15520

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidatorto optionally handle a CIDR or port suffix. Added capabilitiesimplemented via defaulted parameter to maintain compatibilitywith

[Bruce Anderson]

andersonbruce created this revision.
andersonbruce added reviewers: jgrulich, pino.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
andersonbruce requested review of this revision.

REVISION SUMMARY
  ...updated
  code. Opened as a separate review per comment from Pino on review
  D15093 .
  
  Part of:
  FEATURE: 397572
  FIXED-IN: 5.14.0

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  IP4/6validatorsUpdate

REVISION DETAIL
  https://phabricator.kde.org/D15520

AFFECTED FILES
  CMakeLists.txt
  libs/editor/simpleipv4addressvalidator.cpp
  libs/editor/simpleipv4addressvalidator.h
  libs/editor/simpleipv6addressvalidator.cpp
  libs/editor/simpleipv6addressvalidator.h
  tests/CMakeLists.txt
  tests/simpleipv4test.cpp
  tests/simpleipv6test.cpp

To: andersonbruce, jgrulich, pino
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Christoph Feck]

cfeck added a comment.


  I would even say 'after' looks better, because the bottom shadow isn't as 
strong as 'before'.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma
Cc: cfeck, ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag updated this revision to Diff 41667.
zzag added a comment.


  Simplify code, also delete unrelated changes

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15514?vs=41666&id=41667

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp

To: zzag, #kwin, #plasma
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag planned changes to this revision.
zzag added a comment.


  Simplify it further.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag updated this revision to Diff 41666.
zzag added a comment.


  Code formatting

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15514?vs=41665&id=41666

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp

To: zzag, #kwin, #plasma
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag added a comment.


  In D15514#326127 , @ngraham wrote:
  
  > Yeah, I also can't tell the difference. If this new way is computationally 
cheaper, then +1 from me.
  
  
  I don't want to say numbers (because in order to have proper benchmark, I 
have to test it on variety of different hardware), but with the debug build (on 
my crappy 2012 laptop) + some load (Firefox), on average, it takes 10x less 
time to generate shadows.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I also can't tell the difference. If this new way is computationally 
cheaper, then +1 from me.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag updated this revision to Diff 41665.
zzag added a comment.


  Call reserve method

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15514?vs=41663&id=41665

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp

To: zzag, #kwin, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Andres Betts]

abetts added a comment.


  Interesting, no big real differences visually IMHO

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15514

To: zzag, #kwin, #plasma
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag updated this revision to Diff 41663.
zzag added a comment.


  Edit comments

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15514?vs=41662&id=41663

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp

To: zzag, #kwin, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15514: [libbreezecommon] Use box blur instead of FFT approach

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Creation of shadows (especially for "Large" and "Very large" sizes) is
  a computation expensive task because we have to blur alpha channel of a
  shadow texture (which then will be tinted with desired shadow color).
  
  Currently, we use the following approach:
  
  - for blur radius less than 64, use naive 2-pass algorithm;
  - for blur radius greater than or equal to 64, use FFT.
  
  Even though the FFT approach is doing its the best, it still takes
  impresive amount of time to blur the alpha channel.
  
  What makes things even worse is that while we're blurring the alpha
  channel, we're blocking the main thread of KWin (decorations are not
  rendered in their own thread). This can result in frame drops (2 or 3
  frames, something like that).
  
  So, the only viable alternative is to use an approximation of the Gaussian
  blur. As such an approximation, I picked the box blur because it's quite
  simple, it's fast, and it takes small amount of iterations to have something
  similar to the true Gaussian blur.
  
  In general, there are no big differences between true gaussian shadows
  and approximated shadows:
  
  Before:
  F6264173: FFT shadows 
  
  After:
  F6264175: after.png 
  
  As a win, it takes much less time to generate decoration shadows.

REPOSITORY
  R31 Breeze

BRANCH
  zzag/box-shadow-helper-box-blur

REVISION DETAIL
  https://phabricator.kde.org/D15514

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp

To: zzag, #kwin, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Fabian Vogt]

fvogt added a comment.


  In D15512#326093 , @romangg wrote:
  
  > In D15512#326091 , @fvogt wrote:
  >
  > > I'm against this - `kwin_wayland` should just pick the next available 
socket if `wayland-0` is not available. That's also what Xorg does and is IMO 
the expected behaviour.
  >
  >
  > Maybe this would be nice, haven't thought about it yet. But what speaks in 
any case against a manual override?
  
  
  It's not necessary AFAICT. Either a socket exists and can't be used, or it 
does not exist and does not matter.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15512

To: romangg, #kwin, #plasma
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Roman Gilg]

romangg added a comment.


  In D15512#326091 , @fvogt wrote:
  
  > I'm against this - `kwin_wayland` should just pick the next available 
socket if `wayland-0` is not available. That's also what Xorg does and is IMO 
the expected behaviour.
  
  
  Maybe this would be nice, haven't thought about it yet. But what speaks in 
any case against a manual override?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15512

To: romangg, #kwin, #plasma
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Fabian Vogt]

fvogt added a comment.


  I'm against this - `kwin_wayland` should just pick the next available socket 
if `wayland-0` is not available. That's also what Xorg does and is IMO the 
expected behaviour.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15512

To: romangg, #kwin, #plasma
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Argument will be forwarded to KWin.
  
  Allows to start a full Wayland Plasma session from a second
  VT while another Wayland session is active on the first one.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  kwinWaylandSocketArg

REVISION DETAIL
  https://phabricator.kde.org/D15512

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: romangg, #kwin, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kde-gtk-config » stable-kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/stable-kf5-qt5%20FreeBSDQt5.11/4/
 Project:
stable-kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 18:42:10 +
 Build duration:
2 min 1 sec and counting

KDE CI: Plasma » kde-gtk-config » stable-kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/stable-kf5-qt5%20FreeBSDQt5.11/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 18:41:09 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 13.65 KB...] > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 4dccfb0f307f985dbde709372066337039b2ff95 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 4dccfb0f307f985dbde709372066337039b2ff95Commit message: "Fix these as well"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Plasma/kde-gtk-config/stable-kf5-qt5 FreeBSDQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a6080f60f7b708e8919ff3d7421ae3f0f319e6ac (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a6080f60f7b708e8919ff3d7421ae3f0f319e6acCommit message: "Plasma: track Plasma/5.14 as stable i18n branch"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Plasma/kde-gtk-config/stable-kf5-qt5 FreeBSDQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 7d0a0be87dbdc1e0736ad5e4e0ddb060fa5e6fec (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 7d0a0be87dbdc1e0736ad5e4e0ddb060fa5e6fecCommit message: "Remove duplicate dependencies on kdoctools (these are provided via kf5umbrella) Also, sync dependencies from master to stable"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[stable-kf5-qt5 FreeBSDQt5.11] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project kde-gtk-config --branchGroup stable-kf5-qt5 --environment production --platform FreeBSDQt5.11 --installTo /home/jenkins/install-prefix/Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5Retrieving: Plasma-karchive-stable-kf5-qt5Retrieving: Plasma-ki18n-stable-kf5-qt5Retrieving: Plasma-kcoreaddons-stable-kf5-qt5Retrieving: Plasma-kwindowsystem-stable-kf5-qt5Retrieving: Plasma-kconfig-stable-kf5-qt5Retrieving: Plasma-kcrash-stable-kf5-qt5Retrieving: Plasma-kdbusaddons-stable-kf5-qt5Retrieving: Plasma-kdoctools-stable-kf5-qt5Retrieving: Plasma-kservice-stable-kf5-qt5Retrieving: Plasma-kcodecs-stable-kf5-qt5Retrieving: Plasma-phonon-stable-kf5-qt5Retrieving: Plasma-kauth-stable-kf5-qt5Retrieving: Plasma-kguiaddons-stable-kf5-qt5Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5Retrieving: Plasma-kitemviews-stable-kf5-qt5Retrieving: Plasma-kcompletion-stable-kf5-qt5Retrieving: Plasma-kiconthemes-stable-kf5-qt5Retrieving: Plasma-sonnet-stable-kf5-qt5Retrieving: Plasma-attica-stable-kf5-qt5Retrieving: Plasma-kglobalaccel-stable-kf5-qt5Retrieving: Plasma-ktextwidgets-stable-kf5-qt5Retrieving: Plasma-breeze-icons-stable-kf5-qt5Retrieving: Plasma-knotifications-stable-kf5-qt5Retrieving: Plasma-kxmlgui-stable-kf5-qt5Retrieving: Plasma-solid-stable-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 71, in filename, metadata = packageArchive.retrievePackage( package )  File "/usr/home/jenkins/workspace/Plasma/kde-gtk-config/stable-kf5-qt5 FreeBSDQt5.1

D15509: autoconnect-priority is a 32-bit signed integer

[Caio Jordão Carvalho]

cjlcarvalho created this revision.
cjlcarvalho added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cjlcarvalho requested review of this revision.

REVISION SUMMARY
  Fixing autoconnect-priority spinbox minimum value and including maximum 
value, because it is an int32 as seen here 
.
  
  It was set previously only with -100 as minimum value.
  
  Lower values are being considered as -100.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15509

AFFECTED FILES
  libs/editor/settings/ui/connectionwidget.ui

To: cjlcarvalho, #plasma
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:715ba3a22906: Add Messages.sh (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15495?vs=41650&id=41651

REVISION DETAIL
  https://phabricator.kde.org/D15495

AFFECTED FILES
  reminder/CMakeLists.txt
  reminder/Messages.sh

To: broulik, #plasma, davidedmundson, #localization, aacid, aspotashev
Cc: aspotashev, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Alexander Potashev]

aspotashev accepted this revision.
aspotashev added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15495

To: broulik, #plasma, davidedmundson, #localization, aacid, aspotashev
Cc: aspotashev, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Kai Uwe Broulik]

broulik updated this revision to Diff 41650.
broulik added a comment.


  - Move `Messages.sh` into `reminder` dir

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15495?vs=41620&id=41650

REVISION DETAIL
  https://phabricator.kde.org/D15495

AFFECTED FILES
  reminder/CMakeLists.txt
  reminder/Messages.sh

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: aspotashev, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/9/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 14 Sep 2018 13:15:07 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1825)0%
(0/690)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/270)0%
(0/124)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/190)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/503)0%
(0/232)icons0%
(0/3)0%
(0/3)0%
(0/271)0%
(0/52)sidebar0%
(0/4)0%
(0/4)0%
(0/406)0%
(0/190)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 7 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/7/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 14 Sep 2018 13:20:47 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2548)14%
(214/1481)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/158)0%
(0/84)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1249)21%
(138/666)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/221)0%
(0/116)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/35)

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 11 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/11/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 14 Sep 2018 13:18:20 +
 Build duration:
2 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/62)0%
(0/62)0%
(0/3662)0%
(0/2492)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1345)0%
(0/1044)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/788)0%
(0/468)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/212)0%
(0/110)daemon.backends.upower0%
(0/10)0%
(0/10)0%
(0/779)0%
(0/595)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/108)0%
(0/46)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/7/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 13:16:31 +
 Build duration:
1 min 14 sec and counting

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/9/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 13:15:25 +
 Build duration:
47 sec and counting

D15498: Workaround QTBUG-47066 to fix crash on startup

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:a21dd3486b12: Workaround QTBUG-47066 to fix crash on 
startup (authored by fvogt).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15498?vs=41622&id=41644

REVISION DETAIL
  https://phabricator.kde.org/D15498

AFFECTED FILES
  src/sddmkcm.cpp

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/6/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 14 Sep 2018 12:11:52 +
 Build duration:
6 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 90.29 KB...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'PWD   = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-14184a18717d'HOST  = '14184a18717d'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/6/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#6'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.11-6'NODE_LABELS   = 'Docker Swarm-14184a18717d SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.51.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.51.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.51.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.51.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.51.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.51.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.51.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/8/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 14 Sep 2018 12:11:43 +
 Build duration:
2 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 93.89 KB...]XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/8/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#8'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 SUSEQt5.11-8'NODE_LABELS   = 'Docker Swarm-f14e51f4d469 SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.51.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.51.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.51.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.51.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.51.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.51.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.51.0") -- Found KF5WidgetsAddons: /home/jenkins/install-prefix/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.51.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.51.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.51.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.51.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmak

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/8/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 12:11:40 +
 Build duration:
2 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 71.03 KB...]PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.11'WORKSPACE = '/usr/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 FreeBSDQt5.11'BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/8/'STAGE_NAME= 'Configuring Build'QT_SELECT = 'qt5'OSTYPE= 'FreeBSD'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'HUDSON_HOME   = '/home/production/data'HOME  = '/usr/home/jenkins/'BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 FreeBSDQt5.11-8'LOGNAME   = 'jenkins'BUILD_DISPLAY_NAME= '#8'HOST  = 'freebsd-node3'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/display/redirect'MACHTYPE  = 'x86_64'XDG_CURRENT_DESKTOP   = 'KDE'PAGER = 'more'HOSTTYPE  = 'FreeBSD'NODE_NAME = 'FreeBSD Builder 3'SHLVL = '1'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/8/display/redirect'NODE_LABELS   = 'FreeBSD Builder 3 FreeBSDQt5.11'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'BUILD_ID  = '8'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.11/'EXECUTOR_NUMBER   = '0'JOB_NAME  = 'Plasma/systemsettings/kf5-qt5 FreeBSDQt5.11'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins//bin'SHELL = '/bin/tcsh'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 FreeBSDQt5.11"-- The C compiler identification is Clang 6.0.0-- The CXX compiler identification is Clang 6.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.51.0") -- Found KF5ItemViews: /usr/home/jenkins/install-prefix/lib/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.51.0") -- Found KF5KCMUtils: /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.51.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.51.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.51.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.51.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.51.0") -- Found KF5WidgetsAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.51.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.51.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.51.0") -- Found K

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/10/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 14 Sep 2018 12:11:46 +
 Build duration:
1 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 46.42 KB...]Retrieving: Plasma-kcrash-kf5-qt5Retrieving: Plasma-kdbusaddons-kf5-qt5Retrieving: Plasma-kdoctools-kf5-qt5Retrieving: Plasma-kservice-kf5-qt5Retrieving: Plasma-kcodecs-kf5-qt5Retrieving: Plasma-phonon-kf5-qt5Retrieving: Plasma-polkit-qt-1-kf5-qt5Retrieving: Plasma-kauth-kf5-qt5Retrieving: Plasma-kguiaddons-kf5-qt5Retrieving: Plasma-kwidgetsaddons-kf5-qt5Retrieving: Plasma-kconfigwidgets-kf5-qt5Retrieving: Plasma-kitemviews-kf5-qt5Retrieving: Plasma-kcompletion-kf5-qt5Retrieving: Plasma-kiconthemes-kf5-qt5Retrieving: Plasma-sonnet-kf5-qt5Retrieving: Plasma-attica-kf5-qt5Retrieving: Plasma-kglobalaccel-kf5-qt5Retrieving: Plasma-ktextwidgets-kf5-qt5Retrieving: Plasma-breeze-icons-kf5-qt5Retrieving: Plasma-knotifications-kf5-qt5Retrieving: Plasma-kxmlgui-kf5-qt5Retrieving: Plasma-solid-kf5-qt5Retrieving: Plasma-kjobwidgets-kf5-qt5Retrieving: Plasma-kbookmarks-kf5-qt5Retrieving: Plasma-kwallet-kf5-qt5Retrieving: Plasma-kio-kf5-qt5Retrieving: Plasma-kparts-kf5-qt5Retrieving: Plasma-kplotting-kf5-qt5Retrieving: Plasma-kdewebkit-kf5-qt5Retrieving: Plasma-kinit-kf5-qt5Retrieving: Plasma-kunitconversion-kf5-qt5Retrieving: Plasma-kded-kf5-qt5Retrieving: Plasma-kemoticons-kf5-qt5Retrieving: Plasma-kdesignerplugin-kf5-qt5Retrieving: Plasma-syntax-highlighting-kf5-qt5Retrieving: Plasma-kpackage-kf5-qt5Retrieving: Plasma-kactivities-kf5-qt5Retrieving: Plasma-kdnssd-kf5-qt5Retrieving: Plasma-kdeclarative-kf5-qt5Retrieving: Plasma-kidletime-kf5-qt5Retrieving: Plasma-kitemmodels-kf5-qt5Retrieving: Plasma-kjs-kf5-qt5Retrieving: Plasma-kross-kf5-qt5Retrieving: Plasma-threadweaver-kf5-qt5Retrieving: Plasma-kwayland-kf5-qt5Retrieving: Plasma-ktexteditor-kf5-qt5Retrieving: Plasma-oxygen-icons5-kf5-qt5Cannot contact Docker Swarm-4b0b87b1524e: java.lang.InterruptedExceptionRetrieving: Plasma-kirigami-kf5-qt5Traceback (most recent call last):  File "/usr/lib64/python3.6/urllib/request.py", line 1318, in do_openencode_chunked=req.has_header('Transfer-encoding'))  File "/usr/lib64/python3.6/http/client.py", line 1239, in requestself._send_request(method, url, body, headers, encode_chunked)  File "/usr/lib64/python3.6/http/client.py", line 1285, in _send_requestself.endheaders(body, encode_chunked=encode_chunked)  File "/usr/lib64/python3.6/http/client.py", line 1234, in endheadersself._send_output(message_body, encode_chunked=encode_chunked)  File "/usr/lib64/python3.6/http/client.py", line 1026, in _send_outputself.send(msg)  File "/usr/lib64/python3.6/http/client.py", line 964, in sendself.connect()  File "/usr/lib64/python3.6/http/client.py", line 1392, in connectsuper().connect()  File "/usr/lib64/python3.6/http/client.py", line 936, in connect(self.host,self.port), self.timeout, self.source_address)  File "/usr/lib64/python3.6/socket.py", line 704, in create_connectionfor res in getaddrinfo(host, port, 0, SOCK_STREAM):  File "/usr/lib64/python3.6/socket.py", line 745, in getaddrinfofor res in _socket.getaddrinfo(host, port, family, type, proto, flags):socket.gaierror: [Errno -3] Temporary failure in name resolutionDuring handling of the above exception, another exception occurred:Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 71, in filename, metadata = packageArchive.retrievePackage( package )  File "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.11/ci-tooling/helpers/helperslib/Packages.py", line 113, in retrievePackageresponse = urllib.request.urlopen( self.downloadBaseUrl() + '/' + contentsFilename )  File "/usr/lib64/python3.6/urllib/request.py", line 223, in urlopenreturn opener.open(url, data, timeout)  File "/usr/lib64/python3.6/urllib/request.py", line 526, in openresponse = self._open(req, data)  File "/usr/lib64/python3.6/urllib/request.py", line 544, in _open'_open', req)  File "/usr/lib64/python3.6/urllib/request.py", line 504, in _call_chainresult = func(*args)  File "/usr/lib64/python3.6/urllib/request.py", line 1361, in https_opencontext=self._context, check_hostname=self._check_hostname)  File "/usr/lib64/python3.6/urllib/request.py", line 1320, in do_openraise URLError(err)urllib.error.URLError: [Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.11 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/6/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 12:11:54 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 65.98 KB...]EXECUTOR_NUMBER   = '0'HUDSON_HOME   = '/home/production/data'HOME  = '/home/jenkins'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/6/display/redirect?page=changes'LANG  = 'en_US.UTF-8'JENKINS_URL   = 'https://build.kde.org/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'QT_SELECT = 'qt5'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'MM_CHARSET= 'UTF-8'BUILD_DISPLAY_NAME= '#6'_ = '/usr/local/bin/java'WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.11'MAIL  = '/var/mail/jenkins'USER  = 'jenkins'NODE_NAME = 'FreeBSD Builder 1'JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.11'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'STAGE_NAME= 'Configuring Build'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/'TERM  = 'su'SHELL = '/usr/local/bin/bash'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/6/'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.11-6'BLOCKSIZE = 'K'JAVA_HOME = '/usr/local/openjdk8-jre'BUILD_ID  = '6'HUDSON_URL= 'https://build.kde.org/'JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.11'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/display/redirect'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.11/6/display/redirect'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'BUILD_NUMBER  = '6'SHLVL = '1'PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.11'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.11'OLDPWD= '/usr/home/jenkins'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.11"-- The C compiler identification is Clang 6.0.0-- The CXX compiler identification is Clang 6.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.51.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.51.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.51.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.51.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.51.0") -- Found KF5KCMUtils: /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.51.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx added a comment.


  Any updates on whether this patch could be merged? It has been a long wait. 
If there are any improvements I can make to the patch I will be more than happy 
to put more work into it.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson
Cc: garywang, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15504: [Output Config] Fix transformation matrix for rotation icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: gladhorn, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The rotate left/right icons were erroneously mirrored as well

TEST PLAN
  Tilted my head, ensured the sun/moon was always on top left corner of the icon
  
  Before
  F6263471: Screenshot_20180914_132429.png 

  After
  F6263474: Screenshot_20180914_132725.png 

  
  (the fact that the "no rotation" icon looks different is a high dpi issue and 
unrelated to this patch)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D15504

AFFECTED FILES
  kcm/src/outputconfig.cpp

To: broulik, gladhorn, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Roman Gilg]

romangg added a comment.


  In D7038#134955 , @graesslin wrote:
  
  > I like that refactoring 👍 - though processAt might not be the best fitting 
name. Don't have a good name idea, maybe findChildSurfaceAt?
  
  
  Maybe `findSurfaceHelper`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D15498: Workaround QTBUG-47066 to fix crash on startup

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  The lambda returns a QStringBuilder which contains dangling references.
  Work around that by converting to QString inside the lambda's context.

TEST PLAN
  Does not crash anymore.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D15498

AFFECTED FILES
  src/sddmkcm.cpp

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Alexander Potashev]

aspotashev added a comment.


  We already have tabsrunner/Messages.sh so adding this Messages.sh will 
extract the messages from tabsrunner/* twice.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15495

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: aspotashev, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Alright, will move it to the reminder then

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15495

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: aspotashev, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Kai Uwe Broulik]

broulik updated this revision to Diff 41620.
broulik added a comment.


  Fix typo..

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15495?vs=41619&id=41620

REVISION DETAIL
  https://phabricator.kde.org/D15495

AFFECTED FILES
  CMakeLists.txt
  Messages.sh

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Luigi Toscano]

ltoscano added a comment.


  Correct: the names should be different, and so the domains.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15495

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Kai Uwe Broulik]

broulik updated this revision to Diff 41619.
broulik added a comment.


  Rename to `plasma-browser-integration-native`
  I could have moved it to the host but I fear we will forget again should we 
ever use `i18n` in the host (which I did at one point)

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15495?vs=41604&id=41619

REVISION DETAIL
  https://phabricator.kde.org/D15495

AFFECTED FILES
  CMakeLists.txt
  Messages.sh

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in surface_interface.cpp:819
> position is a float

So, it would be fine to return `true` in the following case:

  QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10));

?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D15197: Clarify docs in startkde about shtudown

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:af66555b0ab0: Clarify docs in startkde about shtudown 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15197?vs=40804&id=41613

REVISION DETAIL
  https://phabricator.kde.org/D15197

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: davidedmundson, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15178: Reload list of wallpaper types on install/uninstall

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5545214d4420: Reload list of wallpaper types on 
install/uninstall (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15178?vs=40727&id=41614

REVISION DETAIL
  https://phabricator.kde.org/D15178

AFFECTED FILES
  shell/containmentconfigview.cpp

To: davidedmundson, #plasma, apol
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in surface_interface.cpp:819
> Shouldn't it be QRect instead?

position is a float

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 38 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/38/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 14 Sep 2018 08:10:11 +
 Build duration:
5 min 42 sec and counting

D15201: Move logout-greeter into it's own subdir out of ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 41608.
davidedmundson added a comment.


  Update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15201?vs=40813&id=41608

BRANCH
  dave2

REVISION DETAIL
  https://phabricator.kde.org/D15201

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt
  ksmserver/logout-greeter/CMakeLists.txt
  ksmserver/logout-greeter/main.cpp
  ksmserver/logout-greeter/shutdowndlg.cpp
  ksmserver/logout-greeter/shutdowndlg.h
  ksmserver/logout-greeter/tests/CMakeLists.txt
  ksmserver/logout-greeter/tests/main.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/main.cpp
  logout-greeter/shutdowndlg.cpp
  logout-greeter/shutdowndlg.h
  logout-greeter/tests/CMakeLists.txt
  logout-greeter/tests/config.h.cmake
  logout-greeter/tests/main.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[David Edmundson]

davidedmundson added a comment.


  According to https://websvn.kde.org/trunk/l10n-kf5/scripts/   
update_translations  it seems both Messages.sh and StaticMessages.sh will be 
invoked.
  
  But I don't think we can use the same .pot name.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15495

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15495: Add Messages.sh

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, Localization, aacid.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We have translatable strings in the reminder c++ code.

TEST PLAN
  We have a `StaticMessages.sh` that also writes into 
`plasma-browser-integration.pot`, not sure how this works together. Else we 
could make a dedicated `Messages.sh` just for said reminder component

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D15495

AFFECTED FILES
  CMakeLists.txt
  Messages.sh

To: broulik, #plasma, davidedmundson, #localization, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> surface_interface.cpp:819
> +
> +return !size.isEmpty() && QRectF(QPoint(0, 0), size).contains(position);
> +}

Shouldn't it be QRect instead?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: zzag, kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, 
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein