D15093: Add WireGuard capability.

2018-09-17 Thread Jan Grulich 
jgrulich added a comment.


  In D15093#327889 , @andersonbruce 
wrote:
  
  > Since I added a validator function for the WireGuard style keys, is there 
any way to assign a validator to the PasswordField widget without a fairly 
substantial rewrite of that class?
  
  
  We don't do validation inside the passwordfield widget, this is done outside 
in widgets using it, you should do the same. Given it's a QWidget, you cannot 
directly assign a validator to it, but inside is QLineEdit which can have 
validator, you would have add a method to the main class which would just 
assign the validator to the QLineEdit widget inside, still please do the 
validation outside.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-17 Thread Pino Toscano 
pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  note there are still few "not done" comments around (eg using QSpinBox for 
fwMark)

INLINE COMMENTS

> CMakeLists.txt:28
>  Widgets
> +Test
>  )

already added by D15520: Upgrade SimpleIpV4AddressValidator and 
SimpleIpV6AddressValidator 

> wireguard.cpp:139
> +
> +WireGuardKeyValidator keyValidator(this);
> +int keyPos = 0;

no need to specify `this` as parent, since it is on stack, and thus it will be 
deleted automatically

> wireguard.cpp:139-140
> +
> +WireGuardKeyValidator keyValidator(this);
> +int keyPos = 0;
> +

indent

> wireguard.cpp:177
> +if (!value.isEmpty()) {
> +int pos = 0;
> +SimpleIpListValidator validator(this,

since earlier there is a `keyPos` variable used for basically the same purpose 
(i.e. passing it to the `validate()` of validators), just move `pos` earlier in 
the function, and use one everywhere

> wireguardadvancedwidget.cpp:26
> +
> +#include 
> +#include 

unused

> wireguardadvancedwidget.cpp:31
> +#include 
> +#include 
> +#include 

unused

> wireguardadvancedwidget.cpp:120
> +NMStringMap data;
> +long intVal;
> +QString stringVal;

a bit confusing to call `intVal` a variable which is (not correctly) a long; 
OTOH, it can be removed altogether (see below)

> wireguardadvancedwidget.cpp:121
> +long intVal;
> +QString stringVal;
> +

unused

> wireguardadvancedwidget.cpp:123-127
> +intVal = m_ui->listenPortSpinBox->value();
> +setOrClear(data, QLatin1String(NM_WG_KEY_LISTEN_PORT), intVal);
> +
> +intVal = m_ui->mtuSpinBox->value();
> +setOrClear(data, QLatin1String(NM_WG_KEY_MTU), intVal);

just inline the calls to `value()`, just like done below

> wireguardadvancedwidget.h:27
> +#include 
> +#include 
> +

unused

> wireguardkeyvalidator.h:26
> +
> +class Q_DECL_EXPORT WireGuardKeyValidator : public QValidator
> +{

no need for `Q_DECL_EXPORT`, as it is in a plugin, and thus it does not need to 
be exported as public symbol

> pino wrote in wireguardwidget.cpp:182
> no need for the (...) for the whole condition:
> 
>   return foo || bar;
> 
> is easier than
> 
>   return (foo || bar);

this is not "done", btw

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

2018-09-17 Thread Bruce Anderson 
andersonbruce updated this revision to Diff 41878.
andersonbruce added a comment.


  - Remove unnecessary includes and member functions

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15520?vs=41875&id=41878

BRANCH
  IP4/6validatorsUpdate

REVISION DETAIL
  https://phabricator.kde.org/D15520

AFFECTED FILES
  CMakeLists.txt
  libs/editor/CMakeLists.txt
  libs/editor/simpleiplistvalidator.cpp
  libs/editor/simpleiplistvalidator.h
  libs/editor/simpleipv4addressvalidator.cpp
  libs/editor/simpleipv4addressvalidator.h
  libs/editor/simpleipv6addressvalidator.cpp
  libs/editor/simpleipv6addressvalidator.h
  tests/CMakeLists.txt
  tests/simpleiplisttest.cpp
  tests/simpleipv4test.cpp
  tests/simpleipv6test.cpp

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

2018-09-17 Thread Pino Toscano 
pino added a comment.


  - please remove all the empty `initTestCase()` in tests

INLINE COMMENTS

> simpleiplistvalidator.cpp:27-28
> +SimpleIpListValidator::SimpleIpListValidator(QObject *parent,
> +   AddressStyle style,
> +   AddressType type)
> +: QValidator(parent)

indentation

> simpleiplistvalidator.cpp:64
> +// Split the incoming address on commas possibly with spaces on either 
> side
> +QStringList addressList = address.split(QRegularExpression("\\s*,\\s*"));
> +

once again, simple char split with trim, please; you can use both splitRef + 
trimmed with QStringRef, so there is almost no waste of memory
using a regexp for a simple task like this is that it's way slower than using a 
simple character as separator

> simpleiplistvalidator.cpp:69
> +int localPos = 0;
> +int i = 0;
> +QValidator::State result = QValidator::Acceptable;

the variable `i` is only incremented, and never used

> simpleipv4addressvalidator.cpp:93
>  // lets check address parts
> -Q_FOREACH (const QStringRef &part, addrParts) {
> +for (const QStringRef &part : addrParts) {
>  if (part.isEmpty()) {

while this change is OK, please do not mix it together with this patch

> simpleipv6addressvalidator.cpp:48-50
> +if (QValidator::Invalid == checkWithInputMask(address, pos))
>  return QValidator::Invalid;
>  

unrelated changes

> simpleipv6addressvalidator.cpp:112
>  int i = 1;
> -Q_FOREACH (QString part, addrParts) { // krazy:exclude=Q_FOREACH 
> +for (QString part : addrParts) { // krazy:exclude=Q_FOREACH 
>  if (part.isEmpty() && i < number) {

as above, unrelated change

> simpleipv4test.cpp:23
> +#include 
> +#include 
> +

unused

> simpleipv6test.cpp:23
> +#include 
> +#include 
> +

unused

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15520

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-17 Thread Bruce Anderson 
andersonbruce added a comment.


  Since I added a validator function for the WireGuard style keys, is there any 
way to assign a validator to the PasswordField widget without a fairly 
substantial rewrite of that class?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

2018-09-17 Thread Bruce Anderson 
andersonbruce added a comment.


  In D15521#327222 , @jgrulich wrote:
  
  > Maybe merge this review with D15520 . I 
think they should go together.
  
  
  I believe that I have now moved all the changes from this review into review 
D15520  so this review can be deleted or 
marked obsolete or whatever you want to do with it.  I also believe that all of 
the comments made here have been addressed in the changes updated to D15520 
.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15521

To: andersonbruce, jgrulich, pino
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

2018-09-17 Thread Bruce Anderson 
andersonbruce updated this revision to Diff 41875.
andersonbruce added a comment.


  - Merge new IP list validator into this branch
  - Update from review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15520?vs=41677&id=41875

BRANCH
  IP4/6validatorsUpdate

REVISION DETAIL
  https://phabricator.kde.org/D15520

AFFECTED FILES
  CMakeLists.txt
  libs/editor/CMakeLists.txt
  libs/editor/simpleiplistvalidator.cpp
  libs/editor/simpleiplistvalidator.h
  libs/editor/simpleipv4addressvalidator.cpp
  libs/editor/simpleipv4addressvalidator.h
  libs/editor/simpleipv6addressvalidator.cpp
  libs/editor/simpleipv6addressvalidator.h
  tests/CMakeLists.txt
  tests/simpleiplisttest.cpp
  tests/simpleipv4test.cpp
  tests/simpleipv6test.cpp

To: andersonbruce, jgrulich, pino
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-17 Thread Bruce Anderson 
andersonbruce updated this revision to Diff 41874.
andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  - Remove changes moved to review D15520 

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15093?vs=41736&id=41874

BRANCH
  Feature/AddWireGuardVPN

REVISION DETAIL
  https://phabricator.kde.org/D15093

AFFECTED FILES
  CMakeLists.txt
  libs/models/kcmidentitymodel.cpp
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15578: [Notifications] Store "Open..." action in history

2018-09-17 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a8b71fe5c017: [Notifications] Store "Open..." 
action in history (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15578?vs=41845&id=41854

REVISION DETAIL
  https://phabricator.kde.org/D15578

AFFECTED FILES
  applets/notifications/package/contents/ui/Notifications.qml

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15578: [Notifications] Store "Open..." action in history

2018-09-17 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> Notifications.qml:95
> +var actions = notification.actions.filter(function (item) {
> +return item.id.indexOf("jobUrl#") === 0;
> +});

eww.

I hope it's not like this after the refactor

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15578

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15578: [Notifications] Store "Open..." action in history

2018-09-17 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Actions stop working when the original notification goes away, however the 
"Open..." notification when a job completed is added and handled by us, so we 
can store it in the history and it will continue to function.
  
  BUG: 398732
  FIXED-IN: 5.14.0

TEST PLAN
  - Copied a file, finished, the notification in the history had an "Open" 
button that worked
  - Tested some other notifications, their actions were all removed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15578

AFFECTED FILES
  applets/notifications/package/contents/ui/Notifications.qml

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15504: [Output Config] Fix transformation matrix for rotation icon

2018-09-17 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:fca1c2f25657: [Output Config] Fix transformation matrix 
for rotation icon (authored by broulik).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15504?vs=41635&id=41835

REVISION DETAIL
  https://phabricator.kde.org/D15504

AFFECTED FILES
  kcm/src/outputconfig.cpp

To: broulik, gladhorn, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15571: Sync attribution metadata for SDDM theme to LNF

2018-09-17 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6234aaa3680b: Sync attribution metadata for SDDM theme to 
LNF (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15571?vs=41816&id=41819

REVISION DETAIL
  https://phabricator.kde.org/D15571

AFFECTED FILES
  sddm-theme/metadata.desktop

To: davidedmundson, #plasma, bshah
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15571: Sync attribution metadata for SDDM theme to LNF

2018-09-17 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It had my name for historic reasons before moving about, but given
  Plasma ships it, it should have group attribution.

TEST PLAN
  N/A

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15571

AFFECTED FILES
  sddm-theme/metadata.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 379022] Update Task Switcher screenshots

2018-09-17 Thread Alexander Mentyu 
https://bugs.kde.org/show_bug.cgi?id=379022

Alexander Mentyu  changed:

   What|Removed |Added

 CC||tterrani...@gmail.com

--- Comment #5 from Alexander Mentyu  ---
*** Bug 394285 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Meeting notes for 17/09/2018

2018-09-17 Thread Marco Martin 
Eike:
* [General] Various last-minute code reviews and landings of important
pending patches for 5.14 beta
* [TM] Another LibreOffice workaround: Starting a sub-app from the
LibreOffice start center will now correctly hide a pinned launcher for
the app
* [TM] Fixed reordering tasks by DND in a group popup window also
reordering top-level tasks
* [TM] Fixed a regression causing improper sorting of new startup
notifications in "allow mixing tasks and launchers" config mode (still
on phab review)
* [SysSe] Finished a patch by Harald to fix adding new UI languages in
the KCM in a fresh empty user account


Kai Uwe:
Work done:
 - Various fixes for Dolphin
 -- Unsuccessful fix for Dolphin creating thumbnails for certain files
twice (e.g. the first visible item)
 -- Update "Free space info" less frequently
 --- Checks every 10 seconds, regardless of whether the window is
active or whether it's a remote drive
 --- causes disks to spin up repeatedly, network activity, CPU wakeups, etc
 --- Please check out D15506 D15507 D15508 (especially sitter)
 Diff 15506 "RFC: [StatusBarSpaceInfo] Only update when window is
active" [Needs Review] https://phabricator.kde.org/D15506
 Diff 15507 "[MountPointObserverCache] Update remote and slow mounts
less frequently" [Needs Review] https://phabricator.kde.org/D15507
 Diff 15508 "Update disk space info on refresh" [Accepted]
https://phabricator.kde.org/D15508
 - Added various KCM shortcuts to runner config
 -- Spellcheck runner → Spellchecking KCM, Webshortcuts runner →
Webshortcuts KCM
 - Made libdbusmenu-qt less chatty (categorized logging)
 - Solid uses device label also for loop devices (e.g. mounted ISO
file will show the CD's label now instead of the ISO filename)
 - Translation fix for plasma-browser-integration (reminder didn't
have Messages.sh)
 - Fixed breakage in Breeze widget style not detecting QtQuick
controls (e.g. ComboBox popup was unstyled and unreadable again)
 Work todo:
 - Upload new plasma-browser-integration version
 - Figure out why my LibreOffice Writer isn't properly identified in
Task Manager
 - Fix (work around) Ark opening ODT and DOCX files (that are
technically archives but not from a user's POV) as archives
 - Plasma 5.14 Beta bug squashing, triaging, fallout (the breeze
breakage was one of them)


David:
* Identified and "fixed" the recurrent discover crash report, which
was caused by an ABI break. Fortuntely on nothing released.
* I have some wayland patches that fix the behaviour of the
configure->ack requests. So if you resize a window to the left it'll
now be in sync. The old code just updated whenever we had a new
buffer.
Also fixed maximise effects on wayland (which is broke as the order of
resizing is different to X)
* I've been testing the firefox wayland which has issues on kwin (have
git latest firefox, and latest gtk and tonnes of printfs) we have two
major issues. One is now resolved, other I still have to identify.
* I've got some patches that chip away at ksmserver. My longterm goal
is to turn that into /just/ an XSessionManager and nothing else.


Roman:
What I did since last week:
-
* Refactoring of touch interface usage in KWayland: D15443
  Diff 15443 "[server] Allow multiple touch interfaces per client"
[Needs Review] https://phabricator.kde.org/D15443
* Worked on drag support in KWayland and KWin D15464 D15466
  Diff 15464 "[server] Touch drag support" [Needs Review]
https://phabricator.kde.org/D15464
  Diff 15466 "Add Wayland touch drag and drop support" [Needs Review]
https://phabricator.kde.org/D15466
* Some small code improvements to KWin.
* Wayland socket argument to startplasmacompositor script: D15512
  Diff 15512 "[startplasmacompositor] Add Wayland socket argument"
[Needs Review] https://phabricator.kde.org/D15512
* InputRedirection refactoring.
--
What I want to do now:
--
* Finish patch for InputRedirection refactoring.
* I postponed my last Xwl dnd patch, because I wanted to first rework
the InputRedirection (and there is one last bug with Chrome). But I
will upload it this week in any case since I'm not around next week
all the time.
---
Questions/Problems:
---
* I need some diffs getting reviewed. Some of them are pretty small:
D15502, D15519
  Diff 15502 "Float position values in drag input filter" [Needs
Review] https://phabricator.kde.org/D15502
 Diff 15519 "Privatize variables in InputDeviceHandler" [Needs Review]
https://phabricator.kde.org/D15519
* Wayland socket arguemnt in D15512: I would like to get this merged.
It already improved my workflow drastically when testing a full
Wayland session because I can have the other one still running. The
argument by fvogt KWin should just take a next free socket is valid I
believe, but I don't see why we can't have both. In particular because
the one solution with the argument is available now / already
supported by KWin and the other
  Diff 15512 "[startplasmacompositor] Ad

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

2018-09-17 Thread Bruce Anderson 
andersonbruce added inline comments.

INLINE COMMENTS

> jgrulich wrote in simpleiplistvalidator.cpp:39
> In both validator constructors (mean also for IPv6 one), you can directly 
> pass "style" param from contructor, given both enums seem to be identical.

They are the same now but initially they were not (I just added the WithPort 
option to IPv6) and my thought was that they may not necessarily stay identical 
in the future. If someone goes in and changes, say, the IPv4 version without 
realizing it affects the list validator, this code still works.

> pino wrote in simpleiplistvalidator.cpp:62
> no need for a regexp, please use `QString::split()` with 
> `QString::SkipEmptyParts`

I used the regex so that it would split on commas with or without spaces around 
them and how I read SkipEmptyParts is that it will drop something between two 
adjacent commas which is not what I was trying to do. 
Now I know that I could use "trimmed()" on the resulting strings to strip off 
any remaining spaces but I don't see any advantage to either using "trimmed()" 
every time I use one of the resulting strings or doing it once and creating 
another local copy of the strings for this purpose. It seemed to me that doing 
everything in one step was a just as viable approach unless there is something 
inherently bad with splitting on a regex that I am not aware of, especially 
given that I commented it to explain what it is doing.

> pino wrote in simpleiplistvalidator.cpp:67
> set (later on), but never use

I don't understand this comment. 'result' is set here to Acceptable, it can be 
modified to Intermediate at line 102 but if all the addresses are valid it 
needs to have been set initially to Acceptable for the return at line 106 to be 
correct.

> pino wrote in simpleiplisttest.cpp:53
> `QVERIFY(foo == bar)` -> `QCOMPARE(foo, bar)`, it applies to all the checks 
> in this file

Any particular reason you think this is superior?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15521

To: andersonbruce, jgrulich, pino
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

2018-09-17 Thread Jan Grulich 
jgrulich added a comment.


  Please, update all your reviews so they don't duplicate changes. I would 
personally have one review for all your IPv[4,6]Validator changes and one 
review just for WireGuard VPN plugin.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15568: Fix finding QtQuick

2018-09-17 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:3e8eac8fc461: Fix finding QtQuick (authored by broulik).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15568?vs=41796&id=41799

REVISION DETAIL
  https://phabricator.kde.org/D15568

AFFECTED FILES
  kstyle/CMakeLists.txt

To: broulik, #plasma, tundracomp, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

2018-09-17 Thread Vlad Zagorodniy 
zzag added a comment.


  Any update on this?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin
Cc: zzag, romangg, anthonyfieroni, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D15568: Fix finding QtQuick

2018-09-17 Thread Hugo Pereira Da Costa 
hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks for tracking this down !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15568

To: broulik, #plasma, tundracomp, hpereiradacosta
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15568: Fix finding QtQuick

2018-09-17 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, tundracomp.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is `QtQuick_FOUND`, not `Qt_Quick_FOUND`. This broke all special-casings 
for QtQuick, such as "drag on empty area" in QtQuick windows and ComboBox 
popups.
  
  BUG: 398663
  FIXED-IN: 5.14.0

TEST PLAN
  Compiles. QtQuick Controls 1 Dropdowns are fine again in Breeze Dark and 
dragging e.g. wallpaper dialog on empty area works again

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15568

AFFECTED FILES
  kstyle/CMakeLists.txt

To: broulik, #plasma, tundracomp
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart