D15824: [Folder View] Fix right/left arrow navigation in popup mode

2018-10-05 Thread Thomas Surrel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0337f979189c: [Folder View] Fix right/left arrow 
navigation in popup mode (authored by thsurrel).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15824?vs=42528&id=42961

REVISION DETAIL
  https://phabricator.kde.org/D15824

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: thsurrel, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-10-05 Thread Eike Hein 
hein added a reviewer: ltoscano.
hein added a comment.


  Adding Luigi due to the .pot rename caused by this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-10-05 Thread Eike Hein 
hein added a comment.


  Forgot to mention it, but I also did the folder move/rename so this KCM now 
replaces the old one.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-05 Thread Nathaniel Graham 
ngraham added a comment.


  That looks really sweet.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15840: [Folder View] Remember selected item when navigating in subfolders

2018-10-05 Thread Eike Hein 
hein added a comment.


  I like the goal here, but it's not a given the stored index is still valid 
when navigating back - the folder contents could have changed. It'd be hygienic 
to bound the access when popping from the history.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15840

To: thsurrel, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15855: Port Kickoff to shared view component using single-MouseArea pattern

2018-10-05 Thread Eike Hein 
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in KickoffListView.qml:57
> This already is a focusScope
> 
> could this not be the root item?

I don't think so because I need the MouseArea to cover the ScrollArea, but the 
ScrollArea has to manage its single child (the ListView). I could do zany 
things like parent the MA to the ListView and z-order it above the contentItem 
but it's kinda brittle. Compared to having a MA in every single delegate, it's 
still a handy win on fewer objects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15855

To: hein, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-10-05 Thread Eike Hein 
hein updated this revision to Diff 42958.
hein edited the summary of this revision.
hein added a comment.


  - Remove copied code.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=42898&id=42958

BRANCH
  arcpatch-D13887_2

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/org.kde.kwin.virtualdesktopmanager.xml
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.14.0 release tars updated

2018-10-05 Thread Bhushan Shah 
Hello Packagers,

This is follow up to the 5.14.0 tars availability announced by the
Jonathan,

Unfortunately previously uploaded tarballs missed the translations
completely, and we needed to re-do tars, since Jonathan is traveling
today, I have made tars and signed with my key (fingerprint in signature
of the message).

shasum of newly uploaded tars is available on info page[1]. Public
release is on next tuesday.

[1] https://www.kde.org/info/plasma-5.14.0.php 

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-05 Thread Chris Holland 
Zren updated this revision to Diff 42950.
Zren added a comment.


  - Got rid of the signal+slot that emits KNewStuff changes since 
wallpaperComboBox is automagically updated.
  - Reordered the command arguments so the variable is last in 
`wallpaperplugin.knsrc`.
  - Put the `plasmoids.knsrc` and `wallpaperplugin.knsrc` filepaths on separate 
lines in the `CMakeList.txt`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=33951&id=42950

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-05 Thread Chris Holland 
Zren added a comment.


  Finally got around to updating this patch and formally testing with 
`kdesrc-build` (sort of) in Neon Unstable which has Frameworks 5.51.
  
  F6306500: screen-2018-10-05_16.35.50.mp4 

  
  Updated diff incoming as soon as I figure out how to diff 
`~/kde/src/.../plasma-workspace` since they aren't git repos.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Several warnings on Qt 5.12

2018-10-05 Thread Aleix Pol 
Hi,
I've seen a bunch of warnings when running plasmashell under Qt 5.12.
I haven't had time to look into it but it looks legit. Possibly a
matter of using the right namespacing.

Cheers!
Aleix

Previously registered enum will be overwritten due to name clash:
PlasmaQuick::Dialog.FullScreen
Possible conflicting items:
Plasma::Types.Location.FullScreen from scope Plasma::Types
injected by PlasmaQuick::Dialog->Plasma::Types
PlasmaQuick::Dialog.Visibility.FullScreen from scope QWindow
injected by PlasmaQuick::Dialog
Previously registered enum will be overwritten due to name clash:
PlasmaQuick::Dialog.NoBackground
Possible conflicting items:
Plasma::Types.BackgroundHints.NoBackground from scope
Plasma::Types injected by PlasmaQuick::Dialog->Plasma::Types
PlasmaQuick::Dialog.BackgroundHints.NoBackground from scope
PlasmaQuick::Dialog injected by PlasmaQuick::Dialog
Previously registered enum will be overwritten due to name clash:
PlasmaQuick::Dialog.StandardBackground
Possible conflicting items:
Plasma::Types.BackgroundHints.StandardBackground from scope
Plasma::Types injected by PlasmaQuick::Dialog->Plasma::Types
PlasmaQuick::Dialog.BackgroundHints.StandardBackground from scope
PlasmaQuick::Dialog injected by PlasmaQuick::Dialog
Previously registered enum will be overwritten due to name clash:
DesktopView.FullScreen
Possible conflicting items:
DesktopView.Visibility.FullScreen from scope QWindow injected by DesktopView
DesktopView.WindowType.FullScreen from scope DesktopView injected
by DesktopView
Previously registered enum will be overwritten due to name clash:
QQuickGridView.Center
Possible conflicting items:
QQuickGridView.TransformOrigin.Center from scope QQuickItem
injected by QQuickGridView
QQuickGridView.PositionMode.Center from scope QQuickItemView
injected by QQuickGridView
Previously registered enum will be overwritten due to name clash:
QQuickGridView.Center
Possible conflicting items:
QQuickGridView.TransformOrigin.Center from scope QQuickItem
injected by QQuickGridView
QQuickGridView.PositionMode.Center from scope QQuickItemView
injected by QQuickGridView

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 23 - Failure!

2018-10-05 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/23/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 05 Oct 2018 17:29:33 +
 Build duration:
6 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 177.24 KB...][ 16%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/PackageState.cpp.o[ 17%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesUpdatesModel.cpp.o[ 18%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StandardBackendUpdater.cpp.o[ 19%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/SourcesModel.cpp.o[ 20%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResourcesBackend.cpp.o[ 21%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResource.cpp.o[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractBackendUpdater.cpp.o[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/CachedNetworkAccessManager.cpp.o[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/libdiscover_debug.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/OdrsReviewsBackend.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/AppStreamIntegration.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[ 32%] Linking CXX shared library ../bin/libDiscoverCommon.so[ 32%] Built target DiscoverCommonScanning dependencies of target DiscoverNotifiers[ 32%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[ 33%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[ 34%] Linking CXX shared library ../../bin/libDiscoverNotifiers.so[ 34%] Built target DiscoverNotifiersScanning dependencies of target PaginateModelTest[ 35%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[ 36%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[ 37%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/discover_debug.cpp.o[ 38%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/tests/modeltest.cpp: In member function ���void ModelTest::data()���:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/tests/modeltest.cpp:429:30: warning: comparison of integer expressions of different signedness: ���int��� and ���QFlags::Int��� {aka ���unsigned int���} [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 39%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 40%] Linking CXX executable ../../bin/PaginateModelTest[ 40%] Built target PaginateModelTestScanning dependencies of target plasma-discover-exporter_autogen[ 40%] Automatic MOC for target plasma-discover-exporter[ 40%] Built target plasma-discover-exporter_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[ 41%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[ 41%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target kns-backend_autogen[ 42%] Automatic MOC for target kns-backend[ 42%] Built target kns-backend_autogenScanning dependencies of target knsbackendtest_autogen[ 42%] Automatic MOC for target knsbackendtest[ 42%] Built target knsbackendtest_autogenScanning dependencies of target DummyNotifier_autogen[ 42%] Automatic MOC for target DummyNotifier[ 42%] Built target DummyNotifier_autogenScanning dependencies of target dummy

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Ambareesh Balaji 
abalaji added a comment.


  @davidedmundson awesome! I've been running around in circles trying to find 
this, glad that you fixed it! Although I'm the future we should support this 
properly.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: abetts, rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15969: Add support for systemd's suspend-then-hibernate

2018-10-05 Thread Alexander Volkov 
volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15969

AFFECTED FILES
  daemon/actions/bundled/handlebuttoneventsconfig.cpp
  
daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.SuspendSession.xml
  daemon/actions/bundled/suspendsession.cpp
  daemon/actions/bundled/suspendsession.h
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/backends/upower/login1suspendjob.cpp
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/org.freedesktop.PowerManagement.xml
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilfdoconnector.cpp
  daemon/powerdevilfdoconnector.h
  daemon/powerdevilpowermanagement.cpp
  daemon/powerdevilpowermanagement.h

To: volkov
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-10-05 Thread Marco Martin 
mart added a comment.


  once it uses the common dbus type, good to go for me, just rename it, 
eliminating the old kcm

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: WIP: Basic KCM using new virtual desktops DBus interface

2018-10-05 Thread Marco Martin 
mart added a comment.


  I think the last fixme is actually not a fixme.
  dbus structs moved in vitualdesktopsdbustypes.h

INLINE COMMENTS

> main.qml:176
> +
> +Item { // FIXME TODO: Quick gross spacing hack.
> +Layout.fillWidth: true

Actually, that's the way rowlayouts are supposed to work, having empty items as 
spacers.
It mirrors the way QLayouts work, where the spacer is a dedicated item/class

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Andres Betts 
abetts added a comment.


  In D15942#337137 , @broulik wrote:
  
  > No, not with a finger or pen. We should support this, yes, but not in the 
way it's currently done by synthesized mouse events.
  
  
  Sounds good! Thanks for the update!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: abetts, rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Kai Uwe Broulik 
broulik added a comment.


  No, not with a finger or pen. We should support this, yes, but not in the way 
it's currently done by synthesized mouse events.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: abetts, rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Andres Betts 
abetts added a comment.


  Would this ensure that, at least, you can drag a window from the top area, 
like the toolbar, menu and the title bar empty areas?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: abetts, rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Plasma 5.14.0 tars available for packaging

2018-10-05 Thread Bernhard Rosenkraenzer 
Hi,
some tarballs (at least user-manager, libksysguard, milou -- probably others, 
test build isn't finished yet) seem to be missing translation files that were 
included before -- is this intentional (do we need separate l10n/i18n tarballs 
again?), or by mistake?

ttyl
bero

On Thursday, October 04, 2018 19:15 CEST, Jonathan Riddell  
wrote:

> Plasma 5.14.0 tars are on racnoss available for packagers to package
> in their distros and release on Tuesday
>
> Jonathan

KDE CI: Plasma » oxygen » kf5-qt5 SUSEQt5.11 - Build # 10 - Fixed!

2018-10-05 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20SUSEQt5.11/10/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 05 Oct 2018 13:00:44 +
 Build duration:
9 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/9)0%
(0/181)0%
(0/181)0%
(0/12877)0%
(0/8932)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskdecoration0%
(0/11)0%
(0/11)0%
(0/830)0%
(0/517)kdecoration.config0%
(0/14)0%
(0/14)0%
(0/477)0%
(0/251)kstyle0%
(0/21)0%
(0/21)0%
(0/6277)0%
(0/5017)kstyle.animations0%
(0/61)0%
(0/61)0%
(0/2016)0%
(0/1498)kstyle.config0%
(0/7)0%
(0/7)0%
(0/340)0%
(0/206)kstyle.debug0%
(0/2)0%
(0/2)0%
(0/70)0%
(0/27)kstyle.demo0%
(0/25)0%
(0/25)0%
(0/1080)0%
(0/423)kstyle.transitions0%
(0/22)0%
(0/22)0%
(0/594)0%
(0/463)liboxygen0%
(0/18)0%
(0/18)0%
(0/1193)0%
(0/530)

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.11 - Build # 18 - Fixed!

2018-10-05 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.11/18/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 05 Oct 2018 12:58:53 +
 Build duration:
2 min 58 sec and counting

KDE CI: Plasma » oxygen » kf5-qt5 SUSEQt5.11 - Build # 9 - Failure!

2018-10-05 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20SUSEQt5.11/9/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 05 Oct 2018 12:52:42 +
 Build duration:
8 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 298.39 KB...] typedef Q_DECL_DEPRECATED QStyleOptionTab QStyleOptionTabV3;   ^/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp: In member function ���virtual bool Oxygen::Style::drawTabBarTabShapeControl_unselected(const QStyleOption*, QPainter*, const QWidget*) const���:/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:6306:34: warning: ���QStyleOptionTabV3��� is deprecated [-Wdeprecated-declarations] const QStyleOptionTabV3 *tabOptV3 = qstyleoption_cast( option );  ^~~~In file included from /usr/include/qt5/QtWidgets/QStyleOption:1, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.h:63, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:49:/usr/include/qt5/QtWidgets/qstyleoption.h:295:43: note: declared here typedef Q_DECL_DEPRECATED QStyleOptionTab QStyleOptionTabV3;   ^/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:6306:87: warning: ���QStyleOptionTabV3��� is deprecated [-Wdeprecated-declarations] const QStyleOptionTabV3 *tabOptV3 = qstyleoption_cast( option );   ^In file included from /usr/include/qt5/QtWidgets/QStyleOption:1, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.h:63, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:49:/usr/include/qt5/QtWidgets/qstyleoption.h:295:43: note: declared here typedef Q_DECL_DEPRECATED QStyleOptionTab QStyleOptionTabV3;   ^/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp: In member function ���virtual bool Oxygen::Style::drawToolBoxTabShapeControl(const QStyleOption*, QPainter*, const QWidget*) const���:/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:6691:38: warning: ���QStyleOptionToolBoxV2��� is deprecated [-Wdeprecated-declarations] const QStyleOptionToolBoxV2 *v2 = qstyleoption_cast( option );  ^~In file included from /usr/include/qt5/QtWidgets/QStyleOption:1, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.h:63, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:49:/usr/include/qt5/QtWidgets/qstyleoption.h:479:47: note: declared here typedef Q_DECL_DEPRECATED QStyleOptionToolBox QStyleOptionToolBoxV2;   ^/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:6691:89: warning: ���QStyleOptionToolBoxV2��� is deprecated [-Wdeprecated-declarations] const QStyleOptionToolBoxV2 *v2 = qstyleoption_cast( option ); ^In file included from /usr/include/qt5/QtWidgets/QStyleOption:1, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.h:63, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:49:/usr/include/qt5/QtWidgets/qstyleoption.h:479:47: note: declared here typedef Q_DECL_DEPRECATED QStyleOptionToolBox QStyleOptionToolBoxV2;   ^/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp: In member function ���virtual bool Oxygen::Style::drawDockWidgetTitleControl(const QStyleOption*, QPainter*, const QWidget*) const���:/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:6800:41: warning: ���QStyleOptionDockWidgetV2��� is deprecated [-Wdeprecated-declarations] const QStyleOptionDockWidgetV2 *v2 = qstyleoption_cast( option ); ^~In file included from /usr/include/qt5/QtWidgets/QStyleOption:1, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.h:63, from /home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.11/kstyle/oxygenstyle.cpp:49:/usr/include/qt5/QtWidgets/qstyleoption.h:398:50: note: declared here typedef Q_DECL_DEPRECATED QStyleOptionDockWidget QStyleOptionDockWidgetV2;  ^~~~/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 SUSEQt5.1

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

2018-10-05 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.11/9/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 05 Oct 2018 12:55:02 +
 Build duration:
2 min 1 sec and counting

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Failure!

2018-10-05 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.11/8/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 05 Oct 2018 12:52:42 +
 Build duration:
1 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 336.81 KB...]/usr/local/include/qt5/QtWidgets/qstyleoption.h:479:9: note: 'QStyleOptionToolBoxV2' has been explicitly marked deprecated heretypedef Q_DECL_DEPRECATED QStyleOptionToolBox QStyleOptionToolBoxV2;^/usr/local/include/qt5/QtCore/qcompilerdetection.h:230:45: note: expanded from macro 'Q_DECL_DEPRECATED'#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenstyle.cpp:6691:15: warning: 'QStyleOptionToolBoxV2' is deprecated [-Wdeprecated-declarations]const QStyleOptionToolBoxV2 *v2 = qstyleoption_cast( option );  ^/usr/local/include/qt5/QtWidgets/qstyleoption.h:479:9: note: 'QStyleOptionToolBoxV2' has been explicitly marked deprecated heretypedef Q_DECL_DEPRECATED QStyleOptionToolBox QStyleOptionToolBoxV2;^/usr/local/include/qt5/QtCore/qcompilerdetection.h:230:45: note: expanded from macro 'Q_DECL_DEPRECATED'#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenstyle.cpp:6692:56: warning: 'QStyleOptionToolBoxV2' is deprecated [-Wdeprecated-declarations]if( v2 && v2->position == QStyleOptionToolBoxV2::Beginning && selected ) return true;   ^/usr/local/include/qt5/QtWidgets/qstyleoption.h:479:9: note: 'QStyleOptionToolBoxV2' has been explicitly marked deprecated heretypedef Q_DECL_DEPRECATED QStyleOptionToolBox QStyleOptionToolBoxV2;^/usr/local/include/qt5/QtCore/qcompilerdetection.h:230:45: note: expanded from macro 'Q_DECL_DEPRECATED'#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenstyle.cpp:6800:70: warning: 'QStyleOptionDockWidgetV2' is deprecated [-Wdeprecated-declarations]const QStyleOptionDockWidgetV2 *v2 = qstyleoption_cast( option ); ^/usr/local/include/qt5/QtWidgets/qstyleoption.h:398:9: note: 'QStyleOptionDockWidgetV2' has been explicitly marked deprecated heretypedef Q_DECL_DEPRECATED QStyleOptionDockWidget QStyleOptionDockWidgetV2;^/usr/local/include/qt5/QtCore/qcompilerdetection.h:230:45: note: expanded from macro 'Q_DECL_DEPRECATED'#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenstyle.cpp:6800:15: warning: 'QStyleOptionDockWidgetV2' is deprecated [-Wdeprecated-declarations]const QStyleOptionDockWidgetV2 *v2 = qstyleoption_cast( option );  ^/usr/local/include/qt5/QtWidgets/qstyleoption.h:398:9: note: 'QStyleOptionDockWidgetV2' has been explicitly marked deprecated heretypedef Q_DECL_DEPRECATED QStyleOptionDockWidget QStyleOptionDockWidgetV2;^/usr/local/include/qt5/QtCore/qcompilerdetection.h:230:45: note: expanded from macro 'Q_DECL_DEPRECATED'#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenstyle.cpp:7660:22: warning: unused variable 'dark' [-Wunused-variable]const QColor dark( _helper->calcDarkColor( color ) ); ^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenstyle.cpp:7661:22: warning: unused variable 'shadow' [-Wunused-variable]const QColor shadow( _helper->calcShadowColor( color ) ); ^1 warning generated.1 warning generated./usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenwindowmanager.cpp:516:13: error: use of undeclared identifier 'mouseEvent'if (mouseEvent->source() != Qt::MouseEventNotSynthesized)^/usr/home/jenkins/workspace/Plasma/oxygen/kf5-qt5 FreeBSDQt5.11/kstyle/oxygenwindowmanager.cpp:774:73: warning: 'QStyleOptionFrameV2' is deprecated [-Wdeprecated-declarations]if( groupBox->isFlat() ) opt.features |= QStyleOptionFrameV2::Flat;^/usr/local/include/qt5/QtWidgets/qstyleoption.h:152:9: note: 'QStyleOptionFrameV2' has been explicitly marked deprecated heretypedef Q_DECL_DEPRECATED QStyleOptionFrame QStyleOptionFrameV2;^/usr/local/include/qt5/QtCore/qcompilerdetection.h:230:45: note: expanded from macro 'Q_DECL_DEPRECATED'#  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))

D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-05 Thread David Edmundson 
davidedmundson added a comment.


  I would, then we'll at least be consistent across plasma code.

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.11 - Build # 17 - Failure!

2018-10-05 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.11/17/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 05 Oct 2018 12:43:32 +
 Build duration:
3 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 18.62 KB...] > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision c8778da8e413e549401e10613b1005e4317ff746 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f c8778da8e413e549401e10613b1005e4317ff746Commit message: "Create repository for KEuroCalc"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Plasma/breeze/kf5-qt5 FreeBSDQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a51f010a0a29859b328772fc53951d93efd18a09 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a51f010a0a29859b328772fc53951d93efd18a09Commit message: "Add dependency data for keurocalc"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[kf5-qt5 FreeBSDQt5.11] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project breeze --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.11 --installTo /home/jenkins/install-prefix/Retrieving: Plasma-extra-cmake-modules-kf5-qt5Retrieving: Plasma-karchive-kf5-qt5Retrieving: Plasma-ki18n-kf5-qt5Retrieving: Plasma-kcoreaddons-kf5-qt5Retrieving: Plasma-kwindowsystem-kf5-qt5Retrieving: Plasma-kconfig-kf5-qt5Retrieving: Plasma-kcrash-kf5-qt5Retrieving: Plasma-kdbusaddons-kf5-qt5Retrieving: Plasma-kdoctools-kf5-qt5Retrieving: Plasma-kservice-kf5-qt5Retrieving: Plasma-kcodecs-kf5-qt5Retrieving: Plasma-phonon-kf5-qt5Retrieving: Plasma-kauth-kf5-qt5Retrieving: Plasma-kguiaddons-kf5-qt5Retrieving: Plasma-kwidgetsaddons-kf5-qt5Retrieving: Plasma-kconfigwidgets-kf5-qt5Retrieving: Plasma-kitemviews-kf5-qt5Retrieving: Plasma-kcompletion-kf5-qt5Retrieving: Plasma-kiconthemes-kf5-qt5Retrieving: Plasma-sonnet-kf5-qt5Retrieving: Plasma-attica-kf5-qt5Retrieving: Plasma-kglobalaccel-kf5-qt5Retrieving: Plasma-ktextwidgets-kf5-qt5Retrieving: Plasma-breeze-icons-kf5-qt5Retrieving: Plasma-knotifications-kf5-qt5Retrieving: Plasma-kxmlgui-kf5-qt5Retrieving: Plasma-solid-kf5-qt5Retrieving: Plasma-kjobwidgets-kf5-qt5Retrieving: Plasma-kbookmarks-kf5-qt5Retrieving: Plasma-kwallet-kf5-qt5Retrieving: Plasma-kio-kf5-qt5Retrieving: Plasma-kparts-kf5-qt5Retrieving: Plasma-kplotting-kf5-qt5Retrieving: Plasma-kdewebkit-kf5-qt5Retrieving: Plasma-kinit-kf5-qt5Retrieving: Plasma-kunitconversion-kf5-qt5Retrieving: Plasma-kded-kf5-qt5Retrieving: Plasma-kemoticons-kf5-qt5Retrieving: Plasma-kdesignerplugin-kf5-qt5Retrieving: Plasma-syntax-highlighting-kf5-qt5Retrieving: Plasma-kpackage-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 71, in filename, metadata = packageArchive.retrievePackage( package )  File "/usr/home/jenkins/workspace/Plasma/breeze/kf5-qt5 FreeBSDQt5.11/ci-tooling/helpers/helperslib/Packages.py", line 115, in retrievePackagelatestContent.write( response.read() )  File "/usr/local/lib/python3.5/http/client.py", line 461, in reads = self._safe_read(self.length)  File "/usr/local/lib/python3.5/http/client.py", line 607, in _safe_readchunk = self.fp.read(min(amt, MAXAMOUNT))  File "/usr/local/lib/python3.5/socket.py", line 576, in readintoreturn self._sock.recv_into(b)  File "/usr/local/lib/python3.5/ssl.py", line 937, in recv_intoreturn self.read(nbytes, buffer)  File "/usr/local/lib/python3.5/ssl.py", line 799, in readreturn self._sslobj.read(len, buffer)  File "/usr/local/lib/python3.5/ssl.py", line 583, in readv = self._sslobj.read(len, buffer)ConnectionResetError: [Errno 54] Connection reset by pee

D15963: [KonsoleProfiles applet] Fix initial focus

2018-10-05 Thread Thomas Surrel 
thsurrel created this revision.
thsurrel added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Now arrow key nav works when opening a panel applet via keyboard
  shortcut.
  Fixes the same problem as D15856 

TEST PLAN
  Open the konsole profile applet with a keyboard shortcut, move
  around with the up and down arrows

REPOSITORY
  R114 Plasma Addons

BRANCH
  arc_profileapplet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15963

AFFECTED FILES
  applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml

To: thsurrel, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15946: Avoid creation of needless temporary containers

2018-10-05 Thread Alexander Volkov 
volkov closed this revision.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D15946

To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15946: Avoid creation of needless temporary containers

2018-10-05 Thread Alexander Volkov 
volkov added inline comments.

INLINE COMMENTS

> broulik wrote in output.cpp:101
> The previous code also compared the contents of both, or does your new loop 
> below do that?

Yes, the check is in the loop below: `after` and `before` are of the same 
sizes, and if `after` contains each key from `before`, then their keys are 
equal. So return false if a key can't be found in `after`.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15946

To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-05 Thread Roman Geints 
romangeints added a comment.


  So, should I rewrite this in terms of `qBound` & `availableGeometry`?

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

2018-10-05 Thread Thomas Surrel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df458e9ea505: [Folder View] In list view mode, fix home 
button disappearing every other… (authored by thsurrel).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15823?vs=42527&id=42915

REVISION DETAIL
  https://phabricator.kde.org/D15823

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: thsurrel, #plasma, #vdg, hein
Cc: abetts, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

2018-10-05 Thread Thomas Surrel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:943122b4429d: [KonsoleProfiles applet] Fix navigating 
with the keyboard (authored by thsurrel).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15877?vs=42661&id=42913

REVISION DETAIL
  https://phabricator.kde.org/D15877

AFFECTED FILES
  applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml

To: thsurrel, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Kai Uwe Broulik 
broulik added a comment.


  Probably needs an ifdef for `KDE4`

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Rik Mills 
rikmills added a comment.


  Fails to build on Neon and Kubuntu CI
  
  https://build.neon.kde.org/job/bionic_unstable_kde_breeze/71/
  
  01:20:12 [ 94%] Building CXX object 
kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o
  01:20:12 kstyle/CMakeFiles/breeze.dir/build.make:982: recipe for target 
'kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o' failed
  01:20:12 make[5]: Leaving directory '/workspace/build/build-qt4'
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp: In member function 
‘bool Breeze::WindowManager::mousePressEvent(QObject*, QEvent*)’:
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:448:25: error: 
‘class QMouseEvent’ has no member named ‘source’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:448:41: error: 
‘MouseEventNotSynthesized’ is not a member of ‘Qt’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~~~
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp: In member function 
‘bool Breeze::WindowManager::mouseMoveEvent(QObject*, QEvent*)’:
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:514:25: error: 
‘class QMouseEvent’ has no member named ‘source’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:514:41: error: 
‘MouseEventNotSynthesized’ is not a member of ‘Qt’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~~~
  01:20:12 make[5]: *** 
[kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o] Error 1
  01:20:12 make[5]: *** Waiting for unfinished jobs

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15946: Avoid creation of needless temporary containers

2018-10-05 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> output.cpp:101
>  {
> -if (before.keys() != after.keys()) {
> +if (before.count() != after.count()) {
>  return false;

The previous code also compared the contents of both, or does your new loop 
below do that?

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15946

To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart