Can't unsubscribe

2018-10-19 Thread tajames
Hello all, I'm currently having some issues with my email acccounts, and I'd 
like to unsubscribe from plasma-devel.  I've tried unsubscribing through the 
web portal and I've tried resetting my password - neither option appears to do 
anything.  Coudl someone please manually take me off the list? Thanks, Tom

5.15 New Features notepad

2018-10-19 Thread Jonathan Riddell
As discussed at the meeting starting the 5.15 new features notepad
early, please add things as you merge them in
https://notes.kde.org/p/plasma_5_15

Jonathan


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread Roman Geints
romangeints added a comment.


  Am I right thinking no further action is expected from me?

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


Re: 5.15 New Features notepad

2018-10-19 Thread Rik Mills
On 19/10/2018 11:18, Jonathan Riddell wrote:
> As discussed at the meeting starting the 5.15 new features notepad
> early, please add things as you merge them in
> https://notes.kde.org/p/plasma_5_15
> 
> Jonathan
> 

notes.kde.org refuses to allow log in


D16170: [Device Notifier] Restore busy indicator

2018-10-19 Thread Nathaniel Graham
ngraham added a comment.


  FWIW, I can confirm that https://bugs.kde.org/show_bug.cgi?id=399986 is fixed 
with this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16170

To: thsurrel, #plasma, #vdg, broulik, bruns
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16309: Add accessibility information to desktop icons

2018-10-19 Thread Frederik Gladhorn
gladhorn accepted this revision.
gladhorn added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> FolderItemDelegate.qml:45
> +Accessible.name: name
> +Accessible.role: Accessible.Canvas
>  function openPopup() {

Is Canvas what Gnome uses for desktop icons? I'm fine with this, since I don't 
have a better suggestion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16309

To: chempfling, hein, gladhorn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread David Edmundson
davidedmundson added a comment.


  What's your email address? (for the commit log)

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


5.15 New Features notepad

2018-10-19 Thread Rik Mills
On 19/10/2018 13:37, Rik Mills wrote:
> notes.kde.org refuses to allow log in

Seems to have rectified itself. :)




D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread Roman Geints
romangeints added a comment.


  roman...@gmail.com

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:90466f3cd655: Fix Klipper popup opening on default screen 
instead of at cursor position (authored by romangeints, committed by 
davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15887?vs=42988&id=43920

REVISION DETAIL
  https://phabricator.kde.org/D15887

AFFECTED FILES
  klipper/klipper.cpp

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D16316: [Kicker] Rename id column to itemColumn

2018-10-19 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In Qt 5.12 new magic `column` and `row` properties appeared in the delegate's 
scope, similar to the `index` and `model` (`modelData`) one.
  This causes `column` to access that (being always the number zero for this 
list model) and as such the delegate not having a width and turning invisible.

TEST PLAN
  So much for Qt versioning... quite a horrible behavior change as I typically 
also just call my Column `column`... let's work around this in 5.14 (or even 
5.12 since it's quite trivial change) here and escalate to Qt then...
  
  - All apps and krunner in kickerdash work again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16316

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemMultiGridView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added inline comments.

INLINE COMMENTS

> gladhorn wrote in FolderItemDelegate.qml:45
> Is Canvas what Gnome uses for desktop icons? I'm fine with this, since I 
> don't have a better suggestion.

Canvas is used by Nautilus. The default filemanager.

Joanie would prefer the Role „Icon“ what we didn’t find in the documentation.
Just „Graphics“ what is to be assumed as image or picture.

See joanies answer:
https://mail.gnome.org/archives/orca-list/2018-October/msg00215.html

Canvas works as exceped, i tried.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16309

To: chempfling, hein, gladhorn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added a comment.


  Do i need to do anythin else to get it into master?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16309

To: chempfling, hein, gladhorn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


2019 Plasma release schedule

2018-10-19 Thread Jonathan Riddell
I've made the Plasma release schedule for 2019

https://community.kde.org/Schedules/Plasma_5

Plasma 5.15 (using Frameworks 5.54) beta is Jan 17th and final Feb 12th.
Plasma 5.16.0 June 11
Plasma 5.17.0 Oct 15

It's in Phabricator
https://phabricator.kde.org/calendar/query/month/2018/11/

and my Google calendar
https://calendar.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com&ctz=Europe%2FLondon

Let me know of any issues

Jonathan


D16212: [Device Notifier] Add a button to unmount all devices

2018-10-19 Thread Thomas Surrel
thsurrel updated this revision to Diff 43929.
thsurrel added a comment.


  Add a text label to the new button
  Fixes to hide the button correctly when devices unmount

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16212?vs=43624&id=43929

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: thsurrel, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16212: [Device Notifier] Add a button to unmount all devices

2018-10-19 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a subscriber: broulik.
ngraham added a comment.
This revision is now accepted and ready to land.


  Consider it VDG-approved! The button label vastly improves the situation IMHO.
  
  Now, is it @broulik -approved? ;)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D16309: Add accessibility information to desktop icons

2018-10-19 Thread Frederik Gladhorn
gladhorn added a comment.


  I guess we can go with this for now, let's be pragmatic. Qt doesn't have icon 
or desktop_icon at the moment. I can add, if Joanie suggests doing that on the 
Orca mailing list.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16309

To: chempfling, hein, gladhorn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added a comment.


  Ok, so nothing to do then.   Is this merged automatically once  per day or 
something? Or how do i get the patch into master now? I mark the task as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16309

To: chempfling, hein, gladhorn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16327: Update libdbusmenuqt folder

2018-10-19 Thread Chris Holland
Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I needed to add `include(ECMQtDeclareLoggingCategory)` to the root 
`CMakeLists.txt` to get it to compile.
  
  https://github.com/KDE/plasma-workspace/tree/master/libdbusmenuqt
  
  I've no idea why the annotations for the qdbus ItemsPropertiesUpdated signal 
used `In0` instead of `Out0`.
  
  
https://github.com/kotelnik/plasma-applet-active-window-control/blob/master/plugin/libdbusmenuqt/com.canonical.dbusmenu.xml#L5

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16327

AFFECTED FILES
  CMakeLists.txt
  plugin/libdbusmenuqt/CMakeLists.txt
  plugin/libdbusmenuqt/com.canonical.dbusmenu.xml
  plugin/libdbusmenuqt/dbusmenuimporter.cpp
  plugin/libdbusmenuqt/dbusmenuimporter.h
  plugin/libdbusmenuqt/dbusmenushortcut_p.cpp
  plugin/libdbusmenuqt/dbusmenushortcut_p.h
  plugin/libdbusmenuqt/dbusmenutypes_p.h

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16328: Saner config defaults

2018-10-19 Thread Chris Holland
Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Make sure the buttons have a dedicated place, filling the entire height of 
the panel rather than only 50%. We could probably limit the size of the buttons 
to be the same max size as panel icons.
  
  This enables the AppMenu by default, assuming the user will compile the 
widget rather than downloading a zipped `.plasmoid`.
  
  - Enable Fill the Width so the "double click to maximize" is available by 
default.
  - Enable `appmenuDoNotHide` so it's similar to Global Menu
  
  Should probably also make `showButtonOnlyWhenMaximized` true as well, once 
I've also patched AWC to always keep a blank area dedicated for the buttons as 
it currently slides the title/menu to where the buttons were.
  
  F6339169: screen-2018-10-19_16.53.17.mp4 


REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16328

AFFECTED FILES
  package/contents/config/main.xml

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16329: Add a ReadMe with install from Git instructions and bugzilla links

2018-10-19 Thread Chris Holland
Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  TODO: Figure out all the build dependencies.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16329

AFFECTED FILES
  ReadMe.md

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16330: Add a vertical spacer item

2018-10-19 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: mart, Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch creates a very simple vertical spacer item that can be used to add 
a pre-determined amount of spacing between sections in a form layout without 
having to re-invent the wheel or abuse another control.
  
  BUG: 399959
  FIXED-IN: 5.52

TEST PLAN
  Layout with `Kirigami.VerticalSpacer` items between sections:
  [image goes here]

REPOSITORY
  R169 Kirigami

BRANCH
  verticalspacer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16330

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/VerticalSpacer.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ngraham, mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-19 Thread Nathaniel Graham
ngraham added a comment.


  Instead of ghetto DIY spacers, maybe we can use purpose-built vertical 
spacers: D16330: Add a vertical spacer item 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol


D16330: Add a vertical spacer item

2018-10-19 Thread Alexey Min
alexeymin added a comment.


  1. What if in the future another, horizontal spacer component will become 
needed? Will you add a HorizontalSpacer.qml then? 😆 Maybe have just a Spacer 
with `horizontal` property?
  2. Why `Rectangle`, it could be just `Item`, it does not cause rendering 
(Rectangle does)
  
  Probably it is possible use just `Item` itself, without special control.
  P.S. ^^ Just some thoughts, ignore me if I don't make sense.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D16330

To: ngraham, mart, #kirigami
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D16331: GTK theme typo/bug fix

2018-10-19 Thread Olli Helin
ohelin created this revision.
ohelin added a reviewer: Breeze.
ohelin added a project: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ohelin requested review of this revision.

REVISION SUMMARY
  Fixes a typo in the CSS files which resulted in GTK treeviews being unusable. 
See picture.
  F6339414: 47191505-94144180-d350-11e8-993b-a65ded238d0d.png 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D16331

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.18/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: ohelin, #breeze
Cc: plasma-devel, #breeze, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16330: Add a vertical spacer item

2018-10-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 43958.
ngraham added a comment.


  - Make it an Item, not a Rectangle
  - Make it do horizontal spacing too

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16330?vs=43954&id=43958

BRANCH
  verticalspacer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16330

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Spacer.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ngraham, mart, #kirigami
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D16241: [Folder View] Improve layout and formatting of Icons page

2018-10-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 43959.
ngraham added a comment.


  - Also do the Location page
  - Use `Spacer` items instead of hacks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43899&id=43959

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: ngraham, #plasma, #vdg, hein
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol