D16368: Swap Trash/Delete when Shift is used while the menu is open

[Eike Hein]

hein updated this revision to Diff 44091.
hein added a comment.


  Simplify patch.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16368?vs=44063&id=44091

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[Eike Hein]

hein added a comment.


  Ping?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Eike Hein]

hein added a comment.


  Ping?

INLINE COMMENTS

> davidedmundson wrote in desktop.cpp:59
> Use of the & is weird.

I know the containers are implicitly shared, but I consider it better coding 
style to do the correct C++ thing out of habit rather than rely on that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15599

To: hein, mart, davidedmundson
Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Eike Hein]

hein added a comment.


  In D14796#347289 , @apol wrote:
  
  > What's the status of this? The longer we wait, the harder it will be to 
integrate. We just branched 5.14, maybe it's time to consider doing so?
  
  
  It needs a lot of review, VDG feedback on the KCM UIs, and practically 
speaking an ibus backend to be coded. Both Geon and me are currently a bit busy 
(exchange studies in his case, work in my case) and I think much progress 
before Xmas isn't that likely unless more people participate.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: apol, plasma-devel, hein, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D16365: share common values for both Breeze and Breeze-dark GTK themes

[Olli Helin]

ohelin added a comment.


  Nada from here, I'd say go ahead.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D16365

To: ohelin, jackg, #breeze, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16365: Update diff against newest master

[Nathaniel Graham]

ngraham added reviewers: jackg, Breeze.
ngraham added a comment.


  Thanks, it looks good to me too in my testing. Any objections to landing this?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D16365

To: ohelin, jackg, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16330: Add a spacer item

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Don't need this, per @mart.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D16330

To: ngraham, mart, #kirigami
Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

ngraham added a comment.


  @mart I've implemented your suggestions. To my eyes, the vertical spacing 
isn't enough. Compare the current version: F6344159: Using the correct 
objects.png 
  
  ...With the previous one I had before: F6339576: Desktop icons after.png 

  
  But that's pretty minor and would need to be changed (if you agree) elsewhere.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

ngraham updated this revision to Diff 44089.
ngraham added a comment.


  Implement @mart's suggestions

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43959&id=44089

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[René J . V . Bertin]

rjvbb updated this revision to Diff 44083.
rjvbb added a comment.


  updated for the current git/head.
  
  David: did you perhaps forget to accept the revision (aka, should I have 
committed this)?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14000?vs=37897&id=44083

REVISION DETAIL
  https://phabricator.kde.org/D14000

AFFECTED FILES
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Aleix Pol Gonzalez]

apol added a comment.


  What's the status of this? The longer we wait, the harder it will be to 
integrate. We just branched 5.14, maybe it's time to consider doing so?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: apol, plasma-devel, hein, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigIcons.qml:130
>  
> -// Row 1: Spacing
> -Item {
> -Layout.row: 1
> -Layout.column: 0
> -Layout.minimumHeight: units.largeSpacing
> +Kirigami.Spacer {
>  visible: isPopup

those should be just

Item {
Kirigami.FormData.isSection: true
}

then, we'll see how things in formlayout have to be fixed to reach the desired 
spacing/result

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16365: Update diff against newest master

[Olli Helin]

ohelin added a comment.


  I checked the both the diff_part files next to each other. All the other 
differences were quite easy to see, but this one bugs me a little:
  
scrollbar.vertical button.down {
  -gtk-icon-source: -gtk-icontheme("pan-down-symbolic"); }
scrollbar.vertical button.up {
  -gtk-icon-source: -gtk-icontheme("pan-up-symbolic"); }
scrollbar.horizontal button.down {
  -gtk-icon-source: -gtk-icontheme("pan-end-symbolic"); }
scrollbar.horizontal button.up {
  -gtk-icon-source: -gtk-icontheme("pan-start-symbolic"); }
  
  So that was in the old gtk-dark theme, but not in the new one. However, it's 
probably just some obsolete stuff anyway. From the few differences between the 
theme files, I think most are just leftovers from the past and simply forgotten 
to update. That alone speaks for the usefulness of this patch, as probably 
there shouldn't be any differences in margins for example between a light and a 
dark version of a theme.
  
  So, for the code part I'd say it's fine, unless someone knows better. I don't 
have any visual experience using Breeze, so judging from the quick look I guess 
it's fine, too.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D16365

To: ohelin
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16375: fix warnings

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Don't call directly properties that may be undefined

TEST PLAN
  Now discover still works without warnings in the GlobalDrawer

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16375

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/controls/private/BannerImage.qml

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16374: Don't fetch the url if it's already being fetched

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3a7782e0ba5c: Don't fetch the url if it's 
already being fetched (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16374?vs=44075&id=44076

REVISION DETAIL
  https://phabricator.kde.org/D16374

AFFECTED FILES
  src/desktopicon.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16374: Don't fetch the url if it's already being fetched

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It had weird behaviours and would sometimes overwrite the image
  when it's downloaded for real.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16374

AFFECTED FILES
  src/desktopicon.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16368: Swap Trash/Delete when Shift is used while the menu is open

[Nathaniel Graham]

ngraham added a comment.


  Thanks Eike! Any chance this can go into the 5.12 branch?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

[Scott Deagan]

https://bugs.kde.org/show_bug.cgi?id=375732

--- Comment #2 from Scott Deagan  ---
I have found a workaround for this: in Dolphin, use "fish://" instaead of
"sftp://";.

As an example, consider the following in your ~/.ssh/config:

Host ExternalHost # Host A - external/Internet facing.
Hostname 123.123.123.123  # Public IP address for Host A.
User myusername   # Username for Host A.
IdentityFile ~/.ssh/external_machine_private_key


Host InternalHost# Host B - internal (target host).
HostName 192.168.0.123   # IP address of target host on internal LAN.
User yourusername# User on Host B.
IdentityFile ~/.ssh/your_private_key  # Private key for Host B.
ProxyCommand ssh -q ExternalHost nc -w10 %h %p 2> /dev/null

In Dolphin, pressing CTRL + L (to make the address bar editable), then enter:

fish://InternalHost

This works as expected - Dolphin will open the user's home directory on
192.168.0.123.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D16368: Swap Trash/Delete when Shift is used while the menu is open

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> foldermodel.cpp:1854
>  menu->popup(m_menuPosition);
> -connect(menu, &QMenu::aboutToHide, [menu]() { menu->deleteLater(); });
> +connect(menu, &QMenu::aboutToHide, [this, menu]() {
> +menu->deleteLater();

Use four argument connect since now you access `this` but given you delete the 
menu anyway,  this change probably isn't neccessary to begin with

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16316: [Kicker] Rename id column to itemColumn

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:004d838c2718: [Kicker] Rename id column to itemColumn 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16316?vs=43921&id=44067

REVISION DETAIL
  https://phabricator.kde.org/D16316

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemMultiGridView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16368: Swap Trash/Delete when Shift is used while the menu is open

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> foldermodel.cpp:653
> +// Trash and Delete actions while the Shift modifier is pressed.
> +// There's no point to doing so when the menu isn't open.
> +if (m_menuPosition.isNull()) {

you delete the menu when the menu isn't open, you won't get any events

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

notes for Monday meeting of 22/10/2018

[Marco Martin]

Eike:
* [Wayland] Fixed another review-originated thingie in one of the
containment action phabs, two Wayland VD Phabs of mine still waiting
on re-review now
* [FV] Fixed Trash/Delete not being swapped in the context menu when
Shift was pressed while the menu was already open

Kai Uwe:
Work done:
- Fixed bug in Global Menu preventing use of single button mode in
horizontal panel
- Various bugfixes and mentoring of a person doing various KFind fixes
and improvements
- Fix (mostly..) for Dolphin's icons being misaligned when using
fractional scaling
- Cleaned up cruft in plasma-framework, e.g. the PLASMA_NO_KIO and
other unused (and broken) build options
- plasma-browser-integration now requires only Qt 5.9
-- should make it esier for distros to backport it to Plasma 5.12 LTS,
given it doesn't really depend on anything Plasma
- Investigated various Qt 5.12 issues
-- Import versioning is a lot stricter now: Minimize All plasmoid
suddenly failed because it imported QtQuick 2.1 but used something
from 2.7
-- Found awful QML GC bug breaking ToolButton (the about menu in
System Settings sidebar mode): QTBUG-71238
https://bugreports.qt.io/projects/QTBUG/issues/QTBUG-71238 (when you
return a parent-less Qobject form a Q_INVOKABLE it is adopted by GC.
However, due to some bug it is deleted despite being assigned to (and
as such referenced) a  property)
-- Found awful Repeater/model-related regression breaking AppDash: QTBUG-70031
https://bugreports.qt.io/projects/QTBUG/issues/QTBUG-70031

David:
* kwin now has XDGPopupPositioner support (with the full anchor rects
and constraint handling etc) \o/
* all of which is moot whilst Qt doesn't expose it..but I have a plan
on adding that to Qt 5.13
*‎ then hopefully expose in a way that X will share the same
positioning public API but we do it in-process
* my ksmserver splitting got some more patches splitting out shutdown.
I hope to split everything in-process, merge that, test for a few
weeks, then split into the multiple processes after that.

Vlad:
Done:
* Keep closed transients above their old parents when they are animated;
* Polish the Dim Inactive effect;
* The Dim Inactive, the Dim Screen, and the Translucency effect now
work with Wayland clients.
Under review/Waiting for review:
* Optimize shadow generation in the Breeze decoration theme; D15514
‎>‎ Diff 15514 "[libbreezecommon] Use box blur instead of FFT blur"
[Accepted] https://phabricator.kde.org/D15514
* Overhaul the Snap Helper effect; D15695
‎>‎ Diff 15695 "[effects/snaphelper] Do massive overhaul" [Needs
Review] https://phabricator.kde.org/D15695
* "Fix" lowerClient/raiseClient; D16228 D16229
‎>‎ Diff 16228 "Raise window group together with group transient"
[Needs Review] https://phabricator.kde.org/D16228
‎>‎ Diff 16229 "[wayland] Make the "Lower Window" shortcut work with
transients" [Needs Review] https://phabricator.kde.org/D16229
* Blur background behind windows when the Invert effect is active. D16358
‎>‎ Diff 16358 "[effects/invert] Don't block blur and background
contrast effect" [Needs Review] https://phabricator.kde.org/D16358
Currently working on:
* Show label/flag for the current keyboard layout (Wayland);
* Split the Fade effect into two: the one that animates toplevel
windows and the other one that animates popups, then move Fade, Glide,
and Scale effect into an exclusive group;
* Port the Minimize Animation effect to JavaScript.

Marco:
* mostly non plasma stuff this week, but the relevant things are:
Kirigami:
* merged the global toolbar loading refactoring
* fixed behavior of SwipeListItem when it's not the last page of the PageRow
* units of Plasma kirigami style more homogeneous with the other styles
Plasma:
* fixed layouting and icon colors of some components such as Button
and RoundButton
* PlasmaComponents3 support mnemonics in text of buttons and toolbuttons
* left only one comment in the vd stuff, will take care today/tomorrow

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a2b683a10802: Implement option to toggle page navigation 
wraps around for pager plasmoid (authored by phuongn, committed by 
davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14988?vs=40618&id=44064

REVISION DETAIL
  https://phabricator.kde.org/D14988

AFFECTED FILES
  applets/pager/package/contents/config/main.xml
  applets/pager/package/contents/ui/configGeneral.qml
  applets/pager/package/contents/ui/main.qml

To: phuongn, #plasma, #vdg, davidedmundson
Cc: hein, zzag, ngraham, abetts, davidedmundson, broulik, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D16309: Add accessibility information to desktop icons

[Christian Hempfling]

chempfling added a comment.


  In D16309#347071 , @hein wrote:
  
  > I'll land it for you (it needs a manual step, which requires a dev account 
- which you should eventually apply for if you wind up contributing regularly!).
  
  
  Ok Thanks,
  I ll try to get an dev acount. let me check how to i get one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16309

To: chempfling, hein, gladhorn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16368: Swap Trash/Delete when Shift is used while the menu is open

[Eike Hein]

hein created this revision.
hein added reviewers: ngraham, broulik.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Matching Dolphin.
  
  BUG:395155

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16368

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: hein, ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart