D16417: Improve replacement text when action description is not provided

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this works.

INLINE COMMENTS

> bruns wrote in AuthDialog.cpp:359
> Btw, "not provided" is your own proposal ;-)

What!? I must be going senile already...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  arcpatch-D12498

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: bruns, ngraham, davidedmundson, sharvey
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16365: share common values for both Breeze and Breeze-dark GTK themes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: grmat.
ngraham added a comment.
This revision is now accepted and ready to land.


  I haven't noticed any problems running with this over the past few days. It's 
unfortunate that neither the maintainer (@jackg) nor anyone else familiar with 
this code has showed up to review it. But it would be a shame to let something 
this extensive rot away, and since you and I haven't found any problems with 
it, my inclination is to land it.
  
  If nobody else shows up soon to offer a review, I'll land this on Halloween 
(October 31).
  
  Note for @grmat: I will land this with your authorship and then close out 
D15786 .

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D16365

To: ohelin, jackg, #breeze, #plasma, ngraham
Cc: grmat, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[Chris Holland]

https://bugs.kde.org/show_bug.cgi?id=304696

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #14 from Chris Holland  ---
As Oliver said in 2013, it looks like this is the intended behaviour since it
was first written (8 years ago?).

https://github.com/KDE/powerdevil/blame/master/daemon/actions/bundled/dimdisplay.cpp#L64

At 50% the set idle duration, it dims to 50% brightness.
At 75% the set idle duration, it dims to 12.5% brightness.
At 100% the set idle duration, it dims to 0% brightness.

We could maybe use different values, say 90% brightness, then 70% brightness,
before dropping to 0% at the specified time.

I wonder if there'd be issues with changing it to 5/4 (125% idle duration) and
3/2 (150% idle duration) so that it doesn't start dimming before the user's
explicitly defined value.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D16419: [kickoff] Wordwrap long sentence in config

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Text should always be constrained and should almost always elide or
  wrap.
  
  Note that the parent layout may be bigger than the view due to the
  non-resizing nature of the Buttons UI so some different bugs still
  exist.
  
  BUG: 389124

TEST PLAN
  Looked at it

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16419

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in AuthDialog.cpp:359
> I would prefer "not available" over "not provided", but I won't choose this 
> as my hill to die on. :)
> 
> Do we actually need to repeat the word 'Description' here?

Btw, "not provided" is your own proposal ;-)

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15885: Clean UI file for `details` portion of UI

[Stefan Brüns]

bruns abandoned this revision.
bruns added a comment.


  Folded back into D12498 

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D15885

To: bruns, ngraham, davidedmundson, sharvey
Cc: bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16403: Add services and appstream runner debug categories to categories file

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:17a0d34d0e83: Add services and appstream runner debug 
categories to categories file (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16403?vs=44160=44185

REVISION DETAIL
  https://phabricator.kde.org/D16403

AFFECTED FILES
  plasma-workspace.categories

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in AuthDialog.cpp:356
> So I gather `.isEmpty()` works now?

Yes.

> ngraham wrote in AuthDialog.cpp:359
> I would prefer "not available" over "not provided", but I won't choose this 
> as my hill to die on. :)
> 
> Do we actually need to repeat the word 'Description' here?

There is no repetition here - the Polkit "" is labeled "Action:" 
in the dialog.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Stefan Brüns]

bruns updated this revision to Diff 44184.
bruns added a comment.


  Update UI file
  Split out "description" change

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12498?vs=42375=44184

BRANCH
  arcpatch-D12498

REVISION DETAIL
  https://phabricator.kde.org/D12498

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: bruns, ngraham, davidedmundson, sharvey
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> AuthDialog.cpp:356
> -// replace blank description
> -// neither isEmpty() or isNull() worked (?)
> -if (actionDescription.description() == "") {

So I gather `.isEmpty()` works now?

> AuthDialog.cpp:359
>  action_label->setFont(descrFont);
> -action_label->setText(i18n("Not Applicable"));
> +action_label->setText(i18n("'Description' not provided"));
>  } else {

I would prefer "not available" over "not provided", but I won't choose this as 
my hill to die on. :)

Do we actually need to repeat the word 'Description' here?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Plasma, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The polkit rules specification mandates a description for actions,
  
https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-declaring-actions
  
  Split from D12498 .

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

AFFECTED FILES
  AuthDialog.cpp

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16327: Update libdbusmenuqt folder

[Chris Holland]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by 
Zren).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16327?vs=43949=44177

REVISION DETAIL
  https://phabricator.kde.org/D16327

AFFECTED FILES
  CMakeLists.txt
  plugin/libdbusmenuqt/CMakeLists.txt
  plugin/libdbusmenuqt/com.canonical.dbusmenu.xml
  plugin/libdbusmenuqt/dbusmenuimporter.cpp
  plugin/libdbusmenuqt/dbusmenuimporter.h
  plugin/libdbusmenuqt/dbusmenushortcut_p.cpp
  plugin/libdbusmenuqt/dbusmenushortcut_p.h
  plugin/libdbusmenuqt/dbusmenutypes_p.h

To: Zren
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16394: Hide Buttons With Empty Text (Gtk Separators)

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R884:942169541d33: Hide Buttons With Empty Text (Gtk 
Separators) (authored by Zren).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16394?vs=44133=44176

REVISION DETAIL
  https://phabricator.kde.org/D16394

AFFECTED FILES
  package/contents/ui/AppMenu.qml

To: Zren, broulik
Cc: trmdi, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15206: [Kickoff] Add a subtle separator line between the header and the content view

[Nathaniel Graham]

ngraham added a comment.


  No, the blue highlight doesn't touch, just like people requested. It looks 
just fine now. If we want to make the blue highlight touch the bounds of its 
whole view, that would be a significant design change that would need to be 
made elsewhere (if indeed it would be desirable).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15206

To: ngraham, #plasma, #vdg
Cc: abetts, mmustac, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15855: Port Kickoff to shared view component using single-MouseArea pattern

[Nathaniel Graham]

ngraham added a comment.


  Oops, sorry, I forgot to change my status!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15855

To: hein, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Nathaniel Graham]

ngraham added a comment.


  Ping! Can we get a review from a #plasma 
 person?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The favicon and places instances are created in the prepare() call,
  leaking the instance from the last invocation. Delete the old
  instance in teardown().
  
  See also T9626 .

TEST PLAN
  run several queries in krunner
  -> instances are no longer leaked

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16410

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16409: [Bookmarks Runner] Open database connection in the query thread

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QSqlDatabase connection instances are global reference counted objects which
  can be crated using the QSqlDatabase::addDatabase(...) method and later
  retrieved with QSqlDatabase::database(connectionname).
  
  Connections should only be used from a single thread, and should be cleaned
  up with QSD::removeDatabase(name), which implicitly closes the connection
  when the last reference is removed.
  
  Currently, the same connection (name) is reused over all threads, and
  the connection is only removed implicitly by replacing it via addDatabase().
  This leads to warnings, i.e.: "QSqlDatabasePrivate::addDatabase: duplicate
  connection name '...', old connection removed."
  
  As one reference is held by the m_db member, the implicit removal triggers
  another warning: "QSqlDatabasePrivate::removeDatabase: connection '..."
  is still in use, all queries will cease to work."
  
  According to the documentation, "It is highly recommended that you do not
  keep a copy of the QSqlDatabase around as a member of a class, as this
  will prevent the instance from being correctly cleaned up on shutdown."
  There is no need to keep a reference using a member variable, as retrieving
  an open connection via QSqlDatabase::database(...) is cheap.
  
  Create a per-thread DB connection on first use, and remove the connections
  when the FetchSqlite instance is torn down.
  
  Delaying the open is beneficial for the favicon instance, which may be
  unused when the icon is already cached on disk.
  
  See also T9626 .

TEST PLAN
  execute a query in krunner
  
  1. Results are as expected
  2. The 'QSqlDatabasePrivate::removeDatabase: connection ... is still in use, 
all queries will cease to work.' warning no longer appears
  3. The 'QSqlDatabasePrivate::addDatabase: duplicate connection name ..., old 
connection removed' warning no longer appears

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16409

AFFECTED FILES
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

[Stefan Brüns]

bruns added a comment.


  Only applies cleanly after D16403 .

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

[Stefan Brüns]

bruns added a comment.


  Depends on the cleanup in D16404 , as the 
autogenerated `bookmarks_debug.cpp` is not linked to the 
tests/testChromeBookmarks binary otherwise.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16327: Update libdbusmenuqt folder

[Chris Holland]

Zren added a comment.


  For now, I'm going to merge this so I can keep the widget in sync with the 
global menu widget. We can revisit linking to a shared library later on.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16327

To: Zren
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16405: Add debug category for bookmarks runner

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Dependency for followup patches, no functional change

TEST PLAN
  make

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16405

AFFECTED FILES
  plasma-workspace.categories
  runners/bookmarks/CMakeLists.txt

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16402: Cleanup - remove unnecessary QIcon include

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9945aecaf2eb: Cleanup - remove unnecessary QIcon include 
(authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16402?vs=44159=44163

REVISION DETAIL
  https://phabricator.kde.org/D16402

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.h

To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16404: [Bookmarks Runner] Cleanup tests CMakeList

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Build the test dependencies as static library. Remove duplicate and
  commented out lines. Use ecm_add_test instead of setting up everything
  manually.

TEST PLAN
  make && ctest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16404

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/tests/CMakeLists.txt

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16403: Add services and appstream runner debug categories to categories file

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Make the debug categories visible in kdebugsettings

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16403

AFFECTED FILES
  plasma-workspace.categories

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16402: Cleanup - remove unnecessary QIcon include

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QIcon is only used in the implementation, not in the interface.

TEST PLAN
  compile tested, no functional changes

REPOSITORY
  R120 Plasma Workspace

BRANCH
  db_fix_2

REVISION DETAIL
  https://phabricator.kde.org/D16402

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.h

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[S]

https://bugs.kde.org/show_bug.cgi?id=304696

S  changed:

   What|Removed |Added

 CC||sb56...@gmail.com

--- Comment #13 from S  ---
Created attachment 115877
  --> https://bugs.kde.org/attachment.cgi?id=115877=edit
Power settings not obeyed

Hi, this bug still exists in Plasma 5.14.1 (on openSUSE Tumbleweed).

With the settings in this screenshot, it appears to dim to about 50% brightness
after 2.5 minutes (half of my configured 5 minutes). But what is more strange
is that it goes into yet another dimmed state of about 10% brightness at the 5
minute mark, and finally powers off the screen entirely at 6 minutes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15616: [Comic] Handle error state correctly

[Anthony Fieroni]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:7c7c00798048: [comicprovider] Restart timer on redirect 
request (authored by anthonyfieroni).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15616?vs=43461=44158

REVISION DETAIL
  https://phabricator.kde.org/D15616

AFFECTED FILES
  dataengines/comic/comicprovider.cpp

To: anthonyfieroni, davidedmundson, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16400: Prefer to set current mode in resolution combobox

[Alexander Volkov]

volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Preferred resolution may be lower than current resolution (e.g. on KVM),
  in this case it will be selected in the combobox instead of current
  resolution. Select current resolution if it's available.

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16400

AFFECTED FILES
  kcm/src/resolutionslider.cpp

To: volkov
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Peridot Lavender]

lavender added a comment.


  This redesign seems like a good place to start thinking about integrating 
accessibility options T  with the rest 
of the settings. I included some screenshots of what OSX does (Switch Control 
, 
Accessibility Keyboard 
, Dwell 
 for 
head- and eye-tracking and Panel Editor 
 to edit)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: lavender, ngraham, apol, plasma-devel, hein, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:24bdc06747ed: [server] Respect input region of 
sub-surfaces on pointer surface focus (authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7038?vs=44149=44151

REVISION DETAIL
  https://phabricator.kde.org/D7038

AFFECTED FILES
  src/server/pointer_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Roman Gilg]

romangg updated this revision to Diff 44149.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7038?vs=42733=44149

BRANCH
  inputRegionSubSurfaces

REVISION DETAIL
  https://phabricator.kde.org/D7038

AFFECTED FILES
  src/server/pointer_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D15855: Port Kickoff to shared view component using single-MouseArea pattern

[Eike Hein]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:48b32259e73f: Port Kickoff to shared view component using 
single-MouseArea pattern (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15855?vs=42841=44142

REVISION DETAIL
  https://phabricator.kde.org/D15855

AFFECTED FILES
  applets/kickoff/package/contents/ui/ApplicationsView.qml
  applets/kickoff/package/contents/ui/BaseView.qml
  applets/kickoff/package/contents/ui/Breadcrumb.qml
  applets/kickoff/package/contents/ui/FavoritesView.qml
  applets/kickoff/package/contents/ui/KickoffItem.qml
  applets/kickoff/package/contents/ui/KickoffListView.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: hein, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16368: Swap Trash/Delete when Shift is used while the menu is open

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c4285ed1b407: Swap Trash/Delete when Shift is used while 
the menu is open (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16368?vs=44091=44141

REVISION DETAIL
  https://phabricator.kde.org/D16368

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: hein, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.11 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.11/10/
 Project:
stable-kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 24 Oct 2018 06:16:31 +
 Build duration:
27 min and counting

D15616: [Comic] Handle error state correctly

[Anthony Fieroni]

anthonyfieroni added a comment.


  @davidedmundson to commit or you have other objections?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15616

To: anthonyfieroni, davidedmundson, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart