D16587: [ksmserver] Simplify call to kcminit

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R120:8c85bfa65a11: [ksmserver] Simplify call to kcminit 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16587?vs=44630=44681

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma, broulik
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6a4f4cc31ebc: [Folder View] Improve layout, formatting, 
and wording of Icons and Locations… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=44089=44679

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

[Kai Uwe Broulik]

broulik added a comment.


  We use everything in Plasma "as a library", that's why 
`KDeclarative::QmlObject` sets a translation context on the root context, so 
that plasmoids, wallpaper plugins, and other QML bits can use `i18n` with no 
translation domain (only exception really being the look and feel packages). 
I'm too tired to explain right now but note when you run the KCM from within 
Plasma you get a warning like:
  
QQmlContext: Cannot set context object for internal context.
QQmlContext: Cannot set property on internal context.
  
  That is what breaks the translations in this case and used to work until we 
shared `QQmlEngines` between the KCM and the window around it. However, if we 
don't then the KCM uses the Plasma Qt Quick Controls style which is also 
undesirable. We also don't want separate `QQmlEngine`s as then you run into 
bugs and crashes since we would have objects (e.g. context properties and 
singletons) between engines and they clean up each other's stuff and crash.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16595

To: aacid, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

[Albert Astals Cid]

aacid added a comment.


  In D16595#352466 , @broulik wrote:
  
  > This is only covering an underlying problem where `KDeclarative` fails to 
set the translation context on `QQmlContext` as the engines are shared and it 
then refuses to set anything on the "internal context". But since I haven't 
found a solution, perhaps this is better than having non-translated UI
  
  
  Where in kdeclarative/plasma-framework are you trying to set the translation 
context?
  
  I had a quick look without knowing anything about the architecture and it 
seems ConfigViewPrivate::init would be the place, but there's nothing there. Or 
you mean you tried and it didn't work and that's why the code isn't there?
  
  Anyhow the thing is, it can't work, you're using this code "as a library", 
and what you have to do in library code is hardcode the translation domain 
since there can only be one "default domain" and obviously that's the applet 
here and not the kcm (which acts as a library).
  
  The thing is that most of the times in library C++ code we don't see 
ourselves hardcoding the domain via i18nd calls because we use the 
-DTRANSLATION_DOMAIN trick to do it for us, but since QML isn't compiled we 
can't have anything that, so for QML that can show in various processes we need 
to use i18nd.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16595

To: aacid
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

[Kai Uwe Broulik]

broulik added a comment.


  This is only covering an underlying problem where `KDeclarative` fails to set 
the translation context on `QQmlContext` as the engines are shared and it then 
refuses to set anything on the "internal context". But since I haven't found a 
solution, perhaps this is better than having non-translated UI

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16595

To: aacid
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag added a comment.


  Other issues:
  
  - if I remove a virtual desktop and apply settings, it's not possible anymore 
to add or remove virtual desktops;
  - if I create a virtual desktop, then for some reason the KCM will try to 
create more than one:
  
  F6377804: Screenshot_20181101_225444.png 

  (it will try to reach the maximum number of virtual desktops)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 44673.
hein added a comment.


  Fix build error.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=44672=44673

BRANCH
  arcpatch-D14542_2

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 44672.
hein retitled this revision from "KCM using new virtual desktops DBus 
interface" to "[kcmkwin/desktop] KCM using new virtual desktops DBus interface".
hein added a comment.


  Update the title.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=44671=44672

BRANCH
  arcpatch-D14542_2

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 44671.
hein added a comment.


  - Sync ids before syncing names.
  - Remove the dummy id swap, it's no longer needed given the above.
  - Add a class description comment that illuminates the sync/detach behavior.
  - Reindent headers.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=44498=44671

BRANCH
  arcpatch-D14542_2

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  autotests/CMakeLists.txt
  autotests/integration/virtual_desktop_test.cpp
  autotests/test_window_paint_data.cpp
  dbusinterface.cpp
  dbusinterface.h
  deleted.cpp
  deleted.h
  effects.cpp
  effects/desktopgrid/desktopgrid.cpp
  effects/desktopgrid/desktopgrid.h
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h
  org.kde.KWin.VirtualDesktopManager.xml
  toplevel.h
  unmanaged.cpp
  unmanaged.h
  useractions.cpp
  useractions.h
  virtualdesktops.cpp
  virtualdesktops.h
  virtualdesktopsdbustypes.cpp
  virtualdesktopsdbustypes.h
  wayland_server.cpp
  wayland_server.h
  workspace.cpp
  workspace.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> desktopsmodel.cpp:253
> +
> +call.setArguments({m_desktops.last()});
> +

Is m_desktops.last() the right one? It can be already deleted.

For example, If user has two virtual desktops:

- Desktop 1
- Pizza

and he or she wants to delete virtual desktop called "Pizza", then Desktop 1 
will be removed instead.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag requested changes to this revision.
zzag added inline comments.

INLINE COMMENTS

> desktopsmodel.cpp:413
> +// so we can determine when we are in sync.
> +const QString  = m_desktops.at(data.position);
> +m_names.remove(dummyId);

Is this right?

If I remove a desktop in the KCM(without applying settings) and create a new 
one using the d-bus interface, the KCM will crash.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D16598: enable animations for standalone created buttons

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R113:f88caf298dbe: enable animations for standalone created 
buttons (authored by mvourlakos).

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16598?vs=44667=44668

REVISION DETAIL
  https://phabricator.kde.org/D16598

AFFECTED FILES
  kdecoration/oxygenbutton.cpp

To: mvourlakos, #plasma, hpereiradacosta, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[Nathaniel Graham]

ngraham added a subscriber: hein.
ngraham added a comment.


  To me, using `Qt::ToolButtonFollowStyle` would seem to make sense, but it 
might be best to ask @mart or @hein, who may know more of the history behind 
why `Qt::ToolButtonTextBesideIcon` was chosen here in the first place.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich, mart, apol
Cc: hein, mgallien, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16598: enable animations for standalone created buttons

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, hpereiradacosta, zzag.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --as mentioned at T9899  we are not 
calling the correct
  creator when buttons are created in Standalone mode and
  as such animations are disabled when OxygenButton is created
  from plasma applets. This patch fixes this and restores
  the Standalone behavior mode in order to be identical
  with the default one.

TEST PLAN
  -check that window title bars still work
  -check that when buttons are used in a plasma applet
  they are animated

REPOSITORY
  R113 Oxygen Theme

BRANCH
  fixCreator

REVISION DETAIL
  https://phabricator.kde.org/D16598

AFFECTED FILES
  kdecoration/oxygenbutton.cpp

To: mvourlakos, #plasma, hpereiradacosta, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[Alexander Stippich]

astippich added a subscriber: mgallien.
astippich added a comment.


  @mgallien stated in the meantime that we probably have been abusing the 
ToolButton in Elisa for our needs, and we will go a different route anyway.
  Since the desktop style still behaves differently than QQC1 and the Fusion 
style, I think it's still of value to discuss this. I will just follow your 
call here, tell me what the right solution is :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich, mart, apol
Cc: mgallien, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16596: enable animations for standalone created buttons

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:19348e1ccb32: enable animations for standalone created 
buttons (authored by mvourlakos).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16596?vs=44663=44664

REVISION DETAIL
  https://phabricator.kde.org/D16596

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: mvourlakos, #breeze, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.14.2 released

[Luna Jernberg]

Updated :)

On Wed, Oct 24, 2018 at 2:31 AM Bhushan Shah  wrote:

> Plasma 5.14.2 is released :
> https://www.kde.org/announcements/plasma-5.14.2.php
>
> Thanks!
>
> --
> Bhushan Shah
> http://blog.bshah.in
> IRC Nick : bshah on Freenode
> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
>

D16596: enable animations for standalone created buttons

[Michail Vourlakos]

mvourlakos updated this revision to Diff 44663.
mvourlakos added a comment.


  - fix comment description

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16596?vs=44662=44663

BRANCH
  fixCreator

REVISION DETAIL
  https://phabricator.kde.org/D16596

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: mvourlakos, #breeze, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16596: enable animations for standalone created buttons

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Breeze, zzag.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --as mentioned at T9899  we are not 
calling the correct
  creator when buttons are created in Standalone mode and
  as such animations are disabled when BreezeButton is created
  from plasma applets. This patch fixes this and restores
  the Standalone behavior mode in order to be identical
  with the default one.

TEST PLAN
  -check that window title bars still work 
  -check that breeze window buttons in titlebar editor buttons
  still work
  -check that when buttons are used in a plasma applet
  they are animated

REPOSITORY
  R31 Breeze

BRANCH
  fixCreator

REVISION DETAIL
  https://phabricator.kde.org/D16596

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: mvourlakos, #breeze, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  You can get to this code by right clicking on the plasmoid, when doing that 
the kcm translation catalog is not loaded so we must make all th1 i18n calls be 
i18nd calls and specify the catalog manually

TEST PLAN
  it works

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16595

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DefaultDeviceButton.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[Nathaniel Graham]

ngraham added a comment.


  Wouldn't this change make it revert to the default value, which is 
`Qt::ToolButtonIconOnly` 
? How about 
`Qt::ToolButtonFollowStyle` instead? That way it'll pick up the 
user-overridable setting in the style KCM.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich, mart, apol
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[Alexander Stippich]

astippich added a comment.


  opinions?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16404: [Bookmarks Runner] Cleanup tests CMakeList

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16404

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I understand what you're doing with the syncing now, it makes sense in 
principle.
  Can you copy-paste what you typed to me into the code.

INLINE COMMENTS

> desktopsmodel.cpp:202
> +
> +m_desktops[desktopIndex] = id;
> +m_names[id] = name;

this is setting it to the value it already is

> desktopsmodel.cpp:251
> +s_virtualDesktopsInterface,
> +QStringLiteral("removeDesktop"));
> +

If I have 3 desktops with 3 IDs
id1 -> desktop1
id2 -> desktop2
id3 -> desktop3

and I delete desktop2

Here I delete 3 and then sync the names,  leaving me with:
id1 -> desktop1
id2 -> desktop3

it looks fine within the confines of this KCM, but as soon as we  rely on those 
IDs for external use (even just the fact that a user might have his windows on 
id3 and none on id2) it'll fall apart.

--

When you make the change sending insert/remove instead of renaming we'll need 
to make sure we  do removal before insertion.

desktopCreated relies on the index of the newly created desktop to be in the 
same place as m_desktops has it.

If we insert first, the position will be off as the server will still have the 
about-to-be-deleted entries

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 143 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/143/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 01 Nov 2018 16:50:42 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: (root) Failed: 19 test(s), Passed: 111 test(s), Skipped: 0 test(s), Total: 130 test(s)Failed: TestSuite.kwin-testColorCorrectNightColorFailed: TestSuite.kwin-testColorCorrectNightColor-waylandonlyFailed: TestSuite.kwin-testDontCrashAuroraeDestroyDecoFailed: TestSuite.kwin-testFadeFailed: TestSuite.kwin-testKWinBindingsFailed: TestSuite.kwin-testKWinBindings-waylandonlyFailed: TestSuite.kwin-testKeyboardLayoutFailed: TestSuite.kwin-testKeyboardLayout-waylandonlyFailed: TestSuite.kwin-testMaximizedFailed: TestSuite.kwin-testMaximized-waylandonlyFailed: TestSuite.kwin-testQuickTilingFailed: TestSuite.kwin-testScriptedEffectLoaderFailed: TestSuite.kwin-testShellClientFailed: TestSuite.kwin-testShellClient-waylandonlyFailed: TestSuite.kwin-testSlidingPopupsFailed: TestSuite.kwin-testTranslucencyFailed: TestSuite.kwin-testVirtualDesktopFailed: TestSuite.kwin-testVirtualDesktop-waylandonlyFailed: TestSuite.kwin-testXClipboardSync
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(56/83)55%
(293/530)55%
(293/530)40%
(26586/67219)29%
(12479/42584)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault87%
(131/151)87%
(131/151)62%
(17164/27631)46%
(9102/19613)colorcorrection80%
(4/5)80%
(4/5)38%
(181/477)15%
(47/312)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)78%
(358/458)61%
(111/182)effects100%
(2/2)100%
(2/2)97%
(72/74)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(13/345)5%
(12/242)effects.blur20%
(1/5)20%
(1/5)2%
(13/652)4%
(13/369)effects.colorpicker100%
(2/2)100%
(2/2)22%
(12/55)9%
(2/22)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(3/1281)0%
(0/1013)effects.cubeslide33%
(1/3)33%
(1/3)5%
(24/465)1%
(5/370)effects.desktopgrid67%
(2/3)67%
(2/3)7%
(73/1013)3%
(27/952)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/232)2%
(3/160)effects.dimscreen100%
(1/1)100%
(1/1)18%
(10/57)0%
(0/72)effects.fallapart100%
(2/2)100%
  

D14542: KCM using new virtual desktops DBus interface

[Eike Hein]

hein added a comment.


  In D14542#352260 , @zzag wrote:
  
  > Please wait for others.
  >
  > When you're about to push, please:
  >
  > - re-title this patch to "[kcmkwin/desktop] Use new ...";
  > - shift access modifiers and everything that goes below 4 spaces to the 
left (that's one of my inline comments).
  
  
  Will do

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added a comment.


  Please wait for others.
  
  When you're about to push, please:
  
  - re-title this patch to "[kcmkwin/desktop] Use new ...";
  - shift access modifiers and everything that goes below 4 spaces to the left 
(that's one of my inline comments).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Looks great, I'm happy to finally see this get cleaned up.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 142 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/142/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 01 Nov 2018 15:36:02 +
 Build duration:
5 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 623.83 KB...][ 30%] Building CXX object autotests/CMakeFiles/testVirtualKeyboardDBus.dir/test_virtualkeyboard_dbus.cpp.oScanning dependencies of target testVirtualDesktops[ 31%] Building CXX object autotests/CMakeFiles/testVirtualDesktops.dir/test_virtual_desktops.cpp.oScanning dependencies of target testGestures[ 31%] Linking CXX executable ../bin/testClientMachine[ 31%] Building CXX object autotests/CMakeFiles/testGestures.dir/test_gestures.cpp.oScanning dependencies of target testXcbSizeHints[ 31%] Building CXX object autotests/CMakeFiles/testXcbSizeHints.dir/test_xcb_size_hints.cpp.o[ 31%] Built target testClientMachine[ 31%] Building CXX object autotests/CMakeFiles/testGestures.dir/__/gestures.cpp.o[ 31%] Linking CXX executable ../bin/testOpenGLContextAttributeBuilder[ 31%] Linking CXX executable ../bin/testXcbWrapper[ 31%] Building CXX object autotests/CMakeFiles/testGestures.dir/testGestures_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/mock_workspace.cpp.o[ 31%] Built target testOpenGLContextAttributeBuilder[ 31%] Building CXX object autotests/CMakeFiles/testVirtualKeyboardDBus.dir/__/virtualkeyboard_dbus.cpp.o[ 31%] Built target testXcbWrapper[ 31%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/__/screens.cpp.o[ 31%] Building CXX object autotests/CMakeFiles/testXcbSizeHints.dir/testXcbSizeHints_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/__/plugins/platforms/x11/standalone/screens_xrandr.cpp.o[ 31%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/__/xcbutils.cpp.o[ 32%] Linking CXX executable ../bin/testGesturesScanning dependencies of target testOnScreenNotification[ 32%] Building CXX object autotests/CMakeFiles/testOnScreenNotification.dir/onscreennotificationtest.cpp.o[ 32%] Building CXX object autotests/CMakeFiles/testVirtualKeyboardDBus.dir/testVirtualKeyboardDBus_autogen/mocs_compilation.cpp.o[ 32%] Building CXX object autotests/CMakeFiles/testOnScreenNotification.dir/__/onscreennotification.cpp.o[ 32%] Built target testGestures[ 32%] Building CXX object autotests/CMakeFiles/testOnScreenNotification.dir/__/input_event_spy.cpp.o[ 32%] Linking CXX executable ../bin/testVirtualKeyboardDBus[ 32%] Built target testVirtualKeyboardDBus[ 32%] Building CXX object autotests/CMakeFiles/testOnScreenNotification.dir/testOnScreenNotification_autogen/mocs_compilation.cpp.o[ 32%] Building CXX object autotests/CMakeFiles/testVirtualDesktops.dir/__/virtualdesktops.cpp.o/home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.11/virtualdesktops.cpp:29:10: fatal error: KWayland/Server/plasmavirtualdesktop_interface.h: No such file or directory #include   ^~compilation terminated.make[2]: *** [autotests/CMakeFiles/testVirtualDesktops.dir/build.make:76: autotests/CMakeFiles/testVirtualDesktops.dir/__/virtualdesktops.cpp.o] Error 1make[2]: *** Waiting for unfinished jobsScanning dependencies of target testXcbWindow[ 33%] Building CXX object autotests/CMakeFiles/testXcbWindow.dir/test_xcb_window.cpp.o[ 33%] Generating screenlocker_interface.cpp, screenlocker_interface.hScanning dependencies of target testScreensmake[1]: *** [CMakeFiles/Makefile2:7753: autotests/CMakeFiles/testVirtualDesktops.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 33%] Building CXX object autotests/CMakeFiles/testScreens.dir/test_screens.cpp.o[ 34%] Generating screenlocker_interface.moc[ 34%] Building CXX object autotests/CMakeFiles/testXcbWindow.dir/testXcbWindow_autogen/mocs_compilation.cpp.o[ 34%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/__/x11eventfilter.cpp.oScanning dependencies of target testScreenEdges[ 34%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/__/orientation_sensor.cpp.o[ 34%] Linking CXX executable ../bin/testXcbSizeHints[ 34%] Building CXX object autotests/CMakeFiles/testScreenEdges.dir/test_screen_edges.cpp.o[ 34%] Building CXX object autotests/CMakeFiles/testXRandRScreens.dir/settings.cpp.o[ 34%] Building CXX object autotests/CMakeFiles/testScreenEdges.dir/mock_abstract_client.cpp.o[ 34%] Built target testXcbSizeHints[ 34%] Building CXX object autotests/CMakeFiles/testScreens.dir/mock_abstract_client.cpp.o[ 35%] Linking CXX executable ../bin/testOnScreenNotification[ 35%] Building CXX object autotests/CMakeFiles/testScreens.dir/mock_client.cpp.o[ 36%] Building CXX object autotests/CMakeFiles/testScreens.dir/mock_screens.cpp.o[ 36%] Building CXX object autotests/CMakeFiles/testScreenEdges.dir/mock_client.cpp.o[ 36%] Built target testOnScreenNotification[ 36%] Building CXX object 

[Powerdevil] [Bug 360162] Segfault at startup (just after login)

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=360162

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Andrew Crouthamel  ---
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test
if the bug is valid in the latest version? I am setting the status to NEEDSINFO
pending your response, please change the Status back to REPORTED when you
respond.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D16587: [ksmserver] Simplify call to kcminit

[David Edmundson]

davidedmundson updated this revision to Diff 44630.
davidedmundson added a comment.


  remove Q_SIGNALS

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16587?vs=44628=44630

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16587: [ksmserver] Simplify call to kcminit

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> main.h:37
>  Q_SCRIPTABLE void runPhase2();
> -Q_SIGNALS: //dbus signal
> - Q_SCRIPTABLE void phase1Done();
> - Q_SCRIPTABLE void phase2Done();
> +Q_SIGNALS:
>  public:

It looks like there are no more signals anymore. Do we need Q_SIGNALS?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16587

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16587: [ksmserver] Simplify call to kcminit

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  kcminit had a slot to start processing something and a signal to emit
  when it's finished.
  
  For DBus that's quite bad practice as it can leave you hanging in the
  case of a kcminit crashing. It's better to use the return of the
  original call to signal when something is done.
  
  From ksmserver we can then just use DBus timeouts set on the interface
  than a secondary timer.
  
  We also remove a pointless blocking call to kcminit introspecting
  everything, if kcminit is not running it will return with an error
  immediately which is no slower than checking first if it's not running
  and faster if it is.

TEST PLAN
  Logged in
  Session logs showed kcminit ran

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart