D16595: Fix i18n when the kcm code is embedded in the plasmoid config

2018-11-05 Thread Albert Astals Cid
aacid added a comment.


  Ok, understood, there's a plan to maybe make it work but isn't really working.
  
  Can i commit this today so it gets in Plasma 5.14.3 and our users get to 
understand the UI?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16595

To: aacid, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


Re: Downtime announcement: www.kde.org

2018-11-05 Thread Ben Cooksley
On Sat, Nov 3, 2018 at 7:50 AM Ben Cooksley  wrote:
>
> Hi all,

Hi all,

>
> In order to allow for hardware maintenance, one of our physical
> hardware hosts will need to be shutdown for a few hours on Monday.
> This downtime will commence around 9:30am UTC and may take several
> hours.
>
> During this time a number of sites will be inaccessible, including:
> - www.kde.org
> - autoconfig.kde.org
> - docs.kde.org
> - ev.kde.org
> - freebsd.kde.org
> - hig.kde.org
> - kdesrc-build.kde.org
> - neon.kde.org
> - releases.neon.kde.org
> - networkcheck.kde.org
> - planet.kde.org
>
> Other websites within KDE.org that are dependent on resources hosted
> on those sites may also experience delayed loading times in browsers
> during this window.
>
> As some of these sites are relied upon by applications to function
> properly, those applications may experience degraded functionality
> during this time.
>
> Affected applications include:
> - Discover
> - Kaffeine
> - Kopete
> - Plasma Network Manager (when behind a captive portal)
> - Any application using GHNS
>
> In addition, any other site which is hosted by the server known as
> "olios.kde.org" will also be unavailable during this time.
>
> Apologies for any inconvenience caused.

The maintenance window has now commenced.
The above sites will be inaccessible until the maintenance is completed.

>
> Regards,
> Ben Cooksley
> KDE Sysadmin

Regards,
Ben


D7769: [Task Manager] Use Grid for grouped and single tooltips

2018-11-05 Thread Roman Gilg
romangg abandoned this revision.
romangg added a comment.


  Has been made unnecessary by 1e218b405bee 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7769

To: romangg, #plasma, davidedmundson, hein
Cc: cfeck, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

2018-11-05 Thread Roman Gilg
romangg abandoned this revision.
romangg added a comment.


  Has been made unnecessary by 1e218b405bee 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: romangg, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
[sending again from right address since my gmail address is not
subscribed to somee lists]

Hello,

On Mon, Nov 05, 2018 at 11:02:43PM +1300, Ben Cooksley wrote:
> > In order to allow for hardware maintenance, one of our physical
> > hardware hosts will need to be shutdown for a few hours on Monday.
> > This downtime will commence around 9:30am UTC and may take several
> > hours.

The maintenance is now completed, and as far as we are aware, all
services are now back up. If you have trouble accessing any of services,
please let us know over email or sysadmin ticket.

Thanks!

> >
> > During this time a number of sites will be inaccessible, including:
> > - www.kde.org
> > - autoconfig.kde.org
> > - docs.kde.org
> > - ev.kde.org
> > - freebsd.kde.org
> > - hig.kde.org
> > - kdesrc-build.kde.org
> > - neon.kde.org
> > - releases.neon.kde.org
> > - networkcheck.kde.org
> > - planet.kde.org
> >
> > Other websites within KDE.org that are dependent on resources hosted
> > on those sites may also experience delayed loading times in browsers
> > during this window.
> >
> > As some of these sites are relied upon by applications to function
> > properly, those applications may experience degraded functionality
> > during this time.
> >
> > Affected applications include:
> > - Discover
> > - Kaffeine
> > - Kopete
> > - Plasma Network Manager (when behind a captive portal)
> > - Any application using GHNS
> >
> > In addition, any other site which is hosted by the server known as
> > "olios.kde.org" will also be unavailable during this time.
> >
> > Apologies for any inconvenience caused.
> 
> The maintenance window has now commenced.
> The above sites will be inaccessible until the maintenance is completed.
> 
> >
> > Regards,
> > Ben Cooksley
> > KDE Sysadmin
> 
> Regards,
> Ben

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature


D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
apol created this revision.
apol added reviewers: Frameworks, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This (random) height shows an odd padding on the menu when there's just the 
one
  element.
  
  CCBUG: 400517

TEST PLAN
  I don't get it anymore on Discover

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16685

AFFECTED FILES
  org.kde.desktop/Menu.qml

To: apol, #frameworks, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems like this is only a problem if you have a single-item menu, and if you 
have that, you've done something wrong. :) Regardless, this seems to fix the 
issue, so +1.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16685

To: apol, #frameworks, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8fa114df0ad1: Fix issue where there's only one 
element on the menu (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16685?vs=44908&id=44913

REVISION DETAIL
  https://phabricator.kde.org/D16685

AFFECTED FILES
  org.kde.desktop/Menu.qml

To: apol, #frameworks, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16638: Set focus on the actual items in the window switcher

2018-11-05 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 44925.
gladhorn retitled this revision from "Handle focus in the window switcher" to 
"Set focus on the actual items in the window switcher".
gladhorn edited the summary of this revision.
gladhorn edited the test plan for this revision.
gladhorn edited reviewers, added: kwin; removed: KWin.
gladhorn removed subscribers: zzag, romangg, broulik.
gladhorn added a comment.


  After the change in KWin only this is needed

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16638?vs=44856&id=44925

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16638

AFFECTED FILES
  lookandfeel/contents/windowswitcher/WindowSwitcher.qml

To: gladhorn, davidedmundson, chempfling, kwin, #kwin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, zzag, romangg, broulik


D16638: Add accessibility and set focus on the actual items in the window switcher

2018-11-05 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 44926.
gladhorn retitled this revision from "Set focus on the actual items in the 
window switcher" to "Add accessibility and set focus on the actual items in the 
window switcher".
gladhorn added a comment.


  Changed it to be more pleasant by using client as role and set the focus on 
the top level, so that the geometry is also more sensible.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16638?vs=44925&id=44926

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16638

AFFECTED FILES
  lookandfeel/contents/windowswitcher/WindowSwitcher.qml

To: gladhorn, davidedmundson, chempfling, kwin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16690: [Baloo Runner] Filter duplicates and prefer specific type matches

2018-11-05 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, ngraham, sitter, michaelh.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A Presentation is also a Document so it would show up twice.
  This patch filters out URLs we have already found and moves searching for 
specific types (Presentation, Spreadsheet) before the more generic Document 
type.

TEST PLAN
  Searched for Presentation, my presentation.odp showed up only once as 
"Presentation".
  
  Probably good for 5.14 too

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16690

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h

To: broulik, #plasma, ngraham, sitter, michaelh
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16651: Honor flat property of buttons

2018-11-05 Thread Alexander Stippich
astippich marked an inline comment as done.
astippich added a comment.


  How can I actually run this test?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16651

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16651: Honor flat property of buttons

2018-11-05 Thread Alexander Stippich
astippich updated this revision to Diff 44934.
astippich added a comment.


  - do not unnecessarily check flat property

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16651?vs=44800&id=44934

BRANCH
  flat

REVISION DETAIL
  https://phabricator.kde.org/D16651

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16659: Size according to specified icon width and height

2018-11-05 Thread Alexander Stippich
astippich updated this revision to Diff 44936.
astippich added a comment.


  - only query pixelMetric on demand

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16659?vs=44828&id=44936

BRANCH
  icon_size

REVISION DETAIL
  https://phabricator.kde.org/D16659

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16658: Respect the display property of buttons

2018-11-05 Thread Alexander Stippich
astippich added a comment.


  
  
  In D16658#354233 , @apol wrote:
  
  > I guess we can wait until we can bump to Qt 5.10 as a dependency? This 
looks a bit chaotic.
  
  
  
  
  > Also the Under/Beside setting isn't taken into account yet.
  
  Yep, forgot that to mention, but icon below the text is not something I 
currently care about.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16658

To: astippich, #plasma, apol, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16638: Add accessibility and set focus on the actual items in the window switcher

2018-11-05 Thread Frederik Gladhorn
gladhorn closed this revision.
gladhorn added a comment.


  This is in I'm unsure why "arc land" didn't close it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16638

To: gladhorn, davidedmundson, chempfling, kwin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16622: [Plasmoid] Clean up layout

2018-11-05 Thread Nathaniel Graham
ngraham added a comment.


  Is this good to go now?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D16622

To: ngraham, #plasma, broulik, #vdg
Cc: Codezela, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16536: [fontinst KCM] Slightly modernize layout

2018-11-05 Thread Nathaniel Graham
ngraham added a comment.


  Ping! #VDG  or #plasma 
?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16536

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16536: [fontinst KCM] Slightly modernize layout

2018-11-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8a74e73228ef: [fontinst KCM] Slightly modernize layout 
(authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16536?vs=44523&id=44940

REVISION DETAIL
  https://phabricator.kde.org/D16536

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
  kcms/kfontinst/kcmfontinst/KCmFontInst.h

To: ngraham, #plasma, #vdg, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16697: [Kickoff] Fix context menu not appearing on right-click

2018-11-05 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, hein, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right-clicking on list items to bring up a context menu broke with
48b32259e73f374a456ed836ba44e3effe2baee5 
. 
This fixes it. Thanks to @kbroulik for finding this; I'm submitting it on his 
behalf because he's super busy right now.

TEST PLAN
  Right-click on a list item in Kickoff -> now a context menu appears

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-right-click-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16697

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffListView.qml

To: ngraham, #plasma, hein, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart