D15512: [startplasmacompositor] Add Wayland socket argument

[Martin Flöser]

graesslin added a comment.


  KWin does not have functionality to generate the socket. KWin doesn't need 
this functionality and shouldn't have this functionality and it would be 
difficult to implement. Given that I fully support this change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15512

To: romangg, #kwin, #plasma
Cc: graesslin, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16873: [comic] Request current identifier on date changed

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  The problem is when date is changed we connect to source ex. 
dilbert:2018-11-14 but in other hand script (main.es) makes
  
  if (comic.identifier.toString() == date.currentDate().toString()) {
  
comic.requestPage("http://dilbert.com/";, comic.User, infos);
  
  so provider do its job but dataengine does not have a data for us, cause 
identifier is dilbert: and we are not connected to, so dataUpdated is not 
called which cause busy indicator to eats cpu power. Another fix can be to have 
permanently connection to comic_name: to enter dataUpdated in any case.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16873

AFFECTED FILES
  applets/comic/comic.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for crosshair cursors

[Noah Davis]

ndavis added a comment.


  In D16861#359193 , @ngraham wrote:
  
  > Imagine that, reading the README. :) If manual work is required for each 
image, that seems like all the more reason to only include the two changed ones 
in the diff.
  
  
  Yep. This is a terrible workflow. I hope all of this is simpler in Wayland. 
One SVG for each cursor and just using the SVGs as cursor files would be ideal.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Nathaniel Graham]

ngraham added a comment.


  Imagine that, reading the README. :) If manual work is required for each 
image, that seems like all the more reason to only include the two changed ones 
in the diff.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Noah Davis]

ndavis planned changes to this revision.
ndavis added a comment.


  Hmm some of the cursors seem blurrier than they used to be and I have no idea 
why.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

[Nathaniel Graham]

ngraham added a comment.


  Now that I think about it, maybe we keep it the way it is and see if anyone 
actually complains rather than trying to make the perfect the enemy of the 
good. I don't think I've actually heard any complaints from the jack always 
displaying a headphone icon in the applet itself.
  
  That said, now I'm wondering whether or not showing an OSD for this is really 
all that useful. I personally don't like pop-ups and notifications that 
essentially say, "Hey, you just did a thing!" It's like, duh, I know I did a 
thing, you don't need to tell me because I just did it! Those kinds of 
notifications are just noise.
  
  Thoughts?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Nathaniel Graham]

ngraham added a comment.


  FWIW the actual crosshair cursors seem better to me now, especially the 
Breeze snow one. You could maybe just take the changed files for the crosshairs 
and make a new diff with just them if you can't figure out the other issue.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Noah Davis]

ndavis added a comment.


  I think I found the reason why the prebuilt cursor themes are included in the 
repo in the README:
  
  > No trimming will have been done to the cursors, and X11 *may* give you 
split-second glitches when switching cursors making them appear to 'jump' for 
an instant. To remedy this, you will need to open any auto-generated in gimp 
and re-export when with the “trim whitespace” option checked. I do not beleive 
it impacts all versions of X, or Wayland.
  
  
  
  > You will need the “X11 Mouse Cursor (XMC)” plugin for GIMP installed to 
trim the cursors if you choose to do so.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

[David Rosca]

drosca added a comment.


  In D16082#359173 , @ngraham wrote:
  
  > Maybe we could use a generic icon, or make a new one that depicts speakers 
plus headphones or something?
  
  
  It can be any device really, not just speakers/headphones, as long as it has 
jack. If this icon has to reflect the reality, then it should be (un)plugged 
jack.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16861: Improve contrast for Breeze Snow and the Breeze crosshair

[Noah Davis]

ndavis added a comment.


  In D16861#359170 , @ngraham wrote:
  
  > So is there a script that regenerates all the X11 cursor files from the SVG 
whenever it's changed or something? Because I'm willing to bet you didn't 
change all 654 cursors...
  
  
  There's a `build.sh` file that uses `xcursorgen`. I used that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

[Nathaniel Graham]

ngraham added a comment.


  In D16082#356111 , @thsurrel wrote:
  
  > So now the question is whether it is acceptable to show a headphone on the 
OSD when we could have been plugging something else in the jack.
  
  
  I don't think so, sorry. I think this would be very confusing for people who 
plug speakers into their laptops. The bug is not very noticeable as long as the 
wrong icon is only displayed in plasma-pa itself, but with this patch, the 
wrong icon will be shoved in the user's face every time they plug in something 
that's not headphones.
  
  Maybe we could use a generic icon, or make a new one that depicts speakers 
plus headphones or something?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  So is there a script that regenerates all the X11 cursor files from the SVG 
whenever it's changed or something? Because I'm willing to bet you didn't 
change all 654 cursors...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  I'd like to remove the extra junk, but I don't want to break anything either.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis updated this revision to Diff 45434.
ndavis added a comment.


  Improve contrast for Breeze Snow and Breeze crosshair

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16861?vs=45429&id=45434

BRANCH
  better-crosshair-cursor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16861

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/alias
  cursors/Breeze/Breeze/cursors/all-scroll
  cursors/Breeze/Breeze/cursors/bottom_left_corner
  cursors/Breeze/Breeze/cursors/bottom_right_corner
  cursors/Breeze/Breeze/cursors/bottom_side
  cursors/Breeze/Breeze/cursors/cell
  cursors/Breeze/Breeze/cursors/center_ptr
  cursors/Breeze/Breeze/cursors/col-resize
  cursors/Breeze/Breeze/cursors/color-picker
  cursors/Breeze/Breeze/cursors/context-menu
  cursors/Breeze/Breeze/cursors/copy
  cursors/Breeze/Breeze/cursors/crosshair
  cursors/Breeze/Breeze/cursors/default
  cursors/Breeze/Breeze/cursors/dnd-move
  cursors/Breeze/Breeze/cursors/dnd-no-drop
  cursors/Breeze/Breeze/cursors/down-arrow
  cursors/Breeze/Breeze/cursors/draft
  cursors/Breeze/Breeze/cursors/fleur
  cursors/Breeze/Breeze/cursors/help
  cursors/Breeze/Breeze/cursors/left-arrow
  cursors/Breeze/Breeze/cursors/left_side
  cursors/Breeze/Breeze/cursors/no-drop
  cursors/Breeze/Breeze/cursors/not-allowed
  cursors/Breeze/Breeze/cursors/openhand
  cursors/Breeze/Breeze/cursors/pencil
  cursors/Breeze/Breeze/cursors/pirate
  cursors/Breeze/Breeze/cursors/pointer
  cursors/Breeze/Breeze/cursors/progress
  cursors/Breeze/Breeze/cursors/right-arrow
  cursors/Breeze/Breeze/cursors/right_ptr
  cursors/Breeze/Breeze/cursors/right_side
  cursors/Breeze/Breeze/cursors/row-resize
  cursors/Breeze/Breeze/cursors/size_bdiag
  cursors/Breeze/Breeze/cursors/size_fdiag
  cursors/Breeze/Breeze/cursors/size_hor
  cursors/Breeze/Breeze/cursors/size_ver
  cursors/Breeze/Breeze/cursors/text
  cursors/Breeze/Breeze/cursors/top_left_corner
  cursors/Breeze/Breeze/cursors/top_right_corner
  cursors/Breeze/Breeze/cursors/top_side
  cursors/Breeze/Breeze/cursors/up-arrow
  cursors/Breeze/Breeze/cursors/vertical-text
  cursors/Breeze/Breeze/cursors/wait
  cursors/Breeze/Breeze/cursors/wayland-cursor
  cursors/Breeze/Breeze/cursors/x-cursor
  cursors/Breeze/Breeze/cursors/zoom-in
  cursors/Breeze/Breeze/cursors/zoom-out
  cursors/Breeze/build/x1/alias.png
  cursors/Breeze/build/x1/all-scroll.png
  cursors/Breeze/build/x1/bottom_left_corner.png
  cursors/Breeze/build/x1/bottom_right_corner.png
  cursors/Breeze/build/x1/bottom_side.png
  cursors/Breeze/build/x1/cell.png
  cursors/Breeze/build/x1/center_ptr.png
  cursors/Breeze/build/x1/col-resize.png
  cursors/Breeze/build/x1/color-picker.png
  cursors/Breeze/build/x1/context-menu.png
  cursors/Breeze/build/x1/copy.png
  cursors/Breeze/build/x1/crosshair.png
  cursors/Breeze/build/x1/default.png
  cursors/Breeze/build/x1/dnd-move.png
  cursors/Breeze/build/x1/dnd-no-drop.png
  cursors/Breeze/build/x1/down-arrow.png
  cursors/Breeze/build/x1/draft.png
  cursors/Breeze/build/x1/fleur.png
  cursors/Breeze/build/x1/help.png
  cursors/Breeze/build/x1/left-arrow.png
  cursors/Breeze/build/x1/left_side.png
  cursors/Breeze/build/x1/no-drop.png
  cursors/Breeze/build/x1/not-allowed.png
  cursors/Breeze/build/x1/openhand.png
  cursors/Breeze/build/x1/pencil.png
  cursors/Breeze/build/x1/pirate.png
  cursors/Breeze/build/x1/pointer.png
  cursors/Breeze/build/x1/progress-01.png
  cursors/Breeze/build/x1/progress-02.png
  cursors/Breeze/build/x1/progress-03.png
  cursors/Breeze/build/x1/progress-04.png
  cursors/Breeze/build/x1/progress-05.png
  cursors/Breeze/build/x1/progress-06.png
  cursors/Breeze/build/x1/progress-07.png
  cursors/Breeze/build/x1/progress-08.png
  cursors/Breeze/build/x1/progress-09.png
  cursors/Breeze/build/x1/progress-10.png
  cursors/Breeze/build/x1/progress-11.png
  cursors/Breeze/build/x1/progress-12.png
  cursors/Breeze/build/x1/progress-13.png
  cursors/Breeze/build/x1/progress-14.png
  cursors/Breeze/build/x1/progress-15.png
  cursors/Breeze/build/x1/progress-16.png
  cursors/Breeze/build/x1/progress-17.png
  cursors/Breeze/build/x1/progress-18.png
  cursors/Breeze/build/x1/progress-19.png
  cursors/Breeze/build/x1/progress-20.png
  cursors/Breeze/build/x1/progress-21.png
  cursors/Breeze/build/x1/progress-22.png
  cursors/Breeze/build/x1/progress-23.png
  cursors/Breeze/build/x1/progress.png
  cursors/Breeze/build/x1/right-arrow.png
  cursors/Breeze/build/x1/right_ptr.png
  cursors/Breeze/build/x1/right_side.png
  cursors/Breeze/build/x1/row-resize.png
  cursors/Breeze/build/x1/size_bdiag.png
  cursors/Breeze/build/x1/size_fdiag.png
  cursors/Breeze/build/x1/size_hor.png
  cursors/Breeze/build/x1/size_ver.png
  cursors/Breeze/build/x1/text.png
  cursors/Breeze/build/x1/top_left_corner.png
  cursors/Breeze/build/x1/top_right_corner.png
  cursors/Breeze/build/x1/top_side.png
  cursors/Breeze/build/x1/up-arrow.png
  cursors/Breeze/build/x1/vertical-text.png
  curso

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  Don't ask me, I just live here. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  Why do we have the cursor theme pre-built in the repo? It's making Arcanist 
take forever.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  I think either way would work. For maximum surety, I would download it 
locally and then do `arc diff --update D16861`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  What's the best way to update this diff? What I'm doing completely discards 
your changes. Should I get this diff with `arc patch D16861` and then update 
the diff from that branch or can I make my own branch and do `arc diff --update 
D16861` to overwrite your changes?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  Go for it! That bugged me too.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  I find the Breeze Snow cursors to bee generally lacking in contrast because 
of the 60% opacity outline. Should I expand this commit to improve the contrast 
for all Breeze Snow cursors as well?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ndavis, #breeze, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  In D16861#359124 , @ngraham wrote:
  
  > Would you like to take over? I have a feeling that you can do a better job 
than I can, and you also know what you're doing with the tools, too. :)
  
  
  Sure. I've basically already completed it from fooling around.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15512: [startplasmacompositor] Add Wayland socket argument

[Roman Gilg]

romangg updated this revision to Diff 45431.
romangg added a comment.


  - Use SOCKET_OPTION variable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15512?vs=41660&id=45431

BRANCH
  kwinWaylandSocketArg

REVISION DETAIL
  https://phabricator.kde.org/D15512

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: romangg, #kwin, #plasma
Cc: fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  Would you like to take over? I have a feeling that you can do a better job 
than I can, and you also know what you're doing with the tools, too. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  Turns out there already is an outline, but it's at 10% opacity instead of 
100% and the crosshair doesn't have a blurred shadow around it like the other 
breeze cursors. I think we should do our best to try to keep the crosshair 
feeling precise while also improving the contrast around it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  In D16861#359107 , @ndavis wrote:
  
  > In D16861#359106 , @ngraham 
wrote:
  >
  > > Yeah, they currently have hard edges. I'm sadly pretty abysmal with this 
kind of pixel art, but hopefully I'll muddle through...
  >
  >
  > Maybe the original cursors were made with SVG sources? Could those be found 
somewhere?
  
  
  Oh, so they were! They're right there in `cursors/Breeze/src/cursors.svg` 
`cursors/Breeze_Snow/src/cursors.svg`
  
  The good news is that this means we can do it right! The bad news is that it 
might take me a while to figure out how to get from point A to point B here. :) 
I'll give it my best shot.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  In D16861#359106 , @ngraham wrote:
  
  > Yeah, they currently have hard edges. I'm sadly pretty abysmal with this 
kind of pixel art, but hopefully I'll muddle through...
  
  
  Maybe the original cursors were made with SVG sources? Could those be found 
somewhere?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  Yeah, they currently have hard edges. I'm sadly pretty abysmal with this kind 
of pixel art, but hopefully I'll muddle through...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  Those crosshair outlines seem to be a bit jagged, unlike the other breeze 
crosshairs.
  F6421397: Screenshot_20181113_135510.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  You should probably do Breeze Snow as well since it has the exact same issue. 
In fact, it's probably even worse since a majority of websites use a white 
background.F6421382: Screenshot_20181113_135123.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham updated this revision to Diff 45429.
ngraham added a comment.


  Remove interior gradients in favor of a flat fill of the standard color

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16861?vs=45409&id=45429

BRANCH
  better-crosshair-cursor (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D16861

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/crosshair

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  In D16861#359066 , @ngraham wrote:
  
  > It is indeed a weird gradient. I was just trying to make the minimum 
required number of changes to fix the bug, but I can fix that too if you'd like.
  
  
  Yes, if you're going to add an outline like the other breeze cursor states, 
you might as well make the inside match. I think it wold probably look better 
too.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham added a comment.


  It is indeed a weird gradient. I was just trying to make the minimum required 
number of changes to fix the bug, but I can fix that too if you'd like.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[Alexander Stippich]

astippich updated this revision to Diff 45425.
astippich added a comment.


  - follow style

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16284?vs=43823&id=45425

BRANCH
  toolbutton

REVISION DETAIL
  https://phabricator.kde.org/D16284

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: astippich, mart, apol
Cc: hein, mgallien, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16658: Respect the display property of buttons

[Alexander Stippich]

astippich added a comment.


  Can I convince you to land this for Kf 5.53 with the promise to clean up once 
frameworks depends on Qt 5.10?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16658

To: astippich, #plasma, apol, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16658: Respect the display property of buttons

[Alexander Stippich]

astippich updated this revision to Diff 45424.
astippich added a comment.


  - rebase
  - more verbose comment about compatibility

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16658?vs=44827&id=45424

REVISION DETAIL
  https://phabricator.kde.org/D16658

AFFECTED FILES
  org.kde.desktop/Button.qml

To: astippich, #plasma, apol, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16659: Size according to specified icon width and height

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:66d8bdb32735: Size according to specified icon width and 
height (authored by astippich).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16659?vs=44936&id=45423

REVISION DETAIL
  https://phabricator.kde.org/D16659

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16651: Honor flat property of buttons

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8c1fb20f52a5: Honor flat property of buttons (authored by 
astippich).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16651?vs=44934&id=45422

REVISION DETAIL
  https://phabricator.kde.org/D16651

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16861: Improve crosshair cursor

[Noah Davis]

ndavis added a comment.


  What color is the area on the inside of the cursor? I'm not sure, but it 
looks like it has a gradient, which doesn't really match the other Breeze 
cursors.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D16861

To: ngraham, #breeze, #vdg, #plasma
Cc: ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 69 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/69/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 13 Nov 2018 13:36:23 +
 Build duration:
1 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 198.22 KB...]Scanning dependencies of target dummy-backend_autogenScanning dependencies of target plasma-discover_autogenScanning dependencies of target dummytest_autogenScanning dependencies of target plasma-discover-exporter_autogen[ 50%] Automatic MOC for target CategoriesTest[ 51%] Automatic MOC for target fwupd-backend[ 52%] Automatic MOC for target updatedummytest[ 53%] Automatic MOC for target dummy-backend[ 54%] Automatic MOC for target knsbackendtest[ 54%] Automatic MOC for target kns-backend[ 54%] Automatic MOC for target dummytest[ 55%] Automatic MOC for target plasma-discover[ 55%] Automatic MOC for target plasma-discover-exporter[ 55%] Built target knsbackendtest_autogen[ 55%] Built target CategoriesTest_autogen[ 55%] Built target plasma-discover-exporter_autogen[ 55%] Built target dummytest_autogen[ 55%] Built target dummy-backend_autogenScanning dependencies of target knsbackendtest[ 55%] Built target updatedummytest_autogenScanning dependencies of target plasma-discover-exporterScanning dependencies of target CategoriesTest[ 55%] Built target kns-backend_autogenScanning dependencies of target dummy-backend[ 56%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 57%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[ 58%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[ 58%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.oScanning dependencies of target dummytest[ 59%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 59%] Built target fwupd-backend_autogen[ 59%] Built target plasma-discover_autogen[ 60%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.oScanning dependencies of target updatedummytest[ 61%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 62%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 63%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.oIn file included from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/tests/KNSBackendTest.cpp:23:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/tests/../KNSBackend.h:25:10: fatal error: KNSCore/ErrorCode: No such file or directory #include   ^~~compilation terminated.make[2]: *** [libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/build.make:63: libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o] Error 1make[2]: *** Waiting for unfinished jobsScanning dependencies of target kns-backend[ 64%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.oIn file included from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/KNSBackend.cpp:47:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/KNSBackend.h:25:10: fatal error: KNSCore/ErrorCode: No such file or directory #include   ^~~compilation terminated.make[2]: *** [libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/build.make:63: libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:279: libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 65%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o[ 66%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyTransaction.cpp.omake[1]: *** [CMakeFiles/Makefile2:368: libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/all] Error 2[ 67%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummySourcesBackend.cpp.o[ 67%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/dummy-backend_autogen/mocs_compilation.cpp.o[ 68%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 69%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4, from /usr/include/qt5/QtGui/

D16715: make global menu minimize state aware

[Michail Vourlakos]

mvourlakos marked an inline comment as done.
mvourlakos added a comment.


  follow mart suggestion

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16715

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: mart, trmdi, apol, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D16715: make global menu minimize state aware

[Michail Vourlakos]

mvourlakos updated this revision to Diff 45411.
mvourlakos added a comment.


  - rename menuHidden to visible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16715?vs=45142&id=45411

BRANCH
  appMenuMinimize

REVISION DETAIL
  https://phabricator.kde.org/D16715

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: mart, trmdi, apol, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D16861: Improve crosshair cursor

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The regular Breeze crosshair cursor had no white outline like its companions, 
so it was almost impossible to distinguish against dark backgrounds. This patch 
fixes that.
  
  BUG: 400110
  FIXED-IN: 5.12.8

TEST PLAN
  Crosshair in Spectacle against a dark background:
  [image goes here]

REPOSITORY
  R31 Breeze

BRANCH
  better-crosshair-cursor (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D16861

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/crosshair

To: ngraham, #breeze, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16860: touchscreen text controls

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in MobileTextActionsToolBar.qml:25
> Can you check whether this macro substitution actually works for the 
> "private" folder?

yes it works correctly, the problem in the plasma version was the separate 
install of the style as an import

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16860

To: mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16860: touchscreen text controls

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> MobileTextActionsToolBar.qml:25
> +import QtQuick.Window 2.2
> +import QtQuick.Controls @QQC2_VERSION@
> +import org.kde.kirigami 2.5 as Kirigami

Can you check whether this macro substitution actually works for the "private" 
folder?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16860

To: mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16860: touchscreen text controls

[Marco Martin]

mart added a comment.


  F6420787: Screenshot_20181113_122130.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16860

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16860: touchscreen text controls

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  on QQC2 the controls to be able to select, cut,copy and paste text are
  responsibility of the style.
  this enables onscreen text manipulation when the system is in tabletMode
  state, just as D16841  for Plasma style

TEST PLAN
  they work when kirigami is in tablet mode, they are completely invisible when 
not
  and the system behaves completely desktop-like

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  phab/textcontrols

REVISION DETAIL
  https://phabricator.kde.org/D16860

AFFECTED FILES
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/private/MobileCursor.qml
  org.kde.desktop/private/MobileTextActionsToolBar.qml
  org.kde.desktop/private/qmldir

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16859: Rename config loading function

[Roman Gilg]

romangg updated this revision to Diff 45407.
romangg added a comment.


  - Remove unrelated change

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16859?vs=45406&id=45407

BRANCH
  configReadCleanup

REVISION DETAIL
  https://phabricator.kde.org/D16859

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16859: Rename config loading function

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Make it more explicit what it does.

TEST PLAN
  Serializer test passes.

REPOSITORY
  R104 KScreen

BRANCH
  configReadCleanup

REVISION DETAIL
  https://phabricator.kde.org/D16859

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16845: Make use of libkscreen hash API

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:740a86695df4: Make use of libkscreen hash API (authored 
by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16845?vs=45371&id=45405

REVISION DETAIL
  https://phabricator.kde.org/D16845

AFFECTED FILES
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16843: Add output and connected outputs config API

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:4be57b2027fe: Add output and connected outputs config API 
(authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16843?vs=45368&id=45403#toc

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16843?vs=45368&id=45403

REVISION DETAIL
  https://phabricator.kde.org/D16843

AFFECTED FILES
  src/config.cpp
  src/config.h
  src/output.cpp
  src/output.h

To: romangg, #plasma, davidedmundson
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D16651: Honor flat property of buttons

[Alexander Stippich]

astippich added a comment.


  friendly ping

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16651

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

[Albert Astals Cid]

aacid added a comment.


  ping?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16595

To: aacid, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 68 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/68/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 13 Nov 2018 09:10:11 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 200.46 KB...][ 54%] Automatic MOC for target plasma-discover[ 55%] Automatic MOC for target CategoriesTest[ 55%] Built target plasma-discover-exporter_autogen[ 55%] Built target knsbackendtest_autogen[ 55%] Built target dummytest_autogen[ 55%] Built target updatedummytest_autogenScanning dependencies of target plasma-discover-exporter[ 55%] Built target kns-backend_autogenScanning dependencies of target knsbackendtest[ 55%] Built target dummy-backend_autogenScanning dependencies of target dummytest[ 56%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[ 57%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[ 58%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 59%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.oScanning dependencies of target kns-backend[ 59%] Built target plasma-discover_autogenScanning dependencies of target updatedummytest[ 59%] Built target CategoriesTest_autogen[ 60%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 61%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.o[ 61%] Built target fwupd-backend_autogen[ 62%] Automatic RCC for assets.qrcScanning dependencies of target dummy-backend[ 63%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 64%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 65%] Automatic RCC for resources.qrcIn file included from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/KNSBackend.cpp:47:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/KNSBackend.h:25:10: fatal error: KNSCore/ErrorCode: No such file or directory #include   ^~~compilation terminated.make[2]: *** [libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/build.make:63: libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:279: libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/all] Error 2make[1]: *** Waiting for unfinished jobsIn file included from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/tests/KNSBackendTest.cpp:23:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/backends/KNSBackend/tests/../KNSBackend.h:25:10: fatal error: KNSCore/ErrorCode: No such file or directory #include   ^~~compilation terminated.[ 66%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.omake[2]: *** [libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/build.make:63: libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o] Error 1make[2]: *** Waiting for unfinished jobs[ 67%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.oScanning dependencies of target plasma-discover[ 68%] Building CXX object discover/CMakeFiles/plasma-discover.dir/discover_debug.cpp.omake[1]: *** [CMakeFiles/Makefile2:368: libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/all] Error 2[ 69%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/dummytest_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object discover/CMakeFiles/plasma-discover.dir/main.cpp.o[ 71%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o[ 72%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/tests/modeltest.cpp: In member function ���void ModelTest::data()���:/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.11/libdiscover/tests/modeltest.cpp:429:30: warning: comparison of integer expressions of different signedness: ���int��� and ���QFlags::Int��� {aka ���unsigned int���} [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt:

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.11 - Build # 78 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.11/78/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Tue, 13 Nov 2018 09:10:11 +
 Build duration:
45 sec and counting
   CONSOLE OUTPUT
  [...truncated 163.79 KB...][ 47%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 48%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[ 49%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 50%] Linking CXX shared library ../bin/libDiscoverNotifierDeclarativePlugin.so[ 50%] Built target DiscoverNotifierDeclarativePlugin[ 51%] Linking CXX shared library ../bin/libDiscoverCommon.so[ 51%] Built target DiscoverCommonScanning dependencies of target dummytest_autogenScanning dependencies of target CategoriesTest_autogenScanning dependencies of target kns-backend_autogenScanning dependencies of target updatedummytest_autogenScanning dependencies of target plasma-discover-exporter_autogenScanning dependencies of target knsbackendtest_autogenScanning dependencies of target dummy-backend_autogenScanning dependencies of target plasma-discover_autogen[ 53%] Automatic MOC for target plasma-discover-exporter[ 53%] Automatic MOC for target CategoriesTest[ 55%] Automatic MOC for target dummytest[ 55%] Automatic MOC for target plasma-discover[ 56%] Automatic MOC for target updatedummytest[ 57%] Automatic MOC for target kns-backend[ 58%] Automatic MOC for target knsbackendtest[ 59%] Automatic MOC for target dummy-backend[ 59%] Built target plasma-discover-exporter_autogen[ 59%] Built target dummytest_autogenScanning dependencies of target plasma-discover-exporter[ 61%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[ 61%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[ 61%] Built target knsbackendtest_autogen[ 62%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 62%] Built target kns-backend_autogen[ 62%] Built target CategoriesTest_autogen[ 62%] Built target dummy-backend_autogenScanning dependencies of target dummytestScanning dependencies of target knsbackendtest[ 63%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.o[ 64%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 64%] Built target updatedummytest_autogenScanning dependencies of target CategoriesTest[ 65%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[ 65%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.oScanning dependencies of target kns-backend[ 66%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 66%] Built target plasma-discover_autogen[ 67%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 68%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.11/libdiscover/backends/KNSBackend/tests/KNSBackendTest.cpp:23:/usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.11/libdiscover/backends/KNSBackend/tests/../KNSBackend.h:25:10: fatal error: 'KNSCore/ErrorCode' file not found#include  ^~~Scanning dependencies of target dummy-backend[ 69%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 70%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSReviews.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.11/libdiscover/backends/KNSBackend/KNSBackend.cpp:47:/usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.11/libdiscover/backends/KNSBackend/KNSBackend.h:25:10: fatal error: 'KNSCore/ErrorCode' file not found#include  ^~~[ 71%] Linking CXX executable ../bin/plasma-discover-exporterIn file included from /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.11/libdiscover/backends/KNSBackend/KNSResource.cpp:22:/usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.11/libdiscover/backends/KNSBackend/KNSBackend.h:25:10: fatal error: 'KNSCore/ErrorCode' file not found#include  ^~~1 error generated.1 error generated.gmake[2]: *** [libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/build.make:63: libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:3

D16776: Better error handling in KNewStuff backend

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:7f6caf385809: Better error handling in KNewStuff backend 
(authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16776?vs=45355&id=45398

REVISION DETAIL
  https://phabricator.kde.org/D16776

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp
  libdiscover/backends/KNSBackend/KNSBackend.h

To: leinir, #discover_software_store, apol
Cc: plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16843: Add output and connected outputs config API

[Roman Gilg]

romangg added a comment.


  In D16843#358678 , @apol wrote:
  
  > Don't we already have a hash per config?
  
  
  Not that I know of. There are output ids, but they get lost after restarts.

INLINE COMMENTS

> apol wrote in config.h:126
> X=53 :)

You mean X=15. libkscreen is part of Plasma.

REPOSITORY
  R110 KScreen Library

BRANCH
  hashApi

REVISION DETAIL
  https://phabricator.kde.org/D16843

To: romangg, #plasma, davidedmundson
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart