D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Root]

rooty added a comment.


  > FWIW make sure to test your changes with all four possible orientations.
  
  I actually figured out how to do that just before my latest edit, my bad. It 
seems to work sort of fine with the tabs on the left or the right, except for 
the lower separator (to the left/right of the tabs on the right or left, 
respectively) that seems to appear shorter than the length of the separator to 
the left/right of the tab bar before you start scrolling to the bottom.
  
  F6427659: 1.png 
  F6427660: 2.png 
  
  I don't know if this was done by design or if it's a bug, but the bottom 
separator becomes thicker to the left/right of the tab bar when you start 
flicking through the menus in the previous design (no opacity settings / width: 
root.width).
  
  F6427670: 1.png 
  F6427671: 2.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg
Cc: filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Filip Fila]

filipf added a comment.


  I didn't comment on the original patch, but I'd like to pitch in here. There 
are two issues/points of improvement for the original patch:
  
  1. The width of the separators does not correspond to any meaningful UI 
element -> they're almost drawn from edge to edge, but they're actually not; it 
makes the placement look a bit awkwad
  
  Rooty's addressed the problem for the top separator by making it correspond 
to the width of the header -> this is more aesthetically pleasing
  He hasn't addressed the bottom separator though, which should ideally be 
drawn from the *very* beginning of the first blue tab line to the *very* end of 
the last blue tab line (now the separator is a bit longer)
  
  2. The separators are still not subtle enough and present a visual problem 
for more transparent themes
  
  For the most extreme example (with the Opal theme), see:
  F6427626: Screenshot_20181117_30.png 

  
  The separators stick out quite a bit and this may make theme developers 
unhappy so the proposed change in opacity could serve to remedy that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg
Cc: filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Root]

rooty added a comment.


  In D16937#360667 , @ngraham wrote:
  
  > But now when the tab bar is on the top or bottom, the separators will have 
different widths, which doesn't look good. To be honest, I'm not sure what the 
actual problem is here.
  
  
  Regarding the width, there isn't an //actual// problem, I just think they 
look better if they're flush with the highlighted portions of Kickoff (that are 
assigned a width different from that of the top separator). I don't know if 
other people do too.
  F6427613: image.png  
  Regarding their opacity, they just stick out too much. The problem is that it 
looks like Kickoff consists of three different parts stitched together (unlike 
the various parts of System Settings, especially in Icon View, Dolphin etc.) 
that seem to work better with 1 px elements that are more see-through and blend 
with each other. Darker themes make them stick out even more. Hence the 
proposed change in opacity.
  F6427611: image.png 
  
  > FWIW make sure to test your changes with all four possible orientations.
  
  Four? Still a noob :D Can you teach me how to get the tab bar on the 
right/left?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  But now when the tab bar is on the top or bottom, the separators will have 
different widths, which doesn't look good. To be honest, I'm not sure what the 
actual problem is here.
  
  FWIW make sure to test your changes with all four possible orientations.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Root]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  Leaner separators in Kickoff (lowered opacity, narrower/shorter)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-leaner-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16937

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: rooty
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma Accessibility: Kickoff Application starter and Focus handling

[chrys]

Howdy Plasma List,

My name is chrys and I m very new here. I currently started with 
Frederik (my mentor) some work on Plasma Accessibility. We try to bring 
an Accessibility team back on rail and try improve the situation here. 
We already make some progress here and continue our work in that area.


First of all, thanks for those an wonderful desktop environment.

Our first goal is to make next plasma release initial "useful" for bind 
people. that means we want to be able to do basic tasks.


1. be able to use the desktop

2. Launch an application

3. Switch between applications and windows.

point 1. and 3. are already done :) yay!

I currently work to make the default application launcher "kickoff" 
accessible. I already have an local patch floating around to add the 
missing A11y Name/ Role to the entries. While i did my tests I 
recognized that the focus handling of that the focus handling of Kickoff 
is completely broken. In fact the highlighted area what represents the 
current selected item is just an colorful overlay (some kind of fake 
focus), but the real focus is always set to the search field. The 
problem is that screen readers need to know what widget or item 
currently has the focus to present it properly. if the focus never 
changes, like in this case it never go away from the search entry, the 
screen reader does not see the fake focus. so it never knows that you 
change the item.


I have 3 efforts here:

1. i want to sensitize that proper focus handling is important, because 
i see this behave in other areas too (i.e. clipboard manager plasmoid in 
panel) and want to start an discussion how to avoid this behave in futur 
since it is just wrong...


2. i tried to fix the kickoff focus issue. but i failed badly. is there 
someone out there, with deeper knowledge of kickoffs structure, who can 
help me out fixing the keyboard and focus handling?


3. we should also consider checking the other widgets and fix those if 
needed. I currently evaluate what else is affected by this issue. what 
do you think?


for questions or feedback just let me know.

so greetings from your new Accessibility Team :)

chrys

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Sure, lets get this into stable till a magic fix comes along

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16595

To: aacid, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16897: Allow windows to be closed from the window switchers

[Martin Flöser]

graesslin added a comment.


  In D16897#359912 , @ngraham wrote:
  
  > In D16897#359911 , @graesslin 
wrote:
  >
  > > In D16897#359900 , @ngraham 
wrote:
  > >
  > > > Good point, guys. I'll start with `StandardKey.Close` for now and see 
about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's 
codebase!).
  > >
  > >
  > > I would prefer if the standardKey.Close is not used. This is an 
in-application shortcut used by Qt, but not necessarily by GTK or other 
toolkits. It is not used by the window manager. Please don't mix in-application 
shortcuts and global shortcuts. It would be confusing to users.
  >
  >
  > Isn't the in-application shortcut for window closing exactly what the user 
would expect? From another perspective, the implementation of this feature in 
other window managers and other platforms (macOS, GNOME) uses the same 
window-closing shortcut in the switcher, so it seems that this is what is 
expected and common.
  
  
  And how do you know the in-application shortcut of a window? What's for 
example the in application close window shortcut of Konsole or xterm? There 
simply is no universal shortcut. Also our default shortcut for Qt application 
is ctrl+q which simply is impossible to press in an alt+tab session.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16897

To: ngraham, #plasma, #vdg, davidedmundson
Cc: graesslin, davidedmundson, abetts, Zren, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D2393: Don't check current active session at all

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Marking as request changes based on Kai's comment which has gone unanswered.
  
  Also you've explained what the patch is doing, but not really what the reason 
for doing it is.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2393

To: oliverhenshaw, #plasma, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16900: Don't use an icon that is only supposed for plasmoids

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D16900

To: apol, andreask, sitter, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

[David Edmundson]

davidedmundson commandeered this revision.
davidedmundson edited reviewers, added: knambiar; removed: davidedmundson.
davidedmundson added a comment.


  This was merged at some point
  Closing the RR.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

To: davidedmundson, #plasma, mart, aacid, knambiar
Cc: aacid, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D2975: [shell] Event compress resizePanel

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Marking as request changes to remove from queue pending reply to Kai's 
question

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2975

To: bshah, #plasma, davidedmundson
Cc: davidedmundson, broulik, mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 360162] Segfault at startup (just after login)

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=360162

--- Comment #4 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  The problem:
  
  1. Unplug laptop power supply
  2. On screen energy saving in settings
  3. Uncheck screen brightness (on all profiles or on that will be loaded)
  4. Wait minutes display to do off (not dimmed)
  5. Plug power supply without display on
  6. When it's on, screen brightness is 100%
  
  Probably it's depends of backend (intel in my case) on dpms it returns 
*garbage* values even on max brightness (it's still not tested)
  
  The solution:
  Trying to cache max brightness level and denied to change screen brightness 
on garbage values

TEST PLAN
  @broulik if you have better solution, i'll test it

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16918

AFFECTED FILES
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/brightnesscontrol.h

To: anthonyfieroni, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

[Eike Hein]

hein added a comment.


  @ngraham Let's progress this, do you want @phuongn to change the patch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14988

To: phuongn, #plasma, #vdg, davidedmundson
Cc: hein, zzag, ngraham, abetts, davidedmundson, broulik, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart