D17003: Fix mouse events being withheld from the scrollbar.

[Eike Hein]

hein updated this revision to Diff 45864.
hein added a comment.


  Fix RTL bug

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17003?vs=45777=45864

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17003

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffListView.qml

To: hein, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Eike Hein]

hein added a comment.


  Thanks, that should probably be reverted, although there might have been some 
reason I'm unaware of in that case since it also sets the font style to outline 
rendering.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, broulik, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Filip Fila]

filipf added a comment.


  In D17034#362786 , @hein wrote:
  
  > we can't just randomly sprinkle a different font rasterizer into the UI.
  
  
  Someone's already done this though. Check line 32 on the left here: 
https://phabricator.kde.org/differential/changeset/?ref=300659=ignore-most
 (can't find the repo version)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, broulik, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  This isn't an acceptable patch, sorry - we can't just randomly sprinkle a 
different font rasterizer into the UI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, broulik, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Kai Uwe Broulik]

broulik added a comment.


  Widget explorer also shows this behavior, however this is more a problem of 
the labels being not aligned to a pixel grid rather than `NativeRendering`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma
Cc: broulik, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17025: Perf: Do expensive regexp construction earlier

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> systemtray.cpp:88
>  qCDebug(SYSTEM_TRAY) << "ST Found DBus-able Applet: " << 
> info.pluginId() << dbusactivation;
> -m_dbusActivatableTasks[info.pluginId()] = dbusactivation;
> +QRegExp rx(dbusactivation);
> +rx.setPatternSyntax(QRegExp::Wildcard);

Shouldn't we prefer QRegularExpression?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17025

To: kfunk, davidedmundson
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Filip Fila]

filipf added a comment.


  In D17034#362739 , @rooty wrote:
  
  >
  
  
  
  
  > This is actually pretty neat considering Kickoff and Notifications are the 
only two widgets where this is a noticeable problem.
  
  And the icons on the desktop (not a widget though, yeah).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Root]

rooty added a comment.


  (LOL I accidentally removed the comment)
  NativeRendering really is the gift that keeps on giving.
  F6432908: nativerendering.png 
  QtRendering renders a lot better.
  F6432910: qtrendering.png 
  
  This is actually pretty neat considering Kickoff and Notifications are the 
only two widgets where this is a noticeable problem.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Root]

rooty added a comment.


  NativeRendering truly is the gift that keeps on giving
  F6432893: nativerendering.png 
  This is what happens if I specify that JobDetailsItem.qml use QtRendering
  F6432899: qtrendering.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Root]

rooty added a comment.


  this has been bugging me/us for years, glad you finally decided to patch it :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Filip Fila]

filipf added a comment.


  **Explanation:**
  Kerning refers to the spacing between letters in text. It's important to get 
it right because otherwise the UI can look unprofessional (and ugly). Currently 
there is a QML bug  that renders 
all NativeRendering elements with bad kerning. The tab labels in Kickoff are 
highly affected and you often get "His tory" "L ea ve" and other combination of 
bad spacing.
  
  Since: (1) we are polishing the presentation of Kickoff in other diffs, (2) 
the kerning bug appears almost always in the tab section, (3) it looks like 
there isn't much progress in the upstream bug report; it would be beneficial to 
address this visual issue with a small workaround that entails setting 
rendering to QtRendering, which doesn't suffer from kerning issues.
  
  **Disclaimer: **
  I am the biggest opponent of working around upstream bugs, but this wouldn't 
be a precedent because we already do the same with the clock in the SDDM theme, 
and it's a minor change applied to the place where the bug most critically 
manifests itself. I'd promise to remove this from future versions as soon as QT 
provides a fix.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch explicitly sets the QML text rendering variable for Kickoff
  tab labels as QtRendering. The effect is that the tab labels are now
  properly kerned.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-kerning-workaround (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17034

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffButton.qml

To: filipf
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17025: Perf: Do expensive regexp construction earlier

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  FWIW, if we use the new https://codereview.qt-project.org/#/c/225432/ we can 
both remove the regex and have all the filtering done in dbus-server which will 
save even more

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17025

To: kfunk, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

[Kevin Funk]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e2ba40a4912a: Fix a few memory leaks (authored by kfunk).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17032?vs=45850=45854#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17032?vs=45850=45854

REVISION DETAIL
  https://phabricator.kde.org/D17032

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

To: kfunk, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17032

To: kfunk, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

[Kevin Funk]

kfunk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  Trace:
  Direct leak of 24 byte(s) in 3 object(s) allocated from:
  
#0 0x544cc0 in operator new(unsigned long) 
(/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x7fe4f0e82df9 in 
TaskManager::XWindowTasksModel::Private::windowInfo(unsigned long long) 
/home/kfunk/devel/src/kf5/plasma-workspace/libtaskmanager/xwindowtasksmodel.cpp:419:25
#2 0x7fe4f0e87e69 in TaskManager::XWindowTasksModel::data(QModelIndex 
const&, int) const 
/home/kfunk/devel/src/kf5/plasma-workspace/libtaskmanager/xwindowtasksmodel.cpp:646:38
...
  
  ASAN: Fix leak in ShellCorona
  
  Trace:
  Indirect leak of 48 byte(s) in 1 object(s) allocated from:
  
#0 0x544cc0 in operator new(unsigned long) 
(/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x5e1a95 in ShellCorona::checkAddPanelAction(QStringList const&) 
/home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:1728:27
#2 0x5dac7e in ShellCorona::ShellCorona(QObject*) 
/home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:180:5
#3 0x65c31d in ShellManager::loadHandlers() 
/home/kfunk/devel/src/kf5/plasma-workspace/shell/shellmanager.cpp:93:21
...

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17032

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

To: kfunk
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Root]

rooty added a comment.


  In D16031#362635 , @ngraham wrote:
  
  > In D16031#362634 , @rooty wrote:
  >
  > > Another fair point: Why not just pick an image that doesn't really 
interfere with the boxes and icons that much then you don't need blur at all.
  >
  >
  > Because within reason, it's the system's job to accommodate the user, not 
the reverse.
  
  
  No, I mean, I did phrase it in the 2nd person but I was talking about KDE 
picking a wallpaper that's appropriate to the login environment. One of the 
things that blur does really well is make it idiotproof so wallpaper selection 
isn't as much of an issue (however it does sort of butcher the wallpaper).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham added a comment.


  In D16031#362634 , @rooty wrote:
  
  > Another fair point: Why not just pick an image that doesn't really 
interfere with the boxes and icons that much then you don't need blur at all.
  
  
  Because within reason, it's the system's job to accommodate the user, not the 
reverse.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Root]

rooty added a comment.


  In D16031#362566 , @ngraham wrote:
  
  > Thing is, if we're going to reduce the blur that much, why not just show 
the original image?
  
  
  That's a fair point.
  Another fair point: Why not just pick an image that doesn't really interfere 
with the boxes and icons that much then you don't need blur at all.
  
  That being said, I personally prefer blur - it's just a matter of taste. The 
added bonus with the blur is the "effect" or "animation" (more like, the time 
needed for it to show up and disappear later on). Not to belabor the point (too 
much) but I've also been using ImageSplash (a splash screen that uses an image 
instead of an actual splash screen) to bridge the gap between the login screen 
and the desktop, and you get a very smooth transition from login to desktop 
with both blur and non-blur when it disappears (and my graphics drivers decide 
//not to glitch//), check it out you might like it:
  
  F6432738: phone-recording.mp4 
  
  Might be something worth investigating,

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Filip Fila]

filipf added a comment.


  In D16031#362072 , @rooty wrote:
  
  > People have been complaining about the blur, but is it necessary to do away 
with it, or is it a better idea to run with it like they do in Windows Fluent 
Design (Deepin too actually)?
  >  F6431816: image.png 
  >
  > This theme, for example, has different blur that might work (It makes you 
think you need glasses though).
  >  It's a Breeze-Chili hybrid that incorporates the proposed font changes 
into ActionButton.qml and UserDelegate.qml. I'm just not sure about the shadows 
behind the clock (spread: 0.1) but they look great full screen. It also uses 
Chili's password box (even though I do like the Breeze one, not really sure 
about that). I haven't yet incorporated the latest system.svgz icons here 
though, because they look sort of out of place on top of a blurry background.
  >  F6431828: image.png 
  
  
  These are fairly appealing blur settings, but yeah, if we're still leaving 
blur on the table, it should be proper blurring. I liked the one in Deepin for 
what it's worth:
  
  F6432729: DeepinScreenshot_20181119102306.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham added a comment.


  Thing is, if we're going to reduce the blur that much, why not just show the 
original image?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D17025: Perf: Do expensive regexp construction earlier

[Kevin Funk]

kfunk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  SystemTray::serviceRegistered is called tons of times; the regexp
  construction inside the for-loop is expensive and should be avoided.
  Thus construct the regexp once, and re-use the regexp object each time.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17025

AFFECTED FILES
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: kfunk
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

[Nathaniel Graham]

ngraham updated this revision to Diff 45833.
ngraham edited the test plan for this revision.
ngraham added a comment.


  Tweak shadows

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16879?vs=45461=45833

BRANCH
  lock-and-login-screen-contrast-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16879

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Clock.qml
  sddm-theme/Main.qml

To: ngraham, davidedmundson, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

[Nathaniel Graham]

ngraham added a comment.


  IMHO spread 0.1 doesn't provide enough contrast against the toughest 
backgrounds:
  
  F6432627: Screenshot_20181119_124804.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16879

To: ngraham, davidedmundson, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

[Anthony Fieroni]

anthonyfieroni added a comment.


  So i made simple script to test, it looks like the problem is that
  
xset dpms force off
sleep 1
cat /sys/class/backlight/intel_backlight/max_brightness
cat /sys/class/backlight/intel_backlight/brightness
cat /sys/class/backlight/intel_backlight/actual_brightness
  
  Results:
  
187
22
0
  
  Any other ideas?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D16918

To: anthonyfieroni, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17003: Fix mouse events being withheld from the scrollbar.

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  If you run in arabic/RTL the scrollbars will be on the left.
  
  If you add:
  anchors.left: parent.left
  
  It should get automatically flipped to the right anchors and continue to 
work. If you don't specify anything, it'll stay on the left.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17003

To: hein, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

[patrick j pereira]

patrickelectric updated this revision to Diff 45831.
patrickelectric added a comment.


  - debugger: Use c++11 for

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17024?vs=45830=45831

BRANCH
  fix

REVISION DETAIL
  https://phabricator.kde.org/D17024

AFFECTED FILES
  src/debugger.cpp

To: patrickelectric
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

[patrick j pereira]

patrickelectric updated this revision to Diff 45830.
patrickelectric added a comment.


  Typo

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17024?vs=45829=45830

BRANCH
  fix

REVISION DETAIL
  https://phabricator.kde.org/D17024

AFFECTED FILES
  src/debugger.cpp

To: patrickelectric
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

[patrick j pereira]

patrickelectric created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
patrickelectric requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Patrick José Pereira 
  
  debugger: Use a stringlist to search in different paths for debugger 
configuration files
  
  Signed-off-by: Patrick José Pereira 

REPOSITORY
  R871 DrKonqi

BRANCH
  fix

REVISION DETAIL
  https://phabricator.kde.org/D17024

AFFECTED FILES
  src/debugger.cpp

To: patrickelectric
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17023: [Kickoff] Depends on D16988, Change search label and username font size

[Root]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  Included commits in branch kickoff-visible-and-unfocused-fonts-type:
  78eb4b0d4e08 [Kickoff] Depends on D16988 
, Change search label and username font size

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-visible-and-unfocused-fonts-type (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17023

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17022: [Kickoff] Depends on D16988, Enable Esc to close Kickoff and Tab to switch to Search

[Root]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  #Summary:
  
  #Test Plan:
  
  #Subscribers:
  
  1. NEW DIFFERENTIAL REVISION
  2. Describe the changes in this new revision. #
  
  Included commits in branch kickoff-visible-and-unfocused-tab-esc:
  63c6197a151a [Kickoff] Depends on D16988 
, Enable Esc to close Kickoff and Tab to 
switch to Search

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-visible-and-unfocused-tab-esc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17022

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17020: [Kickoff] Depends on D16988, Reenable hover to show system information

[Root]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch reenables the mouseover to show system information function 
introduced by Nate Graham and tailors it to D16988 

  
  #Test Plan:
  
  #Reviewers:
  
  #Subscribers:
  
  1. NEW DIFFERENTIAL REVISION
  2. Describe the changes in this new revision. #
  
  Included commits in branch kickoff-visible-and-unfocused-hover:
  #
  5775150fcf26 [Kickoff] Depends on D16988 
, Reenable hover to show system information

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-visible-and-unfocused-hover (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17020

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty updated this revision to Diff 45820.
rooty added a comment.


  - [Kickoff] Make search field unfocused but visible

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16988?vs=45757=45820

BRANCH
  kickoff-visible-and-unfocused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16988

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  Thanks!
  
  Ironically, I do like it focused too 藍

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Nathaniel Graham]

ngraham added a comment.


  Cool, I'm looking forward to most of these changes. And you may yet convince 
me on the visually-unfocused-search-field-by-default thing. :)
  
  Here's the documentation for creating a dependency chain of patches: 
https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17003: Fix mouse events being withheld from the scrollbar.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks Eike! Can confirm that this fixes the issue, and the code change looks 
eminently sane.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17003

To: hein, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dfce50030dd9: [Kickoff] Make Kickoff separators leaner 
(less opaque) and narrower (the length… (authored by Krešimir Čohar 
kco...@gmail.com, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16937?vs=45696=45814

REVISION DETAIL
  https://phabricator.kde.org/D16937

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/KickoffListView.qml

To: rooty, ngraham, #vdg, romangg
Cc: romangg, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > You can do this as you see fit. I would recommend though in this case to 
make a patch series where patches depend on each other since otherwise it can 
become difficult to keep all the independent patches consistent with each other.
  
  Excellent.
  
  > I believe in you! :) If you need quick help come join the Plasma IRC 
channel.
  
  Thanks! :D I just have to figure out how IRC works now. And I thought //arc// 
was a challenge 藍

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Roman Gilg]

romangg added a comment.


  In D16988#362323 , @rooty wrote:
  
  > Clipboard works like this but the coding is beyond my abilities. Krunner 
does this too except it opens up with the search field in focus. This Kickoff 
patched version can't do that, and I've yet to figure out how to make it be 
able to.
  
  
  I believe in you! :) If you need quick help come join the Plasma IRC channel.
  
  > It's not necessary to do so in Kicker. You can just keep on typing.
  
  I know it's not necessary. I meant that it should not be allowed. My argument 
is there is no purpose/advantage to that if you can just continue typing from 
every focused item. All it does is making it one more item to cycle through 
when moving up/down through the search results.
  
  > Patches that would patch this patch or patches that would each patch master 
separately?
  
  You can do this as you see fit. I would recommend though in this case to make 
a patch series where patches depend on each other since otherwise it can become 
difficult to keep all the independent patches consistent with each other.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Conceptual changes to KScreen

[Roman Gilg]

On Mon, Nov 19, 2018 at 11:56 AM David Edmundson
 wrote:
>
> The concept of the global values makes sense. But I think you've over 
> complicated it.
>
> I don't think we should retroactively apply global changes to setups.
> The UX is super confusing, and we have all these state problems that require 
> more and more code on top.
>
> All I think is needed is:
>  - we save the last user set refresh/rotation/scale to an output config file 
> as well as the current config file
>
>  - kded/generator.cpp, when we get a new setup, looks for a global value and 
> uses that instead of automatically generating it.
> That should be the only user of the global values.
>
> Bam, done.

Unfortunately it's not that easy.

Simple example:
* Imagine user has active two-display setup/configuration with
displays D1 and D2.
* User decides to change the scale factor of D1 to two.
* Now user disconnects D2.
* User decides that scale factor two is too large after all and goes
back to one.
* One month later user reconnects D2, the scale factor of D1 suddenly
changes back to the old value read from the configuration file.

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  In D16988#362281 , @romangg wrote:
  
  > I like all the changes, but they should go into separate patches:
  
  
  Patches that would patch this patch or patches that would each patch master 
separately?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > Why does it make it easy?
  
  Sorry I have no idea what I was thinking when I wrote that. It doesn't. (I 
think my point was that it works regardless of the focus being drawn away from 
it?)
  
  > - By default search field looks unactivated but has focus. Arrow up/down 
sets focus to the item selected, but typing to start a search is still possible.
  
  Clipboard works like this but the coding is beyond my abilities. Krunner does 
this too except it opens up with the search field in focus. This Kickoff 
patched version can't do that, and I've yet to figure out how to make it be 
able to.
  
  > - One does not need to go back to the search field with arrow keys to 
add/remove characters (and also should not be able to do that like in Kicker).
  
  It's not necessary to do so in Kicker. You can just keep on typing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Conceptual changes to KScreen

[Roman Gilg]

On Mon, Nov 19, 2018 at 3:00 PM Christoph Feck  wrote:
>
> On 19.11.2018 11:11, Roman Gilg wrote:
> > D1 is at coordinates (0, 0) and has logical size 3840x2160. D2 is
> > therefore at coordinates (3841, 0).
>
> Is the single-pixel gap intended, or should that read (3840, 0)?
>
It should be indeed (3840, 0). Thanks for point it out.

D15855: Port Kickoff to shared view component using single-MouseArea pattern

[Nathaniel Graham]

ngraham added a comment.


  With the benefit of a good nightly sleep, I can see now that my comment was 
really passive-aggressive, for which I apologize. You're right, of course. 
Thanks for the quick fix!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15855

To: hein, #plasma, ngraham, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Roman Gilg]

romangg added a comment.


  In D16988#362160 , @rooty wrote:
  
  > (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  
  
  Why does it make it easy?
  
  > (2) Krunner becomes unfocused if you use the arrow keys, **but not if you 
hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  >  (3) Kickoff (the old, the master and this patch) seems to leave the search 
field focused at all times while you go through the results, and it's possible 
to add more characters to the search like in (1) and (2).
  >  (4) Clipboard behaves pretty much like this patch except //pressing the 
Esc key doesn't make it unfocused again//.
  
  Every applet does it differently. Great.
  
  I would propose:
  
  - By default search field looks unactivated but has focus. Arrow up/down sets 
focus to the item selected, but typing to start a search is still possible.
  - While typing input field and current top item look activated, but focus 
shall not lie on the input field but on the item which would get started when 
Enter is pressed (this item could change while continuing to type).
  - When moving in the search results with arrow keys up/down the search field 
stays activated (but still the focus lies on the currently selected item).
  - One does not need to go back to the search field with arrow keys to 
add/remove characters (and also should not be able to do that like in Kicker).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17016: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli created this revision.
lsartorelli added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lsartorelli requested review of this revision.

REVISION SUMMARY
  Usage example for  D17013  and  D17014 


REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D17016

AFFECTED FILES
  gui/ksysguard.cpp

To: lsartorelli, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Conceptual changes to KScreen

[Christoph Feck]

On 19.11.2018 11:11, Roman Gilg wrote:

D1 is at coordinates (0, 0) and has logical size 3840x2160. D2 is
therefore at coordinates (3841, 0).


Is the single-pixel gap intended, or should that read (3840, 0)?

D16988: [Kickoff] Make the visible search field unfocused by default

[Roman Gilg]

romangg added a comment.


  I like all the changes, but they should go into separate patches:
  
  > (1) Keeps the search field visible by default but leaves it unfocused until 
triggered by the keyboard
  
  Patch 1
  
  > (2) Enables the tab key to select/focus the search field just like any 
other key
  
  Patch 2
  
  > (3) Enables the escape key to collapse Kickoff when pressed from within an 
empty focused search field that was activated by either a mouse click
  >  or the tab key (a bug in the previous version of Kickoff evident due to an 
unfocused search area)
  >  (4) Enables the escape key to return the user to the tabbed view in 
Kickoff when pressed from within a non-empty search field
  
  Patch 3
  
  > (5) Changes the label 'Search...' to 'Type to search...' so that the user 
is made aware that they can, in fact, type to search
  >  (6) Maintains the ability to hover over the user's name to show more 
information about the system
  >  (7) Lowers the font size of the username to make it fit in better with the 
search field and user picture/avatar
  
  Patch 4
  
  You could use this diff here for patch 1 and split the other changes into 
dependent diffs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Root]

rooty added a comment.


  my real name is Kresimir Cohar, email address: kco...@gmail.com
  thanks you guys :D
  
  i just realized i have a pseudonym on kde identity... i might have to fix that

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-leaner-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg, romangg
Cc: romangg, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.


  In D16937#362012 , @ngraham wrote:
  
  > You know what, I tried this out and I like it. The differing line widths 
don't actually seem all that weird when actually using it for a a bit. I think 
this is fine.
  >
  > Other #VDG  and/or #plasma 
 folks, what do you guys think?
  
  
  I like it too
  
  In D16937#362068 , @rooty wrote:
  
  > Hey I'm new to all this sorry, what do I do now? Do I land it (can I even 
do that haha) or do we wait for the VDG/Plasma crew and their go-ahead ? :D
  
  
  @ngraham or me can push the change for you. We just need your full name and 
an email address from you to cite you as author in the commit message.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-leaner-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg, romangg
Cc: romangg, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  In D16988#362206 , @chempfling 
wrote:
  
  > In D16988#362160 , @rooty wrote:
  >
  > > Okay so from what I can tell:
  > >
  > > (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  > >  (2) Krunner becomes unfocused if you use the arrow keys, **but not if 
you hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  > >  (3) Kickoff (the old, the master and this patch) seems to leave the 
search field focused at all times while you go through the results, and it's 
possible to add more characters to the search like in (1) and (2).
  > >  (4) Clipboard behaves pretty much like this patch except //pressing the 
Esc key doesn't make it unfocused again//.
  > >
  > > Any thoughts on how to reconcile all these differences? It might take 
some doing 
  >
  >
  > Howdy,
  >
  > just for clearification :). With focus and unfocuse we talk about "focus: 
true", not only an highlighting effect?
  
  
  Yup - not just a cosmetic effect

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Christian Hempfling]

chempfling added a comment.


  In D16988#362160 , @rooty wrote:
  
  > Okay so from what I can tell:
  >
  > (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  >  (2) Krunner becomes unfocused if you use the arrow keys, **but not if you 
hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  >  (3) Kickoff (the old, the master and this patch) seems to leave the search 
field focused at all times while you go through the results, and it's possible 
to add more characters to the search like in (1) and (2).
  >  (4) Clipboard behaves pretty much like this patch except //pressing the 
Esc key doesn't make it unfocused again//.
  >
  > Any thoughts on how to reconcile all these differences? It might take some 
doing 
  
  
  Howdy,
  
  just for clearification :). With focus and unfocuse we talk about "focus: 
true", not only an highlighting effect?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 19/11/2018

[Marco Martin]

Eike:
* I've come back from extended absence + a short vacation, and started going 
through my giant backlog of tickets today
* Out of that came a Task Manager performance improvement, two Kickoff 
regression fixes and some other bugfix so far
* Currently I'm to stem a tide of brokenness in Folder View, where nested 
popups are hosed, and other things I've come back from extended absence + a 
short vacation, and started going through my giant backlog of tickets today
* Out of that came a Task Manager performance improvement, two Kickoff 
regression fixes and some other bugfix so far
* Currently I'm to stem a tide of brokenness in Folder View, where nested 
popups are hosed, and other things
* Aside from all of that, this week I want to take a stab at rewriting the 
sync code in the Wayland virtual desktops KCM, so the shell side of the 
virtual desktop work can go on

Roman:
* Worked on KScreen. Have a larger partch series up for review and a mail on 
plasma-devel describing the core concepts
   Diff 16997 "[kcm] Expose interface to control output property retention" 
[Changes Planned] https://phabricator.kde.org/D16997
* Also pushed my abstract output changes to KWin:
   Diff 16785 "Handle Wayland change sets in AbstractOutput" [Closed] https://
phabricator.kde.org/D16785
Question from Eike: I think it would be nice to have a Markdown file with a 
table of Wayland protocols and implementation status/plan in the kwin.git 
repo, btw - I get a lot of "does KWin implement this protocol" or "when will 
it get implemented" questions, and the Phab tasks aren't as convenient as doc 
link (to decide between kwayland and kwin)
>From Bhushan: probably in kwin a file which tells about opengl/gles extensions

David:
* Spent some time fixing kwin unit tests. Which reminds me that we need to get 
on top of the rest of plasma's.
* This week I'll spend on some KIO work, I have a reproducible bug in trash:// 
that came from a plasma bug report
* and on wayland stuff, I've started XDG-Deco protocol, should have that ready 
later this week

Vlad:
 Done:
 * Split the Fade effect into two effects: one that animates toplevel 
windows(called Fade) and the other one that animates popups(called Fading 
Popups);
 * Made Fade, Glide, and Scale effect mutually exclusive in the Desktop 
Effects KCM;
 * Ported AnimationEffect to TimeLine;
 * When you change the window title font size, the new height of window 
titlebars will be applied immediately;
 * retarget() now works as expected, which means the Morphing Popups effect 
should be a little bit smoother:
 - before: https://www.youtube.com/watch?v=AUTGfIXkYzs
 - after: https://www.youtube.com/watch?v=srXtRi2ZgOk
 * Re-implemented the Dim Screen effect in JavaScript;
 * The Dialog Parent effect now smoothly brightens main windows when a full 
screen effect(e.g. Slide) gets activated;
 * Rewrote the Fade Desktop effect;
 * Added redirect() and complete() to scripted effects API. The former 
function changes the direction of a given animation, the latter function fast 
forwards a given animation to the target position.
 Under review/Waiting for review:
 * "Fix" lowerClient/raiseClient for group transients.
 Todo:
 * Investigate why in some cases we're re-inserting deleted clients(e.g. 
Client) back into the unconstrained stacking order.
 Postponed:
 I spent the weekend implementing multisampling support in KWin and here's the 
short summary: multisampling is way too expensive than I expected; only two 
effects(Flip Switch and Cover Switch) are not affected by big frame drop. 
[Flip Switch with MSAAx4](https://photos.app.goo.gl/pycpSpDmUWPHutzd8) [Magic 
Lamp with MSAAx4](https://photos.app.goo.gl/sAPL1tdwkGaXZUPa9)
 That's not quite correct to make decisions based on results observed on a 
single machine, but in general, KWin should not be expected to run on some 
high-end gaming rig, etc.
 We also can't use post-processing anti-aliasing techniques(like, FXAA) 
because text will be blurry.
 
 also
 could someone please take a look at D16228? the review process got stuck
   Diff 16228 "Raise window group together with group transient" [Needs 
Review] https://phabricator.kde.org/D16228
 if that's indeed a bad idea to raise window group
 then I would like abandon the patch and rework lowerClient

Bhushan:
- Request for implementation of : EGL_KHR_patitial_update for kwin https://
gitlab.freedesktop.org/lima/mesa/issues/59
 - I want to spend some time on whole "scaling issue" in Plasma Mobile, we are 
doing some magic based on font size or something on phone AFAIU, and it is 
recurring complaint (Schedule some time this week with David and Marco)
 - I also see that we are using Oxygen fonts in phone and should be switched 
to Noto.
 the EGL_KHR_partial_update will improve the wayland performance on pinebook 
for example ^^

Kai Uwe:
 * plasma-browser-integration
 ** Eike:
* I've come back from extended absence + a short vacation, and started going 
through my giant backlog of 

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  Okay so from what I can tell:
  
  (1) Kicker takes the focus off the search field when you go through the 
results by either mouse or keyboard. This makes it easy to go back to the 
search field by typing or using the arrow keys (to add more words etc.)
  (2) Krunner becomes unfocused if you use the arrow keys, **but not if you 
hover over the search results with your mouse**, and it's still possible in 
either case to append your search same as in Kickoff.
  (3) Kickoff (the old, the master and this patch) seems to leave the search 
field focused at all times while you go through the results, and it's possible 
to add more characters to the search like in (1) and (2).
  (4) Clipboard behaves pretty much like this patch except //pressing the Esc 
key doesn't make it unfocused again//.
  
  Any thoughts on how to reconcile all these differences? It might take some 
doing 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16898: [kcm] Remove profiles code

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  I remember Alex at the time had a thing that new features should be in master 
but in #ifdefs so it's easier for other devs to test things than having a giant 
patchset that no-one can even find and have to keep switching between.
  
  It's not a bad idea, I never run code in branches for a long time.
  
  However, it doesn't work if things get abandoned and die.

REPOSITORY
  R104 KScreen

BRANCH
  removeProfilesCode

REVISION DETAIL
  https://phabricator.kde.org/D16898

To: romangg, #plasma, apol, davidedmundson
Cc: davidedmundson, afiestas, apol, dvratil, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: Conceptual changes to KScreen

[David Edmundson]

The concept of the global values makes sense. But I think you've over
complicated it.

I don't think we should retroactively apply global changes to setups.
The UX is super confusing, and we have all these state problems that
require more and more code on top.

All I think is needed is:
 - we save the last user set refresh/rotation/scale to an output config
file as well as the current config file

 - kded/generator.cpp, when we get a new setup, looks for a global value
and uses that instead of automatically generating it.
That should be the only user of the global values.

Bam, done.

David

D16400: Prefer to set current mode in resolution combobox

[Alexander Volkov]

volkov closed this revision.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D16400

To: volkov, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16898: [kcm] Remove profiles code

[Daniel Vrátil]

dvratil added a subscriber: afiestas.
dvratil added a comment.


  Profiles were supposed to allow various screen layouts per single setup, for 
instance, if you have your monitor and TV both connected to your PC, you may 
want to have "Monitor", "Monitor+TV" and "TV-only" profiles. The idea was to 
have a combobox in the KCM that would allow you to quickly switch between those 
profiles without having to fiddle with the rest of the GUI every time. IIRC we 
did not agree with @afiestas on this feature back then, so it remained disabled 
(should've been on a branch instead of #ifdefs on master, I admit that ) and 
while I was still working on kscreen, I never got around to actually finish it 
and push it.

REPOSITORY
  R104 KScreen

BRANCH
  removeProfilesCode

REVISION DETAIL
  https://phabricator.kde.org/D16898

To: romangg, #plasma, apol
Cc: afiestas, apol, dvratil, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Relicensing of file in plasma-phone-components

[Bhushan Shah]

Hello everyone,

I am writing to you since you have commited to the
plasma-phone-components/dialer/src/dialerutils.* code.

(Volker in CC list because he raised the current issue, Volker is not
committer to files.)

Current code is GPL2, which is incompatible with the Apache2 license of
libphonenumber we want to use.

Do you grant permission to relicense this code to either GPL2+ or LGPL?

Thanks.

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

Conceptual changes to KScreen

[Roman Gilg]

Hi all,

I've written over the last few days a patch series for KScreen, that
restructures part of the code, but more importantly introduces new
configuration concepts on a fundamental level.

I write this mail to get some feedback on these concepts, if there are
aspects I overlooked when designing them, problems which might creep
up later.

You can read the patch series starting at:
https://phabricator.kde.org/D16989

Concepts


As a summary the two main new concepts are:
1. Introduction of global output property files, which contain a
default state for display models (which are defined by their EDID
model). Core functionality for that is added between patches:
https://phabricator.kde.org/D16991
https://phabricator.kde.org/D16997
2. Additional to the data sharing between KCM and KScreen daemon via
the windowing system a secondary one-way control channel is
introduced. This allows the KCM to share additional control
information with the daemon. This is mostly patch:
https://phabricator.kde.org/D16992

For 1. the rationale was that a user in most cases want to change the
properties of a particular display model for all screen
setups/configurations and not only for the one currently in use. The
default behavior would therefore be with these patches that properties
are saved to the global output properties file, which gets read by
default for all new and existing configurations, should they get
activated.

To offer some more flexibility there is a second "advanced" mode
allowing the user to specify configuration-specific values, which
won't get overridden by the global properties. In this second mode an
output in a certain configuration would therefore behave basically how
it is currently the case.

For 2. the idea was, that there might be additional information about
a configuration or global output property file the KCM needs to share
with the daemon, but the detour through the windowing system is
unnecessary, because the information is not relevant for the windowing
system. The primary use case for such information is at the moment the
retention information, i.e. if the user specifies a configuration to
use individual output values instead of global output values.

Other information shared through this channel in the future will be
presumably if the configured resolution, refresh rate and so on is the
result of manual user interaction or of an algorithm (i.e. "auto"
selected in the KCM). By this the daemon can decide to recalculate the
auto value on next output/configuration activation or just reapply the
stored fixed value. On the other side the KCM can read this
information to display the correct mode in its Ui.

Challenges
--
I see with the current patch set three remaining issues:

1. Old property files of configurations get (partly) invalidated.
The files get moved, so old files won't get read out anymore. One
could write an update script, but with D17007 there is another
proposed patch to libkscreen, that changes the hash values of all
configurations with name based output hashes, i.e. afterwards these
configuration files are not found anyway.

I would argue since the concept of configuration with this patch
series changes on a fundamental level, it is acceptable and to a
certain degree preferable to invalidate old configuration files. But
in this case the new concept must be right the first time, that's what
this email is for.

2. KCM data not yet refreshed on hot plug events.
While the KCM is opened, if a hot plug event occurs or if screens are
unified, I can't yet guarantee that the control values (i.e. at the
moment the retention) are updated in the Ui accordingly.

I would like to tackle this by a larger rewrite of the KCM data logic,
by remembering a pending and current state and through that also
allowing the KCM to go back into the non-changed state when the user
roll-backs pending changes.

3. Global output properties resolution, scale, rotation influence the
position of screens.
Imagine a two screen configuration C with a 4k display D1 on the left
and scale factor 1 (using global properties) and some other display D2
on the right. D2 left top corner is aligned with D1 right top corner.
D1 is at coordinates (0, 0) and has logical size 3840x2160. D2 is
therefore at coordinates (3841, 0).

Now user decides to change the global scale factor of D1 from 1 to 2
while a different configuration is active. Logical size of D1 is
reduced to 1920x1080 by that. Still D2 is at (3841,0) in configuration
C. So the next time the configuration is activated there is suddenly a
large gap between the screens. One can assume the user instead wanted
the screens to still be next to each other.

My idea for solving this problem is compensation logic in the daemon.
Since the configuration file of C still features the old scale and
position values, the daemon can compare them with the different global
properties and then move the screens accordingly. Still this needs
some careful designing in order to 

D16170: [Device Notifier] Restore busy indicator

[Thomas Surrel]

thsurrel added a comment.


  Ping !
  Anyone could have a look at this patch ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16170

To: thsurrel, #plasma, #vdg, broulik, bruns
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17007: Do hash and hex name based output hashes

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The hash of an output is based on its name in case no EDID information is
  available. In order to have the same hash format as when EDID is available
  do the same hash operation to the name as to the EDID checksum.
  
  Imortant: This invalidates previous configuration files in KScreen, whose
  file names were based on output names instead of EDID values.

TEST PLAN
  Compiles.

REPOSITORY
  R110 KScreen Library

BRANCH
  hashOutputNameHash

REVISION DETAIL
  https://phabricator.kde.org/D17007

AFFECTED FILES
  src/output.cpp

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Frederik Gladhorn]

gladhorn added a comment.


  In D16988#362104 , @rooty wrote:
  
  > @gladhorn More food for thought by the way: in this patch (and the master) 
the search field is focused while searching and while navigating the search 
results - it still accepts input even though you've technically navigated away 
from it. Should this functionality be kept (regardless of if the search field 
remains visibly focused or not), or should we prevent the user from typing into 
the search field while the focus is on the search results?
  >
  > I think it's a good idea to let the user type to search from wherever they 
may be in Kickoff, but to draw the focus away from the search field (like 
Kicker).
  
  
  Yes, I want to be able to type, no matter where, but the search result should 
get the focus in my opinion. We don't want to lose that functionality, it's 
about knowing what the currently most relevant item is, just like a sighted 
user would see the top list item. Then if the arrow keys for example work to go 
to the next search result, just like you'd glance down, then that's perfect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17006: Compress calls to `updateSize`

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ab26ebb18b74: Compress calls to `updateSize` (authored by 
hein).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17006?vs=45780=45785#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17006?vs=45780=45785

REVISION DETAIL
  https://phabricator.kde.org/D17006

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16990: [kded] Change configuration storage path

[David Edmundson]

davidedmundson added a comment.


  Why?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D16990

To: romangg, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17006: Compress calls to `updateSize`

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> hein wrote in GroupDialog.qml:265
> The suggested code is the same as the present code, so not sure ... can you 
> clarify?
> 
> The aboutToPopulate thing is done for the focus-active-task. I'm not sure I 
> want to replace this with `callLater`, since callLater has weakly defined 
> semantics for me tastes. For the `updateSize` case only eventual consistency 
> counts. If it was executed too early and then later again it'd at worst be 
> more like the old performance, but not break things. With the 
> focus-active-task code, though, it could break things.

My line changes

  || -> &&

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17006

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17006: Compress calls to `updateSize`

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in GroupDialog.qml:265
> I remember looking into this.
> 
> I was thinking this should be:
> 
> (!groupRepeater.aboutToPopulate && visualParent.childCount == 
> groupRepeater.count)
> 
> As if we're still aboutToPopulate then we shouldn't be doing anything.
> 
> But then I changed it and it didn't immediately work so I did nothing.

The suggested code is the same as the present code, so not sure ... can you 
clarify?

The aboutToPopulate thing is done for the focus-active-task. I'm not sure I 
want to replace this with `callLater`, since callLater has weakly defined 
semantics for me tastes. For the `updateSize` case only eventual consistency 
counts. If it was executed too early and then later again it'd at worst be more 
like the old performance, but not break things. With the focus-active-task 
code, though, it could break things.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17006

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  @gladhorn More food for though, by the way: in this patch (and the master) 
the search field is focused while searching and while navigating the search 
results - it still accepts input even though you've technically navigated away 
from it. Should this functionality be kept (regardless of if the search field 
remains visibly focused or not), or should we prevent the user from typing into 
the search field while the focus is on the search results?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Root]

rooty added a comment.


  > Actually this sounds like it might help our cause. Especially when the 
search bar can be tabbed into, that's really nice. The problem is that we would 
like to focus to be on the selected item, such as the one that gets launched 
when pressing enter. The search should not have the focus unless the user type. 
I didn't look at the code change at all, but from the description it may just 
be a step forward.
  
  This did occur to me too, and it's a great idea, I just haven't figured out 
how to implement it yet haha

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16988: [Kickoff] Make the visible search field unfocused by default

[Frederik Gladhorn]

gladhorn added a comment.


  In D16988#361980 , @ngraham wrote:
  
  > There are a lot of good changes in here, like those keyboard navigation 
improvements! And I appreciate all the work that clearly went into this. 
However, the problem with huge patches like this is that if we like some but 
not all of it, you end up needing to re-work a lot of the patch. That's 
generally why we prefer "atomic" changes with one change per patch/commit. It 
makes that kind of thing way saner.
  >
  > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have 
been working hard to push on accessibility, and one thing I've learned in the 
past week weeks is how important focus is. Making sure that the active element 
both has and looks like it has focus is critical to making sure  the UI is 
accessible for screen readers. As such, we need to keep it visually focused by 
default when it opens.
  
  
  Actually this sounds like it might help our cause. Especially when the search 
bar can be tabbed into, that's really nice. The problem is that we would like 
to focus to be on the selected item, such as the one that gets launched when 
pressing enter. The search should not have the focus unless the user type. I 
didn't look at the code change at all, but from the description it may just be 
a step forward.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16988

To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson
Cc: gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16297: [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:73339208cd34: [DBusMenuImporter] Dont call 
removeAction() to avoid an empty QMenu (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16297?vs=43860=45783

REVISION DETAIL
  https://phabricator.kde.org/D16297

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: broulik, #plasma, davidedmundson, poboiko
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16906: Update about KDE text

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:639764da6b61: Update about KDE text (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16906?vs=45538=45781

REVISION DETAIL
  https://phabricator.kde.org/D16906

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/options.html

To: broulik, #plasma, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17006: Compress calls to `updateSize`

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Use of callLater seems like a neat solution, does it make aboutToPopulate 
redundant?

INLINE COMMENTS

> GroupDialog.qml:265
>  // only update size once the repeater count matches the model role.
>  } else if (!groupRepeater.aboutToPopulate || visualParent.childCount 
> == groupRepeater.count) {
>  var task;

I remember looking into this.

I was thinking this should be:

(!groupRepeater.aboutToPopulate && visualParent.childCount == 
groupRepeater.count)

As if we're still aboutToPopulate then we shouldn't be doing anything.

But then I changed it and it didn't immediately work so I did nothing.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17006

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Root]

rooty added a comment.


  People have been complaining about the blur, but is it necessary to do away 
with it, or is it a better idea to run with it like they do in Windows Fluent 
Design (Deepin too actually)?
  F6431816: image.png 
  
  This theme, for example, has different blur that might work (It makes you 
think you need glasses though).
  It's a Breeze-Chili hybrid that incorporates the proposed font changes in 
ActionButton.qml and UserDelegate.qml. I'm just not sure about the shadows 
behind the clock (spread: 0.1) but they look great full screen. It also uses 
Chili's password box (even though I do like the Breeze one, not really sure 
about that). I haven't yet incorporated the latest system.svgz icons here 
though, because they look sort of out of place on top of a blurry background.
  F6431828: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16990: [kded] Change configuration storage path

[Kai Uwe Broulik]

broulik added a comment.


  Can you provide a kconf update script or have it also check the old 
locations? Losing all screen config after an upgrade is bad.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D16990

To: romangg, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart