D17076: Avoid indeterminism in kcolorschemeeditor

[Olivier Churlaud]

ochurlaud accepted this revision.
ochurlaud added a comment.
This revision is now accepted and ready to land.


  The root cause is that we build twice the same elements instead of having one 
share lib used on the two contexts.
  
  I guess this is more involved to do the proper fix, so at first yours can be 
OK... Push it!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17076

To: bmwiedemann, rwooninck, ochurlaud
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Nathaniel Graham]

ngraham added a comment.


  Cool!
  
  For this design, I'd like to get rid of the tabs and put everything in a 
scrollview. We generally have enough space that a tabbed view is overkill.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16977: [weather] Fix broken observation display for temperature of 0 °

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 45986.
kossebau added a comment.


  diff against correct branch

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16977?vs=45985=45986

BRANCH
  fix0DegreeTemperature

REVISION DETAIL
  https://phabricator.kde.org/D16977

AFFECTED FILES
  applets/weather/package/contents/ui/main.qml

To: kossebau, #plasma, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16977: [weather] Fix broken observation display for temperature of 0 °

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 45985.
kossebau added a comment.


  - use var data = weatherDataSource.currentData || {}; to simplify rest
  - use typeof number !== "undefined"

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16977?vs=45724=45985

BRANCH
  fix0DegreeTemperature

REVISION DETAIL
  https://phabricator.kde.org/D16977

AFFECTED FILES
  CMakeLists.txt
  applets/keyboardindicator/metadata.desktop
  applets/mediaframe/package/metadata.desktop
  applets/weather/package/contents/ui/main.qml
  applets/weather/package/metadata.desktop
  dataengines/comic/comicprovider.cpp
  dataengines/potd/apodprovider.json
  dataengines/potd/bingprovider.json
  dataengines/potd/epodprovider.json
  dataengines/potd/flickrprovider.json
  dataengines/potd/natgeoprovider.json
  dataengines/potd/noaaprovider.json
  dataengines/potd/wcpotdprovider.json
  runners/konsoleprofiles/plasma-runner-konsoleprofiles.desktop
  wallpapers/hunyango/metadata.desktop

To: kossebau, #plasma, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17079#363906 , @ltoscano wrote:
  
  > That's a great idea! Would it be possible:
  >
  > - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  
  
  Yes, I actually forgot to add it, it's basically a matter of replicating the 
authors bit but instead of calling .authors, we call .translators. Actually we 
should do the same for contributors too.
  
  > - to move this about page to some common kirigami-addons library?
  
  We would have to look into it, we don't want to have kirigami depend on 
kcoreaddons, but we can easily allow applications that don't use kcoreaddons to 
pass a json object that looks like KAboutData instance (duck typing!).
  Otherwise, we could also move it to kdeclarative or have kcoreaddons install 
it.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Luigi Toscano]

ltoscano added a comment.


  That's a great idea! Would it be possible:
  
  - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  - to move this about page to some common kirigami-addons library?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17076: Avoid indeterminism in kcolorschemeeditor

[Bernhard M. Wiedemann]

bmwiedemann added a comment.


  If you look at 
http://rb.zq1.de/compare.factory-20181121/plasma5-desktop-compare.out
  You can see that the asm diff between a -j1 and a -j4 build of openSUSE's 
plasma5-desktop package contains (among many others)
  
  
-_ZN18SchemeEditorDialog18qt_static_metacallEP7QObjectN11QMetaObject4CallEiPPv.part.1:
  
+_ZN19SchemeEditorEffects18qt_static_metacallEP7QObjectN11QMetaObject4CallEiPPv.part.1:
  
  and I found that it goes away when you tell cmake or make to build one after 
the other (either order works) like with this patch.
  But what is the root cause then? And how do you fix it better?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17076

To: bmwiedemann, rwooninck, ochurlaud
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  WRT the gravatar bit, I'm not married to it, it's just a way to have this 
moving forward.
  
  I'll add some screenshots so you get an idea:
  
  F6435584: discover-about1.png 
  
  F6435585: discover-about2.png 
  
  F6435586: discover-about3.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol updated this revision to Diff 45968.
apol added a comment.


  Don't show the gravatar logo when not there

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17079?vs=45965=45968

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17080: Make it possible to fallback to a different icon

[Aleix Pol Gonzalez]

apol updated this revision to Diff 45967.
apol added a comment.


  Unrelated change

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17080?vs=45966=45967

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17080

AFFECTED FILES
  src/desktopicon.cpp
  src/desktopicon.h

To: apol, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17080: Make it possible to fallback to a different icon

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  If we failed to download something, it could make sense to be in control of 
what
  icon is shown instead.

TEST PLAN
  See D17079 

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17080

AFFECTED FILES
  src/controls/GlobalDrawer.qml
  src/desktopicon.cpp
  src/desktopicon.h

To: apol, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17039: ASAN: Fix leak in KAStatsFavoritesModel

[Ivan Čukić]

ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  Ok, +2 from me then

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17039

To: kfunk, davidedmundson, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

[Root]

rooty added a comment.


  In D16879#362527 , @ngraham wrote:
  
  > IMHO spread 0.1 doesn't provide enough contrast against the toughest 
backgrounds:
  >
  > F6432627: Screenshot_20181119_124804.png 

  
  
  ouch you're right that //is// bad

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16879

To: ngraham, davidedmundson, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of using the one in xmlgui, create one that integrates properly in 
Kirigami/Discover.

TEST PLAN
  Used it, saw myself in it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 208 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/208/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 21 Nov 2018 18:01:27 +
 Build duration:
5 min 20 sec and counting

D17039: ASAN: Fix leak in KAStatsFavoritesModel

[Kevin Funk]

kfunk added a comment.


  I think the `QSharedPointer` overhead is very much negligible in this case 
here. And doesn't require refactoring of the original code. This is not 
performance sensitive code (compared to the costs of the QAIM-modifications), 
no?
  
  If you think the memory leak can be fixed differently, shoot.

INLINE COMMENTS

> kastatsfavoritesmodel.cpp:297
>  
>  m_itemEntries[resource]
>  = m_itemEntries[entry->id()]

With `std::unique_ptr` we'd run into a couple of problems, like in this place 
here: Multiple copies would be needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17039

To: kfunk, davidedmundson, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17076: Avoid indeterminism in kcolorschemeeditor

[Olivier Churlaud]

ochurlaud added a comment.


  Well it's not really a dependency, is it? They only use the same sources to 
build up two different views of the same widget. This patch is hacky as the 
original cmakefile... I understand the need but can't the patch fix the root 
cause instead?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17076

To: bmwiedemann, rwooninck, ochurlaud
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Andres Betts]

abetts added a comment.


  I know this patch doesn't deal with this, but I would suggest doing a 
background blur on the bottom bar that has the player buttons and the labels. 
It will improve readability

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Nathaniel Graham]

ngraham added a comment.


  We should avoid resizing the pop-up but rather scale the image to fit while 
preserving its existing aspect ratio.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

[Nathaniel Graham]

ngraham updated this revision to Diff 45962.
ngraham edited the test plan for this revision.
ngraham added a comment.


  Slightly reduce shadow strength

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16879?vs=45833=45962

BRANCH
  lock-and-login-screen-contrast-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16879

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Clock.qml
  sddm-theme/Main.qml

To: ngraham, davidedmundson, #vdg, #plasma
Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17039: ASAN: Fix leak in KAStatsFavoritesModel

[Ivan Čukić]

ivan added a comment.


  Using a shared pointer seems like a pessimization. Could this be done with 
std::unique_ptr?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17039

To: kfunk, davidedmundson, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Relicensing of file in plasma-phone-components

[Martin Klapetek]

Hi,

I'm fine with relicensing my contributions
to plasma-phone-components/dialer/src/dialerutils.*
code from GPL2 to either GPL2+ or LGPL.

Cheers
--
Martin Klapetek


On Sun, Nov 18, 2018 at 7:47 AM Bhushan Shah  wrote:

> Hello everyone,
>
> I am writing to you since you have commited to the
> plasma-phone-components/dialer/src/dialerutils.* code.
>
> (Volker in CC list because he raised the current issue, Volker is not
> committer to files.)
>
> Current code is GPL2, which is incompatible with the Apache2 license of
> libphonenumber we want to use.
>
> Do you grant permission to relicense this code to either GPL2+ or LGPL?
>
> Thanks.
>
> --
> Bhushan Shah
> http://blog.bshah.in
> IRC Nick : bshah on Freenode
> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
>

D17041: Sync text for empty trash

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5bea4b98ad00: Sync text for empty trash (authored by 
davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17041?vs=45871=45957

REVISION DETAIL
  https://phabricator.kde.org/D17041

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17076: Avoid indeterminism in kcolorschemeeditor

[Bernhard M. Wiedemann]

bmwiedemann added reviewers: rwooninck, ochurlaud.
bmwiedemann added a comment.


  please review

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17076

To: bmwiedemann, rwooninck, ochurlaud
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17076: Avoid indeterminism in kcolorschemeeditor

[Bernhard M. Wiedemann]

bmwiedemann created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bmwiedemann requested review of this revision.

REVISION SUMMARY
  Avoid indeterminism in kcolorschemeeditor
  
  Without this patch,
  
build/kcms/colors/CMakeFiles/kcolorschemeeditor.dir/kcolorschemeeditor_autogen/mocs_compilation.cpp.o
  and the resulting /usr/bin/kcolorschemeeditor varied from parallelism.
  
  See https://reproducible-builds.org/ for why this matters.
  
  See also https://bugzilla.opensuse.org/show_bug.cgi?id=1109420

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17076

AFFECTED FILES
  kcms/colors/CMakeLists.txt

To: bmwiedemann
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Andres Betts]

abetts added a comment.


  Looks great. Thanks for the fix.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Anthony Fieroni]

anthonyfieroni added a comment.


  Whole point is to not change tooltip height, it can be larger that entire 
screen or smaller that 16x16, so the solution is to scale image to current 
aspect ratio. Otherwise it can lead to inconsistency.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[trmdi]

trmdi created this revision.
trmdi added reviewers: hein, broulik, ngraham, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Because:
  
  - the standard aspect ratio of `albumImage` is always `1:1`
  - we should not crop the important part of `albumArt` in some cases.
  
  BUG: 401234

TEST PLAN
  Before:
  F6435279: Screenshot_20181121_200913.png 

  After:
  F6435280: Screenshot_20181121_201846.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17005: Fix dismissing the Dashboard by clicking inbetween multi-grid categories.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e12e3cad1d7e: Fix dismissing the Dashboard by clicking 
inbetween multi-grid categories. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17005?vs=45779=45949

REVISION DETAIL
  https://phabricator.kde.org/D17005

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/ItemMultiGridView.qml

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17003: Fix mouse events being withheld from the scrollbar.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b664aa9c055b: Fix mouse events being withheld from the 
scrollbar. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17003?vs=45864=45948

REVISION DETAIL
  https://phabricator.kde.org/D17003

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffListView.qml

To: hein, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17034: [Kickoff] Fix bad kerning in tab labels

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  In D17034#363098 , @ngraham wrote:
  
  > FWIW, we already conditionally switch to using QtRendering when using a 
fractional scale factor throughout the PlasmaComponents library. So there is 
already a precedent for sometimes using a different renderer to work around 
visual bugs, and so far it has been much appreciated by our users. Doing it 
there rather than in individual UI elements is probably right right place for 
this change rather than in individual UI elements in widgets, if it's to be 
done at all.
  >
  > Of course, the upstream bugs should be fixed, for sure.
  
  
  That's a much more elegant solution. I assume the problems were bigger there, 
thus warranting such an intervention.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17034

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, broulik, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart