D16977: [weather] Fix broken observation display for temperature of 0 °

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:0d379c5957e2: [weather] Fix broken observation display 
for temperature of 0 ° (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16977?vs=45986=46056

REVISION DETAIL
  https://phabricator.kde.org/D16977

AFFECTED FILES
  applets/weather/package/contents/ui/main.qml

To: kossebau, #plasma, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[trmdi]

trmdi added a comment.


  In D17073#364393 , @ndavis wrote:
  
  > That blur looks nice, but I think the background should be more opaque like 
the Elisa header background.F6437066: Screenshot_20181122_005432.png 

  
  
  Do you want to suggest some numbers ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D4929: DrKonqi : lldb and Mac support

[David Edmundson]

davidedmundson added a comment.


  > Making DrKonqi standalone is a good step, I'd strongly suggest to move it 
to KF5 Applications at the first possible occasion.
  
  That'll probably be when we move to Qt6.
  
  Ultimately it'd still be the same tarball just in a different folder on an 
FTP site, so I doubt it really would make anyone's lives easier.
  
  -
  
  Generally this patchset is a +1 from me, except for my second comment. It's a 
shame we pollute the main codebase in a few places for the one backend, but if 
there's no other option, then we have no choice.
  
  Can you explain why you detach?  Work to just call quit in the script to 
solve the hanging issue?

INLINE COMMENTS

> aboutbugreportingdialog.cpp:39
>  
> -setWindowIcon(QIcon::fromTheme(QStringLiteral("help-hint")));
> +setWindowIcon(QIcon::fromTheme(QStringLiteral("help-hint"), 
> windowIcon()));
>  setWindowTitle(i18nc("@title title of the dialog", "About Bug Reporting 
> - Help"));

icon = QIcon::fromTheme
  if (icon.isValid()) {
 setWindowIcon(...)
  }

is more standard..

Though from the docs:

> Note: On macOS, the window title bar icon is meant for windows representing 
> documents, and will only show up if a file path is also set.

We don't set this, is this an issue?

> backtracegenerator.cpp:140
>  int pos;
> -while ((pos = m_output.indexOf('\n')) != -1) {
> +while ((pos = m_output.indexOf('\n')) != -1 && m_proc->state() == 
> QProcess::Running) {
>  QString line = QString::fromLocal8Bit(m_output.constData(), pos + 1);

this seems dangerous for the other clients.

It's not unfeasible for a process to have a load of data still in the buffer 
when it quits.

I don't know lldb, but it seems you can probably move this to ~149

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D17112: Allow disabling the build of the file dialog component

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  You can't run plasma without KIO. It's used elsewhere.
  If you're not running plasma, you shouldn't be using plasma-integration.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17112

To: ntninja, mlaurent, jriddell, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17113: Allow disabling KPackage install while building Breeze

[David Edmundson]

davidedmundson added a comment.


  Why?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D17113

To: ntninja, mart, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17113: Allow disabling KPackage install while building Breeze

[Alexander Schlarb]

ntninja created this revision.
ntninja added reviewers: mart, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ntninja requested review of this revision.

REVISION SUMMARY
  Truth to be told, I'm not 100% sure what this step actually does, but breeze 
seems to load just fine without this. Please tell me if I'm doing something 
terrible here.

TEST PLAN
  Build with and without `-DWITH_KPACKAGE_INSTALL=off` and verify that both 
versions work.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D17113

AFFECTED FILES
  CMakeLists.txt

To: ntninja, mart, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4929: DrKonqi : lldb and Mac support

[René J . V . Bertin]

rjvbb updated this revision to Diff 46044.
rjvbb added a comment.


  includes the root cmake file changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4929?vs=46025=46044

REVISION DETAIL
  https://phabricator.kde.org/D4929

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/aboutbugreportingdialog.cpp
  src/backtracegenerator.cpp
  src/backtracegenerator.h
  src/backtracewidget.cpp
  src/bugzillaintegration/reportassistantdialog.cpp
  src/data/debuggers/external.mac/lldbrc
  src/data/debuggers/external/lldbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/drkonqibackends.cpp
  src/drkonqidialog.cpp
  src/main.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparserlldb.cpp
  src/parser/backtraceparserlldb.h
  src/tests/CMakeLists.txt

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D17112: Allow disabling the build of the file dialog component

[Alexander Schlarb]

ntninja created this revision.
ntninja added reviewers: mlaurent, jriddell, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ntninja requested review of this revision.

REVISION SUMMARY
  While this of course considerbly reduces functionality it makes it possible 
to build `plasma-integration` without KIO, which is a pretty sizeable 
dependency and not always needed.

TEST PLAN
  Build both with an without `-DBUILD_FILE_DIALOG_KIO=off` and ensure that both 
modes work.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17112

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/config-platformtheme.h.cmake
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h

To: ntninja, mlaurent, jriddell, dfaure
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4929: DrKonqi : lldb and Mac support

[René J . V . Bertin]

rjvbb added a comment.


  >   a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists 
file.
  
  Ah, thanks. I have that in my own cmake file of course, but also an unrelated 
change I thought I could safely keep out by just taking a diff of the `src` 
directory.
  
  I test DrKonqi by starting an application like kate and then doing a `killall 
-SEGV kate`.
  Note that I do use a patched Qt5 on Mac where QStandardPaths can be made to 
behave like it does on any other Unix variant. Without that DrKonqi might well 
be unable to find the lldbrc (or equivalent) file it needs.
  
  The easiest way to make this platform independent would be to put those files 
in the Qt resource. That's a separate change though.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.11 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.11/13/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 22 Nov 2018 20:34:18 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(2/6)16%
(9/57)16%
(9/57)8%
(375/4511)24%
(632/2662)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/27)0%
(0/27)0%
(0/1541)0%
(0/727)src.bugzillaintegration0%
(0/15)0%
(0/15)0%
(0/2320)0%
(0/1103)src.parser67%
(6/9)67%
(6/9)73%
(301/412)81%
(611/752)src.tests.backtraceparsertest75%
(3/4)75%
(3/4)72%
(74/103)70%
(21/30)src.tests.bugzillalibtest0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/20)src.tests.crashtest0%
(0/1)0%
(0/1)0%
(0/72)0%
(0/30)

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.11 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.11/13/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 22 Nov 2018 20:34:18 +
 Build duration:
1 min 53 sec and counting

D4929: DrKonqi : lldb and Mac support

[patrick j pereira]

patrickelectric added a comment.


  a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists file.
  
CMake Error at src/CMakeLists.txt:84 (add_executable):
  Target "drkonqi" links to target "KF5::WindowSystem" but the target was 
not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, 
or
  an ALIAS target is missing?
  
  After adding the missing find_package, I was able to compile it but unable to 
make it to work with a test here, will do some tests to figure out the problem.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.11 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.11/12/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 22 Nov 2018 19:42:23 +
 Build duration:
1 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 158.91 KB...][ 31%] Built target backtraceparsertest_autogenScanning dependencies of target backtraceparsertest[ 32%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest.dir/fakebacktracegenerator.cpp.o[ 33%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest.dir/backtraceparsertest.cpp.o[ 35%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest.dir/backtraceparsertest_autogen/mocs_compilation.cpp.o[ 33%] Built target drkonqi_autogen[ 36%] Generating ui_assistantpage_bugzilla_send.h[ 37%] Generating ui_maindialog.h[ 39%] Generating ui_backtracewidget.h[ 40%] Generating ui_assistantpage_introduction.h[ 41%] Linking CXX executable ../../../bin/bugzillalibtest[ 43%] Generating ui_assistantpage_bugawareness.h[ 44%] Generating ui_assistantpage_conclusions.h[ 45%] Generating ui_assistantpage_conclusions_dialog.h[ 47%] Generating ui_assistantpage_bugzilla_login.h[ 48%] Generating ui_assistantpage_bugzilla_duplicates.h[ 50%] Generating ui_assistantpage_bugzilla_duplicates_dialog.h[ 51%] Generating ui_assistantpage_bugzilla_duplicates_dialog_confirmation.h[ 52%] Generating ui_assistantpage_bugzilla_information.h[ 54%] Generating ui_assistantpage_bugzilla_preview.h[ 54%] Built target bugzillalibtestScanning dependencies of target drkonqi[ 55%] Building CXX object src/CMakeFiles/drkonqi.dir/main.cpp.o[ 56%] Building CXX object src/CMakeFiles/drkonqi.dir/drkonqidialog.cpp.o[ 58%] Building CXX object src/CMakeFiles/drkonqi.dir/backtraceratingwidget.cpp.o[ 59%] Building CXX object src/CMakeFiles/drkonqi.dir/aboutbugreportingdialog.cpp.o[ 60%] Building CXX object src/CMakeFiles/drkonqi.dir/statuswidget.cpp.o[ 62%] Linking CXX executable ../../../bin/backtraceparsertest_manual[ 63%] Building CXX object src/CMakeFiles/drkonqi.dir/backtracewidget.cpp.o[ 63%] Built target backtraceparsertest_manual[ 64%] Building CXX object src/CMakeFiles/drkonqi.dir/backtracegenerator.cpp.o[ 66%] Building CXX object src/CMakeFiles/drkonqi.dir/drkonqi.cpp.o[ 67%] Building CXX object src/CMakeFiles/drkonqi.dir/drkonqibackends.cpp.o[ 68%] Building CXX object src/CMakeFiles/drkonqi.dir/detachedprocessmonitor.cpp.o[ 70%] Building CXX object src/CMakeFiles/drkonqi.dir/debugpackageinstaller.cpp.o[ 71%] Linking CXX executable ../../../bin/backtraceparsertest[ 72%] Building CXX object src/CMakeFiles/drkonqi.dir/systeminformation.cpp.o[ 74%] Building CXX object src/CMakeFiles/drkonqi.dir/crashedapplication.cpp.o[ 75%] Building CXX object src/CMakeFiles/drkonqi.dir/debugger.cpp.o[ 77%] Building CXX object src/CMakeFiles/drkonqi.dir/debuggerlaunchers.cpp.o[ 78%] Building CXX object src/CMakeFiles/drkonqi.dir/debuggermanager.cpp.o[ 78%] Built target backtraceparsertest[ 79%] Building CXX object src/CMakeFiles/drkonqi.dir/applicationdetailsexamples.cpp.o[ 81%] Building CXX object src/CMakeFiles/drkonqi.dir/gdbhighlighter.cpp.o[ 82%] Building CXX object src/CMakeFiles/drkonqi.dir/statusnotifier.cpp.o/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 SUSEQt5.11/src/debugger.cpp: In static member function ���static QList Debugger::availableDebuggers(const QString&, const QString&)���:/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 SUSEQt5.11/src/debugger.cpp:135:46: error: ���QCoreApplication��� has not been declared QString(QStringLiteral("%1/%2")).arg(QCoreApplication::applicationDirPath(), path)  ^~~~/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 SUSEQt5.11/src/debugger.cpp:136:5: error: no matching function for call to ���QStringList::QStringList()��� }; ^In file included from /usr/include/qt5/QtCore/qlist.h:1094, from /usr/include/qt5/QtCore/qvariant.h:45, from /usr/include/qt5/QtCore/QVariant:1, from /home/jenkins/install-prefix/include/KF5/KConfigCore/kconfig.h:32, from /home/jenkins/install-prefix/include/KF5/KConfigCore/ksharedconfig.h:25, from /home/jenkins/install-prefix/include/KF5/KConfigCore/KSharedConfig:1, from /home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 SUSEQt5.11/src/debugger.h:22, from /home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 SUSEQt5.11/src/debugger.cpp:17:/usr/include/qt5/QtCore/qstringlist.h:110:12: note: candidate: ���QStringList::QStringList(std::initializer_list)��� inline QStringList(std::initializer_list args) : QList(args) { }^~~/usr/include/qt5/QtCore/qstringlist.h:110:12: note:   candidate expects 1 argument, 2 provided/usr/include/qt5/QtCore/qstringlist.h:107:12: note: candidate: ���QStringList::QStringList(QList&&)��� inline 

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.11 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.11/12/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Thu, 22 Nov 2018 19:42:23 +
 Build duration:
1 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 115.80 KB...][ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.o[ 12%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.o[ 13%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.o[ 14%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.oScanning dependencies of target bugzillalibtest[ 16%] Building CXX object src/tests/bugzillalibtest/CMakeFiles/bugzillalibtest.dir/bugzillalibtest.cpp.o[ 17%] Building CXX object src/tests/bugzillalibtest/CMakeFiles/bugzillalibtest.dir/__/__/bugzillaintegration/bugzillalib.cpp.o[ 18%] Building CXX object src/tests/bugzillalibtest/CMakeFiles/bugzillalibtest.dir/drkonqi_debug.cpp.o[ 20%] Building CXX object src/tests/bugzillalibtest/CMakeFiles/bugzillalibtest.dir/bugzillalibtest_autogen/mocs_compilation.cpp.o[ 21%] Linking CXX executable ../../../bin/crashtest[ 22%] Linking CXX static library ../../lib/libdrkonqi_backtrace_parser.a[ 22%] Built target drkonqi_backtrace_parserScanning dependencies of target backtraceparsertest_manual_autogenScanning dependencies of target drkonqi_autogenScanning dependencies of target backtraceparsertest_autogen[ 24%] Automatic MOC for target backtraceparsertest_manual[ 25%] Automatic MOC for target drkonqi[ 27%] Automatic MOC for target backtraceparsertest[ 27%] Built target crashtest[ 27%] Built target backtraceparsertest_manual_autogenScanning dependencies of target backtraceparsertest_manual[ 28%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest_manual.dir/backtraceparsertest_manual.cpp.o[ 29%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest_manual.dir/backtraceparsertest_manual_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest_manual.dir/fakebacktracegenerator.cpp.o[ 32%] Linking CXX executable ../../../bin/bugzillalibtest[ 32%] Built target backtraceparsertest_autogenScanning dependencies of target backtraceparsertest[ 33%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest.dir/backtraceparsertest.cpp.o[ 35%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest.dir/backtraceparsertest_autogen/mocs_compilation.cpp.o[ 36%] Building CXX object src/tests/backtraceparsertest/CMakeFiles/backtraceparsertest.dir/fakebacktracegenerator.cpp.o[ 36%] Built target drkonqi_autogen[ 39%] Generating ui_maindialog.h[ 39%] Generating ui_assistantpage_bugzilla_send.h[ 40%] Generating ui_backtracewidget.h[ 40%] Built target bugzillalibtest[ 41%] Generating ui_assistantpage_introduction.h[ 43%] Generating ui_assistantpage_bugawareness.h[ 44%] Generating ui_assistantpage_conclusions.h[ 45%] Generating ui_assistantpage_conclusions_dialog.h[ 47%] Generating ui_assistantpage_bugzilla_login.h[ 48%] Generating ui_assistantpage_bugzilla_duplicates.h[ 50%] Generating ui_assistantpage_bugzilla_duplicates_dialog.h[ 51%] Generating ui_assistantpage_bugzilla_duplicates_dialog_confirmation.h[ 52%] Generating ui_assistantpage_bugzilla_information.h[ 54%] Generating ui_assistantpage_bugzilla_preview.h[ 55%] Linking CXX executable ../../../bin/backtraceparsertest_manualScanning dependencies of target drkonqi[ 56%] Building CXX object src/CMakeFiles/drkonqi.dir/main.cpp.o[ 59%] Building CXX object src/CMakeFiles/drkonqi.dir/statuswidget.cpp.o[ 59%] Building CXX object src/CMakeFiles/drkonqi.dir/drkonqidialog.cpp.o[ 60%] Building CXX object src/CMakeFiles/drkonqi.dir/backtraceratingwidget.cpp.o[ 62%] Building CXX object src/CMakeFiles/drkonqi.dir/aboutbugreportingdialog.cpp.o[ 63%] Building CXX object src/CMakeFiles/drkonqi.dir/backtracewidget.cpp.o[ 63%] Built target backtraceparsertest_manual[ 64%] Building CXX object src/CMakeFiles/drkonqi.dir/backtracegenerator.cpp.o[ 66%] Building CXX object src/CMakeFiles/drkonqi.dir/drkonqi.cpp.o[ 67%] Building CXX object src/CMakeFiles/drkonqi.dir/drkonqibackends.cpp.o[ 68%] Building CXX object src/CMakeFiles/drkonqi.dir/detachedprocessmonitor.cpp.o[ 70%] Building CXX object src/CMakeFiles/drkonqi.dir/debugpackageinstaller.cpp.o[ 71%] Linking CXX executable ../../../bin/backtraceparsertest[ 72%] Building CXX object src/CMakeFiles/drkonqi.dir/systeminformation.cpp.o[ 74%] Building CXX object src/CMakeFiles/drkonqi.dir/crashedapplication.cpp.o[ 75%] Building CXX object src/CMakeFiles/drkonqi.dir/debugger.cpp.o[ 77%] Building CXX object src/CMakeFiles/drkonqi.dir/debuggerlaunchers.cpp.o[ 77%] Built target backtraceparsertest[ 78%] Building CXX 

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

[patrick j pereira]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:515425143cb3: debugger: DataLocation is deprecated, move 
to AppDataLocation (authored by patrickelectric).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17024?vs=45831=46034

REVISION DETAIL
  https://phabricator.kde.org/D17024

AFFECTED FILES
  src/debugger.cpp

To: patrickelectric, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  That blur looks nice, but I think the background should be more opaque like 
the Elisa header background.F6437066: Screenshot_20181122_005432.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D4929: DrKonqi : lldb and Mac support

[patrick j pereira]

patrickelectric added a comment.


  After taking a second look on it, I was able to merge the patch from the 
`src`folder and not from the repository root folder, weird..
  Will do the tests here and now !

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4929: DrKonqi : lldb and Mac support

[René J . V . Bertin]

rjvbb added a comment.


  >   Can you rebase it over the last master branch ?
  
  I did that hours ago, or at least I thought I did?! Is there a commit later 
than 62c33ba3a885106f31706cbfecc75190ca00c70c 
 
which I somehow do not see yet?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D17107: global menu,rename menuHidden to visible

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --as @mart requested we can rename "menuHidden" property
  to "visible" in order to follow Qt naming

TEST PLAN
  --check that global menu applet is functioning the same
  way as when using removed menuHidden property

REPOSITORY
  R120 Plasma Workspace

BRANCH
  menuVisible

REVISION DETAIL
  https://phabricator.kde.org/D17107

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, mart, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D16715: make global menu minimize state aware

[Michail Vourlakos]

mvourlakos added a comment.


  included in D16768  and I will upload a 
new patch to rename menuHidden -> visible as @mart requested

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16715

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: mart, trmdi, apol, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D16805: improve variable name for global menu model

[Michail Vourlakos]

mvourlakos abandoned this revision.
mvourlakos added a comment.


  included in D16768 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16805

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16768: mage global menu screen aware

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3fa1cc6b7716: mage global menu screen aware (authored by 
mvourlakos).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16768?vs=45243=46031

REVISION DETAIL
  https://phabricator.kde.org/D16768

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D16860: touchscreen text controls

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  phab/textcontrols

REVISION DETAIL
  https://phabricator.kde.org/D16860

To: mart, #plasma, apol
Cc: apol, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17105: Add a new lookandfeel runner

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46028.
apol added a comment.


  LnF themes don't really have an icon

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17105?vs=46027=46028

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17105

AFFECTED FILES
  runners/CMakeLists.txt
  runners/lookandfeel/CMakeLists.txt
  runners/lookandfeel/Messages.sh
  runners/lookandfeel/lookandfeelrunner.cpp
  runners/lookandfeel/lookandfeelrunner.h
  runners/lookandfeel/plasma-runner-lookandfeel.desktop

To: apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17105: Add a new lookandfeel runner

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  I was using my laptop in the dark and hoping I could tone my colors down, 
thought this could be convenient enough.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17105

AFFECTED FILES
  runners/CMakeLists.txt
  runners/lookandfeel/CMakeLists.txt
  runners/lookandfeel/Messages.sh
  runners/lookandfeel/lookandfeelrunner.cpp
  runners/lookandfeel/lookandfeelrunner.h
  runners/lookandfeel/plasma-runner-lookandfeel.desktop

To: apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16860: touchscreen text controls

[Marco Martin]

mart added a comment.


  In D16860#364161 , @apol wrote:
  
  > isn't this a bit too binary? Maybe it makes sense to have hover effects 
even if on tablet mode. isn't it a matter of whether it comes from a finger?
  
  
  i don't think we can know that from QML, would need access to events of the 
textedit, which would need a c++ based eventfilter (not sure i want to go 
there?)
  I would use the way we are using for everything which is this central 
tabletmode config point.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16860

To: mart, #plasma
Cc: apol, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D4929: DrKonqi : lldb and Mac support

[patrick j pereira]

patrickelectric added a comment.


  Can you rebase it over the last master branch ?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  In D17079#364263 , @apol wrote:
  
  > In D17079#364163 , @ltoscano 
wrote:
  >
  > > In D17079#364157 , @mart wrote:
  > >
  > > > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  > >
  > >
  > > kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.
  >
  >
  > I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  >  That said, we'll need someone to register the KAbout* types somewhere too, 
but we can also rely on applications doing that as a first iteration.
  
  
  one thing i'm a bit concerned is kirigami becomeing too much of a QML kdelibs 
monolith :p

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4929: DrKonqi : lldb support

[René J . V . Bertin]

rjvbb updated this revision to Diff 46025.
rjvbb added a comment.


  Refactored for the standalone DrKonqi repo and disabled the integration 
testing on Mac.
  
  Making DrKonqi standalone is a good step, I'd strongly suggest to move it to 
KF5 Applications at the first possible occasion. The utility doesn't even 
depend on a single Plasma library and provides a service that has nothing 
Plasma-desktop specific.
  
  Instead, ask yourself if automatic crash reports are welcome only from Plasma 
desktop users or if as many users as possible should be able to submit crash 
reports (i.e. from any platform where DrKonqi is functional). Better, don't ask 
yourself, ask the entire family of KDE developers.
  
  On a related note: DrKonqi's dependencies have been bumped along with the 
other Plasma dependencies. That's overkill: it has no business requiring Qt 
5.11, 5.9LTS provides all required APIs. Similarly, it builds just fine against 
KF5 Frameworks 5.47.0, possibly even earlier versions.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4929?vs=12368=46025

REVISION DETAIL
  https://phabricator.kde.org/D4929

AFFECTED FILES
  src/CMakeLists.txt
  src/aboutbugreportingdialog.cpp
  src/backtracegenerator.cpp
  src/backtracegenerator.h
  src/backtracewidget.cpp
  src/bugzillaintegration/reportassistantdialog.cpp
  src/data/AppleTerminal
  src/data/CMakeLists.txt
  src/data/debuggers/external.mac/gdbrc
  src/data/debuggers/external.mac/kdbgrc
  src/data/debuggers/external.mac/lldbrc
  src/data/debuggers/external/lldbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/drkonqibackends.cpp
  src/drkonqidialog.cpp
  src/main.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparserlldb.cpp
  src/parser/backtraceparserlldb.h
  src/tests/CMakeLists.txt

To: rjvbb, #plasma_workspaces, kfunk
Cc: patrickelectric, kfunk, mart, broulik, kde-mac, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4929: DrKonqi : lldb support

[René J . V . Bertin]

rjvbb marked an inline comment as done.
rjvbb added a comment.


  Sorry, I had updating this on my list but it drifted to the bottom...
  
  I think I've addressed all feedback apart from the `m_lldbDetached` variable 
Kevin objected to. I'm open to suggestions how to make that aspect less 
eyebrow-raising. Give it a more generic name and add a comment that it's only 
set/used for lldb (or else set it in every backend)?

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: patrickelectric, kfunk, mart, broulik, kde-mac, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17064: datetime runner: Match timezones less restrictively

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17064

To: apol, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17080: Make it possible to fallback to a different icon

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17080

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17079#364163 , @ltoscano wrote:
  
  > In D17079#364157 , @mart wrote:
  >
  > > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  >
  >
  > kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.
  
  
  I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  That said, we'll need someone to register the KAbout* types somewhere too, 
but we can also rely on applications doing that as a first iteration.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17102: Connect to contextMenu clicked callback only once

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:453b420ceb42: Connect to contextMenu clicked callback 
only once (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17102?vs=46017=46021

REVISION DETAIL
  https://phabricator.kde.org/D17102

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17102: Connect to contextMenu clicked callback only once

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The connection isn't bound to the menu entry but global causing the handler 
to fire multiple times, one more for every device added.

TEST PLAN
  Unpaired and paired my phone repeatedly, sent a link to it, it only opened 
once on my phone now

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D17102

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16889: Listen to KDE Connect device signals

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:b4a5f02482f6: Listen to KDE Connect device signals 
(authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16889?vs=46015=46016

REVISION DETAIL
  https://phabricator.kde.org/D16889

AFFECTED FILES
  host/kdeconnectplugin.cpp
  host/kdeconnectplugin.h

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: kdeconnect, apol, bruns, plasma-devel, shivanshukantprasad, skymoore, 
wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, 
johnq, ragreen, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, ZrenBot, 
seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, mikesomov, 
jensreuterberg, tctara, abetts, sebas, mart

D16889: Listen to KDE Connect device signals

[Kai Uwe Broulik]

broulik updated this revision to Diff 46015.
broulik added a comment.


  - Check earlier

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16889?vs=46013=46015

REVISION DETAIL
  https://phabricator.kde.org/D16889

AFFECTED FILES
  host/kdeconnectplugin.cpp
  host/kdeconnectplugin.h

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: kdeconnect, apol, bruns, plasma-devel, shivanshukantprasad, skymoore, 
wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, 
johnq, ragreen, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, ZrenBot, 
seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, mikesomov, 
jensreuterberg, tctara, abetts, sebas, mart

D16889: Listen to KDE Connect device signals

[Kai Uwe Broulik]

broulik updated this revision to Diff 46013.
broulik added a comment.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.


  - Check if device is already known just before emitting

REPOSITORY
  R224 KDE Connect

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16889?vs=46012=46013

REVISION DETAIL
  https://phabricator.kde.org/D16889

AFFECTED FILES
  host/kdeconnectplugin.cpp
  host/kdeconnectplugin.h

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: kdeconnect, apol, bruns, plasma-devel, shivanshukantprasad, skymoore, 
wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, 
johnq, ragreen, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, ZrenBot, 
seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, mikesomov, 
jensreuterberg, tctara, abetts, sebas, mart

D16889: Listen to KDE Connect device signals

[Kai Uwe Broulik]

broulik updated this revision to Diff 46012.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16889?vs=46011=46012

REVISION DETAIL
  https://phabricator.kde.org/D16889

AFFECTED FILES
  extension/extension.js
  host/kdeconnectplugin.cpp
  host/kdeconnectplugin.h

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16889: Listen to KDE Connect device signals

[Kai Uwe Broulik]

broulik updated this revision to Diff 46011.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16889?vs=45496=46011

REVISION DETAIL
  https://phabricator.kde.org/D16889

AFFECTED FILES
  extension/extension.js
  host/kdeconnectplugin.cpp
  host/kdeconnectplugin.h

To: broulik, #plasma, davidedmundson, fvogt, nicolasfella
Cc: apol, bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17073: Do not crop albumArt

[trmdi]

trmdi updated this revision to Diff 46007.
trmdi edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=45950=46007

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D4929: DrKonqi : lldb support

[patrick j pereira]

patrickelectric added a comment.
This revision now requires changes to proceed.


  What is the actual state of this patch ?

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: patrickelectric, kfunk, mart, broulik, kde-mac, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Luigi Toscano]

ltoscano added a comment.


  In D17079#364157 , @mart wrote:
  
  > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  
  
  kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D16860: touchscreen text controls

[Aleix Pol Gonzalez]

apol added a comment.


  isn't this a bit too binary? Maybe it makes sense to have hover effects even 
if on tablet mode. isn't it a matter of whether it comes from a finger?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16860

To: mart, #plasma
Cc: apol, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> DiscoverWindow.qml:76
>  }
> +TopLevelPageData {
> +id: aboutAction

can you try how does it look for this page to be pushed as a layer instead of 
the main PageRow?
would be like applicationWindow().pageStack.layers.push(thecomponentorurl)
it would end up more "modal"than using the main row.
I have no idea what would be better usability-wise, but is a thing could be 
tried (and then codified in the hig)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Relicensing of file in plasma-phone-components

[Marco Martin]

Hi Bhushan,
i'm fine as well going to LGPL
On Wed, Nov 21, 2018 at 5:21 PM Martin Klapetek
 wrote:
>
> Hi,
>
> I'm fine with relicensing my contributions to 
> plasma-phone-components/dialer/src/dialerutils.*
> code from GPL2 to either GPL2+ or LGPL.
>
> Cheers
> --
> Martin Klapetek
>
>
> On Sun, Nov 18, 2018 at 7:47 AM Bhushan Shah  wrote:
>>
>> Hello everyone,
>>
>> I am writing to you since you have commited to the
>> plasma-phone-components/dialer/src/dialerutils.* code.
>>
>> (Volker in CC list because he raised the current issue, Volker is not
>> committer to files.)
>>
>> Current code is GPL2, which is incompatible with the Apache2 license of
>> libphonenumber we want to use.
>>
>> Do you grant permission to relicense this code to either GPL2+ or LGPL?
>>
>> Thanks.
>>
>> --
>> Bhushan Shah
>> http://blog.bshah.in
>> IRC Nick : bshah on Freenode
>> GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  In D17079#363975 , @ngraham wrote:
  
  > Cool!
  >
  > For this design, I'd like to get rid of the tabs and put everything in a 
scrollview. We generally have enough space that a tabbed view is overkill.
  
  
  +1

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Basically what Nate said, this is a great idea :) Thinking that having this 
is already an improvement, but also perhaps that having it as a scrollable page 
would indeed feel more natural here rather than tabs... Thinking this seems 
like a good place to use the fact that Cards are good for not-quite-similar 
data, or am i off there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> comic.cpp:527
> +mActionScaleContent->setEnabled(false);
> +mActionShop->setEnabled(false);
> +mActionStorePosition->setEnabled(false);

Check against nullptr like else branch?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17094

To: pavelmos, jriddell, bshah, davidedmundson
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in comic.cpp:196
> Just move this after brace.

Yes, I agree. Your remark is true

REVISION DETAIL
  https://phabricator.kde.org/D17095

To: pavelmos, jriddell, bshah, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos updated this revision to Diff 45996.
pavelmos marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17095?vs=45995=45996

REVISION DETAIL
  https://phabricator.kde.org/D17095

AFFECTED FILES
  applets/comic/comic.cpp

To: pavelmos, jriddell, bshah, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Anthony Fieroni]

anthonyfieroni added a reviewer: Plasma.
anthonyfieroni added inline comments.

INLINE COMMENTS

> comic.cpp:196
>  updateComic( previousIdentifierSuffix );
>  return;
>  }

Just move this after brace.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17095

To: pavelmos, jriddell, bshah, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Crash happens on trying to load an unsupported format content such as video.
  To prevent a crash, the patch blocks the loading of unsupported content (such 
as video) instead of a picture when switching comic strip.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17095

AFFECTED FILES
  applets/comic/comic.cpp

To: pavelmos
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

[Pavel Mos]

pavelmos created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Crash happens on trying to use the context menu of widget with no active 
comics.
  The patch disables some items in this context menu to prevent crashes.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17094

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: pavelmos
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17076: Avoid indeterminism in kcolorschemeeditor

[Bernhard M. Wiedemann]

bmwiedemann added a comment.


  Can you please push it?
  I am contributing so rarely, that it is not worth having commit access.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17076

To: bmwiedemann, rwooninck, ochurlaud
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  If you want to try adding blur to the background, check out the code here: 
https://cgit.kde.org/elisa.git/tree/src/qml/HeaderBar.qml#n53

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Noah Davis]

ndavis added a comment.


  In D17073#364003 , @trmdi wrote:
  
  > How about this ?
  >  F6436415: test.png 
  
  
  I think this version works much better than the other 2. It shows the entire 
image and it fills up the space while maintaining the consistent thumbnail size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: ndavis, abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Anthony Fieroni]

anthonyfieroni added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[trmdi]

trmdi added a comment.


  How about this ?
  F6436415: test.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16873: [comic] Request current identifier on date changed

[Anthony Fieroni]

anthonyfieroni added a comment.


  @davidedmundson have more little fixes over applet did you something 
suspicious here, i plan to commit them before 5.14.4 release.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16873

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart