D16873: [comic] Request current identifier on date changed

[Anthony Fieroni]

anthonyfieroni added a comment.


  I will push it in few days, since no activity.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16873

To: anthonyfieroni, #plasma, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.11 - Build # 34 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.11/34/
 Project:
stable-kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 07 Dec 2018 07:23:40 +
 Build duration:
3 min 7 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.11’Running on FreeBSD Builder 3 in /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/kwin +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: read error: Connection reset by peer	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2016)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1735)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:420)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:629)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 3		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor425.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy80.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:120)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:90)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:77)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 47011.
GB_2 added a comment.


  Increase tooltip timeout.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47010=47011

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 47010.
GB_2 added a comment.


  Improve code and add tooltip timeout.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46973=47010

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

[Anthony Fieroni]

anthonyfieroni added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17394: [Device Notifier] Fix transition animation

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice catch! This works and looks good to me, but let's make sure the #plasma 
 folks agree. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_transitions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17394

To: thsurrel, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

[Nathaniel Graham]

ngraham added a comment.


  I see, you're right!
  
  Finally got to test this out instead of just complaining about the pictures. 
:) I now have `KDeclarative`, `KCMUtils`,  and `KWidgetsAddons` with the 
necessary changes, but when I compile System Settings with this, I see the 
following:
  
  With certain KCMs, the sizes don't seem identical:
  F6460363: Too big.png 
  
  But with other ones, they do:
  F6460369: Same size.png 
  
  I have reservations about how well this larger size will work for wordy 
languages like German. We already have some strings elided in English:
  F6460365: Elided text.png 
  
  With this patch, the back button's text just seems, I dunno, //too big.//

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: fabianr, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

[Nathaniel Graham]

ngraham updated this revision to Diff 47003.
ngraham added a comment.


  Also give the Properties action a shortcut, so now the menu is 100% identical 
with Dolphin's

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17393?vs=47000=47003

BRANCH
  context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17393

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: ngraham, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17394: [Device Notifier] Fix transition animation

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  In the specific case of having the device notifier opened
  and inserting a device that has been configured to be
  automatically mounted, the transition animation could be
  interrupted resulting in the opacity being wrong.

TEST PLAN
  In the setup discribed in the summary, you should never
  see something like the attached screenshot where the list
  of action opacity is not 1.
  
  See 
http://doc.qt.io/qt-5/qml-qtquick-viewtransition.html#handling-interrupted-animations
  for more information.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_transitions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17394

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/DeviceItem.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17393: [Folder View] make file context menu consistent with Dolphin's

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 401652
  FIXED-IN: 5.15.0

TEST PLAN
  Folder view now:
  
  Matches Dolphin:
  
  (the lack of a separator over Properties in Dolphin seems like a recent 
regression that I will go fix now, because it always had that before)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  context-menu-consistency-with-dolphin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17393

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Still looks great to me! Would be nice to get a #plasma 
 person's comments too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Thomas Surrel]

thsurrel marked an inline comment as done.
thsurrel added inline comments.

INLINE COMMENTS

> ngraham wrote in devicenotifier.qml:51
> En Anglais, les mots n'utilisent pas la lettre «u» aussi souvent qu'en 
> Français. :)

Je ne savais pas que tu parlais français ! 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> thsurrel wrote in devicenotifier.qml:51
> I put too much French into this one ;)

En Anglais, les mots n'utilisent pas la lettre «u» aussi souvent qu'en 
Français. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Thomas Surrel]

thsurrel marked 2 inline comments as done.
thsurrel added inline comments.

INLINE COMMENTS

> ngraham wrote in devicenotifier.qml:51
> mountedRemouvables -> mountedRemovables (and change all other instances, 
> obviously)

I put too much French into this one ;)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Thomas Surrel]

thsurrel updated this revision to Diff 46999.
thsurrel added a comment.


  Improvements as per Nate's comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16212?vs=46939=46999

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Nathaniel Graham]

ngraham added a comment.


  We're getting there!
  
  Right now, the tooltip appears if I click-and-hold for a moment, but not when 
I just click. Since that's the use case we're targeting, we should probably 
make it appear for click-and-quickly-release as well.

INLINE COMMENTS

> EdgeHandle.qml:36
> +visible: false
> +height: panel.location == PlasmaCore.Types.TopEdge || panel.location 
> == PlasmaCore.Types.BottomEdge ? 40 : 60
> +width: panel.location == PlasmaCore.Types.TopEdge || panel.location 
> == PlasmaCore.Types.BottomEdge ? 190 : 130

Hardcoding heights and widths like this strikes me as likely to break for 
translated text, which could be much longer or shorter.

> EdgeHandle.qml:39
> +x: parent.width / 2 - width / 2
> +y: panel.location == PlasmaCore.Types.TopEdge || panel.location == 
> PlasmaCore.Types.BottomEdge ? 32 : -62
> +contentItem: PlasmaComponents.Label {

Like the widths and heights above, these magic numbers seem fragile. It's 
probably better to position using anchors rather than `x` and `y` values like 
this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[TrickyRicky]

trickyricky26 added a comment.


  Will that tooltip be shown when just clicking on the button without dragging?
  
  It would be very helpful to trigger the tooltip when the button is pressed, 
but not dragged.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:119
> +enabled: true
> +visible: devicenotifier.mountedRemouvables.length > 0;
> +anchors.right: parent.right

What do you think about changing this to `> 1`? It seems kind of redundant to 
have an "unmount all" button when there's only one item.

> devicenotifier.qml:51
>  property int currentIndex: -1
> +property var mountedRemouvables: []
>  

mountedRemouvables -> mountedRemovables (and change all other instances, 
obviously)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7260: System tray icon's context menu isn't updated properly in plasma/x11

[Aleksei Nikiforov]

i.Dark_Templar added a comment.


  Any news on this bug and this change yet?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7260

To: i.Dark_Templar, #plasma, davidedmundson
Cc: broulik, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16658: Respect the display property of buttons

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16658

To: astippich, #plasma, apol, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Alex Debus]

alexde added a comment.


  In D17354#372274 , @ngraham wrote:
  
  > Changing the style just here would introduce inconsistency at a time when 
we're trying to make everything more consistent. The current FormLayout style 
is what we've decided on for the moment and I think it makes sense to fully 
implement it before we think about replacing it with something else. :)
  
  
  Sounds reasonable to me! ;) Can you please point me to the discussion? Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ad34212a8ccd: [Digital clock plasmoid] Calendar settings 
page: port to QQC2  Kirigami and… (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17354?vs=46967=46992

REVISION DETAIL
  https://phabricator.kde.org/D17354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Nathaniel Graham]

ngraham added a comment.


  In D17354#372270 , @alexde wrote:
  
  > Thank you Nate! I am just curious if you considered to structure titles and 
options vertically, where the options are indented by a tab:
  
  
  Yes, quite a bit. This current layout style is the result of an //enormous// 
amount of internal discussion. There is no one style that pleased everyone, but 
this is the one that was most popular and generally considered the most 
attractive and pleasant to use overall. Again, you can't please everybody 
especially in matters of style and design, but this style seemed overall to be 
the favorite when we were trying to figure what we should standardize on.
  
  Changing the style just here would introduce inconsistency at a time when 
we're trying to make everything more consistent. The current FormLayout style 
is what we've decided on for the moment and I think it makes sense to fully 
implement it before we think about replacing it with something else. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve-calendar-settings-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Alex Debus]

alexde added a comment.


  Thank you Nate! I am just curious if you considered to structure titles and 
options vertically, where the options are indeted by a tab:
  
  General
  
[  ] Show week number
  
  Available plugins
  
[  ] Plugin A
[  ] Plugin B
  
  That's would I personally would favor.
  
  Kind Regards

REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve-calendar-settings-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46973.
GB_2 added a comment.


  Add import.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46972=46973

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Oops, forgot the import...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46972.
GB_2 added a comment.


  Use QQC2 tooltip.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46971=46972

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Nathaniel Graham]

ngraham added a comment.


  Hmm, that tooltip doesn't match the style. Why not use the QQC2 tooltip?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46971.
GB_2 added a comment.


  Added the tooltip.
  F6459564: Panel Edit Mode Buttons (3).png 

  It is ready now!

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46749=46971

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17375: Don't automatically refresh if the user already asked apt to do so

[Rik Mills]

rikmills added a comment.


  Seems good to me, and a quick test on a stock Kubuntu install gets the 
updater registering new updates when the system does its own refresh.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Marco Martin]

mart accepted this revision.
mart added a comment.


  I've just done a round of testing of the latest revision together my last 
kwin patch, including:
  
  - adding and/or removinf desktops
  - changing the number of rows
  - renaming some desktops
  - restarting kwin randomly after any of the above to see settings are kept, 
without restarting the kcm which keeps showing coherent data
  
  so, definitely lgtm (adding ship it as my personal one, still needs David's)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17362: [RFC] [FormLayout] Top-align item labels

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Not necessary; found a way to implement this goal in D17362 
 without changes to Kirigami.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17362

To: ngraham, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Nathaniel Graham]

ngraham updated this revision to Diff 46967.
ngraham added a comment.


  Align the label to the first child properly

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17354?vs=46872=46967

BRANCH
  improve-calendar-settings-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configCalendar.qml

To: ngraham, #plasma, #vdg, mart
Cc: mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D4929: DrKonqi : lldb and Mac support

[David Edmundson]

davidedmundson added a comment.


  Yeah, it's all fine. Sorry should have replied when you asked.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4929: DrKonqi : lldb and Mac support

[René J . V . Bertin]

rjvbb added a comment.


  > This revision was not accepted when it landed; it landed in state "Needs 
Review".
  
  Because I asked David if he'd seen the very last (=just committed) revision 
when he accepted this. He'd have infirmed that by now if our posts had crossed 
so I felt I could push this.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4929: DrKonqi : lldb and Mac support

[René J . V . Bertin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:13121f4a303b: lldb and Mac support (authored by rjvbb).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4929?vs=46309=46944

REVISION DETAIL
  https://phabricator.kde.org/D4929

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/backtracegenerator.cpp
  src/backtracewidget.cpp
  src/data/debuggers/external.mac/lldbrc
  src/data/debuggers/external/lldbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/drkonqibackends.cpp
  src/main.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparserlldb.cpp
  src/parser/backtraceparserlldb.h
  src/tests/CMakeLists.txt

To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, 
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D16212: [Device Notifier] Add a button to unmount all devices

[Thomas Surrel]

thsurrel updated this revision to Diff 46939.
thsurrel added a comment.


  Fix button width

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16212?vs=43929=46939

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart