D18018: [Digital Clock] Add ability to change first day of week

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> configCalendar.qml:56
> +id: firstDayOfWeekComboBox
> +Kirigami.FormData.label: i18n("First day of week:")
> +// [-1, 0, 1, 2, 3, 4, 5, 6] // Default = -1, 0..6 = Sun..Sat

I'd add a "the" and make this "First day of the week"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18018

To: Zren, #plasma
Cc: ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18032: Fix USB view

[Alexandre Ferreira]

alexandref added a comment.


  Fix USB view to correctly present the USB hierarchy

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18032

To: alexandref
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18032: Fix USB view

[Alexandre Ferreira]

alexandref created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexandref requested review of this revision.

REVISION SUMMARY
  Fix
  BUG: 402949

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18032

AFFECTED FILES
  Modules/usbview/usb.ids
  Modules/usbview/usbdevices.cpp

To: alexandref
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18027: Use the nicer K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18027

To: aacid, apol
Cc: apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18027: Use the nicer K_PLUGIN_CLASS_WITH_JSON

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks much better!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18027

To: aacid, apol
Cc: apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18027: Use the nicer K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18027

AFFECTED FILES
  freespacenotifier/module.cpp
  kcms/translations/translations.cpp
  kioslave/desktop/desktopnotifier.cpp
  ktimezoned/ktimezoned.cpp
  ktimezoned/ktimezoned_win.cpp
  libcolorcorrect/kded/locationupdater.cpp
  solidautoeject/solidautoeject.cpp
  soliduiserver/soliduiserver.cpp
  statusnotifierwatcher/statusnotifierwatcher.cpp
  systemmonitor/kdedksysguard.cpp

To: aacid
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Nathaniel Graham]

ngraham added a comment.


  @filipf That looks about right!
  
  @davidedmundson Reading through that bug report, it looks like we do some 
magic to avoid storing huge pixmaps in memory, so is it true that this change 
would avoid increasing users' memory consumption? I was thinking that on future 
memory constrained mobile devices especially, this might otherwise cause a 
deal-breaking regression and I don't want to be responsible for that. :)
  
  Also what exactly do you mean by "run-time resizes"? Where would these happen?

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18026: Use the nicer K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18026

AFFECTED FILES
  kded/daemon.cpp

To: aacid
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18025: Use the nicer K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18025

AFFECTED FILES
  dataengines/potd/apodprovider.cpp
  dataengines/potd/bingprovider.cpp
  dataengines/potd/epodprovider.cpp
  dataengines/potd/flickrprovider.cpp
  dataengines/potd/natgeoprovider.cpp
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/wcpotdprovider.cpp
  templates/plasmapotdprovider/src/%{APPNAMELC}.cpp

To: aacid
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17975: [WIP, Notifications] Add padding to notifications

[Nathaniel Graham]

ngraham added a comment.


  How are you scaling plasma? Are you setting `PLASMA_USE_QT_SCALING=1` to make 
sure it's really actually using the scale factor you set in the KScreen KCM?
  
  Technically Plasma doesn't support fractional scale factors yet (see 
https://bugs.kde.org/show_bug.cgi?id=356446) so if the only bugs you have occur 
there, maybe we can live with that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18023: Use the nicer K_PLUGIN_CLASS_WITH_JSON

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18023

AFFECTED FILES
  src/kcm/module.cpp

To: aacid
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Filip Fila]

filipf added a comment.


  Couldn't it be this? https://bugs.kde.org/show_bug.cgi?id=338506

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[David Edmundson]

davidedmundson added a comment.


  I can list bugs that you might have seen in 5.x.
  
  I can't name things in 4.x. which is when it was introduced.  Its before my 
plasma time.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Filip Fila]

filipf added a comment.


  In D18005#387738 , @davidedmundson 
wrote:
  
  > > In short, images were blurry when scaled and cropped.
  >
  > I want the "In long" version.  QImage resizing hasn't changed, and with the 
source size set that's what we'll be using.
  
  
  What I can say is that this Kubuntu experience wasn't a one off, I had to 
crop my wallpapers manually for the longest because Plasma would make them 
blurry if they didn't match the screen resolution. However, it's been working 
lately.
  
  I know this isn't the greatest info, could you help me investigate what 
//actually// changed in the meantime? I can test whatever's relevant.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[David Edmundson]

davidedmundson added a comment.


  > In short, images were blurry when scaled and cropped.
  
  I want the "In long" version.  QImage resizing hasn't changed, and with the 
source size set that's what we'll be using.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Filip Fila]

filipf added a comment.


  In D18005#387607 , @davidedmundson 
wrote:
  
  > What previous technical constraint are you referring to?
  
  
  See D18006#387372 . In short, 
images were blurry when scaled and cropped.
  
  > Our run-time resizes will look worse than gimp/inkscape doing it.
  
  Aside from Plasma doing non-artist style cropping, they seem fine to me tbh.
  
  > CPU usage to load an image is a sizable amount of our loading. Especially 
for JPEG images.
  >  You might see that less in 5.x as it now happens in another thread, and we 
don't necessarily max out all the cores - but still.
  
  In your estimate, how bad would the added load be?
  
  > Artists wanted some control over /how/ it's cropped. i.e if you have a 
mountain on the right and lots of sea to the left, you want to always cut off 
the boring sea part (i.e the spray folder)
  
  +1 but we need to do some sort of a trade off here. IMO I'd keep all of sizes 
for "Next", but for T9817  and T10220 
 we're put in a pretty bad situation if 
having to ship all sizes because we'll be want to shipping large resolution 
wallpapers and quite a few of them.
  
  For instance, just shipping a certain old Plasma wallpaper adds 20 MiB to the 
plasma-wallpapers package, which is already almost half of its current size  (a 
bit over 40 MiB).
  
  For comparison's sake Deepin, GNOME and Elementary also just offer one size 
in this extra package from I can tell.
  
  Also might be worth mentioning that the new photographic wallpapers in T10220 
 are CC0 or similar licence (Unsplash) and 
picked from third-party sites so there's no author involvement with KDE. We're 
also trying to select them based on whether or not it will get messed up with 
cropped.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18016: Don't use hardcoded background color

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:3a43aa10b4dd: Dont use hardcoded background color 
(authored by GB_2, committed by ngraham).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18016?vs=48811=48824

REVISION DETAIL
  https://phabricator.kde.org/D18016

AFFECTED FILES
  src/qml/main.qml

To: GB_2, #vdg, #breeze, davidedmundson, ngraham
Cc: ngraham, davidedmundson, #breeze, plasma-devel, #vdg, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18016: Don't use hardcoded background color

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Awesome! Now the only things left to fix are:
  
  - Make the frame in which this thing lives large enough to display all of it
  - Make the image picker remember the image you chose after leaving and 
reopening the KCM: https://bugs.kde.org/show_bug.cgi?id=402930

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18016

To: GB_2, #vdg, #breeze, davidedmundson, ngraham
Cc: ngraham, davidedmundson, #breeze, plasma-devel, #vdg, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.12/4/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 06 Jan 2019 18:59:48 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 14 test(s), Passed: 86 test(s), Skipped: 0 test(s), Total: 100 test(s)Failed: projectroot.autotests.integration.kwin_testDebugConsoleFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testInternalWindow_waylandonlyFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testShellClientFailed: projectroot.autotests.integration.kwin_testShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXClipboardSyncFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 3 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Adds a new `dateFormatStr` config key which is used when the `dateFormat` 
"StringEnum" is set to `custom`.
  Shows a link to the Qt time formatting documentation above the text field.
  Qt doc link and text field are hidden when not set to custom date format.
  
  CCBUG: 340982
  
  -
  
  - Should I add presets like Event Calendar?
  
  F6530111: 2019-01-06___13-15-19.png 
  
  F6530110: 2019-01-06___13-14-56.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Seems sensible.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  toolbutton

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich, mart, apol, davidedmundson
Cc: davidedmundson, hein, mgallien, ngraham, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18016: Don't use hardcoded background color

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18016

To: GB_2, #vdg, #breeze, davidedmundson
Cc: davidedmundson, #breeze, plasma-devel, #vdg, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18018: [Digital Clock] Add ability to change first day of week

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  CCBUG: 390330
  
  The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to 
represent the locale's default value.
  
  -
  
  If you have issues with the enum starting at -1, just say so and I'll shift 
it to Default=0, Sunday=1, Monday=2.
  
  F6530020: 2019-01-06___12-06-02.png 
  
  F6530016: 2019-01-06___11-55-41.png 

TEST PLAN
  - Open config > Calendar Tab > Change to First day of week to Wednesday
  - Open Digital Clock popup, confirm it starts at Wednesday
  - Close the widget config.
  - Reopen the widget config and confirm the ComboBox is populated with the 
correct (new) value.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18018

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/digital-clock/package/contents/ui/configCalendar.qml

To: Zren
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[David Edmundson]

davidedmundson added a comment.


  What previous technical constraint are you referring to?
  
  And we've had the multiple resolutions since 4.x so it dates back a long way.
  
  It's about a few things:
  
  - CPU usage to load an image is a sizable amount of our loading. Especially 
for JPEG images.
  
  You might see that less in 5.x as it now happens in another thread, and we 
don't necessarily max out all the cores - but still.
  
  - Artists wanted some control over /how/ it's cropped. i.e if you have a 
mountain on the right and lots of sea to the left, you want to always cut off 
the boring sea part (i.e the spray folder)
  
  - Our run-time resizes will look worse than gimp/inkscape doing it.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, cfeck, ndavis, plasma-devel, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18016: Don't use hardcoded background color

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Fixes the hardcoded SDDM theme preview background color
  F6530004: SDDM KCM Breeze.png 
  F6530005: SDDM KCM Breeze Dark.png 

TEST PLAN
  Open the SDDM KCM

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18016

AFFECTED FILES
  src/qml/main.qml

To: GB_2, #vdg, #breeze
Cc: #breeze, plasma-devel, #vdg, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Richard Addison]

raddison added a comment.


  You've got my blessing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze, GB_2, ngraham
Cc: raddison, ngraham, GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a3bbdef02ad8: [SDDM theme] Update the theme preview 
(authored by filipf, committed by GB_2).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18012?vs=48796=48802

REVISION DETAIL
  https://phabricator.kde.org/D18012

AFFECTED FILES
  sddm-theme/preview.png

To: filipf, #plasma, #vdg, #breeze, GB_2, ngraham
Cc: ngraham, GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18012: [SDDM theme] Update the theme preview

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice, ship it!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  new-sddm-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze, GB_2, ngraham
Cc: ngraham, GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18012: [SDDM theme] Update the theme preview

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  +1, updated and looks much better

REPOSITORY
  R120 Plasma Workspace

BRANCH
  new-sddm-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze, GB_2
Cc: GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Christoph Feck]

cfeck added a comment.


  Maybe symlinking all to the largest version?

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: cfeck, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Oussema Bouaneni]

oussemabouaneni added a comment.


  In D18012#387473 , @filipf wrote:
  
  > I believe it's because the old one has a plain color background, whereas 
for the new one it has to store more data because it's a blurred wallpaper.
  
  
  That makes sense to me. Thank you for answering.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze
Cc: oussemabouaneni, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Filip Fila]

filipf added a comment.


  In D18012#387471 , 
@oussemabouaneni wrote:
  
  > Hello, I am new here. But I wanted to ask something. Why does the older 
image take less space on disk than the newer one even though its resolution is 
higher?
  
  
  I believe it's because the old one has a plain color background, whereas for 
the new one it has to store more data because it's a blurred wallpaper.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze
Cc: oussemabouaneni, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Oussema Bouaneni]

oussemabouaneni added a comment.


  Hello, I am new here. But I wanted to ask something. Why does the older image 
take less space on disk than the newer one even though its resolution is higher?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze
Cc: oussemabouaneni, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The current preview of our Breeze SDDM theme is outdated. This patch adds a 
new and updated
  preview.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  new-sddm-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18012

AFFECTED FILES
  sddm-theme/preview.png

To: filipf
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16284: do not force text display for ToolButton

[Alexander Stippich]

astippich added a comment.


  friendly ping

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16284

To: astippich, mart, apol
Cc: hein, mgallien, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18006: Include only the largest size for the "Next" wallpaper

[Filip Fila]

filipf added a comment.


  And from my understanding this removes the file the SDDM theme needs so I 
created D18007  as a dependent revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze
Cc: filipf, kvermette, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18007: [SDDM theme] Use the biggest wallpaper resolution

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The SDDM theme now uses the 3200x2000
  version of the "Next" wallpaper. If that
  gets
  removed in D18006 , we need to have the 
theme
  using the 3840x2160 dimensions.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sddm-biggest-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18007

AFFECTED FILES
  sddm-theme/theme.conf.cmake

To: filipf
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18006: Include only the largest size for the "Next" wallpaper

[Filip Fila]

filipf added subscribers: kvermette, filipf.
filipf added a comment.


  I've reproduced what the issue was before. Tests done with a 1280x1024 
monitor.
  
  - **Tested on a Kubuntu 16.04 install with Plasma**
  
  Using the optimized 1280x1024 wallpaper:
  
  F6529646: Screenshot_20190106_110639.png 

  
  Using the scaled & cropped method with the 3840x2160 wallpaper:
  
  F6529644: Screenshot_20190106_110519.png 

  
  As we can see the end result is not good - the wallpaper is blurry.
  
  - **Tested on the latest Manjaro KDE stable snapshot**
  
  Using the scaled & cropped method with the 3840x2160 wallpaper:
  
  F6529655: manjaro1024p.png 
  
  The problem with blurriness is gone. We do, however, see that manual and 
automatic cropping don't have the same result.
  
  Based on this, I think it should ultimately be up to @kvermette to decide if 
the automatic scaling and cropping will do injustice to his wallpapers. If so, 
it does also represent a minus point for Plasma's default presentation.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze
Cc: filipf, kvermette, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17834: Allow the use of One-Time Password

[Jan Grulich]

jgrulich added a comment.


  It doesn't build now, can you please fix that?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D17834

To: enriquem, jgrulich
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17925: [containmentactions/switchwindow] Fix loop itteration

[Eike Hein]

hein added a comment.


  Sorry about this, thx for fixing :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17925

To: davidedmundson, #plasma, ngraham
Cc: hein, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 06 Jan 2019 07:50:00 +
 Build duration:
2 hr 3 min and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.12 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.12/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 06 Jan 2019 07:47:45 +
 Build duration:
1 hr 53 min and counting
   CONSOLE OUTPUT
  [...truncated 4598 lines...]-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/kwinscreenedges/index.cache.bz2-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/kwinscreenedges/index.docbook-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/kwintabbox/index.cache.bz2-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/kwintabbox/index.docbook-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowbehaviour/index.cache.bz2-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowbehaviour/index.docbook-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/index.cache.bz2-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/index.docbook-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/Face-smile.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/akgregator-info.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/akregator-attributes.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/akregator-fav.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/config-win-behavior.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/emacs-attribute.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/emacs-info.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/focus-stealing-pop2top-attribute.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/knotes-attribute.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/knotes-info.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-attribute-2.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-chat-attribute.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-chat-info.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kopete-info.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-detect-window.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 FreeBSDQt5.12/install-divert/home/jenkins/install-prefix/share/doc/HTML/en/kcontrol/windowspecific/kwin-kopete-rules.png-- Installing: /usr/home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 

D17975: [WIP, Notifications] Add padding to notifications

[Root]

rooty added a comment.


  @davidedmundson Is there anything I can put in the code to get the icons to 
scale properly? this is a screenshot of master (not this patch):
  
  F6529598: image.png 
  
  I've tried multiplying units.iconSizes.large by the scaling factor, and that 
works, but that's as ballpark a solution as they come...

INLINE COMMENTS

> davidedmundson wrote in NotificationItem.qml:175
> > Is there any way around this? Because if it's not 0.75 then it's shifted 
> > too far down (uneven padding)
> 
> If that's the case, adjust the other side, even adjust the window if you need 
> to.

Nate's right though, I should abandon the idea of totally even padding because 
it'll never hold up as you change fonts or scaling... then again it doesn't 
have to be perfect, right? Just close enough?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart