D18206: Improve the Look and Feel KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:beca304a1f44: Improve the Look and Feel KCM (authored by 
GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18206?vs=49321&id=49374

REVISION DETAIL
  https://phabricator.kde.org/D18206

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16658: Respect the display property of buttons

[Alexander Stippich]

astippich added a comment.


  friendly ping

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16658

To: astippich, #plasma, apol, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Nathaniel Graham]

ngraham added a comment.


  Thank you!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:ff26a13930d5: [KdePlasma-Addons/POTD/NOAA] Fixed the web 
address and fetched the picture from… (authored by tagorechandanreddy, 
committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13868?vs=37283&id=49388

REVISION DETAIL
  https://phabricator.kde.org/D13868

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Nathaniel Graham]

ngraham added a comment.


  @ tagorechandanreddy Hmm, I'm not seeing that this actually works. Console 
spew says:
  
kf5.kio.core: Invalid URL: 
QUrl("/content/three-views-winter-solstice-space")
file:///usr/share/plasma/wallpapers/org.kde.potd/contents/ui/main.qml:46: 
TypeError: Cannot read property 'Image' of undefined
  
  Is this a bug in your code, or a side effect of the U.S. government being 
shut down right now? The data source web page 
(https://www.nesdis.noaa.gov/content/imagery-and-data) says:
  
  F6547638: Screenshot_20190113_085424.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  I can confirm that it is due to current state of U.S. government.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Nathaniel Graham]

ngraham added a comment.


  Given the frequency with which it seems to be happening these days, maybe we 
should explicitly handle this case!
  
  😩

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  I'm already working on it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Tagore Chandan Reddy]

tagorechandanreddy updated this revision to Diff 49399.
tagorechandanreddy added a comment.


  Further fixes

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13868?vs=49388&id=49399

REVISION DETAIL
  https://phabricator.kde.org/D13868

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Nathaniel Graham]

ngraham added a comment.


  Please put the new stuff in another patch. I've already landed this one.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  Ok

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18232: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string of landing page

[Tagore Chandan Reddy]

tagorechandanreddy created this revision.
tagorechandanreddy added reviewers: davidedmundson, ngraham.
tagorechandanreddy added a project: Plasma.
Herald edited subscribers, added: plasma-devel; removed: Plasma.
tagorechandanreddy requested review of this revision.

REVISION SUMMARY
  'Image of the day' has a new landing page everyday. This patch fixes the 
RegEx string that fetches the web address of the landing page.

TEST PLAN
  All plugins should work as usual.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18232

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp

To: tagorechandanreddy, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18232: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string of landing page

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go, this works for me now.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18232

To: tagorechandanreddy, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18232: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string of landing page

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:5fb5ce7f9a46: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx 
string of landing page (authored by tagorechandanreddy, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18232?vs=49405&id=49407

REVISION DETAIL
  https://phabricator.kde.org/D18232

AFFECTED FILES
  dataengines/potd/noaaprovider.cpp

To: tagorechandanreddy, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham updated this revision to Diff 49408.
ngraham added a comment.


  Rebase on master and fix merge conflicts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16031?vs=46523&id=49408

BRANCH
  arcpatch-D16031

REVISION DETAIL
  https://phabricator.kde.org/D16031

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  sddm-theme/Main.qml

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, 
broulik, rikmills, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  KWorkSpace::detectPlatform among others use that, so make sure it's set.
  
  On 5.12 it has export QT_QPA_PLATFORM=wayland already, so it's not necessary 
(?).

TEST PLAN
  I had that patch applied locally for basically ever, works fine.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18233

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: fvogt, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[David Edmundson]

davidedmundson added a comment.


  The login manager should set this already

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18233

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[Fabian Vogt]

fvogt added a comment.


  > The login manager should set this already
  
  If no display manager is used it's unset, which causes weird issues.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18233

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  After much discussion in the #VDG  
room, we decided to put this on hold and revisit it for 5.16. The problem here 
is that we're worried that this change won't be enough to stop people from 
wanting to redesign it yet again, and we don't want to produce change fatigue 
here. We're going to focus on producing a timeless design that's good enough 
that nobody wants to redesign it anymore, which is ultimately the best sign 
that you have the design right.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, 
broulik, rikmills, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Root]

rooty added a comment.


  In D16031#392659 , @ngraham wrote:
  
  > After much discussion in the #VDG  
room, we decided to put this on hold and revisit it for 5.16. The problem here 
is that we're worried that this change won't be enough to stop people from 
wanting to redesign it yet again, and we don't want to produce change fatigue 
here. We're going to focus on producing a timeless design that's good enough 
that nobody wants to redesign it anymore, which is ultimately the best sign 
that you have the design right.
  
  
  agreed
  
  by the way, we might get an idea by/from revisiting old plasma themes too
  
  F6548022: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, 
broulik, rikmills, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:65e3cc3a58ce: Set XDG_SESSION_TYPE=wayland in 
startplasmacompositor (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18233?vs=49409&id=49414

REVISION DETAIL
  https://phabricator.kde.org/D18233

AFFECTED FILES
  startkde/startplasmacompositor.cmake

To: fvogt, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[Vlad Zagorodniy]

zzag added a comment.


  We should probably update https://community.kde.org/KWin/Wayland as well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18233

To: fvogt, #plasma, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[Fabian Vogt]

fvogt added a comment.


  In D18233#392685 , @zzag wrote:
  
  > We should probably update https://community.kde.org/KWin/Wayland as well.
  
  
  I updated the tty section now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18233

To: fvogt, #plasma, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor

[Vlad Zagorodniy]

zzag added a comment.


  In D18233#392688 , @fvogt wrote:
  
  > I updated the tty section now.
  
  
  Cool! Thanks. :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18233

To: fvogt, #plasma, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Yes, I think the old Plasma theme was great. It was changed as part of the 
"Boot to Shutdown" initiative (T2062 ) which 
in retrospect must be counted as a failure. It turned out to be not 
implementable according to the original design due to technical impediments, 
and what resulted from the effort anyway did not prove popular with users. 
We've been sort of incrementally reverting parts of it over the past year or 
so, but without any specific design in mind.
  
  I think that's why this particular design never seemed to come together. With 
the original design, the elements all float above a blue background. But the 
blue background was ugly and unpopular and people replaced it with wallpaper. 
This looked pretty but introduced contrast problems. So we put the wallpaper 
there by default and blurred it to ensure contrast, but that defeated the 
purpose of adding the wallpaper since you couldn't actually see it! So now we 
get user complaints that they can't see the wallpaper on the lock screen and 
that it looks like a dark muddy mess. In this patch I removed the blur and 
tried to solve the contrast problems with a combination of drop shadows, new 
icons with built-in backgrounds, and a bottom bar, but the result never felt 
cohesive and our designers kept trying to redesign it over and over again--a 
sign that it still wasn't right. It started to feel like a game of whack-a-mole.
  
  The root of the problem is that with this basic design, all the different 
elements want to hover over the background, unconstrained by a box or frame. 
This requires tight control over the background which in practice doesn't work 
since it's user-customizable and limits our own design choices (e.g. we could 
never use a light-colored wallpaper since then the text and icons would be 
illegible).
  
  What I think we need to is come up with a new design that accommodates 
arbitrary backgrounds from the start, probably by putting all the UI elements 
in some kind of box, like the Plasma ≤ 5.7 theme, Elarun theme, Maldives theme, 
etc. And most importantly, they should feel //good// in a box or frame. it 
shouldn't feel like they're uncomfortable together, like they want to escape.
  
  There's no time left for 5.15; let's give it a shot in 5.16 timeframe, with 
an eye towards producing something timeless that does not work against itself. 
Only then will our users feel satisfied and our designers will stop trying to 
redesign it. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, 
broulik, rikmills, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:235fa8107dab: [Digital Clock] Add ability to set a custom 
date format string (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18019?vs=49332&id=49421

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma, #vdg
Cc: karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, 
rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol