D18443: Load Plasma QtQuick settings in KCMShell

2019-01-21 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  BUG: 403314
  FIXED-IN: 5.15.0

TEST PLAN
  Clone of code used in systemsettings etc.
  Compiles

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18443

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D15684: DateTime Runner timezone and 24 hour clock time conversion.

2019-01-21 Thread James Smith
smithjd added a comment.


  Timezone name expansion and multiple matches:
  F6561200: Screenshot_20190121_164314.png 

  
  24-hr conversion and multiple matches:
  F6561199: Screenshot_20190121_164852.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15684

To: smithjd, #plasma, mart
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18318: Prettify and search enable the error page

2019-01-21 Thread Nathaniel Graham
ngraham added a comment.


  Nice! Now the icon is still too big, especially with color. For these error 
pages, can we experiment with using a smaller size? I bet half as big would 
look good. Now that I thin of it, the icon should probably go above the text, 
too.
  
  If the goal was to use the same size as the icon on the update page, well 
pretty soon I want to replace that with a smaller spinner. :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18318

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18441: [Desktop theme KCM] Use new icon

2019-01-21 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Icon was just introduced with D18433 . 
The new icon's name is such that the fallback icon will be 
`preferences-desktop-plasma`, which is already present in 3rd-party icon 
themes, so nothing will get broken.

TEST PLAN
  F6561083: New plasma theme icon 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-new-plasma-desktop-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18441

AFFECTED FILES
  kcms/desktoptheme/kcm_desktoptheme.desktop

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18438: [Task Manager] When closing apps, resize only when mouse is out.

2019-01-21 Thread Thomas Surrel
thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When closing several apps from the task manager with the mouse
  middle button, it is convenient that the remaining tasks are not
  resized so that you don't need to move your mouse to target the
  next app you intend to close.
  This mimics the behavior of tabs in Firefox or Chrome.

TEST PLAN
  With the task manager configured without grouping, open several
  applications so that the tasks displayed in the task manager get
  smaller to fit in the available space. Now close the last three
  for example: you should be able to do so without having to move
  your mouse.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

AFFECTED FILES
  applets/taskmanager/package/contents/ui/main.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


Re: Issue with Discover on the Plasma/5.14 branch

2019-01-21 Thread David Edmundson
Presumably also requires 4b6420596ca6a557591c24184a57b7985c77984e and more
importantly e8e3160cd20c11090572bd66337b41d9567bf461 from KNS which is a
whole new error reporting API with the error codes which you'd need

As it's new API any backported fix would need all that to be #ifdef'd, and
you'd still need the old code in a #else.
Do-able, but not as trivial as simply backporting something.

Given it's been broken forever, but gut reaction is that this is messy
enough to not be worth the risk of making things worse.
Or if you want a cheap hack, it might be worth looking at changing KNS's
legacy signal to emit Provider::signalError(""All categories are missing")
for network errors.

David


D18419: Adjust some KCMs to implement new Appearance section layout

2019-01-21 Thread Nathaniel Graham
ngraham added a comment.


  I'm trying to get a sense of when we should do this.
  
  1. Improve text on existing QWidgets KCMs to conform to the HIG
  2. Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG
  3. Port all QWidgets KCMs to QML
  4. Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and 
GNOME Applications Style (GTK))
  
  Between which items should this re-org be located?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


Issue with Discover on the Plasma/5.14 branch

2019-01-21 Thread Nate Graham

Hello folks,
We have a non-ideal situation with Discover. Its package update 
functionality is broken for many users of Plasma 5.14 due to 
https://bugs.kde.org/show_bug.cgi?id=399981.


The fix requires:
- Frameworks 5.54 for 
https://cgit.kde.org/attica.git/commit/?id=4c53ebade05a3961abb0c70549870ba749d90692
- Plasma 5.15 for 
https://cgit.kde.org/discover.git/commit/?id=7f6caf385809ce8c8087d8e56e9f3c6bd8c9170a


Unfortunately, because there are no more 5.14 bugfix releases scheduled, 
Plasma 5.14 users would be out of luck even if we could backport a 
version of that fix that didn't have any string changes.


Ideas regarding how to proceed? If we prepare a targeted 
string-change-less fix for 5.14.x, could we re-spin the tars for 
Discover to include it?



Nate



D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time

2019-01-21 Thread Enrique Melendez
enriquem created this revision.
enriquem added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
enriquem requested review of this revision.

REVISION SUMMARY
  The way an invalid certificate fingerprint is saved in the [vpn-secrets] 
section does not work. It is unconditionally saved with a key 
certificate:[host]:[port] when the users accepts the invalid certificate, and 
is never retrieved so that the user has to accept the certificate again next 
time.
  
  So, I have changed that behavior to save the fingerprint with a different 
key, and give the user the chance to accept the fingerprint only for the 
current connection, to accept it forever, and to delete it from the config 
file. And make it work properly, that is, once accepted, the user is never 
asked again.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18437

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/nm-openconnect-service.h
  vpn/openconnect/openconnectadvanced.ui
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/openconnectwidget.h

To: enriquem, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fc2d0c4f56eb: Handle ShutdowntypeDefault in KSMserver 
legacy code (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18435?vs=50017&id=50020

REVISION DETAIL
  https://phabricator.kde.org/D18435

AFFECTED FILES
  ksmserver/logout.cpp

To: davidedmundson, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread David Edmundson
davidedmundson added a comment.


  > This should go into 5.15, right?
  
  Yep.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18435

To: davidedmundson, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread Nathaniel Graham
ngraham added a comment.


  This should go into 5.15, right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18435

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In the ksmserver porting most code was moved to explicitly calling
  logout or shutdown methods rather than a random enum.
  
  A legacy code path remained for compatibility. This path is used by the
  containmentactions, in the refactor handling of
  KWorkspace::ShutdownTypeDefault was lost.
  
  BUG: 403466

TEST PLAN
  Set different default modes
  Logged out using containment actions

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18435

AFFECTED FILES
  ksmserver/logout.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-01-21 Thread Nathaniel Graham
ngraham added a comment.


  I tried to test this out, but it doesn't apply to master anymore. Applying 
and then rebasing on master results in a ton of merge conflicts. :(
  
  Is there any movement on this? It would be a real shame to let such a huge 
amount of valuable work rot away. Even just rebasing it on current master would 
be helpful since then people could test it out without having to roll back to 
Plasma 5.13. @gpark, are you around to continue this work?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: lavender, ngraham, apol, plasma-devel, hein, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


D15684: DateTime Runner timezone and 24 hour clock time conversion.

2019-01-21 Thread Nathaniel Graham
ngraham added a comment.


  Some screenshots would be helpful here.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15684

To: smithjd, #plasma, mart
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18321: support for the concept of expandible items

2019-01-21 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2e7602f3fa5f: support for the concept of expandible items 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18321?vs=49721&id=49998#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18321?vs=49721&id=49998

REVISION DETAIL
  https://phabricator.kde.org/D18321

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ContextDrawerActionItem.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami
Cc: alex-l, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D18430: [DesktopView] Don't set a window icon

2019-01-21 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The desktop view isn't visible in the task bar, tabbox, and neither does it 
have a window decoration.

TEST PLAN
  Saves some RAM and startup time.
  
QWindow::setIcon` in this case was 1.63% on startup, mostly caused by icon 
theme setup stuff, so the impact isn't as noticeable overall.
Verified in xprop that the icon was gone.
Plasma popups that show up in tabbox are unaffected and still have an icon.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18430

AFFECTED FILES
  shell/desktopview.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17217: Implement free memory notifier

2019-01-21 Thread Oleg Solovyov
McPain added a comment.


  In D17217#378768 , @davidedmundson 
wrote:
  
  > > Thanks. Any examples in KDE? I can't implement this from scratch right 
now.
  >
  > There is not, it would requires writing new C code.
  >  It's something I can help with.
  
  
  What/where I can start with?

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart


D18428: actually remove unused ksnrc file

2019-01-21 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:f43864feb2d0: actually remove unused ksnrc file (authored 
by sitter).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18428?vs=49989&id=49990

REVISION DETAIL
  https://phabricator.kde.org/D18428

AFFECTED FILES
  cgcicon.knsrc

To: sitter, apol, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18428: actually remove unused ksnrc file

2019-01-21 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this file is not getting installed for years. it was dropped in
  836486fbfd3f8256e9749c15d0874a9a780a0471 
 but 
unfortunately that commit
  neglected to also drop the file from git.
  in order to resolve this dissonance between git and install -> delete it
  (it's still in the history anyway, should we need to recover it at some
   point)

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18428

AFFECTED FILES
  cgcicon.knsrc

To: sitter, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18318: Prettify and search enable the error page

2019-01-21 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 49984.
leinir added a comment.


  Changes as discussed: The component is now all nice and centered, and the 
icon is fully opaque. Yup, much prettier all 'round, and would be nice and easy 
to turn into a full-on component :)
  F6559581: image.png 

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18318?vs=49718&id=49984

REVISION DETAIL
  https://phabricator.kde.org/D18318

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


Monday meeting minutes for 2019-01-21 (week 4)

2019-01-21 Thread Kai Uwe Broulik

Hi all,

this week's meeting minutes for Plasma:

notmart
===
* fixed loading of default iconset&window deco from lnf package
* (5.16) systemsettings sidebar icons are now 32 px with less margin, as 
agreed with VDG


d_ed

* fixed a kscreen-kwin crash
* Back on some wayland work:
* added support for the keep on top "pin" that we see in system tray / 
calendar

* along with the usual bugfixes
* going to try and spend today investigating Bug 353983 (Turning off 
compositing breaks Plasma panel rendering)


romangg
===
* Will push my Xwl DND patch series this week to master.
* Working on an idea to fix Xwl Multi DPI.
** For example: Bug 389191 (xwayland auto-upscaling causes pixelation 
and should be optional)

** The Xwl Multi DPI is code in KWin and Xwl
* Working on a rewrite of the Wayland platform plugin in terms of 
AbstractOutput


kbroulik


Work done:
* Some overall optimizations:
** Some connect syntax porting
** Plasma::Theme instances are shared between (often-created) ColorScope 
objects
*** Plasma::Svg also creates its own instance of default theme but there 
it's more complicated as:
*** can be either default theme or custom theme, not sure about proper 
use of refcounting/QShared stuff there
* Lock screen doesn't break (lock out user) if HOME ends up unwritable 
(config file locked)


Work todo:
* Continue on notifications rewrite
* Overall 5.15 Beta bug fixing

Other:
* Plasma-browser-integration for Chrome has hit 40,000 users \o/


Cheers
Kai Uwe
[12:02:24]  meeting?
[12:03:05]  notmart: d_ed Sho_ romangg fvogt jgrulich
[12:04:54]  here
[12:05:31]  here
[12:06:00]  alright, notmart go
[12:06:58]  really few things in plasma this week
[12:07:01]  * fixed loading of default iconset&window deco from lnf package
[12:07:02]  * (5.16) systemsettings sidebar icons are now 32 px with less margin, as agreed with VDG
[12:07:24]  that's pretty much it :(
[12:07:24]  ah, that explains why they're gigantic now
[12:07:34]  hi
[12:07:49]  kbroulik: yeah, vdg really wanted them like that very much
[12:07:52]  :/
[12:07:55]  (until next time i guess :p)
[12:08:04]  alright, d_ed next
[12:08:33]  Back on some wayland work
[12:08:58]  fixed a kscreen-kwin crash
[12:09:15]  added support for the keep on top "pin" that we see in system tray / calendar
[12:09:26]  along with the usual bugfixes
[12:10:03]  ok, romangg
[12:10:09]  going to try and spend today investigating 353983
[12:10:19]  as I have some new hardware and a possible idea
[12:10:29]  (sorry, done now, I had to pause to look up the number)
[12:10:33]  cool!
[12:10:49]  * Will push my Xwl DND patch series this week to master.
[12:10:59]  * Working on an idea to fix Xwl Multi DPI.
[12:11:12]  (for example: https://bugs.kde.org/show_bug.cgi?id=389191)
[12:11:12]  KDE bug 389191 in kwin (wayland-generic) "xwayland auto-upscaling causes pixelation and should be optional" [wishlist,WONTFIX] https://bugs.kde.org/show_bug.cgi?id=389191
[12:11:33]  * Working on a rewrite of the Wayland platform plugin in terms of AbstractOutput
[12:11:50]  The Xwl Multi DPI is code in KWin and Xwl
[12:12:08]  questions?
[12:12:22]  cool
[12:12:26]  anyone else wants to chime in?
[12:12:51]  alright I'll wrap up then, this was a quick one
[12:12:56]  Work done:
[12:12:56]  - Some overall optimizations:
[12:12:56]  -- Some connect syntax porting
[12:12:56]  -- Plasma::Theme instances are shared between (often-created) ColorScope objects
[12:12:56]  --- Plasma::Svg also creates its own instance of default theme but there it's more complicated as:
[12:12:56]  --- can be either default theme or custom theme, not sure about proper use of refcounting/QShared stuff there
[12:13:01]  - Lock screen doesn't break (lock out user) if HOME ends up unwritable (config file locked)
[12:13:01]  -- Candidate for 5.12? D18291
[12:13:05]  - Plasma-browser-integration for Chrome has hit 40,000 users \o/
[12:13:07]  Diff 18291 "[Greeter] Ignore unwritable configuration files" [Closed] https://phabricator.kde.org/D18291
[12:13:08]  Work todo:
[12:13:08]  - Continue on notifications rewrite
[12:13:08]  - Overall 5.15 Beta bug fixing
[12:14:29]  alright, done, thanks everyone


D18318: Prettify and search enable the error page

2019-01-21 Thread Dan Leinir Turthra Jensen
leinir added a comment.


  In D18318#395986 , @ngraham wrote:
  
  > +1 for always showing the search field. But that icon looks a bit big. I 
might make it smaller and lose the opacity.
  >
  > Also, while we're prettifying the error page, how about vertically 
centering everything too?
  
  
  The icon is exactly the same size as the one on the Updates page, literally 
copied the code across (which suggests to me we might want to create a 
component for this sort of thing perhaps...). But, that is not to say that it 
wouldn't make sense to make it smaller and have it be entirely opaque. 
Optimally, i can see it being handy to have a component that just has a string 
and an icon, which is then centred in the container, and which we could then 
use in both these places (and anywhere else it turns out we need to tell the 
user something of a similar nature). ...which, i realise rereading your second 
line is not unlike what you are suggesting ;) i'll try and come up with 
something that pleasantly does that, stay tuned to this channel ;)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18318

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18419: Adjust some KCMs to implement new Appearance section layout

2019-01-21 Thread David Edmundson
davidedmundson added a comment.


  To clarify one thing, I didn't say "porting". The original task was to go 
through all of them unifying them, rethinking design and following Fabian's new 
HIG as well as making sure all options are in the right place, etc.. I 
personally don't particularly care too much which tech is used.
  
  From that POV there are waay more changes this release, especially Björn's 
work with the title casing.
  
  It seems like it'll require enormous amounts of work because enormous amounts 
of work are the only thing that will deliver anything with any substance.
  
  > I don't see what harm it does to implement the parts of this re-organization
  
  It breaks existing user habits as well as breaking every 
manual/documentation/help post on the internet.
  Obviously that has to happen occasionally, but it's not a move to be done 
lightly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart