D18597: Fix combobox initial sizing

2019-01-29 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:152bb7363a80: Fix combobox initial sizing (authored by 
davidedmundson).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18597?vs=50488=50540

REVISION DETAIL
  https://phabricator.kde.org/D18597

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson, #plasma, mart, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

2019-01-29 Thread Nathaniel Graham 
ngraham added a comment.


  In D18607#402168 , @vpilo wrote:
  
  > Better just place it at the top above the the connections list, then?
  
  
  I think that would make sense.
  
  In such a limited space, I think it's fine for the search field to only 
appear if the list would otherwise be scrollable.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

2019-01-29 Thread Valerio Pilo 
vpilo added a comment.


  Better just place it at the top above the the connections list, then?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

2019-01-29 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in appletproxymodel.cpp:60
> what happens if you have a filter and the the entry is a slave?

Edit: ignore this.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

2019-01-29 Thread David Edmundson 
davidedmundson added a comment.


  Seems niche, but this solution is also unobtrusive, so I like that. I have a 
lot of VPNs searching through them would be quite useful.
  
  Having the search bar on the bottom is a bit weird as when you filter the 
results will be at the top, meaning the user's focus is split all over the 
place.

INLINE COMMENTS

> PopupDialog.qml:81
> +
> +onContentHeightChanged: isConnectionsListLong = height < 
> contentHeight
> +}

The connection view changes height depending on the presence of a search bar
The search bar becomes visible depending on the height of the listview

I would expect that to be giving binding loops when you're on the edge.

> appletproxymodel.cpp:60
> +if (filterRegExp().isEmpty()) {
>  return true;
>  }

what happens if you have a filter and the the entry is a slave?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

2019-01-29 Thread Valerio Pilo 
vpilo created this revision.
vpilo added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  If there are not enough connections to fill the scrollview, the search bar is 
not displayed by default.
  If there are, the search bar is shown.
  Regardless of that, starting typing will filter the connections list and show 
the search bar.
  
  I'm uncertain whether not hiding it by default would be a good idea, 
usability wise.
  
  BUG: 344789
  BUG: 394290

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein added a comment.


  Sorry for the noise. Please review again (I'm off till tomorrow).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18598

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein updated this revision to Diff 50509.
hein added a comment.


  Revert an unintended change, fixes positionertest

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18598?vs=50506=50509

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18598

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein updated this revision to Diff 50506.
hein added a comment.


  Add missing include

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18598?vs=50502=50506

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18598

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein updated this revision to Diff 50502.
hein added a comment.


  Signal-slot hygiene

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18598?vs=50498=50502

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18598

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein updated this revision to Diff 50498.
hein added a comment.


  Reorder abort checks and unset m_deferApplyPositions if going for a reset

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18598?vs=50490=50498

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18598

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein added a comment.


  In D18598#401848 , @davidedmundson 
wrote:
  
  > If the QML code calls setPositions({})  and when we apply 
m_positions.size() < 5
  >  m_deferApplyPositions gets left on true forever.  Is that ok?
  
  
  It's not, good catch. Updating in a sec.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18598

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread David Edmundson 
davidedmundson added a comment.


  If the QML code calls setPositions({})  and when we apply m_positions.size() 
< 5
  m_deferApplyPositions gets left on true forever.  Is that ok?
  
  Other than that, looks good.

INLINE COMMENTS

> positioner.cpp:82
>  if (m_folderModel) {
>  disconnectSignals(m_folderModel);
>  }

you're not disconnecting newly added connections

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18598

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18578: Reduce string objects

2019-01-29 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks okay from a theoretical point of view, I can expect the practical 
impact of this be about 0~ :P

REPOSITORY
  R106 KSysguard

BRANCH
  reduceStrings

REVISION DETAIL
  https://phabricator.kde.org/D18578

To: tcanabrava, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18576: Simpe C updates to ksysguardd code

2019-01-29 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM +1

REPOSITORY
  R106 KSysguard

BRANCH
  simplify_c_code

REVISION DETAIL
  https://phabricator.kde.org/D18576

To: tcanabrava, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18598: Defer initial positions apply until listing is complete

2019-01-29 Thread Eike Hein 
hein created this revision.
hein added reviewers: Plasma, davidedmundson, chinmoyr.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This fixes the infamous "desktop positions partially scramble on reboot"
  bug that occurs when KDirLister completes listing in multiple model
  transactions.
  
  This also:
  
  - Disallows moves and drops while listing, for extra safety.
  - Cleans up wonky old defer-sometimes code that made little sense.
  - Removes a cache for lastRow() that was never actually used.
  
  BUG:354802

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18598

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18596: Set combobox popups to be modal

2019-01-29 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:0ac99af6e691: Set combobox popups to be modal (authored 
by davidedmundson).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18596?vs=50483=50489

REVISION DETAIL
  https://phabricator.kde.org/D18596

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18597: Fix combobox initial sizing

2019-01-29 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We have a listview in a popup. The popup is resized to the listview
  content height.
  
  Because the popup starts out at size 0 the listview thinks it's too
  small to show anything.
  
  So it doesn't load any delegates.
  
  As it has no delegates it can't guess the contentHeight.
  contentHeight is a guess based on count * (currentHeight
  / currentlyLoadedDelegates)
  
  That means the popup doesn't resize properly.
  
  Ultimately it does end up showing a two entries, but it doesn't
  re-evaluate the contentHeight properly to resize the popup correctly.
  
  Forcing it to load one delegate is enough to break that cycle.
  
  BUG: 403736

TEST PLAN
  Opened popup in cursortheme and fonts
  Worked correctly

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18597

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18596: Set combobox popups to be modal

2019-01-29 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This closer matches what we see on QWidgets where losing focus closes
  the combobox.
  
  BUG: 403403

TEST PLAN
  Opened a combobox
  Clicked outside
  It closed

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18596

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18588: Configuration to never show the passwors dialog

2019-01-29 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1d7841399924: Configuration to never show the passwors 
dialog (authored by mart).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18588?vs=50468=50469

REVISION DETAIL
  https://phabricator.kde.org/D18588

AFFECTED FILES
  kded/secretagent.cpp
  libs/configuration.cpp
  libs/configuration.h

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18588: Configuration to never show the passwors dialog

2019-01-29 Thread Marco Martin 
mart updated this revision to Diff 50468.
mart added a comment.


  - return true

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18588?vs=50466=50468

BRANCH
  arcpatch-D18588

REVISION DETAIL
  https://phabricator.kde.org/D18588

AFFECTED FILES
  kded/secretagent.cpp
  libs/configuration.cpp
  libs/configuration.h

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18588: Configuration to never show the passwors dialog

2019-01-29 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  on Plasma mobile, not qwidget dialogs should be ever shown at any time.
  the networkmanager KCM includes its own password field, so the password 
dialog can be safely
  be never shown

TEST PLAN
  fails silently

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  phab/passwordDialog

REVISION DETAIL
  https://phabricator.kde.org/D18588

AFFECTED FILES
  kded/secretagent.cpp
  libs/configuration.cpp
  libs/configuration.h

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18580: Accept commas to separate processes on the Search Edit

2019-01-29 Thread Tomaz Canabrava 
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:f5dcd02c52fd: Accept commas to separate processes on the 
Search Edit (authored by tcanabrava).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18580?vs=50463=50464

REVISION DETAIL
  https://phabricator.kde.org/D18580

AFFECTED FILES
  processui/ProcessFilter.cpp

To: tcanabrava, ngraham
Cc: rizzitello, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18580: Accept commas to separate processes on the Search Edit

2019-01-29 Thread Tomaz Canabrava 
tcanabrava updated this revision to Diff 50463.
tcanabrava added a comment.


  - Accept commas for PID

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18580?vs=50426=50463

BRANCH
  acceptCommasSearch

REVISION DETAIL
  https://phabricator.kde.org/D18580

AFFECTED FILES
  processui/ProcessFilter.cpp

To: tcanabrava, ngraham
Cc: rizzitello, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Fixed!

2019-01-29 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 29 Jan 2019 07:39:23 +
 Build duration:
35 min and counting