D15304: [KCM] Port to QQC2

[David Rosca]

drosca accepted this revision.
drosca added a comment.


  Looks good now!

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D18976: Improve Contextmenu

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> menu.cpp:85
> +m_configureAction->setVisible(!configuring);
> +});
> +

this bracket ident needs to be like the one from m_addWidgetsAction

> menu.cpp:138
>  
> +m_configureAction->setText(i18nc("view settings window", viewType == 
> Latte::Types::DockView ? "Dock &Settings..." : "Panel &Settings..."));
> +

including this like this I think it will faile gettest or return false results 
for translation strings, a clean approach can be:

  QString settingsStr = ( viewType == Latte::Types::DockView ? i18nc("dock 
settings window", "Dock &Settings...") : i18nc("panel settings window, "Panel 
&Settings") );
  
  m_configureAction->setText(settingsStr);

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18976

To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> main.qml:78
> +function wifiScan() {
> +handler.requestScan()
>  }

Since this is just one line function, you can use handler.requestScan() 
directly as before.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18867: Remove redundant DNS field

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:29b6d0ee5900: Remove redundant DNS field (authored by 
andersonbruce, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18867?vs=51235&id=51570

REVISION DETAIL
  https://phabricator.kde.org/D18867

AFFECTED FILES
  libs/editor/connectioneditorbase.cpp
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich
Cc: ngraham, lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kmenuedit.cpp:137
> +m_searchLine = new KTreeWidgetSearchLine(this, m_tree);
> +m_searchLine->setCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive);
> +m_searchLine->setKeepParentsVisible(true);

you can use directly Qt::CaseInsensitive

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi added a comment.


  Yes, that's exactly what I'm doing. QFrame works fine for doing the same 
thing with the added benefit of easier styling around the edges. But if you 
*really want* I can switch it to a blank QWidget... it makes absolutely no 
difference though.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added a comment.


  If the reason why you're creating a `QFrame` is because `QSplitter` doesn't 
accept a layout, you can just give it a blank `QWidget` and assign the widget 
your layout. See https://stackoverflow.com/a/53384177/2934226

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi updated this revision to Diff 51565.
tuxxi added a comment.


  - Fix padding issues

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18939?vs=51562&id=51565

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

AFFECTED FILES
  kmenuedit.cpp
  kmenuedit.h
  treeview.cpp
  treeview.h

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Actually looking one more time I see a visual issue introduced by this patch: 
by putting the search field and list inside a frame, they both have bigger 
margins than the tabbed view to the right, so they don't line up anymore:
  
  F6612255: Screenshot_20190212_195729.png 

  F6612252: Screenshot_20190212_195346.png 

  
  Let's revert the `treeFrame` part, which should fix this.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent. UX and code look good to me now. @cfeck, or #plasma 
 folks, any comments or shall we land 
this?
  
  BTW @tuxxi you'll need to fix your git authorship information to use your 
full name. If I try to land this now, the commit hookscript will complain that 
`tuxxi ` isn't valis because the name part doesn't 
have a last name. Assuming your email address reveals your real name, I can fix 
this up for you before it lands, but it would be nice not to have to in the 
future, ya know? :-)
  
  See https://community.kde.org/Get_Involved/development#Configure_Git

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18976: Improve Contextmenu

[Tranter Madi]

trmdi created this revision.
trmdi added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - Display Dock Settings/Panel Settings instead of View Settings
  - Hide View Settings when configuring

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18976

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: trmdi, #latte_dock
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi added inline comments.

INLINE COMMENTS

> ngraham wrote in kmenuedit.cpp:143
> If there's nothing specifically in the style guidelines about it, it's best 
> to follow the existing coding style. Nothing else here uses `auto` with `new` 
> constructors, so we should follow the same style for new code.
> 
> KDE software is multi-generational and it's important that each individual 
> developer not use their own personal preferred style instead of following the 
> existing style because that leads to the whole codebase becoming an 
> inconsistent mess over time. Cleanup can be desirable, but that should happen 
> separately, in its own patch, so it can be discussed on its own merits.

Okay, makes sense. I'll try to be more atomic :)

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi updated this revision to Diff 51562.
tuxxi marked 8 inline comments as done.
tuxxi added a comment.


  - resolve (hopefully) final nitpicks

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18939?vs=51561&id=51562

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

AFFECTED FILES
  kmenuedit.cpp
  kmenuedit.h
  treeview.cpp
  treeview.h

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> tuxxi wrote in kmenuedit.cpp:30
> IMHO it looks cleaner to separate includes into categories, which is what I 
> did here.

It surely is, but that's not related to this patch. In KDE, we try to make our 
commits as atomic as possible, and do clean-up like this separately.

> tuxxi wrote in kmenuedit.cpp:141
> I copied the tooltip text from KOpenWithDialog, but I'll change this one. 
> Perhaps we can change it as well

Yep, sounds like we should change it it there too! A good second patch. :)

> tuxxi wrote in kmenuedit.cpp:143
> I'm using `auto` to avoid duplicating the type name when using `new` since 
> the type is right there; its a habit I got into since clang-tidy recommends 
> it. I couldn't find anything in the style guides prohibiting this. If you 
> _really_ want, I can stop using `auto`.

If there's nothing specifically in the style guidelines about it, it's best to 
follow the existing coding style. Nothing else here uses `auto` with `new` 
constructors, so we should follow the same style for new code.

KDE software is multi-generational and it's important that each individual 
developer not use their own personal preferred style instead of following the 
existing style because that leads to the whole codebase becoming an 
inconsistent mess over time. Cleanup can be desirable, but that should happen 
separately, in its own patch, so it can be discussed on its own merits.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi added inline comments.

INLINE COMMENTS

> ngraham wrote in kmenuedit.cpp:30
> Unrelated change.

IMHO it looks cleaner to separate includes into categories, which is what I did 
here.

> ngraham wrote in kmenuedit.cpp:141
> Since the placeholder text says "Search..." we should probably not use the 
> word "Filter" in the tooltip. Also "Type to" isa not really necessary since 
> that's the only thing you can do with a search field. :)
> 
> How about something like "Search through the list of applications below"?

I copied the tooltip text from KOpenWithDialog, but I'll change this one. 
Perhaps we can change it as well

> ngraham wrote in kmenuedit.cpp:143
> No need to use `auto` here

I'm using `auto` to avoid duplicating the type name when using `new` since the 
type is right there; its a habit I got into since clang-tidy recommends it. I 
couldn't find anything in the style guides prohibiting this. If you _really_ 
want, I can stop using `auto`.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi updated this revision to Diff 51561.
tuxxi marked 5 inline comments as done.
tuxxi added a comment.


  Fix various nitpicks

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18939?vs=51545&id=51561

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

AFFECTED FILES
  kmenuedit.cpp
  kmenuedit.h
  treeview.cpp
  treeview.h

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18975: [PotD] Port mostly to QQC2

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson, kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Port the Config UI mostly to QQC2, with the exception of the ComboBox,
  which still suffers from a visual bug (see the inline comment in the code)
  
  This also has the side effect of working around
  https://bugreports.qt.io/browse/QTBUG-70481 and improving the presentation
  for people using fractional Qt scale factors.
  
  BUG:
  FIXED-IN: 5.15.1

TEST PLAN
  No change at 1x scale. Looks better at 1.2x scale: F6612028: 1.2x scale 


REPOSITORY
  R114 Plasma Addons

BRANCH
  port-potd-to-qqc2 (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18975

AFFECTED FILES
  wallpapers/potd/contents/ui/config.qml

To: ngraham, #plasma, davidedmundson, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port to QQC2

[Nathaniel Graham]

ngraham marked 2 inline comments as done.
ngraham added a comment.


  OK, I think this is finally ready to land. No more hacks. @drosca and/or 
@davidedmundson, could you confirm?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D15304: [KCM] Port to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 51557.
ngraham added a comment.


  Remove more hacks and now-unnecessary changes

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=51556&id=51557

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D15304: [KCM] Port to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 51556.
ngraham added a comment.


  Remove all the hacks and do this right, once and for all

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=50385&id=51556

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added a comment.


  Thanks! The UI and behavior are now good. Code looks pretty sane too, just a 
few style nitpicks:

INLINE COMMENTS

> kmenuedit.cpp:30
>  #include 
> +
>  #include 

Unrelated change.

> kmenuedit.cpp:141
> +m_searchLine->setPlaceholderText(i18n("Search..."));
> +m_searchLine->setToolTip(i18n("Type to filter applications below"));
> +

Since the placeholder text says "Search..." we should probably not use the word 
"Filter" in the tooltip. Also "Type to" isa not really necessary since that's 
the only thing you can do with a search field. :)

How about something like "Search through the list of applications below"?

> kmenuedit.cpp:143
> +
> +auto treeLayout = new QVBoxLayout;
> +treeLayout->addWidget(m_searchLine);

No need to use `auto` here

> kmenuedit.cpp:146
> +treeLayout->addWidget(m_tree);
> +auto treeFrame = new QFrame;
> +treeFrame->setLayout(treeLayout);

No need to use `auto` here

> kmenuedit.cpp:157
>  
> +
>  connect(m_tree, SIGNAL(entrySelected(MenuFolderInfo*)),

Unrelated change

> treeview.cpp:1922
> +/*
> + * Workaround to set expansion of categories when search updates
> + */

I'm not sure this is actually working around anything; it's just a nice UI 
behavior! :)

> treeview.h:208
>  
> +
>  protected:

Unrelated change

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16658: Respect the display property of buttons

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:974efd584666: Respect the display property of buttons 
(authored by astippich).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16658?vs=48917&id=51546

REVISION DETAIL
  https://phabricator.kde.org/D16658

AFFECTED FILES
  org.kde.desktop/Button.qml

To: astippich, #plasma, apol, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi updated this revision to Diff 51545.
tuxxi marked an inline comment as done.
tuxxi added a comment.


  - search -> search...

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18939?vs=51540&id=51545

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

AFFECTED FILES
  kmenuedit.cpp
  kmenuedit.h
  treeview.cpp
  treeview.h

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:502b963bcc96: UpdatesPage: Fix icon sizing on small 
screens (authored by jbbgameich, committed by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18964?vs=51526&id=51544

REVISION DETAIL
  https://phabricator.kde.org/D18964

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Nathaniel Graham]

ngraham added a comment.


  Sure, I'll do it this time. The documentation for using `arc` is really quite 
good though: https://community.kde.org/Infrastructure/Phabricator

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Jonah Brüchert]

jbbgameich added a comment.


  I'm sorry, I'm not yet used to the Phabricator workflow. My attempt to 
convert this revision into a proper arc diff I can land failed, since this was 
initially created by pasting `git diff` output. If possible, can you land the 
patch?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18971: UpdatesPage: Fix icon sizing on small screens

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  On Small screens (e.g phones), not all list items have the same height, for 
example when a package has a long version string.
  Since the width of the icon was previously copied from the height, this 
resulted in inconsistent icon sizes.
  
  This patch sets the icon size to a constant value, which fixes the problem.
  
  BUG: 404070

TEST PLAN
  Icon sizes are consistent and still correctly sized

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18971

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added a comment.


  Thanks. :)
  
  You can also click on the "Resolved" checkboxes for inline comments and then 
click the Submit button on the bottom of the page once those issues are taken 
care of.

INLINE COMMENTS

> kmenuedit.cpp:140
> +m_searchLine->setKeepParentsVisible(true);
> +m_searchLine->setPlaceholderText(i18n("Search"));
> +m_searchLine->setToolTip(i18n("Type to filter applications below"));

Close! It needs ellipses ("Search...")

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi updated this revision to Diff 51540.
tuxxi added a comment.


  - Removed `.gitignore` changes
  - Switch label to placeholder text

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18939?vs=51468&id=51540

REVISION DETAIL
  https://phabricator.kde.org/D18939

AFFECTED FILES
  kmenuedit.cpp
  kmenuedit.h
  treeview.cpp
  treeview.h

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18970: update gitignore

[Aidan Sojourner]

tuxxi abandoned this revision.
tuxxi added a comment.


  whoops

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D18970

To: tuxxi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18970: update gitignore

[Aidan Sojourner]

tuxxi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tuxxi requested review of this revision.

REVISION SUMMARY
  add basic filtering
  
  added label
  
  fix category expansion when searching
  
  simplify expansion code
  
  use QTreeView methods instead of reinventing the wheel; fix gitignore
  
  change filter threshold to 2 chars, update comments
  
  revert unnesscary changes
  
  update gitignore again since ngraham is a dick
  
  remove label and add placeholder text

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18970

AFFECTED FILES
  kmenuedit.cpp
  kmenuedit.h
  treeview.cpp
  treeview.h

To: tuxxi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Nathaniel Graham]

ngraham added a comment.


  Putting the KCM name in the header would make semantic sense, though then we 
would have triple name duplication: in the header, in the sidebar, and in the 
titlebar. Maybe that's not so bad as long as they all display the same text 
though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added a comment.


  I suggest not adding them to the patch. :)
  
  Since they've already been added to this patch, you can do `git checkout 
.gitignore` to recover the original version of that file, and then `arc diff` 
to update the patch. But if your IDE adds the file again automatically, then I 
can't help you since I'm not familiar with that IDE.

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Aidan Sojourner]

tuxxi added a comment.


  Hi ngraham:
  
  OK, can do on the label / placeholder. 
  RE: `.gitignore`, those files are generated by my IDE (CLion). What do you 
suggest I do?

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

[Filip Fila]

filipf added a comment.


  In D18934#410952 , @ngraham wrote:
  
  > Let me know if that appeals to you.
  
  
  You bet it does, it's looks much better. Unfortunately from what I'm seeing 
"window-close" is picked up from the desktop\Plasma theme while 
"window-close-symbolic" is picked up from the icon theme.
  
  In practice that means if you, for instance, use the Oxygen icon theme and 
the Adapta desktop\Plasma theme, the default look of things is:
  
  F6611674: Screenshot_20190212_201605.png 

  
  And when you hover over the icon you get this:
  
  F6611676: Screenshot_20190212_201619.png 

  
  ... which is the opposite of what we'd want!
  
  In D18934#410954 , @ngraham wrote:
  
  > Or alternatively we could make the existing ToolButton `flat` all the time 
and then it will have the advantage of behaving like all other ToolButtons that 
people are already familiar with.:
  
  
  We've thought about this too, but the problem is that the button is still 
centered and placed within a button, which makes it look badly aligned:
  
  F6611691: Screenshot_20190212_202517.png 

  
  Ideally we actually wanted to use **RoundButton**, but we cannot for the life 
of us get icons to show up in it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18934

To: filipf, ngraham, #vdg, rooty, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added a comment.


  @trmdi please do me a favour:
  
  1. close this review and open a clean new one because for some reason when 
trying to test it in my system includes also one old commit that I added the 
ViewType option
  2. no problem with & characters you can add them
  3. no problem to hide the Dock/Panel View when (configuring)
  4. please dont use the config file to access the viewType, I found an 
alternative way that it is in the master, we sniff now the viewType through 
dbus contextMenuData. The menu sends the containment->id() and when 
contextMenuData are requested these data include also the view type.
  5. For the setVisible(true) and how this bug occurs we will discuss it again 
at the new review

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Got some updates and confirmed that this fixes the bug. Code looks sane. 
Please land on the `Plasma/5.15` branch and then merge to master.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

[Nathaniel Graham]

ngraham added a comment.


  Or alternatively we should make the existing ToolButton `flat` all the time 
and then it will have the advantage of behaving like all other ToolButtons that 
people are already familiar with.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18934

To: filipf, ngraham, #vdg, rooty, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

[Nathaniel Graham]

ngraham added a comment.


  I don't like this approach because the IconItem has no pressed state. This is 
already a problem for the Task Manager tooltips, and I'd like to not replicate 
it here too. Also I don't really like the fact that the close button is red 
here even before it's hovered; dismissing a notification is not a destructive 
action.
  
  I have an idea though. Try applying this on top of your patch:
  
diff --git a/applets/notifications/package/contents/ui/NotificationItem.qml 
b/applets/notifications/package/contents/ui/NotificationItem.qml
index 83bd9dcd..5386e557 100644
--- a/applets/notifications/package/contents/ui/NotificationItem.qml
+++ b/applets/notifications/package/contents/ui/NotificationItem.qml
@@ -237,8 +237,8 @@ MouseArea {
 PlasmaCore.IconItem {
 id:closeIcon
 anchors.fill: parent
-active: parent.containsMouse
-source: "window-close"
+active: parent.pressed
+source: parent.containsMouse ? "window-close" : 
"window-close-symbolic"
 animated: false
 }
 }
  
  (You can do this with `git apply -` then paste, then hit [Ctrl] + [d])
  
  Let me know if that appeals to you.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18934

To: filipf, ngraham, #vdg, rooty, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Chris Holland]

Zren added a comment.


  In D18961#410792 , @kossebau wrote:
  
  > > we no longer have to install the widget to .../share/plasma/plasmoids/
  >
  > No experience here, but do we not still need to install the QML extension 
plugins to have the applet working? Or is there some mechanism to load them 
also from the build dir now?
  
  
  
  
  - We still need the private QML plugin for the `Util.___` functions yes, but 
you don't need to reinstall those if you only touched the QML.
  - `plasmoidviewer -a package` does not populate `plasmoid.nativeInterface`, 
so any code touching the `nativeInterface` config (all of it) doesn't work when 
you use that to test. I'm not 100% sure why the relative path isn't loading the 
`nativeInterface` even though the metadata `X-KDE-PluginInfo-Name` should be 
the same. I'll need to dive into `plasmoidviewer`'s code.
  - After the patch, we only need the `nativeInterface` to migrate the code. If 
it doesn't load the `nativeInterface`, plasma uses a placeholder `QObject {}`, 
which skips the migration code.
  
  In D18961#410784 , @kossebau wrote:
  
  > Though it breaks my technically-perfect-solution-aiming engineer's heart :)
  >  please be prepared for some 2 weeks time needed on my side to get over 
this :)
  
  
  lol, take your time. This is for the Plasma 5.16/5.17 release cycle so we've 
ages to choose this or develop a different patch.
  
  So long as the migration code is in Ubuntu 20.04, and Debian 11 (Bullseye) in 
2021. We can take it out before 22.04 or Debian 12 (Bookworm) in 2023. Anyone 
jumping 2 LTS versions usually expects some hiccups when upgrading.
  
  Note: kicker used a similar migration method (QML onCompleted) to port their 
`plasmoid.configuration.favorites` => SQLiteDB.  
  
https://github.com/KDE/plasma-desktop/blob/master/applets/kicker/package/contents/ui/main.qml#L115

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

To: Zren, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Jonah Brüchert]

jbbgameich added a comment.


  Thanks, done.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Nathaniel Graham]

ngraham added a comment.


  Yep, see 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Jonah Brüchert]

jbbgameich added a comment.


  Yes, this looks like the same problem. Since the UpdatesPage width is being 
decreased when opening the "More information", it's the same effect as on a 
phone screen where the width is always that small.
  Can / should I somehow tag this patch so it marks the bug as resolved?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> kmenuedit.cpp:143
> +auto searchLayout = new QHBoxLayout;
> +searchLayout->addWidget(new QLabel(i18n("Filter:")));
> +searchLayout->addWidget(m_searchLine);

In general, we're trying to standardize on a single KDE-wide style for our 
search boxes:

- No explanatory label to the left
- Placeholder text that says "Search..."

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham added a comment.


  This revision still has unrelated `.gitignore` changes.

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Nathaniel Graham]

ngraham added a comment.


  Can you confirm whether or not this also fixes 
https://bugs.kde.org/show_bug.cgi?id=404070?
  
  Can't test right now, I don't have any updates!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

[Jonah Brüchert]

jbbgameich created this revision.
jbbgameich added a reviewer: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  On Small screens (e.g phones), not all list items have the same height, for 
example when a package has a long version string.
  Since the width of the icon was previously copied from the height, this 
resulted in inconsistent icon sizes.
  
  This patch sets the icon size to a constant value, which fixes the problem.

TEST PLAN
  Icon sizes are consistent and still correctly sized

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> mvourlakos wrote in menu.cpp:92
> in this slot is also needed:
> 
>   m_configureAction->setEnabled(true);
> 
> there are cases that the Dock Settings is shown when !configuring but it is 
> not enabled

I don't understand. my code only change the `visible` property, why does it 
have to handle the "enable" one?

You meant the setting is showing but configuring==false? Sound weird. How to 
make it happen?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> mvourlakos wrote in menu.cpp:68
> when we add character & in the menus it means that a modifier+&Letter 
> activates that option what is the shortcut that add widgets?

For example, "&Add widgets..."

- shortcut: `Alt+a`
- the shortcut only works when that menu is showing
- it does not change anything else

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> menu.cpp:92
> +connect(this->containment(), 
> &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){
> +m_configureAction->setVisible(!configuring);
> +});

in this slot is also needed:

  m_configureAction->setEnabled(true);

there are cases that the Dock Settings is shown when !configuring but it is not 
enabled

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> menu.cpp:132
> +const int viewType = this->containment()->config().readEntry("viewType", 
> static_cast(Latte::Types::DockView));
> +m_configureAction->setText(i18nc("view settings window", viewType == 
> Latte::Types::DockView ? "Dock &Settings..." : "Panel &Settings..."));
> +

same thing for these & characters, do not respond to any shortcut so they 
should be removed

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> menu.cpp:68
>  
> -m_addWidgetsAction = new QAction(QIcon::fromTheme("add"), i18n("Add 
> Widgets..."), this);
> +m_addWidgetsAction = new QAction(QIcon::fromTheme("add"), i18n("&Add 
> Widgets..."), this);
>  m_addWidgetsAction->setStatusTip(i18n("Show Plasma Widget Explorer"));

when we add character & in the menus it means that a modifier+&Letter activates 
that option what is the shortcut that add widgets?

> menu.cpp:78
>  
> -m_configureAction = new QAction(QIcon::fromTheme("configure"), 
> i18nc("view settings window", "View Settings..."), this);
> -m_configureAction->setShortcut(QKeySequence());
> +m_configureAction = new QAction(QIcon::fromTheme("configure"), 
> i18nc("view settings window", "View &Settings..."), this);
> +

when we add character & in the menus it means that a modifier+&Letter activates 
that option what is the shortcut that shows dock settings? it has been chosen 
to be Meta+A so that change does not respond to something

> menu.cpp:84
>  m_layoutsAction = m_switchLayoutsMenu->menuAction();
> -m_layoutsAction->setText(i18n("Layouts"));
> +m_layoutsAction->setText(i18n("&Layouts"));
>  m_layoutsAction->setIcon(QIcon::fromTheme("user-identity"));

when we add character & in the menus it means that a modifier+&Letter activates 
that option what is the shortcut that shows Latte layouts menu? none, this 
shouldnt be applied also

> trmdi wrote in menu.cpp:91
> Yes, it's needed. Because when you're opening the Setting window and you 
> right click on the view, it will close the Setting window, not a nice 
> behavior. So we should hide it when the Setting window is opening.

ok this a behavior change irrelevant with the patch but ok we can keep it

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo updated this revision to Diff 51525.
vpilo added a comment.


  - Review comments, rework
  
  - Put the timer back to 15s
  - Removed trigger on start for QML timers: the timer now only runs if the 
current scan was successful
  - Don't use any more Qt 5.12 APIs

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18896?vs=51315&id=51525

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Björn Feber]

GB_2 added a comment.


  We currently use the KAboutData name in headers, we can easily change them to 
real titles and leave the desktop files how they are currently (explanation 
sentences). Should we just use the KCM name in the header or something more 
explaining like "Look and Feel Theme Selection"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> mvourlakos wrote in menu.cpp:91
> is this still needed if we check the value each time we show up the context 
> menu?

Yes, it's needed. Because when you're opening the Setting window and you right 
click on the view, it will close the Setting window, not a nice behavior. So we 
should hide it when the Setting window is opening.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> menu.cpp:91
> +
> +connect(this->containment(), 
> &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){
> +m_configureAction->setVisible(!configuring);

is this still needed if we check the value each time we show up the context 
menu?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Friedrich W. H. Kossebau]

kossebau added a comment.


  > we no longer have to install the widget to .../share/plasma/plasmoids/
  
  No experience here, but do we not still need to install the QML extension 
plugins to have the applet working? Or is there some mechanism to load them 
also from the build dir now?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

To: Zren, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for the work on that patch!
  
  So far I had thought of using the kconf_update system to ensure the config 
data would get the needed migration in the storage system (i.e. the ini files) 
into the [General] & Co. subsection as needed with the QML-based config variant.
  Challenge here has been that so far nobody had pioneered to do that for 
Plasma config, at least for Plasma 5.
  
  Doing this with some temporary logic in the applet itself of course is also a 
way. Though it breaks my technically-perfect-solution-aiming engineer's heart :)
  
  This needs some more thinking from my side, so please be prepared for some 2 
weeks time needed on my side to get over this :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

To: Zren, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Nathaniel Graham]

ngraham added a comment.


  No. :(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18859: cdb: First working version

[patrick j pereira]

patrickelectric marked 2 inline comments as done.
patrickelectric added a comment.


  Make tomaz happy

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: cdb: First working version

[patrick j pereira]

patrickelectric updated this revision to Diff 51518.
patrickelectric added a comment.


  remove virtual, override.

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18859?vs=51516&id=51518

BRANCH
  cdb

REVISION DETAIL
  https://phabricator.kde.org/D18859

AFFECTED FILES
  src/data/debuggers/external/cdbrc
  src/data/debuggers/internal/cdbrc
  src/drkonqibackends.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18867: Remove redundant DNS field per bug 403546

[Nathaniel Graham]

ngraham added a comment.


  Does this fix 403546? If so, then the Summary section should have `BUG: 
403546` in it so the bug automatically gets closed. Also regardless, You should 
remove "per bug 403546" from the title. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  RemoveDNSField

REVISION DETAIL
  https://phabricator.kde.org/D18867

To: andersonbruce, jgrulich
Cc: ngraham, lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: cdb: First working version

[Tomaz Canabrava]

tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> backtraceparsercdb.h:31
> +protected Q_SLOTS:
> +virtual void newLine(const QString &lineStr);
> +

remove virtual, override.

> backtraceparsercdb.h:34
> +protected:
> +virtual BacktraceParserPrivate *constructPrivate() const;
> +};

remove virtual, override.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi updated this revision to Diff 51515.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18918?vs=51498&id=51515

REVISION DETAIL
  https://phabricator.kde.org/D18918

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: cdb: First working version

[patrick j pereira]

patrickelectric added a comment.


  This is a screenshot of drkonqi on windows, it was built with craft and 
integrated with a WIP project.
  F6611293: image.png 

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18859

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18859: [WIP] msvc: First commit

[patrick j pereira]

patrickelectric updated this revision to Diff 51516.
patrickelectric added a comment.


  Correct and initial implementation

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18859?vs=51209&id=51516

BRANCH
  cdb

REVISION DETAIL
  https://phabricator.kde.org/D18859

AFFECTED FILES
  src/data/debuggers/external/cdbrc
  src/data/debuggers/internal/cdbrc
  src/drkonqibackends.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h

To: patrickelectric
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  If `plasmoid.nativeInterface.source != ""`, we copy it to 
`plasmoid.configuration.source` + same
  with all other properties besides `needsToBeSquare` which is a "session" 
variable that updated
  right after the migration code.
  
  The selected weather `services` StringList is not a `nativeInterface` 
property, so it needs to be copied differently.
  
  -
  
  We could also copy the other properties the using the 
`configValues().services` pattern if you want the code consistent.
  
  This is a pure QML solution. Ideally, the final patch will have a few more 
C++ functions/enums exposed to the QML. The `DisplayUnits.qml` properties could 
be turned into functions. Eg:
  
Utils.parseTemperatureUnitId(plasmoid.configuration.temperatureUnitId)
  
  That way we don't have magic numbers (`6001 // Celcius`)  littered throughout 
`DisplayUnits.qml`.
  
  -
  
  Ideally, we'll only keep the `nativeInterface` + migration code until Plasma 
5.19 assuming Plasma 5.18 is the next Plasma LTS version. We could remove the 
migration code earlier, as having the user re-setup their weather widget isn't 
terribly cumbersome for the user.
  
  Once it no longer depends on the `nativeInterface`, users can easily fork the 
default weather widget.
  
  Immendiate benefits are that we no longer have to install the widget to 
`.../share/plasma/plasmoids/` to test the widget's QML. We can now use 
`plasmoidviewer -a package`. Note that we still need to install to 
`~/.local/share/plasma/plasmoids/` to test the `nativeInterface` migration code 
as mentioned in the test plan.

TEST PLAN
  - Apply patch.
  - Copy `weather/package` to `~/.local/share/plasma/plasmoids/` and rename the 
`package` directory to `org.kde.plasma.weather`.
  - Restart plasmashell with `kstart5 -- plasmashell --replace`
  - The settings should have migrated, and the widget should still work.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

AFFECTED FILES
  applets/weather/package/contents/config/main.xml
  applets/weather/package/contents/ui/CompactRepresentation.qml
  applets/weather/package/contents/ui/DisplayUnits.qml
  applets/weather/package/contents/ui/config/ConfigAppearance.qml
  applets/weather/package/contents/ui/config/ConfigUnits.qml
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml
  applets/weather/package/contents/ui/main.qml

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18867: Remove redundant DNS field per bug 403546

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  I wonder whether this should also go to Plasma 5.15 branch, it's an 
improvement and doesn't introduce new strings so should be ok to be backported.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  RemoveDNSField

REVISION DETAIL
  https://phabricator.kde.org/D18867

To: andersonbruce, jgrulich
Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  @ngraham, are the icorresponding images now removed after removing a folder 
with the removal of the token check?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi added a comment.


  In D18918#410614 , @mvourlakos 
wrote:
  
  > I don't think it is needed, you can try to update the action text just a 
little before the menu is shown
  >
  > Qmenu has an aboutToShow signal and containment has as a 
contextuakActionsAboutToShow signal
  
  
  You meant to run setConfigureActionText() whenever the menu/action is about 
to show?
  It will have to read the config again and again. If there isn't any issue 
with reading the config again and again, e.g. disk reading... then we could set 
the text inside the `Menu::contextualActions()`

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Jan Grulich]

jgrulich added a comment.


  In D18896#410594 , @vpilo wrote:
  
  > In D18896#409742 , @jgrulich 
wrote:
  >
  > > I would keep the 15s interval, everyone does 15s. Also from what I have 
read, every scan drops your connection for a while, which might be a problem 
for bad wifi drivers, where the scan can take 15+ seconds so doing this more 
often is not a good idea. Other thing I would change is to try to repeat the 
scan if it fails only for the first time (when you open the applet), then I 
don't think it's necessary to keep spamming NetworkManager with our requests.
  >
  >
  > Everyone using 15 seconds for a timeout doesn't mean it's good for the 
users...
  
  
  I think it's reasonable enough and also as I mentioned above, wifi scanning 
drops your connection for a while, there is no reason to drop it more often, 
especially when we will have a fresh scan as soon as possible.
  
  Also see: 
https://blogs.gnome.org/dcbw/2016/05/16/networkmanager-and-wifi-scans/
  
  > Anyways, why shouldn't we be doing an attempt every 2 seconds? that's not a 
lot. I could do two things instead:
  
  I didn't mean we shouldn't be doing an attempt every 2 seconds, I meant that 
we should go through this retry logic only in case of initial scan, but keep it 
that way. Just set the interval back to 15s.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Force reset of kwayland

[David Edmundson]

I merged someone else's commit by mistake which wasn't accepted.
It was force reset immediately afterwards. Hopefully won't have affected
anyone

Sorry

David

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added a comment.


  In D18918#410587 , @trmdi wrote:
  
  > In D18918#410552 , @mvourlakos 
wrote:
  >
  > >
  >
  
  
  
  
  > Do you have a better way to detect when `viewType` changes?
  
  I don't think it is needed, you can try to update the action text just a 
little before the menu is shown
  
  Qmenu has an aboutToShow signal and containment has as a 
contextuakActionsAboutToShow signal
  
  I would try these two first

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[David Edmundson]

davidedmundson added a comment.


  > Other thing I would change is to try to repeat the scan if it fails only 
for the first time
  > then I don't think it's necessary to keep spamming NetworkManager with our 
requests.
  
  Maybe not necessary, but I don't think it's an issue either.
  
  The return is very early on the NM side, it won't actually spend time doing 
anything. 
  DBus overhead is insignificant when doing something every second.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo added a comment.


  In D18896#409742 , @jgrulich wrote:
  
  > I would keep the 15s interval, everyone does 15s. Also from what I have 
read, every scan drops your connection for a while, which might be a problem 
for bad wifi drivers, where the scan can take 15+ seconds so doing this more 
often is not a good idea. Other thing I would change is to try to repeat the 
scan if it fails only for the first time (when you open the applet), then I 
don't think it's necessary to keep spamming NetworkManager with our requests.
  
  
  Everyone using 15 seconds for a timeout doesn't mean it's good for the 
users... Anyways, why shouldn't we be doing an attempt every 2 seconds? that's 
not a lot. I could do two things instead:
  
  - double the interval between attempts every time they fail
  - Only run the UI timer when the scan request has been successful

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi updated this revision to Diff 51498.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18918?vs=51481&id=51498

REVISION DETAIL
  https://phabricator.kde.org/D18918

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi added a comment.


  In D18918#410552 , @mvourlakos 
wrote:
  
  > for Latte panels after startup or after switching layouts if the user right 
clicks the panel the menu is appearing correctly as:
  >
  > **Panel Setings...** ?
  
  
  Whenever there is a valid `viewType` in the layout file.

INLINE COMMENTS

> mvourlakos wrote in menu.cpp:92
> why this is needed?

- when the user opens View Settings, there is a case that he change the 
viewType, so we should set the text again.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:c62901d8aed6: Don't show tooltip when search field 
has text and set a timeout period (authored by shubham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18766?vs=51272&id=51496

REVISION DETAIL
  https://phabricator.kde.org/D18766

AFFECTED FILES
  discover/qml/SearchField.qml

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.15.0

[Jonathan Riddell]

Plasma 5.15.0 is now released
https://www.kde.org/announcements/plasma-5.15.0.php

D18918: Make the text of "View Settings" action more specific

[Michail Vourlakos]

mvourlakos added a comment.


  for Latte panels after startup or after switching layouts if the user right 
clicks the panel the menu is appearing correctly as:
  
  **Panel Setings...** ?

INLINE COMMENTS

> menu.cpp:92
> +connect(this->containment(), 
> &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){
> +m_configureAction->setVisible(!configuring);
> +if (!configuring) setConfigureActionText();

why this is needed?

> menu.cpp:93
> +m_configureAction->setVisible(!configuring);
> +if (!configuring) setConfigureActionText();
> +});

style issue. even for single lines ifs

  if (..) {
  
  }

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18946: Set parent on newly created fwupd resource

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:8c673e79ab45: Set parent on newly created fwupd resource 
(authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18946?vs=51482&id=51483

REVISION DETAIL
  https://phabricator.kde.org/D18946

AFFECTED FILES
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdBackend.h

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18946: Set parent on newly created fwupd resource

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 51482.
leinir added a comment.


  Slightly different (and more central) approach. This ensures that resources 
are parented on creation rather than later (such as when being added to the 
updates list)

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18946?vs=51480&id=51482

REVISION DETAIL
  https://phabricator.kde.org/D18946

AFFECTED FILES
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdBackend.h

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18918: Make the text of "View Settings" action more specific

[Tranter Madi]

trmdi updated this revision to Diff 51481.

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18918?vs=51464&id=51481

REVISION DETAIL
  https://phabricator.kde.org/D18918

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18946: Set parent on newly created fwupd resource

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Without this patch, the resource lacks a parent backend, which causes issues 
when attempting to signal changes in it later on (as AbstractResource depends 
on there being a backend set)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18946

AFFECTED FILES
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Make Kicker accessible

[chrys]

Howdy David,

i wonder if we can revoke the following for the next version of plasma?
https://phabricator.kde.org/D7780

would be very awsome to not have it stalled if you already did most of  
the work and have an accessible default menu :).


cheers chrys