D19280: [TaskManager] Modernize and reorganize configuration settings

[Eike Hein]

hein added a comment.


  > [X] Open groups in popups
  > [X] Only when the Task Manager is full
  
  Reversing and not indenting these options breaks their dependent 
relationship. Please revert this to the original layout.
  
  Looks nice otherwise!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2
Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19293: i18n: Add context to "Cannot fetch sources"

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good to me, maybe it would make sense to include the context on the 
rest? Why is this one special?

REPOSITORY
  R134 Discover Software Store

BRANCH
  i18n-context-fetch-source

REVISION DETAIL
  https://phabricator.kde.org/D19293

To: aspotashev, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

[Krešimir Čohar]

rooty updated this revision to Diff 52501.
rooty added a comment.


  Do not use implicit width

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19295?vs=52500=52501

BRANCH
  battery-config-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19295

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/ConfigGeneral.qml

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  battery-config-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19295

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/ConfigGeneral.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Filip Fila]

filipf updated this revision to Diff 52497.
filipf added a comment.


  remove PlasmaCore as an import

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19289?vs=52493=52497

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19293: i18n: Add context to "Cannot fetch sources"

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aspotashev requested review of this revision.

TEST PLAN
  none

REPOSITORY
  R134 Discover Software Store

BRANCH
  i18n-context-fetch-source

REVISION DETAIL
  https://phabricator.kde.org/D19293

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitMessages.cpp

To: aspotashev
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in configGeneral.qml:23
> Is PlasmaCore also needed here?

Looks like it's not used anywhere, so I'd say no.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> configGeneral.qml:23
>  
>  import org.kde.plasma.core 2.0 as PlasmaCore
>  

Is PlasmaCore also needed here?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Filip Fila]

filipf added a comment.


  In D19289#418964 , @davidedmundson 
wrote:
  
  > Out of curiosity, did you need the exclusive group. 
  >  In theory RadioButton should do it automatically when we share a parent, 
I'm curious if FormLayout breaks that.
  
  
  You're right, it wasn't necessary; I was following the original code too 
closely.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Filip Fila]

filipf updated this revision to Diff 52493.
filipf added a comment.


  ButtonGroup is not needed

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19289?vs=52489=52493

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/configGeneral.qml

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf added a comment.


  Thank you :)
  
  Does anyone from #plasma  maybe know 
why the QQC2 Slider fails to obey the "visible: vertical" setting? The 
variables have been changed in accordance with QQC2 and the slider does show up 
with no "visible:" status set, but simply won't work here.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty, GB_2
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[David Edmundson]

davidedmundson added a comment.


  Out of curiosity, did you need the exclusive group. 
  In theory RadioButton should do it automatically when we share a parent, I'm 
curious if FormLayout breaks that.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great and works great. Fantastic work!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice work!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf updated this revision to Diff 52491.
filipf added a comment.


  "Filters:" -> "Filter:", "Only when the Task Manager is full" -> "Group only 
when the Task 
  Manager is full" (I think it's better to be explicit), use 
"preferences-desktop-color" for 
  Appearance icon, "Highlight windows" -> "Highlight windows when hovering over 
tasks"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52484=52491

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Settings are ported to QtQuickControls 2 and now use a Kirigami Form Layout.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  modernize-devicenotifier-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19289

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/configGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19036: [notifications] Lift up notification content if one line of body text droops

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  @broulik, does this look good to you?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19036

REVISION DETAIL
  https://phabricator.kde.org/D19036

To: rooty, #plasma, #vdg, broulik, ngraham, filipf
Cc: anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:56
> +id: highlightWindows
> +text: i18n("Highlight windows")
> +}

This would be a bit clearer if it said something more along the line of 
"Highlight windows when hovering over tasks"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> config.qml:27
> + name: i18n("Appearance")
> + icon: "preferences-desktop-plasma-theme"
> + source: "ConfigAppearance.qml"

Hmm, not sure this really fits, TBH. I kind of likes the colors-style icon you 
used in a previous version.

> GB_2 wrote in ConfigBehavior.qml:64
> "Task Manager" should be lowercase and a better text would be "Only group 
> when the task manager is full".
> I'd also switch the position with the above checkbox.

Uppercase is fine since it's a proper noun.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Björn Feber]

GB_2 added a comment.


  Almost perfect!

INLINE COMMENTS

> ConfigBehavior.qml:64
> +id: onlyGroupWhenFull
> +text: i18n("Only when the Task Manager is full")
> +enabled: groupingStrategy.currentIndex > 0 && groupPopups.checked

"Task Manager" should be lowercase and a better text would be "Only group when 
the task manager is full".
I'd also switch the position with the above checkbox.

> ConfigBehavior.qml:115
> +id: showOnlyCurrentScreen
> +Kirigami.FormData.label: i18n("Filters:")
> +text: i18n("Show only tasks from the current screen")

Better: "Filter:"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf added a comment.


  Much better, I agree! I've implemented all the changes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:58e6cc6e119f: [weather] envcan: Fix typo in lowercase 
icon lookup string (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19176?vs=52122=52485

REVISION DETAIL
  https://phabricator.kde.org/D19176

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf updated this revision to Diff 52484.
filipf added a comment.


  better categorization of settings

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52479=52484

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I love the idea of an Appearance/Behavior split. I think that really improves 
the approachability of the settings window. But I think it will require a bit 
of re-organization since with the current state of the patch, there are items 
on the Behavior page that are appearance-based, and vice versa.
  
  How about this for the breakdown?
  
Appearance

 General: [x] Show tooltips
  [ ] Highlight windows
  [x] Show progress and status information in task buttons
  [x] Mark applications that play audio

   Icon size: --o---
  SmallLarge

Maximum rows: [ 2 ]
  [x] Always arrange tasks in as many rows as columns
  
  
  
Behavior

   Group: [ By program name v ]
  [x] Open groups in popups
  [x] Only when the Task Manager is full

Sort: [ Manually v ]
  [x] Keep launchers separate

 On middle-click: [ Close Window or Group v ]
  [ ] Cycle through tasks with mouse wheel

 Filters: [ ] Show only tasks from the current screen
  [ ] Show only tasks from the current desktop
  [x] Show only tasks from the current activity
  [ ] Show only tasks that are minimized

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Nick Guletskii]

nickguletskii added a comment.


  I've described my problem in a bug report: 
https://bugs.kde.org/show_bug.cgi?id=404785

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

To: nickguletskii, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19274: i18n: Do not refer to parent directory from Messages.sh

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:423f4b8bc922: i18n: Do not refer to parent directory from 
Messages.sh (authored by aspotashev).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19274?vs=52440=52480

REVISION DETAIL
  https://phabricator.kde.org/D19274

AFFECTED FILES
  Messages.sh
  app/Messages.sh

To: aspotashev, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf updated this revision to Diff 52479.
filipf added a comment.


  use sentence-style capitalization for combobox entries

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52476=52479

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Michail Vourlakos]

mvourlakos added a comment.


  In D19279#418826 , @nickguletskii 
wrote:
  
  > Hmm, sorry, I couldn't get the master branch to start on my machine, and 
since I've only used v0.8, I didn't realise this is already implemented. My 
mistake.
  
  
  why you couldn't get the master branch, what is the problem?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

To: nickguletskii, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19281: Highlight the hovered item in the task group tooltip

[Michail Vourlakos]

mvourlakos requested changes to this revision.
mvourlakos added a comment.
This revision now requires changes to proceed.


  1. you must rebase it with master somehow otherwise I cant test/review this
  2. I like the idea but I dont like how it looks, I find it too intrusive. I 
could accept the following as a feature for this:
  
a. When the mouse hovers previews changes its mouse icon to a hand like web 
links are doing b. the bottom line could be used also in that case maybe by 
showing it and changing its color e.g. from theme but not buttoFocusColor that 
is used from active task something other from the theme palette

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19281

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Nick Guletskii]

nickguletskii abandoned this revision.
nickguletskii added a comment.


  Hmm, sorry, I couldn't get the master branch to start on my machine, and 
since I've only used v0.8, I didn't realise this is already implemented. My 
mistake.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

To: nickguletskii, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19274: i18n: Do not refer to parent directory from Messages.sh

[Michail Vourlakos]

mvourlakos accepted this revision.
mvourlakos added a comment.
This revision is now accepted and ready to land.


  makes sense

REPOSITORY
  R878 Latte Dock

BRANCH
  messages-sh

REVISION DETAIL
  https://phabricator.kde.org/D19274

To: aspotashev, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19284: Close the window selected in the task group tooltip on middle click

[Michail Vourlakos]

mvourlakos accepted this revision.
mvourlakos added a comment.
This revision is now accepted and ready to land.


  this ok ...

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19284

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Krešimir Čohar]

rooty accepted this revision as: rooty.
rooty added a comment.
This revision is now accepted and ready to land.


  Works fine for me on neon, best wait for Nate's go-ahead but I'm convinced :D

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf updated this revision to Diff 52476.
filipf edited the test plan for this revision.
filipf added a comment.


  Use action verbs for "Sorting" and "Grouping"; extend "visible: vertical" 
property to all 
  revelant elements

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52465=52476

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Make shadow sizes linear

[Vlad Zagorodniy]

zzag added a comment.


  > I don't see a difference either
  
  
  
  > If the ambient shadow actually did anything, wouldn't the inner areas of 
the shadow be significantly different in the second screenshot?
  
  Again, I'll repeat, the ambient shadow matters. Decoration shadows are a bit 
bigger so it's okay to make it less subtle. Impact of the ambient shadow is 
more noticeable in kstyle shadows. Speaking of which, I'm not sure that I like 
the new ones. Popups "glow" rather than cast shadows; though that's 
personal(not anymore) opinion...
  
  > but at least the numbers look pretty.
  
  The linear function is not good enough for sampling parameters. When I was 
working on shadows, I'd also fallen in this trap. "Pretty numbers" doesn't mean 
"pretty shadows." :-)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham, rooty
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19276: [AppletConfiguration] Use title case for Keyboard Shortcuts label

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:61e9f7319a60: [AppletConfiguration] Use title case for 
Keyboard Shortcuts label (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19276?vs=52444=52470

REVISION DETAIL
  https://phabricator.kde.org/D19276

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, ngraham, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19284: Close the window selected in the task group tooltip on middle click

[Nick Guletskii]

nickguletskii created this revision.
nickguletskii added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nickguletskii requested review of this revision.

REVISION SUMMARY
  In Windows, it is possible to close windows by middle-clicking their previews 
in the taskbar. This patch adds this feature to Latte Dock. Now, middle 
clicking an item in the task group tooltip will close the corresponding window.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19284

AFFECTED FILES
  plasmoid/package/contents/ui/ToolTipWindowMouseArea.qml

To: nickguletskii, #latte_dock
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Thiago Macieira]

thiago added a comment.


  This new backtrace *is* a stuck application. Please report the issue to Mesa 
(dri/i965). Cc me, I can walk three paces in the office to the Mesa devs and 
help them figure out what's happening.
  
  Mesa debug symbols would be helpful.
  
  Anyway, as a workaround for the issue, this change seems acceptable.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf updated this revision to Diff 52465.
filipf added a comment.


  remove unneeded section breaks at the very beginning of the layout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19280?vs=52461=52465

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Thiago Macieira]

thiago added a comment.


  I repeat: there's no indication in the backtrace that it is stuck. What's 
your evidence that it is? You wrote an application that shows nothing and never 
exits. Now it showed nothing and didn't exit. That's not stuck, that's the 
expected behaviour.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Christoph Roick]

croick added a comment.


  A backtrace where it gets stuck in the destructor of QApplication.
  
(gdb) info thread
  Id   Target Id  Frame 
* 1Thread 0x736a2f80 (LWP 6015) "testqt"  
0x76906f6d in __pthread_timedjoin_ex () from /usr/lib/libpthread.so.0
  3Thread 0x7fffe9642700 (LWP 6026) "testqt:disk$0"   
0x7690bafc in pthread_cond_wait@@GLIBC_2.3.2 ()
   from /usr/lib/libpthread.so.0
  4Thread 0x7fffe8e41700 (LWP 6027) "QDBusConnection" 
0x76a0fc21 in poll () from /usr/lib/libc.so.6
(gdb) thread apply all bt

Thread 4 (Thread 0x7fffe8e41700 (LWP 6027)):
#0  0x76a0fc21 in poll () from /usr/lib/libc.so.6
#1  0x75e81540 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x75e8162e in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#3  0x770e3ce9 in 
QEventDispatcherGlib::processEvents(QFlags) () 
from /usr/lib/libQt5Core.so.5
#4  0x7708cb2c in 
QEventLoop::exec(QFlags) () from 
/usr/lib/libQt5Core.so.5
#5  0x76ed0569 in QThread::exec() () from /usr/lib/libQt5Core.so.5
#6  0x73108ba6 in ?? () from /usr/lib/libQt5DBus.so.5
#7  0x76ed196c in ?? () from /usr/lib/libQt5Core.so.5
#8  0x76905a9d in start_thread () from /usr/lib/libpthread.so.0
#9  0x76a1ab23 in clone () from /usr/lib/libc.so.6

Thread 3 (Thread 0x7fffe9642700 (LWP 6026)):
#0  0x7690bafc in pthread_cond_wait@@GLIBC_2.3.2 () from 
/usr/lib/libpthread.so.0
#1  0x7fffe9c5ec94 in ?? () from /usr/lib/dri/i965_dri.so
#2  0x7fffe9c5e9b8 in ?? () from /usr/lib/dri/i965_dri.so
#3  0x76905a9d in start_thread () from /usr/lib/libpthread.so.0
#4  0x76a1ab23 in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x736a2f80 (LWP 6015)):
#0  0x76906f6d in __pthread_timedjoin_ex () from 
/usr/lib/libpthread.so.0
#1  0x7fffe9c5ea71 in ?? () from /usr/lib/dri/i965_dri.so
#2  0x7fffe9c5f309 in ?? () from /usr/lib/dri/i965_dri.so
#3  0x7fffe9c5a73a in ?? () from /usr/lib/dri/i965_dri.so
#4  0x7fffe9be4344 in ?? () from /usr/lib/dri/i965_dri.so
#5  0x7fffe9c563cf in ?? () from /usr/lib/dri/i965_dri.so
#6  0x7fffeaafb07c in ?? () from /usr/lib/libGLX_mesa.so.0
#7  0x7fffeaae7822 in ?? () from /usr/lib/libGLX_mesa.so.0
#8  0x7fffeaae78a9 in ?? () from /usr/lib/libGLX_mesa.so.0
#9  0x7fffeaae79fe in ?? () from /usr/lib/libGLX_mesa.so.0
#10 0x75cc03e2 in XCloseDisplay () from /usr/lib/libX11.so.6
#11 0x731f1f52 in ?? () from /usr/lib/libQt5XcbQpa.so.5
#12 0x731c711a in QXcbConnection::~QXcbConnection() () from 
/usr/lib/libQt5XcbQpa.so.5
#13 0x731c83d7 in QXcbIntegration::~QXcbIntegration() () from 
/usr/lib/libQt5XcbQpa.so.5
#14 0x731c84da in QXcbIntegration::~QXcbIntegration() () from 
/usr/lib/libQt5XcbQpa.so.5
#15 0x77455ed9 in QGuiApplicationPrivate::~QGuiApplicationPrivate() 
() from /usr/lib/libQt5Gui.so.5
#16 0x77a546fa in QApplicationPrivate::~QApplicationPrivate() () 
from /usr/lib/libQt5Widgets.so.5
#17 0x770bf86f in QObject::~QObject() () from 
/usr/lib/libQt5Core.so.5
#18 0x770902b0 in QCoreApplication::~QCoreApplication() () from 
/usr/lib/libQt5Core.so.5
#19 0x77a56842 in QApplication::~QApplication() () from 
/usr/lib/libQt5Widgets.so.5
#20 0x5221 in main (argc=1, argv=0x7fffe578) at testqt.cpp:6

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19281: Highlight the hovered item in the task group tooltip

[Nick Guletskii]

nickguletskii created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nickguletskii requested review of this revision.

REVISION SUMMARY
  Currently, the task group tooltip doesn't react to the user hovering over a 
thumbnail. This patch adds a standard Plasma Highlight around the item that the 
user is hovering over, which signals the user that the item is clickable:
  
  F6633128: Screenshot_Latte_Dock_Window_Thumbnails_Highlight.png 

  
  (Unfortunately, Spectacle didn't capture the cursor, which was hovering over 
the third item.)

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19281

AFFECTED FILES
  plasmoid/package/contents/ui/ToolTipInstance.qml

To: nickguletskii
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Christoph Roick]

croick added a comment.


  In D18245#418656 , @thiago wrote:
  
  > This last backtrace does not show anything stuck. Thread 1 was actively 
running, in fact (it's inside of malloc).
  >
  > Also note your testcase has no window, since the widget is destroyed before 
app.exec().
  
  
  But it actually is stuck. That's the backtrace after CTRL+C in gdb of the 
stuck example and sending SIGSTOP to KDevelop.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19280: [TaskManager] Modernize and reorganize configuration settings

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch ports most of the QQC1 elements into QQC2 and makes use of 
Kirigami.FormLayout.
  
  Due to an overwhelming  number of options originally being present, the patch 
also splits them up
  into "Appearance" and "Behavior" categories.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19280

AFFECTED FILES
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Thiago Macieira]

thiago added a comment.


  This last backtrace does not show anything stuck. Thread 1 was actively 
running, in fact (it's inside of malloc).
  
  Also note your testcase has no window, since the widget is destroyed before 
app.exec().

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Christoph Cullmann]

cullmann added a reviewer: broulik.
cullmann added a comment.


  Perhaps Kai has some opinion.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik
Cc: cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Christoph Roick]

croick added a comment.


  The problem does not seem to be specific to DrKonqi. Once DrKonqi and 
KDevelop are stuck, any Qt program may have problems starting or quitting. A 
minimal example
  
#include 
#include 

int main(int argc, char **argv)
{
QApplication app(argc, argv);
QWidget().show();

return 0;
}
  
  gets stuck as well (sometimes starting like below, sometimes only when 
quitting), as long as KDevelop was not SIGSTOPped.
  
(gdb) info thread
  Id   Target Id  Frame 
* 1Thread 0x736a2f80 (LWP 21781) "testqt" 
0x76a116eb in brk () from /usr/lib/libc.so.6
  2Thread 0x72346700 (LWP 21785) "QXcbEventQueue" 
0x76a0fc21 in poll () from /usr/lib/libc.so.6
  3Thread 0x7fffe9642700 (LWP 21786) "testqt:disk$0"  
0x7690bafc in pthread_cond_wait@@GLIBC_2.3.2 ()
   from /usr/lib/libpthread.so.0
(gdb) thread apply all bt

Thread 3 (Thread 0x7fffe9642700 (LWP 21786)):
#0  0x7690bafc in pthread_cond_wait@@GLIBC_2.3.2 () from 
/usr/lib/libpthread.so.0
#1  0x7fffe9c5ec94 in ?? () from /usr/lib/dri/i965_dri.so
#2  0x7fffe9c5e9b8 in ?? () from /usr/lib/dri/i965_dri.so
#3  0x76905a9d in start_thread () from /usr/lib/libpthread.so.0
#4  0x76a1ab23 in clone () from /usr/lib/libc.so.6

Thread 2 (Thread 0x72346700 (LWP 21785)):
#0  0x76a0fc21 in poll () from /usr/lib/libc.so.6
#1  0x738f5630 in ?? () from /usr/lib/libxcb.so.1
#2  0x738f72db in xcb_wait_for_event () from /usr/lib/libxcb.so.1
#3  0x731f0949 in ?? () from /usr/lib/libQt5XcbQpa.so.5
#4  0x76ed196c in ?? () from /usr/lib/libQt5Core.so.5
#5  0x76905a9d in start_thread () from /usr/lib/libpthread.so.0
#6  0x76a1ab23 in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x736a2f80 (LWP 21781)):
#0  0x76a116eb in brk () from /usr/lib/libc.so.6
#1  0x76a117d1 in sbrk () from /usr/lib/libc.so.6
#2  0x769a63ed in __default_morecore () from /usr/lib/libc.so.6
#3  0x769a2656 in sysmalloc () from /usr/lib/libc.so.6
#4  0x769a3716 in _int_malloc () from /usr/lib/libc.so.6
#5  0x769a4ada in malloc () from /usr/lib/libc.so.6
#6  0x7fffeaaf3377 in ?? () from /usr/lib/libGLX_mesa.so.0
#7  0x7fffeaafba7b in ?? () from /usr/lib/libGLX_mesa.so.0
#8  0x7fffeaae7d09 in ?? () from /usr/lib/libGLX_mesa.so.0
#9  0x7fffeaae3335 in ?? () from /usr/lib/libGLX_mesa.so.0
#10 0x7fffeaae3d4d in ?? () from /usr/lib/libGLX_mesa.so.0
#11 0x73321f5f in ?? () from 
/usr/lib/qt/plugins/xcbglintegrations/libqxcb-glx-integration.so
#12 0x731de99a in QXcbWindow::create() () from 
/usr/lib/libQt5XcbQpa.so.5
#13 0x731c9880 in QXcbIntegration::createPlatformWindow(QWindow*) 
const () from /usr/lib/libQt5XcbQpa.so.5
#14 0x7746a9d8 in QWindowPrivate::create(bool, unsigned long long) 
() from /usr/lib/libQt5Gui.so.5
#15 0x77a888d8 in QWidgetPrivate::create_sys(unsigned long long, 
bool, bool) () from /usr/lib/libQt5Widgets.so.5
#16 0x77a88f30 in QWidget::create(unsigned long long, bool, bool) 
() from /usr/lib/libQt5Widgets.so.5
#17 0x77a96596 in QWidget::setVisible(bool) () from 
/usr/lib/libQt5Widgets.so.5
#18 0x5204 in main (argc=1, argv=0x7fffe578) at testqt.cpp:7
  
  
  
  > The commit message is nonsense. This problem has nothing to do with D-Bus. 
That's a red herring, because the QDBusConnection thread only exits after all 
open QDBusConnections close (including QDBusMessages holding them). The problem 
appears to be the XCB thread, stuck waiting for something, somehow, inside 
XCloseDisplay.
  
  So truly no DBus in this case. It really seems to be a problem with the 
graphics library, which could be the reason why this problem does not seem to 
be common.
  
  ---
  
  > The patch is innocuous. I don't see *how* it can solve anything, though, 
because I don;'t know what DrKonqu::cleanup does.
  
  One of the things that `DrKonqi::cleanup()` does is sending SIGCONT to the 
debuggee to finish it. I just checked: Not sending the signal makes DrKonqi 
quit entirely.
  I will add a comment in the code and change the commit message. The patch 
still remains a workaround though.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Michail Vourlakos]

mvourlakos added a comment.


  I am sorry but this isnt already supported?
  
  F6633078: image.png 

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

To: nickguletskii, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19279: Make the group activation action configurable

[Nick Guletskii]

nickguletskii created this revision.
nickguletskii added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nickguletskii requested review of this revision.

REVISION SUMMARY
  Currently, Latte starts the "present windows" effect when the user clicks on 
a task group and the "present windows" effect is available. To force Latte to 
display the task selection tooltip instead, the "present windows" effect must 
be disabled entirely. This patch adds the ability to force Latte to open the 
task group tooltip even when the "present windows" effect is enabled.
  
  This patch adds an additional setting, both to the main dock settings dialog 
and the dock widget settings:
  
  F6633034: Screenshot_Latte_Group_Activation_Action.png 

  
  F6633037: Screenshot_Latte_Group_Activation_Action_Dock_Settings.png 

  
  When "Present windows is possible" (the default option) is selected, the 
current behavior will be retained. When "Show previews" is selected, clicking 
on a task group will open the window selection tooltip as if "present windows" 
is disabled.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19279

AFFECTED FILES
  containment/package/contents/config/main.xml
  containment/package/contents/ui/main.qml
  liblattedock/dock.h
  plasmoid/package/contents/config/main.xml
  plasmoid/package/contents/ui/config/ConfigInteraction.qml
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/task/TaskDelegate.qml
  shell/package/contents/configuration/TasksConfig.qml

To: nickguletskii, #latte_dock
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18975: [PotD] Port mostly to QQC2

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:dd5a234771ab: [PotD] Port mostly to QQC2 (authored by 
ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18975?vs=51558=52445

REVISION DETAIL
  https://phabricator.kde.org/D18975

AFFECTED FILES
  wallpapers/potd/contents/ui/config.qml

To: ngraham, #plasma, davidedmundson, kossebau, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Conceptually sound. I'd say this even is a bugfix that can land on the 
`Plasma/5.15` branch, if the #plasma  
folks agree. See 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19276: [AppletConfiguration] Use title case for Keyboard Shortcuts label

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  "Keyboard shortcuts" -> "Keyboard Shortcuts"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  keyboard-shortcuts-TC (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19276

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Krešimir Čohar]

rooty added a comment.


  you got my vote, i think this looks a lot less stuck-on

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch adds horizontal padding to the category configuration delegate so 
that the label
  does not look like it is glued to the parent element.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19274: i18n: Do not refer to parent directory from Messages.sh

[Alexander Potashev]

aspotashev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aspotashev requested review of this revision.

REVISION SUMMARY
  This will make file references in .po/.pot files clearer for
  translators.

TEST PLAN
  none

REPOSITORY
  R878 Latte Dock

BRANCH
  messages-sh

REVISION DETAIL
  https://phabricator.kde.org/D19274

AFFECTED FILES
  Messages.sh
  app/Messages.sh

To: aspotashev
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19247: Replace outdated FindX11_XCB copy with ECM and imported targets

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:45d35e88b3cd: Replace outdated FindX11_XCB copy with ECM 
and imported targets (authored by vkrause).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19247?vs=52368=52429

REVISION DETAIL
  https://phabricator.kde.org/D19247

AFFECTED FILES
  kcms/touchpad/cmake/modules/FindX11_XCB.cmake
  kcms/touchpad/src/backends/x11.cmake

To: vkrause, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19244: Remove outdated FindGLIB2 copy

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f88abed5581f: Remove outdated FindGLIB2 copy (authored by 
vkrause).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19244?vs=52365=52428

REVISION DETAIL
  https://phabricator.kde.org/D19244

AFFECTED FILES
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/cmake/FindGLIB2.cmake

To: vkrause, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart