D19631: [sddm-theme/lock screen] Overhaul font sizes

[Filip Fila]

filipf accepted this revision as: filipf.
filipf added a comment.


  If we're not going to be able to change SDDM's default font, this is the 
second best solution.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Filip Fila]

filipf added a comment.


  The checkboxes are right where they're supposed to be, as for their 
visibility: maybe it would be useful if we had a variable that would allow us 
to add a background behind a checkbox.
  
  F6692107: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:e32e12df50d3: [fuzzy-clock] Port configuration window to 
QQC2 and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19747?vs=53893=53927

REVISION DETAIL
  https://phabricator.kde.org/D19747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cef563e560ac: [lock-logout] Port configuration window to 
QQC2 and Kirigami.FormLayout (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19746?vs=53858=53926

REVISION DETAIL
  https://phabricator.kde.org/D19746

AFFECTED FILES
  applets/lock_logout/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19763: [Desktop Theme KCM] Emit current index change when resetting the model

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fa99dfb2fd7a: [Desktop Theme KCM] Emit current index 
change when resetting the model (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19763?vs=53894=53924

REVISION DETAIL
  https://phabricator.kde.org/D19763

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp

To: broulik, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: [Task Manager] Do not crop album art in tooltip

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e8af68ad76bb: [Task Manager] Do not crop album art in 
tooltip (authored by trmdi, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=53884=53903

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks. I can confirm the bug not only here but in the wild in our libinput 
mouse and touchpad KCMs. The workaround seems sane for now.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  Looks amazing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17073: Do not crop albumArt

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Huge improvement. Let's do it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  In D19745#430958 , @ngraham wrote:
  
  > Pretty nice stuff! While you're at it, how about implementing a UI change 
so that while the popup is open, its contents change as you slide the mouse 
along the icons (but only when there's a single row/column)?
  
  
  Only as an optional feature. Will it be usable, though? Anyway, it'll be 
separate pull request. Let me see if I can manage my time. this week.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19763: [Desktop Theme KCM] Emit current index change when resetting the model

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the model is reset, `GridView` invalidates its `currentIndex` resulting 
in no theme being selected.

TEST PLAN
  Installed a new theme via GHNS, "Breeze" was still highlighted as current. 
Before none was highlighted.
  Verified that Apply button isn't erroneously activated

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19763

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  > HInt: Please dont discuss here the Latte case because it creates noise for 
all the reviewers interested in this
  
  Sure thing. Sorry :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17073: Do not crop albumArt

[Michail Vourlakos]

mvourlakos added a comment.


  In D17073#431047 , @rooty wrote:
  
  > P.S. We could also implement this in latte-dock. Not just that, but also 
give latte's ToolTipInstance a makeover (the fonts are really huge).
  
  
  No problem... Concerning Latte, just a side note, we discussed this with 
@trmdi when he initially submitted the first version of this patch for Latte.
  My decision for this is that whatever the official plasma taskmanager 
supports as a design decision the same will be applied to Latte also. I want
  the Latte Preview windows to look the same with plasma taskmanagers one. So 
this patch I think is an effort from @trmdi to update the plasma
  taskmanager previews in order afterwards to apply the same thing to Latte
  
  Again no problem from me, as long as the Latte and plasma taskmanagers have 
same Preview Windows
  
  > Might be worth another patch? I could post my changes or if you want you 
could write your own version :D
  
  no problem, I would propose first to have an acceptance from here and 
afterwards create a new PR for Latte
  
  HInt: Please dont discuss here the Latte case because it creates noise for 
all the reviewers interested in this

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added a comment.


  In D19747#430961 , @ngraham wrote:
  
  > We'll need a bug report on this slider issue if we're gonna work around it, 
at a minimum.
  
  
  Done: https://bugs.kde.org/show_bug.cgi?id=405471

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53893.
filipf added a comment.


  link the bug report for qqc2 slider

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19747?vs=53854=53893

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19747

AFFECTED FILES
  applets/fuzzy-clock/package/contents/ui/configAppearance.qml

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty added a comment.


  P.S. We could also implement this in latte-dock. Not just that, but also give 
latte's ToolTipInstance a makeover (the fonts are really huge).
  I've actually already used this diff to modify latte-dock's ToolTipInstance:
  
  F6691364: image.png 
  
  Might be worth another patch? I could post my changes or if you want you 
could write your own version :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Krešimir Čohar]

rooty accepted this revision as: rooty.
rooty added a comment.


  I normally wouldn't ask this but seeing as my fonts have been acting up, can 
you please post a screenshot? Sorry :D
  
  I'm giving you my +1, if the others decide we shouldn't go ahead with the 
bold (in case it's too bold) then I'm not going to argue, but I do think it's 
worth it
  
  Nice work

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19612: RFC port to bugzilla REST API

[Harald Sitter]

sitter updated this revision to Diff 53889.
sitter added a comment.


  redo diff so it maybe doesn't include nonesense

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19612?vs=53888=53889

BRANCH
  webservice

REVISION DETAIL
  https://phabricator.kde.org/D19612

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/duplicatefinderjob.cpp
  src/bugzillaintegration/duplicatefinderjob.h
  src/bugzillaintegration/libbugzilla/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/attachment.cpp
  src/bugzillaintegration/libbugzilla/attachment.h
  src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp
  src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/error.http
  src/bugzillaintegration/libbugzilla/autotests/data/hi.http
  src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/put.http
  src/bugzillaintegration/libbugzilla/autotests/producttest.cpp
  src/bugzillaintegration/libbugzilla/bug.cpp
  src/bugzillaintegration/libbugzilla/bug.h
  src/bugzillaintegration/libbugzilla/bugzilla.cpp
  src/bugzillaintegration/libbugzilla/bugzilla.h
  src/bugzillaintegration/libbugzilla/comment.cpp
  src/bugzillaintegration/libbugzilla/comment.h
  src/bugzillaintegration/libbugzilla/connection.cpp
  src/bugzillaintegration/libbugzilla/connection.h
  src/bugzillaintegration/libbugzilla/product.cpp
  src/bugzillaintegration/libbugzilla/product.h
  src/bugzillaintegration/parsebugbacktraces.cpp
  src/bugzillaintegration/parsebugbacktraces.h
  src/bugzillaintegration/productmapping.cpp
  src/bugzillaintegration/productmapping.h
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h
  src/bugzillaintegration/reportinterface.cpp
  src/bugzillaintegration/reportinterface.h
  src/drkonqi.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17073: Do not crop albumArt

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ngraham wrote in ToolTipInstance.qml:338
> No need to reduce the opacity here if the song name is bold.

I think that makes it look nicer.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19612: RFC port to bugzilla REST API

[Harald Sitter]

sitter updated this revision to Diff 53888.
sitter added a comment.


  search now searches long description so only get somewhat pertinent bugs come 
back as results. also implement pagniation of results (ie. only 25 results at a 
time are queried, this is both much faster to query and to parse). boths 
somewhat reliant on undocumented features of the webservice api (they are 
however intentional features since they have explicit code in the webservice 
code)

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19612?vs=53669=53888

BRANCH
  webservice

REVISION DETAIL
  https://phabricator.kde.org/D19612

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/duplicatefinderjob.cpp
  src/bugzillaintegration/duplicatefinderjob.h
  src/bugzillaintegration/libbugzilla/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/attachment.cpp
  src/bugzillaintegration/libbugzilla/attachment.h
  src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp
  src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/error.http
  src/bugzillaintegration/libbugzilla/autotests/data/hi.http
  src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/put.http
  src/bugzillaintegration/libbugzilla/autotests/producttest.cpp
  src/bugzillaintegration/libbugzilla/bug.cpp
  src/bugzillaintegration/libbugzilla/bug.h
  src/bugzillaintegration/libbugzilla/bugzilla.cpp
  src/bugzillaintegration/libbugzilla/bugzilla.h
  src/bugzillaintegration/libbugzilla/comment.cpp
  src/bugzillaintegration/libbugzilla/comment.h
  src/bugzillaintegration/libbugzilla/connection.cpp
  src/bugzillaintegration/libbugzilla/connection.h
  src/bugzillaintegration/libbugzilla/product.cpp
  src/bugzillaintegration/libbugzilla/product.h
  src/bugzillaintegration/parsebugbacktraces.cpp
  src/bugzillaintegration/parsebugbacktraces.h
  src/bugzillaintegration/productmapping.cpp
  src/bugzillaintegration/productmapping.h
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h
  src/bugzillaintegration/reportinterface.cpp
  src/bugzillaintegration/reportinterface.h
  src/config-drkonqi.h.cmake
  src/data/debuggers/external/cdbrc
  src/data/debuggers/internal/cdbrc
  src/data/mappings
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/drkonqi.cpp
  src/drkonqibackends.cpp
  src/kdbgwin/CMakeLists.txt
  src/kdbgwin/abstract_generator.h
  src/kdbgwin/kdbgwin_process.cpp
  src/kdbgwin/kdbgwin_process.h
  src/kdbgwin/main.cpp
  src/kdbgwin/mingw_generator.cpp
  src/kdbgwin/msvc_generator.cpp
  src/kdbgwin/process.cpp
  src/kdbgwin/process.h
  src/main.cpp
  src/parser/CMakeLists.txt
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsercdb.cpp
  src/parser/backtraceparsercdb.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Nathaniel Graham]

ngraham added a comment.


  In D19687#429746 , @davidre wrote:
  
  > Anchoring to the whole delegate: F6686885: grafik.png 

  
  
  Yeah that doesn't look great with the Breeze style checkbox. Within the frame 
seems like the way to go, unless we want to take the time to redo Breeze 
checkboxes first. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:338
> +visible: text != ""
> +opacity: 0.75
>  }

No need to reduce the opacity here if the song name is bold.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17073

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

[Tranter Madi]

trmdi updated this revision to Diff 53884.
trmdi added a comment.


  Use `Font.Bold` for the song name.
  (I feel it's a bit too bold though.)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17073?vs=53812=53884

REVISION DETAIL
  https://phabricator.kde.org/D17073

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty
Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19340: Search new knsrc locations

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D19340#430964 , @ngraham wrote:
  
  > Nice. So do we need to change KNS providers/apps to install their files in 
the new location now?
  
  
  We'll need to wait until the next time the CI system gets updated for 
dependencies, otherwise it'll start being all red and angry - same for this 
one, incidentally, as what's there now will already report 5.57, but of course 
won't actually have the function being called... i've got patches under way for 
it all, though, but as we have to wait for the CI anyway, i've not stuck them 
up yet :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19340

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19340: Search new knsrc locations

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice. So do we need to change KNS providers/apps to install their files in 
the new location now?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19340

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Nathaniel Graham]

ngraham added a comment.


  We'll need a bug report on this slider issue if we're gonna work around it, 
at a minimum.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Nathaniel Graham]

ngraham added a comment.


  Pretty nice stuff! While you're at it, how about implementing a UI change so 
that while the popup is open, its contents change as you slide the mouse along 
the icons (but only when there's a single row/column)?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik
Cc: ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  This visual change makes sense to me, +1.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Seems the broken openSUSEdark display was due to cached rendered pixmaps, at 
least I can no longer reproduce it. So for completeness, and do celebrate the 
initial recovery of good old Fluffy Bunny theme, here another After (beware, 
can harm sensitive eyes):
  F6691045: Screenshot_20190314_141444.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19340: Search new knsrc locations

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 53876.
leinir added a comment.


  Update to require 5.57, and also actually inspect the minor version rather 
than two instances of the major version.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19340?vs=52713=53876

REVISION DETAIL
  https://phabricator.kde.org/D19340

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[David Redondo]

davidre updated this revision to Diff 53870.
davidre added a comment.


  Change email address

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19687?vs=53697=53870

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19753: [KSplashQML] Register DBus before loading the splash theme

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Loading the theme and setting everything up can take a while.
  Ensure that we catch all `setStage` calls that might have been emitted before 
we were fully up.
  
  CCBUG: 405444

TEST PLAN
  Sabotaged my ksplash theme to take forever to load, did a qdbus setstage 
call, once ksplash came up and processed the dbus call, the stage immediately 
advanced without any obvious sideeffects

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19753

AFFECTED FILES
  ksplash/ksplashqml/splashapp.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19752: [Splash KCM] Use InlineMessage for testing error

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When testing a splash screen fails, a message box appears. This changes it to 
an `InlineLabel` and also makes process handling asynchronous to not block the 
settings dialog process and instead disables the controls within.

TEST PLAN
  Made a ksplash theme that just froze the splash process, killed it, got this 
error.
  F6690792: Screenshot_20190314_103534.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19752

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19751: [Pager] Shrink label font size dynamically

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:de1c1c93c883: [Pager] Shrink label font size dynamically 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19751?vs=53862=53863

REVISION DETAIL
  https://phabricator.kde.org/D19751

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19751: [Pager] Shrink label font size dynamically

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Tiny font is still more useful than "..."
  
  CCBUG: 405454

TEST PLAN
  Before
  F6690755: Screenshot_20190314_100759.png 

  After
  F6690754: Screenshot_20190314_100735.png 

  
  Perhaps we need an option to horizontally scale the pager?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19751

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

[Kai Uwe Broulik]

broulik added a comment.


  +1 Since there is no "proper" way I think this is fine and also looks a lot 
better than the previous Kraut und Rüben.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19748

To: kossebau, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19744: [taskmanager] Fix desktop file mapping for some apps

[Nicolas Fella]

nicolasfella added a comment.


  I did.
  
  The usual path fails because the Nautilus window announces itself with 
Nautilus/nautilus as appId/wmClass, but the name defined in the desktop file is 
"Files". Other useful entries like StartupWmClass are not set at all. The only 
indication that "Files" actually is nautilus in the desktop file comes from the 
Exec line.
  
  Same applies to Gedit

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19744

To: nicolasfella, #plasma, hein, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19744: [taskmanager] Fix desktop file mapping for some apps

[Kai Uwe Broulik]

broulik added a comment.


  Seems to match Nautilus and GEdit fine here. I have a `nautilus.desktop` and 
`org.gnome.Nautilus.desktop` on my system for some reason and it maps to 
`nautilus.desktop`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19744

To: nicolasfella, #plasma, hein, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19744: [taskmanager] Fix desktop file mapping for some apps

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  Sorry, that's too fast and loose for me.
  
  Let's investigate why Nautilus and GEdit hit this fallback path in the first 
place instead of matching via preferred means?
  Did you investigate by any chance why

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19744

To: nicolasfella, #plasma, hein, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added a comment.


  ^ Ignore that, I was working on an older template.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19746

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf updated this revision to Diff 53858.
filipf added a comment.


  actually fix the "sleep" string

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19746?vs=53853=53858

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19746

AFFECTED FILES
  applets/lock_logout/contents/ui/ConfigGeneral.qml

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Filip Fila]

filipf added a comment.


  Unless I'm doing something wrong, QQC2 Slider seems broken when 
`minimumValue` aka `from` is 1:
  
import QtQuick.Controls 2.5
Slider {
from: 1
to: 5
stepSize: 1
}

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Noah Davis]

ndavis added a comment.


  +1 to this. Fitts' law comes to mind.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik
Cc: ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart