D19687: Allow single images to be excluded from the slideshow

2019-03-23 Thread David Redondo
davidre added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D19994: Add microphone indicator

2019-03-23 Thread Kai Uwe Broulik
broulik added a comment.


  > What happens if 2 applications are using it?
  
  It shows "foo, bar are using the microphone"
  
  > Maybe it would make sense to include the application icon as an overlay?
  
  For the tooltip, maybe.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19994

To: broulik, #plasma, #vdg
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart


D19994: Add microphone indicator

2019-03-23 Thread Aleix Pol Gonzalez
apol added a comment.


  What happens if 2 applications are using it? Maybe it would make sense to 
include the application icon as an overlay?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19994

To: broulik, #plasma, #vdg
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart


D19994: Add microphone indicator

2019-03-23 Thread Aleix Pol Gonzalez
apol added a comment.


  BTW, +1 really cool :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19994

To: broulik, #plasma, #vdg
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart


D19011: Thunderbolt KCM and KDED module

2019-03-23 Thread Daniel Vrátil
dvratil updated this revision to Diff 54625.
dvratil added a comment.


  Remove 'Help', 'Default' and 'Apply' buttons as they serve no purpose here,
  there's no help at the moment, there's no default state to revert to and the
  changes to devices are applied immediately.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19011?vs=53323&id=54625

BRANCH
  arcpatch-D19011

REVISION DETAIL
  https://phabricator.kde.org/D19011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/bolt/CMakeLists.txt
  autotests/bolt/data/default.json
  autotests/bolt/fakeserver/CMakeLists.txt
  autotests/bolt/fakeserver/fakedevice.cpp
  autotests/bolt/fakeserver/fakedevice.h
  autotests/bolt/fakeserver/fakemanager.cpp
  autotests/bolt/fakeserver/fakemanager.h
  autotests/bolt/fakeserver/fakeserver.cpp
  autotests/bolt/fakeserver/fakeserver.h
  autotests/bolt/fakeserver/main.cpp
  autotests/bolt/kded/CMakeLists.txt
  autotests/bolt/kded/kdedtest.cpp
  autotests/bolt/lib/CMakeLists.txt
  autotests/bolt/lib/devicetest.cpp
  autotests/bolt/lib/managertest.cpp
  cmake/modules/FindBolt.cmake
  kcms/CMakeLists.txt
  kcms/bolt/CMakeLists.txt
  kcms/bolt/Messages.sh
  kcms/bolt/kcm_bolt.cpp
  kcms/bolt/kcm_bolt.desktop
  kcms/bolt/kcm_bolt.h
  kcms/bolt/package/contents/ui/DeviceList.qml
  kcms/bolt/package/contents/ui/DeviceView.qml
  kcms/bolt/package/contents/ui/main.qml
  kcms/bolt/package/contents/ui/utils.js
  kcms/bolt/package/metadata.desktop
  kded/CMakeLists.txt
  kded/bolt/CMakeLists.txt
  kded/bolt/kded_bolt.cpp
  kded/bolt/kded_bolt.desktop
  kded/bolt/kded_bolt.h
  kded/bolt/kded_bolt.notifyrc
  kded/bolt/main.cpp
  libs/CMakeLists.txt
  libs/bolt/CMakeLists.txt
  libs/bolt/dbushelper.cpp
  libs/bolt/dbushelper.h
  libs/bolt/device.cpp
  libs/bolt/device.h
  libs/bolt/devicemodel.cpp
  libs/bolt/devicemodel.h
  libs/bolt/enum.cpp
  libs/bolt/enum.h
  libs/bolt/interfaces/org.freedesktop.bolt1.device.xml
  libs/bolt/interfaces/org.freedesktop.bolt1.manager.xml
  libs/bolt/manager.cpp
  libs/bolt/manager.h

To: dvratil, #vdg, #plasma
Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, 
fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart


D19995: Change URLs to https where possible

2019-03-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fc6cdb161516: Change URLs to https where possible 
(authored by vkrause).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19995?vs=54610&id=54624

REVISION DETAIL
  https://phabricator.kde.org/D19995

AFFECTED FILES
  CMakeLists.txt
  HACKING
  applets/icontasks/metadata.desktop
  applets/kickoff/package/metadata.desktop
  applets/taskmanager/package/metadata.desktop
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  doc/kcontrol/keyboard/index.docbook
  doc/kcontrol/spellchecking/index.docbook
  doc/kcontrol/splashscreen/index.docbook
  imports/activitymanager/CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/emoticons/emoticonslist.ui
  kcms/kfontinst/CMakeLists.txt
  kcms/kfontinst/viewpart/download-unicode-files.sh
  knetattach/main.cpp

To: vkrause, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D19997: Change http URLs to https

2019-03-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R845:a73e803a39f3: Change http URLs to https (authored by 
vkrause).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19997?vs=54616&id=54623

REVISION DETAIL
  https://phabricator.kde.org/D19997

AFFECTED FILES
  kded/ui/vaultcreationwizard.cpp
  plasma/package/metadata.desktop

To: vkrause, ivan
Cc: ivan, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

2019-03-23 Thread Luca Carlon
luc4 added a comment.


  Should I do something else or will someone else take care of committing?

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19997: Change http URLs to https

2019-03-23 Thread Ivan Čukić
ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  Accepted, but incomplete ;)

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19997

To: vkrause, ivan
Cc: ivan, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19997: Change http URLs to https

2019-03-23 Thread Volker Krause
vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19997

AFFECTED FILES
  kded/ui/vaultcreationwizard.cpp
  plasma/package/metadata.desktop

To: vkrause
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19995: Change URLs to https where possible

2019-03-23 Thread Yuri Chornoivan
yurchor accepted this revision.
yurchor added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19995

To: vkrause, yurchor
Cc: yurchor, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D19991: FileItem plugin for opening and closing Vaults from Dolphin

2019-03-23 Thread Ivan Čukić
ivan closed this revision.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D19991

To: ivan, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19995: Change URLs to https where possible

2019-03-23 Thread Volker Krause
vkrause created this revision.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Also, update a few outdated or redirecting URLs.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19995

AFFECTED FILES
  CMakeLists.txt
  HACKING
  applets/icontasks/metadata.desktop
  applets/kickoff/package/metadata.desktop
  applets/taskmanager/package/metadata.desktop
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  doc/kcontrol/keyboard/index.docbook
  doc/kcontrol/spellchecking/index.docbook
  doc/kcontrol/splashscreen/index.docbook
  imports/activitymanager/CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/emoticons/emoticonslist.ui
  kcms/kfontinst/CMakeLists.txt
  kcms/kfontinst/viewpart/download-unicode-files.sh
  knetattach/main.cpp

To: vkrause
Cc: plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, 
ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D19991: FileItem plugin for opening and closing Vaults from Dolphin

2019-03-23 Thread Ivan Čukić
ivan updated this revision to Diff 54609.

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19991?vs=54607&id=54609

REVISION DETAIL
  https://phabricator.kde.org/D19991

AFFECTED FILES
  CMakeLists.txt
  fileitemplugin/CMakeLists.txt
  fileitemplugin/plasmavaultfileitemaction.cpp
  fileitemplugin/plasmavaultfileitemaction.h
  fileitemplugin/plasmavaultfileitemaction.json

To: ivan, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19994: Add microphone indicator

2019-03-23 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Shows a System Tray icon when the microphone is being used.
  It also indicates the default microphone volume as well as middle click to 
mute and wheel for adjusting the volume.
  The microphone icon only shows muted when *all* microphones are muted.

TEST PLAN
  F6715292: Screenshot_20190323_140703.png 

  F6715294: Screenshot_20190323_140732.png 

  Tried both alsa and pulseaudio apps, everything I tried ended up spawning an 
indicator.
  Didn't manage to read raw from `/dev/snd/...`

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19994

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/main.qml
  src/CMakeLists.txt
  src/qml/microphoneindicator.cpp
  src/qml/microphoneindicator.h
  src/qml/plugin.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19991: FileItem plugin for opening and closing Vaults from Dolphin

2019-03-23 Thread Ivan Čukić
ivan updated this revision to Diff 54607.

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19991?vs=54599&id=54607

REVISION DETAIL
  https://phabricator.kde.org/D19991

AFFECTED FILES
  CMakeLists.txt
  fileitemplugin/CMakeLists.txt
  fileitemplugin/plasmavaultfileitemaction.cpp
  fileitemplugin/plasmavaultfileitemaction.h
  fileitemplugin/plasmavaultfileitemaction.json

To: ivan, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19991: FileItem plugin for opening and closing Vaults from Dolphin

2019-03-23 Thread Ivan Čukić
ivan created this revision.
ivan added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ivan requested review of this revision.

REVISION SUMMARY
  Adds a context menu item when the user right-clicks a directory that is a 
registered vaults mount point.
  
  BUG:388602

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D19991

AFFECTED FILES
  CMakeLists.txt
  fileitemplugin/CMakeLists.txt
  fileitemplugin/plasmavaultfileitemaction.cpp
  fileitemplugin/plasmavaultfileitemaction.h
  fileitemplugin/plasmavaultfileitemaction.json

To: ivan, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19799: QNetworkReply was not deleted

2019-03-23 Thread Laurent Montel
mlaurent added a comment.


  is it ok now ?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19799

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D19959: Fixed issue causing changed signal to be called with false argument

2019-03-23 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:ed3decc06e38:   Fixed issue causing changed signal to be 
called with false argument (authored by mlaurent).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19959?vs=54521&id=54594

REVISION DETAIL
  https://phabricator.kde.org/D19959

AFFECTED FILES
  src/advanceconfig.cpp

To: tigrang, mlaurent
Cc: mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart