D20035: Set autofocus to child KPluginSelector on UI load

[Jayesh Bhoot]

jayeshbhoot added a comment.


  True. The description isn't quite clear. The 'sibling commit' is this: 
https://phabricator.kde.org/D20034. But at the time of `arc diff`, I didn't 
know how to link to it. So I just linked them both via the BUG tag. Let me know 
what to correct here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20035

To: jayeshbhoot, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20035: Set autofocus to child KPluginSelector on UI load

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch! But what is the sibling commit? The description is not 
quite clear to me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20035

To: jayeshbhoot, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19947: systray: show a small animation on the icons when activated

[Nathaniel Graham]

ngraham added a comment.


  How do I trigger this? I'm not seeing anything happen when I click on a 
System Tray icon with this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19947

To: apol, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19893: [KickerDash] Add missed argument in addFavorite

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:af28e245070e: [KickerDash] Add missed argument in 
addFavorite (authored by trmdi, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19893?vs=54699=54745

REVISION DETAIL
  https://phabricator.kde.org/D19893

AFFECTED FILES
  applets/kicker/plugin/kastatsfavoritesmodel.cpp

To: trmdi, ngraham, hein, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20035: Set autofocus to child KPluginSelector on UI load

[Jayesh Bhoot]

jayeshbhoot created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jayeshbhoot requested review of this revision.

REVISION SUMMARY
  A sibling commit to this commit in frameworks/kcmutils
  passes down the focus to the searchbar in KPluginSelector.
  
  CCBUG: 399516
  BUG: 399516

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix/focus-searchbar-in-plasmasearch-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20035

AFFECTED FILES
  kcms/runners/kcm.cpp

To: jayeshbhoot
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19893: [KickerDash] Add missed argument in addFavorite

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops! Nice catch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19893

To: trmdi, ngraham, hein, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This works great with D19932 . Definitely 
seems like the correct fix. The rest of the code changes look good too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Awesome.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  support-twinLayouts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19932

To: filipf, mart, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20027: Fix initial width/height in KCMs that use qml

[Nathaniel Graham]

ngraham added a comment.


  No, you'll have to do it for @tigrang. You can grab his authorship info from 
what's listed in 
https://cgit.kde.org/dolphin.git/commit/?id=1eaf5d3e0362f8d39655e973bcd29813ae98652b
  
  @tigrang, wanna have a go at also doing this for the bugs listed in the "See 
Also" section in https://bugs.kde.org/show_bug.cgi?id=389585? Looks like 
there's a lot of low-hanging fruit if this is really all it takes!

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20027

To: tigrang, apol
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.xml:99
> +  Whether to mute/unmute applications when the audio streams 
> indicator is clicked.
> +  false
> +

I'd have this on by default.

> ConfigAppearance.qml:80
> +id: audioStreamsMute
> +text: i18n("Mute/unmute applications by clicking on the 
> audio streams indicator")
> +checked: cfg_audioStreamsMute && plasmaPaAvailable

"Allow Tasks to be muted by clicking on their volume indicators" ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Farid Boudedja]

faridb updated this revision to Diff 54735.
faridb added a comment.


  - [Task Manager] Make mute/unmute behaviour configurable
  
  I added the possibility to enable/disable this behaviour in the 
  plasmoid configuration. I added it to the 'Appearance' section even 
  though it's a behaviour. Could you suggest a better wording for the 
  text and for variables names?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=54731=54735

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20027: Fix initial width/height in KCMs that use qml

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense to me. Do you have permissions to land it?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20027

To: tigrang, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19784: Avoid calling QT_LSTAT and accessing recent documents

[David Faure]

dfaure added a comment.


  > If they point to files on a network drive, and the network or the drive is 
not responding
  
  Well that's exactly the problem with network mounts, and the reason they are 
a sucky technical solution.
  KIO's async jobs never have that problem.
  
  You will never be able to remove all uses of synchronous local file APIs in 
all of Qt and KDE-made software -- or IMHO any other large toolkit or 
application.
  
  At best, the kernel should offer better solutions for users to get rid of 
non-responding mounts more easily.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19784: Avoid calling QT_LSTAT and accessing recent documents

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  OK so this is about KFileItem::text() and KFileItem::iconName().
  
  Indeed this doesn't need the stat() done by KFileItem's init(). This means 
the right solution is indeed for KFileItem to do that stat() on demand, and 
this code doesn't need any changes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added a comment.


  Cool! I think the top-right corner would be more appropriate though, as long 
as there's no other badge there. Also, the volume indicator badge shouldn't 
expand the geometry of the item.
  
  In D19822#437687 , @filipf wrote:
  
  > I still think we should make it configurable. We'd want to be able to avoid 
situations with parents or a newbies going something like: "I was 
watching/listening to X and your darn Linux stopped playing sound!".
  
  
  Since we're KDE, then sure, why not. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Filip Fila]

filipf added a comment.


  I still think we should make it configurable. We'd want to be able to avoid 
situations with parents or a newbies going something like: "I was 
watching/listening to X and your darn Linux stopped playing sound!".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Farid Boudedja]

faridb added a comment.


  In D19822#437680 , @ngraham wrote:
  
  > Also, it would be nice if you also work on making the volume indicators 
smaller and always in the corner.
  
  
  This is what it looks like with a small icon in the corner:
  F6718166: Screenshot_20190324_213236.png 

  
  F6718165: Screenshot_20190324_212843.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM. @broulik?
  
  Also, it would be nice if you also work on making the volume indicators 
smaller and always in the corner.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Farid Boudedja]

faridb updated this revision to Diff 54731.
faridb added a comment.


  - [Task Manager] Remove unnecessary braces

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19822?vs=54077=54731

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D20027: Fix initial width/height in KCMs that use qml

[Tigran Gabrielyan]

tigrang added a comment.


  Note: There are modules in other packages that still need to be fixed for bug 
398820 like Workspace settings in plasma-desktop.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20027

To: tigrang
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20027: Fix initial width/height in KCMs that use qml

[Tigran Gabrielyan]

tigrang created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tigrang requested review of this revision.

REVISION SUMMARY
  This change fixes width/height for File Index Manager and Energy Information 
modules.
  
  BUG: 398820

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20027

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml
  Modules/fileindexermonitor/package/contents/ui/main.qml

To: tigrang
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54717.
kdautovic added a comment.


  Use arcanist to get context

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54711=54717

BRANCH
  clipboard

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  ...Or 96 hours. :) Thanks, this looks perfect to me.

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54711.
kdautovic added a comment.


  Change QString to QStringLiteral

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54694=54711

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19893: [KickerDash] Add missed argument in addFavorite

[Tranter Madi]

trmdi added a comment.


  In D19893#437455 , @ngraham wrote:
  
  > Which bug are we fixing? A bit more context would be helpful. :)
  
  
  I can't find any one in the bug tracker, but you can easily reproduce it like 
I said at "Before" in the "Test Plan".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19893

To: trmdi, ngraham, hein, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19893: Fix "Tooltip can not be displayed"

[Nathaniel Graham]

ngraham added a comment.


  Which bug are we fixing? A bit more context would be helpful. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19893

To: trmdi
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19893: Fix "Tooltip can not be displayed"

[Tranter Madi]

trmdi updated this revision to Diff 54699.
trmdi added a comment.


  Change the target of the patch

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19893?vs=54352=54699

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19893

AFFECTED FILES
  applets/kicker/plugin/kastatsfavoritesmodel.cpp

To: trmdi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic added inline comments.

INLINE COMMENTS

> davidedmundson wrote in klipper.cpp:744
>   bIgnoreImages || !data-> ...

But bIgnoreImages is used later in the code, when determining whether to save 
images to history or not. Is it really necessary here? If it's added here then 
we're back to square one because copying screenshots to clipboard won't work 
with the default behavior of Klipper.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> klipper.cpp:744
>  {
> -if( m_bIgnoreImages )
> +if (!data->hasFormat("x-kde-force-image-copy"))
>  return;

bIgnoreImages || !data-> ...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54694.
kdautovic added a comment.


  Formatting.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54692=54694

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic updated this revision to Diff 54692.
kdautovic added a comment.


  Add the "x-kde-force-image-copy" mime type hint.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19852?vs=54239=54692

REVISION DETAIL
  https://phabricator.kde.org/D19852

AFFECTED FILES
  klipper/klipper.cpp

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19752: [Splash KCM] Use InlineMessage for testing error

[Nathaniel Graham]

ngraham added a comment.


  Yeah I agree, this isn't a very actionable error message. What is the user 
supposed to make of it or do next?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19752

To: broulik, #plasma, #vdg, filipf
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I think this makes sense.

INLINE COMMENTS

> Task.qml:505
> +enabled: parent.shown
> +onClicked: { toggleMuted() }
> +}

Don't need braces here

REPOSITORY
  R119 Plasma Desktop

BRANCH
  taskmanager-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham
Cc: filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[frameworks-plasma] [Bug 405819] malformed font in notification panel

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=405819

Nate Graham  changed:

   What|Removed |Added

Version|5.15.3  |5.56.0
Product|kwrited |frameworks-plasma
  Component|general |components
 CC||n...@kde.org
   Assignee|plasma-devel@kde.org|notm...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19959: Fixed issue causing changed signal to be called with false argument

[Nathaniel Graham]

ngraham added a comment.


  @mlaurent you didn't commit with with correct authorship information in the 
git author field. :(

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19959

To: tigrang, mlaurent
Cc: ngraham, mlaurent, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[kwrited] [Bug 405819] New: malformed font in notification panel

[Nayr438]

https://bugs.kde.org/show_bug.cgi?id=405819

Bug ID: 405819
   Summary: malformed font in notification panel
   Product: kwrited
   Version: 5.15.3
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: chrisac...@gmail.com
  Target Milestone: ---

Created attachment 118999
  --> https://bugs.kde.org/attachment.cgi?id=118999=edit
Fonts malformed

SUMMARY


STEPS TO REPRODUCE
Just have more than a couple notifications

OBSERVED RESULT
Font gets malformed

EXPECTED RESULT
Readable font

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon 5.15 User Edition
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.0

ADDITIONAL INFORMATION
Nvidia proprietary 418.43 Driver

-- 
You are receiving this mail because:
You are the assignee for the bug.

D19852: Change default Klipper behavior to accept images

[Karlo Dautović]

kdautovic added a comment.


  Yeah, I'll add the mime hint.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19852: Change default Klipper behavior to accept images

[Nathaniel Graham]

ngraham added a comment.


  @kdautovic are you planning on working on this some more? Looks like we're 
really close!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19852

To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, #plasma_workspaces, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D12055: Remove border around menubars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1 here too. Go ahead and land this!

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  remove-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19931: Explicitly set charset to UTF-8

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the contribution and for your patience!

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Explicitly set charset to UTF-8

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:6a6cc0d55689: Explicitly set charset to UTF-8 (authored by 
luc4, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19931?vs=54514=54681#toc

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19931?vs=54514=54681

REVISION DETAIL
  https://phabricator.kde.org/D19931

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Thank you: "Luca carlon ".

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Nathaniel Graham]

ngraham added a comment.


  I'll commit it for you (sorry for the delay, I was traveling). Can you 
provide your full name and email address so I can land it with proper 
attribution?

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.


  It was suggested to change the model (C++ code? where?) instead.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson, cfeck
Cc: cfeck, mart, broulik, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20014: Update URLs to use https

[Volker Krause]

vkrause created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Also update one URL that no longer works.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20014

AFFECTED FILES
  CMakeLists.txt
  COPYING
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/DummyBackend/DummyResource.cpp
  
libdiscover/backends/KNSBackend/custom/discover_ktexteditor_codesnippets_core.knsrc

To: vkrause
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19799: QNetworkReply was not deleted

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:4adbb68bf405: QNetworkReply was not deleted (authored by 
mlaurent).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19799?vs=54387=54647

REVISION DETAIL
  https://phabricator.kde.org/D19799

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart