D20081: Add readme explaining how kwallet-pam works

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20081

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Filip Fila]

filipf added a comment.


  Just throwing out another possible solution: the PlasmaComponents Highlight 
thingy:
  
  F6747233: Screenshot_20190403_005556.png 

  
  F6747232: Screenshot_20190403_005453.png 

  
  Might be considered too obtrusive though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20081: Add readme explaining how kwallet-pam works

[David Edmundson]

davidedmundson added a comment.


  addressed comments

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D20081

To: davidedmundson, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20081: Add readme explaining how kwallet-pam works

[David Edmundson]

davidedmundson updated this revision to Diff 55320.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.


  update

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20081?vs=54940=55320

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20081

AFFECTED FILES
  README.txt

To: davidedmundson, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  In D19873#442385 , @hein wrote:
  
  > Looks solid to me. Is your concern re vertical spacing still valid?
  
  
  Thanks for having a look. Vertical spacing in wallpaper plugins is now OK, 
but unfortunately the spacing is always too big where the master layout and the 
individual wallpaper plugin meet:
  
  F6747169: image (1)spacing.png 
  
  I tried removing a bunch of items in both files thinking they may be be 
adding to the height of the form, but it didn't seem to help.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20198: Don't lose list position after installing KNS cursor themes

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kcmcursortheme.cpp:466
> +const CursorTheme *theme = selectedIndex().isValid() ? 
> m_proxyModel->theme(selectedIndex()) : nullptr;
> +if(theme) {
> +QString currentTheme = theme->name();

This reads weird: how about:

  if (selectedIndex().isValid()) {
  const CursorTheme* theme = m_proxyModel->theme(selectedIndex());
  ...
  }

> kcmcursortheme.cpp:472
> +}, this);
> +connect(m_model, ::modelReset, action, 
> ::trigger);
> +}

Maybe another solution would be having the model insert/remove instead of 
resetting, although that works too I guess.

> kcmcursortheme.h:150
>  
> +class OneTimeAction : public QObject
> +{

:) this sounds familiar.

Maybe we should keep this in the cpp file? it's only used there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20198

To: leinir, #plasma, ngraham, broulik
Cc: apol, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20218: Don't hardcode default kwallet path

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  ... wow

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20218

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Filip Fila]

filipf added a comment.


  In D19822#442584 , @ngraham wrote:
  
  > Hmm, while the red highlight effect is pretty and distinctive, typically we 
don't telegraph what will happen when clicked using an item's hover effect. 
Though it's more boring and conventional, I would recommend using the typical 
effect. :)
  
  
  There was something bothering me about the effect, and now that you mention 
it this is actually it - it's unconventional, feels a bit out of place.
  
  In D19822#442548 , @faridb wrote:
  
  > I also tried reducing the opacity of the icon, which results in the 
following effect:
  >  F6746972: Mute3.gif 
  
  
  The built-in highlight effect looks really good with dark and colorful icons. 
What happens when you combine it with this opacity approach, how does the 
opacity shift look like when the icon is dark?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

[David Edmundson]

davidedmundson updated this revision to Diff 55319.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.


  updates

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19389?vs=53111=55319

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19389

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace_p.h
  libkworkspace/login1_manager_interface.cpp
  libkworkspace/loginddbustypes.h
  libkworkspace/org.freedesktop.ConsoleKit.Manager.xml
  libkworkspace/org.freedesktop.UPower.xml
  libkworkspace/org.freedesktop.login1.Manager.xml
  libkworkspace/org.freedesktop.login1.Seat.xml
  libkworkspace/org.freedesktop.login1.Session.xml
  libkworkspace/org.freedesktop.login1.User.xml
  libkworkspace/sessionmanagement.cpp
  libkworkspace/sessionmanagement.h
  libkworkspace/sessionmanagementbackend.cpp
  libkworkspace/sessionmanagementbackend.h
  libkworkspace/tests/CMakeLists.txt
  libkworkspace/tests/sessiontest.cpp

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Nathaniel Graham]

ngraham added a comment.


  Hmm, while the red highlight effect is pretty and distinctive, typically we 
don't telegraph what will happen when clicked using an item's hover effect. 
Though it's more boring and conventional, I would recommend using the typical 
effect. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20218: Don't hardcode default kwallet path

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This allows a user to install to a different prefix and have kwallet_pam
  work out the box.

TEST PLAN
  My kwallet_pam now works

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20218

AFFECTED FILES
  CMakeLists.txt
  pam_kwallet.c

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20217: Remove kwallet4 support

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Kwallet5 migrates the old wallet and kdelibs4 code can connect to the
  kwalletd5 daemon.
  
  I can't envision any situation where a person would need to be compiling
  the latest version of this Plasma code without having the KF5 wallet
  runtime.

TEST PLAN
  N/A

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D20217

AFFECTED FILES
  CMakeLists.txt
  pam_kwallet.c
  pam_kwallet_init

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Eike Hein]

hein added a comment.


  About the icon issue, IconItem by default uses the icon theme overlay from 
the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind 
of tricky - with Breeze we could totally make them match, but other Plasma 
themes would have issues.
  
  A long time ago I suggested that the overlay shouldn't be put into IconItem 
in this way, and instead it should be something like IconItem { source: 
OverlayIcon {} } to factor out the overlay stuff and keep IconItem generic. I 
wish we had that now, then it'd just work with Kirigami.Icon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Farid Boudedja]

faridb added a comment.


  The highlight effect provided by `PlasmaCore.IconItem` is only visible when 
used with dark or colourful icons:
  F6746966: Mute5.gif 
  
  F6746965: Mute4.gif 
  
  I also tried reducing the opacity of the icon, which results in the following 
effect:
  F6746972: Mute3.gif 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20213: [kcolorschemeeditor] Use config path instead of searching again

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `m_schemeName` is the translated scheme name which may not match the file 
name.
  Since the config is always opened with an absolute path, we can just use the 
config's name.
  
  BUG: 399951

TEST PLAN
  I'll try putting that into 5.15 (but gonna be tough since the color kcm 
rewrite happened)
  
  - Ran `kcolorschemeeditor "BreezeHighContrast"` tried to upload, it got the 
correct `/usr/share/color-schemes/BreezeHighContrast.colors` path
  - Changed the scheme, saved it under a different name, tried to upload, it 
got the correct `~/.local/share/color-schemes/NewScheme.colors` path

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20213

AFFECTED FILES
  kcms/colors/editor/scmeditordialog.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20205: initialize the kcolorscheme at the first app start

[Eike Hein]

hein added a comment.


  Or the QPA could look at the LnF in the first place instead of kdeglobals?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D20205

To: mart, #plasma
Cc: hein, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20205: initialize the kcolorscheme at the first app start

[David Edmundson]

davidedmundson added a comment.


  The analysis makes sense, I don't understand why this is the correct fix.
  
  Colours aren't the only thing lookandfeel syncs to kdeglobals when set. 
  Is it correct that all of them have a fallback to loading a second config? If 
they do, why does the lnf kcm copy into kdeglobals instead of just deleting the 
kdeglobals entries?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D20205

To: mart, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

GB_2 added subscribers: rooty, filipf, abetts, ndavis.
GB_2 added a comment.


  In D20144#441802 , @ngraham wrote:
  
  > Hmm, the separator line feels like a bit much to me. How about just 
`units.largeSpacing` or `units.gridUnit` between them?
  
  
  This is it without separator, I personally think it looks weird with that 
gap: F6746651: More Obvious Location of Lock Widgets and Remove Panel Buttons 
(Vertical) (No Separator).png 
  Let's see what others think.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Eike Hein]

hein added a comment.


  Looks solid to me. Is your concern re vertical spacing still valid?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20198: Don't lose list position after installing KNS cursor themes

[Nathaniel Graham]

ngraham added a comment.


  Why do we need this do-it-once helper function?

INLINE COMMENTS

> kcmcursortheme.cpp:466
> +const CursorTheme *theme = selectedIndex().isValid() ? 
> m_proxyModel->theme(selectedIndex()) : nullptr;
> +if(theme) {
> +QString currentTheme = theme->name();

Coding style: space between `if` and `(`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20198

To: leinir, #plasma, ngraham, broulik
Cc: plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19077: Redesign the theme preview window

[Marco Martin]

mart added a comment.


  In D19077#422017 , @filipf wrote:
  
  > @mart could you help us out a bit please? I used code with 
"Kirigami.Theme.viewBackgroundColor.r", which throws out a warning that the 
value is deprecated. The one suggested for replacement (Theme.View) isn't the 
same as the deprecated one though. How bad would it be to leave the code with 
the deprecated value?
  
  
  that rectangle should havethe attached property:
  Rectangle {
  
Kirigami.Theme.inherit: false
Kirigami.Theme.colorSet: Kirigami.Theme.View
  
  }
  
  then, anywhere under this item you access Kirigami.Theme.backgroundColor and 
will be the background color of the view, because you defined it to use the 
color set for views.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20205: initialize the kcolorscheme at the first app start

[Marco Martin]

mart updated this revision to Diff 55286.
mart added a comment.


  - revert mistake

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20205?vs=55285=55286

BRANCH
  phab/initializeColors

REVISION DETAIL
  https://phabricator.kde.org/D20205

AFFECTED FILES
  src/platformtheme/khintssettings.cpp
  src/platformtheme/khintssettings.h

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20205: initialize the kcolorscheme at the first app start

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when an app starts when there isn't a kdeglobals yet, it reads from
  the color theme defined in the look package, but it did build only the
  QPalette of the application. any application using KColorScheme directly 
failed to
  get the proper color at startup (e.g. plasmashell, but also any app needing a 
color present in kcolorscheme but not in qpaletter, like activetext, 
negativetext etc)
  
  at the first start, copy over the colors from the scheme file to kdeglobals 
(same code of the kcm)
  that code is not cheap, but should be executed exactly once at the startup of 
the first app on an empty session

TEST PLAN
  started plasma with breezedark as lnf as the only key in /etc/xdg/kdeglobals, 
plasmashell gets the proper breeze dark colors now

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  phab/initializeColors

REVISION DETAIL
  https://phabricator.kde.org/D20205

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/khintssettings.cpp
  src/platformtheme/khintssettings.h

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf added a comment.


  I think it would be good if someone from #plasma 
 could have a look if this is okay, I 
did do a lot of modifications.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 55283.
filipf added a comment.


  .

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=55282=55283

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 55282.
filipf added a comment.


  git...

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=55281=55282

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  dataengines/weather/ions/bbcukmet/ion-bbcukmet.desktop
  kcms/translations/kcm_translations.desktop
  kcms/translations/package/metadata.desktop
  klipper/klipper.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/metadata.desktop
  menu/desktop/kf5-games-kids.directory
  sddm-theme/Main.qml
  sddm-theme/metadata.desktop
  sddm-theme/preview.png
  shell/panelconfigview.cpp
  shell/panelconfigview.h
  shell/panelshadows.cpp
  shell/panelshadows_p.h
  shell/panelview.cpp
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

[Filip Fila]

filipf updated this revision to Diff 55281.
filipf added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19873?vs=54797=55281

BRANCH
  fix-hor-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19873

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  dataengines/weather/ions/bbcukmet/ion-bbcukmet.desktop
  kcms/translations/kcm_translations.desktop
  kcms/translations/package/metadata.desktop
  klipper/klipper.cpp
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/metadata.desktop
  menu/desktop/kf5-games-kids.directory
  sddm-theme/Main.qml
  sddm-theme/metadata.desktop
  sddm-theme/preview.png
  shell/panelconfigview.cpp
  shell/panelconfigview.h
  shell/panelshadows.cpp
  shell/panelshadows_p.h
  shell/panelview.cpp
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20048: [color-wallpaper] Align with the master FormLayout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b40dabdc27e4: [color-wallpaper] Align with the master 
FormLayout (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20048?vs=54791=55279

REVISION DETAIL
  https://phabricator.kde.org/D20048

AFFECTED FILES
  wallpapers/color/contents/ui/config.qml

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19077: Redesign the theme preview window

[Filip Fila]

filipf added a comment.


  In D19077#442288 , @GB_2 wrote:
  
  > I like B too.
  >  BTW, can "Background:" and the background selection button be centered 
like in a form layout?
  
  
  Sure, we could see if that would look better. Since I know you've been doing 
this kind of UI work lately, would you want to continue work on D19209 
?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19077: Redesign the theme preview window

[Björn Feber]

GB_2 added a comment.


  I like B too.
  BTW, can "Background:" and the background selection button be centered like 
in a form layout?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19077: Redesign the theme preview window

[Filip Fila]

filipf added a comment.


  In D19077#442281 , @GB_2 wrote:
  
  > Ping
  
  
  I've been putting this off because we couldn't quite reach consensus on the 
general layout. Putting it to a vote again:
  
  A) simplistic
  F6745779: image.png 
  
  B) diff at its current state
  F6745785: image.png 
  
  FWIW I'm more in favor of B, but it needs to have the "Customize theme" 
heading removed (different patch).
  
  On a minor note @GB_2 , since no senior dev has approved it, the color 
matching hack will probably have to go.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, 
ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D19829: kicker: add option to make root level icons visible

[Björn Feber]

GB_2 added a comment.


  In D19829#432852 , @i.Dark_Templar 
wrote:
  
  > Favorite icons are much larger, it's hard to confuse them with root level 
menu icons. If it's deemed as informational noise, it's disabled by default. 
But in case it's not, it may be enabled if this change is applied. And in my 
opinion it looks more consistent in style with 'modern menu' since 'modern 
menu' has those icons enabled.
  >
  > Edit: and it looks more consistent with menu editor which show those root 
level icons. It looks weird for me when menu editor shows those icons but menu 
does not.
  
  
  I would personally like to have this feature.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19829

To: i.Dark_Templar, hein, #plasma, #vdg
Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19077: Redesign the theme preview window

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D20203: desktoppackage: add "panelMask" property for Panel.qml

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Needs D20202 .
  
  From what I understood, the property "containment" is expected to exist for a 
"views/Panel.qml" root item, at least by the panelview.cpp code. So I would 
hope the same could be said about the "panelMask" property. Is the API/property 
interface of such desktoppackage elements defined somewhere, so this new 
(optional) property could be defined there?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20203

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.15.4.1

[Jonathan Riddell]

A Breeze update to fix the Qt 4 theme

http://download.kde.org/stable/plasma/5.15.4/breeze-5.15.4.1.tar.xz
sha256 9a95fb9c5be7c84164d3ce337d15cad57cdd495fe84e1da8487a463d69293497

http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/breeze/5.15.4_to_5.15.4.1/changes_report.html

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Filip Fila]

filipf resigned from this revision.
filipf added a comment.


  Highlight color is nice, but in my tests I really like having red for the 
muting because it gets the point across that a disabling action will be 
triggered. Therefore the code I have now is:
  
  `color: mouseArea.containsMouse? (task.muted? theme.highlightColor : 
theme.negativeTextColor) : theme.textColor`
  
  Which then ends up looking like:
  
  F6745684: AudioHover 
  
  However there is an inconsistency issue the Kirigami icon brings about (@mart 
perhaps you might know why?). It picks up a different muted icon (code points 
it to the same icon) than IconItem which results in an inconsistency with the 
media applet muted icon:
  
  F6745676: Screenshot_20190402_151328.png 

  
  BTW I'm getting no interference of the color property with Oxygen icons, 
there is no coloring applied to them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20204: Fix always full rect blur mask for panels ignoring shape from Plasma themes

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Plasma themes might define non-full-rect shapes for panels (e.g. round
  borders for panels not filling the whole width/height).
  The old code tells the window manager to blur the full rect of a panel
  window, resulting in unwanted artifacts around the panel shape for
  non-full-rect themed panels.
  With the Panel.qml item of the desktop packages exposing some optional
  "panelMask" property now, we can query for the shape and only use the
  painted area when telling the window manager where to blur behind or
  changing the background contrast.
  This also follows the logic as already applied for dialogs or other window
  elements like tooltips which are rendered using a Plasma theme.

TEST PLAN
  The Oxygen Plasma theme no longer has blurry corners on panel edges.
  Also still works as before when using non-composing window manager.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  getpanelmaskfrompanel

REVISION DETAIL
  https://phabricator.kde.org/D20204

AFFECTED FILES
  shell/panelview.cpp

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi updated this revision to Diff 55277.
atulbi added a comment.


  - Code Cleanup and resolved unexpected behaviour

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20186?vs=55251=55277

BRANCH
  X11Libinput

REVISION DETAIL
  https://phabricator.kde.org/D20186

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/src/backends/x11/synapticstouchpad.h
  kcms/touchpad/src/backends/x11/xlibbackend.cpp
  kcms/touchpad/src/backends/x11/xlibbackend.h
  kcms/touchpad/src/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/src/backends/x11/xlibtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/src/touchpadbackend.h

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20201: Fix build with Qt 4

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:386d3b8ed1e0: Fix build with Qt 4 (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20201?vs=55273=55276

REVISION DETAIL
  https://phabricator.kde.org/D20201

AFFECTED FILES
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma, davidedmundson, fvogt
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20203: desktoppackage: add "panelMask" property for Panel.qml

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows the panel code from plasmashell to know the shape of the panel, as
  useful when defining the area for BlurBehind.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  addpanelmaskproperty

REVISION DETAIL
  https://phabricator.kde.org/D20203

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20201: Fix build with Qt 4

[Vlad Zagorodniy]

zzag updated this revision to Diff 55273.
zzag added a comment.


  merghe paths

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20201?vs=55271=55273

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D20201

AFFECTED FILES
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma, davidedmundson, fvogt
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20201: Fix build with Qt 4

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fvogt wrote in breezewindowmanager.cpp:904
> Please add that to the already existing `#if` above.

Well, for better readability I suggest to keep them both separate.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20201

To: zzag, #plasma, davidedmundson, fvogt
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20201: Fix build with Qt 4

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> breezewindowmanager.cpp:904
>  
> +#if BREEZE_USE_KDE4
> +const QPoint native = position;

Please add that to the already existing `#if` above.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20201

To: zzag, #plasma, davidedmundson, fvogt
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20201: Fix build with Qt 4

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D20201

AFFECTED FILES
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.15.4

[Jonathan Riddell]

Plasma 5.15.4 is now released
https://www.kde.org/announcements/plasma-5.15.4.php

D20155: [SpinBox] Improve mouse wheel behavior

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8f4ac7abc600: [SpinBox] Improve mouse wheel behavior 
(authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20155?vs=55216=55269

REVISION DETAIL
  https://phabricator.kde.org/D20155

AFFECTED FILES
  org.kde.desktop/SpinBox.qml

To: broulik, #plasma, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/13/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 10:22:40 +
 Build duration:
27 min and counting
   CONSOLE OUTPUT
  [...truncated 258 lines...][2019-04-02T10:49:42.022Z] HOME  = '/home/jenkins/'[2019-04-02T10:49:42.022Z] NODE_NAME = 'Docker Swarm-b3bfb75c9e9e'[2019-04-02T10:49:42.022Z] HOST  = 'b3bfb75c9e9e'[2019-04-02T10:49:42.022Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2019-04-02T10:49:42.022Z] JOB_NAME  = 'Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12'[2019-04-02T10:49:42.022Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-04-02T10:49:42.022Z] LIBGL_DEBUG   = 'quiet'[2019-04-02T10:49:42.022Z] HUDSON_HOME   = '/home/production/data'[2019-04-02T10:49:42.022Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-04-02T10:49:42.022Z] PROFILEREAD   = 'true'[2019-04-02T10:49:42.022Z] MAIL  = '/var/mail/jenkins'[2019-04-02T10:49:42.022Z] LESSKEY   = '/etc/lesskey.bin'[2019-04-02T10:49:42.022Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/13/'[2019-04-02T10:49:42.022Z] SHELL = '/bin/bash'[2019-04-02T10:49:42.022Z] STAGE_NAME= 'Configuring Build'[2019-04-02T10:49:42.022Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/'[2019-04-02T10:49:42.022Z] BUILD_DISPLAY_NAME= '#13'[2019-04-02T10:49:42.022Z] XCURSOR_THEME = 'DMZ-Black'[2019-04-02T10:49:42.022Z] SHLVL = '3'[2019-04-02T10:49:42.022Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.12-13'[2019-04-02T10:49:42.022Z] NODE_LABELS   = 'Docker Swarm-b3bfb75c9e9e SUSEQt5.12'[2019-04-02T10:49:42.022Z] LOGNAME   = 'jenkins'[2019-04-02T10:49:42.022Z] JRE_HOME  = '/usr/lib64/jvm/jre'[2019-04-02T10:49:42.022Z] XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'[2019-04-02T10:49:42.022Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-04-02T10:49:42.022Z] JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'[2019-04-02T10:49:42.022Z] G_BROKEN_FILENAMES= '1'[2019-04-02T10:49:42.022Z] HISTSIZE  = '1000'[2019-04-02T10:49:42.022Z] CPU   = 'x86_64'[2019-04-02T10:49:42.022Z] CVS_RSH   = 'ssh'[2019-04-02T10:49:42.022Z] LESSOPEN  = 'lessopen.sh %s'[2019-04-02T10:49:42.022Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-04-02T10:49:42.022Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-04-02T10:49:42.022Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-04-02T10:49:42.022Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-04-02T10:49:42.022Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-04-02T10:49:42.022Z] QT_SELECT = 'qt5'[2019-04-02T10:49:42.022Z] LANG  = 'en_US.UTF-8'[2019-04-02T10:49:42.022Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-04-02T10:49:42.022Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-04-02T10:49:42.022Z] [2019-04-02T10:49:42.022Z] [2019-04-02T10:49:42.022Z] == Commencing Configuration:[2019-04-02T10:49:42.022Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.12"[2019-04-02T10:49:44.369Z] -- The C compiler identification is GNU 8.2.1[2019-04-02T10:49:45.419Z] -- The CXX compiler identification is GNU 8.2.1[2019-04-02T10:49:45.419Z] -- Check for working C compiler: /usr/bin/cc[2019-04-02T10:49:45.419Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-04-02T10:49:45.419Z] -- Detecting C compiler ABI info[2019-04-02T10:49:45.925Z] -- Detecting C compiler ABI info - done[2019-04-02T10:49:45.925Z] -- Detecting C compile features[2019-04-02T10:49:46.426Z] -- Detecting C compile features - done[2019-04-02T10:49:46.426Z] -- Check for working CXX compiler: /usr/bin/c++[2019-04-02T10:49:46.930Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-04-02T10:49:46.930Z] -- Detecting CXX compiler ABI 

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 18 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/18/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 10:22:53 +
 Build duration:
25 min and counting
   CONSOLE OUTPUT
  [...truncated 263 lines...][2019-04-02T10:47:54.921Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-04-02T10:47:54.921Z] LIBGL_DEBUG   = 'quiet'[2019-04-02T10:47:54.921Z] HUDSON_HOME   = '/home/production/data'[2019-04-02T10:47:54.921Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-04-02T10:47:54.921Z] PROFILEREAD   = 'true'[2019-04-02T10:47:54.921Z] MAIL  = '/var/mail/jenkins'[2019-04-02T10:47:54.921Z] LESSKEY   = '/etc/lesskey.bin'[2019-04-02T10:47:54.921Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/18/'[2019-04-02T10:47:54.921Z] SHELL = '/bin/bash'[2019-04-02T10:47:54.921Z] STAGE_NAME= 'Configuring Build'[2019-04-02T10:47:54.921Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/'[2019-04-02T10:47:54.921Z] BUILD_DISPLAY_NAME= '#18'[2019-04-02T10:47:54.921Z] XCURSOR_THEME = 'DMZ-Black'[2019-04-02T10:47:54.921Z] SHLVL = '3'[2019-04-02T10:47:54.921Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 SUSEQt5.12-18'[2019-04-02T10:47:54.921Z] NODE_LABELS   = 'Docker Swarm-af59f7aea549 SUSEQt5.12'[2019-04-02T10:47:54.921Z] LOGNAME   = 'jenkins'[2019-04-02T10:47:54.921Z] JRE_HOME  = '/usr/lib64/jvm/jre'[2019-04-02T10:47:54.921Z] XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'[2019-04-02T10:47:54.921Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-04-02T10:47:54.921Z] JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'[2019-04-02T10:47:54.921Z] G_BROKEN_FILENAMES= '1'[2019-04-02T10:47:54.921Z] HISTSIZE  = '1000'[2019-04-02T10:47:54.921Z] CPU   = 'x86_64'[2019-04-02T10:47:54.921Z] CVS_RSH   = 'ssh'[2019-04-02T10:47:54.921Z] LESSOPEN  = 'lessopen.sh %s'[2019-04-02T10:47:54.921Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-04-02T10:47:54.921Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-04-02T10:47:54.921Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-04-02T10:47:54.921Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-04-02T10:47:54.921Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-04-02T10:47:54.921Z] QT_SELECT = 'qt5'[2019-04-02T10:47:54.921Z] LANG  = 'en_US.UTF-8'[2019-04-02T10:47:54.921Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-04-02T10:47:54.921Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-04-02T10:47:54.921Z] [2019-04-02T10:47:54.921Z] [2019-04-02T10:47:54.921Z] == Commencing Configuration:[2019-04-02T10:47:54.921Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.12"[2019-04-02T10:47:54.921Z] -- The C compiler identification is GNU 8.2.1[2019-04-02T10:47:55.176Z] -- The CXX compiler identification is GNU 8.2.1[2019-04-02T10:47:55.176Z] -- Check for working C compiler: /usr/bin/cc[2019-04-02T10:47:55.176Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-04-02T10:47:55.433Z] -- Detecting C compiler ABI info[2019-04-02T10:47:55.433Z] -- Detecting C compiler ABI info - done[2019-04-02T10:47:55.433Z] -- Detecting C compile features[2019-04-02T10:47:56.795Z] -- Detecting C compile features - done[2019-04-02T10:47:56.795Z] -- Check for working CXX compiler: /usr/bin/c++[2019-04-02T10:47:57.051Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-04-02T10:47:57.051Z] -- Detecting CXX compiler ABI info[2019-04-02T10:47:57.305Z] -- Detecting CXX compiler ABI info - done[2019-04-02T10:47:57.305Z] -- Detecting CXX compile features[2019-04-02T10:47:59.824Z] -- Detecting CXX compile features - done[2019-04-02T10:47:59.824Z] -- Looking for __GLIBC__[2019-04-02T10:48:01.183Z] -- Looking for __GLIBC__ - found[2019-04-02T10:48:01.183Z] -- Performing Test 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/16/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 02 Apr 2019 10:19:42 +
 Build duration:
9 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 191 lines...][2019-04-02T10:29:09.401Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2019-04-02T10:29:09.401Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/display/redirect'[2019-04-02T10:29:09.401Z] MAIL  = '/var/mail/jenkins'[2019-04-02T10:29:09.401Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/16/display/redirect?page=changes'[2019-04-02T10:29:09.401Z] JENKINS_URL   = 'https://build.kde.org/'[2019-04-02T10:29:09.401Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-04-02T10:29:09.401Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.12'[2019-04-02T10:29:09.401Z] HUDSON_HOME   = '/home/production/data'[2019-04-02T10:29:09.401Z] BUILD_ID  = '16'[2019-04-02T10:29:09.401Z] OLDPWD= '/usr/home/jenkins'[2019-04-02T10:29:09.401Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12'[2019-04-02T10:29:09.401Z] _ = '/usr/local/bin/java'[2019-04-02T10:29:09.401Z] TERM  = 'su'[2019-04-02T10:29:09.401Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.12'[2019-04-02T10:29:09.401Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.12-16'[2019-04-02T10:29:09.401Z] BUILD_DISPLAY_NAME= '#16'[2019-04-02T10:29:09.401Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/16/display/redirect'[2019-04-02T10:29:09.401Z] USER  = 'jenkins'[2019-04-02T10:29:09.401Z] HOME  = '/home/jenkins'[2019-04-02T10:29:09.401Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/16/'[2019-04-02T10:29:09.401Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/'[2019-04-02T10:29:09.401Z] HUDSON_URL= 'https://build.kde.org/'[2019-04-02T10:29:09.401Z] SHELL = '/usr/local/bin/bash'[2019-04-02T10:29:09.401Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12'[2019-04-02T10:29:09.401Z] MM_CHARSET= 'UTF-8'[2019-04-02T10:29:09.401Z] STAGE_NAME= 'Configuring Build'[2019-04-02T10:29:09.401Z] NODE_NAME = 'FreeBSD Builder 2'[2019-04-02T10:29:09.401Z] BLOCKSIZE = 'K'[2019-04-02T10:29:09.401Z] EXECUTOR_NUMBER   = '0'[2019-04-02T10:29:09.401Z] SHLVL = '0'[2019-04-02T10:29:09.401Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-04-02T10:29:09.401Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-04-02T10:29:09.401Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-04-02T10:29:09.401Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-04-02T10:29:09.401Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-04-02T10:29:09.401Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-04-02T10:29:09.401Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-04-02T10:29:09.401Z] QT_SELECT = 'qt5'[2019-04-02T10:29:09.401Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-04-02T10:29:09.401Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-04-02T10:29:09.401Z] [2019-04-02T10:29:09.401Z] [2019-04-02T10:29:09.401Z] == Commencing Configuration:[2019-04-02T10:29:09.401Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.12"[2019-04-02T10:29:09.656Z] -- The C compiler identification is Clang 6.0.1[2019-04-02T10:29:09.656Z] -- The CXX compiler identification is Clang 6.0.1[2019-04-02T10:29:09.656Z] -- Check for working C compiler: /usr/bin/cc[2019-04-02T10:29:09.656Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-04-02T10:29:09.656Z] -- 

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/13/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 10:19:42 +
 Build duration:
4 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...][2019-04-02T10:24:18.162Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-04-02T10:24:18.162Z] PWD   = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-04-02T10:24:18.162Z] HUDSON_URL= 'https://build.kde.org/'[2019-04-02T10:24:18.162Z] HOME  = '/home/jenkins/'[2019-04-02T10:24:18.162Z] NODE_NAME = 'Docker Swarm-edec06e6a32c'[2019-04-02T10:24:18.162Z] HOST  = 'edec06e6a32c'[2019-04-02T10:24:18.162Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2019-04-02T10:24:18.162Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-04-02T10:24:18.162Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-04-02T10:24:18.162Z] LIBGL_DEBUG   = 'quiet'[2019-04-02T10:24:18.162Z] HUDSON_HOME   = '/home/production/data'[2019-04-02T10:24:18.162Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-04-02T10:24:18.162Z] PROFILEREAD   = 'true'[2019-04-02T10:24:18.162Z] MAIL  = '/var/mail/jenkins'[2019-04-02T10:24:18.162Z] LESSKEY   = '/etc/lesskey.bin'[2019-04-02T10:24:18.162Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/13/'[2019-04-02T10:24:18.162Z] SHELL = '/bin/bash'[2019-04-02T10:24:18.162Z] STAGE_NAME= 'Configuring Build'[2019-04-02T10:24:18.162Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/'[2019-04-02T10:24:18.162Z] BUILD_DISPLAY_NAME= '#13'[2019-04-02T10:24:18.162Z] XCURSOR_THEME = 'DMZ-Black'[2019-04-02T10:24:18.162Z] SHLVL = '3'[2019-04-02T10:24:18.162Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-13'[2019-04-02T10:24:18.162Z] NODE_LABELS   = 'Docker Swarm-edec06e6a32c SUSEQt5.12'[2019-04-02T10:24:18.162Z] LOGNAME   = 'jenkins'[2019-04-02T10:24:18.162Z] JRE_HOME  = '/usr/lib64/jvm/jre'[2019-04-02T10:24:18.162Z] XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'[2019-04-02T10:24:18.162Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-04-02T10:24:18.162Z] JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'[2019-04-02T10:24:18.162Z] G_BROKEN_FILENAMES= '1'[2019-04-02T10:24:18.162Z] HISTSIZE  = '1000'[2019-04-02T10:24:18.162Z] CPU   = 'x86_64'[2019-04-02T10:24:18.162Z] CVS_RSH   = 'ssh'[2019-04-02T10:24:18.162Z] LESSOPEN  = 'lessopen.sh %s'[2019-04-02T10:24:18.162Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-04-02T10:24:18.162Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-04-02T10:24:18.162Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-04-02T10:24:18.162Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-04-02T10:24:18.162Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-04-02T10:24:18.162Z] QT_SELECT = 'qt5'[2019-04-02T10:24:18.162Z] LANG  = 'en_US.UTF-8'[2019-04-02T10:24:18.162Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-04-02T10:24:18.162Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-04-02T10:24:18.162Z] [2019-04-02T10:24:18.162Z] [2019-04-02T10:24:18.162Z] == Commencing Configuration:[2019-04-02T10:24:18.162Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2019-04-02T10:24:18.162Z] -- The C compiler identification is GNU 8.2.1[2019-04-02T10:24:18.162Z] -- The CXX compiler identification is GNU 8.2.1[2019-04-02T10:24:18.162Z] -- Check for working C compiler: /usr/bin/cc[2019-04-02T10:24:18.663Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-04-02T10:24:18.663Z] -- Detecting C compiler ABI info[2019-04-02T10:24:18.663Z] -- Detecting C compiler ABI 

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/130/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 09:50:41 +
 Build duration:
6 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 2572 lines...][2019-04-02T09:56:11.716Z] [ 33%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/keyboard_config.cpp.o[2019-04-02T09:56:11.716Z] [ 33%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/bindings.cpp.o[2019-04-02T09:56:11.716Z] [ 33%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/layout_tray_icon.cpp.o[2019-04-02T09:56:13.379Z] [ 34%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/layouts_menu.cpp.o[2019-04-02T09:56:14.432Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/x11_helper.cpp.o[2019-04-02T09:56:14.432Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/flags.cpp.o[2019-04-02T09:56:14.432Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/xkb_helper.cpp.o[2019-04-02T09:56:14.432Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/xkb_rules.cpp.o[2019-04-02T09:56:14.934Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/debug.cpp.o[2019-04-02T09:56:15.987Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/xkb_rules.cpp.o[2019-04-02T09:56:17.042Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/flags.cpp.o[2019-04-02T09:56:17.042Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kded_keyboard.dir/kded_keyboard_autogen/mocs_compilation.cpp.o[2019-04-02T09:56:17.042Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/iso_codes.cpp.o[2019-04-02T09:56:17.042Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/kcmmisc.cpp.o[2019-04-02T09:56:19.391Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/bindings.cpp.o[2019-04-02T09:56:19.892Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/geometry_components.cpp.o[2019-04-02T09:56:20.394Z] [ 35%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/geometry_parser.cpp.o[2019-04-02T09:56:20.394Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/kbpreviewframe.cpp.o[2019-04-02T09:56:22.061Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keyboardlayout.cpp.o[2019-04-02T09:56:22.563Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/symbol_parser.cpp.o[2019-04-02T09:56:22.563Z] [ 36%] Linking CXX shared module ../../bin/keyboard.so[2019-04-02T09:56:23.617Z] [ 36%] Built target kded_keyboard[2019-04-02T09:56:23.617Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keyaliases.cpp.o[2019-04-02T09:56:23.617Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keyboardpainter.cpp.o[2019-04-02T09:56:24.722Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysymhelper.cpp.o[2019-04-02T09:56:25.774Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/preview/keysym2ucs.cpp.o[2019-04-02T09:56:26.277Z] [ 36%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/debug.cpp.o[2019-04-02T09:56:26.277Z] [ 37%] Building CXX object kcms/keyboard/CMakeFiles/kcm_keyboard.dir/kcm_keyboard_autogen/mocs_compilation.cpp.o[2019-04-02T09:56:32.397Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/keyboard/preview/geometry_parser.cpp: In instantiation of ���grammar::GeometryParser::GeometryParser() [with Iterator = __gnu_cxx::__normal_iterator >]���:[2019-04-02T09:56:32.397Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/keyboard/preview/geometry_parser.cpp:473:20:   required from here[2019-04-02T09:56:32.397Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/keyboard/preview/geometry_parser.cpp:68:18: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-04-02T09:56:32.397Z]  ignore = (lit("outline") || lit("overlay") || lit("text")) >> *(char_ - lit("};")) >> lit("};")[2019-04-02T09:56:32.397Z]~~~^~~[2019-04-02T09:56:32.397Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/keyboard/preview/geometry_parser.cpp:68:54: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-04-02T09:56:32.397Z]  ignore = (lit("outline") || lit("overlay") || lit("text")) >> *(char_ - lit("};")) >> lit("};")[2019-04-02T09:56:32.397Z]~~~^~~~[2019-04-02T09:56:32.397Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/keyboard/preview/geometry_parser.cpp:68:80: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant][2019-04-02T09:56:32.397Z]

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Marco Martin]

mart added a comment.


  In D19822#442125 , @hein wrote:
  
  > I'd say let's go with Kirigami.Icon for now then, and recolor the icon to 
the highlight color on hover. @faridb could you take a stab at that? :)
  
  
  one important thing, it should be an icon ending with -symbolic, as otherwise 
coloring would destroy badly e.g. an oxygen icon.
  (i'm not sure breeze has symbolic icons for the speakers?)
  
  it should be Kirigami.Icon {
  
isMark: true
icon.name: ...
icon.color: hover condition ? theme.highlightColor : theme.textColor
  
  }

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20198: Don't lose list position after installing KNS cursor themes

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Plasma, ngraham.
leinir added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  When installing a new cursor theme from KNewStuff, the current theme would 
become deselected due to a full refresh of the theme list.
  
  This also introduces a simple convenience helper originally from Discover, 
which simply runs a function based on a signal being fired, and then deletes 
itself. This might be useful elsewhere as well, but until the need arises it 
seems reasonable to leave it here.
  
  BUG:406084

TEST PLAN
  Install a theme using Get Hot New Stuff, see that after the list refreshes, 
the current theme is reselected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20198

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/xcursor/thememodel.cpp

To: leinir, #plasma, ngraham
Cc: plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 184 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/184/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 02 Apr 2019 09:50:40 +
 Build duration:
2 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 2522 lines...][2019-04-02T09:52:46.083Z] m_package = Plasma::PluginLoader::self()->loadPackage(QStringLiteral("Plasma/LookAndFeel"));[2019-04-02T09:52:46.083Z]   ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/pluginloader.h:156:5: note: 'loadPackage' has been explicitly marked deprecated here[2019-04-02T09:52:46.083Z] PLASMA_DEPRECATED Package loadPackage(const QString , const QString  = QString());[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-04-02T09:52:46.083Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12/kcms/ksplash/kcm.cpp:147:15: warning: 'operator=' is deprecated [-Wdeprecated-declarations][2019-04-02T09:52:46.083Z] m_package = Plasma::PluginLoader::self()->loadPackage(QStringLiteral("Plasma/LookAndFeel"));[2019-04-02T09:52:46.083Z]   ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/package.h:115:5: note: 'operator=' has been explicitly marked deprecated here[2019-04-02T09:52:46.083Z] PLASMA_DEPRECATED Package =(const Package );[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-04-02T09:52:46.083Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12/kcms/ksplash/kcm.cpp:151:19: warning: 'setPath' is deprecated [-Wdeprecated-declarations][2019-04-02T09:52:46.083Z] m_package.setPath(packageName);[2019-04-02T09:52:46.083Z]   ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/package.h:135:5: note: 'setPath' has been explicitly marked deprecated here[2019-04-02T09:52:46.083Z] PLASMA_DEPRECATED void setPath(const QString );[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-04-02T09:52:46.083Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12/kcms/ksplash/kcm.cpp:156:35: warning: 'metadata' is deprecated [-Wdeprecated-declarations][2019-04-02T09:52:46.083Z] currentPlugin = m_package.metadata().pluginName();[2019-04-02T09:52:46.083Z]   ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/package.h:206:5: note: 'metadata' has been explicitly marked deprecated here[2019-04-02T09:52:46.083Z] PLASMA_DEPRECATED KPluginInfo metadata() const;[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-04-02T09:52:46.083Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12/kcms/ksplash/kcm.cpp:182:20: warning: 'metadata' is deprecated [-Wdeprecated-declarations][2019-04-02T09:52:46.083Z] if (!m_package.metadata().isValid()) {[2019-04-02T09:52:46.083Z]^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/package.h:206:5: note: 'metadata' has been explicitly marked deprecated here[2019-04-02T09:52:46.083Z] PLASMA_DEPRECATED KPluginInfo metadata() const;[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/install-prefix/include/KF5/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-04-02T09:52:46.083Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-04-02T09:52:46.083Z] ^[2019-04-02T09:52:46.083Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.12/kcms/ksplash/kcm.cpp:185:33: warning: 'metadata' is deprecated [-Wdeprecated-declarations][2019-04-02T09:52:46.083Z] 

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Eike Hein]

hein added a comment.


  I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the 
highlight color on hover. @faridb could you take a stab at that? :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19857: [DownloadJob] Report total size only if known

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  Additionally, the `bytesReceived > totalAmount` case is currently not handled 
at all, but I'm not sure whether that's something for `KJob` or here.

INLINE COMMENTS

> downloadjob.cpp:111
>  if (it != end) {
> -setTotalAmount(Bytes, it->toDouble());
> +const auto totalAmount = it->toDouble();
> +if (totalAmount > -1) {

To avoid casting and rounding errors later on, I suggest to use `const 
qlonglong totalAmount = it->toDouble();` here.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19857

To: broulik, #plasma, fvogt
Cc: fvogt, bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18979: foldermodel: store information about screen used

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dcb4c158b414: foldermodel: store information about screen 
used (authored by McPain, committed by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18979?vs=51582=55262

REVISION DETAIL
  https://phabricator.kde.org/D18979

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: McPain, broulik, hein, #plasma
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: CI system maintainability

[Ben Cooksley]

On Sat, Mar 30, 2019 at 10:46 PM Volker Krause  wrote:
>
> On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote:
> > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl
> > > I fear that a mandatory reviews would add too juch strain on smaller
> > > teams. If there's just one person with an intimate knowledge of the
> > > code-base, plus two co-developers, then who should do the reviews?
> > >
> > > How about a distinction based on importance of a project instead? I.e.
> > > mandatory reviews for frameworks and any app that wants to be included in
> > > KDE apps releases. Non-mandatory reviews can then also come with a
> > > "price" to pay: if CI errors are not dealt with in a timely manner, you
> > > should be free to disable the CI for administrative reasons...
> > While this does seem like a nice solution, unfortunately for many
> > repositories it isn't a case of disabling CI coverage for it, but also
> > CI coverage for everything that depends on it. In the case of
> > KContacts, this would also impact on parts of Extragear and Calligra
> > (who depending on their exact requirements would either lose a
> > dependency being available, or lose all of their CI coverage).
> >
> > This is why i've not pursued this as an option in the past, because
> > it's not fair on other projects that don't have anything to do with
> > another project aside from being a user of it's interfaces to lose
> > their coverage, simply because the project they depend on is broken.
>
> I agree that anything on the CI level would be merely a workaround for this at
> best. I'd rather suggest we address this at the source by turning the
> externally used modules into frameworks. We did that last year already for
> KHolidays and Syndication who were used by Plasma among others. KContacts,
> KCalCore and KMime should follow that next IMHO.
>
> The next time window to do that relatively painlessly is coming up after the
> 19.04 applications release I think, and all of those have been part of the
> KDE4-era kdepimlibs module that complied with KF5-like ABI guarantees, so the
> necessary work should be limited hopefully. Extra review of the public
> interfaces would certainly help with making this happen I think.

This would certainly help resolve many of the issues I think, because
then the build issues should be mostly contained to one specific
Product, which makes this much easier to work with in the long term.

>
> Regards,
> Volker

Cheers,
Ben

D18979: foldermodel: store information about screen used

[Eike Hein]

hein added a comment.


  I checked the database and it looks like you don't have a developer account 
yet, so I'll land this patch for you. If you keep submitting patches, feel free 
to apply for a developer account via identity.kde.org at some point :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, hein, #plasma
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Marco Martin]

mart added a comment.


  In D19822#439167 , @hein wrote:
  
  > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add 
a small feature and need to immediately add a checkbox to disable it, it's 
rather a red flag to me. It means either the feature or the checkbox should 
probably go. Firefox gets away without the option BTW.
  
  
  i quite like it in firefox, i do see other people mistakenly clicking on the 
speaker icon instead of the tab and getting confused tough

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Rajeesh K Nambiar]

knambiar added a comment.


  > Got to Know a lot about how X works with input handling. XD
  
  I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more 
than happy to hand that hat over if you wish to maintain this code. :-D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Marco Martin]

mart added a comment.


  In D19822#437687 , @filipf wrote:
  
  > I still think we should make it configurable. We'd want to be able to avoid 
situations with parents or a newbies going something like: "I was 
watching/listening to X and your darn Linux stopped playing sound!".
  
  
  bad idea. If it is indeed confusing, the feature shouldn't be there 
altogether.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Marco Martin]

mart added a comment.


  In D19822#437684 , @faridb wrote:
  
  > In D19822#437680 , @ngraham 
wrote:
  >
  > > Also, it would be nice if you also work on making the volume indicators 
smaller and always in the corner.
  >
  >
  > This is what it looks like with a small icon in the corner:
  >  F6718166: Screenshot_20190324_213236.png 

  >
  > F6718165: Screenshot_20190324_212843.png 

  
  
  for the icon only taskmanager this way is way better

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

[Marco Martin]

mart added a comment.


  In D19822#439297 , @hein wrote:
  
  > A possible improvement to make here is to make the indicator visually react 
to hover by recoloring the icon, to teach that it's seperately interactive and 
will do something different than clicking elsewhere on the task button, so 
users get habituated not to click it accidentally. This should probably be done 
anyway (we're usally pretty triggerhappy on the hover feedback).
  
  
  If you want to recolor it dramatically indeed you would have to use 
kirigami.Icon (or add the same feature to iconitem, which is also fine)
  you would need to recolor both states, normal and hover, otherwise the normal 
state may be recolored the wrong color (in cases when the plasma theme doesn't 
follow system palette)
  
  alternatively to use the standard mouseover effect, it can use the builtin 
highlight effect in iconitem made with kiconeffect (maybe if is too light, the 
default highlight effect in kiconeffects has to be reconsidered?)
  
  weight-wise, kirigami.icon should be slightly ligher (eh, not too much :p) 
than iconitem and would like in the future (kf6?) to just have that one instead 
of the duplication plasmacore.iconitem and kirigami.icon

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19822

To: faridb, #plasma, #vdg, ngraham, filipf, hein
Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D18979: foldermodel: store information about screen used

[Oleg Solovyov]

McPain added a comment.


  In D18979#441799 , @hein wrote:
  
  > Thanks! Do you need help landing this?
  
  
  Any instructions about "how to commit an accepted revision?"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18979

To: McPain, broulik, hein, #plasma
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart