D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:60181eca4414: [Kickoff] Make the tabbar separator width 
consistent with tab selection line (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20676?vs=56570=56572

REVISION DETAIL
  https://phabricator.kde.org/D20676

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20675: LoadingPage: Use Kirigami.Heading

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f061345ad6fe: LoadingPage: Use Kirigami.Heading (authored 
by jbbgameich).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20675?vs=56565=56568

REVISION DETAIL
  https://phabricator.kde.org/D20675

AFFECTED FILES
  discover/qml/LoadingPage.qml

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20675: LoadingPage: Use Kirigami.Heading

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  And we also need to give this page a spinner, just like the Updates page has.

REPOSITORY
  R134 Discover Software Store

BRANCH
  loading-kirigami-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20675

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20674: Word wrap "No backends found" error message

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:4d644303be08: Word wrap No backends found 
error message (authored by jbbgameich).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20674?vs=56564=56566

REVISION DETAIL
  https://phabricator.kde.org/D20674

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: jbbgameich, #discover_software_store, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20675: LoadingPage: Use Kirigami.Heading

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Unifies the look of the loading message with the other messages in discover.

TEST PLAN
  Font size is correct when installing a package e.g from a flatpak ref.

REPOSITORY
  R134 Discover Software Store

BRANCH
  loading-kirigami-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20675

AFFECTED FILES
  discover/qml/LoadingPage.qml

To: jbbgameich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20313: Hook up the main form layout with child form layouts

[Filip Fila]

filipf added a comment.


  I'll land this tomorrow night since it's a prerequisite for fixing the PoTD 
plugin.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hook-main-and-child-layouts-up (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20313

To: filipf, #plasma, ngraham, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Nathaniel Graham]

ngraham updated this revision to Diff 56561.
ngraham added a comment.


  largeSpacing -> smallSpacing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20612?vs=56550=56561

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

AFFECTED FILES
  applets/kickoff/package/contents/config/config.qml
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in ConfigButtons.qml:29
> maybe `units.smallSpacing` would be enough, what do you think?

Yeah, good call

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ConfigButtons.qml:29
>  
> -cellHeight: units.gridUnit * 5
> +cellHeight: units.gridUnit * 6 + units.largeSpacing
>  cellWidth: units.gridUnit * 6

maybe `units.smallSpacing` would be enough, what do you think?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Nice! The last label is getting cut off for me with the default window size, 
but not sure what could be done about it.
  
  F6780515: image.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Squeaky Pancakes]

squeakypancakes added a comment.


  Could we just group them like we do on the devices tab?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D19011: Thunderbolt KCM and KDED module

[Nathaniel Graham]

ngraham added a comment.


  Submit it in a patch to breeze-icons! :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, 
abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, 
plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D17105: Add a new lookandfeel runner

[Nathaniel Graham]

ngraham added a comment.


  In D17105#452140 , @apol wrote:
  
  > Maybe what would make sense is to define an alternative Look and Feel theme 
for every theme, and have Breeze dark point at Breeze and vice-versa. This 
could then be easily toggled then from a keyboard or using fancy hardware.
  
  
  Stepping back, the primary (only?) use case here is defining a dark variant 
of a given color scheme or Plasma theme. I wonder if instead we should 
institutionalize this and instead allow each color scheme and Plasma theme to 
define a Dark variant.
  
  Then switching from light to dark and vice versa wouldn't involve switching 
between two different and unrelated color schemes or Plasma themes (e.g. Breeze 
and Breeze Dark); instead you would tell your current color scheme and Plasma 
theme to display their dark versions. Then we could fairly easily have a single 
place in the UI to switch between light and dark modes that would persist no 
matter which Plasma theme or color scheme you happen to be using, and that 
single place to change it could be scriptable or configurable to automatically 
change at different times of day.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17105

To: apol, #plasma
Cc: kossebau, ngraham, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19011: Thunderbolt KCM and KDED module

[Yuri Chornoivan]

yurchor added a comment.


  It might be not very stylish but just to make the whole thing work...
  F6780264: preferences-desktop-thunderbolt.svg 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, 
abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, 
plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20645: process: add NoNewPrivileges

[Topi Miettinen]

topimiettinen updated this revision to Diff 56551.
topimiettinen added a comment.


  Updated per comments from @davidedmundson.

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20645?vs=56475=56551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20645

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [RFC] [Kickoff] Modernize settings window layout

[Nathaniel Graham]

ngraham updated this revision to Diff 56550.
ngraham added a comment.


  - Fix button height issue
  - Add padding between sections
  - Add vertical spacing between button categories
  - Rename to "General" and use appropriate icon

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20612?vs=56458=56550

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

AFFECTED FILES
  applets/kickoff/package/contents/config/config.qml
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

To: ngraham, #plasma, #vdg
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [RFC] [Kickoff] Modernize settings window layout

[Filip Fila]

filipf added a comment.


  Some other comments:
  
  - it's not correct for the configuration category to be called Appearance; we 
have behavior checkboxes present -> we can just call the category "General"
  - we need to add `isSection` spacing underneath the icon -> looks different 
in my screenshot than in the test plan for some reason:
  
  F6780034: image.png 
  
  - the Kirigami headings for config buttons could use some vertical padding IMO

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [RFC] [Kickoff] Modernize settings window layout

[Filip Fila]

filipf added a comment.


  In D20612#452054 , @GB_2 wrote:
  
  > In D20612#451981 , @ngraham 
wrote:
  >
  > > Use `onPressed` And `Layout.preferredHeight` (still doesn't fix the 
button height though)
  >
  >
  > Just use `implicitWidth` and `implicitHeight`.
  
  
  +1 this fixes the button
  
  F6779950: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9b24060c632e: [MPRIS Data Engine] Avoid blocking calls 
when changing volume (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20661?vs=56519=56528

REVISION DETAIL
  https://phabricator.kde.org/D20661

AFFECTED FILES
  dataengines/mpris2/playercontrol.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids plasmashell freezing when the player app is unresponsive or has a 
broken MPRIS implementation

TEST PLAN
  `kill -SIGSTOP `pidof vlc`, wheeled the tray icon, plasmashell didn't freeze 
anymore.
  Quickly changing volume still works (hence setting the new value in the 
dataengine right away)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20661

AFFECTED FILES
  dataengines/mpris2/playercontrol.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20651: Support default action, priority hints, set desktop-entry

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Works for me. I tested both like the default action and urgency.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20651

To: broulik, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20645: process: add NoNewPrivileges

[David Edmundson]

davidedmundson added a comment.


  FYI, you can update an old phabricator request with new changes. Arc should 
should do it automatically if the phabricator line is in the commit message.
  
  We've now set the change flag, but I would still expect a line around 
processmodel.cpp:750
  
if(process->changes() & KSysGuard::Process::Status) {
 totalUpdated++;
 QModelIndex index = q->createIndex(row, 
ProcessModel::HeadingNoNewPrivileges process);
 emit q->dataChanged(index, index);
 }

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20645

To: topimiettinen
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20635: Show Vaults action only for local folders

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:b553905222dc: Show Vaults action only for local folders 
(authored by broulik).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20635?vs=56442=56497

REVISION DETAIL
  https://phabricator.kde.org/D20635

AFFECTED FILES
  fileitemplugin/plasmavaultfileitemaction.cpp

To: broulik, ivan, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20651: Support default action, priority hints, set desktop-entry

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This adds support for default actions and priority hints, both of which we 
support in `KNotification` these days.
  Also send along the `desktop-entry` of the issuing application so the 
notification server can identify where the notification is actually coming from.

TEST PLAN
  Tested with Konversation flatpak, now got org.kde.konversation as 
desktop-entry
  Didn't test the default action or priority stuff as I couldn't figure out how 
to build that portal tester with more recent frameworks
  Depends on D20158 
  This uses Frameworks 5.58 APIs which isn't released yet but Plasma 5.16 will 
depend on

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20651

AFFECTED FILES
  src/notification.cpp

To: broulik, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  Not a huge fan of this giant gap tbh

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Méven Car]

meven added a comment.


  In D15418#452214 , @meven wrote:
  
  > In D15418#364811 , @mart wrote:
  >
  > > In D15418#331397 , @ngraham 
wrote:
  > >
  > > > Maybe something like this?
  > > >
  > > > F6283615: Screenshot_20180924_195355.png 

  > >
  > >
  > > I like this way
  >
  >
  > Friendly ping ;)
  
  
  I could take over @broulik if you'd prefer.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Méven Car]

meven added a comment.


  In D15418#364811 , @mart wrote:
  
  > In D15418#331397 , @ngraham 
wrote:
  >
  > > Maybe something like this?
  > >
  > > F6283615: Screenshot_20180924_195355.png 

  >
  >
  > I like this way
  
  
  Friendly ping ;)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol