D20859: Crash in sddmthemeinstaller invalid use of errorString

[Anthony Fieroni]

anthonyfieroni added a comment.


  That's maybe KAuth bug or KCoreAddons one, when job fails it should have 
errorString. Also check jobs does not delete itself.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D20859

To: johngehrig, ngraham
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> ProcessList.c:420-421
> +if ( buf[0] == '0' && buf[1] == ':' && buf[2] == ':' ) {
> +  while (buf[strlen(buf) - 1] == '\n')
> +buf[strlen(buf) - 1] = '\0'; /* trim trailing newlines */
> +  ps->cGroup = strdup( &buf[3] );

for (int i = strlen(buf) - 1; buf[i] == '\n'; i++)
  buf[i] = '\0';

> ProcessList.c:422
> +buf[strlen(buf) - 1] = '\0'; /* trim trailing newlines */
> +  ps->cGroup = strdup( &buf[3] );
> +}

strdup allocates memory i don't see where you free it.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20786

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20859: Crash in sddmthemeinstaller invalid use of errorString

[John Gehrig]

johngehrig added a comment.


  It looks like my alternate error "unknown error" isn't showing up in the 
dialog... So this isn't quite right yet.
  
  I will fix this together with any other feedback. The segfault does appears 
to be resolved.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D20859

To: johngehrig, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Noah Davis]

ndavis added a comment.


  In D20851#456931 , @ngraham wrote:
  
  > [...] In the first screenshot you can see that the number "1" is actually 
almost invisible. I'm open to suggestions for alternative ways to improve this.
  
  
  Yes, but this is because the text is under the blue highlight. I bet if the 
text was on top, then it would be much easier to read.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20854: process: show SELinux context

[Topi Miettinen]

topimiettinen added a comment.


  F6795665: Screenshot_fedora.png  Fedora 
with SELinux

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20854

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

[Topi Miettinen]

topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

[Topi Miettinen]

topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R106 KSysguard

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

[Topi Miettinen]

topimiettinen updated this revision to Diff 57070.
topimiettinen added a comment.


  trim trailing newlines

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=56890&id=57070

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

[Topi Miettinen]

topimiettinen updated this revision to Diff 57069.
topimiettinen added a comment.


  fix copy-pasta

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57068&id=57069

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20851: [Pager] Improve label legibility

[Filip Fila]

filipf added a comment.


  An outline could work, but maybe not at 100% opacity.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456936 , @ngraham wrote:
  
  > In D20851#456932 , @abetts wrote:
  >
  > > I agree with this too. Do you think it would be too weird of other 
methods are used? For example:
  > >
  > > - Use a more legible font that is independent from system font
  > > - Use current system font 1 or 2 points bigger
  >
  >
  > I don't think those would help. A part of the problem is that the label 
isn't on top; other things are on top of it. Just moving it to the top would 
help, The other part of the problem is that we need some way to ensure that the 
text has contrast with its background. It's a variant of the exact same problem 
we always have when we have text or icons floating on top of an arbitrary 
background. Every time we encounter this, the only feasible solution we have 
ever found is to give the text a background or a shadow.
  
  
  Can we try a non-blurred shadow instead? One that is offset by 1 px? that 
might help too. I think when we use blurred, it gets messy at those sizes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham added a comment.


  In D20851#456932 , @abetts wrote:
  
  > I agree with this too. Do you think it would be too weird of other methods 
are used? For example:
  >
  > - Use a more legible font that is independent from system font
  > - Use current system font 1 or 2 points bigger
  
  
  I don't think those would help. A part of the problem is that the label isn't 
on top; other things are on top of it. Just moving it to the top would help, 
The other part of the problem is that we need some way to ensure that the text 
has contrast with its background. It's a variant of the exact same problem we 
always have when we have text or icons floating on top of an arbitrary 
background. Every time we encounter this, the only feasible solution we have 
ever found is to give the text a background or a shadow.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456931 , @ngraham wrote:
  
  > Well, I find it almost impossible to read the text with the status quo 
version when there are a bunch of window outlines. In the first screenshot you 
can see that the number "1" is actually almost invisible. I'm open to 
suggestions for alternative ways to improve this.
  
  
  I agree with this too. Do you think it would be too weird of other methods 
are used? For example:
  
  - Use a more legible font that is independent from system font
  - Use current system font 1 or 2 points bigger

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham added a comment.


  Well, I find it almost impossible to read the text with the status quo 
version when there are a bunch of window outlines. In the first screenshot you 
can see that the number "1" is actually almost invisible. I'm open to 
suggestions for alternative ways to improve this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20787: process: add support for cgroups

[Topi Miettinen]

topimiettinen added a comment.


  F6795486: screenshot3.png  Looks much 
better!

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20787: process: add support for cgroups

[Topi Miettinen]

topimiettinen updated this revision to Diff 57068.
topimiettinen added a comment.


  phabricate only one git commit, sorry

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57067&id=57068

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20787: process: add support for cgroups

[Topi Miettinen]

topimiettinen updated this revision to Diff 57067.
topimiettinen added a comment.


  Trim trailing newline for proper vertical alignment

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=56908&id=57067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20585: [FormLayout] Use even top and bottom spacing for separator

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.


  This looks okay to me, but wait for @mart. :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D20585

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

[Filip Fila]

filipf updated this revision to Diff 57065.
filipf added a comment.


  OK I solved it, but not sure if there isn't a better way

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20585?vs=56330&id=57065

BRANCH
  even-separator-spacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20585

AFFECTED FILES
  src/controls/FormLayout.qml
  src/controls/Separator.qml

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456903 , @ndavis wrote:
  
  > To me, the white text with the shadows doesn't really improve legibility 
and just looks "off". For some reason, shadow behind small text messes with my 
eyes and makes it harder to focus on the actual text.
  
  
  I agree.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Noah Davis]

ndavis added a comment.


  To me, the white text with the shadows doesn't really improve legibility and 
just looks "off"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, when displaying pager labels (either number or name), text 
legibility is
  often poor or even non-existent, because the label is drawn below things that 
can
  and frequently do obscure it.
  
  This patch puts the label on top and gives it a drop shadow so it's always 
legible.

TEST PLAN
  Before, displaying VD/Activity number: F6795368: Before, numbers.png 

  
  After, displaying VD/Activity number: F6795362: After, numbers.png 

  
  Before, displaying VD/Activity name: F6795367: Before, names.png 

  
  After, displaying VD/Activity name: F6795363: After, names.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-pager-label-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20851

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20849: [aboutpage] hide Authors header if there are no authors

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  author

REVISION DETAIL
  https://phabricator.kde.org/D20849

AFFECTED FILES
  src/controls/AboutPage.qml

To: nicolasfella, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20820: Add Show Desktop applet to default panel

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4d3bfe3c0d31: Add Show Desktop applet to default panel 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20820?vs=57059&id=57060

REVISION DETAIL
  https://phabricator.kde.org/D20820

AFFECTED FILES
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20820: Add Show Desktop applet to default panel

[Björn Feber]

GB_2 updated this revision to Diff 57059.
GB_2 added a comment.


  Fix diff

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20820?vs=56976&id=57059

BRANCH
  add-showdesktop-applet-to-default-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20820

AFFECTED FILES
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:00cd377ecc57: Remove the Show Desktop applet (it's 
in plasma-desktop now) (authored by GB_2).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20817?vs=57039&id=57058

REVISION DETAIL
  https://phabricator.kde.org/D20817

AFFECTED FILES
  applets/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/Messages.sh
  applets/minimizeall/package/contents/config/main.xml
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b6d785370d53: Add the Show Desktop applet (moved from 
kdeplasma-addons) (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20818?vs=57040&id=57057

REVISION DETAIL
  https://phabricator.kde.org/D20818

AFFECTED FILES
  applets/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/Messages.sh
  applets/minimizeall/package/contents/config/main.xml
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D18645: BasicListItem: use specified tint color when transparency is 0

[Paweł Wegner]

pwegner added a comment.


  Sorry for not creating a bug report..
  
  Your build issue might be caused by pkg-config not being able to find moc.
  You might have to set PKG_CONFIG_LIBDIR / PKG_CONFIG_PATH accordingly.
  
  Here is the logic for detecting where moc is: 
https://github.com/lemourin/libcloudstorage/blob/master/configure.ac#L187
  It works when I set 
PKG_CONFIG_LIBDIR=/home/lemourin/.qt/5.12.1/gcc_64/lib/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/share/pkgconfig
  I have qt installed from qt website through their maintenance tool.
  
  You might find this useful: 
https://github.com/lemourin/libcloudstorage/blob/master/packaging/appimage/create-appimage.sh#L53
  
  I suggest running make in the root of your build directory.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D18645: BasicListItem: use specified tint color when transparency is 0

[Marco Martin]

mart added a comment.


  In D18645#456718 , @pwegner wrote:
  
  > 
https://github.com/KDE/kirigami/commit/c0f2a341a4c9e947cbb2ca914ba36a31728b05c4
  >
  > This commit broke my app. It is too big for me to find a bug in there. 
  >  The app in question is available here: 
https://github.com/lemourin/libcloudstorage/blob/master/bin/cloudbrowser/qml/main.qml
  
  
  when things break, pleast scream to me :) (and in general, bug report + note 
it on the chat is useful)
  
  I've tried to build that app, tough cloudbrowser doesn't seem to be 
built/installed (if i run make in the cloudbrowser folder it says:
  
  GEN  src/CloudContext.moc.cpp
  /bin/sh: -o: command not found
  
  what should i look into to have it built/working?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20846: [Task Manager] Don't show redundant "Actions" header in context menu with nothing but actions in it

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Previously, the Actions header was always shown, even when the context menu
  consisted of nothing but actions. This is unnecessary since a menu's normal 
state is
  to show nothing but actions.
  
  With this patch, the Actions header is only shown for context menus that have
  more than one section.

TEST PLAN
  Context menu with only actions: F6795048: All actions.png 

  
  Context menu with nore than just actions: F6795049: More than just 
actions.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-show-redundant-action-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20846

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20576: Add new notifications KCM

[Kai Uwe Broulik]

broulik updated this revision to Diff 57047.
broulik added a comment.


  - Drop remove feature for seen apps. They shouldn't really pile up, as 
discussed with VDG
  - Some cleanup

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20576?vs=56304&id=57047

REVISION DETAIL
  https://phabricator.kde.org/D20576

AFFECTED FILES
  CMakeLists.txt
  kcms/CMakeLists.txt
  kcms/notifications/CMakeLists.txt
  kcms/notifications/Messages.sh
  kcms/notifications/filterproxymodel.cpp
  kcms/notifications/filterproxymodel.h
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/kcm_notifications.desktop
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/ScreenPositionSelector.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/package/metadata.desktop
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: broulik, #plasma, #vdg
Cc: mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D18645: BasicListItem: use specified tint color when transparency is 0

[Paweł Wegner]

pwegner added a comment.


  
https://github.com/KDE/kirigami/commit/c0f2a341a4c9e947cbb2ca914ba36a31728b05c4
  
  This commit broke my app. It is too big for me to find a bug in there. 
  The app in question is available here: 
https://github.com/lemourin/libcloudstorage/blob/master/bin/cloudbrowser/qml/main.qml
  
  After this commit pages and toolbar don't appear at all; the only thing 
that's working is the drawer.
  
  For now I'm sticking with my fork 
https://github.com/lemourin/kirigami/commits/master which basically means that
  I can't answer your question.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20804: RFC: Try getting the X keyboard grab multiple times

[Vlad Zagorodniy]

zzag added a comment.


  > Wrote relevant matching kwin patch to close effects
  
  Have you uploaded it? :-)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20804

To: davidedmundson, #plasma, #kwin
Cc: zzag, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Björn Feber]

GB_2 updated this revision to Diff 57040.
GB_2 added a comment.


  Move Minimize All too, so there is an alternative

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20818?vs=56973&id=57040

BRANCH
  arcpatch-D20818

REVISION DETAIL
  https://phabricator.kde.org/D20818

AFFECTED FILES
  applets/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/Messages.sh
  applets/minimizeall/package/contents/config/main.xml
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

[Björn Feber]

GB_2 updated this revision to Diff 57039.
GB_2 added a comment.


  Move Minimize All too, so there is an alternative

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20817?vs=56972&id=57039

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20817

AFFECTED FILES
  applets/CMakeLists.txt
  applets/minimizeall/CMakeLists.txt
  applets/minimizeall/Messages.sh
  applets/minimizeall/package/contents/config/main.xml
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/showdesktop/CMakeLists.txt
  applets/showdesktop/Messages.sh
  applets/showdesktop/package/contents/config/main.xml
  applets/showdesktop/package/contents/ui/main.qml
  applets/showdesktop/package/metadata.desktop
  applets/showdesktop/plugin/qmldir
  applets/showdesktop/plugin/showdesktop.cpp
  applets/showdesktop/plugin/showdesktop.h
  applets/showdesktop/plugin/showdesktopplugin.cpp
  applets/showdesktop/plugin/showdesktopplugin.h

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  ok, let's delay this still for a while

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D20585

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

[Filip Fila]

filipf added a comment.


  @mart are you sure this is the right solution? From my tests the patch also 
adds extra spacing whenever there is an instance of `isSection`, but we'd only 
want it to do so when there is a separator present.
  
  Before:
  F6794817: Screenshot_20190426_133016.png 

  
  After:
  F6794819: Screenshot_20190426_133914.png 

  
  We can see in this example when there is no separator that extra (unwanted) 
spacing has been added.

REPOSITORY
  R169 Kirigami

BRANCH
  even-separator-spacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20585

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20819: Make really sure we show an error message in case saving failed

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:6ae424de5d13: Make really sure we show an error message 
in case saving failed (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20819?vs=57019&id=57022

REVISION DETAIL
  https://phabricator.kde.org/D20819

AFFECTED FILES
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18645: BasicListItem: use specified tint color when transparency is 0

[Marco Martin]

mart added a comment.


  so, now the decision when to color an icon and when not should be a bit 
smarter...
  
  is this still necessary?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D20835: fix formatting in android build instructions

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4f2293bd2e93: fix formatting in android build 
instructions (authored by neroburner, committed by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20835?vs=57004&id=57020

REVISION DETAIL
  https://phabricator.kde.org/D20835

AFFECTED FILES
  README.md

To: neroburner, apol
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D20835: fix formatting in android build instructions

[Nero Burner]

neroburner added a comment.


  In D20835#456484 , @apol wrote:
  
  > Can you land the patch or should we do it for you?
  
  
  please do it for me. It is my first interaction with Phabricator and I have 
no idea how to land  the patch.
  
  I'm hoping the migration to gitlab (https://invent.kde.org/kde) happens soon, 
as I'm more familiar with gitlabs workflow

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D20835

To: neroburner, apol
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D20819: Make really sure we show an error message in case saving failed

[Kai Uwe Broulik]

broulik updated this revision to Diff 57019.
broulik added a comment.


  - Show `error`, if any

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20819?vs=56975&id=57019

REVISION DETAIL
  https://phabricator.kde.org/D20819

AFFECTED FILES
  extension/options.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20810: Fix launcher URL comparison

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b6b008bbf0ec: Fix launcher URL comparison (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20810?vs=56961&id=57017

REVISION DETAIL
  https://phabricator.kde.org/D20810

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein, ngraham, mlaurent, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D20835: fix formatting in android build instructions

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Can you land the patch or should we do it for you?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D20835

To: neroburner, apol
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

[Björn Feber]

GB_2 added a comment.


  Does that mean I can land it?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-showdesktop-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20818

To: GB_2, #plasma, #vdg, ngraham, apol
Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart