D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce added a comment.


  In D20930#459505 , @ngraham wrote:
  
  > When #VDG  assistance is requested, 
screenshots of the current/proposed UI are appreciated. :)
  
  
  F6804483: PeersDialog.png 
  In the dialog shown, there can be several different "Peers" defined. The 
question involves the use of the SpinBox as the means of switching between the 
various entries. Each Peer has the same set of parameters to display/modify and 
changing the SpinBox value changes which one of them is being currently 
displayed. The "Add" and "Remove" buttons add a new Peer or delete an existing 
Peer and change the "of x peers" label next to the SpinBox to correspond to the 
current total number.
  
  I have not seen this exact method of changing a dialog before and while it 
seems intuitive to me, I don't know if it violates any KDE standards and I 
think both jgrulich and I just wanted to get input from the VDG before this is 
released.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce marked 12 inline comments as done.
andersonbruce added a comment.


  Requested changes are made.

INLINE COMMENTS

> jgrulich wrote in connectionicon.cpp:403
> Do you want me to add this to NMQT?

Yes, please. This is part of the device type enum we discussed earlier where 
not all of the values defined in NM have been folded into NMQT yet.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce updated this revision to Diff 57434.
andersonbruce marked an inline comment as done.
andersonbruce added a comment.


  - Correct review comment

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57433&id=57434

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerswidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerswidget.cpp
  libs/editor/settings/wireguardpeerswidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Bruce Anderson]

andersonbruce updated this revision to Diff 57433.
andersonbruce added a comment.


  - Correct CamelCase of Wireguard to WireGuard
  - Disable adding WireGuard for NetworkManager < 1.16
  - Correct review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20930?vs=57297&id=57433

BRANCH
  TwoTabs

REVISION DETAIL
  https://phabricator.kde.org/D20930

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp
  kcm/qml/ConnectionItem.qml
  kded/notification.cpp
  kded/secretagent.cpp
  libs/declarative/connectionicon.cpp
  libs/declarative/networkstatus.cpp
  libs/declarative/networkstatus.h
  libs/editor/CMakeLists.txt
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ui/wireguardinterfacewidget.ui
  libs/editor/settings/ui/wireguardpeerswidget.ui
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardinterfacewidget.h
  libs/editor/settings/wireguardpeerswidget.cpp
  libs/editor/settings/wireguardpeerswidget.h
  libs/editor/wireguardkeyvalidator.cpp
  libs/editor/wireguardkeyvalidator.h
  libs/models/creatableconnectionsmodel.cpp
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  libs/uiutils.h
  vpn/CMakeLists.txt
  vpn/wireguard/CMakeLists.txt
  vpn/wireguard/Messages.sh
  vpn/wireguard/nm-wireguard-service.h
  vpn/wireguard/plasmanetworkmanagement_wireguardui.desktop
  vpn/wireguard/wireguard.cpp
  vpn/wireguard/wireguard.h
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardadvanced.ui
  vpn/wireguard/wireguardadvancedwidget.cpp
  vpn/wireguard/wireguardadvancedwidget.h
  vpn/wireguard/wireguardauth.cpp
  vpn/wireguard/wireguardauth.h
  vpn/wireguard/wireguardauth.ui
  vpn/wireguard/wireguardkeyvalidator.cpp
  vpn/wireguard/wireguardkeyvalidator.h
  vpn/wireguard/wireguardwidget.cpp
  vpn/wireguard/wireguardwidget.h

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf added a comment.


  F6804361: image.png 
  
  When `anchors.margins` is removed we see that the ToolButton still has 1px of 
its own margin around it, which might be that +1 that adds up to 8. The 
separator has on the other hand now even eaten into the search field's border.
  
  I think the best solution would be if the separator was left anchored to 
parent.right. That's not working out however, but we could still compensate 
with a right margin.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20973: [Kickoff] Use simpler code for separator color

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:935f33387437: [Kickoff] Use simpler code for separator 
color (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20973?vs=57411&id=57422

REVISION DETAIL
  https://phabricator.kde.org/D20973

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20973: [Kickoff] Use simpler code for separator color

[Filip Fila]

filipf added a comment.


  In D20973#459842 , @ngraham wrote:
  
  > Yeah, much saner. Nice! I recall copy-pasting this code from elsewhere so 
you might wanna have look-see to check whether there are other uses of this 
that can be simplified as well.
  
  
  I think it was taken from Kirigami's separator. I probably shouldn't mess 
with its color since it might be fine tuned to match the borders of other QQC2 
elements etc. or might also be fine tuned to match Breeze menu border colors.
  
  From a practical POV not even Kvantum can make QML windows transparent so 
there wouldn't be the same problem with the Kirigami separator as here.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-simpler-color-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20973

To: filipf, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20576: Add new notifications KCM

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ApplicationConfiguration.qml:103
> +Item {
> +width: Kirigami.Units.gridUnit
> +}

you shouldn't specify a width inside a layout.

> SourcesPage.qml:35
> +Component.onCompleted: {
> +// TODO the page is push'd in Qt.callLater, why is the model still 
> not loaded when we get here?
> +Qt.callLater(function() {

The kcm.filteredModel?

> SourcesPage.qml:60
> +// and then use a proxy model to filter it. We don't get any QML change 
> signals anywhere
> +// and ListView needs a currentIndex number
> +Connections {

Can you talk me through all this:

We have a listview with a filtered model with a selected item
We change the filter

As long as the proxies are working correctly and track a movement as a 
movement, the currentIndex of the listview should adjust.

What does happen?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20576

To: broulik, #plasma, #vdg
Cc: davidedmundson, mart, ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf added a comment.


  In D20972#459893 , @davidedmundson 
wrote:
  
  > I think the problem is the  icon within the toolbutton is relatively small 
making it look like a bigger left margin
  
  
  That definitely plays a big role here perception-wise, but IMO we should just 
focus on the icon frame.
  
  After zooming in and counting the pixels I think it's partly due to the 
separator stealing the width.
  
  F6804315: image.png 
  
  At 1.5 scaling that's 8 pixels between the icon frame and search field frame.
  
  F6804317: image.png 
  
  5 pixels between the search frame and separator + 2 pixels separator width, 
which leaves a pixel unaccounted for however.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Nathaniel Graham]

ngraham added a comment.


  Maybe we could make it a pushbutton rather than a toolbutton.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[David Edmundson]

davidedmundson added a comment.


  I think the problem is the  icon within the toolbutton is relatively small 
making it look like a bigger left margin

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf added a comment.


  Yeah it should have already been looking as desired pre-patch, I noticed the 
same. You're right, I'll try to find the right fix.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20969: [potd] Modernize configuration settings

[Filip Fila]

filipf added a comment.


  
  
  In D20969#459871 , @davidedmundson 
wrote:
  
  > If you upload without the combobox changes, I'll be happy to click ship it.
  
  
  The problem though I've run into with having QQC1 Combobox in the Form Layout 
is all the code that was used to fix its width stops working:
  
property int textLength: 24
width: theme.mSize(theme.defaultFont).width * textLength
  
  And then we get quite narrow, elided comboboxes which don't match the height 
of the QQC2 comboxes from ConfigurationContainmentAppearance.qml. Will 
investigate if I can write some new code to hack the width, though my rationale 
here was that the QQC2 combobox was the lesser evil.
  
  In D20969#459851 , @ngraham wrote:
  
  > If it's not getting set on load, the problem is probably somewhere in those 
funky for loops to get and set the value of the combobox.
  
  
  Hah yeah, possibly, although it works just fine with the QQC1 Combobox.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20969

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20969: [potd] Modernize configuration settings

[David Edmundson]

davidedmundson added a comment.


  If you upload without the combobox changes, I'll be happy to click ship it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20969

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  This doesn't add up.
  
  "searchLayout" fills the width with a smallSpacing all the way round.
  The toolButton has no padding to the left.
  Therefore actionTextField shouldn't have something to the right.
  
  If something does needs fixing, it needs fixing somewhere else.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20969: [potd] Modernize configuration settings

[Nathaniel Graham]

ngraham added a comment.


  If it's not getting set on load, the problem is probably somewhere in those 
funky for loops to get and set the value of the combobox.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20969

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20973: [Kickoff] Use simpler code for separator color

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, much saner. Nice! I recall copy-pasting this code from elsewhere so you 
might wanna have look-see to check whether there are other uses of this that 
can be simplified as well.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-simpler-color-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20973

To: filipf, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20973: [Kickoff] Use simple code for separator color

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The somewhat complex code for separator color in Kickoff creates issues with 
transparent themes. Separators can become barely visible, defeating the purpose 
of adding them. Relying on text color on the other hand is a safe bet so ensure 
visibility.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-simpler-color-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20973

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf updated this revision to Diff 57408.
filipf added a comment.


  units.smallSpacing -> Kirigami.Units.smallSpacing

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20972?vs=57407&id=57408

BRANCH
  sidebarview-padding-nitpick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20972

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: filipf, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf updated this revision to Diff 57407.
filipf added a comment.


  fix mistype

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20972?vs=57406&id=57407

BRANCH
  sidebarview-padding-nitpick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20972

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The category search field is too close to the right separator so this patch 
gives it a small right margin.

REPOSITORY
  R124 System Settings

BRANCH
  sidebarview-padding-nitpick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20972

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20969: [potd] Modernize configuration settings

[Filip Fila]

filipf added a comment.


  Combobox popup width is still not fixed though, I have to comment on the bug 
report.
  
  F6804103: image.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20969

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20969: [potd] Modernize configuration settings

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  - port from QQC1 to QQC2
  - replace ColumnLayout with Kirigami.FormLayout
  - make use of twinFormLayouts
  
  NOTE: On initial loading I get a blank providers comobobox, but after 
selecting an option it's OK.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-potd-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20969

AFFECTED FILES
  wallpapers/potd/contents/ui/config.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20965: [color-wallpaper] Interlink child and parent form layout

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a1903620f0f0: [color-wallpaper] Interlink child and 
parent form layout (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20965?vs=57386&id=57396

REVISION DETAIL
  https://phabricator.kde.org/D20965

AFFECTED FILES
  wallpapers/color/contents/ui/config.qml

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18394: Add OTP support for openconnect VPN

[Enrique Melendez]

enriquem updated this revision to Diff 57394.
enriquem added a comment.


  I addressed your comments. Sorry for the careless coding in what spaces are 
concerned. BTW, I added a missing QStringLiteral.
  
  I believe the combobox size constraints are fixed now (although I liked it 
better before).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18394?vs=57294&id=57394

REVISION DETAIL
  https://phabricator.kde.org/D18394

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/nm-openconnect-service.h
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauth.h
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectauthworkerthread.h
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/openconnectwidget.h

To: enriquem, jgrulich
Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20965: [color-wallpaper] Interlink child and parent form layout

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yepp.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  interlink-master-and-child-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20965

To: filipf, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16997: [kcm] Expose interface to control output property retention

[Nathaniel Graham]

ngraham added a comment.


  @romangg and I talked and now I understand the feature and think it's a good 
idea. It needs to be exposed to the user in a way that's immediately apparent 
though. Here's my recommendation
  
  1. Default to global settings
  2. When there is only configuration data for one screen arrangement (i.e. 
because the user has never plugged in another display), don't show the 
global/per-arrangement configuration UI
  3. When there //are// multiple display arrangements because the user has 
plugged in another display at some point, display the following UI at the 
bottom of the FormLayout which allows the user to choose between global and 
per-arrangement settings:
  
  
  
Save settings: (o) For all display arrangements that use this screen
   ( ) Only for the current display arrangement

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D16997

To: romangg, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20965: [color-wallpaper] Interlink child and parent form layout

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Should in some odd case (language) the color wallpaper's "Color:" label be 
longer than "Layout:" or "Wallpaper Type:" we can ensure the alignment between 
parent and child layout will not be broken.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  interlink-master-and-child-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20965

AFFECTED FILES
  wallpapers/color/contents/ui/config.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 84 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 02 May 2019 14:19:38 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.discover Failed: 9 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.discover.autotests.appargFailed: projectroot.discover.autotests.appstreamUrlFailed: projectroot.discover.autotests.categoryargFailed: projectroot.discover.autotests.installFailed: projectroot.discover.autotests.missingResourceFailed: projectroot.discover.autotests.packageArgumentFailed: projectroot.discover.autotests.toplevelsFailed: projectroot.discover.autotests.updateandinstallFailed: projectroot.discover.autotests.wrongInputName: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.libdiscover.backends.DummyBackend.tests.dummytestFailed: projectroot.libdiscover.backends.DummyBackend.tests.updatedummytestName: projectroot.libdiscover.backends.KNSBackend Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.libdiscover.backends.KNSBackend.tests.knsbackendtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report56%
(10/18)51%
(53/103)51%
(53/103)35%
(1956/5652)25%
(898/3624)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover92%
(11/12)92%
(11/12)60%
(464/779)39%
(179/454)discover.autotests100%
(1/1)100%
(1/1)100%
(92/92)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover33%
(2/6)33%
(2/6)29%
(71/243)33%
(61/183)libdiscover.Category100%
(5/5)100%
(5/5)61%
(148/242)46%
(105/230)libdiscover.ReviewsBackend43%
(3/7)43%
(3/7)29%
(64/217)29%
(21/72)libdiscover.Transaction50%
(4/8)50%
(4/8)15%
(42/286)10%
(15/144)libdiscover.UpdateModel100%
(3/3)100%
(3/3)63%
(148/236)48%
(60/125)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/203)0%
(0/84)libdiscover.backends.DummyBackend55%
(6/11)55%
(6/11)49%
(149/305)40%
(65/162)libdiscover.backends.DummyBackend.tests0%
(0/2)0%
(0/2)0%
(0/257)0%
(0/268)libdiscover.backends.FwupdBackend0%
(0/8)0%
(0/8)0%
(0/541)0%
(0/255)libdiscover.backends.KNSBackend0%
(0/5)0%
(0/5)0%
(0/556)0%
  

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/83/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 02 May 2019 14:16:48 +
 Build duration:
1 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 439 lines...][2019-05-02T14:17:45.502Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2019-05-02T14:17:45.502Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2019-05-02T14:17:45.502Z] Found property definition "NoDisplay" with type "bool"[2019-05-02T14:17:45.502Z] Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to string[2019-05-02T14:17:45.502Z] Unknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to string[2019-05-02T14:17:45.502Z] Generated  "/home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [2019-05-02T14:17:45.502Z] [2019-05-02T14:17:45.502Z] [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[2019-05-02T14:17:45.761Z] [  4%] Built target DiscoverNotifiers_autogen[2019-05-02T14:17:45.761Z] Scanning dependencies of target DiscoverNotifiers[2019-05-02T14:17:45.761Z] [  4%] Built target PaginateModelTest_autogen[2019-05-02T14:17:45.761Z] [  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[2019-05-02T14:17:45.761Z] [  6%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[2019-05-02T14:17:45.761Z] Scanning dependencies of target PaginateModelTest[2019-05-02T14:17:45.761Z] [  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[2019-05-02T14:17:45.761Z] [  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[2019-05-02T14:17:45.761Z] [  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[2019-05-02T14:17:45.761Z] [ 10%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[2019-05-02T14:17:45.762Z] [ 11%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/discover_debug.cpp.o[2019-05-02T14:17:45.762Z] [ 11%] Built target DiscoverCommon_autogen[2019-05-02T14:17:46.020Z] Scanning dependencies of target DiscoverCommon[2019-05-02T14:17:46.020Z] [ 11%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[2019-05-02T14:17:46.020Z] [ 12%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[2019-05-02T14:17:46.610Z] [ 13%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[2019-05-02T14:17:46.610Z] [ 14%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[2019-05-02T14:17:46.610Z] [ 14%] Linking CXX shared library ../../bin/libDiscoverNotifiers.so[2019-05-02T14:17:46.610Z] [ 15%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[2019-05-02T14:17:46.868Z] [ 15%] Built target DiscoverNotifiers[2019-05-02T14:17:46.868Z] [ 16%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[2019-05-02T14:17:47.131Z] Scanning dependencies of target DummyNotifier_autogen[2019-05-02T14:17:47.131Z] Scanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[2019-05-02T14:17:47.131Z] [ 16%] Automatic MOC for target DummyNotifier[2019-05-02T14:17:47.131Z] [ 17%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[2019-05-02T14:17:47.131Z] [ 17%] Built target DummyNotifier_autogen[2019-05-02T14:17:47.131Z] [ 18%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[2019-05-02T14:17:47.131Z] [ 18%] Built target DiscoverNotifierDeclarativePlugin_autogen[2019-05-02T14:17:47.131Z] Scanning dependencies of target DummyNotifier[2019-05-02T14:17:47.409Z] [ 19%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[2019-05-02T14:17:47.409Z] [ 19%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[2019-05-02T14:17:47.676Z] [ 20%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[2019-05-02T14:17:47.676Z] In file included from /usr/include/qt5/QtCore/QtCore:4,[2019-05-02T14:17:47.676Z]  from /usr/include/qt5/QtGui/QtGuiDepends:3,[2019-05-02T14:17:47.676Z]  from /usr/include/qt5/QtGui/QtGui:3,[2019-05-02T14:17:47.676Z]  from /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/libdiscover/tests/modeltest.cpp:43:[2019-05-02T14:17:47.676Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/libdiscover/t

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  When #VDG  assistance is requested, 
screenshots of the current/proposed UI are appreciated. :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20930: Update WireGuard to match NetworkManager 1.16 interface

[Jan Grulich]

jgrulich added a subscriber: ngraham.
jgrulich added a comment.


  Can we maybe have some assistence from anyone from VDG? @ngraham maybe?

INLINE COMMENTS

> CMakeLists.txt:11
>  
> +set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -g")
> +

Please remove.

> kcm.cpp:264
>  NetworkManager::ConnectionSettings::ConnectionType type = 
> static_cast(connectionType);
> -
> +qCWarning(PLASMA_NM) << "onRequestCreateConnection type: " << type;
>  if (type == NetworkManager::ConnectionSettings::Vpn && vpnType == 
> "imported") {

Please remove.

> connectionicon.cpp:403
>  }
> +} else if (type == 29) {  // TODO change to WireGuard enum 
> value once it is added
> +// WireGuard is a VPN but is not implemented

Do you want me to add this to NMQT?

> connectioneditorbase.cpp:151
>  }
> -
> +#if 1
> +qCWarning(PLASMA_NM) << "ConnectionEditorBase: Before toMap";

Please remove

> connectioneditorbase.cpp:198
>  
> +qCWarning(PLASMA_NM) << "ConnectionEditorBase:" << m_connection->id();
> +

Please remove.

> connectioneditorbase.cpp:264
>  if (!vpnSetting) {
> -qCWarning(PLASMA_NM) << "Missing VPN setting!";
> +qCWarning(PLASMA_NM) << "Missing VPN setting 2!";
>  } else {

Why the "2" at the end?

> connectioneditorbase.cpp:458
>  for (const QString &key : secrets.keys()) {
> +qCWarning(PLASMA_NM) << "replyFinished key: " << key << "  
> settingName: " << settingName;
>  if (key == settingName) {

Please remove.

> connectioneditorbase.cpp:465
>  const QString type = widget->type();
> +qCWarning(PLASMA_NM) << "type: " << type << "   settingName: " << 
> settingName;
>  if (type == settingName ||

Please remove.

> wireguardinterfacewidget.cpp:114
> +WireGuardInterfaceWidget::WireGuardInterfaceWidget(const 
> NetworkManager::Setting::Ptr &setting, QWidget* parent, Qt::WindowFlags f):
> +SettingWidget(setting, parent, f),
> +d(new Private)

Coding style.

Should be:

  WireGuardInterfaceWidget::WireGuardInterfaceWidget(const 
NetworkManager::Setting::Ptr &setting, QWidget* parent, Qt::WindowFlags f)
  : SettingWidget(setting, parent, f)
  , d(new Private)

> wireguardinterfacewidget.cpp:182
> +
> +if (0 != wireGuardSetting->listenPort())
> +
> d->ui.listenPortLineEdit->setText(QString::number(wireGuardSetting->listenPort()));

I would preffer:

  if (wireGuardSetting->listenPort() != 0)

It's more readable. Same for code below.

> wireguardinterfacewidget.cpp:250
> +{
> +
> +NetworkManager::WireGuardSetting wgSetting;

Remove empty line

> wireguardinterfacewidget.cpp:424
> +
> +else if (keyValue[0] == PNM_WG_CONF_TAG_PEER) {
> +// Check to make sure the previous PEER section has

Coding style. The "else if" should be on the same line as the "}" bracket.

> wireguardinterfacewidget.cpp:482
> +// Listen Port
> +else if (key == PNM_WG_CONF_TAG_LISTEN_PORT) {
> +uint val = keyValue[1].toUInt();

Same here and below.

> wireguardinterfacewidget.cpp:568
> +else if (currentState == PEER_SECTION)
> +{
> +// Public Key

The "{" bracket should be on the same line as the "else if". Same below.

> wireguardinterfacewidget.cpp:633
> +peers.append(*currentPeer);
> +#endif
> +#if 1

Please remove

> wireguardpeerswidget.cpp:82
> +
> +WireGuardPeersWidget::WireGuardPeersWidget(const NMVariantMapList& peerData, 
> QWidget* parent, Qt::WindowFlags f):
> +QDialog(parent, f),

Coding style.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20265: Introduce libnotificationmanager

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> jobsmodel.cpp:215
> +{
> +if (!idx.isValid() || idx.row() >= d->m_jobViews.count()) {
> +return;

https://doc.qt.io/qt-5/qabstractitemmodel.html#checkIndex

> jobsmodel_p.cpp:358
> +
> +for (int i = 0; i < m_jobViews.count(); ++i) {
> +Job *job = m_jobViews.at(i);

you're not filtering the jobs based on the desktopEntry

every app gets notified about anyones percentage?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20894: Remove unused files

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:bf4a7e45de8f: Remove unused files (authored by broulik).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20894?vs=57170&id=57377

REVISION DETAIL
  https://phabricator.kde.org/D20894

AFFECTED FILES
  sidebar/CMakeLists.txt
  sidebar/CategorizedView.cpp
  sidebar/CategorizedView.h
  sidebar/CategoryDrawer.cpp
  sidebar/CategoryDrawer.h
  sidebar/SidebarDelegate.cpp
  sidebar/SidebarDelegate.h
  sidebar/SidebarMode.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.16 Beta release in 2 weeks

[Kai Uwe Broulik]

Am 02.05.19 um 14:29 schrieb Jonathan Riddell:

please make sure to have any features in by then.


Friendly reminder there's still a tonne of notification code to be 
reviewed :(


https://phabricator.kde.org/D20265

Also check out branch broulik/libnotificationmanager of plasma-workspace 
for a complete workable set.


Thanks

Plasma 5.16 Beta release in 2 weeks

[Jonathan Riddell]

Our 5.16 Beta release is in 2 weeks on Thu 16 May.  This will freeze
development for new features, please make sure to have any features in by
then.  There will then be three weeks before the final tars are made and 5
days for packagers to package those with a .0 release on Tue June 11.

Please look over the workboard to see what items you have done and update
the status there.
https://phabricator.kde.org/project/view/35/

Please add new features to this shared etherpad so we can turn it into an
announce in time for beta.
https://notes.kde.org/p/plasma_5_16
Also ideas for headlines would be great.  For 5.15 it was
embracing Usability & Productivity goal and headline was Lightweight,
Usable and Productive.  If nobody comes up with ideas I'll use
https://inspirobot.me/ for it instead, you have been warned.

The promo team is coordinating a wallpaper contest which is not expected to
complete until after beta. https://phabricator.kde.org/T10875

Happy hacking

Jonathan

Plasm 5.16 Repo Freeze

[Jonathan Riddell]

Repo Freeze is today, if you have any new git repositories you want made
into Plasma 5.16 please tell me pronto.

The list from 5.15 which I expect to carry into 5.16 unchanged is

bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi
kactivitymanagerd kde-cli-tools kdecoration kde-gtk-config kdeplasma-addons
kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass
ksysguard kwallet-pam kwayland-integration kwin kwrited libkscreen
libksysguard milou oxygen plasma-browser-integration plasma-desktop
plasma-integration plasma-nm plasma-pa plasma-sdk plasma-tests plasma-vault
plasma-workspace plasma-workspace-wallpapers plymouth-kcm
polkit-kde-agent-1 powerdevil sddm-kcm systemsettings user-manager
xdg-desktop-portal-kde

Jonathan

D18394: Add OTP support for openconnect VPN

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Just fix those minor issues, otherwise it looks good to me, I'll verify on 
Monday, but I believe it's safe to push this.

INLINE COMMENTS

> openconnectauth.cpp:287
> +ret = __openconnect_set_token_mode(d->vpninfo, 
> OC_TOKEN_MODE_STOKEN, tokenSecret);
> +} else if (d->tokenMode ==QStringLiteral("stokenrc")) {
> +ret = __openconnect_set_token_mode(d->vpninfo, 
> OC_TOKEN_MODE_STOKEN, NULL);

Missing space after "==".

> openconnectauth.cpp:293
> +#if OPENCONNECT_CHECK_VER(3,4)
> +else if (d->tokenMode ==  QStringLiteral("hotp") && 
> !tokenSecret.isEmpty()) {
> +ret = __openconnect_set_token_mode(d->vpninfo, 
> OC_TOKEN_MODE_HOTP, tokenSecret);

And here is one additional space after "=="

> openconnecttoken.ui:36
> +
> + QComboBox::AdjustToContents
> +

I think this combobox should be expanded across whole width.

> openconnectwidget.cpp:132
> +d->tokenUi.leTokenSecret->setToolTip("Insert the secret here, with a 
> sha specification and a leading '0x' or 'base32:'. See the openconnect 
> documentation for syntax.");
> +} else if (mode ==QStringLiteral("hotp")) {
> +d->tokenUi.leTokenSecret->setEnabled(true);

Missing space after "=="

REVISION DETAIL
  https://phabricator.kde.org/D18394

To: enriquem, jgrulich
Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 6 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 02 May 2019 08:45:03 +
 Build duration:
4 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.idletime.idleTest_kwayland_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/8)0%
(0/8)0%
(0/723)0%
(0/459)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.idletime0%
(0/1)0%
(0/1)0%
(0/50)0%
(0/48)src.idletime0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/56)src.windowsystem0%
(0/5)0%
(0/5)0%
(0/570)0%
(0/355)

D20951: Track surface creation/destruction inside wayland window effects

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R130:0a0c3f23fce2: Track surface creation/destruction inside 
wayland window effects (authored by davidedmundson).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20951?vs=57353&id=57364

REVISION DETAIL
  https://phabricator.kde.org/D20951

AFFECTED FILES
  src/windowsystem/windoweffects.cpp
  src/windowsystem/windoweffects.h

To: davidedmundson, #kwin, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.12 - Build # 96 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.12/96/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 02 May 2019 08:16:33 +
 Build duration:
6 min 13 sec and counting
   CONSOLE OUTPUT
  [...truncated 1139 lines...][2019-05-02T08:22:42.938Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.cpp:90:17: warning: 'locationChanged' is deprecated [-Wdeprecated-declarations][2019-05-02T08:22:42.938Z] emit q->locationChanged(location());[2019-05-02T08:22:42.938Z] ^[2019-05-02T08:22:42.938Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.h:114:5: note: 'locationChanged' has been explicitly marked deprecated here[2019-05-02T08:22:42.938Z] PLASMA_DEPRECATED void locationChanged(Plasma::Types::Location location);[2019-05-02T08:22:42.938Z] ^[2019-05-02T08:22:42.938Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-05-02T08:22:42.938Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.cpp:93:17: warning: 'formFactorChanged' is deprecated [-Wdeprecated-declarations][2019-05-02T08:22:42.939Z] emit q->formFactorChanged(formFactor());[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.h:119:5: note: 'formFactorChanged' has been explicitly marked deprecated here[2019-05-02T08:22:42.939Z] PLASMA_DEPRECATED void formFactorChanged(Plasma::Types::FormFactor formFactor);[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-05-02T08:22:42.939Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.cpp:96:13: warning: 'containmentChanged' is deprecated [-Wdeprecated-declarations][2019-05-02T08:22:42.939Z] emit q->containmentChanged();[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.h:124:5: note: 'containmentChanged' has been explicitly marked deprecated here[2019-05-02T08:22:42.939Z] PLASMA_DEPRECATED void containmentChanged();[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-05-02T08:22:42.939Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.cpp:101:36: warning: 'locationChanged' is deprecated [-Wdeprecated-declarations][2019-05-02T08:22:42.939Z]  q, &View::locationChanged);[2019-05-02T08:22:42.939Z]^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.h:114:5: note: 'locationChanged' has been explicitly marked deprecated here[2019-05-02T08:22:42.939Z] PLASMA_DEPRECATED void locationChanged(Plasma::Types::Location location);[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/plasma_export.h:25:45: note: expanded from macro 'PLASMA_DEPRECATED'[2019-05-02T08:22:42.939Z] #  define PLASMA_DEPRECATED __attribute__ ((__deprecated__))[2019-05-02T08:22:42.939Z] ^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.cpp:103:36: warning: 'formFactorChanged' is deprecated [-Wdeprecated-declarations][2019-05-02T08:22:42.939Z]  q, &View::formFactorChanged);[2019-05-02T08:22:42.939Z]^[2019-05-02T08:22:42.939Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasmaquick/view.h:119:5: note: 'formFactorChanged' has been explicitly marked deprecated here[2019-05-0

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 02 May 2019 08:14:57 +
 Build duration:
1 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 273 lines...][2019-05-02T08:15:44.652Z] BUILD_ID  = '5'[2019-05-02T08:15:44.652Z] LESSKEY   = '/etc/lesskey.bin'[2019-05-02T08:15:44.652Z] OLDPWD= '/home/jenkins'[2019-05-02T08:15:44.652Z] LC_CTYPE  = 'C.UTF-8'[2019-05-02T08:15:44.652Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-05-02T08:15:44.652Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-05-02T08:15:44.652Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-05-02T08:15:44.652Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-05-02T08:15:44.652Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-05-02T08:15:44.652Z] QT_SELECT = 'qt5'[2019-05-02T08:15:44.652Z] LANG  = 'en_US.UTF-8'[2019-05-02T08:15:44.652Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-05-02T08:15:44.652Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-05-02T08:15:44.652Z] [2019-05-02T08:15:44.652Z] [2019-05-02T08:15:44.652Z] == Commencing Configuration:[2019-05-02T08:15:44.652Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12"[2019-05-02T08:15:44.910Z] -- The C compiler identification is GNU 8.3.1[2019-05-02T08:15:45.841Z] -- The CXX compiler identification is GNU 8.3.1[2019-05-02T08:15:45.841Z] -- Check for working C compiler: /usr/bin/cc[2019-05-02T08:15:45.841Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-05-02T08:15:45.841Z] -- Detecting C compiler ABI info[2019-05-02T08:15:46.100Z] -- Detecting C compiler ABI info - done[2019-05-02T08:15:46.100Z] -- Detecting C compile features[2019-05-02T08:15:46.668Z] -- Detecting C compile features - done[2019-05-02T08:15:46.668Z] -- Check for working CXX compiler: /usr/bin/c++[2019-05-02T08:15:46.668Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-05-02T08:15:46.668Z] -- Detecting CXX compiler ABI info[2019-05-02T08:15:46.927Z] -- Detecting CXX compiler ABI info - done[2019-05-02T08:15:47.189Z] -- Detecting CXX compile features[2019-05-02T08:15:48.131Z] -- Detecting CXX compile features - done[2019-05-02T08:15:48.131Z] -- Looking for __GLIBC__[2019-05-02T08:15:48.394Z] -- Looking for __GLIBC__ - found[2019-05-02T08:15:48.394Z] -- Performing Test _OFFT_IS_64BIT[2019-05-02T08:15:48.654Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-05-02T08:15:48.654Z] -- Performing Test HAVE_DATE_TIME[2019-05-02T08:15:48.915Z] -- Performing Test HAVE_DATE_TIME - Success[2019-05-02T08:15:48.915Z] -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.58.0") [2019-05-02T08:15:48.915Z] -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.58.0") [2019-05-02T08:15:48.915Z] -- Found KF5: success (found suitable version "5.58.0", minimum required is "5.54.0") found components:  IdleTime WindowSystem [2019-05-02T08:15:48.915Z] -- The following REQUIRED packages have been found:[2019-05-02T08:15:48.915Z] [2019-05-02T08:15:48.915Z]  * ECM (required version >= 5.54.0)[2019-05-02T08:15:48.915Z]  * Qt5Gui (required version >= 5.12.2)[2019-05-02T08:15:48.915Z]  * Qt5Widgets[2019-05-02T08:15:48.915Z]  * Qt5Core[2019-05-02T08:15:48.915Z]  * KF5IdleTime (required version >= 5.54.0)[2019-05-02T08:15:48.915Z]  * KF5WindowSystem (required version >= 5.54.0)[2019-05-02T08:15:48.915Z]  * KF5 (required version >= 5.54.0)[2019-05-02T08:15:48.915Z]  * KF5Wayland[2019-05-02T08:15:48.915Z]  * Qt5Test[2019-05-02T08:15:48.915Z]  * Qt5[2019-05-02T08:15:48.915Z] [2019-05-02T08:15:48.915Z] -- Configuring done[2019-05-02T08:15:48.915Z] -- Generating done[2019-05-02T08:15:48.915Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/kwayland-integration/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-05-02T08:15:50.081Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kwayland-integration --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-05-02T08:15:50.338Z] Scanning dependencies of target KF5IdleTimeKWaylandPlugin_autogen[2019-05-02T08:15:50.338Z] [  5%] Automatic MOC for target KF5IdleTimeKWaylandPlugin[2019-05-

D20631: Support CriticalNotification window type

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R130:e2db5ce32d7b: Support CriticalNotification window type 
(authored by broulik).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20631?vs=56427&id=57360

REVISION DETAIL
  https://phabricator.kde.org/D20631

AFFECTED FILES
  src/windowsystem/windowinfo.cpp
  src/windowsystem/windowsystem.cpp

To: broulik, #kwin, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/3/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 02 May 2019 07:00:52 +
 Build duration:
3 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 379 lines...][2019-05-02T07:03:59.652Z] **[2019-05-02T07:03:59.652Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-05-02T07:03:59.652Z] ** Copyright (c) 2019 Microsoft Corporation[2019-05-02T07:03:59.652Z] **[2019-05-02T07:04:00.586Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-05-02T07:04:00.843Z] [2019-05-02T07:04:00.843Z] jom 1.1.2 - empower your cores[2019-05-02T07:04:00.843Z] [2019-05-02T07:04:00.843Z] jom: parallel job execution disabled for Makefile[2019-05-02T07:04:00.843Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2019-05-02T07:04:00.843Z] Scanning dependencies of target kdbgwin_autogen[2019-05-02T07:04:00.843Z] Scanning dependencies of target bugzillalibtest_autogen[2019-05-02T07:04:00.843Z] Scanning dependencies of target crashtest_autogen[2019-05-02T07:04:00.843Z] [  2%] Automatic MOC for target drkonqi_backtrace_parser[2019-05-02T07:04:01.103Z] [  4%] Automatic MOC for target crashtest[2019-05-02T07:04:01.103Z] [  4%] Built target crashtest_autogen[2019-05-02T07:04:01.103Z] [  1%] Automatic MOC for target kdbgwin[2019-05-02T07:04:01.103Z] [  4%] Built target kdbgwin_autogen[2019-05-02T07:04:01.103Z] Scanning dependencies of target kdbgwin[2019-05-02T07:04:01.103Z] [  7%] Built target drkonqi_backtrace_parser_autogen[2019-05-02T07:04:01.103Z] [  4%] Automatic MOC for target bugzillalibtest[2019-05-02T07:04:01.103Z] [  5%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/main.cpp.obj[2019-05-02T07:04:01.103Z] [  7%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/process.cpp.obj[2019-05-02T07:04:01.103Z] [  9%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/abstract_generator.cpp.obj[2019-05-02T07:04:01.103Z] [  9%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/callbacks.cpp.obj[2019-05-02T07:04:01.103Z] [ 11%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/__/drkonqi_debug.cpp.obj[2019-05-02T07:04:01.103Z] [ 10%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/outputters.cpp.obj[2019-05-02T07:04:01.103Z] [ 12%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/msvc_generator.cpp.obj[2019-05-02T07:04:01.103Z] [ 14%] Building CXX object src/kdbgwin/CMakeFiles/kdbgwin.dir/kdbgwin_autogen/mocs_compilation.cpp.obj[2019-05-02T07:04:01.103Z] main.cpp[2019-05-02T07:04:01.363Z] Scanning dependencies of target crashtest[2019-05-02T07:04:01.363Z] drkonqi_debug.cpp[2019-05-02T07:04:01.363Z] c:\ci\workspace\plasma\drkonqi\stable-kf5-qt5 windowsmsvcqt5.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-02T07:04:01.363Z] [ 14%] Built target bugzillalibtest_autogen[2019-05-02T07:04:01.363Z] [ 15%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.obj[2019-05-02T07:04:01.363Z] [ 16%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.obj[2019-05-02T07:04:01.363Z] Scanning dependencies of target drkonqi_backtrace_parser[2019-05-02T07:04:01.363Z] crashtest.cpp[2019-05-02T07:04:01.363Z] mocs_compilation.cpp[2019-05-02T07:04:01.363Z] [ 17%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.obj[2019-05-02T07:04:01.363Z] [ 18%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.obj[2019-05-02T07:04:01.363Z] [ 20%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.obj[2019-05-02T07:04:01.363Z] backtraceparser.cpp[2019-05-02T07:04:01.624Z] Scanning dependencies of target bugzillalibtest[2019-05-02T07:04:01.624Z] outputters.cpp[2019-05-02T07:04:01.624Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-02T07:04:01.624Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-02T07:04:01.624Z] abstract_generator.cpp[2019-05-02T07:04:01.624Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-02T07:04:01.624Z] process.cpp[2019-05-02T07:04:01.624Z] C:\CI\WORKSP~1\Plasma\drkonqi\STABLE~1.11\build\src\drkonqi_debug.h(6): fatal error C1083: Cannot open include file: 'QLoggingCategory': No such file or directory[2019-05-02T07:04:01.884Z] jom: C